Re: [DISCUSS] string normalization in black

2022-09-20 Thread Felix Uellendall
Totally for it! That’s not true actually. Black won’t reformat strings using f-string if you use single quotes for the string and double quotes within e.g. when passing a str.join statement as a value which uses double quotes. So you can still have a mixture of both in the codebase but it will

Re: [DISCUSS] string normalization in black

2022-09-20 Thread Daniel Standish
> > I'll weigh in on this most important of decisions :) OK but I must clear up one thing ... if we turn on string normalization, we do not get to choose single vs double -- with black, there is only one way, and it is double. Personally I have always liked single but yeah, I am in favor of

Re: [DISCUSS] string normalization in black

2022-09-20 Thread Ferruzzi, Dennis
I'll weigh in on this most important of decisions. I find myself wishing I had time to standardize string quotes when I am in files and not doing it because I don't want to complicate PRs with unnecessary/unrelated changes. So I'd be for this. I prefer single-quotes myself, but I'd

Re: [DISCUSS] string normalization in black

2022-09-20 Thread Jed Cunningham
I'd be in favor of turning it on. I tend to prefer double quotes, but I'd rather have it on and have single quotes. If we do get enough support for this, I'd like to wait until we are closer to 2.5 to reduce conflicts when cherry-picking for 2.4.x's.

Re: [ANNOUNCE] Apache Airflow 2.4.0 Released

2022-09-20 Thread Alexander Shorin
Great release! Thanks you all for dataset feature! But for this time I had to revert https://github.com/apache/airflow/commit/36eea1c8e0 change for our production since it completely broke the grid view for all our dags - it thought that the last dagrun was somewhere at 2021.11 dates while all

Re: [DISCUSS] string normalization in black

2022-09-20 Thread Kamil Breguła
This option has been used to limit the number of changes to files. https://github.com/apache/airflow/pull/9550#issuecomment-650971650 śr., 21 wrz 2022 o 02:32 Daniel Standish napisał(a): > Black, our python formatter, can "normalize" strings to prefer double > quotes, and we disable this

[DISCUSS] string normalization in black

2022-09-20 Thread Daniel Standish
Black, our python formatter, can "normalize" strings to prefer double quotes, and we disable this feature. I have always been a single quotes person unless using f-string and supported disabling normalization when we introduced black. But lately, black’s string normalization has seemed more

CVE-2022-40754: Apache Airflow: Open Redirect

2022-09-20 Thread Jedidiah Cunningham
Description: In Apache Airflow 2.3.0 through 2.3.4, there was an open redirect in the webserver's `/confirm` endpoint. Credit: The Apache Airflow PMC would like to thank Konstantin Weddige (Lutra Security) for reporting this issue. References: https://github.com/apache/airflow/pull/26409

CVE-2022-40604: Apache Airflow: Format String Vulnerability

2022-09-20 Thread Jedidiah Cunningham
Description: In Apache Airflow 2.3.0 through 2.3.4, part of a url was unnecessarily formatted, allowing for possible information extraction. Credit: The Apache Airflow PMC would like to thank L3yx of Syclover Security Team for reporting this issue. References: