+1 non-binding to starting the lazy consensus? :P
From: Daniel Standish
Sent: Wednesday, September 21, 2022 9:55 AM
To: dev@airflow.apache.org
Subject: RE: [EXTERNAL][DISCUSS] string normalization in black
CAUTION: This email originated from outside
>
> Opinion: Adding a lazy consensus thread will not hurt and I think it
> should happen
Sure, can do
>
Opinion: Adding a lazy consensus thread will not hurt and I think it
should happen - for the record and for people who might be busy.
I think it's easy to miss the fact that a decision was made in a [DISCUSS]
thread. That's the main purpose of the subject prefixes - to drag attention
for people
+1 for string normalization.
I love double quoted strings anyways :)
On Wed, 21 Sep 2022 at 16:46, Daniel Standish
wrote:
> OK seems like all are in favor. Do we even need a vote? I guess lazy
> consensus still applies even when you don't formally call for a lazy
> consensus vote. So I
OK seems like all are in favor. Do we even need a vote? I guess lazy
consensus still applies even when you don't formally call for a lazy
consensus vote. So I reckon I won't bother.
But the implementation to @Jed Cunningham 's point
we can wait until closer to 2.5. And I'll connect with
> Happy to adapt to any style as long as I don't even have to think about it
> and my personal preferences are not important here.
That.
On Sep 21 2022, at 12:45 pm, Jarek Potiuk wrote:
> Yeah! Heated discussions! Tabs vs. Spaces.
>
> I am also full in for consistency. I think where there are
Yeah! Heated discussions! Tabs vs. Spaces.
I am also full in for consistency. I think where there are no clear
arguments to do this or that, for me consistency trumps any individual
preference/style (especially when it is backed with automation that will
correct things for you and will not put
The formatting discussions are always the most heated ones :) I'm for
normalization - we have ugly mix of both and I'm down for whatever but to
be consistent. I wouldn't worry about git history or cherry picks. We had
several PRs recently that touched almost every file anyway (like improving
our
Correction in my previous email. pre-commit hook double-quote-string-fixer
too does not seem to work well for f-strings with a mix of double and
single quotes (meaning does not convert a f-string which has outer quotes
as double and inner quotes as single). It just skips it if the string is
like
Definitely in favor of more consistency. (Hoping it will not make things
too hard for people doing the cherry picking)
Best Regards,
Pierre
Le mer. 21 sept. 2022 à 08:35, Pankaj Koti
a écrit :
> I'm in for normalizing.
> Personally, I don't like a mix of both single and double quotes.
>
> In
I'm in for normalizing.
Personally, I don't like a mix of both single and double quotes.
In my opinion, we can enforce double-quotes with Black or also try the
pre-commit hook double-quote-string-fixer
https://github.com/pre-commit/pre-commit-hooks/blob/main/README.md#double-quote-string-fixer
Totally for it!
That’s not true actually. Black won’t reformat strings using f-string if you
use single quotes for the string and double quotes within e.g. when passing a
str.join statement as a value which uses double quotes. So you can still have a
mixture of both in the codebase but it will
>
> I'll weigh in on this most important of decisions
:)
OK but I must clear up one thing ... if we turn on string normalization, we
do not get to choose single vs double -- with black, there is only one way,
and it is double.
Personally I have always liked single but yeah, I am in favor of
consider
standardizing either way a win.
- ferruzzi
From: Jed Cunningham
Sent: Tuesday, September 20, 2022 8:39 PM
To: dev@airflow.apache.org
Subject: RE: [EXTERNAL][DISCUSS] string normalization in black
CAUTION: This email originated from outside
I'd be in favor of turning it on.
I tend to prefer double quotes, but I'd rather have it on and have single
quotes.
If we do get enough support for this, I'd like to wait until we are closer
to 2.5 to reduce conflicts when cherry-picking for 2.4.x's.
This option has been used to limit the number of changes to files.
https://github.com/apache/airflow/pull/9550#issuecomment-650971650
śr., 21 wrz 2022 o 02:32 Daniel Standish
napisał(a):
> Black, our python formatter, can "normalize" strings to prefer double
> quotes, and we disable this
Black, our python formatter, can "normalize" strings to prefer double
quotes, and we disable this feature.
I have always been a single quotes person unless using f-string and
supported disabling normalization when we introduced black.
But lately, black’s string normalization has seemed more
17 matches
Mail list logo
