Hi committers,
It looks like we have some rogue branches showing up again (perhaps the result
of our trial and error with the new pull request model). In any event, here are
the branches I am nominating for removal. If you don't want one of these
removed, please respond to this email:
+1
On 4/11/18, 10:50 AM, "Doroszlai, Attila" wrote:
Hi all,
Can you please make sure to include meaningful description and test
steps in your pull requests? Please take some time to replace the
placeholder text from the template (everything except
Hi all,
Can you please make sure to include meaningful description and test
steps in your pull requests? Please take some time to replace the
placeholder text from the template (everything except the 2 headings)
to help others (reviewers, users) understand the context.
Agreed - the reviews without +1's are most concerning. We can't be committing
without proper reviews. I think the only exceptions are:
- reverts
- merges from a main branch to a feature branch
> On Apr 11, 2018, at 11:28 AM, Robert Levas wrote:
>
> +1
>
> On 4/11/18,
+1
I agree with Jonathan that commits without +1 from reviewers are most
concerning. This shouldn't be happening.
-Vivek Ratnavel
On Wed, Apr 11, 2018 at 8:37 AM, Jonathan Hurley
wrote:
> Agreed - the reviews without +1's are most concerning. We can't be
> committing
I agree, however I think there is one more exception, if the same patch should
go into multiple branches, and one of them was already reviewed.
On 4/11/18, 5:37 PM, "Jonathan Hurley" wrote:
Agreed - the reviews without +1's are most concerning. We can't be