[GitHub] [incubator-annotator] tilgovi closed pull request #66: Improve licensing

2020-04-03 Thread GitBox
tilgovi closed pull request #66: Improve licensing URL: https://github.com/apache/incubator-annotator/pull/66 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [incubator-annotator] tilgovi commented on issue #71: Remove fragment-identifier package

2020-04-03 Thread GitBox
tilgovi commented on issue #71: Remove fragment-identifier package URL: https://github.com/apache/incubator-annotator/pull/71#issuecomment-608478918 Excellent! Thank you. This is an automated message from the Apache Git Servi

[GitHub] [incubator-annotator-website] BigBlueHat merged pull request #17: Add official Apache Annotator logo

2020-04-06 Thread GitBox
BigBlueHat merged pull request #17: Add official Apache Annotator logo URL: https://github.com/apache/incubator-annotator-website/pull/17 This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [incubator-annotator-website] BigBlueHat merged pull request #18: RDFa for SEO

2020-04-06 Thread GitBox
BigBlueHat merged pull request #18: RDFa for SEO URL: https://github.com/apache/incubator-annotator-website/pull/18 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-annotator-website] BigBlueHat commented on issue #11: Add new Apache Annotator logo to site

2020-04-06 Thread GitBox
BigBlueHat commented on issue #11: Add new Apache Annotator logo to site URL: https://github.com/apache/incubator-annotator-website/issues/11#issuecomment-610007709 And...done. 😁 This is an automated message from the Apache

[GitHub] [incubator-annotator-website] BigBlueHat opened a new pull request #19: RDFa for SEO (again)

2020-04-07 Thread GitBox
BigBlueHat opened a new pull request #19: RDFa for SEO (again) URL: https://github.com/apache/incubator-annotator-website/pull/19 Looks like it setup the "train," but with this branch merging into `add-logo` first...so I merged them in the wrong order. 😖 Anyhow. Submitting this (app

[GitHub] [incubator-annotator-website] BigBlueHat merged pull request #19: RDFa for SEO (again)

2020-04-07 Thread GitBox
BigBlueHat merged pull request #19: RDFa for SEO (again) URL: https://github.com/apache/incubator-annotator-website/pull/19 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-annotator-website] Treora closed issue #11: Add new Apache Annotator logo to site

2020-04-16 Thread GitBox
Treora closed issue #11: Add new Apache Annotator logo to site URL: https://github.com/apache/incubator-annotator-website/issues/11 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [incubator-annotator] Treora commented on issue #22: Build a highlighter

2020-04-16 Thread GitBox
Treora commented on issue #22: Build a highlighter URL: https://github.com/apache/incubator-annotator/issues/22#issuecomment-614736335 Done in PR 59: This is an automate

[GitHub] [incubator-annotator] Treora closed issue #22: Build a highlighter

2020-04-16 Thread GitBox
Treora closed issue #22: Build a highlighter URL: https://github.com/apache/incubator-annotator/issues/22 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [incubator-annotator] Treora opened a new pull request #74: Convert code to Typescript

2020-04-17 Thread GitBox
Treora opened a new pull request #74: Convert code to Typescript URL: https://github.com/apache/incubator-annotator/pull/74 Fixes #69 I split the work in two commits: first set up the configuration changes (while trying not to break if some files remain plain js), then convert the

[GitHub] [incubator-annotator] BigBlueHat commented on issue #53: Add support for ARIA Annotations output

2020-04-21 Thread GitBox
BigBlueHat commented on issue #53: URL: https://github.com/apache/incubator-annotator/issues/53#issuecomment-617187237 ARIA Annotations are headed to be a core part of ARIA 1.3 and implemented in Firefox 75 (at least): https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Anno

[GitHub] [incubator-annotator] Treora opened a new issue #75: Support TextPositionSelector (in the dom package)

2020-05-03 Thread GitBox
Treora opened a new issue #75: URL: https://github.com/apache/incubator-annotator/issues/75 Following its [specification](https://www.w3.org/TR/2017/REC-annotation-model-20170223/#text-position-selector). Altough it looks simple, there may be challenges in ensuring we count characte

[GitHub] [incubator-annotator] tilgovi opened a new pull request #76: Create distributions with git clone

2020-05-04 Thread GitBox
tilgovi opened a new pull request #76: URL: https://github.com/apache/incubator-annotator/pull/76 Create distribution tarballs by creating a shallow git clone. Distributing a shallow clone has several befenits: - Join upstream development with `git fetch --unshallow`

[GitHub] [incubator-annotator] BigBlueHat commented on issue #63: Sort out LICENSE and NOTICE issues from v0.1.0-rc.2

2020-05-07 Thread GitBox
BigBlueHat commented on issue #63: URL: https://github.com/apache/incubator-annotator/issues/63#issuecomment-625320812 Not sure why this didn't auto-close, but this is completed in #66. This is an automated message from the

[GitHub] [incubator-annotator] Treora opened a new issue #77: Create tests for dom package

2020-05-08 Thread GitBox
Treora opened a new issue #77: URL: https://github.com/apache/incubator-annotator/issues/77 I made a first small step in the [dom-tests](https://github.com/apache/incubator-annotator/tree/dom-tests) branch. Not yet sure what approach to take, but I thought to just start with some tests fo

[GitHub] [incubator-annotator] Treora commented on issue #77: Create tests for dom package

2020-05-15 Thread GitBox
Treora commented on issue #77: URL: https://github.com/apache/incubator-annotator/issues/77#issuecomment-629384737 In the call yesterday we discussed moving to jest as a possible solution. [Karma](https://github.com/karma-runner/karma) was suggested as a way to run automated tests in actu

[GitHub] [incubator-annotator] Treora opened a new pull request #79: Add tests for text quote selector

2020-05-28 Thread GitBox
Treora opened a new pull request #79: URL: https://github.com/apache/incubator-annotator/pull/79 See #77. This branch tests description and anchoring of text quote selectors. It does not attempt to exhaust every possible input, nor cover every branch of the code, but uses several example (

[GitHub] [incubator-annotator] Treora edited a comment on pull request #79: Add tests for text quote selector

2020-05-28 Thread GitBox
Treora edited a comment on pull request #79: URL: https://github.com/apache/incubator-annotator/pull/79#issuecomment-635372689 Note that this branch grows forth from the typescript branch, PR #74, and may best be rebased onto master after that one has been finalised and merged. -

[GitHub] [incubator-annotator] Treora commented on pull request #79: Add tests for text quote selector

2020-05-28 Thread GitBox
Treora commented on pull request #79: URL: https://github.com/apache/incubator-annotator/pull/79#issuecomment-635372689 Note that this branch grows forth from the typescript branch, PR #74, and may best be rebased to master after that one has been finalised and merged. --

[GitHub] [incubator-annotator] danielweck opened a new issue #80: highlight range: "not a perfect undo: split text nodes are not merged again"

2020-05-28 Thread GitBox
danielweck opened a new issue #80: URL: https://github.com/apache/incubator-annotator/issues/80 Source code reference: https://github.com/apache/incubator-annotator/blob/ac3b5bd4b2793b8f01a12bcd328b6beb947069fc/packages/dom/src/highlight-range.js#L23-L24 https://github.com/apache

[GitHub] [incubator-annotator] Treora commented on issue #80: highlight range: "not a perfect undo: split text nodes are not merged again"

2020-05-28 Thread GitBox
Treora commented on issue #80: URL: https://github.com/apache/incubator-annotator/issues/80#issuecomment-635380270 > Could `Node.normalize()` be used on `highlightElement.parentNode`? Indeed! That idea popped up recently too, and is what we started doing in the demo [1][]. I was not

[GitHub] [incubator-annotator] danielweck commented on issue #80: highlight range: "not a perfect undo: split text nodes are not merged again"

2020-05-28 Thread GitBox
danielweck commented on issue #80: URL: https://github.com/apache/incubator-annotator/issues/80#issuecomment-635428423 > However it would not be a perfect undo function either, as it would also merge nodes that were already split beforehand (for some reason). My thoughts exactly. Ev

[GitHub] [incubator-annotator] danielweck edited a comment on issue #80: highlight range: "not a perfect undo: split text nodes are not merged again"

2020-05-28 Thread GitBox
danielweck edited a comment on issue #80: URL: https://github.com/apache/incubator-annotator/issues/80#issuecomment-635428423 > However it would not be a perfect undo function either, as it would also merge nodes that were already split beforehand (for some reason). My thoughts exac

[GitHub] [incubator-annotator] Treora commented on issue #80: highlight range: "not a perfect undo: split text nodes are not merged again"

2020-05-29 Thread GitBox
Treora commented on issue #80: URL: https://github.com/apache/incubator-annotator/issues/80#issuecomment-635894043 Thanks for the elaboration, this sounds like great work. A highlighter that overlays on the dom seems preferable in many situations. Is/will your implementation be available

[GitHub] [incubator-annotator] danielweck commented on issue #80: highlight range: "not a perfect undo: split text nodes are not merged again"

2020-05-29 Thread GitBox
danielweck commented on issue #80: URL: https://github.com/apache/incubator-annotator/issues/80#issuecomment-635902789 > Is/will your implementation be available as a module? It's all open-source (TypeScript), but at this stage there is some tight-coupling with our internal layout/r

[GitHub] [incubator-annotator] danielweck commented on issue #80: highlight range: "not a perfect undo: split text nodes are not merged again"

2020-05-29 Thread GitBox
danielweck commented on issue #80: URL: https://github.com/apache/incubator-annotator/issues/80#issuecomment-635903713 > It would be great to learn more about your application and ways in which our work could become of use to you; be welcome on our mailing list, IRC, and/or weekly video c

[GitHub] [incubator-annotator] Treora opened a new issue #81: sync vs async API

2020-05-29 Thread GitBox
Treora opened a new issue #81: URL: https://github.com/apache/incubator-annotator/issues/81 As discussed in the call yesterday, I open this issue to park thoughts about whether/how to provide synchronous APIs, mainly future consideration. So far, we have been using async iterables/ge

[GitHub] [incubator-annotator] BigBlueHat commented on issue #47: Interleaving selections within the DOM

2020-06-04 Thread GitBox
BigBlueHat commented on issue #47: URL: https://github.com/apache/incubator-annotator/issues/47#issuecomment-638946715 Originally posted this as a separate issue in #78 (but closing and moving here to keep @Treora sane 😉): > https://www.w3.org/TR/intersection-observer/ > > Might h

[GitHub] [incubator-annotator] BigBlueHat commented on issue #78: Consider/monitor the new IntersectionObserver spec/work

2020-06-04 Thread GitBox
BigBlueHat commented on issue #78: URL: https://github.com/apache/incubator-annotator/issues/78#issuecomment-638947031 Closing in favor of #78. This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [incubator-annotator] BigBlueHat closed issue #78: Consider/monitor the new IntersectionObserver spec/work

2020-06-04 Thread GitBox
BigBlueHat closed issue #78: URL: https://github.com/apache/incubator-annotator/issues/78 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-annotator] Treora closed issue #69: Convert codebase to TypeScript

2020-06-18 Thread GitBox
Treora closed issue #69: URL: https://github.com/apache/incubator-annotator/issues/69 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [incubator-annotator] Treora merged pull request #74: Convert code to Typescript

2020-06-18 Thread GitBox
Treora merged pull request #74: URL: https://github.com/apache/incubator-annotator/pull/74 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-annotator] Treora merged pull request #79: Add tests for text quote selector

2020-06-18 Thread GitBox
Treora merged pull request #79: URL: https://github.com/apache/incubator-annotator/pull/79 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-annotator] Treora closed issue #77: Create tests for dom package

2020-06-18 Thread GitBox
Treora closed issue #77: URL: https://github.com/apache/incubator-annotator/issues/77 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [incubator-annotator] Treora commented on issue #77: Create tests for dom package

2020-06-18 Thread GitBox
Treora commented on issue #77: URL: https://github.com/apache/incubator-annotator/issues/77#issuecomment-646153752 First tests merged in #79, more can be developed as we go. Closing this issue. This is an automated message

[GitHub] [incubator-annotator] Treora commented on issue #64: Document release process and release testing process

2020-06-18 Thread GitBox
Treora commented on issue #64: URL: https://github.com/apache/incubator-annotator/issues/64#issuecomment-646156324 I suppose this is finished. On the wiki: [Creating a Release](https://github.com/apache/incubator-annotator/wiki/Creating-a-Release) and [Testing a Source Release](https://g

[GitHub] [incubator-annotator] Treora closed issue #64: Document release process and release testing process

2020-06-18 Thread GitBox
Treora closed issue #64: URL: https://github.com/apache/incubator-annotator/issues/64 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [incubator-annotator] Treora commented on issue #49: Explore WorkerDOM

2020-06-18 Thread GitBox
Treora commented on issue #49: URL: https://github.com/apache/incubator-annotator/issues/49#issuecomment-646204117 I added this to the new [Tech Radar](https://github.com/apache/incubator-annotator/wiki/Tech-Radar) page on the wiki; updates can be added there, and discussion may also cont

[GitHub] [incubator-annotator] Treora closed issue #49: Explore WorkerDOM

2020-06-18 Thread GitBox
Treora closed issue #49: URL: https://github.com/apache/incubator-annotator/issues/49 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [incubator-annotator] Treora commented on issue #45: Generate accessible annotations

2020-06-18 Thread GitBox
Treora commented on issue #45: URL: https://github.com/apache/incubator-annotator/issues/45#issuecomment-646206067 Superseded by #53? Closing. (also, I added this topic to the new [Tech Radar](https://github.com/apache/incubator-annotator/wiki/Tech-Radar) page on the wiki) -

[GitHub] [incubator-annotator] Treora closed issue #45: Generate accessible annotations

2020-06-18 Thread GitBox
Treora closed issue #45: URL: https://github.com/apache/incubator-annotator/issues/45 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [incubator-annotator] Treora commented on issue #54: Highlight API explainer

2020-06-18 Thread GitBox
Treora commented on issue #54: URL: https://github.com/apache/incubator-annotator/issues/54#issuecomment-646207455 Current home seems to be: https://drafts.csswg.org/css-highlight-api-1/ I added this topic to the new [Tech Radar](https://github.com/apache/incubator-annotator/wiki/Te

[GitHub] [incubator-annotator] Treora closed issue #54: Highlight API explainer

2020-06-18 Thread GitBox
Treora closed issue #54: URL: https://github.com/apache/incubator-annotator/issues/54 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [incubator-annotator] Treora commented on issue #55: Consider exploring Intl.Segmenter (and current polyfill) for word-based selection

2020-06-18 Thread GitBox
Treora commented on issue #55: URL: https://github.com/apache/incubator-annotator/issues/55#issuecomment-646207986 I added this topic to the new [Tech Radar](https://github.com/apache/incubator-annotator/wiki/Tech-Radar) page on the wiki; updates can be added there, and discussion may als

[GitHub] [incubator-annotator] Treora closed issue #55: Consider exploring Intl.Segmenter (and current polyfill) for word-based selection

2020-06-18 Thread GitBox
Treora closed issue #55: URL: https://github.com/apache/incubator-annotator/issues/55 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [incubator-annotator] Treora commented on issue #60: Implement a parser for ScrollToTextFragment syntax

2020-06-18 Thread GitBox
Treora commented on issue #60: URL: https://github.com/apache/incubator-annotator/issues/60#issuecomment-646209725 Is this still a plan? We have ditched our other fragment identifier effort (see PR #71). Besides making a parser for the fragment identifier syntax itself, I suppose w

[GitHub] [incubator-annotator] mokipedia opened a new issue #82: update version of npm packages

2020-07-08 Thread GitBox
mokipedia opened a new issue #82: URL: https://github.com/apache/incubator-annotator/issues/82 Hi, the npm releases seem to be a little behind the releases marked here in github. Is there a new release planned? This is

[GitHub] [incubator-annotator] tilgovi commented on issue #82: update version of npm packages

2020-07-08 Thread GitBox
tilgovi commented on issue #82: URL: https://github.com/apache/incubator-annotator/issues/82#issuecomment-655697223 We have stopped publishing pre-release versions for the moment, as we are getting our release process in order. The first official release is v0.1.0, which was tagged less t

[GitHub] [incubator-annotator] tilgovi closed issue #82: update version of npm packages

2020-07-08 Thread GitBox
tilgovi closed issue #82: URL: https://github.com/apache/incubator-annotator/issues/82 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [incubator-annotator] tilgovi commented on issue #82: update version of npm packages

2020-07-11 Thread GitBox
tilgovi commented on issue #82: URL: https://github.com/apache/incubator-annotator/issues/82#issuecomment-657183392 The release is now live. Thank you for your patience! There is no formal documentation at the moment, so please dig into the code and raise questions on the mailing li

[GitHub] [incubator-annotator-website] Treora opened a new pull request #20: Update intro text

2020-07-16 Thread GitBox
Treora opened a new pull request #20: URL: https://github.com/apache/incubator-annotator-website/pull/20 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [incubator-annotator-website] Treora commented on pull request #20: Update intro text

2020-07-16 Thread GitBox
Treora commented on pull request #20: URL: https://github.com/apache/incubator-annotator-website/pull/20#issuecomment-659480818 For easier reading: > Growing out of the experiences with web annotation software (Annotator.js, Hypothes.is, and others), Apache Annotator is a co

[GitHub] [incubator-annotator-website] BigBlueHat commented on pull request #20: Update intro text

2020-07-16 Thread GitBox
BigBlueHat commented on pull request #20: URL: https://github.com/apache/incubator-annotator-website/pull/20#issuecomment-659487024 > We are always welcoming other developers and community members interested in participating in the future of annotation, so reach out to our mailing list or

[GitHub] [incubator-annotator] Treora opened a new issue #83: Fuzzy text quote matching

2020-07-16 Thread GitBox
Treora opened a new issue #83: URL: https://github.com/apache/incubator-annotator/issues/83 Many annotation tools want to match a quote also when it has been modified slightly, but we have yet to implement this. Enabling approximate/fuzzy string matching could be an option to our ex

[GitHub] [incubator-annotator] Treora commented on issue #38: Import @tilgovi's dom-anchor-* libraries

2020-07-16 Thread GitBox
Treora commented on issue #38: URL: https://github.com/apache/incubator-annotator/issues/38#issuecomment-659538621 Just discussed in the weekly call: rather than importing these modules as such, we better just get at (and beyond) feature parity and thereby make them obsolete. For t

[GitHub] [incubator-annotator] Treora closed issue #38: Import @tilgovi's dom-anchor-* libraries

2020-07-16 Thread GitBox
Treora closed issue #38: URL: https://github.com/apache/incubator-annotator/issues/38 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [incubator-annotator-website] BigBlueHat merged pull request #20: Update intro text

2020-07-16 Thread GitBox
BigBlueHat merged pull request #20: URL: https://github.com/apache/incubator-annotator-website/pull/20 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-annotator-website] BigBlueHat commented on pull request #20: Update intro text

2020-07-16 Thread GitBox
BigBlueHat commented on pull request #20: URL: https://github.com/apache/incubator-annotator-website/pull/20#issuecomment-659603359 @Treora said I could make this change on our last call together (today). Honest. 😉 This is

[GitHub] [incubator-annotator] Treora opened a new pull request #84: Add tests for highlighter

2020-07-23 Thread GitBox
Treora opened a new pull request #84: URL: https://github.com/apache/incubator-annotator/pull/84 Mainly adds some tests for the highlighter. Not yet rebased. This is an automated message from the Apache Git Service. To

[GitHub] [incubator-annotator] Treora merged pull request #84: Add tests for highlighter

2020-07-24 Thread GitBox
Treora merged pull request #84: URL: https://github.com/apache/incubator-annotator/pull/84 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-annotator] Treora commented on issue #21: Ability to use multiple layers of annotation.

2020-07-24 Thread GitBox
Treora commented on issue #21: URL: https://github.com/apache/incubator-annotator/issues/21#issuecomment-663492713 We do have a simple highlighter now, using the ``-based approach, which could be used for overlapping annotations as described [above](https://github.com/apache/incubator-ann

[GitHub] [incubator-annotator] Treora closed issue #21: Ability to use multiple layers of annotation.

2020-07-24 Thread GitBox
Treora closed issue #21: URL: https://github.com/apache/incubator-annotator/issues/21 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [incubator-annotator] Treora commented on issue #47: Interleaving selections within the DOM

2020-07-24 Thread GitBox
Treora commented on issue #47: URL: https://github.com/apache/incubator-annotator/issues/47#issuecomment-663510334 Since recently we have a simple highlighter, which wraps text nodes in `` elements, and ignores any existing ``s to allow for nested use. I just created some simple tests (se

<    1   2   3   4