Please have a look at the attached file.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
- renamed variables (m_destdir -destdir)
- added javadoc for public methods and normal doc for private methods
- slight tweak to remove Unneccessary nested... complaint from Eclipse
Kev
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
- added javadoc and normal doc where appropriate
- renamed variables from m_*
Kev
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
- added javadoc and normal doc where appropriate
- renamed variables from m_*
Kev
Index: AntResolver.java
===
RCS file:
/home/cvspublic/ant/src/main/org/apache/tools/ant/taskdefs/optional/extension/resolvers/AntResolver.java,v
- renamed variables (m_destdir -destdir)
- added javadoc for public methods and normal doc for private methods
- slight tweak to remove Unneccessary nested... complaint from Eclipse
Kev
Index: URLResolver.java
===
RCS file:
- swapped out deprecated code where the replacement code was obvious -
left some deprecated methods where I wasn't sure
- changed visibility of class variables from private to protected
still showing 1700+ warnings/errors :(
Kev
Index: ProjectHelperImpl.java
jkf 2004/12/09 14:17:24
Modified:src/main/org/apache/tools/ant/taskdefs Parallel.java
Log:
In bug 32566 someone asked about the thread safety requirements in Ant.
This made me perform a quick check on the main flow of the Ant project
from a threading perspective. The only
jkf 2004/12/09 15:06:47
Modified:src/main/org/apache/tools/ant/taskdefs Parallel.java
Log:
Checkstyle updates.
(removed trailing spaces just added, updated javadoc, removed an undocumented
BuildException
which was neither thrown according to interface nor according to
Is there some script not working any more?
The homepage [1] has a link to cvs/snapshot [2], but there
is nothing.
Just for comparison ... Forrest has, httpd has, lenya has,
maven not, spamassasin has, ...
Jan
[1] http://ant.apache.org/cvs.html
[2] http://cvs.apache.org/snapshots/ant/
peterreilly2004/12/10 02:58:19
Modified:
src/main/org/apache/tools/ant/taskdefs/optional/extension/resolvers
AntResolver.java LocationResolver.java
URLResolver.java
Log:
checkstyle changes
Obtained from: Kevin Jackson
Revision
peterreilly2004/12/10 02:58:36
Modified:
src/main/org/apache/tools/ant/taskdefs/optional/extension/resolvers
Tag: ANT_16_BRANCH AntResolver.java
LocationResolver.java URLResolver.java
Log:
sync
Revision ChangesPath
No
On Wed, 8 Dec 2004, Matt Benson [EMAIL PROTECTED] wrote:
Hmm... maybe we should just change the unit test to read the files
(using loadfile with a striplinebreaks filter) into properties
and compare those rather than using FileUtils.contentEquals(...)?
+1
Stefan
On Wed, 8 Dec 2004, Dominique Devienne [EMAIL PROTECTED] wrote:
Isn't the alternative simply to check in the expected files are
binary to avoid line ending conversions at all?
Won't work since the result of running checksum produces platfirm
dependent line ends.
Stefan
On Wed, 08 Dec 2004, Martijn Kruithof [EMAIL PROTECTED] wrote:
I actually used the same technique as proposed in the bug report on
the recorder test cases. Stefan modified that one in such a way that
not the files from cvs are fixed but copies of those files.
I mainly did so since otherwise
On Fri, 10 Dec 2004, Jan Materne [EMAIL PROTECTED] wrote:
Just for comparison ... Forrest has, httpd has, lenya has,
maven not, spamassasin has, ...
Hmm, looks as if the script stopped working for the project that have
not converted to SVN yet.
Stefan
If this is related to MD5 checksums, they've recently been proven to not
be conclusive proof that the content of the file is the same as the
checksum, ie two different files can create the same checksum under
certain conditions.
Not sure if this is relevant to the discussion
Just to remove whiny messages - although the compiler believes it will
also help performance
Kev
Index: ScriptDef.java
===
RCS file:
/home/cvspublic/ant/src/main/org/apache/tools/ant/taskdefs/optional/script/ScriptDef.java,v
Kev Jackson wrote:
- swapped out deprecated code where the replacement code was obvious -
left some deprecated methods where I wasn't sure
- changed visibility of class variables from private to protected
We will not be changing private to protected.
As much as possible all fields should be
Kev Jackson wrote:
We will not be changing private to protected.
As much as possible all fields should be private and there should
be very few protected methods.
For current released code, it is not possible to change protected fields
to private fields due to BC consideration.
OK, I agree that
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=32631.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=32631.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=32632.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=32631.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
peterreilly2004/12/10 05:17:51
Modified:docs/manual/CoreTasks copy.html
Log:
document using a filenamemapper type in place of the mapper element
Revision ChangesPath
1.29 +5 -3 ant/docs/manual/CoreTasks/copy.html
Index: copy.html
peterreilly2004/12/10 05:21:54
Modified:docs/manual/CoreTasks Tag: ANT_16_BRANCH copy.html
src/main/org/apache/tools/ant/taskdefs Tag: ANT_16_BRANCH
Copy.java
Log:
sync: copy's filenamemapper type support
Revision ChangesPath
No
This past two weeks, I've worked on coming up with a generic build file
for our multiple projects, which I'd say are 80% to 99% common from one
project to the next. Of course, I'm using heavily import, target
overriding, and macrodef, but even with these fine features, it's not
always easy to
All these features sould great.
1) this attribute is good.
however, it is only really usefull in combination with the iftrue
attribute,
or with ant-contrib if task
2) a default value for the element is good. The default value should
be in the declaration, but it is ok to have it the
peterreilly2004/12/10 07:18:57
Modified:.WHATSNEW
src/main/org/apache/tools/ant/util ClasspathUtils.java
Added: src/testcases/org/apache/tools/ant/util
ClasspathUtilsTest.java
Log:
with the bugzilla change 30161 it is not
peterreilly2004/12/10 07:20:11
Modified:.Tag: ANT_16_BRANCH WHATSNEW
src/main/org/apache/tools/ant/util Tag: ANT_16_BRANCH
ClasspathUtils.java
Added: src/testcases/org/apache/tools/ant/util Tag: ANT_16_BRANCH
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=28782.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=32488.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=29248.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
Thanks for the feedback Peter. I'll be off line most of Dec, so for now I'll
just attach my modified MacroDef/Instance files in bugzilla until I can
properly try to integrate it to Ant (it's not very tested yet, and not unit
tested at all either). I worked off the 1.6 branch anyway, and this
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=32638.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=32638.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=32631.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=32632.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
I've never used macrodef in Ant, but would say that I'd find a
template definition easiest to understand with the following
structure:
define id=t
parameters
parameter id=x
... (gives default value)
/parameter
/parameters
body
...
/body
/define
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=32638.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=29248.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=21421.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=29248.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=32638.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=32638.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=32639.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=32639.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
peterreilly2004/12/10 09:10:08
Modified:docs/manual/CoreTasks uptodate.html
Log:
doc for use of filenamemaper in uptodate
Revision ChangesPath
1.15 +4 -0 ant/docs/manual/CoreTasks/uptodate.html
Index: uptodate.html
peterreilly2004/12/10 09:11:41
Modified:src/main/org/apache/tools/ant/taskdefs Tag: ANT_16_BRANCH
UpToDate.java
docs/manual/CoreTasks Tag: ANT_16_BRANCH uptodate.html
Log:
sync: updatetodate filenamemapper type
Revision ChangesPath
peterreilly2004/12/10 09:13:54
Modified:src/main/org/apache/tools/ant/taskdefs UpToDate.java
Log:
Checkstyle changes for UptoDate.java
Obtained from: Kevin Jackson
Revision ChangesPath
1.38 +39 -28ant/src/main/org/apache/tools/ant/taskdefs/UpToDate.java
peterreilly2004/12/10 09:14:09
Modified:src/main/org/apache/tools/ant/taskdefs Tag: ANT_16_BRANCH
UpToDate.java
Log:
sync
Revision ChangesPath
No revision
No revision
1.32.2.6 +39 -28
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=32638.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
bodewig 2004/12/10 09:29:04
Modified:src/main/org/apache/tools/ant/taskdefs/compilers Jikes.java
Log:
Try to help the Gump/Kaffe/Jikes build
Revision ChangesPath
1.29 +9 -0
ant/src/main/org/apache/tools/ant/taskdefs/compilers/Jikes.java
Index: Jikes.java
mbenson 2004/12/10 10:28:45
Modified:src/main/org/apache/tools/ant/types AbstractFileSet.java
Log:
Javadoc and LOC bumming
Revision ChangesPath
1.35 +99 -104
ant/src/main/org/apache/tools/ant/types/AbstractFileSet.java
Index: AbstractFileSet.java
Stefan Bodewig wrote:
On Wed, 8 Dec 2004, Matt Benson [EMAIL PROTECTED] wrote:
Hmm... maybe we should just change the unit test to read the files
(using loadfile with a striplinebreaks filter) into properties
and compare those rather than using FileUtils.contentEquals(...)?
We could
Hi,
what are the conditions to merge to ANT_16_BRANCH as sync and not only
to HEAD?
Martijn
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Kev Jackson wrote:
If this is related to MD5 checksums, they've recently been proven to
not be conclusive proof that the content of the file is the same as
the checksum, ie two different files can create the same checksum
under certain conditions.
Yes it is.
Martijn
--- Martijn Kruithof [EMAIL PROTECTED] wrote:
Hi,
what are the conditions to merge to ANT_16_BRANCH as
sync and not only
to HEAD?
Off the top of my head, bugfixes most often go to the
branch immediately or nearly so. For new features it
probably depends on level of complexity and/or risk
Kev Jackson wrote:
question: Do we assume that when arrays are initialised they have an
undefined value?
Java requires newly created arrays to be filled with null/0/false acc.
to type. There is no need to explicitly blank it.
mbenson 2004/12/10 13:49:32
Modified:src/main/org/apache/tools/ant/types AbstractFileSet.java
Log:
More LOC bumming
Revision ChangesPath
1.36 +14 -27
ant/src/main/org/apache/tools/ant/types/AbstractFileSet.java
Index: AbstractFileSet.java
mbenson 2004/12/10 13:52:32
Modified:src/main/org/apache/tools/ant/types Tag: ANT_16_BRANCH
AbstractFileSet.java
Log:
Sync
Revision ChangesPath
No revision
No revision
1.29.2.5 +115 -133
jglick 2004/12/10 15:16:09
Modified:docs/manual/CoreTasks javac.html
Log:
The manual strongly encourages you to specify source/target levels, yet it
gave no examples that did so! Putting
in some usages to plant the bug in people's minds. (Especially important for
people just
jglick 2004/12/10 15:17:34
Modified:docs/manual/CoreTasks Tag: ANT_16_BRANCH javac.html
Log:
merge
Revision ChangesPath
No revision
No revision
1.42.2.7 +14 -4 ant/docs/manual/CoreTasks/javac.html
Index: javac.html
jglick 2004/12/10 15:18:22
Modified:src/main/org/apache/tools/ant/util FileUtils.java
Log:
If we can use File.getParentFile, there is presumably no reason to use
FileUtils.getParentFile, right?
Revision ChangesPath
1.76 +4 -3
jglick 2004/12/10 15:19:28
Modified:.check.xml
Log:
1. Make checkstyle target work independently of CWD.
2. Add a target to display the text report inline, for easy hyperlink
navigation.
Revision ChangesPath
1.13 +13 -8 ant/check.xml
Index:
64 matches
Mail list logo
