Re: ResourceCollections

Matt Benson wrote: --- Martijn Kruithof <[EMAIL PROTECTED]> wrote: [SNIP] Apart from the variands A and B further below, would the following also work? or would this mean that the resoursecollection must be part of set itself? As I understand it, yes, becau

Re: ResourceCollections

But wouldn't that defeat the whole purpose of the I thought the whole point was avoiding having addConcrete in favour of having add(Role). What basically is that what Matt just stated. Apart from the variands A and B further below, would the following also work? or woul

Re: ResourceCollections

Dominique Devienne wrote: Martijn, Matt, the example above would be necessary if and only if only had a add(ResourceSelector). In practice, we'll likely have specialized addAnd(ResourceSelector) and co so that if can be written just: > But wouldn't that defeat the whole purpose of the I thou

Re: ResourceCollections

Well that would be up to the "user". Would it mean for us that the code must be in different libraries, or is it enough if the classes are defined in separate property files / marked with special values, while the classes can still be blended in in core ant. Martijn Matt Benson wrote: You are u

Re: ResourceCollections

Matt Benson wrote: --- Stefan Bodewig <[EMAIL PROTECTED]> wrote: On Mon, 11 Apr 2005, Matt Benson <[EMAIL PROTECTED]> wrote: Please don't. If I'm going to dump this ResourceCollection stuff into HEAD I'd rather have this resolved first, and right now only five committers have shown any int

Re: We have SVN

Great, looks good - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: [patch] javadoc, name-hiding, if/else nesting

Thanks Kev, Committed the vs part. I do not really see the benefit of having if (condition) { return a; } return b; over: if (condition) { return a; } else { return b; } so I didn't apply those patches. I did apply the destDir -> baseDir one, but it left the javadoc in an inconsistent s

Re: Drop 1.2/1.3 support in Ant 1.7 (or sometime)?

Jesse Glick wrote: Stefan Bodewig wrote: All in all I'm -0.5 on dropping JDK 1.2 for Ant 1.7 and -0.75 on dropping JDK 1.3 for Ant 1.7. BTW dropping JDK 1.2 support but supporting JDK 1.3 doesn't buy us a lot; few new APIs or other features were added in JDK 1.3, as it was mostly a performance

Re: cvs commit: ant/src/main/org/apache/tools/ant/util FileUtils.java

+/** + * The granularity of timestamps under the NT File System. + * NTFS has a granularity of 100 nanoseconds, which is less + * than 1 millisecond, so we set this to 0. + */ +public static final long NTFS_FILE_TIMESTAMP_GRANULARITY = 0; Shouldn't this be 1, testi

Re: Drop 1.2/1.3 support in Ant 1.7 (or sometime)?

Hi I am +1 on dropping 1.2 support in ant 1.7, and -1 on dropping 1.3 support already. This because I have the impression that 1.2 is on it's return heavily, and testing that things work on 1.2 is somewhat difficult on certain platforms. 1.3 seems to be used a lot still. As far as I recall we d

Re: Drop 1.2/1.3 support in Ant 1.7 (or sometime)?

Hi I am +1 on dropping 1.2 support in ant 1.7, and -1 on dropping 1.3 support already. This because I have the impression that 1.2 is on it's return heavily, and testing that things work on 1.2 is somewhat difficult on certain platforms. 1.3 seems to be used a lot still. As far as I recall we d

Re: [VOTE] Alexey Solofnenko

+1 Martijn - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: ant/src/testcases/org/apache/tools/ant/taskdefs StyleTest.java

Matt Benson wrote: --- Stefan Bodewig <[EMAIL PROTECTED]> wrote: On 21 Mar 2005, <[EMAIL PROTECTED]> wrote: unit test for PR 25911 which passes for me. Could anybody please run it on Windows? Passed w/ Java 1.4.2/Win2k/cygwin and also on Java 1.4.2/XP Home/no cygwin Martijn

Re: [VOTE] Retire Antidote

Stefan Bodewig wrote: On Mon, 21 Mar 2005, Stefan Bodewig <[EMAIL PROTECTED]> wrote: I hereby propose to retire the Antidote subproject. +1 Martijn - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [

Re: [VOTE] Ant 1.6.3 release candidate - new date proposed : March 31st

Antoine Levy-Lambert wrote: Since several committers seemed to want a bit more time for fixes, let's vote for Ant 1.6.3 rc1 on Thursday, March 31st. (and cancel the previous vote of course) [ ] Yes [ ] No Let me begin with my +1 +1 Martijn

Re: cvs commit: ant/src/main/org/apache/tools/ant AntClassLoader.java

Stefan Bodewig wrote: On 11 Mar 2005, <[EMAIL PROTECTED]> wrote: Removed superfluous cast It is not superfluos in JDK 1.5. Stefan Sorry, i see it has been fixed again. Martijn - To unsubscribe, e-mail: [EMAIL PROTECTED]

bug 33361

Hi, I am thinking about aligning this for 1.7, by also applying the default permissions + delegation to existing SM also when the failonerror is not set. This of course along with a note in the manual and the WHATSNEW. Any objections? Martijn

Re: [patch] mainly name-hiding

Conor MacNeill wrote: Likewise, I do not see converting an if-else to a ternary conditional makes the code clearer - on the contrary it makes it more convoluted. Ternary conditionals are one of my favorite things. I riddle the code with them in the interest of making it smaller... surely it doe

Re: Ant SVN repo URLs

Proposals so far: http://svn.apache.org/repos/asf/ant/core/ http://svn.apache.org/repos/asf/ant/libs/ and http://svn.apache.org/repos/asf/ant/antlibs/proper/dotnet http://svn.apache.org/repos/asf/ant/antlibs/sandbox/svn Maybe we should use 3 locations though (moving is possible within a svn

cvs commit: ant/src/main/org/apache/tools/mail ErrorInQuitException.java (2/2)

revision No revision 1.23.2.11 +2 -5 ant/docs/manual/credits.html Index: credits.html === RCS file: /home/cvs/ant/docs/manual/credits.html,v retrieving revision 1.23.2.10 retrieving

cvs commit: ant/src/main/org/apache/tools/mail ErrorInQuitException.java (1/2)

jkf 2005/03/09 10:56:31 Modified:src/main/org/apache/tools/ant/taskdefs/optional/extension Tag: ANT_16_BRANCH ExtensionAdapter.java Specification.java Extension.java LibraryDisplayer.java LibFileSet.java

cvs commit (mail delivery failed)

Hi. This is the qmail-send program at apache.org. I'm afraid I wasn't able to deliver your message to the following addresses. This is a permanent error; I've given up. Sorry it didn't work out. <[EMAIL PROTECTED]>: ezmlm-reject: fatal: Sorry, I don't accept messages larger than 10 bytes (#5.2

Re: Should CVS keyword substitution be permitted?

If wanted i'll do it Matt Benson wrote: --- Jesse Glick <[EMAIL PROTECTED]> wrote: Not sure if anyone else cares much about this, but is there a reason other Ant committers permit sources in CVS to use keywords such as "$Revision$"? Just reminded by the recent patch and the bogus I'd jus

Re: New COPY granularity breaks builds on Windows 2000

I had yet another thought, why don't we assume (unless specified otherwise) that the filesystem timestamp granularity of all involved filesystems is the same (we currently already do, and tie some pretty strange conclusions to that fact). That way we should be able to not take into account the gr

Re: [Ant Wiki] Updated: Ant17/Planning

[EMAIL PROTECTED] wrote: Date: 2005-03-03T08:55:35 Editor: SteveLoughran Wiki: Ant Wiki Page: Ant17/Planning URL: http://wiki.apache.org/ant/Ant17/Planning no comment Change Log: -- @@ -60,6 +60,7 @@ * security

Re: Active PMCers and Committers?

Steve Loughran wrote: Stefan Bodewig wrote: Hi all, I am about to propose a vote on the Antlib subproject proposal[1], which hasn't received much attention. Given that our bylaws state it needs a 2/3 majority of all "active committers" to get accepted, I'm more than a bit worried that it is going

Re: FileUtils.normalize

Matt Benson wrote: FileUtils.resolveFile claims to return absolute files; however calling FileUtils.resolveFile(null, "\\") on DOS returns the non-absolute File "\\". So we lie. :) -Matt No file on windows is allowed to have \ in the name, so \\ would not be a valid file on dos at all (so not

Re: cvs commit: ant/docs/manual/CoreTasks checksum.html

Dominique Devienne wrote: From: Stefan Bodewig [mailto:[EMAIL PROTECTED] On Wed, 16 Feb 2005, Dominique Devienne <[EMAIL PROTECTED]> wrote: You mean that the MD5 and SHA-1 digests computed by the JDK-provided libraries didn't generate the canonical values of these digests? No, broken as

Re: cvs commit: ant WHATSNEW

Matt Benson wrote: --- [EMAIL PROTECTED] wrote: +* filenames with semicolon on second position are not handled correctly by ant. + Bugzilla report 32979 semicolon ';' or colon ':' ? -Matt colon - To unsubscribe, e-mai

Re: Ant 1.6 branch + JDK 1.5 + win2K test failure

Hi All testcases an ant 1.6 head passed on XP with 1.2.2_017 / 1.3.1_13 / 1.4.2_06 and 1.5.0. JavaTest didn't pass the first time on 1.4.2 and 1.5.0 but that is a problem I face regularly (didn't investigate why this problem occurs intermittently) Kind Regards, Martijn

Re: cvs commit: ant/src/testcases/org/apache/tools/ant/taskdefs/optional/depend DependTest.java

[EMAIL PROTECTED] wrote: jkf 2005/01/22 05:36:26 Modified:src/testcases/org/apache/tools/ant/taskdefs/optional/depend Tag: ANT_16_BRANCH DependTest.java Log: sync with head to make test pass on 1.5 I saw that these changes were originally applied in 2004 on

Re: Ant 1.6 branch + JDK 1.5 + win2K test failure

Antoine Levy-Lambert wrote: Hi, I have not been committing a lot lately, but if we want to release a 1.6.3 soon I can take care of preparing a beta ? I was wondering whether we would like the fix for the bug 25777 (Cannot pass composite path reference...) to be merged in the 1.6 branch ? Thank

Re: AW: Property name policy (was Re: cvs commit: ant/docs/manual/Cor eTypes selectors.html)

[EMAIL PROTECTED] wrote: I have declared a policy on what we will name new properties. Is this a good formal policy to have? If new properties get added (it happens), expect them to appear under the "ant." and "org.apache.tools.ant" prefixes, unless the developers have a very good

Re: Out of memory errors since recent changes.

than a problem with a specific test. The most widely applicable code changes that have gone in are the Property stuff and the Reference Project... anyone have any ideas? -Matt --- Martijn Kruithof <[EMAIL PROTECTED]> wrote: I do not know what has been changed the last 44 hours, but somewh

Out of memory errors since recent changes.

I do not know what has been changed the last 44 hours, but somewhere in between a big memory leak has been caused. build test fails with an OutOfMemoryError in: FixCrLfTest on XP / 1.5.0 and on Linux / 1.4.2_06 ExecuteOnTest on XP / 1.4.2_06 and on XP / 1.3.1_13 BZip2Test on XP / 1.2.2_017 While,

Re: DO NOT REPLY [Bug 33074] - condition task should support optional value for false

Sorry for mixing things up, this mail had nothing to do with the bug 33074 Martijn Kruithof wrote: I do not know what has been changed the last 44 hours, but somewhere in between a big memory leak has been caused. build test fails with an OutOfMemoryError in: FixCrLfTest on XP / 1.5.0 and on

Re: DO NOT REPLY [Bug 33074] - condition task should support optional value for false

I do not know what has been changed the last 44 hours, but somewhere in between a big memory leak has been caused. build test fails with an OutOfMemoryError in: FixCrLfTest on XP / 1.5.0 and on Linux / 1.4.2_06 ExecuteOnTest on XP / 1.4.2_06 and on XP / 1.3.1_13 BZip2Test on XP / 1.2.2_017 While,

Re: or file collections

Dominique Devienne wrote: From: Matt Benson [mailto:[EMAIL PROTECTED] Yes, possible. You say you're not sure whether that would make you feel better. What about you, DD? I don't like using clone() at all, but I don't have good reasons either ;-) I'd prefer that only declared types be 'extend

Re: [GUMP@brutus]: Project test-ant (in module ant) failed -> JUnitReportTest only

As in the subject, only the error in the JUnitReportTest occured again. Martijn - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: AW: [GUMP@brutus]: Project test-ant (in module ant) failed

of course i will fix this before monday. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: AW: [GUMP@brutus]: Project test-ant (in module ant) failed

[EMAIL PROTECTED] wrote: Ok, the usual testNoFileJUnitNoFrames(org.apache.tools.ant.taskdefs.optional.junit.JUnitRe portTest) Xalan error. But there are another few ... Jan Testcase: testResolveFile(org.apache.tools.ant.ProjectTest):FAILED expected: but was: junit.framework.Comp

Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs/compilers DefaultCompilerAdapter.java

Hi? Has the deviating mail format to do with the size of the commit? Martijn - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Checksum.java

I understand the importance of improving the style, but shouldn't we prefer no comments (warnings stay to indicate they are missing) over this kind of comments: Kind Regards, Martijn + * @param file a File value + * @param algorithm a String value + * @param provider a String value

Re: [GUMP@brutus]: Project test-ant (in module ant) failed

Gump Integration Build wrote: This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, Hi it seems the web site advertised in the mail is not available anymore. (I clicked it by accident instead of the details link.) Best R

Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs Copy.java DependSet.java

Hi Unless anyone objects within the next few days I will apply a patch that will make use of getFileUtils instead of newFileUtils in all files in a uniform way (122 files impacted). I have manually checked if it could do any harm when using the same instance of the FileUtils everywhere and could

Re: cvs commit: ant/src/testcases/org/apache/tools/ant/taskdefs/optional/depend DependTest.java

Hi, this test case would now also pass if no class has been found at all, is that intentional? Kind Regards, Martijn [EMAIL PROTECTED] wrote: conor 2004/12/22 06:08:23 Modified:src/testcases/org/apache/tools/ant/taskdefs/optional/depend DependTest.java Log: JDM

Re: cvs commit: ant/src/etc/testcases/taskdefs checksum.xml

Kev Jackson wrote: If this is related to MD5 checksums, they've recently been proven to not be conclusive proof that the content of the file is the same as the checksum, ie two different files can create the same checksum under certain conditions. Yes it is. Martijn -

Syncing

Hi, what are the conditions to merge to ANT_16_BRANCH as sync and not only to HEAD? Martijn - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: cvs commit: ant/src/etc/testcases/taskdefs checksum.xml

Stefan Bodewig wrote: On Wed, 8 Dec 2004, Matt Benson <[EMAIL PROTECTED]> wrote: Hmm... maybe we should just change the unit test to read the files (using with a filter) into properties and compare those rather than using FileUtils.contentEquals(...)? We could also add a FileUtil.conte

Re: cvs commit: ant/src/etc/testcases/taskdefs checksum.xml

Hi I actually used the same technique as proposed in the bug report on the recorder test cases. Stefan modified that one in such a way that not the files from cvs are "fixed" but copies of those files. I would propose to either go the same way here or take a better approach in actually write a

Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs/compilers Jikes.java

Hi if (attributes.getSource() != null) { cmd.createArgument().setValue("-source"); -cmd.createArgument().setValue(attributes.getSource()); +String source = attributes.getSource(); +if (source.equals("1.1") || source.equals("1.2")) { +

Bug 26020

Hi, could the patch to bug http://issues.apache.org/bugzilla/show_bug.cgi?id=26020 (which would also fix 27842) please be taken into consideration? Kind regards, Martijn - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional

Re: cvs commit: ant/src/main/org/apache/tools/ant/launch Locator.java

[EMAIL PROTECTED] wrote: 1.12 +12 -7 ant/src/main/org/apache/tools/ant/launch/Locator.java Index: Locator.java === RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/launch/Locator.java,v retrieving revision 1.11

Re: Pb with ++

Martijn Kruithof wrote: Hi Back to the cause analysis of the gc mystery: It seems to me that expandFile of Expand.java (the class implementing the unzip task) leaks non explicitly closed streams, that are very likely to lead to open file handles from the expandFile method. I will verify and

Re: Pb with ++

Hi Back to the cause analysis of the gc mystery: It seems to me that expandFile of Expand.java (the class implementing the unzip task) leaks non explicitly closed streams, that are very likely to lead to open file handles from the expandFile method. I will verify and test the following patch, ju

Re: Authors tag

Peter Reilly wrote: I have commited the removal of authors patch. I made a CONTRIBUTORS file at the top level containing the authors names - without corresponding e-mail addresses. The following name/e-mails I could not find names for: gg at grtmail dot com miha at softhome dot net rhanderson skant

Re: cvs commit: ant/src/etc/testcases/types filelist.xml

Win XP Home (NL version) passes (test run 5) including some test on nested ;-) The org.apache.tools.ant.ProjectTest.testDuplicateTargets fails however :-( (both on linux (fedora core) and XP / both sun jdk 1.4.2_03) Peter Reilly wrote: Hi, I have added a nested file element to filelist, used as f

Re: cvs commit: ant/src/testcases/org/apache/tools/ant/taskdefs/optional/sitraka ClassFileTest.java

32:13 Modified:src/testcases/org/apache/tools/ant/taskdefs/optional/sitraka Tag: ANT_16_BRANCH ClassFileTest.java Log: Merge from HEAD Prevent ClassFileTest from failing under JDK 1.2 PR: 23919 Submitted by: Martijn Kruithof Revision ChangesPat

Re: [patch] Having execute a nested if the target is out of date

Hi, If you make something like this (I don't see a direct benefit), why not make uptodate an taskcontainer so that you can wrap any task in there without the need of indirection via the sequential task. Kind regards, Martijn. Paul Mclachlan wrote: Basically, I've added the capability for to hav

Re: Execute#getExitCode doesn't work as advertised

Hi Well fair enough, it is recognizable as the exit value will in that case be Integer.MAX_VALUE, so that should not be an issue. (So far for the non-hardcoded values) Thanks, Martijn Stefan Bodewig wrote: On Wed, 17 Sep 2003, Martijn Kruithof <[EMAIL PROTECTED]> wrote: regarding op

Re: Execute#getExitCode doesn't work as advertised

author mailto:[EMAIL PROTECTED]">Charles Hudak + * @author mailto:[EMAIL PROTECTED]">Martijn Kruithof * * @since Ant 1.2 * @@ -96,6 +97,7 @@ private File workingDirectory = null; private Project project = null; private boolean newEnvironment = false; +p

Re: [PATCH] Next round of typo fixes

Hi, nice work, though this set seems to contain a wrong correction (prefixed with ) Kind Regards, Martijn Shatzer, Larry wrote: Thanks, here is the next set. src/main/org/apache/tools/ant/util/UnPackageNameMapper.java still has messed up line endings. -- Larry -Original Message- From

Re: cvs commit: ant/src/main/org/apache/tools/ant/types Permissions.java

Hi, in that case please also apply : Index: docs/manual/CoreTypes/permissions.html === RCS file: /home/cvspublic/ant/docs/manual/CoreTypes/permissions.html,v retrieving revision 1.1 diff -u -r1.1 permissions.html --- docs/manual/CoreTy

Re: cvs commit: ant/src/testcases/org/apache/tools/mail MailMessageTest.java

Antoine Levy-Lambert wrote: Isn't there a danger in using a non-synchronized class ? Otherwise I can gladly switch to ArrayList. Antoine There are wrappers for that (Collections.synchronizedXXX(XXX xxx) XXX = Collection , List, Map, Set, SortedMap or SortedSet. So that should not be an issue. (That

Re: cvs commit: ant/src/main/org/apache/tools/ant/taskdefs MacroDef.java MacroInstance.java PreSetDef.java defaults.properties

Could please @since 1.6 tags be added to the code? - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

CVS down?

Hi, Can it be that public CVS is currently down? I seem to not be able to do updats / create patches anymore. Kind Regards, Martijn - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

<    1   2   3