Re: [VOTE] Ivy 2.5.0-rc1 Release

2018-04-15 Thread Stefan Bodewig
On 2018-04-15, Nicolas Lalevée wrote: >> Le 14 avr. 2018 à 19:02, Stefan Bodewig a écrit : >>> Do you vote for the release of these binaries? >> +1 >> If you want to call them 2.5.0-rc1. If you want the release to be 2.5.0 >> then the names of the archiv

Re: ant git commit: Yet more isEmpty()

2018-04-15 Thread Stefan Bodewig
On 2018-04-15, wrote: > @@ -275,10 +270,7 @@ public class DefaultLogger implements BuildLogger { > new BufferedReader(new > StringReader(event.getMessage( { > message.append(r.lines().map(line -> prefix + line) > -.collect(Co

Re: Mass changes to various projects under Ant umbrella - should we be doing it?

2018-04-15 Thread Stefan Bodewig
On 2018-04-15, Gintautas Grigelionis wrote: > Could you please explain what alternative approach does the "root" > property support It has been added with https://github.com/apache/ant/commit/71333195c9d57d80d1a44cd8362a641c62d5e214 and the commit message states the main use case "running tests f

Re: [VOTE] Ivy 2.5.0-rc1 Release

2018-04-14 Thread Stefan Bodewig
On 2018-04-12, Nicolas Lalevée wrote: > I have built a release candidate for Ivy 2.5.0-rc1. > The git tag of this release is: > https://git-wip-us.apache.org/repos/asf?p=ant-ivy.git;a=tag;h=refs/tags/2.5.0-rc1 > >

Re: ant git commit: More isEmpty()

2018-04-14 Thread Stefan Bodewig
On 2018-04-13, Jaikiran Pai wrote: > I think we could probably document that passing null to such attribute > setters will lead to NullPointerException, which most likely will be > the case in a lot of places other than those that just set the > incoming value to some member variable. Agreed. In

Re: Mass changes to various projects under Ant umbrella - should we be doing it?

2018-04-14 Thread Stefan Bodewig
On 2018-04-13, Gintautas Grigelionis wrote: > 2018-04-13 5:33 GMT+00:00 Stefan Bodewig : >> Ant test cases are not designed to be run from an IDE, this has never >> been a goal. I'm surprised this system property is the only thing you >> need to remember :-) > Well

Re: Junit Task warning about multiple versions of Ant

2018-04-12 Thread Stefan Bodewig
On 2018-04-12, Nicolas Lalevée wrote: > As far as I can see, the classpath used by checkForkedPath is the > proper one. The function which manipulates the classpath to add the > Ant runtime [1] is called before. So I should start looking into the > AntClassLoader which is improperly finding the An

Re: Mass changes to various projects under Ant umbrella - should we be doing it?

2018-04-12 Thread Stefan Bodewig
On 2018-04-12, Gintautas Grigelionis wrote: > 2018-04-12 15:18 GMT+00:00 Stefan Bodewig : >> On 2018-04-12, Gintautas Grigelionis wrote: >>> 2018-04-12 14:39 GMT+00:00 Stefan Bodewig : >>>> On 2018-04-11, Gintautas Grigelionis wrote: >>>>&g

Re: Mass changes to various projects under Ant umbrella - should we be doing it?

2018-04-12 Thread Stefan Bodewig
On 2018-04-12, Gintautas Grigelionis wrote: > 2018-04-12 14:39 GMT+00:00 Stefan Bodewig : >> On 2018-04-11, Gintautas Grigelionis wrote: >>> XMLCatalogTest is an example of unit tests complicated by root property. >> Actually, the test even passes if you remove the

Re: Junit Task warning about multiple versions of Ant

2018-04-12 Thread Stefan Bodewig
On 2018-04-12, Nicolas Lalevée wrote: > The Junit task is printing a warning if it finds multiple versions of > Ant in the classpath of the unit tests. It seems it doesn’t do > correctly the job if the ant runtime is explicitly removed from the > classpath. Quite possible. > Here the function wh

Re: Mass changes to various projects under Ant umbrella - should we be doing it?

2018-04-12 Thread Stefan Bodewig
On 2018-04-11, Gintautas Grigelionis wrote: > 2018-04-11 6:25 GMT+00:00 Jaikiran Pai :´ >> On 10/04/18 12:27 AM, Gintautas Grigelionis wrote: >>> I wrote earlier that I was about to review the unit tests. >>> I was particularly unhappy about the root-property hack for an ancient >>> deficiency i

Re: Mass changes to various projects under Ant umbrella - should we be doing it?

2018-04-11 Thread Stefan Bodewig
On 2018-04-11, Matt Benson wrote: > On Sun, Apr 8, 2018, 11:03 AM Stefan Bodewig wrote: >> We did have one big "cleanup" commit which has been the one that brought >> us the regressions in 1.10.2 and I deeply regret not taking the time >> reviewing the change back

Re: Mass changes to various projects under Ant umbrella - should we be doing it?

2018-04-11 Thread Stefan Bodewig
On 2018-04-09, Gintautas Grigelionis wrote: > I was particularly unhappy about the root-property hack for an ancient > deficiency in Surefire. Could you please expand on this a bit? > I consider my previous commits a sort of a groundwork for > refactorisation of JUnit tests. Would you bear with

Re: ant git commit: More isEmpty()

2018-04-11 Thread Stefan Bodewig
On 2018-04-06, wrote: > http://git-wip-us.apache.org/repos/asf/ant/blob/c3b91f90/src/main/org/apache/tools/ant/types/ArchiveFileSet.java > -- > diff --git a/src/main/org/apache/tools/ant/types/ArchiveFileSet.java > b/src/main/or

InputHandler and end-of-stream

2018-04-11 Thread Stefan Bodewig
Hi while reviewing some changes I realized DefaultInputHandler and SecureInputHandler may create unexpected outcomes if System.in or System.console() signal an end-of-stream and thus readLine/readPassword return null. The former will create an InputRequest with a null getInput() result which may

Re: ant git commit: Use isEmpty() in tasks

2018-04-09 Thread Stefan Bodewig
On 2018-04-06, wrote: > http://git-wip-us.apache.org/repos/asf/ant/blob/73bda1fb/src/main/org/apache/tools/ant/taskdefs/BindTargets.java > -- > diff --git a/src/main/org/apache/tools/ant/taskdefs/BindTargets.java > b/src/main/or

Re: Mass changes to various projects under Ant umbrella - should we be doing it?

2018-04-08 Thread Stefan Bodewig
On 2018-04-07, Gintautas Grigelionis wrote: > Java is a language with the syntax that changes and tries to accomodate new > patterns that make programming more efficient. Some of the patterns you've been changign don't fall into this category for me. Switching if/else blocks, colapsing ifs or rem

Re: Mass changes to various projects under Ant umbrella - should we be doing it?

2018-04-08 Thread Stefan Bodewig
On 2018-04-07, Jaikiran Pai wrote: > I don't mean to appear authoritative but I feel that these mass, > never-ending changes to various projects under the Ant umbrella, > related to formatting, coding style, whitespaces, syntax changes and > such aren't really worth it. We've done some systematic

Re: [2/4] ant git commit: Remove extraneous casts and (un)boxing, tersify logic

2018-04-06 Thread Stefan Bodewig
On 2018-04-01, wrote: > http://git-wip-us.apache.org/repos/asf/ant/blob/95495d57/src/main/org/apache/tools/bzip2/BlockSort.java > -- > diff --git a/src/main/org/apache/tools/bzip2/BlockSort.java > b/src/main/org/apache/tools/bzi

Re: JunitTestRunner commit

2018-04-05 Thread Stefan Bodewig
On 2018-04-05, Maarten Coene wrote: > I think I finally got it merged into the 1.9.x branch... yes, looks good. > (Where are the days where everything was so easy with SVN ;-)) I've maintained svn branches long enough to recall merging is a pain regardless of which SCM you use :-) > I did a li

Re: [2/2] ant git commit: Merge branch 'master' of https://git-wip-us.apache.org/repos/asf/ant

2018-04-05 Thread Stefan Bodewig
On 2018-04-05, Maarten Coene wrote: > Sorry, I have no idea what this is... should it be reverted? No, you haven't really changed anything. Your "fix typo" commit was based on a version of the master branch that is older than the HEAD at apache as you didn't update your local copy first. When yo

Re: JunitTestRunner commit

2018-04-04 Thread Stefan Bodewig
On 2018-04-04, Maarten Coene wrote: > Since this is more or less my first commit to the Ant codebase, could > someone please review my change to JunitTestRunner ? Typo in WHATSNEW (until rather than untill). I think the change is good, although I'm not sure whether there is a difference in how a

Re: File type mapping in external task

2018-04-04 Thread Stefan Bodewig
On 2018-04-03, Gilles Querret wrote: > If I have an attribute mapped to a File type (such as setSrcDir(File file) > { this.srcDir = file; } ), then passing an empty string (as in srcDir="" ) leads to srcDir set to baseDir (or current directory, not sure). baseDir :-) > Is there a way to trap th

Re: SBT branch in Ivy repo

2018-03-29 Thread Stefan Bodewig
On 2018-03-29, Gintautas Grigelionis wrote: > IMHO sbt fork happened because Ivy was not using Git then. I don't understand. Either they have changed Ivy or could have used binaries. If they had to change Ivy the question is what did they have to change. > So my idea is to graft their branch ont

Re: SBT branch in Ivy repo

2018-03-29 Thread Stefan Bodewig
On 2018-03-25, Gintautas Grigelionis wrote: > I asked sbt developers [1] whether they would like to use the same Git > repo. The consensus seems to be that sbt would like to have their own > branch (or two). Would it be acceptable to graft sbt branch(es) to Ivy repo? I'm not sure I understand the

[ANN] Apache Ant 1.9.11 and 1.10.3 Released

2018-03-27 Thread Stefan Bodewig
hen running on Java 11+ rmic will fail early if iiop or idl are requested. Java11 removes support for CORBA and the switches have been removed from the rmic tool. For complete information on Ant, including instructions on how to submit bug reports, patches, or suggestions for improvement, see

[RESULT] Release Ant 1.10.3 based on RC2

2018-03-27 Thread Stefan Bodewig
Hi all with +1s by Jaikiran Pai Stefan Bodewig Maarten Coene and no other votes the vote has passed. I'll publish the artifacts and update the site/announce the release tomorrow (CET) when the mirrors have caught up. Many thanks to those who took the time to verify the RCs. S

[RESULT] Release Ant 1.9.11 based on RC1

2018-03-27 Thread Stefan Bodewig
Hi all with +1s by Jaikiran Pai Stefan Bodewig Maarten Coene and no other votes the vote has passed. I'll publish the artifacts and update the site/announce the release tomorrow (CET) when the mirrors have caught up. Many thanks to those who took the time to verify the RCs. S

Release Candidates Lacking Votes

2018-03-27 Thread Stefan Bodewig
Hi all the vote deadline for the 1.9.11 RC ended more than twelve hours ago, the one for 1.10.3 will end in about five hours. Both currently lack at least one +1. I intend to keep both votes open long enough to receive the additional +1 - at least for a bit - before I consider the votes failed. S

Re: [VOTE] Release Ant 1.10.3 based on RC2

2018-03-25 Thread Stefan Bodewig
On 2018-03-24, Stefan Bodewig wrote: > git tag: ANT_1.10.3_RC2 > on commit: 1b9cc239e +1 Stefan - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

Re: [VOTE] Release Ant 1.9.11 based on RC1

2018-03-25 Thread Stefan Bodewig
On 2018-03-23, Stefan Bodewig wrote: > I've created a release candidate for 1.9.11: > git tag: ANT_1_9_11_RC1 > on commit: 6f58cfd +1 Stefan - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org

[VOTE] Release Ant 1.10.3 based on RC2

2018-03-24 Thread Stefan Bodewig
Hi all I've created a new release candidate for 1.10.3 incorporating the doc fix for junitlauncher: git tag: ANT_1.10.3_RC2 on commit: 1b9cc239e tarballs: https://dist.apache.org/repos/dist/dev/ant/ revision: 25934 Maven artifacts: https://repository.apache.org/content

[CANCEL][VOTE] Release Ant 1.10.3 based on RC1

2018-03-24 Thread Stefan Bodewig
Hi all with the manual of the junitlauncher task being wrong in crucial parts, I cancel this vote and will cut RC2 later today. Cheers Stefan - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional comma

junitlauncher doc fix (was Re: [VOTE] Release Ant 1.10.3 based on RC1)

2018-03-24 Thread Stefan Bodewig
On 2018-03-24, Jaikiran Pai wrote: > I'm not sure if for the documentation fix (which I have pushed > upstream) we need to redo a new RC release. If I understand your change correctly then the manual as would be released with 1.10.3 is plain wrong and will cause people who trust it to bang their

[VOTE] Release Ant 1.10.3 based on RC1

2018-03-23 Thread Stefan Bodewig
Hi all I've created a release candidate for 1.10.3: git tag: ANT_1.10.3_RC1 on commit: d00658c tarballs: https://dist.apache.org/repos/dist/dev/ant/ revision: 25917 Maven artifacts: https://repository.apache.org/content/repositories/orgapacheant-1024/org/apache/ant/

Re: [VOTE] Release Ant 1.9.11 based on RC1

2018-03-23 Thread Stefan Bodewig
correction, the Maven artifacts are at https://repository.apache.org/content/repositories/orgapacheant-1022/org/apache/ant/ Sorry Stefan On 2018-03-23, Stefan Bodewig wrote: > Hi all > I've created a release candidate for 1.9.11: > git tag: ANT_1_9_11_RC1 >

[VOTE] Release Ant 1.9.11 based on RC1

2018-03-23 Thread Stefan Bodewig
Hi all I've created a release candidate for 1.9.11: git tag: ANT_1_9_11_RC1 on commit: 6f58cfd tarballs: https://dist.apache.org/repos/dist/dev/ant/ revision: 25910 Maven artifacts: https://repository.apache.org/content/repositories/orgapacheant-1120/org/apache/ant/

Ant Releases

2018-03-22 Thread Stefan Bodewig
Hi all unless anybody objects I'd cut releases from both active branches tomorrow evening (central european time). Any reasons I should hold back? Stefan - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional c

Re: Snapshot access to regular users of Ant

2018-03-20 Thread Stefan Bodewig
On 2018-03-19, Gintautas Grigelionis wrote: > Maybe Ant Task Guidelines could be exposed under under "Contributing" > as a landing page, and the relevant information could be moved into > the manual? The tutorials as well as the Ant task guidelines have always been only attachments to the manual

Re: junitlauncher dependency on JUnit4?

2018-03-20 Thread Stefan Bodewig
On 2018-03-20, Jaikiran Pai wrote: > This looks like some odd merge or squashing issue when I pushed that > task changes. I have fixed it. The task itself doesn't need any JUnit > test engine specific dependencies like this one. I just pushed the > commit upstream which should fix this. Looks goo

Re: junitlauncher dependency on JUnit4?

2018-03-20 Thread Stefan Bodewig
On 2018-03-20, Gintautas Grigelionis wrote: > My understanding is that junitlauncher has a dependency on JUnit 4 through > vintage engine. I guess pom should provide profiles for engine choice. See > my earlier questions re the task classpath. Only when running the tests. The launcher task itself

junitlauncher dependency on JUnit4?

2018-03-20 Thread Stefan Bodewig
Hi I've just added a POM for ant-junitlauncher and it currently fails to build as org.apache.tools.ant.taskdefs.optional.junitlauncher.SingleTestClass has a dependency on org.junit.Test and I haven't declared any dependency on JUnit4 inside the POM (only transitively with scope test). The class h

Re: signjar-test failures in Jenkins

2018-03-20 Thread Stefan Bodewig
On 2018-03-20, Stefan Bodewig wrote: > it looks as if I had broken every single Jenkins build. Of course the > test pass on my machine with all JDKs I've got installed. No, it fails on Java10 for me, because jarsigner -verify now dies for a self-signed certificate. I'll try to

signjar-test failures in Jenkins

2018-03-20 Thread Stefan Bodewig
Hi all it looks as if I had broken every single Jenkins build. Of course the test pass on my machine with all JDKs I've got installed. Can anybody who gets test errors in his/her local environment please run ./build.sh -f src/tests/antunit/taskdefs/signjar-test.xml testVerifyJarStrictPKCS12 -v

Re: Snapshot access to regular users of Ant

2018-03-19 Thread Stefan Bodewig
On 2018-03-19, Gintautas Grigelionis wrote: > Starting from > https://rawgit.com/apache/ant/master/manual/tutorial-tasks-filesets-properties.html#contribute > to the end of document. Cf > https://ant.apache.org/manual/tutorial-tasks-filesets-properties.html#contribute > which still talks about

Re: Snapshot access to regular users of Ant

2018-03-19 Thread Stefan Bodewig
On 2018-03-17, Gintautas Grigelionis wrote: > On the other hand, I rewrote the manual (which was still talking about > CVS), suggesting that the proper way to propose code changes would be > a GitHub PR rather than an archive uploaded to Bugzilla, so please > correct me if I'm wrong before Ant 1.1

Re: Snapshot access to regular users of Ant

2018-03-19 Thread Stefan Bodewig
On 2018-03-17, Jaikiran Pai wrote: > I was about to send a mail to the user mailing list about the Ant > nightly job which publishes the daily snapshots, so that they can test > some bug fixes and new features (JUnit 5 in particular). However, I > happened to read the Apache release policy[1] whic

Re: When is Ant 1.10.3 release expected?

2018-03-19 Thread Stefan Bodewig
On 2018-03-17, Jaikiran Pai wrote: > I (finally) merged the JUnit 5 work to master. Rest of the fork > related work for this task is something that I don't plan to make > available in this release (the work is going to take some time). So I > guess, we can make a new release. I can see whether I

Re: User implementations of custom interfaces can have access to Task instance?

2018-03-19 Thread Stefan Bodewig
On 2018-03-17, Jaikiran Pai wrote: > Thanks for the input, Stefan. I took your suggestion and exposed a API > to get the Project on that custom interface. It doesn't/can't directly > use the IntrospectionHelper support available to project components, > since unlike nested elements of a task, this

Re: User implementations of custom interfaces can have access to Task instance?

2018-03-13 Thread Stefan Bodewig
On 2018-03-13, Jaikiran Pai wrote: > I'm looking for some suggestion on whether it's a good/bad idea to > expose a method to custom user defined classes which takes a "Task" > object. This is in context of the JUnitLauncher task that I recently > added. It allows custom report formatters/listeners

Re: When is Ant 1.10.3 release expected?

2018-03-12 Thread Stefan Bodewig
On 2018-03-12, Sarika Sinha wrote: > After 1.10.2 release and the regression bug, do we see 1.10.3 getting > released early? Whatever early means :-) https://lists.apache.org/thread.html/169de63328f60269e88a37446f27549733f9f57e8de6778276c581a1@%3Cdev.ant.apache.org%3E We informally decided to c

Re: JDK 10: Release Candidate & JDK 11 Early Access builds available

2018-03-05 Thread Stefan Bodewig
Hi all no surprises with Java10 in Ant land. Of course some of our tests that use rmic -iiop/-idl have been broken on Java11 because of JEP320. Starting with Ant 1.10.3 and 1.9.11 Ant is going to fail with a more useful error message and tests have been adapted. Stefan -

Re: Ant documentation

2018-03-02 Thread Stefan Bodewig
On 2018-03-02, Gintautas Grigelionis wrote: > 2018-03-02 9:54 GMT+01:00 Stefan Bodewig : >> On 2018-03-01, Stefan Bodewig wrote: >>>> On Thu, Mar 1, 2018 at 7:28 AM, Gintautas Grigelionis < >>>> g.grigelio...@gmail.com> wrote: >>>>> I tri

Re: Ant documentation

2018-03-02 Thread Stefan Bodewig
On 2018-03-01, Stefan Bodewig wrote: >> On Thu, Mar 1, 2018 at 7:28 AM, Gintautas Grigelionis < >> g.grigelio...@gmail.com> wrote: >>> I tried then to use the replacement tags as consistently as possible in >>> such a large body of text, but I realised that w

Re: Ant test failures on Java 9

2018-03-01 Thread Stefan Bodewig
On 2018-03-01, Gintautas Grigelionis wrote: > Build File: .../src/tests/antunit/taskdefs/copy-test.xml > Tests run: 26, Failures: 0, Errors: 2, Time elapsed: 8,59 sec Passes for me locally as well as on Jenkins https://builds.apache.org/view/A-D/view/Ant/job/Ant-Build-Matrix-master-Linux/OS=xeni

Re: Ant documentation

2018-03-01 Thread Stefan Bodewig
On 2018-03-01, Dominique Devienne wrote: > On Thu, Mar 1, 2018 at 7:28 AM, Gintautas Grigelionis < > g.grigelio...@gmail.com> wrote: >> I tried then to use the replacement tags as consistently as possible in >> such a large body of text, but I realised that we perhaps need a kind of a >> style gu

Re: svn commit: r1825596 - /ant/site/ant/build.xml

2018-02-28 Thread Stefan Bodewig
On 2018-02-28, Jan Matèrne (jhm) wrote: > @Stefan: You added the 1.9 manual. Do you think we could upate the > manuals this way? The online manual also contains the javadocs, these ate not present in the git repo. I simply extracted the manual archive of the distribution artifact. Stefan -

Re: committer += gintas

2018-02-28 Thread Stefan Bodewig
On 2018-02-28, Jan Matèrne (jhm) wrote: > - build, inactive repo, last change 2007, not used any more (I think) I don't even recall what it was :-) > If we want to migrate the site repo, we should also think about > handling the sandbox. I think we just never migrated it because it simply wasn'

Re: Ant 1.9.10 and Ivy

2018-02-28 Thread Stefan Bodewig
On 2018-02-28, Jaikiran Pai wrote: >> I'll grep through the sources and revert all changes to clone >> signatures unless anybody else beats me to it. > Done > https://github.com/apache/ant/commit/2e788849136bfd75e88ce0d959810f1191d43a33 Thanks Stefan ---

Re: Ant 1.9.10 and Ivy

2018-02-27 Thread Stefan Bodewig
On 2018-02-27, Gintautas Grigelionis wrote: > More specifically, that's Ant 1.10.2 thing... so, one more regression in > master, I suppose. 1.10.1 and 1.9.10 work fine. > Gintas > 2018-02-27 20:23 GMT+01:00 Gintautas Grigelionis : >> After Ant dependency in Ivy was updated to 1.9.10, I'm gettin

Re: Ivy release instructions

2018-02-27 Thread Stefan Bodewig
On 2018-02-27, Jaikiran Pai wrote: > The first round of this might not be publicly usable and we might have > to redo the steps as and when we fix things in the release process. So > maybe we should attempt an intermediate release before doing a 2.5.0. As long as we stop before pushing anything i

Re: Ivy release this month?

2018-02-18 Thread Stefan Bodewig
On 2018-02-18, Gintautas Grigelionis wrote: > 2018-02-18 20:30 GMT+01:00 Stefan Bodewig : >> On 2018-02-18, Gintautas Grigelionis wrote: >>>- https://github.com/apache/ant-ivy/pull/63 (has to do with choice of >>>generics, with are not set in stone yet); >

Re: Ant support for users who use JUnit5

2018-02-18 Thread Stefan Bodewig
On 2018-02-15, Jaikiran Pai wrote: > I'm now done with the initial goals that I had in mind for this > task. I've opened a PR[1] for review. I've included a manual for this > task and it can be currently found here[2]. I would suggest reading > the manual first, before reviewing the PR, since the

Re: Ivy release this month?

2018-02-18 Thread Stefan Bodewig
[Personally I prefer discussion by email over discussion in github issues.] On 2018-02-18, Gintautas Grigelionis wrote: >- https://github.com/apache/ant-ivy/pull/63 (has to do with choice of >generics, with are not set in stone yet); changes the generic type of an argument of a public me

New Release(s)?

2018-02-18 Thread Stefan Bodewig
Hi all https://bz.apache.org/bugzilla/show_bug.cgi?id=62086 is a serious regression in 1.10.2 and it has been fixed in master by now. The 1.9.x branch has never been affected. By now I have reviewed all changes of the really big commit that also caused the regression. I found a few more places th

Re: Ant support for users who use JUnit5

2018-02-16 Thread Stefan Bodewig
On 2018-02-15, Jaikiran Pai wrote: > I'm now done with the initial goals that I had in mind for this > task. I've opened a PR[1] for review. I've included a manual for this > task and it can be currently found here[2]. I would suggest reading > the manual first, before reviewing the PR, since the

Re: Need a Second Pair of Eyes

2018-02-14 Thread Stefan Bodewig
On 2018-02-14, Stefan Bodewig wrote: > On 2018-02-14, Jaikiran Pai wrote: >> You are right. The change introduces a different behaviour than what >> was there before. Just to be extra sure that we indeed are reading it >> right, I added a (dummy) test case in my personal

Re: Need a Second Pair of Eyes

2018-02-14 Thread Stefan Bodewig
On 2018-02-14, Jaikiran Pai wrote: > You are right. The change introduces a different behaviour than what > was there before. Just to be extra sure that we indeed are reading it > right, I added a (dummy) test case in my personal repo, which compares > the previous logic and the new logic and it d

Need a Second Pair of Eyes

2018-02-13 Thread Stefan Bodewig
Hi all I'm currently reviewing the big change that introduced the regression in 1.10.2 as we may have overlooked more than this issue. It is a *big* change and so it is taking time. While looking at the hunk starting at https://github.com/apache/ant/commit/b7d1e9bde44cb8e5233d6e70bb96e14cbb2f3e2

Re: Include user mailing list for RC release?

2018-02-10 Thread Stefan Bodewig
On 2018-02-10, Jaikiran Pai wrote: > Our recent release of Ant showed up a major issue[1] which impact Ant > users. The issue was found almost as soon as Ant was released, thanks > to the user upgrading to this newer version. I think this is an issue > which could have been caught before the relea

Re: Mapped resources NPEs - Potential fix causes a failure in one specific test

2018-02-09 Thread Stefan Bodewig
Jaikiran, just to avoid duplicate work, I'm currently running tests on the 1.9.x branch where I fix a bunch a FileNameMapper implementations that wouldn't handle null sourceFileNames (which could happen for resources that retun null for getName) as well as several other places that didn't check th

Re: Mapped resources NPEs - Potential fix causes a failure in one specific test

2018-02-09 Thread Stefan Bodewig
On 2018-02-09, Jaikiran Pai wrote: > That test was introduced long back as part of [5] to test another > similar NPE. I think with the change I now have, it no longer reaches > this place in the code where the Copy task would end up getting a null > from a mapper, because various other utility cla

Apache EU Roadshow in Berlin 13-14 June

2018-02-08 Thread Stefan Bodewig
Hi all I'm not sure whether you've seen the announcement of an Apache community happening this summer at the same time and place as FOSS Backstage https://blogs.apache.org/foundation/entry/the-apache-software-foundation-announces28 The CfP for this is still open http://apachecon.com/euroadshow1

Re: ant git commit: Generate manifest files and add automatic module names for JPMS

2018-02-07 Thread Stefan Bodewig
On 2018-02-07, Gintautas Grigelionis wrote: > 2018-02-07 11:44 GMT+01:00 Stefan Bodewig : >> My fear is that if the classpath world stops working then a completely >> different version of Ant will be required. A version that has to break >> backwards compatibility in many

Re: [SECURITY] CVE-2017-5645: Apache Ant 1.9.9 and 1.10.1 - Apache Log4j 1.2.13 security vulnerability

2018-02-07 Thread Stefan Bodewig
On 2018-02-07, Gintautas Grigelionis wrote: > The CVE says it affects SocketServer up to Log4j 2.8.2, so it's not only > Log4j 1.x issue. Did I miss something? The subject is how it has been reported to us. Prior to the latest releases you have not been able to use log4j2 so there is no reason t

Re: ant git commit: Generate manifest files and add automatic module names for JPMS

2018-02-07 Thread Stefan Bodewig
On 2018-02-06, Gintautas Grigelionis wrote: > 2018-02-06 11:05 GMT+01:00 Stefan Bodewig : >> If the taskdef/typedef implementation classes are loaded via a module >> path and a custom task lives on the CLASSPATH will taskdef be able to >> load it at all? > Anything on

[ANN] Apache Ant 1.9.10 and 1.10.2 Released

2018-02-06 Thread Stefan Bodewig
submit bug reports, patches, or suggestions for improvement, see the Apache Ant website: http://ant.apache.org/ Stefan Bodewig, on behalf of the Apache Ant community -BEGIN PGP SIGNATURE- Version: GnuPG v1 iEYEARECAAYFAlp6jS4ACgkQohFa4V9

Release Notes for 1.10.2 and 1.9.10

2018-02-06 Thread Stefan Bodewig
Hi all as you can witness in https://svn.apache.org/viewvc/ant/site/ant/sources/antnews.xml?r1=1823368&r2=1823367&pathrev=1823368 I don't really know which change to highlight specifically. The announcement is going to contain all changes, is there any one or two changes you think we should highl

[RESULT] Release Apache Ant 1.10.2 based on RC1

2018-02-06 Thread Stefan Bodewig
On 2018-02-03, Stefan Bodewig wrote: > Hi all > I've created a release candidate for 1.10.2: Jan Matèrne Jaikiran Pai Stefan Bodewig and no other votes the vote has passed. I'll publish the artifacts and give the mirrors a few hours time to catch up before updating the site

[RESULT] Release Ant 1.9.10 based on RC1

2018-02-06 Thread Stefan Bodewig
On 2018-02-03, Stefan Bodewig wrote: > I've created a release candidate for 1.9.10: with +1s by Jaikiran Pai Jan Matèrne Maarten Coene Stefan Bodewig and no other votes the vote has passed. Stefan - To unsubscribe

Re: github PR builds

2018-02-06 Thread Stefan Bodewig
On 2018-02-06, Jaikiran Pai wrote: > The PR build on Jenkins is backed by the github PR integration > plugin[1]. One of the features of that plugin is to prevent some > malicious/rogue PR (imagine someone creating a PR with code which does > some odd things with the host on which it runs) being au

Re: ant git commit: Do not add automatic module names

2018-02-06 Thread Stefan Bodewig
On 2018-02-06, wrote: > Do not add automatic module names thank you Stefan - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

github PR builds

2018-02-06 Thread Stefan Bodewig
Hi if I understand correctly our current PR build setup with Jenkins requires somebody to comment on the issue in order to have Jenkins build it. Do we really want this extra step? For Commons Compress I never thought about something like that. If we do, how does Jenkins know who is allowed to t

Re: [VOTE] Release Apache Ant 1.10.2 based on RC1

2018-02-06 Thread Stefan Bodewig
On 2018-02-03, Stefan Bodewig wrote: > git tag: ANT_1.10.2_RC1 > on commit: 0eba7eb +1 Stefan - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

Re: [VOTE] Release Ant 1.9.10 based on RC1

2018-02-06 Thread Stefan Bodewig
On 2018-02-03, Stefan Bodewig wrote: > git tag: ANT_1_9_10_RC1 > on commit: 528c94e +1 Stefan - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

Re: ant git commit: Generate manifest files and add automatic module names for JPMS

2018-02-06 Thread Stefan Bodewig
On 2018-02-06, Jaikiran Pai wrote: > don't think we should be doing any of these commits especially when > there's a RC out which we plan to release. In general we live in a commit then review world, so I think it is kind of OK to perform bigger changes without discussion upfront. It would have

Re: ant git commit: Generate manifest files and add automatic module names for JPMS

2018-02-06 Thread Stefan Bodewig
On 2018-02-05, Gintautas Grigelionis wrote: > I adjusted the proposal and I hope that I addressed your criticism. Unfortunately it doesn't. I'm afraid that we would be sending a wrong signal here. On top of that I don't think Ant would actually work if parts of it are used as modules. We use cla

Re: ant git commit: Generate manifest files and add automatic module names for JPMS

2018-02-05 Thread Stefan Bodewig
> Generate manifest files and add automatic module names for JPMS -1 please remove the Automatic-Module-Name attributes as our jars are no proper JPMS modules. Stefan - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org Fo

Re: [VOTE] Release Apache Ant 1.10.2 based on RC1

2018-02-05 Thread Stefan Bodewig
On 2018-02-05, Gintautas Grigelionis wrote: > Houston, we have a problem: JPMS explicitly forbids broken packages. I was about to answer this to your Automatic-Module-Name question. Ant's jar can never be Java9 modules. If we wanted them to be modules, we'd have to move classes and seriously bre

Re: ant-ivy git commit: IVY-1569 Avoid reflection warnings (or worse) in Java 9+

2018-02-04 Thread Stefan Bodewig
On 2018-02-05, Jaikiran Pai wrote: > On 02/02/18 11:49 PM, gin...@apache.org wrote: >> Repository: ant-ivy >> Updated Branches: >>refs/heads/master 1d3567f30 -> 7ebc8107a >> IVY-1569 Avoid reflection warnings (or worse) in Java 9+ >>>private static int getJavaVersion() { >>>//

Re: Issues with Downloading Ant's dependencies

2018-02-04 Thread Stefan Bodewig
On 2018-02-03, Gintautas Grigelionis wrote: > My turn to say "sorry for being a PITA" ;-) > I broke fetch.xml and JetBrains CI -- should have been more attentive to > their builds. I'm not sure anybody is looking at the JetBrains CI builds (I don't). Don't worry, stuff happens. Stefan -

[VOTE] Release Apache Ant 1.10.2 based on RC1

2018-02-03 Thread Stefan Bodewig
Hi all I've created a release candidate for 1.10.2: git tag: ANT_1.10.2_RC1 on commit: 0eba7eb tarballs: https://dist.apache.org/repos/dist/dev/ant/ revision: 24668 Maven artifacts: https://repository.apache.org/content/repositories/orgapacheant-1021/org/apache/ant/

[VOTE] Release Ant 1.9.10 based on RC1

2018-02-03 Thread Stefan Bodewig
Hi all I've created a release candidate for 1.9.10: git tag: ANT_1_9_10_RC1 on commit: 528c94e tarballs: https://dist.apache.org/repos/dist/dev/ant/ revision: 24666 Maven artifacts: https://repository.apache.org/content/repositories/orgapacheant-1020/org/apache/ant/

Re: Issues with Downloading Ant's dependencies

2018-02-03 Thread Stefan Bodewig
On 2018-02-03, Stefan Bodewig wrote: > and this seems to indicate the groupId for jai-codec should be > javax.media rather than com.sun.media. which leads to src/main/org/apache/tools/ant/taskdefs/optional/image/Image.java:45: error: package com.sun.media.jai.codec does not exist

Re: Issues with Downloading Ant's dependencies

2018-02-03 Thread Stefan Bodewig
On 2018-02-03, Stefan Bodewig wrote: > Hi all > I'm starting to cut the releases and wanted to make sure I build against > the latest dependency updates. > When running "ant -f fetch.xml -Ddest=optional" on the 1.9.x branch I > end up with ... > | Un

Issues with Downloading Ant's dependencies

2018-02-03 Thread Stefan Bodewig
Hi all I'm starting to cut the releases and wanted to make sure I build against the latest dependency updates. When running "ant -f fetch.xml -Ddest=optional" on the 1.9.x branch I end up with , | jai: | Downloading: javax/media/jai-core/1.1.3/jai-core-1.1.3.pom from repository central at h

Re: Java 9 test failures

2018-01-29 Thread Stefan Bodewig
On 2018-01-29, Jan Matèrne (jhm) wrote: >> Well, the task wil not work with any future Java releases since the >> internal APIs are not comming back. >> Meanwhile, a quick search shows that while there is quite a lot >> activity with image io, there is no equivalent of JAI.create() for >> image t

Re: Java 9 test failures

2018-01-29 Thread Stefan Bodewig
On 2018-01-29, Gintautas Grigelionis wrote: > So, what can we do about com.sun.image.codec.jpeg that is finally gone in > Java 9? > BTW, I looked into the package dependencies in Java 8, and > com.sun.image.codec.jpeg needs sun.awt.image.codec which in turn has JNI to > native libraries. > The pos

Re: Ant Nightly Build Job in Jenkins

2018-01-28 Thread Stefan Bodewig
On 2018-01-28, Stefan Bodewig wrote: > On 2018-01-28, Jan Matèrne (jhm) wrote: >> Updated the target to use actual 2.5.8. But there is still a problem >> when using two formatters, so I commented the txt-formatter out. BTW, does this build run any tools that are not also part o

Re: Ant Nightly Build Job in Jenkins

2018-01-28 Thread Stefan Bodewig
On 2018-01-28, Jan Matèrne (jhm) wrote: > Updated the target to use actual 2.5.8. But there is still a problem > when using two formatters, so I commented the txt-formatter out. Thanks! Stefan - To unsubscribe, e-mail:

<    1   2   3   4   5   6   7   8   9   10   >