[GitHub] ant-ivy issue #66: IVY-1545 Detect circular dependencies in POMs

2018-02-02 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/66 @javabrett - could you please rebase your branch and force push? --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org

[GitHub] ant-ivy pull request #66: IVY-1545 Detect circular dependencies in POMs

2018-02-02 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/66 IVY-1545 Detect circular dependencies in POMs You can merge this pull request into a Git repository by running: $ git pull https://github.com/javabrett/ant-ivy IVY-1545 Alternatively you can

[GitHub] ant-ivy issue #65: IVY-1485 Ensure dependency is applicable to all configura...

2018-02-01 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/65 @jaikiran please let me know if you did some addition coding, otherwise I hope you would rather focus on JUnit 5 ð

[GitHub] ant-ivy pull request #65: IVY-1485 Ensure dependency is applicable to all co...

2018-02-01 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/65 IVY-1485 Ensure dependency is applicable to all configurations I adopted a patch by @tbingaman You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] ant-ivy issue #64: IVY-1280 Support preemptive authentication

2018-02-01 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/64 I have noticed that. Perhaps it's enough to document that preemptive authentication only works with basic scheme

[GitHub] ant-ivy pull request #64: IVY-1280 Support preemptive authentication

2018-02-01 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/64 IVY-1280 Support preemptive authentication I adopted a patch by @AurelienLourot You can merge this pull request into a Git repository by running: $ git pull https://github.com/twogee/ant-ivy

[GitHub] ant pull request #:

2018-01-23 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant/commit/1465c4581ace84548ec9dfc487d62cfec14d84ad#commitcomment-27040319 What about upgrading to 2.x with 1.x compatibility API? (ditto for Commons Logging). Any comments, @bodewig

[GitHub] ant pull request #:

2018-01-22 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant/commit/538b7c9ffee7a18064f7726c8b20faf681adb218#commitcomment-27018577 I'd rather upgrade to Log4j 2.x :smile: --- - To unsubscribe

[GitHub] ant issue #54: Let’s use Ivy (properly!) and drop Maven Ant tasks + Common...

2018-01-18 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant/pull/54 I revised the documentation as suggested and added correct entries for Groovy in the process. --- - To unsubscribe, e-mail: dev

[GitHub] ant-ivy issue #55: use the vectorised logo

2018-01-08 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/55 Thanks for recapitulating the issues; headers and javadoc corrected. I tested the xsl using the buildfile provided above (without pointing out the xsl explicitly), so I tend to suspect you're

[GitHub] ant-ivy pull request #63: IVY-1486 respect exclude regardless of order

2018-01-08 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/63 IVY-1486 respect exclude regardless of order You can merge this pull request into a Git repository by running: $ git pull https://github.com/twogee/ant-ivy ivy-1486 Alternatively you can

[GitHub] ant issue #54: Let’s use Ivy (properly!) and drop Maven Ant tasks, Commons...

2017-12-28 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant/pull/54 Good idea. Meanwhile, I'd like commit the pkg-distribution target sans python to avoid distraction. --- - To unsubscribe, e-mail: dev

[GitHub] ant issue #54: Let’s use Ivy (properly!) and drop Maven Ant tasks, Commons...

2017-12-28 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant/pull/54 I am very well aware of your role. I hope we agree about KISS or continuous improvement, though. In particular, regarding the second point, please compare `release/ivy.xml` with `ivy.xml` (too

[GitHub] ant issue #54: Let’s use Ivy (properly!) and drop Maven Ant tasks, Commons...

2017-12-27 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant/pull/54 Re password input: isn't there a [task](https://ant.apache.org/manual/Tasks/input.html) with SecureInputHandler

[GitHub] ant issue #54: Let’s use Ivy (properly!) and drop Maven Ant tasks, Commons...

2017-12-27 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant/pull/54 `buildosxpackage` was peanuts compared to getting rid of `root` system property kludge for surefire in tests. BTW, Ivy `signer` saves you work with 1. signing in advance 2. having

[GitHub] ant pull request #:

2017-12-27 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant/commit/d43d83e0198f86c9233631bcb443da132e394d65#commitcomment-26504265 Thanks for catching this one up, a slip of attention while backporting changes in master

[GitHub] ant issue #54: Let’s use Ivy (properly!) and drop Maven Ant tasks, Commons...

2017-12-27 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant/pull/54 I would like to point out one distinction: I would like to replace the stuff that works (sort of) with **less** stuff that does the same job, and hopefully more. Besides, my beef with Maven Ant tasks

[GitHub] ant issue #53: Optional libraries for Ant 1.10

2017-12-27 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant/pull/53 I see `dest` as a useful functionality of fetch.xml (why else should it be a part of the distribution?); and that is basically the crux of the matter. I will update the documentation, thanks

[GitHub] ant pull request #54: Let’s use Ivy (properly!) and drop Maven Ant tasks, ...

2017-12-26 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant/pull/54 Let’s use Ivy (properly!) and drop Maven Ant tasks, Commons OpenPGP, … … Python, etc. The implementation is incomplete, please comment. I put extraneous stuff in `attic` subdirectory

[GitHub] ant pull request #53: Optional libraries for Ant 1.10

2017-12-25 Thread twogee
Github user twogee closed the pull request at: https://github.com/apache/ant/pull/53 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant issue #53: Optional libraries for Ant 1.10

2017-12-24 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant/pull/53 IMHO, the whole point with `-Ddest` in `fetch.xml` is being able to complement `$ANT_HOME/lib` in Ant distribution. Otherwise, we may just use Ivy and put the dependencies (except NetREXX) into `ivy.xml

[GitHub] ant issue #53: Optional libraries for Ant 1.10

2017-12-24 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant/pull/53 I assumed that the intention of fetch.xml is to provide something usable in runtime rather than at compile time. Nevertheless, I'd rather leave JRuby as it is, since the newer versions have a lot

[GitHub] ant pull request #:

2017-12-21 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant/commit/1a2c33fd0ef9dfc042044277707d7f38b0cfa0b0#commitcomment-26409414 Somebody with a sense of humour has a `@Deprecated` account on GitHub :rofl

[GitHub] ant pull request #:

2017-12-20 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant/commit/242d661161ddf2b28e6df23847c1471ee788bab7#commitcomment-26396824 In src/main/org/apache/tools/ant/util/SymbolicLinkUtils.java: In src/main/org/apache/tools/ant/util/SymbolicLinkUtils.java on line

[GitHub] ant pull request #53: Optional libraries for Ant 1.10

2017-12-19 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant/pull/53 Optional libraries for Ant 1.10 A bit unsure about JRuby: should we stay with 1.7 for a while or go for 9? In any case, would jruby-core be sufficient, or should jruby-stdlib be added, too? You can

[GitHub] ant pull request #50: Use newer third party libraries

2017-12-19 Thread twogee
Github user twogee closed the pull request at: https://github.com/apache/ant/pull/50 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org

[GitHub] ant issue #50: Use newer third party libraries

2017-12-19 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant/pull/50 I squashed the commits so the change is easier to apply to 1.9.x --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org

[GitHub] ant pull request #:

2017-12-18 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant/commit/6f5db5e0689c0bea88f16f018be875ef9840825b#commitcomment-26338779 Shouldn't we use HTML entities (eg )? Is HTML 3 is a requirement, too? :confused

[GitHub] ant issue #50: Use newer third party libraries

2017-12-13 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant/pull/50 I intended it for 1.9.x in particular. I will open a new request for master later (with commons-net 3.6, for example

[GitHub] ant issue #50: Use newer Maven Ant tasks

2017-12-13 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant/pull/50 I reviewed third party libraries that could be updated; the documentation could be more emphatic about jspc being deprecated

[GitHub] ant issue #50: Use newer Maven Ant tasks

2017-12-13 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant/pull/50 SLF4J was written by the [author of Log4j](https://en.wikipedia.org/wiki/Log4j) who wrote [an article](https://articles.qos.ch/classloader.html) cataloguing the problems with Commons Logging. When

[GitHub] ant issue #50: Use newer Maven Ant tasks

2017-12-13 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant/pull/50 I updated WHATSNEW and added a replacement for all legacy logging frameworks. There are more potential updates: Java Mail API, Rhino, Jasper; perhaps they deserve a separate PR

[GitHub] ant issue #50: Use newer Maven Ant tasks

2017-12-10 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant/pull/50 I hope the third time is the charm 😄 A couple of wishes for antunit: it should have ant/ant-launcher as "provided" dependencies and it should have a "tempdir" attribute si

[GitHub] ant issue #50: Use newer Maven Ant tasks

2017-12-10 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant/pull/50 This is exactly why I was looking into it -- those things tend to deteriorate over time 😄 To sum it up, I'll revert stripping, restore CPL and correct the README (that tests rely on JUnit 3

[GitHub] ant issue #50: Use newer Maven Ant tasks

2017-12-09 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant/pull/50 BTW, JUnit license has changed from CPL to EPL. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands

[GitHub] ant issue #50: Use newer Maven Ant tasks

2017-12-09 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant/pull/50 Sorry about confusion 😊 -- here comes a corrected commit. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org

[GitHub] ant issue #50: Use newer Maven Ant tasks

2017-12-09 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant/pull/50 Sorry about the whitespace -- I can separate all "drive-by" changes into a commit on its own. Could you please elaborate on having both JUnit 3 and 4? JUnit 4 is Java 5 compatible, and

[GitHub] ant pull request #50: Use newer Maven Ant tasks

2017-12-09 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant/pull/50 Use newer Maven Ant tasks The initial aim was to avoid NPE when retrieving jasper and automate retrieval of ant-antunit (with exclusion of ant/ant-launcher). Then I started wondering whether

[GitHub] ant pull request #:

2017-11-29 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant/commit/68b846a4c27361cce2b6d7e9c60ca697f980913e#commitcomment-25932714 In src/main/org/apache/tools/ant/taskdefs/Javac.java: In src/main/org/apache/tools/ant/taskdefs/Javac.java on line 778

[GitHub] ant-ivy pull request #61: Use japicmp to check binary compatibility

2017-10-19 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/61 Use japicmp to check binary compatibility japicmp 0.11 has got an Ant task. It can as well be used for documenting the public API. Grouped related targets, too (moved `sources` closer

[GitHub] ant-ivy issue #55: use the vectorised logo

2017-09-25 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/55 logo.png is for CredentialsUtil; replaced by IvyLogo CSS contains changes for `#logo` and adds `svg.icon` (somehow Firefox cannot read dimensions from embedded SVGs) XSL generates

[GitHub] ant-ivy pull request #:

2017-09-15 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant-ivy/commit/ab8b608744500c6af9933df5977a2aa054ac3c04#commitcomment-24318098 Is this Maven 2 or [Maven 3/Aether](http://maven.apache.org/aether.html

[GitHub] ant-ivy issue #60: use Unicode glyphs or SVG data URLs instead of bitmaps

2017-09-03 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/60 Looks like I've beaten time to first response record again: 9+ hours 😃 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] ant-ivy issue #60: use Unicode glyphs or SVG data URLs instead of bitmaps

2017-09-03 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/60 I changed back the version of asciidoctor-ant to 1.5.4 and added a stab at IVY-450. The current description does not indicate what should happen when the parent is collapsed, so I assume that one may

[GitHub] ant-ivy pull request #60: use Unicode glyphs or SVG data URLs instead of bit...

2017-08-31 Thread twogee
Github user twogee commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/60#discussion_r136417644 --- Diff: build-release.xml --- @@ -179,11 +180,11 @@ - + --- End diff -- Very

[GitHub] ant-ivy pull request #60: use Unicode glyphs or SVG data URLs instead of bit...

2017-08-30 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/60 use Unicode glyphs or SVG data URLs instead of bitmaps I put this up for review in case I missed some page that used the removed icons. You can merge this pull request into a Git repository

[GitHub] ant-ivy issue #59: IVY-1566 - Store External form of URL in cached files

2017-08-28 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/59 This is a bit off topic, but why are Jenkins builds still failing to find JaCoCo? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] ant-ivy issue #59: IVY-1566 - Store External form of URL in cached files

2017-08-19 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/59 Please update your local repo, rebase and force push -- new commit will start a new build. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] ant-ivy issue #59: IVY-1566 - Store External form of URL in cached files

2017-08-11 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/59 If I'm not mistaken, one of the builds for #58 was aborted by @nlalevee -- something wrong with Jenkins? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] ant-ivy issue #58: IVY-1566 - Store External form of URL in cached files

2017-08-10 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/58 2.4.x branch seems not to be buildable, could you please open the PR against master? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] ant-ivy issue #55: use vectorised logo

2017-08-08 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/55 This one seems to break a JIRA record for time of first response: 8+ hours 😄 Beat that! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] ant-ivy pull request #:

2017-08-08 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant-ivy/commit/a9dd1573eb0edbfa977da90dd3bcb1863451ec2a#commitcomment-23529287 Perhaps [this](https://stackoverflow.com/questions/3587071/disable-intellij-starred-package-imports) could be of use ð

[GitHub] ant-ivy pull request #:

2017-08-07 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant-ivy/commit/f4237388ea9b93278db12a43c9db9f18e51b6f7f#commitcomment-23518067 Good catch 👍 would you mind to have a look at 72b730fc, too? --- If your project is set up for it, you can reply

[GitHub] ant-ivy issue #57: fix last inconsistencies in generics

2017-08-07 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/57 @nlalevee, we already broke a few things by going Java 7 (and gained native symlinks 😉). For more examples, look at commons-lang3 breaking off commons-text and introducing escapeHtml3

[GitHub] ant-ivy pull request #:

2017-08-05 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant-ivy/commit/9b2165894ef23247d658dd37e93161c1a59b1c65#commitcomment-23498086 What else must be done to remove it? Deprecate the class? Here's the [relevant discussion](http://www.mail-archive.com

[GitHub] ant-ivy issue #57: fix last inconsistencies in generics

2017-08-02 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/57 Thanks for clarifying. My point was that the use of the method is limited to two classes: `SearchEngine` and `ChainResolver` (because it is essentially a proxy). A quick search seems

[GitHub] ant-ivy issue #55: use vectorised logo

2017-08-01 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/55 This fixes https://issues.apache.org/jira/browse/IVY-922 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] ant-ivy issue #57: fix last inconsistencies in generics

2017-07-28 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/57 Is this sufficient, or should I add an extra check in `ChainResolver` ``` if (resolver instanceof AbstractResolver || hasGenericMethod(resolver

[GitHub] ant-ivy issue #57: fix last inconsistencies in generics

2017-07-28 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/57 The same applies to `ChainResolver` (which should check resolver type as suggested by @jaikiran); actually, all custom resolvers that do not extend `AbstractResolver` could be wrapped in chain

[GitHub] ant-ivy issue #57: fix last inconsistencies in generics

2017-07-28 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/57 The methods in `AbstractResolver` must be defined the other way around: the default implementation of the method with new signature should call the method with the old signature. May I amend

[GitHub] ant-ivy issue #57: fix last inconsistencies in generics

2017-07-28 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/57 BTW, the old method is still there, the implementation is in the abstract class, `AbstractResolver`. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] ant-ivy issue #57: fix last inconsistencies in generics

2017-07-28 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/57 The new method is taken from `AbstractOSGiResolver` where a corresponding method is made public. All resolvers implement only the new method and the fallback for the deprecated method is moved

[GitHub] ant-ivy pull request #:

2017-07-27 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant-ivy/commit/366fb741f0772c8309f9dfe963f6032b091d7b89#commitcomment-23340291 Sorry for a terse suggestion, I meant we could provide more information to the end user about the symlink/symlinkmass now

[GitHub] ant-ivy pull request #57: fix last inconsistencies in generics

2017-07-27 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/57 fix last inconsistencies in generics ... use collections, not arrays You can merge this pull request into a Git repository by running: $ git pull https://github.com/twogee/ant-ivy consistent

[GitHub] ant-ivy pull request #56: use “Maven 2” consistently

2017-07-27 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/56 use “Maven 2” consistently You can merge this pull request into a Git repository by running: $ git pull https://github.com/twogee/ant-ivy maven-2-in-asciidoc Alternatively you can review

[GitHub] ant-ivy issue #53: Suppressed warnings

2017-07-27 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/53 With all due respect, there are some refactorings worth attention IMHO. Besides, some deprecations need to be followed through 😉 --- If your project is set up for it, you can reply to this email

[GitHub] ant-ivy pull request #:

2017-07-27 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant-ivy/commit/6607bdcb3ba69d2ab4f41be6292cc5a6df6365ba#commitcomment-23339716 In URLHandlerDispatcher, ``` @Override public void download(final URL src, final File dest, final

[GitHub] ant-ivy pull request #:

2017-07-27 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant-ivy/commit/366fb741f0772c8309f9dfe963f6032b091d7b89#commitcomment-23334637 Perhaps `UnsupportedOperationException` would be a useful heuristic? --- If your project is set up for it, you can reply

[GitHub] ant-ivy pull request #55: use vectorised logo

2017-07-27 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/55 use vectorised logo I'd like to remove downloaded.gif, error.gif, evicted.gif and searched.gif as well. Maybe we could vote on colours for downloaded and evicted 😉 if green is too dark

[GitHub] ant-ivy issue #53: Suppressed warnings

2017-07-26 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/53 D'uh... getExtends() must respect insertion order -- array straitjacket 😄 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] ant-ivy issue #53: Suppressed warnings

2017-07-26 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/53 This is strange, all tests still pass for me locally -- could someone elucidate what the problem is, please? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] ant-ivy pull request #53: Suppressed warnings

2017-07-26 Thread twogee
Github user twogee commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/53#discussion_r129668076 --- Diff: src/java/org/apache/ivy/plugins/report/XmlReportParser.java --- @@ -71,132 +71,139 @@ --- End diff -- Here's a "diff -wc&q

[GitHub] ant-ivy pull request #:

2017-07-25 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant-ivy/commit/87c4e0656a10f7d9c18a203cf80c01406aeb6820#commitcomment-23286714 In fact, there's a bunch of places where [Mm]aven2 is used... [asciidoc-maven.zip](https://github.com/apache/ant-ivy/files

[GitHub] ant-ivy pull request #:

2017-07-25 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant-ivy/commit/87c4e0656a10f7d9c18a203cf80c01406aeb6820#commitcomment-23286444 In asciidoc/tutorial/multiple.adoc, please replace Maven2 with Maven 2 for consistency 😃 --- If your project is set up

[GitHub] ant-ivy issue #53: Suppressed warnings

2017-07-25 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/53 Sorry for additions to PR. I figured out a way to remove the last inconsistencies with generics without breaking the API. This PR will not change any more. I rebased my commits; you're welcome

[GitHub] ant-ivy issue #54: IVY-735 Support timeouts on resolvers

2017-07-23 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/54 I'd rather have dropping support for 2.x up for vote a.s.a.p. because 3.x is [EOL](http://hc.apache.org/httpclient-3.x/) already. --- If your project is set up for it, you can reply to this email

[GitHub] ant-ivy issue #54: IVY-735 Support timeouts on resolvers

2017-07-22 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/54 The code below apparently assumes that client 2.x might still be around; it is obsolete and this is a perfect opportunity to remove it ``` private HttpClientHelper getHttpClientHelper

[GitHub] ant-ivy issue #54: IVY-735 Support timeouts on resolvers

2017-07-21 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/54 VsftpRepository has DEFAULT_READ_TIMEOUT and DISCONNECT_COMMAND_TIMEOUT; would that require an additional timeout attribute? --- If your project is set up for it, you can reply to this email

[GitHub] ant-ivy issue #54: IVY-735 Support timeouts on resolvers

2017-07-21 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/54 JSch Session has a single (connection) timeout. There is a GitHub project to mock ssh/sftp server based on Mina at https://github.com/shamsoftware/sham-ssh --- If your project is set up

[GitHub] ant-ivy issue #54: IVY-735 Support timeouts on resolvers

2017-07-21 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/54 The PR contains additional changes to HttpClientHandler, introducing HttpConnectionManagerParams, which is not available in Commons HTTP Client version 2 (over 10 years old and virtually gone

[GitHub] ant-ivy pull request #53: Suppressed warnings

2017-07-18 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/53 Suppressed warnings As described in previous PR, all compiler warnings are annotated. This PR removes a few of them, along with some refactoring. Changes are grouped in separate commits which

[GitHub] ant-ivy issue #52: Generics in core

2017-07-14 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/52 I committed proposed changes w/o contains(). Please let me know if should amend. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread twogee
Github user twogee commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127480601 --- Diff: src/java/org/apache/ivy/osgi/util/VersionRange.java --- @@ -306,7 +306,7 @@ public boolean isClosedRange() { return startVersion.equals

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread twogee
Github user twogee commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127474316 --- Diff: src/java/org/apache/ivy/plugins/repository/sftp/SFTPRepository.java --- @@ -148,7 +142,7 @@ public void put(File source, String destination

[GitHub] ant-ivy issue #52: Generics in core

2017-07-14 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/52 Thanks! I will revert the changes regarding the checked exceptions as suggested in a separate commit. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-14 Thread twogee
Github user twogee commented on a diff in the pull request: https://github.com/apache/ant-ivy/pull/52#discussion_r127408025 --- Diff: src/java/org/apache/ivy/tools/analyser/JarJarDependencyAnalyser.java --- @@ -39,21 +39,22 @@ public JarJarDependencyAnalyser(File jarjarjarLocation

[GitHub] ant-ivy pull request #:

2017-07-12 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant-ivy/commit/6f22f4b49c2a3a59840d28e6cbe0c37a56ab1f90#commitcomment-23069324 Neat! 👍 Perhaps it would make sense to ask asciidoctorj team to add support for inlined Ruby and ditto for asciidoctor-ant

[GitHub] ant-ivy pull request #52: Generics in core

2017-07-09 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/52 Generics in core This is as far as I can get without significant changes to API. Any remaining points of contention are annotated by `@SuppressWarnings` (and I'm not proud of what `NoFilter

[GitHub] ant-ivy issue #48: Generics and Java 7 syntax in osgi and plugins packages

2017-07-03 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/48 Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] ant-ivy pull request #48: Generics and Java 7 syntax in osgi and plugins pac...

2017-07-03 Thread twogee
Github user twogee closed the pull request at: https://github.com/apache/ant-ivy/pull/48 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] ant-ivyde pull request #:

2017-07-01 Thread twogee
Github user twogee commented on the pull request: https://github.com/apache/ant-ivyde/commit/b048846233286ed9bb1ae7fbeab9ab3f58983189#commitcomment-22871013 Isn't Eclipse Oxygen Java 8 only? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] ant-ivy issue #49: Aesthetic changes in .gitignore, build.xml and build-rele...

2017-07-01 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/49 This is a part of #50 now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] ant-ivy pull request #49: Aesthetic changes in .gitignore, build.xml and bui...

2017-07-01 Thread twogee
Github user twogee closed the pull request at: https://github.com/apache/ant-ivy/pull/49 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] ant-ivy pull request #50: Check spelling, fix whitespace and links

2017-06-30 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/50 Check spelling, fix whitespace and links Why can't we drop configuration* in asciidoc? You can merge this pull request into a Git repository by running: $ git pull https://github.com/twogee/ant

[GitHub] ant-ivy pull request #49: Aesthetic changes in .gitignore, build.xml and bui...

2017-06-30 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/49 Aesthetic changes in .gitignore, build.xml and build-release.xml You can merge this pull request into a Git repository by running: $ git pull https://github.com/twogee/ant-ivy master

[GitHub] ant-ivy pull request #48: Generics and Java 7 syntax in osgi and plugins pac...

2017-06-30 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/48 Generics and Java 7 syntax in osgi and plugins packages These changes leave only core untouched. Generics are not applied where Java compiler is unhappy (arrays of generics). You can merge

[GitHub] ant-ivy pull request #45: Generics + foreach loops and Java 7 in util (excep...

2017-06-29 Thread twogee
Github user twogee closed the pull request at: https://github.com/apache/ant-ivy/pull/45 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] ant-ivy issue #45: Generics + foreach loops and Java 7 in util (except Filte...

2017-06-29 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/45 I'll put japicmp into a separate PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] ant-ivy issue #45: Generics + foreach loops and Java 7 in util (except Filte...

2017-06-18 Thread twogee
Github user twogee commented on the issue: https://github.com/apache/ant-ivy/pull/45 I pushed new commits which ended up in this PR 😈 This adds more generics in ant and tools, only core and plugins left 😃 To dispel all scares about generics I added a binary

[GitHub] ant-ivy pull request #45: Generics + foreach loops and Java 7 in util (excep...

2017-06-15 Thread twogee
GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/45 Generics + foreach loops and Java 7 in util (except Filter) Sorry for another largish commit, but I don't see much sense splitting it, either. You can merge this pull request into a Git repository

<    1   2   3   >