Re: Mapped resources NPEs - Potential fix causes a failure in one specific test

Thanks everyone for the inputs. Based on those, I have now updated the test to not expect a build failure exception and also have updated our release notes to mention this change in behaviour. -Jaikiran On 09/02/18 11:00 PM, Stefan Bodewig wrote: Jaikiran, just to avoid duplicate work, I'm

Re: Mapped resources NPEs - Potential fix causes a failure in one specific test

Sure Stefan. -Jaikiran On 09/02/18 11:00 PM, Stefan Bodewig wrote: Jaikiran, just to avoid duplicate work, I'm currently running tests on the 1.9.x branch where I fix a bunch a FileNameMapper implementations that wouldn't handle null sourceFileNames (which could happen for resources that

Re: Mapped resources NPEs - Potential fix causes a failure in one specific test

+1 Gintas 2018-02-09 21:16 GMT+01:00 Jan Matèrne (jhm) : > > What this specific test failure shows, though, is that we now no longer > > are able to distinguish between a resource that we could copy but can't > > because it doesn't provide a name and the case of "all

AW: Mapped resources NPEs - Potential fix causes a failure in one specific test

> What this specific test failure shows, though, is that we now no longer > are able to distinguish between a resource that we could copy but can't > because it doesn't provide a name and the case of "all resources have > been stripped out by mappers as "I don't know how to handle it". *

Re: Mapped resources NPEs - Potential fix causes a failure in one specific test

Jaikiran, just to avoid duplicate work, I'm currently running tests on the 1.9.x branch where I fix a bunch a FileNameMapper implementations that wouldn't handle null sourceFileNames (which could happen for resources that retun null for getName) as well as several other places that didn't check

Re: Mapped resources NPEs - Potential fix causes a failure in one specific test

On 2018-02-09, Jaikiran Pai wrote: > That test was introduced long back as part of [5] to test another > similar NPE. I think with the change I now have, it no longer reaches > this place in the code where the Copy task would end up getting a null > from a mapper, because various other utility

Re: Mapped resources NPEs - Potential fix causes a failure in one specific test

Friday, February 9, 2018 5:05 AM To: dev@ant.apache.org Subject: Re: Mapped resources NPEs - Potential fix causes a failure in one specific test On 09/02/18 2:47 PM, Dominique Devienne wrote: > On Fri, Feb 9, 2018 at 10:06 AM, Jaikiran Pai <jai.forums2...@gmail.com> > wrote: >

Re: Mapped resources NPEs - Potential fix causes a failure in one specific test

On Fri, Feb 9, 2018 at 11:05 AM, Jaikiran Pai wrote: > > On 09/02/18 2:47 PM, Dominique Devienne wrote: > >> On Fri, Feb 9, 2018 at 10:06 AM, Jaikiran Pai >> wrote: >> >> I need some inputs on how we should go about this specific change/test?

Re: Mapped resources NPEs - Potential fix causes a failure in one specific test

On Fri, Feb 9, 2018 at 10:06 AM, Jaikiran Pai wrote: > I need some inputs on how we should go about this specific change/test? > Should this test continue to expect a exception or is it fine to expect > that target to complete cleanly (without copying anything)? >

Mapped resources NPEs - Potential fix causes a failure in one specific test

Recently a couple of bugs have been reported around mapped resources where we end up in NullPointerExceptions in various places[1][2]. As noted in [1], it needs a fix at a central place and I think I was able to fix the root cause as part of this commit[3] that I did an hour or so back.