mataha commented on PR #205:
URL: https://github.com/apache/ant/pull/205#issuecomment-1722502639
The pleasure is mine!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
jaikiran commented on PR #205:
URL: https://github.com/apache/ant/pull/205#issuecomment-172236
Thank you @mataha for those details. I have now merged this PR and added you
(`Mateusz Kazimierczuk`) as a contributor to our contributors list.
--
This is an automated message from the Apac
asfgit closed pull request #205: Fix `--release` param check in bootstrap.bat
URL: https://github.com/apache/ant/pull/205
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
mataha commented on PR #205:
URL: https://github.com/apache/ant/pull/205#issuecomment-1722284523
These, of course, can be run on all Windows versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
mataha commented on PR #205:
URL: https://github.com/apache/ant/pull/205#issuecomment-1722247407
> Hello @mataha, what you propose here looks OK to me. However, I haven't
been able to reproduce the issue that prompted this change. Is there some
specific Windows version where this can be rep
jaikiran commented on PR #205:
URL: https://github.com/apache/ant/pull/205#issuecomment-1722169214
Hello @mataha, what you propose here looks OK to me. However, I haven't been
able to reproduce the issue that prompted this change. Is there some specific
Windows version where this can be rep
jaikiran commented on PR #204:
URL: https://github.com/apache/ant/pull/204#issuecomment-1715096911
Thank you @jmichelberger for this patch, this looks OK to me and I've now
merged it and I have added you to our contributors list. The patch doesn't have
a test case, I'm guessing that you we
asfgit closed pull request #204: bz-66552 fix Depend task does not handle
Dynamic constant pool entries - java.lang.ClassFormatError: Invalid Constant
Pool entry Type 17
URL: https://github.com/apache/ant/pull/204
--
This is an automated message from the Apache Git Service.
To respond to
jmichelberger opened a new pull request, #204:
URL: https://github.com/apache/ant/pull/204
In cases the Depend task scans a class file with Constant Pool entry Type
17 there was no handling, just fireing an Exception.
Constant is defined since JDK11, and format is same as InvokeDynamic
jaikiran closed pull request #203: bz-67082 fix unintended trimmed string
output by pathconvert
URL: https://github.com/apache/ant/pull/203
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jaikiran commented on PR #203:
URL: https://github.com/apache/ant/pull/203#issuecomment-1710984197
Hello Sebastian, thank you for reporting this issue and providing a fix that
too with a test case. This is a very well done patch. I've merged this and also
included your name in our contribut
sratz opened a new pull request, #203:
URL: https://github.com/apache/ant/pull/203
PropertyOutputStream by default trims output.
This is undesired in the use case. Explicitly set it to false.
Fixes regression introduced in 1.10.13 /
90ed3ff6cca8634e38d7c3c82858ce48c9c4be2b
stevenschlansker commented on PR #200:
URL: https://github.com/apache/ant/pull/200#issuecomment-1680938966
Thank you very much :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
jaikiran commented on PR #200:
URL: https://github.com/apache/ant/pull/200#issuecomment-1680564559
Ant 1.10.14 (containing this change) is in voting phase if you would like to
try it https://lists.apache.org/thread/th6yrxc4dtpqhc2vnzmrd7d9b881hk4g
--
This is an automated message from the
dependabot[bot] closed pull request #202: Bump xalan:xalan from 2.7.2 to 2.7.3
in /src/etc/poms/ant-apache-xalan2
URL: https://github.com/apache/ant/pull/202
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
dependabot[bot] commented on PR #202:
URL: https://github.com/apache/ant/pull/202#issuecomment-1680152807
Looks like xalan:xalan is up-to-date now, so this is no longer needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
jaikiran commented on PR #122:
URL: https://github.com/apache/ant/pull/122#issuecomment-1676403559
Hello Marc, sorry this took this long. I saw this PR again this week and
what you raise here is a valid bug. I've pushed a commit which should address
this and should be available in our upcom
asfgit closed pull request #122: Bugfix/catch dynamic test before each
URL: https://github.com/apache/ant/pull/122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
dependabot[bot] opened a new pull request, #202:
URL: https://github.com/apache/ant/pull/202
Bumps xalan:xalan from 2.7.2 to 2.7.3.
[](https://github.com/apache/ant/pull/200#issuecomment-16
stevenschlansker commented on PR #200:
URL: https://github.com/apache/ant/pull/200#issuecomment-1633231279
No, I am running the latest spotbugs-maven-plugin release, which uses Ant as
a library. The problem only manifests if you disable forking in the plugin
configuration.
--
This is an
jglick commented on PR #200:
URL: https://github.com/apache/ant/pull/200#issuecomment-1632843378
> are you running these tests by building Ant from source?
@jaikiran why would you ask that?
https://github.com/apache/ant/pull/200#issuecomment-1631658175 reports an error
that looks ide
didiksupriadi41 closed pull request #97: Remove unused dependencies
URL: https://github.com/apache/ant-ivy/pull/97
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
jaikiran commented on PR #200:
URL: https://github.com/apache/ant/pull/200#issuecomment-1631739432
Sorry everyone, my testing with the changes I have is taking longer than
expected. @stevenschlansker, are you running these tests by building Ant from
source? If yes, then I'll go ahead and me
arturobernalg closed pull request #165: Use object equals instead of ==, which
does a character-by-character comparison when the strings are different objects
URL: https://github.com/apache/ant/pull/165
--
This is an automated message from the Apache Git Service.
To respond to the message
arturobernalg closed pull request #163: Make final var when is possible.
URL: https://github.com/apache/ant/pull/163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
apupier closed pull request #62: IVY-1572 - Check for Thread interruption while
resolving resources
URL: https://github.com/apache/ant-ivy/pull/62
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
apupier commented on PR #62:
URL: https://github.com/apache/ant-ivy/pull/62#issuecomment-1558743234
long time without progress and no more in my scope of work. Closing. feel
free to reuse my work if needed
--
This is an automated message from the Apache Git Service.
To respond to the mess
asfgit closed pull request #197: Handling forked VM timeout in a similar way to
junit ant task
URL: https://github.com/apache/ant/pull/197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jaikiran commented on PR #197:
URL: https://github.com/apache/ant/pull/197#issuecomment-1512565293
The change in this PR looks fine to me. A test can be added separately - I
haven't found the time to try and help you get the test implemented/run. I'll
go ahead and merge this now and will ad
mabartos commented on PR #200:
URL: https://github.com/apache/ant/pull/200#issuecomment-1511152337
@jaikiran Hello, any progress with this issue? Or is there any workaround
for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
jaikiran commented on PR #200:
URL: https://github.com/apache/ant/pull/200#issuecomment-1503458393
> > the work we had done in a recent release to set
`java.security.manager=allow` when launching Ant
>
>
[82c70f3](https://github.com/apache/ant/commit/82c70f3202d5aec4d99fa3b6314ba4a6c
jglick commented on PR #200:
URL: https://github.com/apache/ant/pull/200#issuecomment-1503392846
> the work we had done in a recent release to set
`java.security.manager=allow` when launching Ant
82c70f3 I guess. Yes I think it would be appropriate to not even attempt to
call `setSec
jaikiran commented on PR #200:
URL: https://github.com/apache/ant/pull/200#issuecomment-1503324250
Hello Jesse, I'm currently in the process of undoing some of the work we had
done in a recent release to set `java.security.manager=allow` when launching
Ant. This change has caused more than
jglick opened a new pull request, #200:
URL: https://github.com/apache/ant/pull/200
Fixes https://github.com/spotbugs/spotbugs-maven-plugin/issues/423. When
running on Java 18+, where `System.setSecurityManager` is not allowed by
default, just let in-process Java execution run without a
tbw777 closed pull request #198: Using static modifier to normalize methods
contract and performance
URL: https://github.com/apache/ant/pull/198
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
bodewig commented on PR #199:
URL: https://github.com/apache/ant/pull/199#issuecomment-1446276764
https://bz.apache.org/bugzilla/show_bug.cgi?id=66496
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
bodewig commented on PR #199:
URL: https://github.com/apache/ant/pull/199#issuecomment-1446269521
I'll create a bugzilla issue to scan for Resource#toString uses. This change
here is fine as it is and we don't need to clutter it with more discussion.
Thank you for catching this @dreis
jaikiran commented on PR #199:
URL: https://github.com/apache/ant/pull/199#issuecomment-1446256401
Hello Stefan,
> Looks as if StringResource printed its contents, but that seems wrong to
me as there may be more places where code expects toString to not reveal the
contents.
Ag
bodewig commented on PR #199:
URL: https://github.com/apache/ant/pull/199#issuecomment-1446249553
I wonder what kind of `Resource` this is as `Resource#toString` is expected
to only print the resource's name - and this is what the code here relied on.
Looks as if `StringResource` printed i
asfgit closed pull request #199: Use verbose log level for loading stylesheets
URL: https://github.com/apache/ant/pull/199
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
jaikiran commented on PR #199:
URL: https://github.com/apache/ant/pull/199#issuecomment-1446237933
Thank you for these changes. Looks good to me. I'll merge this shortly.
Since this is your first contribution to the Ant project, I'll be adding
`Christoph Dreis` to our contributors list
htt
dreis2211 commented on code in PR #199:
URL: https://github.com/apache/ant/pull/199#discussion_r1118662584
##
src/main/org/apache/tools/ant/taskdefs/XSLTProcess.java:
##
@@ -1258,7 +1258,7 @@ protected void configureLiaison(final Resource
stylesheet) throws BuildException
jaikiran commented on code in PR #199:
URL: https://github.com/apache/ant/pull/199#discussion_r1118656632
##
src/main/org/apache/tools/ant/taskdefs/XSLTProcess.java:
##
@@ -1258,7 +1258,7 @@ protected void configureLiaison(final Resource
stylesheet) throws BuildException
dreis2211 opened a new pull request, #199:
URL: https://github.com/apache/ant/pull/199
Hi,
I've noticed that working with `checkstyle` via Gradle (probably using it
directly will do the same) we always see the very verbose output of the
stylesheet being loaded. Imho this is
tkowalcz commented on PR #197:
URL: https://github.com/apache/ant/pull/197#issuecomment-1436945641
@jaikiran I'm sorry but I was unable to run the tests. After implementing
your instructions the `LegacyXmlResultFormatterTest` was run but there was no
mention of `JUnitLauncherTaskTest` being
bodewig commented on PR #198:
URL: https://github.com/apache/ant/pull/198#issuecomment-1422055507
I must say I find it extremely difficult to properly review a PR that
touches 100+ files, even if the change is supposed to be mechanical.
In this case I saw a change to `Antlib.java` whe
Wade-tech commented on PR #166:
URL: https://github.com/apache/ant/pull/166#issuecomment-1421930331
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
jaikiran commented on PR #166:
URL: https://github.com/apache/ant/pull/166#issuecomment-1421877210
Hello @Wade-tech, it will be present in the ant-jakartamail artifact which
is here https://repo1.maven.org/maven2/org/apache/ant/ant-jakartamail/1.10.13/
--
This is an automated message fro
Wade-tech commented on PR #166:
URL: https://github.com/apache/ant/pull/166#issuecomment-1421837416
Thanks, JakartaMimeMailer.java use jakarta.mail . I downdload
org.apache.ant-ant-1.10.13
jar(url:https://mvnrepository.com/artifact/org.apache.ant/ant/1.10.13). In this
jar , not found Jakar
bodewig commented on PR #166:
URL: https://github.com/apache/ant/pull/166#issuecomment-1421399930
https://ant.apache.org/manual/Tasks/mail.html - Ant 1.10.13.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
Wade-tech commented on PR #166:
URL: https://github.com/apache/ant/pull/166#issuecomment-1420290634
Hi ,tomcat10 change javax.* namespace to jakarta.*， Does ant now support
jakarta.mail?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
tkowalcz commented on PR #197:
URL: https://github.com/apache/ant/pull/197#issuecomment-1419282632
Thanks. I will give it a try and let you know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
jaikiran commented on PR #197:
URL: https://github.com/apache/ant/pull/197#issuecomment-1419267691
> When I build the project the tests do not seem to be executed
Some of the tasks in Ant, including the `junitlauncher` aren't part of the
"core". You will have to first fetch the depen
tkowalcz commented on PR #197:
URL: https://github.com/apache/ant/pull/197#issuecomment-1419257202
Hi, actually I had problems running the tests in the first place. When I
build the project the tests do not seem to be executed (build pass even when I
introduce failing assertion). I can late
jaikiran commented on PR #197:
URL: https://github.com/apache/ant/pull/197#issuecomment-1419253719
Hello Tomasz, I don't want to rush you, but if writing a test is proving to
be time consuming or complicated, do let me know and I'll merge this fix (which
looks good to me) and I'll add a tes
tkowalcz commented on PR #197:
URL: https://github.com/apache/ant/pull/197#issuecomment-1383728622
Thanks for review. I will make changes as you suggested and of course write
a test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
tkowalcz commented on code in PR #197:
URL: https://github.com/apache/ant/pull/197#discussion_r1071004085
##
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/confined/JUnitLauncherTask.java:
##
@@ -330,7 +330,20 @@ private void forkTest(final TestDefinition test) {
tkowalcz commented on code in PR #197:
URL: https://github.com/apache/ant/pull/197#discussion_r1071003296
##
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/confined/JUnitLauncherTask.java:
##
@@ -330,7 +330,20 @@ private void forkTest(final TestDefinition test) {
jaikiran commented on PR #197:
URL: https://github.com/apache/ant/pull/197#issuecomment-1381175943
Thank you Tomasz for this PR. I think this change looks fine. Could you add
a test case to verify this change works as expected. We have a junitlauncher
test class at
`src/tests/junit/org/apa
jaikiran commented on code in PR #197:
URL: https://github.com/apache/ant/pull/197#discussion_r1068816591
##
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/confined/JUnitLauncherTask.java:
##
@@ -330,7 +330,20 @@ private void forkTest(final TestDefinition test) {
jaikiran commented on code in PR #197:
URL: https://github.com/apache/ant/pull/197#discussion_r1068816123
##
src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/confined/JUnitLauncherTask.java:
##
@@ -330,7 +330,20 @@ private void forkTest(final TestDefinition test) {
tkowalcz opened a new pull request, #197:
URL: https://github.com/apache/ant/pull/197
so that settings like haltonfailure have effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dependabot[bot] opened a new pull request, #196:
URL: https://github.com/apache/ant/pull/196
Bumps commons-net from 3.8.0 to 3.9.0.
[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=commons-net:commons-net
bodewig commented on PR #194:
URL: https://github.com/apache/ant/pull/194#issuecomment-1330216852
Good catch, thank you.
I could try to turn the byte array into a string, catch the exception and
then keep searching for encoded NULs later.
But even then it might just fail for so
keithc-ca commented on PR #194:
URL: https://github.com/apache/ant/pull/194#issuecomment-1329179830
That's an interesting idea, but it has the potential to misidentify the end
of a multi-byte encoding.
For example, `"Ā!"` = `"\u0100!"` is encoded by UTF16 as { 1, 0, 0, 33 }.
The null se
bodewig commented on PR #194:
URL: https://github.com/apache/ant/pull/194#issuecomment-1328088190
it seems e04fbe7ff works for our tests. I thought about letting the encoding
tell us what a NUL would look like and then search for that, this seems to work
even though it was more complex than
bodewig commented on PR #194:
URL: https://github.com/apache/ant/pull/194#issuecomment-1327750192
well, in the end the tar format is not meant to store file names in the name
field with a multi-byte encoding. The few docs that one can find talk about
"local variant of ASCII" and the UTF16 t
keithc-ca commented on PR #194:
URL: https://github.com/apache/ant/pull/194#issuecomment-1326867522
> `ZipEncoding` might be a bit too simplistic
Yes, I think so. I explored the idea of just decoding the whole byte array,
but that will fail if there's a bad number of nulls at the end
bodewig commented on PR #194:
URL: https://github.com/apache/ant/pull/194#issuecomment-1320928103
actually this breaks support for file names using multi-byte encodings where
NULs may just be part of a multi-byte sequence and not signal the end of the
name. You can see this by running
jaikiran commented on PR #195:
URL: https://github.com/apache/ant/pull/195#issuecomment-1318135936
> I'll also check why my testing of my previous commit didn't catch the 1.8
version issue
For the record - one of the test jobs did catch this issue for 1.8 version,
I just hadn't caugh
jaikiran merged PR #195:
URL: https://github.com/apache/ant/pull/195
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For
jaikiran commented on PR #195:
URL: https://github.com/apache/ant/pull/195#issuecomment-1317878895
Thank you @keithc-ca for this change. I will run some CI test before merging
(I'll also check why my testing of my previous commit didn't catch the 1.8
version issue).
--
This is an automat
keithc-ca opened a new pull request, #195:
URL: https://github.com/apache/ant/pull/195
The existing use of `tr` doesn't distinguish between Java 8 and Java 18; see
https://github.com/apache/ant/commit/bbe6859b2f57a2c9dcb51e269527f3c18a74aa1d#commitcomment-90131350
- this fixes
bodewig commented on PR #194:
URL: https://github.com/apache/ant/pull/194#issuecomment-1305971189
thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
bodewig closed pull request #184: Bugs are Fixed
URL: https://github.com/apache/ant/pull/184
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev
keithc-ca commented on PR #194:
URL: https://github.com/apache/ant/pull/194#issuecomment-1305963866
Thanks for merging this.
> We'd like to credit you in CONTRIBUTORS and contributors.xml
Please use
```
Keith
W.
Campbell
```
--
This is a
bodewig merged PR #194:
URL: https://github.com/apache/ant/pull/194
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For
bodewig commented on PR #194:
URL: https://github.com/apache/ant/pull/194#issuecomment-1305954729
I should have asked my five year younger self wether I remember why the code
is what it is :-) - see https://github.com/apache/commons-compress/pull/54
I'll merge this PR right away. We'd
On 2022-11-07, Keith Campbell wrote:
> I created https://github.com/apache/ant/pull/194, but since that
> repository is just a mirror, perhaps I should instead create a pull
> request at https://gitbox.apache.org/repos/asf?p=ant.git;a=summary
> instead.
No, everything you've don
Hello,
I created https://github.com/apache/ant/pull/194, but since that repository is
just a mirror, perhaps I should instead create a pull request at
https://gitbox.apache.org/repos/asf?p=ant.git;a=summary instead. I tried to
find instructions for creating an account there so I could do that
qf28 commented on PR #194:
URL: https://github.com/apache/ant/pull/194#issuecomment-1305727468
Hi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: de
keithc-ca opened a new pull request, #194:
URL: https://github.com/apache/ant/pull/194
This fixes parsing of archives produced on macOS.
See the discussion in
https://github.com/ibmruntimes/Semeru-Runtimes/issues/15.
--
This is an automated message from the Apache Git Service.
To
bodewig closed pull request #193: Update defaults.properties
URL: https://github.com/apache/ant/pull/193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
bodewig commented on PR #193:
URL: https://github.com/apache/ant/pull/193#issuecomment-1290054573
I have no idea what you are trying to do but you are certainly not at the
correct repo here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
ppkarwasz commented on PR #192:
URL: https://github.com/apache/ant/pull/192#issuecomment-1207894653
> We are maintaining things we accepted more than twentytwo years ago
(`` anyone :-) ) just to give a perspective on what maintenance
involves.
@bodewig, I perfectly understand the pro
vlsi commented on PR #192:
URL: https://github.com/apache/ant/pull/192#issuecomment-1207773563
> My reluctance to adding new dependencies for things that could be add-ons
+1
> I'd say the same thing about an SLF4J based logger implementation
Well, at least slf4j allows pl
bodewig commented on PR #192:
URL: https://github.com/apache/ant/pull/192#issuecomment-1207757018
I'd say the same thing about an SLF4J based logger implementation. My
reluctance to adding new dependencies for things that could be add-ons - maybe
just a separate antlib under the umbrella of
jaikiran commented on PR #191:
URL: https://github.com/apache/ant/pull/191#issuecomment-1207597394
> I can reproduce this locally and believe the key is to remove jai from the
local m2 repo. Maybe the CI server has stored jai there as well @jaikiran ?
That's very likely. Thank you @pp
rgoers commented on PR #192:
URL: https://github.com/apache/ant/pull/192#issuecomment-1207497855
@vlsi What a pointless comment. ANY software can have a CVE. For the record,
the Log4j 2 API has never had any CVE's reported against it. From a
functionality point of view it is exactly the sam
ppkarwasz commented on PR #192:
URL: https://github.com/apache/ant/pull/192#issuecomment-1207497790
This would be just a marketing problem: Log4j2 Core's vulnerabilities never
affected the Log4j2 API as well as Logback's vulnerabilities never affected
SLF4J. In the case of a new CVE against
vlsi commented on PR #192:
URL: https://github.com/apache/ant/pull/192#issuecomment-1207492798
>I can help maintaining it.
Well, it would be nice to avoid dependency on log4j2 if possible since any
new CVE would trigger cases like "Ant is using vulnerable log4j"
--
This is an autom
1 - 100 of 1001 matches
Mail list logo
