antoine 2003/04/22 16:16:30
Modified:src/main/org/apache/tools/ant/types ZipFileSet.java
src/etc/testcases/taskdefs war.xml
Log:
avoid backward compatibility problems for lib attribute of war task, so relax
ZipFileSet#getRef
Revision ChangesPath
1.17
I have fixed the problem.
Antoine
- Original Message -
From: Gianugo Rabellino [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
Sent: Wednesday, April 23, 2003 12:11 AM
Subject: Backward incompatible change in war task?
Hi there,
probably some of you are already aware of this problem since I
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18476.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
antoine 2003/04/22 16:33:32
Modified:src/main/org/apache/tools/ant/types ZipFileSet.java
Log:
fix because of class cast exception detected
Revision ChangesPath
1.18 +4 -1 ant/src/main/org/apache/tools/ant/types/ZipFileSet.java
Index: ZipFileSet.java
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18476.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
On Tue, 22 Apr 2003, Antoine Levy-Lambert [EMAIL PROTECTED]
wrote:
From: Stefan Bodewig [EMAIL PROTECTED]
Which documentation?
I meant the ant manual page under docs/manual/CoreTasks/war.html
Nested elements lib
The nested lib element specifies a FileSet.
Well, yes. This doesn't rule out
On 22 Apr 2003, [EMAIL PROTECTED] wrote:
+if (o instanceof FileSet) {
+ return (AbstractFileSet)(new ZipFileSet((FileSet)o));
the cast is not needed here.
+}
+else if (!(o instanceof ZipFileSet)) {
will always be true as instanceof ZipFileSet
[junit] Testcase:
testAttributes(org.apache.tools.ant.types.ZipFileSetTest):Caused an
ERROR
[junit] null
[junit] java.lang.NullPointerException
[junit] at
org.apache.tools.ant.types.ZipFileSetTest.testAttributes(ZipFileSetTest.java:149)
[junit] at
I'm taking care of it.
Stefan
bodewig 2003/04/22 23:34:53
Modified:.build.xml
src/etc/testcases/types selectors.xml
Added: src/testcases/org/apache/tools/ant/types/selectors
ContainsRegexpTest.java
Log:
Add testcase for containsregexp selector.
On Tue, 22 Apr 2003, Jose Alberto Fernandez
[EMAIL PROTECTED] wrote:
If we do this, then we can concentrate here on the local antlib
while someone else can take care of the external work.
+1
Stefan
On Mon, 21 Apr 2003, Antoine Levy-Lambert [EMAIL PROTECTED]
wrote:
1) antlib antjar
deployment descriptor called antlib.xml which would go in the
META-INF subdirectory of the antlib
I prefer an XML descriptor over manifest entries as well, because it
is easier to
antoine 2003/04/23 00:20:17
Modified:src/main/org/apache/tools/ant/types ZipFileSet.java
Log:
fix ZipFileSet#getRef for referenced ZipFileSets
Revision ChangesPath
1.19 +5 -7 ant/src/main/org/apache/tools/ant/types/ZipFileSet.java
Index: ZipFileSet.java
Jose Alberto Fernandez wrote, On 22/04/2003 19.20:
Hi guys,
I would propose to that instead of antlib calling ruper,
the rupper people can provide a ruperautoload task (or
whatever other name you want) that will do all the finding and
downloading and then will invoque antlib.
If we do this, then
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9300.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9301.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9536.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9304.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9303.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9304.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=9303.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19179.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19187.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19213.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
:/home/rubys/jakarta/beanshell/dist/bsh-20030423.jar:/home/rubys/jakarta/beanshell/dist/bsh-bsf-20030423.jar:/home/rubys/jakarta/beanshell/dist/bsh-classpath-20030423.jar:/home/rubys/jakarta/beanshell/dist/bsh-commands-20030423.jar:/home/rubys/jakarta/beanshell/dist/bsh-core-20030423.jar:/home/rubys
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19150.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19150.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19150.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19151.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=13510.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19247.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19213.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19151.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
bodewig 2003/04/23 08:03:06
Modified:src/etc/testcases/core/loaderref loaderref.xml
src/main/org/apache/tools/ant/taskdefs Definer.java
src/main/org/apache/tools/ant/util ClasspathUtils.java
Log:
Make Definer use the new ClasspathUtils, make
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19213.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
On Wed, 23 Apr 2003, Jose Alberto Fernandez
[EMAIL PROTECTED] wrote:
I am not even sure the code today was examining the value.
8-) It's been a long time, I know.
we probably should define more meaningful attributes
ant-required-version, antlib-version (version used to buils
umagesh 2003/04/23 08:11:43
Modified:.build.xml
Log:
Enable previously disabled head-tail tests.
Make StripJavaComments recognize and retain Mac line endings.
PR: 18476
Submitted by: [EMAIL PROTECTED] (peter reilly)
Revision ChangesPath
1.369 +0
umagesh 2003/04/23 08:12:13
Modified:src/etc/testcases/filters head-tail.xml
src/main/org/apache/tools/ant/filters StripJavaComments.java
src/testcases/org/apache/tools/ant/filters HeadTailTest.java
Log:
Enable previously disabled head-tail tests.
On Fri, 18 Apr 2003, Marc Portier [EMAIL PROTECTED] wrote:
1. ClasspathUtils duplicates (i.e. stole) some code from the
o.a.t.a.taskdefs.Definer: the least I should do is refactor that one
to now use what is in the ClasspathUtils.
This is now in CVS.
I noted at least one difference, and I'm
One comment about roles: Roles are fine, but roles are just strings... If
everything is defined as a component at a low level, then they can be easily
introspected to find out what interfaces components implement. For example,
why would I have to say:
define classname=a.b.C name=...
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18476.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19213.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
On Wed, 23 Apr 2003, Dominique Devienne [EMAIL PROTECTED] wrote:
If everything is defined as a component at a low level, then they
can be easily introspected to find out what interfaces components
implement.
This breaks down if there is no specific interface for a role - like
task or
I probably didn't express myself correctly ;-)
I didn't say the string role was not necessary, I'm saying it's redundant
when the role itself corresponds to an interface. I can implement a single
class implementing a bunch of interfaces, each corresponding to a given
role, can't I?
Plus
From: Stefan Bodewig [mailto:[EMAIL PROTECTED]
On Wed, 23 Apr 2003, Jose Alberto Fernandez
[EMAIL PROTECTED] wrote:
With that, do we really need separate task and data-type in
antlib or are they just special cases of roles?
They should be.
So if they are just roles, why treat
bodewig 2003/04/23 09:01:00
Modified:.WHATSNEW
Log:
Keep track of changes
Revision ChangesPath
1.403 +2 -0 ant/WHATSNEW
Index: WHATSNEW
===
RCS file: /home/cvs/ant/WHATSNEW,v
On Wed, 23 Apr 2003, Dominique Devienne [EMAIL PROTECTED] wrote:
Forcing roles to map to an interface is probably a *good* idea!
Maybe, hmm, probably, not convinced ...
Every single bean would become implicitly a data-type, and the ones
with an execute() method implicitly become tasks.
On Wednesday 23 April 2003 17:41, Dominique Devienne wrote:
Let's turn around your question: Tell me of a (string) role (beside the
special task/type cases) that would not be an interface? What good a bean
is, if it's not of an expected Java type? What method or field are you
going to use/call
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19252.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
Stefan Bodewig wrote:
On Wed, 23 Apr 2003, Dominique Devienne [EMAIL PROTECTED] wrote:
If everything is defined as a component at a low level, then they
can be easily introspected to find out what interfaces components
implement.
This breaks down if there is no specific interface for a
Yes, it could be a problem. But running the risk of speaking yet another
anathema, I'm starting to believe the Jelly approach of using XML namespaces
is the right one...
The problem is not so much that one wants to use the same name (say
containsregex) for two different things (a condition and a
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=18484.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
On Wednesday 23 April 2003 17:57, Dominique Devienne wrote:
Yes, it could be a problem. But running the risk of speaking yet another
anathema, I'm starting to believe the Jelly approach of using XML
namespaces is the right one...
+1
Seems simple to implement and fits in with current usage.
From: peter reilly [mailto:[EMAIL PROTECTED]
A couple of points:
1) the Project.java in the proposal should be synced up with
the current Project.java. It is quite difficult to see
the differences.
Antoine keeps on sync-ing but the thing keeps on moving :-(
2) do the taskdef,
Peter Reilly wrote
A couple of points:
1) the Project.java in the proposal should be synced up with
the current Project.java. It is quite difficult to see the differences.
Yes
2) do the taskdef, typedef tasks still work as at present ?
(ie for individual tasks and with property resouces)
Dominique, you should love the current antlib proposal more of what
you are arguing is acomplish there, maybe with a little twist. :-)
From: Dominique Devienne [mailto:[EMAIL PROTECTED]
Let's turn around your question: Tell me of a (string) role
(beside the
special task/type cases) that
Dominique Devienne wrote:
Let's turn around your question: Tell me of a (string) role (beside the
special task/type cases) that would not be an interface? What good a bean
is, if it's not of an expected Java type? What method or field are you
going to use/call on it?
Any role. Just like you
peter reilly wrote:
On Wednesday 23 April 2003 17:57, Dominique Devienne wrote:
Yes, it could be a problem. But running the risk of speaking yet another
anathema, I'm starting to believe the Jelly approach of using XML
namespaces is the right one...
+1
Seems simple to implement and fits in
Jose Alberto Fernandez wrote:
This is exactly the point, we should try to type things. Roles
Why ? We have components that can be used in any role. Metadata can
be extracted and used in a variety of ways - descriptors, interfaces,
runtime calls ( like in the 3 kinds of mbeans ). But in the end
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19259.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19259.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=19259.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17973.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND
INSERTED IN THE BUG DATABASE.
63 matches
Mail list logo
