Re: [VOTE] Increase minimum Java version for Ivy to Java7

+1 Nicolas > Le 29 mai 2017 à 13:15, Jan Matèrne a écrit : > > Ivy uses Java7 from Ivy-2.5.x, so let us increase the minimum Java version > for IvyDE from 1.4 [2] to Java7, too. > > According to Eclipse Wiki [2] this will result in requiring Eclipse 4.4 > (from 2014) or

Re: [VOTE] Increase minimum Java version for Ivy to Java7

+1 -Jaikiran On 29-May-2017, at 4:59 PM, Nicolas Lalevée wrote: +1 Nicolas > Le 29 mai 2017 à 13:15, Jan Matèrne a écrit : > > Ivy uses Java7 from Ivy-2.5.x, so let us increase the minimum Java version > for IvyDE from 1.4 [2] to Java7, too. >

[GitHub] ant-ivy issue #33: More code cleanup

Github user nlalevee commented on the issue: https://github.com/apache/ant-ivy/pull/33 In french we have "ssi" which is a contraction of "si et seulement si" which has a mathematical meaning about absolute equivalence between two propositions. I bet that in english "iff" means

[GitHub] ant-ivy issue #33: More code cleanup

Github user janmaterne commented on the issue: https://github.com/apache/ant-ivy/pull/33 You're right. I looked at a dictionary. I'll change that, so haven't to think about that in the future. ;) --- If your project is set up for it, you can reply to this email and have your reply

Ivy buildjobs

I changed the Ivy build jobs to use Java7 instead of Java6. Jan

[GitHub] ant-ivy issue #34: Fix IVY-1528

Github user janmaterne commented on the issue: https://github.com/apache/ant-ivy/pull/34 - we dont use @author - TestXmlHelper -- if xPathExpression would be a String and the method compiles that for itself, reuse would be easier -- XmlHelper would be a better

[GitHub] ant-ivy issue #35: Use Java 7 as the minimum required Java version

Github user janmaterne commented on the issue: https://github.com/apache/ant-ivy/pull/35 merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] ant-ivy pull request #35: Use Java 7 as the minimum required Java version

Github user asfgit closed the pull request at: https://github.com/apache/ant-ivy/pull/35 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: Replace emma with jacoco?

Talk about timing, again :-) -- Clover has been open source since April. BTW, the documentation has moved to https://atlassian-docs.bitbucket.io/, so confluence.atlassian.com links do not work any more. I can try adding both Jacoco and Clover and make instrumentation selectable through a

Re: Replace emma with jacoco?

From: Gintautas Grigelionis Sent: Monday, May 29, 2017 9:50 AM To: Ant Developers List Subject: Re: Replace emma with jacoco? Talk about timing, again :-) -- Clover has been open source since April. BTW, the documentation has moved to

Re: Replace emma with jacoco?

I've used pitest before which is a bit more useful than typical code coverage plugins. On 29 May 2017 at 08:55, Martin Gainty wrote: > > > > > From: Gintautas Grigelionis > Sent: Monday, May 29,

Re: Replace emma with jacoco?

Both Jacoco and Clover fit that bill. Are you comfortable with eventul change in test and test-report targets? Gintas 2017-05-29 17:40 GMT+02:00 Nicolas Lalevée : > FYI, here are the post build actions available on the Jenkins at the ASF: >

Re: PR-33: problems

Removing a checked exception can affect source compatibility, for example, if that particular exception is caught in a try block and nothing else in the try block can throw the exception. Or at least that's how I remember it I think. On 29 May 2017 at 06:05, Nicolas Lalevée

Re: Replace emma with jacoco?

There's definitely space for improvement, but currently I'm content with an equivalent of what no longer works, in this case, a code coverage tool. Gintas 2017-05-29 17:29 GMT+02:00 Matt Sicker : > I've used pitest before which is a bit more useful > than

Re: Replace emma with jacoco?

FYI, here are the post build actions available on the Jenkins at the ASF: https://www.dropbox.com/s/zwpersrv4ydzdp5/Capture%20d%27%C3%A9cran%202017-05-29%2017.36.49.png?dl=0 It would be nice if

[GitHub] ant-ivy pull request #36: Replace emma with jacoco

GitHub user twogee opened a pull request: https://github.com/apache/ant-ivy/pull/36 Replace emma with jacoco This modernises the reporting of code coverage. Please try it out. NB! On macOS, it tickles https://bugs.openjdk.java.net/browse/JDK-8022291 which is harmless,

Re: PR-33: problems

> Le 29 mai 2017 à 11:35, Jan Matèrne (jhm) a écrit : > > Thanks, but I already have it done ;) > > But one point is open: > src/java/org/apache/ivy/osgi/util/Version.java: the constructor removes the > (IMO unneccessary) ParseException. But because it is a checked

AW: PR-33: problems

Sounds like I would do ;) I'll merge the PR locally and insert the delegates. Open is "src/java/org/apache/ivy/osgi/util/Version.java: the constructor removes the (IMO unneccessary) ParseException. But because it is a checked Exception we break BC."

[GitHub] ant-ivy issue #33: More code cleanup

Github user janmaterne commented on the issue: https://github.com/apache/ant-ivy/pull/33 Because of the problems I dont merge this ATM. We should discuss them on the dev list before. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] ant-ivy issue #33: More code cleanup

Github user janmaterne commented on the issue: https://github.com/apache/ant-ivy/pull/33 build.xml - Nice idea with the copyright statement in Javadoc ( (c)${years} ; years=tstamp("2007-") ). You found a lot of spell errors ;)

Re: PR-33: problems

IMO, for each of these public classes/methods/fields that we are fixing for typos, we should mark them @Deprecated (and add a @deprecated javadoc too and point to the new field/method/class) and introduce the rightly named class/method/field. For methods it’s straightforward, the deprecated

PR-33: problems

I did a review of https://github.com/apache/ant-ivy/pull/33 Here are the points I have problems with, so I want to discuss them here. Basically it's about breaking BC. So how to deal with that? Jan Fixing the spell error in

AW: Replace emma with jacoco?

The task is having a code coverage. The chosen tool should: - do that ;) - be free for OSS - maintained - useable by the project community (we have to use that ;) - runnable in a CI environment If a chosen tool (EMMA) does its job, you dont have to change this until you'll get problems not to

Re: PR-33: problems

If it's acceptable I'll complement the PR addressing all the points. Gintas Den 29 maj 2017 10:13 skrev "Jan Matèrne" : I did a review of https://github.com/apache/ant-ivy/pull/33 Here are the points I have problems with, so I want

AW: PR-33: problems

Thanks, but I already have it done ;) But one point is open: src/java/org/apache/ivy/osgi/util/Version.java: the constructor removes the (IMO unneccessary) ParseException. But because it is a checked Exception we break BC. Jan > -Ursprüngliche Nachricht- > Von: Gintautas Grigelionis

[GitHub] ant-ivy issue #33: More code cleanup

Github user janmaterne commented on the issue: https://github.com/apache/ant-ivy/pull/33 start reviewing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

Re: AW: PR-33: problems

Sorry for slow response, I'm on a trip. It does make sense to leave the exception in place only if ivy becomes opinionated about versions. I am not sure if compatibility break requires a change of major version. There are semver tools out there; maybe it's worth integrating them (redemption driven

Re: PR-33: problems

> Le 29 mai 2017 à 11:46, Jan Matèrne (jhm) a écrit : > > Sounds like I would do ;) > I'll merge the PR locally and insert the delegates. > > Open is > "src/java/org/apache/ivy/osgi/util/Version.java: > the constructor removes the (IMO unneccessary) ParseException. > But

[VOTE] Increase minimum Java version for Ivy to Java7

Ivy uses Java7 from Ivy-2.5.x, so let us increase the minimum Java version for IvyDE from 1.4 [2] to Java7, too. According to Eclipse Wiki [2] this will result in requiring Eclipse 4.4 (from 2014) or newer. According to the bylaws [3] this vote is open for one week (until 05.06.2017).

[RESULT] [VOTE] Increase minimum Java version for Ivy to Java7

[RESULT] [VOTE] Increase minimum Java version for Ivy to Java7 Here is the result of the vote to increase the minimum Java version from current (Ivy-2.4.0) Java5 to Java 7 (Ivy-2.5.0): +1: Jan (binding) Jaikiran (non-binding) Gintautas (non-binding) Nicolas (binding) Dominique

[GitHub] ant-ivy issue #33: More code cleanup

Github user janmaterne commented on the issue: https://github.com/apache/ant-ivy/pull/33 merged, thanks for the huge work. What about the "iff"? I am not a native speaker and dont want to judge ;) --- If your project is set up for it, you can reply to this email and have your

[GitHub] ant-ivy pull request #33: More code cleanup

Github user asfgit closed the pull request at: https://github.com/apache/ant-ivy/pull/33 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] ant-ivy pull request #35: Use Java 7 as the minimum required Java version

GitHub user jaikiran opened a pull request: https://github.com/apache/ant-ivy/pull/35 Use Java 7 as the minimum required Java version Now that the vote to upgrade the minimal required Java version has been passed[1], the commit here upgrades the version to Java 7. [1]

[GitHub] ant-ivy issue #34: Fix IVY-1528

Github user jaikiran commented on the issue: https://github.com/apache/ant-ivy/pull/34 >> we dont use @author Fixed - removed that tag. I will setup my IDE accordingly. >> TestXmlHelper -- if xPathExpression would be a String and the method compiles that for