[GitHub] ant issue #76: bz-43144 - Improve the performance of the tar task when it us...
Github user jaikiran commented on the issue: https://github.com/apache/ant/pull/76 I'm going to put this on hold for a bit and won't merge it yet, for the reasons noted in the recent comments in the linked issue. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant pull request #76: bz-43144 - Improve the performance of the tar task whe...
Github user jaikiran closed the pull request at: https://github.com/apache/ant/pull/76 --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant pull request #:
Github user jaikiran commented on the pull request: https://github.com/apache/ant/commit/0cb9d22b77dda1dcabba91d4c2a1616d0042d16c#commitcomment-31143975 In src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/StandaloneLauncher.java: In src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/StandaloneLauncher.java on line 255: That field indeed is no longer used. I have pushed a commit to remove it. --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
[GitHub] ant pull request #:
Github user twogee commented on the pull request: https://github.com/apache/ant/commit/0cb9d22b77dda1dcabba91d4c2a1616d0042d16c#commitcomment-31140697 In src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/StandaloneLauncher.java: In src/main/org/apache/tools/ant/taskdefs/optional/junitlauncher/StandaloneLauncher.java on line 255: Field no longer used after refactoring? --- - To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org For additional commands, e-mail: dev-h...@ant.apache.org
Re: ant git commit: Add magic names for tests, run more tests in Surefire
On Mon, 29 Oct 2018 at 10:00, Stefan Bodewig wrote: > There is no cycle: core <- testutil <- tests of core > > It is just Maven's model that doesn't allow you to introduce test scope > dependencies that depend on your code under test. A model I disagree > with. > > So in the maven POMs we might be cheating Maven, but only because we > have to circumvent Maven's model which doesn't fit ours. > Maven wants to isolate each module [1]. This is where I went down the rabbit hole and lost sight of the bigger picture, namely, that POM build creates isolation on the fly (which is cheating on Maven :-), because I was thinking of launcher-core and core-junit interdependencies on the test level, and I'd still like to figure out a way of running all Ant tests in Surefire while producing artifacts corresponding to Ant build as closely as possible. Gintas [1] https://blog.sonatype.com/2010/01/how-to-create-two-jars-from-one-project-and-why-you-shouldnt/
