DO NOT REPLY [Bug 14333] - FTP depends/newer option does not work
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14333. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14333 FTP depends/newer option does not work --- Additional Comments From [EMAIL PROTECTED] 2003-03-10 02:32 --- I have been talking about this on the commons-dev mailing list as it pertains to commons-net (formerly NetComponents). Fixing it there will be a prerequisite of fixing it here. First off, I am talking only about date parsing and the depends/newer option. The other problem identified by Scott Bellamy and David Ishee seems like a totally different problem which should be addressed in a separate bug report rather than tacked on to this one as its solution will be completely different. You should know that there are new parsing options in commons-net that can and should be supported in the ftp task. FTP parsers for NT, OS2, and VMS FTP servers have been created in addition to unix and support for these could now be added to ant. However these only take us part of the way toward solving this bug and implementation of the ant-side fix may want to wait until the net-components piece is fixed. Here is what I wrote on the commons-dev mailing list: --- I have been thinking about the issue, though, in particular where commons-net.ftp might have to go in order to really implement the ambitious spec laid out for it by clients such as ant, which have chosen to use it. Of particular note here is the depends (or synonym newer) attribute of the ant ftp task. This runs aground on the issue of parsing the date. In the first place, there are the issues of general listing format (unix, NT, VMS, etc.). In the second place, though, within these categories are issues of date format. This devolves into a thicket of locale-type issues: Does month come before date? In which language are the names of the months coded? To solve this, the scope of parser definition needs to be significantly expanded. Things might be better if there was any mechanism within the FTP specification for the server to expose its format to a client. No such mechanism exists, however. In fact RFC959, the FTP spec is intentionally vague on this point: Since the information on a file may vary widely from system to system, this information may be hard to use automatically in a program, but may be quite useful to a human user. http://www.ietf.org/rfc/rfc959.txt In other words, FTP was never meant to be used in such an automated fashion. Nonetheless, with the specification of parameters easily passed in by something like an ant task, it might be possible to define a parser sufficiently to perform this task. These parameters include: 1) os type of FTP server(unix, NT, OS2, VMS, etc.) 2) date format - to define ordering of date components - MMM dd or dd MMM, etc. as in simple date format 3) locale - to define actual abbreviations of the months.From 2 and 3 it is possible to build a Locale-specific SimpleDateFormat capable of parsing dates on a particular system. This object contains the names and abbreviations of the month. This immediately raises the question of how to divvy up the parsing duties between the regular expression and the SimpleDateFormat. It seems as if the format string must be used to construct the part of the regex in the correct order. Then the SimpleDateFormat would be used to actually parse the date. All optimizations such as assuming a constant character width of 3 for month abbreviations are out the window here - they work for many languages, but not for all. French, for example, uses periods and varying lengths. A cautionary note: one would have to inspect actual ftp sites to determine whether they actually the abbreviations specified in java Locales. -- What I would like, especially from those who submitted and added to this bug, are the addresses of particular ftp non-English ftp servers that I could log into for the purposes of getting the lay of the land before I begin coding a solution
DO NOT REPLY [Bug 14333] - FTP depends/newer option does not work
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14333. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14333 FTP depends/newer option does not work --- Additional Comments From [EMAIL PROTECTED] 2003-03-10 02:38 --- Created an attachment (id=5237) lengthy comments on this problem
DO NOT REPLY [Bug 14333] - FTP depends/newer option does not work
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14333. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=14333 FTP depends/newer option does not work --- Additional Comments From [EMAIL PROTECTED] 2003-03-10 02:39 --- Damn, why did Bugzilla not respect my line feeds. I am going to submit my whole comment as an attachment.
Re: sync files with Ant?
- Original Message - From: Brennan Stehling [EMAIL PROTECTED] To: Ant Developers List [EMAIL PROTECTED] Sent: Saturday, March 08, 2003 16:17 Subject: sync files with Ant? I would like to build a sync capability as an Ant feature but I think I need some pointers with getting started. I just tried to build Ant 1.5.2 and got some SAX problems. I also need to know where to begin once I can get everything compiled. The Ant feature I would like to create is something that I would like to use at work. I manage a 3 tier development system where we have a development, test and production environment. I have an Ant script doing all of the building for me and once it is built I want to copy the files to the test and production servers. To do this I want an Ant process that does something like rsync, but to start it will just do copying to local directories. The sync process will do a comparison to check if files need to be created, replaced or deleted in the destination location. The behavior would also need to be configurable. I could create software which would do all of this outside of Ant, but it seems like a logical feature to add to Ant. yes, this would be good. one problem we always have is with remote destinations and reading things like filestamps, esp. with FTP, as there are so many ways to do directory listings. Keep FTP out of it. But we are adding SSH support into ant, and an rsync equivalent over SSH would be very slick indeed.
Re: sync files with Ant?
FWIW: I think adding an rsync like ability to Ant is a smashingly good idea, and I hope to have some time over the next few months to assist in any way I can. --Craeg (aka peanut gallery) From: Brennan Stehling [EMAIL PROTECTED] I would like to build a sync capability as an Ant feature but I think I need some pointers with getting started. The sync process will do a comparison to check if files need to be created, replaced or deleted in the destination location. The behavior would also need to be configurable. I could create software which would do all of this outside of Ant, but it seems like a logical feature to add to Ant.
DO NOT REPLY [Bug 17711] - Enable use of properties reference in depends
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17711. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17711 Enable use of properties reference in depends [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||WONTFIX --- Additional Comments From [EMAIL PROTECTED] 2003-03-10 06:13 --- This would complicate things too much. When would the properties get evaluated? when we read in the file and build the graph? it'd be too early to load stuff in from a file, only command line properties would work reliably. Alternatively, we could parse the string when we get to it, but how do we know what order to get to it if we dont know its dependencies. I agree we sometimes need better ways of working on lists, but this is not it. The proposed subant task will take a list of targets and execute them.
DO NOT REPLY [Bug 5270] - Ant task - allow multiple targets
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5270. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5270 Ant task - allow multiple targets [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||DUPLICATE --- Additional Comments From [EMAIL PROTECTED] 2003-03-10 06:29 --- pointing this bug a proposed impl of the solution in a new (cleaner) task, subant *** This bug has been marked as a duplicate of 12368 ***
DO NOT REPLY [Bug 12368] - [PATCH] New subant task to execute sub-builds
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12368. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12368 [PATCH] New subant task to execute sub-builds [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2003-03-10 06:29 --- *** Bug 5270 has been marked as a duplicate of this bug. ***
Re: sync files with Ant?
Hi, Commons vfs has a set of tasks for shipping files around between local and/or remote file systems. This includes a sync task, which does pretty much what you want. The tasks support local, ftp, webdav, ssh, samba, etc files as source and destination. The tasks still need some work however. They aren't as featured as the ant equivalents (or as an ant sync task would need to be), and are missing things like selectors, mappers and filters. Nothing a patch or two wouldn't take care of :) So, one option would be to help round out the vfs tasks, rather than starting from scratch. On Sun, 9 Mar 2003 12:17 am, Brennan Stehling wrote: I would like to build a sync capability as an Ant feature but I think I need some pointers with getting started. I just tried to build Ant 1.5.2 and got some SAX problems. I also need to know where to begin once I can get everything compiled. The Ant feature I would like to create is something that I would like to use at work. I manage a 3 tier development system where we have a development, test and production environment. I have an Ant script doing all of the building for me and once it is built I want to copy the files to the test and production servers. To do this I want an Ant process that does something like rsync, but to start it will just do copying to local directories. The sync process will do a comparison to check if files need to be created, replaced or deleted in the destination location. The behavior would also need to be configurable. I could create software which would do all of this outside of Ant, but it seems like a logical feature to add to Ant. I would appreciate any feedback on this idea... Thanks, Brennan Stehling - Java Developer - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] -- Adam
DO NOT REPLY [Bug 17576] - org/apache/bcel/classfile/FieldOrMethod not found in classconstants
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17576. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17576 org/apache/bcel/classfile/FieldOrMethod not found in classconstants --- Additional Comments From [EMAIL PROTECTED] 2003-03-10 07:02 --- Why not download the bcel toolkit (http://jakarta.apache.org/bcel/index.html) see if that fixes your problem. I dont know why your source != your binary.
DO NOT REPLY [Bug 17138] - CVS Task has unclear requirements.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17138. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17138 CVS Task has unclear requirements. [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Additional Comments From [EMAIL PROTECTED] 2003-03-10 07:06 --- Good point. Fixed in the documentation.
tests failing
i have been lax on running tests for a while; now I am seeing (on winXP, single CPU) :- Testcase: testCreateWithEmptyFileset(org.apache.tools.ant.taskdefs.JarTest Caused an ERROR null java.lang.NullPointerException at org.apache.tools.ant.taskdefs.Zip.isEmpty(Zip.java:1082) at org.apache.tools.ant.taskdefs.Zip.executeMain(Zip.java:388) at org.apache.tools.ant.taskdefs.Zip.execute(Zip.java:323) at org.apache.tools.ant.Task.perform(Task.java:388) at org.apache.tools.ant.Target.execute(Target.java:309) at org.apache.tools.ant.Target.performTasks(Target.java:336) at org.apache.tools.ant.Project.executeTarget(Project.java:1394)
cvs commit: ant/src/main/org/apache/tools/ant/types AbstractFileSet.java
stevel 2003/03/09 23:36:46 Modified:src/main/org/apache/tools/ant/types AbstractFileSet.java Log: implementing bug 12060: provide a toString operator so that turning into a property is mildly meaningful. We dont include base dir info, so you get a list of files relative to the basem, all with a ; separator. Revision ChangesPath 1.16 +20 -1 ant/src/main/org/apache/tools/ant/types/AbstractFileSet.java Index: AbstractFileSet.java === RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/types/AbstractFileSet.java,v retrieving revision 1.15 retrieving revision 1.16 diff -u -r1.15 -r1.16 --- AbstractFileSet.java 7 Mar 2003 11:23:07 - 1.15 +++ AbstractFileSet.java 10 Mar 2003 07:36:45 - 1.16 @@ -1,7 +1,7 @@ /* * The Apache Software License, Version 1.1 * - * Copyright (c) 2002 The Apache Software Foundation. All rights + * Copyright (c) 2002-2003 The Apache Software Foundation. All rights * reserved. * * Redistribution and use in source and binary forms, with or without @@ -623,6 +623,25 @@ */ public void addDepend(DependSelector selector) { appendSelector(selector); +} + +/** + * Returns included files as a list of semicolon-separated filenames + * + * @return String object with included filenames + */ +public String toString() { +DirectoryScanner ds = getDirectoryScanner(getProject()); +String[] files = ds.getIncludedFiles(); +StringBuffer sb = new StringBuffer(); + +for (int i = 0; i files.length; i++) { +if (i0) { +sb.append(';'); +} +sb.append(files[i]); +} +return sb.toString(); } }
cvs commit: ant/src/main/org/apache/tools/ant/taskdefs ImportTask.java
stevel 2003/03/09 23:54:29 Modified:src/main/org/apache/tools/ant/taskdefs ImportTask.java Log: a raid by the deprecation police. 1. Why is log used at the project level, not the task level? 2. documentation? Revision ChangesPath 1.8 +4 -4 ant/src/main/org/apache/tools/ant/taskdefs/ImportTask.java Index: ImportTask.java === RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/ImportTask.java,v retrieving revision 1.7 retrieving revision 1.8 diff -u -r1.7 -r1.8 --- ImportTask.java 10 Feb 2003 14:13:34 - 1.7 +++ ImportTask.java 10 Mar 2003 07:54:29 - 1.8 @@ -98,7 +98,7 @@ } ProjectHelper helper= -(ProjectHelper)project.getReference(ant.projectHelper); + (ProjectHelper)getProject().getReference(ant.projectHelper); Vector importStack=helper.getImportStack(); if( importStack.size() == 0) { // this happens if ant is used with a project @@ -117,7 +117,7 @@ //System.out.println(Importing from + currentSource); File buildFileParent=new File(buildFile.getParent()); -project.log(Importing file + file + from + +getProject().log(Importing file + file + from + buildFile.getAbsolutePath(), Project.MSG_VERBOSE); // Paths are relative to the build file they're imported from, @@ -133,7 +133,7 @@ } if( importStack.contains(importedFile) ) { -project.log(\nSkipped already imported file to avoid loop:\n + +getProject().log(\nSkipped already imported file to avoid loop:\n + importedFile + \n,Project.MSG_WARN); return; } @@ -158,7 +158,7 @@ //context.helper.parse(project, importedFile, //new ProjectHelper2.RootHandler(context)); -helper.parse( project, importedFile ); +helper.parse( getProject(), importedFile ); } private static String getPath(File file) {
DO NOT REPLY [Bug 17796] - FilterChain LineContainsRegExp StackOverflowError
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17796. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17796 FilterChain LineContainsRegExp StackOverflowError [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||DUPLICATE Target Milestone|--- |1.5.2 --- Additional Comments From [EMAIL PROTECTED] 2003-03-10 07:57 --- *** This bug has been marked as a duplicate of 15528 ***
cvs commit: ant/src/main/org/apache/tools/ant/taskdefs/optional/dotnet DotnetBaseMatchingTask.java DotnetCompile.java Ilasm.java NetCommand.java
stevel 2003/03/10 00:02:25 Modified:src/main/org/apache/tools/ant/taskdefs/optional/dotnet DotnetCompile.java Ilasm.java NetCommand.java Added: src/main/org/apache/tools/ant/taskdefs/optional/dotnet DotnetBaseMatchingTask.java Log: refactoring so that ilasm can share code (and moved something into NetCommand as it may be more at home there, but that may be bogus). Fixed ilasm to handle multiple files and do dependency checking. More convoluted than one would have thought. Revision ChangesPath 1.6 +9 -176 ant/src/main/org/apache/tools/ant/taskdefs/optional/dotnet/DotnetCompile.java Index: DotnetCompile.java === RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/optional/dotnet/DotnetCompile.java,v retrieving revision 1.5 retrieving revision 1.6 diff -u -r1.5 -r1.6 --- DotnetCompile.java10 Feb 2003 14:13:48 - 1.5 +++ DotnetCompile.java10 Mar 2003 08:02:24 - 1.6 @@ -108,7 +108,7 @@ */ public abstract class DotnetCompile - extends MatchingTask { + extends DotnetBaseMatchingTask { /** * list of reference classes. (pretty much a classpath equivalent) @@ -131,11 +131,6 @@ private File win32res; /** - * output file. If not supplied this is derived from the source file - */ -private File outputFile; - -/** * flag to control action on execution trouble */ private boolean failOnError; @@ -153,11 +148,6 @@ private boolean optimize; /** - * sets of file to compile - */ -protected Vector filesets = new Vector(); - -/** * a list of definitions to support; */ protected Vector definitionList = new Vector(); @@ -223,11 +213,6 @@ protected String extraOptions; /** - * source directory upon which the search pattern is applied - */ -private File srcDir; - -/** * type of target. Should be one of exe|library|module|winexe|(null) * default is exe; the actual value (if not null) is fed to the command * line. br @@ -244,7 +229,7 @@ /** * list of extra modules to refer to */ -String additionalModules; +protected String additionalModules; /** @@ -553,23 +538,6 @@ /** -* Overridden because we need to be able to set the srcDir. -*/ -public File getSrcDir() { -return this.srcDir; -} - -/** - * Set the source directory of the files to be compiled. - * - [EMAIL PROTECTED] srcDirName The new SrcDir value - */ -public void setSrcDir(File srcDirName) { -this.srcDir = srcDirName; -} - - -/** * Set the destination directory of files to be compiled. * [EMAIL PROTECTED] dirName The new DestDir value @@ -595,12 +563,12 @@ */ public void setTargetType(String ttype) throws BuildException { -targetType = ttype.toLowerCase(); -if (targetType.equals(exe) || targetType.equals(library) || -targetType.equals(module) || targetType.equals(winexe)) { -targetType = targetType; +ttype = ttype.toLowerCase(); +if (ttype.equals(exe) || ttype.equals(library) || +ttype.equals(module) || ttype.equals(winexe)) { +targetType = ttype; } else { -throw new BuildException(targetType + targetType +throw new BuildException(targetType + ttype + is not one of 'exe', 'module', 'winexe' or 'library' ); } } @@ -766,17 +734,6 @@ } - -/** - * Set the name of exe/library to create. - * - [EMAIL PROTECTED] file The new outputFile value - */ -public void setDestFile(File file) { -outputFile = file; -} - - /** * get the argument or null for no argument needed * @@ -811,14 +768,6 @@ } /** - * add a new source directory to the compile - * @param src - */ -public void addSrc(FileSet src) { -filesets.add(src); -} - -/** * test for a string containing something useful * [EMAIL PROTECTED] s string in @@ -862,14 +811,6 @@ } /** - * get the destination file - * @return the dest file or null for not assigned - */ -public File getDestFile() { -return outputFile; -} - -/** * do the work by building the command line and then calling it * [EMAIL PROTECTED] BuildException if validation or execution failed @@
Re: tests failing
On Sun, 9 Mar 2003, Steve Loughran [EMAIL PROTECTED] wrote: i have been lax on running tests for a while; now I am seeing (on winXP, single CPU) Is this from CVS HEAD? Looks like the bug Nico's patch was supposed to fix (i.e. http://cvs.apache.org/viewcvs/ant/src/main/org/apache/tools/ant/taskdefs/Zip.java.diff?r1=1.97r2=1.98). But then again Nico reported he still had problems with the test and he's using Windows AFAIK. Needless to say it passes on my machines (Linux, MacOS X and Solaris) and seems to pass in Gump (running on Linux and Solaris) as well. Stefan
DO NOT REPLY [Bug 15469] - Use of custom DataType outputs Overriding previous definition of reference warning
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15469. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15469 Use of custom DataType outputs Overriding previous definition of reference warning [EMAIL PROTECTED] changed: What|Removed |Added Status|VERIFIED|CLOSED
DO NOT REPLY [Bug 17683] - javac task fails if path for java file contains space and if using external compiler
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17683. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17683 javac task fails if path for java file contains space and if using external compiler [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||DUPLICATE --- Additional Comments From [EMAIL PROTECTED] 2003-03-10 09:31 --- *** This bug has been marked as a duplicate of 10499 ***
DO NOT REPLY [Bug 10499] - Compiler task doesn't handle spaces in filenames correctly
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10499. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=10499 Compiler task doesn't handle spaces in filenames correctly [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2003-03-10 09:31 --- *** Bug 17683 has been marked as a duplicate of this bug. ***
cvs commit: ant/src/main/org/apache/tools/ant/taskdefs/optional/ssh AbstractSshMessage.java Scp.java ScpFromMessage.java ScpToMessage.java
bodewig 2003/03/10 02:05:43 Modified:src/main/org/apache/tools/ant/taskdefs/optional/ssh AbstractSshMessage.java Scp.java ScpFromMessage.java ScpToMessage.java Log: Upgrade to jsch-0.1.2 Revision ChangesPath 1.2 +4 -3 ant/src/main/org/apache/tools/ant/taskdefs/optional/ssh/AbstractSshMessage.java Index: AbstractSshMessage.java === RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/optional/ssh/AbstractSshMessage.java,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- AbstractSshMessage.java 6 Mar 2003 12:42:44 - 1.1 +++ AbstractSshMessage.java 10 Mar 2003 10:05:43 - 1.2 @@ -54,9 +54,10 @@ package org.apache.tools.ant.taskdefs.optional.ssh; -import com.jcraft.jsch.Session; import com.jcraft.jsch.Channel; import com.jcraft.jsch.ChannelExec; +import com.jcraft.jsch.JSchException; +import com.jcraft.jsch.Session; import java.io.IOException; import java.io.OutputStream; @@ -76,7 +77,7 @@ this.session = session; } -protected Channel openExecChannel( String command ) { +protected Channel openExecChannel( String command ) throws JSchException { ChannelExec channel = (ChannelExec) session.openChannel( exec ); channel.setCommand( command ); @@ -97,7 +98,7 @@ } while (b 0); } -public abstract void execute() throws IOException; +public abstract void execute() throws IOException, JSchException; public void setLogListener( LogListener aListener ) { listener = aListener; 1.3 +2 -2 ant/src/main/org/apache/tools/ant/taskdefs/optional/ssh/Scp.java Index: Scp.java === RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/optional/ssh/Scp.java,v retrieving revision 1.2 retrieving revision 1.3 diff -u -r1.2 -r1.3 --- Scp.java 7 Mar 2003 14:53:36 - 1.2 +++ Scp.java 10 Mar 2003 10:05:43 - 1.3 @@ -201,7 +201,7 @@ if( failOnError ) { throw new BuildException(e); } else { -e.printStackTrace(); +log(Caught exception: + e.getMessage(), Project.MSG_ERR); } } } @@ -317,7 +317,7 @@ } private Directory createDirectory( FileSet set ) { -DirectoryScanner scanner = set.getDirectoryScanner( project ); +DirectoryScanner scanner = set.getDirectoryScanner( getProject() ); Directory root = new Directory( scanner.getBasedir() ); String[] files = scanner.getIncludedFiles(); for (int j = 0; j files.length; j++) { 1.2 +1 -1 ant/src/main/org/apache/tools/ant/taskdefs/optional/ssh/ScpFromMessage.java Index: ScpFromMessage.java === RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/optional/ssh/ScpFromMessage.java,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- ScpFromMessage.java 6 Mar 2003 12:42:44 - 1.1 +++ ScpFromMessage.java 10 Mar 2003 10:05:43 - 1.2 @@ -76,7 +76,7 @@ this.isRecursive = recursive; } -public void execute() throws IOException { +public void execute() throws IOException, JSchException { String command = scp -f ; if( isRecursive ) command += -r ; 1.2 +5 -4 ant/src/main/org/apache/tools/ant/taskdefs/optional/ssh/ScpToMessage.java Index: ScpToMessage.java === RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/optional/ssh/ScpToMessage.java,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- ScpToMessage.java 6 Mar 2003 12:42:44 - 1.1 +++ ScpToMessage.java 10 Mar 2003 10:05:43 - 1.2 @@ -54,8 +54,9 @@ package org.apache.tools.ant.taskdefs.optional.ssh; -import com.jcraft.jsch.Session; import com.jcraft.jsch.Channel; +import com.jcraft.jsch.Session; +import com.jcraft.jsch.JSchException; import java.io.*; import java.util.*; @@ -85,7 +86,7 @@ this.remotePath = aRemotePath; } -public void execute() throws IOException { +public void execute() throws IOException, JSchException { if( directoryList != null ) { doMultipleTransfer(); } @@ -95,7 +96,7 @@ log(done.\n); } -private void doSingleTransfer() throws IOException { +private void doSingleTransfer() throws IOException, JSchException {
cvs commit: ant/src/main/org/apache/tools/ant/taskdefs/optional/dotnet NetCommand.java
bodewig 2003/03/10 02:11:19 Modified:src/main/org/apache/tools/ant/taskdefs/optional/dotnet NetCommand.java Log: 2003 Revision ChangesPath 1.19 +1 -1 ant/src/main/org/apache/tools/ant/taskdefs/optional/dotnet/NetCommand.java Index: NetCommand.java === RCS file: /home/cvs/ant/src/main/org/apache/tools/ant/taskdefs/optional/dotnet/NetCommand.java,v retrieving revision 1.18 retrieving revision 1.19 diff -u -r1.18 -r1.19 --- NetCommand.java 10 Mar 2003 08:02:24 - 1.18 +++ NetCommand.java 10 Mar 2003 10:11:19 - 1.19 @@ -1,7 +1,7 @@ /* * The Apache Software License, Version 1.1 * - * Copyright (c) 2000-2002 The Apache Software Foundation. All rights + * Copyright (c) 2000-2003 The Apache Software Foundation. All rights * reserved. * * Redistribution and use in source and binary forms, with or without
Re: cvs commit: ant/src/etc/testcases/taskdefs/optional/dotnet HelloWorld.wsdl example.cs example.il example2.il
On 10 Mar 2003, [EMAIL PROTECTED] wrote: ant/src/etc/testcases/taskdefs/optional/dotnet/example2.il // Copyright (C) Microsoft Corporation 1998-2001. All rights reserved. I realize that this file may be a generated file, but I think this copyright notice is, uhm, problematic. Stefan
Re: tests failing
I also have the tests failing under Windows 2000/Cygwin Amazingly, the tests work if I start them from a debugger where I have written a small wrapper to run the main ant build script with target=run-single-test-only The tests also work from the debugger if I directly invoke testCreateWithEmptyFileset by wrapping the src/etc/testcases/taskdefs/Jar.xml in a small java main. Antoine - Original Message - From: Stefan Bodewig [EMAIL PROTECTED] To: [EMAIL PROTECTED] Sent: Monday, March 10, 2003 9:22 AM Subject: Re: tests failing On Sun, 9 Mar 2003, Steve Loughran [EMAIL PROTECTED] wrote: i have been lax on running tests for a while; now I am seeing (on winXP, single CPU) Is this from CVS HEAD? Looks like the bug Nico's patch was supposed to fix (i.e. http://cvs.apache.org/viewcvs/ant/src/main/org/apache/tools/ant/taskdefs/Zi p.java.diff?r1=1.97r2=1.98). But then again Nico reported he still had problems with the test and he's using Windows AFAIK. Needless to say it passes on my machines (Linux, MacOS X and Solaris) and seems to pass in Gump (running on Linux and Solaris) as well. Stefan - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: tests failing : red herring
Now I found the culprit for these failing tests. I was starting the tests on the cygwin prompt with ./build.sh run-single-test It seems that the tests were then done with the bootstrap directory, which was old. I removed my bootstrap directory, rebuilt everything, and now everything is fine. Yours Antoine
Re: [PATCH] [17471] -projecthelp does not work with -quiet
Well, we need to be sure it needs fixing :) This may sound silly but -projecthelp -verbose is more informative than the default listing, so the quiet listing should be less informative. The issue is how much less informative Yes -projecthelp -verbose is much verbose about the project targets, but also about any default tasks called beforehand. And -projecthelp -quiet should be less verbose ie silent about the tasks called statically, yet still provide what is asked ie -projecthelp. My situation is I build a dynamic buildfile using some static tasks, and then includes it in my main build file. I'd like to get full projecthelp without task log. Seems to me -projecthelp -quiet should tdo the job. -- Loïc Péron phone:(33) 683 880 177 mailto:[EMAIL PROTECTED]
DO NOT REPLY [Bug 17807] - antlr test fails
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17807. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17807 antlr test fails --- Additional Comments From [EMAIL PROTECTED] 2003-03-10 11:55 --- Created an attachment (id=5242) patch for the antlr testcase
DO NOT REPLY [Bug 17695] - EOL Makes Starteam Checkout Say Status Modified
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17695. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17695 EOL Makes Starteam Checkout Say Status Modified --- Additional Comments From [EMAIL PROTECTED] 2003-03-10 14:03 --- I agree the GUI isn't the best tool to detect the status of a file. The GUI isn't essential to reproducing the issue. The issue happens purely from stcheckout tasks.
DO NOT REPLY [Bug 17745] - VSSGET task generates incorrect command line for get by label
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17745. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17745 VSSGET task generates incorrect command line for get by label [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |RESOLVED Resolution||INVALID --- Additional Comments From [EMAIL PROTECTED] 2003-03-10 17:52 --- This really isn't a problem. I jumped the gun.
DO NOT REPLY [Bug 17780] - Instead of updating a jar file, the task overrides it.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17780. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17780 Instead of updating a jar file, the task overrides it. --- Additional Comments From [EMAIL PROTECTED] 2003-03-10 21:16 --- I believe these lines should be removed from Zip.java#executeMain // quick exit if the target is up to date // can also handle empty archives if (isEmpty(addThem)) { return; } This quick exit prevents the old zip entries from being copied from the old archive to the new when one is in update mode and that there is no file to add.
DO NOT REPLY [Bug 17850] New: - PVCS task dont work with promotion group
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17850. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17850 PVCS task dont work with promotion group Summary: PVCS task dont work with promotion group Product: Ant Version: 1.4.1 Platform: PC OS/Version: Other Status: NEW Severity: Normal Priority: Other Component: Optional Tasks AssignedTo: [EMAIL PROTECTED] ReportedBy: [EMAIL PROTECTED] PVCS task do not work with promotion group. PVCS VM version used is 6.8. Error is pvcs.xml:78: Failed executing: get -N -GtestPromotionGroup @pvcs_ant_- 1312863861442392659.log. Return code was 1 pcli get help says to use -ggroup, than using -G option used by ANT.
ssh exec task...
ssh_tasks_src.tar.gz Description: application/gzip-compressed