Re: Testing IvyDE

[Gintautas Grigelionis]

On Sun, 1 Jul 2018 at 21:30, Jan Matèrne (jhm)  wrote:

> > It looks like Ant nightly is stuck (possibly due to plugin update in
> > Jenkins) and it's blocking all other builds.
> >
> > Gintas
>
> I can't do it myself so I'll ask for killing the job.
>
> Jan
>

Ant nightly aborted, now IvyDE is stuck near artifact archiving...
Besides, IvyDE build could not find WTP 3.4.2, and the archive page at
http://archive.eclipse.org/webtools/downloads/
seems to be broken. Strangely, the patch drop
http://download.eclipse.org/webtools/patches/drops/R3.4.2/P-3.4.2-20130826221819/
is available...

Gintas

AW: Testing IvyDE

[jhm]

> It looks like Ant nightly is stuck (possibly due to plugin update in
> Jenkins) and it's blocking all other builds.
> 
> Gintas

I can't do it myself so I'll ask for killing the job.

Jan


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Re: Testing IvyDE

[Gintautas Grigelionis]

It looks like Ant nightly is stuck (possibly due to plugin update in
Jenkins) and it's blocking all other builds.

Gintas

Re: Testing IvyDE

[Gintautas Grigelionis]

On Sun, 1 Jul 2018 at 15:05, Nicolas Lalevée 
wrote:

> I have found the issue and pushed a fix.
>
> I am then worried that the master is not well tested nor used after the
> big cleanups. Two big bugs were raised during the release process.
>
> So I suggest we do a little testing now of the master.
>
> To help with that, there is a folder in the IvyDE project which contains
> projects ready to be imported into Eclipse, they are samples of many
> different configurations which should be supported:
> https://github.com/apache/ant-ivyde/tree/master/test <
> https://github.com/apache/ant-ivyde/tree/master/test>
> And the last build can be installed from an update site built there:
> https://builds.apache.org/view/A/view/Ant/job/IvyDE-updatesite/ <
> https://builds.apache.org/view/A/view/Ant/job/IvyDE-updatesite/>
>
> Nicolas
>

The nightly build is still pending...

Gintas

Testing IvyDE

[Nicolas Lalevée]

Le 28 juin 2018 à 08:41, Jaikiran Pai  a écrit :
> 
> 
> On 27/06/18 10:12 PM, Nicolas Lalevée wrote:
>> Since there is a work around (hitting refresh after resolve) and it is an 
>> RC, we could ship it like that and fix it later. But due to the automatic 
>> update via the update site, I bet most users will update even if it is an 
>> RC. So I am not sure what I should vote. So I vote -0 for me for now.
> I was reserving my vote just for this reason. I don't use Eclipse so I wanted 
> to see if someone more familiar with it has an opinion about this bug. You 
> are right that it's going to end up affecting everyone once we release this. 
> Given that the purpose of this release is revive this project a bit and not 
> break setups where things are working fine and the fact that this will end up 
> being an annoying kind of workaround (having to hit refresh after resolve), I 
> don't see rushing this release without fixing this issue serves any purpose.
> 
> So I'll vote a -1 on this now. I know we have gone through 3 voting rounds 
> for this release, so thank you everyone for being patient and testing out the 
> binaries. I'll file this issue in JIRA and hopefully spend some time in 
> Eclipse this weekend to try and sort this out.

I have found the issue and pushed a fix.

I am then worried that the master is not well tested nor used after the big 
cleanups. Two big bugs were raised during the release process.

So I suggest we do a little testing now of the master.

To help with that, there is a folder in the IvyDE project which contains 
projects ready to be imported into Eclipse, they are samples of many different 
configurations which should be supported:
https://github.com/apache/ant-ivyde/tree/master/test 

And the last build can be installed from an update site built there:
https://builds.apache.org/view/A/view/Ant/job/IvyDE-updatesite/ 


Nicolas

Re: FileUtils.normalize/isLeadingPath have bitten me

[Nicolas Lalevée]

At my first read of the code I wondered if paths ending with slash are properly 
handled in every case. After more careful reading, it is seems ok. Maybe some 
unit tests about it would be nice, just to be sure.

Then, about tackling the bug, I am on the same page as you both. It looks good 
to me.

Nicolas

> Le 1 juil. 2018 à 11:27, Stefan Bodewig  a écrit :
> 
> On 2018-06-28, Stefan Bodewig wrote:
> 
>> On 2018-06-28, Jaikiran Pai wrote:
> 
>>> Which then makes me wonder - in the context of this specific
>>> untar/expand/unzip issue, should we probably be using a different
>>> custom very specific logic (which relies on canonical files and
>>> getParent()) instead of a call to isLeadingPath()?
> 
>> Probably. I used isLeadingPath because it has been already there - and )
>> simply didn't realize it wouldn't do what I expected it to.
> 
> I decided to "fix" isLeadingPath for this edge case and add a method
> using canonical paths instead - and use that in unzip and friends.
> 
> Please have a look at the proposed solution, I won't close the Bugzilla
> issue before we have agreed this is the proper fix.
> 
> Cheers
> 
>Stefan
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
> For additional commands, e-mail: dev-h...@ant.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Re: FileUtils.normalize/isLeadingPath have bitten me

[Stefan Bodewig]

On 2018-06-28, Stefan Bodewig wrote:

> On 2018-06-28, Jaikiran Pai wrote:

>> Which then makes me wonder - in the context of this specific
>> untar/expand/unzip issue, should we probably be using a different
>> custom very specific logic (which relies on canonical files and
>> getParent()) instead of a call to isLeadingPath()?

> Probably. I used isLeadingPath because it has been already there - and )
> simply didn't realize it wouldn't do what I expected it to.

I decided to "fix" isLeadingPath for this edge case and add a method
using canonical paths instead - and use that in unzip and friends.

Please have a look at the proposed solution, I won't close the Bugzilla
issue before we have agreed this is the proper fix.

Cheers

Stefan

-
To unsubscribe, e-mail: dev-unsubscr...@ant.apache.org
For additional commands, e-mail: dev-h...@ant.apache.org

Bug report for Ant [2018/07/01]

[bugzilla]

+---+
| Bugzilla Bug ID   |
| +-+
| | Status: UNC=Unconfirmed NEW=New ASS=Assigned|
| | OPN=ReopenedVER=Verified(Skipped Closed/Resolved)   |
| |   +-+
| |   | Severity: BLK=Blocker CRI=Critical  REG=Regression  MAJ=Major   |
| |   |   MIN=Minor   NOR=NormalENH=Enhancement TRV=Trivial |
| |   |   +-+
| |   |   | Date Posted |
| |   |   |  +--+
| |   |   |  | Description  |
| |   |   |  |  |
| 5003|Opn|Blk|2001-11-21|exec task does not return after executed command f|
| 6606|Opn|Enh|2002-02-21|META-BUG problems with delegating classloaders|
| 7552|Opn|Cri|2002-03-28|Invalid task cache in targets |
| 7712|New|Enh|2002-04-03|Provide patternset support for VSSGET task?   |
| 8294|New|Enh|2002-04-19|: Allow  and  to app|
| 8866|New|Enh|2002-05-07|Signal handling in java task  |
| 8895|New|Enh|2002-05-08|ant and/or antcall should support forking |
| 8972|New|Enh|2002-05-10|allow property expansion in  property v|
| 8981|New|Enh|2002-05-10|Tar task command additional features  |
| 9294|New|Enh|2002-05-21|[PATCH] optional/j2ee/ServerDeploy OC4J Support   |
| 9995|Ass|Enh|2002-06-19|MKS Source Integrity tasks|
|10020|New|Enh|2002-06-19|'s dependency behaviour should be more con|
|10231|New|Enh|2002-06-25|Need access to current file in SQLExec|
|10283|New|Enh|2002-06-27|Add a destfile to the uptodate task   |
|10402|New|Enh|2002-07-02|adding the ability of html like whitespace preserv|
|3|New|Enh|2002-07-24|keytool task  |
|11560|Opn|Enh|2002-08-08|Taskdef does not apply reverseLoader policy on sta|
|12267|New|Enh|2002-09-03|Add ability to unzip into separate folders|
|12292|New|Enh|2002-09-04|[PATCH] enable  tag inside tar|
|12334|New|Enh|2002-09-05|REQUEST: Ant task doesn't allow attachment of a bu|
|12518|New|Enh|2002-09-11|Gunzip & BUnZip2 add filesets, patternsets, and ov|
|12765|New|Enh|2002-09-18|"rmdir" and "deltree" patches for ftp task enhance|
|12964|New|Enh|2002-09-24|ANTLR only takes one input file at a time |
|13047|Inf|Enh|2002-09-26|Support for  and  on O|
|13371|New|Enh|2002-10-07|[PATCH] Contributed new CvsExportDiff task|
|13847|New|Nor|2002-10-22|pvcs task: wrong option (-r) specified for get (sh|
|13934|New|Enh|2002-10-24|Translate task shouldn't load default locale prope|
|13939|New|Enh|2002-10-24|Translate task should have better key matching cap|
|14320|New|Enh|2002-11-06|copy fileset followsymlinks="false" does not copy |
|14393|New|Enh|2002-11-08|Support use of jndi within ant|
|14512|New|Enh|2002-11-13|Allow creating database connection similar to  with  does not spot bad symlin|
|15149|New|Enh|2002-12-06|Replace task  |
|15244|New|Enh|2002-12-10|tar task should be able to store symbolic links as|
|15430|New|Enh|2002-12-17|Enhancement to ReplaceRegExp.java |
|15596|New|Enh|2002-12-21|Identity mapper in uptodate task. |
|15747|New|Enh|2003-01-01|change tasks (e.g. Ant) to take urls as well as fi|
|15853|New|Enh|2003-01-07|Allow to plug-in different XML Catalog resolver in|
|15949|Opn|Enh|2003-01-10|please provide links to docs.xml and jakarta-site2|
|16131|New|Enh|2003-01-15|not possible to suppress "BUILD SUCCESSFUL" messag|
|16427|New|Enh|2003-01-26|Output return value of setLastModified/document be|
|16469|New|Enh|2003-01-27|Apply task should allow parallel execution on diff|
|16562|New|Enh|2003-01-29|Can not accept characters  from keyboard in a thre|
|16860|New|Enh|2003-02-06|Silent or Debug a single target   |
|16896|New|Enh|2003-02-07|Support in ProjectHelper / ProjectHelperImpl to op|
|17074|New|Enh|2003-02-14|Contribution for WLSTOP   |
|17181|New|Nor|2003-02-18|Build fails while trying to get VSS files by label|
|17372|New|Enh|2003-02-25|Enhancement of replace Task   |
|17742|New|Maj|2003-03-06|PVCS task generates GET with promotion group incor|
|17781|New|Enh|2003-03-07|name attribute of record task is not relative to b|
|17829|New|Enh|2003-03-10|Allow ejbjar task to accept nested manifest   |
|17850|New|Nor|2003-03-10|PVCS task dont work with promotion group  |
|17961|New|Enh|2003-03-13|New task to collect services from a JAR   |