Re: ant git commit: Add magic names for tests, run more tests in Surefire

2018-11-01 Thread Gintautas Grigelionis
ates isolation on the fly (which is cheating on Maven :-), because I was thinking of launcher-core and core-junit interdependencies on the test level, and I'd still like to figure out a way of running all Ant tests in Surefire while producing artifacts corresponding to Ant build as closely a

Re: ant git commit: Add magic names for tests, run more tests in Surefire

2018-10-29 Thread Stefan Bodewig
On 2018-10-28, Gintautas Grigelionis wrote: > Even if running unit tests with different tools is a no-goal for you, it's > a good check of robustness -- ACK > I'm afraid we're cheating a little anyway by compiling testutil with core > tests first, and then building a separate jar file. This is

Re: ant git commit: Add magic names for tests, run more tests in Surefire

2018-10-29 Thread Stefan Bodewig
On 2018-10-29, Gintautas Grigelionis wrote: >> Thanks, I'll merge it to master, then. > I've notice in Nightly that Ant treats MagicTestNames as a test, too. Uhm, it shouldn't. > Would it make sense to add a test method, checking for documented > properties? Adding a test that asserts the cons

Re: ant git commit: Add magic names for tests, run more tests in Surefire

2018-10-28 Thread Gintautas Grigelionis
> Thanks, I'll merge it to master, then. > I've notice in Nightly that Ant treats MagicTestNames as a test, too. Would it make sense to add a test method, checking for documented properties? Gintas

Re: ant git commit: Add magic names for tests, run more tests in Surefire

2018-10-28 Thread Stefan Bodewig
On 2018-10-28, Gintautas Grigelionis wrote: >> The tests for core fail for me (CommandlineJava) anyway. I think I've >> already said that running Ant's unit tests in Maven is a non-goal for me >> :-) > I'll have a closer look at it tomorrow, if you don't mind. Could you please > provide some deta

Re: ant git commit: Add magic names for tests, run more tests in Surefire

2018-10-28 Thread Gintautas Grigelionis
> The tests for core fail for me (CommandlineJava) anyway. I think I've > already said that running Ant's unit tests in Maven is a non-goal for me > :-) > I'll have a closer look at it tomorrow, if you don't mind. Could you please provide some details of your setup? Even if running unit tests with

Re: ant git commit: Add magic names for tests, run more tests in Surefire

2018-10-28 Thread Stefan Bodewig
On 2018-10-28, Gintautas Grigelionis wrote: > On Sun, 28 Oct 2018 at 21:02, Stefan Bodewig wrote: >> On 2018-10-28, Gintautas Grigelionis wrote: >>> On Sun, 28 Oct 2018 at 20:23, Stefan Bodewig wrote: I guess I need to create a branch to either convince you it is possible or convince

Re: ant git commit: Add magic names for tests, run more tests in Surefire

2018-10-28 Thread Gintautas Grigelionis
On Sun, 28 Oct 2018 at 21:02, Stefan Bodewig wrote: > On 2018-10-28, Gintautas Grigelionis wrote: > > On Sun, 28 Oct 2018 at 20:23, Stefan Bodewig wrote: > > >> I guess I need to create a branch to either convince you it is possible > >> or convince me that it is not :-) > > > No branch is neces

Re: ant git commit: Add magic names for tests, run more tests in Surefire

2018-10-28 Thread Stefan Bodewig
On 2018-10-28, Gintautas Grigelionis wrote: > On Sun, 28 Oct 2018 at 20:23, Stefan Bodewig wrote: >> I guess I need to create a branch to either convince you it is possible >> or convince me that it is not :-) > No branch is necessary, just activate launcher tests; the effect will be > the sam

Re: ant git commit: Add magic names for tests, run more tests in Surefire

2018-10-28 Thread Gintautas Grigelionis
On Sun, 28 Oct 2018 at 20:23, Stefan Bodewig wrote: > On 2018-10-28, Gintautas Grigelionis wrote: > > On Sun, 28 Oct 2018 at 18:48, Stefan Bodewig wrote: > >> On 2018-10-28, Gintautas Grigelionis wrote: > >>> On Sun, 28 Oct 2018 at 18:17, Stefan Bodewig > wrote: > On 2018-10-28, Gintautas

Re: ant git commit: Add magic names for tests, run more tests in Surefire

2018-10-28 Thread Stefan Bodewig
On 2018-10-28, Stefan Bodewig wrote: > On 2018-10-28, Gintautas Grigelionis wrote: >> On Sun, 28 Oct 2018 at 18:48, Stefan Bodewig wrote: >>> On 2018-10-28, Gintautas Grigelionis wrote: On Sun, 28 Oct 2018 at 18:17, Stefan Bodewig wrote: > On 2018-10-28, Gintautas Grigelionis wrote: >

Re: ant git commit: Add magic names for tests, run more tests in Surefire

2018-10-28 Thread Stefan Bodewig
On 2018-10-28, Gintautas Grigelionis wrote: > On Sun, 28 Oct 2018 at 18:48, Stefan Bodewig wrote: >> On 2018-10-28, Gintautas Grigelionis wrote: >>> On Sun, 28 Oct 2018 at 18:17, Stefan Bodewig wrote: On 2018-10-28, Gintautas Grigelionis wrote: > On Sun, 28 Oct 2018 at 17:59, Stefan Bo

Re: ant git commit: Add magic names for tests, run more tests in Surefire

2018-10-28 Thread Gintautas Grigelionis
On Sun, 28 Oct 2018 at 18:48, Stefan Bodewig wrote: > On 2018-10-28, Gintautas Grigelionis wrote: > > On Sun, 28 Oct 2018 at 18:17, Stefan Bodewig wrote: > >> On 2018-10-28, Gintautas Grigelionis wrote: > >>> On Sun, 28 Oct 2018 at 17:59, Stefan Bodewig > wrote: > > I wonder whether it wou

Re: ant git commit: Add magic names for tests, run more tests in Surefire

2018-10-28 Thread Stefan Bodewig
On 2018-10-28, Gintautas Grigelionis wrote: > On Sun, 28 Oct 2018 at 18:17, Stefan Bodewig wrote: >> On 2018-10-28, Gintautas Grigelionis wrote: >>> On Sun, 28 Oct 2018 at 17:59, Stefan Bodewig wrote: I wonder whether it wouldn't be a good idea to create a separate class for constant

Re: ant git commit: Add magic names for tests, run more tests in Surefire

2018-10-28 Thread Gintautas Grigelionis
On Sun, 28 Oct 2018 at 18:17, Stefan Bodewig wrote: > On 2018-10-28, Gintautas Grigelionis wrote: > > On Sun, 28 Oct 2018 at 17:59, Stefan Bodewig wrote: > > >> I wonder whether it wouldn't be a good idea to create a separate class > >> for constants used during testing that lives in ant-testuti

Re: ant git commit: Add magic names for tests, run more tests in Surefire

2018-10-28 Thread Stefan Bodewig
On 2018-10-28, Gintautas Grigelionis wrote: > On Sun, 28 Oct 2018 at 17:59, Stefan Bodewig wrote: >> I wonder whether it wouldn't be a good idea to create a separate class >> for constants used during testing that lives in ant-testutil rather than >> poluting the "magic names" of Ant. > The pro

Re: Tests in Surefire

2018-10-28 Thread Gintautas Grigelionis
On Thu, 25 Oct 2018 at 09:05, Gintautas Grigelionis wrote: > On Wed, 24 Oct 2018 at 00:29, Gintautas Grigelionis < > g.grigelio...@gmail.com> wrote: > >> On Tue, 23 Oct 2018 at 12:25, Stefan Bodewig wrote: >> >>> On 2018-10-20, Gintautas Grigelionis wrote: >>> >>> > I believe that in order to ex

Re: ant git commit: Add magic names for tests, run more tests in Surefire

2018-10-28 Thread Gintautas Grigelionis
On Sun, 28 Oct 2018 at 17:59, Stefan Bodewig wrote: > On 2018-10-23, wrote: > > > > http://git-wip-us.apache.org/repos/asf/ant/blob/679a9422/src/main/org/apache/tools/ant/MagicNames.java > > >+/** > >+ * Magic property that makes unit tests based on BuildFileTest > >+ * or BuildFileR

Re: ant git commit: Add magic names for tests, run more tests in Surefire

2018-10-28 Thread Stefan Bodewig
On 2018-10-23, wrote: > http://git-wip-us.apache.org/repos/asf/ant/blob/679a9422/src/main/org/apache/tools/ant/MagicNames.java >+/** >+ * Magic property that makes unit tests based on BuildFileTest >+ * or BuildFileRule ignore externally set basedir >+ * (typically by Surefire/Fa

Re: Tests in Surefire

2018-10-25 Thread Gintautas Grigelionis
On Wed, 24 Oct 2018 at 00:29, Gintautas Grigelionis wrote: > On Tue, 23 Oct 2018 at 12:25, Stefan Bodewig wrote: > >> On 2018-10-20, Gintautas Grigelionis wrote: >> >> > I believe that in order to execute Ant test suite in Surefire one must >> > configure basedir which unfortunately affects Ant

Re: Tests in Surefire

2018-10-23 Thread Gintautas Grigelionis
On Tue, 23 Oct 2018 at 12:25, Stefan Bodewig wrote: > On 2018-10-20, Gintautas Grigelionis wrote: > > > I believe that in order to execute Ant test suite in Surefire one must > > configure basedir which unfortunately affects Ant test projects. > > I'm not sure I share the goal of trying to run th

Re: Tests in Surefire

2018-10-23 Thread Stefan Bodewig
On 2018-10-20, Gintautas Grigelionis wrote: > I believe that in order to execute Ant test suite in Surefire one must > configure basedir which unfortunately affects Ant test projects. I'm not sure I share the goal of trying to run the tests via Surefire at all. Antoine has been the one who set u

Re: Tests in Surefire

2018-10-22 Thread Gintautas Grigelionis
Here's what happened: there's a Jenkins job that builds Ant using Maven, since Ant project has POMs for all components. I happened to create a new component, and realised I forgot to add it to the master POM. While doing that, I saw that the Jenkins job has been broken, and started digging deeper.

Re: Tests in Surefire

2018-10-21 Thread Jaikiran Pai
Could you tell us a bit more about what is being attempted? Are you saying you plan to run the tests that are part of the Ant project, through the mvn command, while building Ant? -Jaikiran On 20/10/18 3:31 PM, Gintautas Grigelionis wrote: > I believe that in order to execute Ant test suite in S

Tests in Surefire

2018-10-20 Thread Gintautas Grigelionis
I believe that in order to execute Ant test suite in Surefire one must configure basedir which unfortunately affects Ant test projects. Perhaps it would make sense to have a magic property that (in combination with detection of Surefire environment) would allow BuildFileRule to call System.clearPro