Github user lewismc commented on a diff in the pull request:
https://github.com/apache/any23/pull/51#discussion_r158862497
--- Diff:
core/src/test/java/org/apache/any23/extractor/yaml/YAMLExtractorTest.java ---
@@ -125,7 +121,7 @@ public void treeTest() throws Exception
GitHub user lewismc opened a pull request:
https://github.com/apache/any23/pull/52
ANY23-318 ExtractionException handling in BaseRDFExtractor.java kills
entire extraction
This issue addresses https://issues.apache.org/jira/browse/ANY23-318
It also includes several improvements
Github user lewismc closed the pull request at:
https://github.com/apache/any23/pull/24
---
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/49
Any comments folks?
---
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/50
Any comments folks?
---
GitHub user lewismc opened a pull request:
https://github.com/apache/any23/pull/50
ANy23-298 Revisit the OGP.java vocabulary and update it
This PR addresses https://issues.apache.org/jira/browse/ANY23-298
You can merge this pull request into a Git repository by running:
$ git
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/49
In the case where one encounters a parse and/or extraction error hence an
unsuccessful extraction, one would see the following result.
As you can see, the partial extraction is now included
GitHub user lewismc opened a pull request:
https://github.com/apache/any23/pull/49
ANY23-314 Service fails to return extraction in case of extraction error
This issue primarily addresses
https://issues.apache.org/jira/browse/ANY23-314
Additional changes are trivial code
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/45
Hi @jgrzebyta I pulled the code and tested it... all looks good and test
successfully. I think the additions here make good improvements. I am +1 to
merge.
---
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/47
@imduffy15 done
https://github.com/apache/any23/blob/master/CONTRIBUTING.md, thanks for the
suggestion I completely agree.
Regarding TravisCI, we already have a pretty well configured Jenkins
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/any23/pull/45#discussion_r151035471
--- Diff:
core/src/main/java/org/apache/any23/extractor/yaml/ElementsProcessor.java ---
@@ -0,0 +1,201 @@
+/*
+ * Copyright 2017 The Apache Software
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/45
@jgrzebyta I am not sure about the ```ref:List``` either. Do you have
examples of
* an rdf:List, and
* a SPARQL query which may loose order
?
---
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/47
Hi @imduffy15 thank you for the PR
In the future if you would please open a JIRA issue over on the ANY23 JIRA
issue tracker and name your PR title with the same title as your JIRA issue it
means
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/46
Thank you @The-Alchemist apologies, I did't pick this patch up until now.
In the future could you please open a JIRA ticket at
https://issues.apache.org/jira/projects/ANY23, after you've opened
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/43
@jgrzebyta when I test this I get the following
```
[ERROR] Failures:
[ERROR]
YAMLExtractorTest.treeTest:102->AbstractExtractorTestCase.assertContainsModel:
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/34
Hi @ansell , in my last commit I've pushed a coupe of (hopefully)
satisfying additions, namely
* removal of open module from CLI (meaning that, by default the open
extractor is not executed
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/any23/pull/24#discussion_r134831365
--- Diff: api/src/main/java/org/apache/any23/extractor/Extractor.java ---
@@ -39,22 +38,6 @@
/**
* This interface specializes
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/34
Hi @ansell yes this is a separate module however currently it always builds
with CLI module. I'm going to push an update which disables the module tests by
default.
---
If your project is set up
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/34
Will commit within next day or so if there are no objections.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/34
Hi @ansell I finally got around to addressing your comments. Just to
refresh your memory, use of FileOutputStream (as oppose to
ByteArrayOutputStream) within the OpenExtractorTest.java logic is more
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/37
Hi @ansell I have reverted the prefix list and committed the patch to
master, if we find that this creates a nasty issue moving forward we can revert
the commit.
---
If your project is set up
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/any23/pull/44#discussion_r129690299
--- Diff:
core/src/main/java/org/apache/any23/writer/LoggingTripleHandler.java ---
@@ -111,6 +116,6 @@ public void setContentLength(long contentLength
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/any23/pull/44#discussion_r129171485
--- Diff:
core/src/main/java/org/apache/any23/writer/LoggingTripleHandler.java ---
@@ -111,6 +116,6 @@ public void setContentLength(long contentLength
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/37
Thanks @ansell can you please scope out the edit (regression???) I had to
make to service/src/test/java/org/apache/any23/servlet/ServletTest.java
Thanks
---
If your project is set up for it, you
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/37
any comments here folks?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/38
@ansell sure thing
```
---
Test set: com.github.jsonldjava.core.LocalBaseTest
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/40
@band the canonical source code for Any23 is available at
https://git-wip-us.apache.org/repos/asf/any23.git as per [parent pom.xml
specification](https://github.com/apache/any23/blob/master/pom.xml
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/38
@jgrzebyta this is now in conflict
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/41
Hi @ansell this looks grand...
I am getting following errors... but I think it may be something to do with
my local build. Note, I was getting similar issues when attempting to build
following
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/40
+1 @band please merge into master and if possible please publish Website.
If you need a hand please let me know. Thank you
---
If your project is set up for it, you can reply to this email and have
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/39
@jgrzebyta right now this pull request only satisfies the first of the
above criteria.. is this correct?
How do you propose to satisfy the remaining items?
We also have a build service which
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/38
@ansell are you able to fetch this pull request and test it locally? I am
still getting the failures as above.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/38
Hi @jgrzebyta this is when I attempt build the source project from top
level directory
```
$ mvn clean test
...
Results :
Tests in error
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/38
@jgrzebyta upon running the proposed tests I get the following
```
Running org.apache.any23.extractor.yaml.YAMLExtractorTest
[2017-06-20 13:00:10,613] INFO 5268[main] -
org.apache.any23
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/37
This currently results in some extraction errors/exceptions so we need to
find new IRI's for the sindice entries.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user lewismc opened a pull request:
https://github.com/apache/any23/pull/37
ANY23-282 Replacement for all Sindice namespaces and URI's
This issue addresses https://issues.apache.org/jira/browse/ANY23-282
You can merge this pull request into a Git repository by running
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/any23/pull/34#discussion_r103832543
--- Diff:
openie/src/test/java/org/apache/any23/openie/OpenIEExtractorTest.java ---
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/any23/pull/34#discussion_r103829816
--- Diff:
openie/src/main/java/org/apache/any23/extractor/openie/OpenIEExtractor.java ---
@@ -0,0 +1,129 @@
+/*
+ * Licensed to the Apache Software
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/34
PING... anyone that is able to provide a review? Would be very much
appreciated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/34
Hi @ansell this is now fixed... if you could pull the code and let me know
how you get on it would be appreciated.
After a good bit of debugging I discovered that some erroneous
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/34
Yep your right. Bang on the money. I'll update the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/34
OK so implementing ExtractorPlugin is not necessary... none of the other
plugins use this logic.
I'm trying to get it working via cli appassembler script however no joy yet.
---
If your project
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/34
@ansell is it necessary to put this new module into ```plugins``` and have
the new extractor implement
[ExtractorPlugin](http://any23.apache.org/apidocs/index.html?org/apache/any23/plugin
GitHub user lewismc opened a pull request:
https://github.com/apache/any23/pull/34
ANY23-304 Add extractor for OpenIE
Hi Folks,
This issue is a rework of #33 which takes on board @ansell 's comments to
add the new extractor as a separate module as oppose to inside of core
Github user lewismc closed the pull request at:
https://github.com/apache/any23/pull/33
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/33
> If there are a large number of new transitive dependencies, possibly
useful to add this as a plugin rather than into the core module.
Yes I think this is an excellent suggestion. I'm go
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/any23/pull/33#discussion_r101650632
--- Diff: core/src/main/java/org/apache/any23/rdf/RDFUtils.java ---
@@ -564,6 +569,4 @@ public static boolean isAbsoluteIRI(String href
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/any23/pull/33#discussion_r101650651
--- Diff:
core/src/main/java/org/apache/any23/extractor/openie/OpenIEExtractor.java ---
@@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software
GitHub user lewismc opened a pull request:
https://github.com/apache/any23/pull/33
ANY23-304 Add extractor for OpenIE 1st pass
This issue is a first pass at addressing
https://issues.apache.org/jira/browse/ANY23-304. There is more work to be done
on the new extractor. The new
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/27
Now getting the following when I attempt to build
```
[INFO]
[INFO] BUILD FAILURE
[INFO
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/27
Hi @ansell this is starting to look REALLY good. I've pulled your
suggestions. I did notice that the appassembler is still generated in the
core/target/appassembler. I think that this can be removed
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/27
@ansell I just pulled the most recent version of this PR build and tested
locally... all tests pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/32
@jgrzebyta this looks great.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/31
Merged thank you @jgrzebyta
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/27
Hi @ansell whats the current state of this patch? Thanks for merging in the
PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/27
ack will do @ansell thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/30
Thank you @ansell
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/30
Excellent Sir thank you :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/28
Thanks for committing to master @band . In the future, if you name your
pull request as the Jira issue you created then our Github hooks will pick it
up and associate it with the Jira ticket. Can you
GitHub user lewismc opened a pull request:
https://github.com/apache/any23/pull/29
ANY23-296 Tar complains about groupid value being too big
This issue addresses https://issues.apache.org/jira/browse/ANY23-296
You can merge this pull request into a Git repository by running
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/27
ACK @ansell I've made an addition trivial correction within the default
configuration file so if you merge then we can get semargl released and upgrade
then it would be great and we can put this one
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/26
This looks brilliant. I will merge ASAP. Thanks @band
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user lewismc commented on the pull request:
https://github.com/apache/any23/pull/24#issuecomment-212761670
Anyone get a chance to take a look at this? This is THE critical issue for
Any23 to address right now IMHO.
---
If your project is set up for it, you can reply
GitHub user lewismc opened a pull request:
https://github.com/apache/any23/pull/24
Initial move towards addressing ANY23-280 Refactor ContentExtractor to
improve extraction flexibility
Hi Folks,
This is an initial crack at addressing
https://issues.apache.org/jira/browse/ANY23
Github user lewismc commented on the pull request:
https://github.com/apache/any23/pull/17#issuecomment-202702530
@ansell any further comments here? I will try to get to work on the larger
issue this week.
---
If your project is set up for it, you can reply to this email and have
Github user lewismc commented on the pull request:
https://github.com/apache/any23/pull/23#issuecomment-201744587
Thank you @RobertMeusel
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user lewismc commented on the pull request:
https://github.com/apache/any23/pull/23#issuecomment-201743212
https://issues.apache.org/jira/browse/ANY23-279
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user lewismc commented on the pull request:
https://github.com/apache/any23/pull/23#issuecomment-201735180
FYI, the reason we did not get notified is that we have Github hooks set
up. The main source resides at the Apache Software Foundation at
https://git-wip
Github user lewismc commented on the pull request:
https://github.com/apache/any23/pull/23#issuecomment-201735043
Hi @RobertMeusel I did not even notice this issue, apologies for such late
reply!
I am going to look at master branch, if this is the bug you've mentioned
then I'll
Github user lewismc commented on the pull request:
https://github.com/apache/any23/pull/17#issuecomment-201573785
ACK @ansell , master branch is unstable with the following test failures
https://builds.apache.org/view/A-D/view/Any23/job/Any23-trunk/1466/#showFailuresLink
Github user lewismc commented on the pull request:
https://github.com/apache/any23/pull/17#issuecomment-201550510
I agree. Jumping through this in the debugged made me think the same.
I think it is different if Any23 is to be a PURE implementation... But that
is clearly
Github user lewismc commented on the pull request:
https://github.com/apache/any23/pull/17#issuecomment-201537723
hi @ansell OK I've added in the correct rule and fix as well as a test to
verify that empty itemscope values are identified and fixed.
Whilst debugging this however
GitHub user lewismc opened a pull request:
https://github.com/apache/any23/pull/22
ANY23-278 Upgrade all Maven plugin versions in parent pom.xml
This issue addresses https://issues.apache.org/jira/browse/ANY23-278
You can merge this pull request into a Git repository by running
GitHub user lewismc opened a pull request:
https://github.com/apache/any23/pull/21
ANY23-274 Change any23.microdata.ns.default configuration value to
http://schema.org
This issues addresses https://issues.apache.org/jira/browse/ANY23-274
You can merge this pull request into a Git
GitHub user lewismc opened a pull request:
https://github.com/apache/any23/pull/20
ANY23-277 Any23 master branch will not build to to build due to lacking
maven-assembly-plugin
This issue addresses https://issues.apache.org/jira/browse/ANY23-277
It also adds some configuration
Github user lewismc commented on the pull request:
https://github.com/apache/any23/pull/18#issuecomment-137988055
Hi Renato to be honest I didn't event notice it.
I think generally speaking it probably is Not encouraged as we all share
the code. I am not fussed either way
Github user lewismc commented on the pull request:
https://github.com/apache/any23/pull/18#issuecomment-137967938
hey @renato2099 which tag do you mean? ta
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user lewismc commented on the pull request:
https://github.com/apache/any23/pull/18#issuecomment-137967921
@nisalanirmana is this PR completed now based on our discussion over on the
GSoC wiki page? If it is then I can get this merged in to master branch. Thank
you
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/any23/pull/18#discussion_r38061468
--- Diff:
core/src/main/java/org/apache/any23/extractor/html/microformats2/HItemExtractor.java
---
@@ -0,0 +1,85 @@
+package org.apache.any23
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/any23/pull/18#discussion_r38061472
--- Diff:
core/src/main/java/org/apache/any23/extractor/html/microformats2/HItemExtractorFactory.java
---
@@ -0,0 +1,40 @@
+package org.apache.any23
GitHub user lewismc opened a pull request:
https://github.com/apache/any23/pull/18
Gsoc 2015 Microformats2
I am initiating this PR on behalf of @nisalanirmana so we can think about
closing off the GSoC work for the summer. This PR _should_ represent
Microformats2 support
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/any23/pull/18#discussion_r37917661
--- Diff:
core/src/main/java/org/apache/any23/extractor/html/microformats2/HItemExtractor.java
---
@@ -0,0 +1,85 @@
+package org.apache.any23
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/any23/pull/18#discussion_r37917681
--- Diff:
core/src/main/java/org/apache/any23/extractor/html/microformats2/HItemExtractorFactory.java
---
@@ -0,0 +1,40 @@
+package org.apache.any23
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/any23/pull/18#discussion_r37917869
--- Diff: core/src/test/java/org/apache/any23/vocab/RDFSchemaUtilsTest.java
---
@@ -43,7 +43,7 @@
*/
@Test
public void
Github user lewismc commented on the pull request:
https://github.com/apache/any23/pull/17#issuecomment-88051079
@ansell done, the branch is now 2 ahead of master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user lewismc commented on the pull request:
https://github.com/apache/any23/pull/17#issuecomment-88056599
When I debug this, a good place to set a breakpoint is at line
https://github.com/apache/any23/blob/master/core/src/main/java/org/apache/any23/extractor
Github user lewismc commented on the pull request:
https://github.com/apache/any23/pull/17#issuecomment-88056267
By the way @ansell, an observation is that whenever we make an attempt to
infer the document language, we never succeed. It is always returns null. On
every single
GitHub user lewismc opened a pull request:
https://github.com/apache/any23/pull/17
ANY23-247 FIX Attribute name itemscope associated with an element type html
must be followed by the ' = ' character.
Hi Folks,
PR which fixes this issue locally. I am getting clean builds now
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/any23/pull/17#discussion_r27442017
--- Diff:
core/src/main/java/org/apache/any23/validator/rule/MissingItemscopeAttributeValueRule.java
---
@@ -0,0 +1,52 @@
+/*
+ * Licensed
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/any23/pull/17#discussion_r27444925
--- Diff:
core/src/main/java/org/apache/any23/validator/rule/MissingItemscopeAttributeValueRule.java
---
@@ -0,0 +1,52 @@
+/*
+ * Licensed
Github user lewismc commented on a diff in the pull request:
https://github.com/apache/any23/pull/17#discussion_r27444885
--- Diff:
core/src/main/java/org/apache/any23/validator/rule/MissingItemscopeAttributeValueRule.java
---
@@ -0,0 +1,52 @@
+/*
+ * Licensed
GitHub user lewismc opened a pull request:
https://github.com/apache/any23/pull/15
ANY23-253 JSON-LD cannot be processed by Rover
Hi @michelemostarda, please check out the results which I now get when I
run the following
lmcgibbn@LMC-032857 /usr/local/any23/core/target
Github user lewismc commented on the pull request:
https://github.com/apache/any23/pull/13#issuecomment-76448755
all tests pass locally. Would be appreciated if someone could confirm.
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user lewismc opened a pull request:
https://github.com/apache/any23/pull/13
ANY23-250 Upgrade to Tika 1.7
Hi Folks,
Please see PR for master branch which addresses ANY23-250
You can merge this pull request into a Git repository by running:
$ git pull https
Github user lewismc commented on the pull request:
https://github.com/apache/any23/pull/12#issuecomment-73071919
@ansell can you take a look? Thank you Peter
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user lewismc opened a pull request:
https://github.com/apache/any23/pull/11
ANY23-246 Add Open Graph Protocol and Facebook prefixes to popular.prefixes
Pull request bundled with ANY23-131
I am getting better results here with more triples being extracted hence
bumping
101 - 196 of 196 matches
Mail list logo
