[PATCH] iconv tweak

2001-02-05 Thread Greg Stein
There was some discussion about iconv prototyes here recently, but I kind of missed it. Do we always need to live with a warning about a type mismatch, or is the cast below appropriate? IOW, do some headers have const on them, and others not? Cheers, -g Index: xlate.c

Re: [PATCH] iconv tweak

2001-02-05 Thread Sam TH
On Sun, Feb 04, 2001 at 09:26:39PM -0800, Greg Stein wrote: There was some discussion about iconv prototyes here recently, but I kind of missed it. Do we always need to live with a warning about a type mismatch, or is the cast below appropriate? IOW, do some headers have const on them,

Re: FreeBSD 4.2 breakage (?)

2001-02-05 Thread pete collins
It might be the Makefile because i can compile it manually. $ gcc -g -Wall -c svn_string.c -I../../apr/include -I../../subversion/include $ ls -l svn_string.o -rw-r--r-- 1 root wheel 19336 Feb 5 11:47 svn_string.o --pete Ben Collins-Sussman wrote: Boy, I'm bit out of my league here

Re: FreeBSD 4.2 breakage (?)

2001-02-05 Thread Greg Hudson
/usr/include/sys/socket.h:47: syntax error before `sa_family_t' [etc.] The problem is the -D_POSIX_SOURCE which Greg Stein added last night. I was thinking of sending mail about it at the time, but decided he had probably done all the necessary footwork; I guess he missed something. If you

Re: cvs commit: apr STATUS

2001-02-05 Thread rbb
+* I think apr_open_stderr() and friends dup() the descriptor. That + would allow the new/returned file to be closed (via pool cleanup + or manually) without accidentally closing stderr/out. The goal of those functions is to actually get stderr, stdout, stdin

Re: FreeBSD 4.2 breakage (?)

2001-02-05 Thread Greg Hudson
I spent a good amount of time trying to figure out the right combination to allow us to include string.h and strings.h (which is done by apr_want.h) without some redundant declaration warnings. Can we change apr_want.h not to include strings.h if APR_HAVE_STRING_H is defined? Removing

Re: FreeBSD 4.2 breakage (?)

2001-02-05 Thread Jeff Trawick
Regarding _POSIX_SOURCE: What did this solve again? Perhaps my knowledge needs updating, but it wasn't long ago that there was no ratified POSIX standard which covered the networking APIs. I am pretty sure that no POSIX standard covers everything which Apache/APR needs. Frankly, I'm not too