Re: Pools rewrite [3]

2001-12-06 Thread Brian Pane
Sander Striker wrote: ... *) The performance gain is in not having to walk the list of nodes in apr_pool_clear as mentioned above. Maybe this is not really a performance win, but more of a better devision of processing time. apr_pool_clear and apr_pool_destroy have less work to do, this cou

RE: Problem with memory initialization.

2001-12-06 Thread Sander Striker
> From: Ryan Bloom [mailto:[EMAIL PROTECTED] > Sent: 06 December 2001 20:34 > On Thursday 06 December 2001 11:29 am, Aaron Bannert wrote: > > On Thu, Dec 06, 2001 at 11:23:44AM -0800, Brian Pane wrote: > > > >It is the apr_pool_init function, which is creating the lock with a NULL > > > >fname, so

Re: Problem with memory initialization.

2001-12-06 Thread Aaron Bannert
On Thu, Dec 06, 2001 at 11:34:01AM -0800, Ryan Bloom wrote: > > The only place where I see this happening is in the shmem.c code. > > Other than that I don't see anywhere else in APR/APR-UTIL that > > is creating a CROSS_PROCESS or LOCKALL scoped lock. > > > > Perhaps it's just the accept mutex in

Re: Problem with memory initialization.

2001-12-06 Thread Ryan Bloom
On Thursday 06 December 2001 11:29 am, Aaron Bannert wrote: > On Thu, Dec 06, 2001 at 11:23:44AM -0800, Brian Pane wrote: > > >It is the apr_pool_init function, which is creating the lock with a NULL > > >fname, so it is a bigger problem than just the pool lock. > > > > Why is the pool initializati

Re: Problem with memory initialization.

2001-12-06 Thread Ryan Bloom
On Thursday 06 December 2001 11:23 am, Brian Pane wrote: > Ryan Bloom wrote: > >On Thursday 06 December 2001 11:11 am, Aaron Bannert wrote: > >>>The biggest problem is that this would change the API for the one > >>>function that must be in every APR program. > >>> > >>>Thoughts? > >> > >>Is it the

Re: Problem with memory initialization.

2001-12-06 Thread Aaron Bannert
On Thu, Dec 06, 2001 at 11:23:44AM -0800, Brian Pane wrote: > >It is the apr_pool_init function, which is creating the lock with a NULL > >fname, so it is a bigger problem than just the pool lock. > > Why is the pool initialization creating a crossprocess lock?! The only place where I see this ha

Re: Problem with memory initialization.

2001-12-06 Thread Brian Pane
Ryan Bloom wrote: On Thursday 06 December 2001 11:11 am, Aaron Bannert wrote: The biggest problem is that this would change the API for the one function that must be in every APR program. Thoughts? Is it the lock routine or something specific to apr_pool_init that is creating the tmpfile? In genera

Re: Problem with memory initialization.

2001-12-06 Thread Ryan Bloom
On Thursday 06 December 2001 11:11 am, Aaron Bannert wrote: > > The biggest problem is that this would change the API for the one > > function that must be in every APR program. > > > > Thoughts? > > Is it the lock routine or something specific to apr_pool_init that is > creating the tmpfile? In ge

Re: Problem with memory initialization.

2001-12-06 Thread Justin Erenkrantz
On Thu, Dec 06, 2001 at 11:16:56AM -0800, Ryan Bloom wrote: > > I don't think it would be worth the time and effort. > > running with a full /tmp is not very healthy for the system at all. > > maybe a better error message in apr_initialize saying 'unable to create > > lockfile /tmp/apr > > is a

Re: Problem with memory initialization.

2001-12-06 Thread Ryan Bloom
On Thursday 06 December 2001 11:03 am, Ian Holsman wrote: > On Thu, 2001-12-06 at 10:59, Ryan Bloom wrote: > > This took me a while to track down, but I did it. One of the engineers > > at Covalent tried to start Apache with a full /tmp file system. None of > > his Apache directives pointed to /t

Re: Problem with memory initialization.

2001-12-06 Thread Aaron Bannert
On Thu, Dec 06, 2001 at 10:59:20AM -0800, Ryan Bloom wrote: > > This took me a while to track down, but I did it. One of the engineers at > Covalent tried to start Apache with a full /tmp file system. None of his > Apache > directives pointed to /tmp, so he assumed he would be okay. Unfortunat

Re: Problem with memory initialization.

2001-12-06 Thread Ian Holsman
On Thu, 2001-12-06 at 10:59, Ryan Bloom wrote: > > This took me a while to track down, but I did it. One of the engineers at > Covalent tried to start Apache with a full /tmp file system. None of his > Apache > directives pointed to /tmp, so he assumed he would be okay. Unfortunately, > he was

Problem with memory initialization.

2001-12-06 Thread Ryan Bloom
This took me a while to track down, but I did it. One of the engineers at Covalent tried to start Apache with a full /tmp file system. None of his Apache directives pointed to /tmp, so he assumed he would be okay. Unfortunately, he wasn't, the server was giving him an error because /tmp was ful

about usefulness of apr_file_mktemp

2001-12-06 Thread Stas Bekman
I've looked at apr_file_mktemp (need it for mod_perl 2.0). I guess I don't understand something. Why the developer is supposed to do the work of mktemp? It wants to receive a path-template, but how am I supposed to know what path will work across platforms? e.g. /tmp is not available on all pla

Re: [patch srclib/apr/file_io/unix/filedup.c] broken dup

2001-12-06 Thread Stas Bekman
Jeff Trawick wrote: Thanks for the fix! Stas Bekman <[EMAIL PROTECTED]> writes: After dupping the fd, the first read was getting 0 as a first char. Of course other platforms should probably also fixed. While I had the time to commit this, I can't look into the other platforms at the moment. If no

Re: [patch srclib/apr/file_io/unix/filedup.c] broken dup

2001-12-06 Thread Jeff Trawick
Thanks for the fix! Stas Bekman <[EMAIL PROTECTED]> writes: > After dupping the fd, the first read was getting 0 as a first char. Of > course other platforms should probably also fixed. While I had the time to commit this, I can't look into the other platforms at the moment. If nobody does anyt

Re: cvs commit: apr/test testfmt.c

2001-12-06 Thread Jeff Trawick
Cliff Woolley <[EMAIL PROTECTED]> writes: > On 6 Dec 2001 [EMAIL PROTECTED] wrote: > > >{ > > -apr_os_proc_t var; > > -memset(&var, 0, sizeof var); > > +apr_os_proc_t var = 0; > >sprintf(buf, "%" APR_OS_PROC_T_FMT, var); > > Can you actually assi

RE: Pools rewrite [3]

2001-12-06 Thread Sander Striker
> From: Sander Striker [mailto:[EMAIL PROTECTED] > Sent: 06 December 2001 09:50 > > From: Brian Pane [mailto:[EMAIL PROTECTED] > > Sent: 06 December 2001 07:52 > [...] > > >APR_DECLARE(void *) apr_palloc(apr_pool_t *pool, apr_size_t size) > > >{ > > > > > > > > > >/* Reset the active no

RE: Pools rewrite [3]

2001-12-06 Thread Sander Striker
> From: Brian Pane [mailto:[EMAIL PROTECTED] > Sent: 06 December 2001 07:52 > Sander Striker wrote: > > > This is the 3rd round of the pools rewrite. This time I have gotten > > rid of all tabs (grmpf) and followed some suggestions by Justin. > > > > I'm reposting the whole file instead of a di

[patch srclib/apr/file_io/unix/filedup.c] broken dup

2001-12-06 Thread Stas Bekman
After dupping the fd, the first read was getting 0 as a first char. Of course other platforms should probably also fixed. Index: srclib/apr/file_io/unix/filedup.c === RCS file: /home/cvspublic/apr/file_io/unix/filedup.c,v retrieving

Re: Pools rewrite [3]

2001-12-06 Thread Brian Pane
Sander Striker wrote: This is the 3rd round of the pools rewrite. This time I have gotten rid of all tabs (grmpf) and followed some suggestions by Justin. I'm reposting the whole file instead of a diff, since this is the first time it is posted inline. Hopefully the interested lot out there have

[STATUS] (apr-util) Wed Dec 5 23:45:15 EST 2001

2001-12-06 Thread Rodent of Unusual Size
APRUTIL LIBRARY STATUS: -*-text-*- Last modified at [$Date: 2001/11/29 10:25:27 $] Release: 2.0a9 : released December 12, 2000 RELEASE SHOWSTOPPERS: * Need apu_compat.h to track the latest renames Status: someone want to step up to diff na

[STATUS] (apr) Wed Dec 5 23:45:09 EST 2001

2001-12-06 Thread Rodent of Unusual Size
APACHE PORTABLE RUNTIME (APR) LIBRARY STATUS: -*-text-*- Last modified at [$Date: 2001/12/05 16:54:23 $] Release: 2.0a9 : released December 12, 2000 2.0a8 : released November 20, 2000 2.0a7 : released October 8, 2000 2.0a6 : released August 18, 2000 2

Re: cvs commit: apr/test testfmt.c

2001-12-06 Thread Cliff Woolley
On 6 Dec 2001 [EMAIL PROTECTED] wrote: >{ > -apr_os_proc_t var; > -memset(&var, 0, sizeof var); > +apr_os_proc_t var = 0; >sprintf(buf, "%" APR_OS_PROC_T_FMT, var); Can you actually assign 0 to an apr_os_proc_t on all platforms (or at least all pl