Re: RESEND: PATCH: Update requested events for a descriptor that is already in a poll set

2004-03-15 Thread Robert Norris
On Mon, Mar 15, 2004 at 10:11:09AM -0800, [EMAIL PROTECTED] wrote: > 1) This patch isn't complete. At the very least we need a patch to the > header > that includes doxygen comments that document this new API. Preferably, a new > patch would also include a patch to testpoll to test this feature

[PATCH]: APR_FROM_OS_ERROR on NetWare

2004-03-15 Thread Jean-Jacques Clar
The attached patch ensure that APR_FROM_OS_ERROR(e) return a consistent value for NetWare. The current macro prevents AB to run on NetWare because we are failing a test in apr_socket_connect():   sockets.c (line 356)     if (connect(sock->socketdes, (const str

Re: testglobalmutex.c

2004-03-15 Thread rbb
Quoting Aaron Bannert <[EMAIL PROTECTED]>: > > On Mar 15, 2004, at 11:30 AM, [EMAIL PROTECTED] wrote: > > Yeah, but rather than add a showstopper, I am just going to fix this > > today. It > > is on my list of things to fix ASAP. > > Part of me wishes we didn't have the lock mechanism in the >

Re: [PROPOSAL] Move APR to the subversion repository

2004-03-15 Thread kfogel
Thom May <[EMAIL PROTECTED]> writes: > > As for timing, I would suggest making APR 1.0 official first, then > > switching over to Subversion shortly after. But, let's please get APR 1.0 > > out the door first. It's overdue enough. =) -- justin +1 on moving to Subversion given a consensus amo

Re: testglobalmutex.c

2004-03-15 Thread Aaron Bannert
On Mar 15, 2004, at 11:30 AM, [EMAIL PROTECTED] wrote: Yeah, but rather than add a showstopper, I am just going to fix this today. It is on my list of things to fix ASAP. Part of me wishes we didn't have the lock mechanism in the main apr_*_mutex_create() functions, so that they could just be ful

Re: testglobalmutex.c

2004-03-15 Thread rbb
Quoting "William A. Rowe, Jr." <[EMAIL PROTECTED]>: > At 12:56 PM 3/15/2004, [EMAIL PROTECTED] wrote: > >Quoting "William A. Rowe, Jr." <[EMAIL PROTECTED]>: > > > >> > >> >rbb 2004/03/15 10:33:30 > >> > > >> > 1.1 apr/test/globalmutexchild.c > >> >... > >> > int main(

Re: testglobalmutex.c

2004-03-15 Thread William A. Rowe, Jr.
At 12:56 PM 3/15/2004, [EMAIL PROTECTED] wrote: >Quoting "William A. Rowe, Jr." <[EMAIL PROTECTED]>: > >> >> >rbb 2004/03/15 10:33:30 >> > >> > 1.1 apr/test/globalmutexchild.c >> >... >> > int main(int argc, const char * const argv[]) >> > { >> > apr_pool_t *p; >

Re: testglobalmutex.c

2004-03-15 Thread Aaron Bannert
On Mar 15, 2004, at 11:15 AM, Aaron Bannert wrote: On Mar 15, 2004, at 10:56 AM, [EMAIL PROTECTED] wrote: Nope. Take a look at the thread that is complaining about the API for global_mutex and proc_mutex. Without that global_mutex_create call, the program segfaults on any Unix machine. This is

Re: testglobalmutex.c

2004-03-15 Thread Aaron Bannert
On Mar 15, 2004, at 10:56 AM, [EMAIL PROTECTED] wrote: Nope. Take a look at the thread that is complaining about the API for global_mutex and proc_mutex. Without that global_mutex_create call, the program segfaults on any Unix machine. This is a bug in the _child_init API, because it should ac

Re: testglobalmutex.c

2004-03-15 Thread rbb
Quoting "William A. Rowe, Jr." <[EMAIL PROTECTED]>: > > >rbb 2004/03/15 10:33:30 > > > > 1.1 apr/test/globalmutexchild.c > >... > > int main(int argc, const char * const argv[]) > > { > > apr_pool_t *p; > > int i = 0; > > apr_global_mutex_t *global_loc

Re: global_lock, how does this work?

2004-03-15 Thread rbb
Quoting [EMAIL PROTECTED]: > Quoting Aaron Bannert <[EMAIL PROTECTED]>: > > > On Mon, Mar 15, 2004 at 09:13:34AM -0800, [EMAIL PROTECTED] wrote: > > > I am trying to port the testgloballock code to the unified framework, > and > > I > > > can't make the child process work. It seems that > > apr_

testglobalmutex.c

2004-03-15 Thread William A. Rowe, Jr.
>rbb 2004/03/15 10:33:30 > > 1.1 apr/test/globalmutexchild.c >... > int main(int argc, const char * const argv[]) > { > apr_pool_t *p; > int i = 0; > apr_global_mutex_t *global_lock; > > apr_initialize(); > atexit(apr_terminate); > >

Re: global_lock, how does this work?

2004-03-15 Thread rbb
Quoting Aaron Bannert <[EMAIL PROTECTED]>: > On Mon, Mar 15, 2004 at 09:13:34AM -0800, [EMAIL PROTECTED] wrote: > > I am trying to port the testgloballock code to the unified framework, and > I > > can't make the child process work. It seems that > apr_global_lock_child_init > > only works if the

Re: RESEND: PATCH: Update requested events for a descriptor that is already in a poll set

2004-03-15 Thread William A. Rowe, Jr.
At 02:15 AM 3/14/2004, Robert Norris wrote: >Attached is a patch that adds a function apr_pollset_update(). This >updates the list of requested events for the descriptor in the >underlying implementation for a descriptor that is already in a pollset. >... >The optimisation that I'd like to do is to

Re: global_lock, how does this work?

2004-03-15 Thread Aaron Bannert
On Mon, Mar 15, 2004 at 09:13:34AM -0800, [EMAIL PROTECTED] wrote: > I am trying to port the testgloballock code to the unified framework, and I > can't make the child process work. It seems that apr_global_lock_child_init > only works if the child process was created using apr_fork. This means t

Re: RESEND: PATCH: Update requested events for a descriptor that is already in a poll set

2004-03-15 Thread rbb
A couple of comments: 1) This patch isn't complete. At the very least we need a patch to the header that includes doxygen comments that document this new API. Preferably, a new patch would also include a patch to testpoll to test this feature. It should also include a stub function in all non-

global_lock, how does this work?

2004-03-15 Thread rbb
I am trying to port the testgloballock code to the unified framework, and I can't make the child process work. It seems that apr_global_lock_child_init only works if the child process was created using apr_fork. This means that the global_lock API can't be used on non-Unix platforms. This same

Re: tagged 0.9.5 pre1

2004-03-15 Thread Cliff Woolley
On Mon, 15 Mar 2004, Geoffrey Young wrote: > if you could take a look at this > http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25550 Noted, thanks!

Re: tagged 0.9.5 pre1

2004-03-15 Thread Geoffrey Young
> Let me know if you have specific things you want to see in 0.9.5 (that are > doable in say a day's time... nothing more than that). if you could take a look at this http://nagoya.apache.org/bugzilla/show_bug.cgi?id=25550 it would be great. there's no diff-generated patch but the change is s

Re: RESEND: PATCH: Update requested events for a descriptor that is already in a poll set

2004-03-15 Thread Bill Stoddard
Robert Norris wrote: Robert, Thanks for resending... No promises but I'll try to review this this week. Please, someone beat me to it. Bill [ I'm resending this, because I didn't get any responses to it the first time. ] Attached is a patch that adds a function apr_pollset_update(). This updates t

Re: PATCH: apr_reslist_invalidate

2004-03-15 Thread rbb
Quoting Nick Kew <[EMAIL PROTECTED]>: > > > > Personally, I dislike using a random number to simulate a failure rate. > > OK so far. Perhaps the fact that my degree was maths and my first job > was in stochastic simulation makes me happier than some with them:-) > > > The > > purpose of the

Re: PATCH: apr_reslist_invalidate

2004-03-15 Thread Nick Kew
> > Personally, I dislike using a random number to simulate a failure rate. OK so far. Perhaps the fact that my degree was maths and my first job was in stochastic simulation makes me happier than some with them:-) > The > purpose of the test suite isn't to emulate the real world where you

Re: PATCH: apr_reslist_invalidate

2004-03-15 Thread rbb
Quoting Nick Kew <[EMAIL PROTECTED]>: > On Mon, 15 Mar 2004, Aaron Bannert wrote: > > > I ended up just committing Nick's patch to testreslist.c. I'm not > > That's a good question. I wasn't at all sure my use of the random > number generation (to simulate a failure rate) would meet APR > porta

Re: PATCH: apr_reslist_invalidate

2004-03-15 Thread rbb
Quoting Aaron Bannert <[EMAIL PROTECTED]>: > On Wed, Mar 10, 2004 at 06:06:16PM -0800, [EMAIL PROTECTED] wrote: > > APR-util needs a full test suite. I will try to put together the > framework > > from > > the APR repository ASAP. probably sometime tomorrow. While I am at it I > will > > start

Re: [PROPOSAL] Move APR to the subversion repository

2004-03-15 Thread Jeff Trawick
related trivia for Solaris users: the folks at www.blastwave.org were kind enough to add ssl support to their subversion package this weekend... previously it was not useful for accessing the test repository

Re: PATCH: apr_reslist_invalidate

2004-03-15 Thread Nick Kew
On Mon, 15 Mar 2004, Aaron Bannert wrote: > I ended up just committing Nick's patch to testreslist.c. I'm not That's a good question. I wasn't at all sure my use of the random number generation (to simulate a failure rate) would meet APR portability criteria. In the absence of an apr_random mod

Re: 1.0 Showstoppers?

2004-03-15 Thread Aaron Bannert
On Thu, Mar 11, 2004 at 11:34:27PM +, Joe Orton wrote: > On Thu, Mar 11, 2004 at 02:18:04PM -0800, Aaron Bannert wrote: > > Are the showstoppers that are listed in the STATUS file the only > > ones we have? (for APR, APR-UTIL, etc...) > [...] > - fixing condition variables on Win32 There is a

Re: PATCH: apr_reslist_invalidate

2004-03-15 Thread Aaron Bannert
On Wed, Mar 10, 2004 at 06:06:16PM -0800, [EMAIL PROTECTED] wrote: > APR-util needs a full test suite. I will try to put together the framework > from > the APR repository ASAP. probably sometime tomorrow. While I am at it I will > start the test suite at the same time. I will be focusing on th

Re: PATCH: apr_reslist_invalidate

2004-03-15 Thread Aaron Bannert
On Mon, Mar 15, 2004 at 03:37:42AM +, Nick Kew wrote: > It's 3 in the morning again, but I've written an updated patch, > This time I've adapted the testsuite to watch it in action and > successfully run it (Linux 2.4.x). As ever, more eyes better:-) Tested and committed. Thanks for the patch

tagged 0.9.5 pre1

2004-03-15 Thread Cliff Woolley
I know it's got a few more patches I need to get in before it's ready to go, but just so that I could go ahead and at least get started on this (using some extended definition of "tomorrow" which technically ended about 24 hrs ago, sigh)... I've tagged apr, apr-util, and apr-iconv as JCW_0_9_5_PRE

Re: PATCH: apr_reslist_invalidate

2004-03-15 Thread Nick Kew
On Sun, 14 Mar 2004, Jeff Trawick wrote: > see comments in PR 26050 about discrepancy in prototypes that seems to show an > underlying issue; apps don't see apr_res_t, so some rework and testing is > needed It's a fair cop guv. The resource is detached when it's issued, so invalidate mustn't ta

Re: Timeout status codes are thoroughly messed up

2004-03-15 Thread Cliff Woolley
On Sun, 14 Mar 2004 [EMAIL PROTECTED] wrote: > This needs to get resolved. I believe the fix is to simply add the correct > checks to APR_STATUS_IS_TIMEUP, but I also would like to know if we really > need > to keep APR_STATUS_IS_ETIMEDOUT at all. Can we mark it deprecated? +1 as far as I'm co

Timeout status codes are thoroughly messed up

2004-03-15 Thread rbb
I have spent the last half hour or so trying to make the socket timeout tests pass on Windows. I couldn't make it happen, so I finally started reading through the code. It turns out that we have a number of error codes that mean that a timeout has expired. On any platform that uses wait_for_io_

Re: [PATCH] fix warnings in test/sockchild.c

2004-03-15 Thread rbb
Committed. Ryan Quoting Garrett Rooney <[EMAIL PROTECTED]>: > > On Mar 14, 2004, at 9:15 PM, [EMAIL PROTECTED] wrote: > > > > > applied and committed. > > > > Thanks, and keep 'em coming. > > Sure thing. Here's two more in testsock.c ;-) > > -garrett > > Index: test/testsock.c > =

Re: [PATCH] fix warnings in test/sockchild.c

2004-03-15 Thread Garrett Rooney
On Mar 14, 2004, at 9:15 PM, [EMAIL PROTECTED] wrote: applied and committed. Thanks, and keep 'em coming. Sure thing. Here's two more in testsock.c ;-) -garrett Index: test/testsock.c === RCS file: /home/cvspublic/apr/test/testsock.c,

Re: [PATCH] fix warnings in test/sockchild.c

2004-03-15 Thread rbb
applied and committed. Thanks, and keep 'em coming. Ryan Quoting Garrett Rooney <[EMAIL PROTECTED]>: > The new sockchild.c file has a few warnings on OS X. > > /bin/sh /Users/rooneg/Hacking/apr/libtool --silent --mode=compile gcc > -g -O2 -DHAVE_CONFIG_H -DDARWIN -DSIGPROCMASK_SETS_THREAD_

Re: [PATCH] fix warnings in test/sockchild.c

2004-03-15 Thread rbb
I'll apply this later tonight. Ever since writing this test, I have been trying to make it work on Windows. Ryan Quoting Garrett Rooney <[EMAIL PROTECTED]>: > The new sockchild.c file has a few warnings on OS X. > > /bin/sh /Users/rooneg/Hacking/apr/libtool --silent --mode=compile gcc > -g -

[PATCH] fix warnings in test/sockchild.c

2004-03-15 Thread Garrett Rooney
The new sockchild.c file has a few warnings on OS X. /bin/sh /Users/rooneg/Hacking/apr/libtool --silent --mode=compile gcc -g -O2 -DHAVE_CONFIG_H -DDARWIN -DSIGPROCMASK_SETS_THREAD_MASK -no-cpp-precomp -I../include -o sockchild.lo -c sockchild.c && touch sockchild.lo sockchild.c: In functio