Re: Wrong definition of APR_OFF_T_FMT in apr.h

2019-03-14 Thread wuzhouhui
> On Mar 15, 2019, at 5:44 AM, William A Rowe Jr wrote: > > Jim, Stefan, wuzhouhui... > > On Wed, Mar 13, 2019 at 3:13 PM Jim Jagielski wrote: > > > > FWIW, I have apr-1.6 here and cannot confirm the below. When compiling w/ > > httpd, DARWIN_10 is defined as required. > > > > > On Mar 3,

Re: Wrong definition of APR_OFF_T_FMT in apr.h

2019-03-14 Thread Jim Jagielski
Yeppers. It's because gcc for Homebrew still sets DARWIN automatically whereas for clang (Xcode), the canon macro is now __APPLE__ I've updated all APR's to be aware of __APPLE__ and, if set, it auto defines DARWIN and DARWIN_10 in apr.h This should fix the issues w/ all compilers. Thx for

Re: Wrong definition of APR_OFF_T_FMT in apr.h

2019-03-14 Thread Jim Jagielski
I think what is going on is that Apple recently changed from using the DARWIN pre-defined macro to the __APPLE__. No doubt, this is causing issues if one doesn't include the right *.h files. Let me address this. > On Mar 14, 2019, at 5:44 PM, William A Rowe Jr wrote: > > Jim, Stefan,

Re: Showstoppers to 1.7.0?

2019-03-14 Thread William A Rowe Jr
On Thu, Mar 14, 2019 at 3:02 PM Yann Ylavic wrote: > On Thu, Mar 14, 2019 at 8:38 PM William A Rowe Jr > wrote: > > > > On Thu, Mar 14, 2019 at 10:49 AM Yann Ylavic > wrote: > >> > >> Possibly to resolve APR__T_FMT on system with > >> [std]int[types].h, we could bind to the standard (C99?)

Re: Wrong definition of APR_OFF_T_FMT in apr.h

2019-03-14 Thread William A Rowe Jr
Jim, Stefan, wuzhouhui... On Wed, Mar 13, 2019 at 3:13 PM Jim Jagielski wrote: > > FWIW, I have apr-1.6 here and cannot confirm the below. When compiling w/ httpd, DARWIN_10 is defined as required. > > > On Mar 3, 2019, at 9:26 AM, wuzhouhui wrote: > > > > ~/Downloads/apr-1.6.5$ gcc -I./include

Re: Showstoppers to 1.7.0?

2019-03-14 Thread William A Rowe Jr
On Thu, Mar 14, 2019 at 3:02 PM Yann Ylavic wrote: > On Thu, Mar 14, 2019 at 8:38 PM William A Rowe Jr > wrote: > > > > On Thu, Mar 14, 2019 at 10:49 AM Yann Ylavic > wrote: > >> > >> Possibly to resolve APR__T_FMT on system with > >> [std]int[types].h, we could bind to the standard (C99?)

Re: Showstoppers to 1.7.0?

2019-03-14 Thread Yann Ylavic
On Thu, Mar 14, 2019 at 8:38 PM William A Rowe Jr wrote: > > On Thu, Mar 14, 2019 at 10:49 AM Yann Ylavic wrote: >> >> Possibly to resolve APR__T_FMT on system with >> [std]int[types].h, we could bind to the standard (C99?) format >> PR[dxo..]N, especially since we configure the format based off

Re: Showstoppers to 1.7.0?

2019-03-14 Thread William A Rowe Jr
On Thu, Mar 14, 2019 at 10:49 AM Yann Ylavic wrote: > Possibly to resolve APR__T_FMT on system with > [std]int[types].h, we could bind to the standard (C99?) format > PR[dxo..]N, especially since we configure the format based off > $ac_cv_sizeof_, so something like: > #define APR__T_FMT

Re: Showstoppers to 1.7.0?

2019-03-14 Thread Yann Ylavic
On Wed, Mar 13, 2019 at 9:33 PM Jim Jagielski wrote: > > Just a FYI that compiling httpd trunk (HEAD) against apr-1.7 (HEAD) and > apu-1.6 (HEAD), I get no error messages about APR_OFF_T_FMT issues, so I'm > not exactly sure where these are coming from for macOS Possibly to resolve APR__T_FMT

Re: Showstoppers to 1.7.0?

2019-03-14 Thread Jim Jagielski
> On Mar 14, 2019, at 9:06 AM, Stefan Sperling wrote: > > On Thu, Mar 14, 2019 at 07:49:41AM -0400, Jim Jagielski wrote: >> I use maintainer-mode all the time... as I said, building httpd does not >> cause any errors due to APR_SSIZE_T_FMT > > Ah, sorry Jim. I misread your message. No

Re: Showstoppers to 1.7.0?

2019-03-14 Thread Stefan Sperling
On Thu, Mar 14, 2019 at 07:49:41AM -0400, Jim Jagielski wrote: > I use maintainer-mode all the time... as I said, building httpd does not > cause any errors due to APR_SSIZE_T_FMT Ah, sorry Jim. I misread your message.

Re: Showstoppers to 1.7.0?

2019-03-14 Thread Jim Jagielski
I use maintainer-mode all the time... as I said, building httpd does not cause any errors due to APR_SSIZE_T_FMT > On Mar 14, 2019, at 2:16 AM, Stefan Sperling wrote: > > On Wed, Mar 13, 2019 at 04:22:46PM -0400, Jim Jagielski wrote: >> Just a FYI that compiling httpd trunk (HEAD) against

Re: Showstoppers to 1.7.0?

2019-03-14 Thread Stefan Sperling
On Wed, Mar 13, 2019 at 04:22:46PM -0400, Jim Jagielski wrote: > Just a FYI that compiling httpd trunk (HEAD) against apr-1.7 (HEAD) and > apu-1.6 (HEAD), I get no error messages about APR_OFF_T_FMT issues, so I'm > not exactly sure where these are coming from for macOS > > % uname -a > Darwin