Re: brigade/bucket insertion macros

2001-02-13 Thread rbb
That allows the snippet above to collapse to this: APR_BRIGADE_INSERT_HEAD(bb, apr_bucket_file_create(fd, 0, r-finfo.size)); APR_BRIGADE_INSERT_TAIL(bb, apr_bucket_eos_create()); AFAICT, the cost is minimal, and the code is much cleaner looking. Since these sequences of bucket

Re: brigade/bucket insertion macros

2001-02-13 Thread rbb
--- [EMAIL PROTECTED] wrote: That allows the snippet above to collapse to this: APR_BRIGADE_INSERT_HEAD(bb, apr_bucket_file_create(fd, 0, r-finfo.size)); APR_BRIGADE_INSERT_TAIL(bb, apr_bucket_eos_create()); AFAICT, the cost is minimal, and the code is much cleaner

RE: brigade/bucket insertion macros

2001-02-13 Thread Cliff Woolley
-Original Message- Or do you mean a full patch to mass-cleanup all callers of the macros throughout Apache? I meant the latter. I can apply what you already sent in about an hour, I need to get to the office soon. All that's left is the rest of the cleanup. :-) Ahh. =-) Well

Re: brigade/bucket insertion macros

2001-02-13 Thread Greg Ames
Cliff Woolley wrote: -Original Message- Ahem. Please don't rush. mass-cleanup can lead to beta delays, without precautions. Clearly. That's why I wasn't sure Ryan was even talking about a mass cleanup when he asked for a full patch. On the other hand, the nice thing about