Re: svn commit: r910597 - /apr/apr/trunk/shmem/unix/shm.c

2010-02-17 Thread Jeff Trawick
On Tuesday, February 16, 2010, Mladen Turk mt...@apache.org wrote: On 02/16/2010 06:07 PM, jfcl...@apache.org wrote: Log: Make sure we don't leak file descriptors.          if (new_m-shmkey == (key_t)-1) { +            apr_file_close(file);              return errno;          } File

Re: svn commit: r910597 - /apr/apr/trunk/shmem/unix/shm.c

2010-02-16 Thread Mladen Turk
On 02/16/2010 06:07 PM, jfcl...@apache.org wrote: Log: Make sure we don't leak file descriptors. if (new_m-shmkey == (key_t)-1) { +apr_file_close(file); return errno; } File will be closed when the pool gets destroyed. Closing here has little