Re: Problems with atomics in 1.7.2

2023-02-27 Thread Stefan Fritsch
Hi Yann, Am 14.02.23 um 14:31 schrieb Yann Ylavic: I think we have several issues here: 1. we should set WEAK_MEMORY_ORDERING for anything but __i386__, __x86_64__, __s390__ and __s390x__ 2. we should not use direct 64bit load/store on 32bit systems for atomic operations 3. on 32bit systems the

Problems with atomics in 1.7.2

2023-02-05 Thread Stefan Fritsch
Hi, there are a number of problems with the atomics in the latest apr release. All the results are on Debian sid(unstable). On powerpc we got a segfault: Thread 1 (Thread 0xf79226a0 (LWP 458077)): #0 0x009dc6d0 in mutex_hash (mem=0xffd5f420) at ./atomic/unix/mutex64.c:79 mutex =

Cleaning up old keys from KEYS?

2015-08-21 Thread Stefan Fritsch
Leggett minf...@sharp.fm imported gpg: key 39FF092C: public key Jeff Trawick (CODE SIGNING KEY) traw...@apache.org imported gpg: key 41CEFDE0: public key Stefan Fritsch s...@sfritsch.de imported $ gpg2 --homedir ring --list-keys ring/pubring.gpg pub 1024D/E005C9CB 2002-08-15 uid

Re: Pool freelist

2014-09-06 Thread Stefan Fritsch
On Thursday 04 September 2014 01:07:49, Branko Čibej wrote: On 03.09.2014 23:15, Stefan Fritsch wrote: On Wednesday 03 September 2014 15:37:17, Jim Jagielski wrote: It's now ~6 years later and so wondering if just bypassing the pool freelist is now viable, at least as a compile-time

Re: Pool freelist

2014-09-03 Thread Stefan Fritsch
On Wednesday 03 September 2014 15:37:17, Jim Jagielski wrote: It's now ~6 years later and so wondering if just bypassing the pool freelist is now viable, at least as a compile-time (or allocator) option. I don't see any reason against a non-default compile-time option. Then people could test

Re: svn commit: r1593614 - in /apr/apr/trunk: CHANGES configure.in memory/unix/apr_pools.c

2014-05-17 Thread Stefan Fritsch
On Thursday 15 May 2014 10:03:25, Ruediger Pluem wrote: +if (old == 2 pool-in_use_by == apr_os_thread_current()) { How can old ever be 2? That was a leftover from a version with a separate state for the pool being cleared. +/* cleanups may use the pool */ +

Re: documentation for module crypto missing

2014-05-16 Thread Stefan Fritsch
49288. [Stefan Fritsch]

Re: digest functions and validation - part 2

2014-05-16 Thread Stefan Fritsch
Am Freitag, 9. Mai 2014, 14:26:26 schrieb Helmut Tessarek: Thanks for the answer. On 09.05.14 3:22 , Stefan Fritsch wrote: No. But which password hashing algorithmis are used/supported by apr_password_validate() is rather unrelated to which digest functions are made available

Re: digest functions and validation - part 2

2014-05-15 Thread Stefan Fritsch
On Mon, 5 May 2014, Helmut Tessarek wrote: I really would like to know, if and why the httpd and apr developers think that md5 and sha1 are safe choices to be used for hashing passwords. No. But which password hashing algorithmis are used/supported by apr_password_validate() is rather

Re: pool owner debugging idea

2014-05-15 Thread Stefan Fritsch
Am Freitag, 2. Mai 2014, 19:39:52 schrieb Branko Čibej: Is there anyway this trylock could be conditional? For example, could we add some sort of flag or whatever that would implement this on specifically created pools? We could do that, but I don't really see a use case. I was

Re: [PATCH] APR pool scalability and efficiency

2014-05-11 Thread Stefan Fritsch
Hi Stefan, On Sunday 11 May 2014 04:23:38, Stefan Fuhrmann wrote: The first and more important one was getting an OOM error because we hit the mmap region count limit on Ubuntu (mmap seems to be enabled in the system libs at least since 12.04 LTS). Using mmap has the advantage that free

Re: [PATCH] APR pool scalability and efficiency

2014-05-11 Thread Stefan Fritsch
On Sunday 11 May 2014 16:07:32, Stefan Fuhrmann wrote: On Sun, May 11, 2014 at 10:28 AM, Stefan Fritsch s...@sfritsch.de wrote: Its root cause was a large data structure (many small allocations) being built up in a single pool. That times multiple threads / concurrent requests

Re: No v1.6.x branch?

2014-05-01 Thread Stefan Fritsch
Am Montag, 21. April 2014, 15:26:59 schrieb Graham Leggett: New features seem rather easy to follow using trunk/CHANGES and-or a diff of the include directories. For finer detail, it is much easier for a person who cares to record revision numbers of desired feature backports in

pool owner debugging idea

2014-05-01 Thread Stefan Fritsch
Hi, it's currently rather hard to debug issues caused by pools being used by different threads. The current pool debugging options don't really work if pool ownership changes during runtime (as int mpm event), require specific apr_pool_owner_set() calls, and apr compiled with pool debugging

Re: pool owner debugging idea

2014-05-01 Thread Stefan Fritsch
would be enabled by some flag to apr_pool_create(). There is PR 51392 requesting that. If you think that would be useful, that could be something for apr 1.6. On May 1, 2014, at 5:16 AM, Stefan Fritsch s...@sfritsch.de wrote: Hi, it's currently rather hard to debug issues caused by pools

Re: apr-util v1.6 branch?

2013-06-09 Thread Stefan Fritsch
On Thursday 06 June 2013, Graham Leggett wrote: On 06 Jun 2013, at 5:24 PM, Jeff Trawick traw...@gmail.com wrote: It makes sense to have it once we have changes that someone wants to release in 1.x but which can't be released in 1.5.x. (I guess you already have such changes in mind so go

Re: [PATCH] unix/sockaddr.c: return error when call_resolver fails and *sa is 0

2013-05-03 Thread Stefan Fritsch
On Thursday 02 May 2013, Jan Kaluža wrote: Attached patch fixes it by returning APR_EGENERAL in this case. Thanks. Committed with small tweaks as http://svn.apache.org/r1478905 trunk http://svn.apache.org/r1478909 1.5 http://svn.apache.org/r1478911 1.4 Cheers, Stefan

Re: 1.4.next next weekend or so?

2013-05-03 Thread Stefan Fritsch
On Sunday 28 April 2013, Rainer Jung wrote: On 26.04.2013 21:18, Jeff Trawick wrote: Some warnings during make check but probably not new: test/testlockperf.c:229:17: warning: variable 'lockname' set but not used test/testmmap.c:122:18: warning: variable 'rv' set but not used

Re: [VOTE] Release APR-util 1.5.2

2013-03-31 Thread Stefan Fritsch
On Saturday 30 March 2013, Jeff Trawick wrote: Tarballs/zipfiles are at http://apr.apache.org/dev/dist/ Shortcuts to CHANGES: http://apr.apache.org/dev/dist/CHANGES-APR-UTIL-1.5.2 http://apr.apache.org/dev/dist/CHANGES-APR-UTIL-1.5 autoconf version: 2.69 (same as 1.5.1) libtool

Re: [VOTE] Release APR-util 1.5.2

2013-03-31 Thread Stefan Fritsch
On Sunday 31 March 2013, Rainer Jung wrote: - testall sometimes fails in testpass on Linux and often fails in testcrypto when testing nss passphrase (see below). Have you any details about the testpass failures? There have been numerous changes and fixes there in 1.5.2, so that would be

Re: [CONCEPT-PATCH] require --enable-unsupported-freetds to support FreeTDS with apr-util 1.5.x

2013-03-30 Thread Stefan Fritsch
On Saturday 30 March 2013, Jeff Trawick wrote: Make sense for post-1.5.2? This doesn't affect non-autoconf builds, and I think the RPM build would be broken. Any other missing pieces? Works for me. I ok with including it post-1.5.2 or in 1.5.2. BTW, if you have time to TR today, go ahead.

Re: time for APU 1.5.2?

2013-03-29 Thread Stefan Fritsch
On Monday 11 March 2013, Jeff Trawick wrote: That sounds like a good idea. I can RM in a few days. Is there anything important missing? AFAICS, the memcached changes proposed by Joshua Marantz add a new field to a public struct and therefore need to wait for 1.6. I could TR tomorrow or on

Re: [PATCH] Reduce apr_[i|l|off_t_]toa memory footprint for common cases

2013-03-28 Thread Stefan Fritsch
On Monday 25 March 2013, Christophe JAILLET wrote: As a first step, I noticed that apr_itoa, apr_ltoa, apr_off_t_toa could be tweaked to require less memory for some common cases. The attached patch reduces memory use for small values, that is to say for strings that fit in 8 bytes

Re: bug 54572 -- move struct crypt_data allocation to heap

2013-03-23 Thread Stefan Fritsch
On Saturday 16 March 2013, Jeff Trawick wrote: This would be good to resolve in 1.5.2. Has anyone else evaluated this? I'm suspicious of the use of a global pool in the reporter's patch vs. just using malloc() directly. I guess the reason for using the pool is that the allocator may have

Re: bug 54572 -- move struct crypt_data allocation to heap

2013-03-23 Thread Stefan Fritsch
On Saturday 23 March 2013, Jeff Trawick wrote: On Sat, Mar 23, 2013 at 12:01 PM, Stefan Fritsch s...@sfritsch.de wrote: On Saturday 16 March 2013, Jeff Trawick wrote: This would be good to resolve in 1.5.2. Has anyone else evaluated this? I'm suspicious of the use of a global pool

Re: bug 54572 -- move struct crypt_data allocation to heap

2013-03-23 Thread Stefan Fritsch
On Sunday 24 March 2013, Eric Covener wrote: Anyone has a system using CRYPTD to test this? AIX anyone? Poked around and CRYPTD stuff doesn't show up in my builds on AIX. HP-UX uses CRYPTD according to google...

Re: apr_proc_detach and chdir

2013-01-24 Thread Stefan Fritsch
On Friday 18 January 2013, Javier Castillo II wrote: Looking into the code for apr_proc_detach(int daemonize), it appears that chdir(/) is being run unconditionally. Was there a specific reason that / is chosen? I guess it's not much of a big deal, because you can chdir into the directory

Re: Question about httpd memory buffer alignment

2013-01-12 Thread Stefan Fritsch
On Friday 11 January 2013, Zhe Zhang wrote: I would like httpd to use 4K-aligned buffers so that I can do direct I/O on the html files being served. Could anyone tell me which file I need to modify? I've already changed APR_BUCKET_BUFF_SIZE to 8192 so at least the buffer size is multiple of

Re: Debian: apu-config and BDB

2012-11-23 Thread Stefan Fritsch
On Thursday 22 November 2012, Ben Reser wrote: Since the change that was made in reaction to this bug report: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=622081 apu-config on Debian has avoided returning the BDB library from --libs. The bug suggests that BDB is related to the DBM

Re: svn commit: r1403239 - in /apr/apr-util/branches/1.3.x: ./ CHANGES buckets/apr_brigade.c

2012-10-29 Thread Stefan Fritsch
On Monday 29 October 2012, rpl...@apache.org wrote: Author: rpluem Date: Mon Oct 29 10:26:10 2012 New Revision: 1403239 URL: http://svn.apache.org/viewvc?rev=1403239view=rev Log: Merge r1402870 from trunk: Remove duplicated logic in apr_brigade_puts(). Thanks for backporting the

Re: [VOTE] Release apr-util 1.5.1

2012-10-03 Thread Stefan Fritsch
Hi, thanks for everyone voting/commenting. While there seem to be some open issues, none are regressions WRT 1.4.1. We have binding +1 votes from minfrin, rjung, covener, sf, plus a non- binding +1. The vote passes. I will proceed with the release real soon now (TM). Cheers, Stefan

Re: [VOTE] Release apr-util 1.5.1

2012-09-12 Thread Stefan Fritsch
On Friday 07 September 2012, Stefan Fritsch wrote: [ ] Release apr-util 1.5.1 as GA +1 (tested on Debian sid)

Re: crypt_r versus macosx

2012-09-07 Thread Stefan Fritsch
On Thursday 06 September 2012, Benson Margulies wrote: I'm trying to build httpd 2.4.3 on OSX Mountain Lion with mod_session_crypto. I'm failing. I think that the reason is the following error from the configure process for apr-util: configure:36291: checking for crypt_r

Re: apr_dbd_freetds

2012-09-07 Thread Stefan Fritsch
On Wednesday 22 August 2012, Graham Leggett wrote: On 22 Aug 2012, at 7:18 PM, Nick Kew wrote: PR 53666 tells us apr_dbd_freetds doesn't work with Sybase, and very probably never did. The reporter attaches a patch, but it's one I'm not happy with, even if I had access to any FreeTDS

Re: apu-util DBD back-ends

2012-09-07 Thread Stefan Fritsch
On Thursday 16 August 2012, olli hauer wrote: My my intention comes from the FreeBSD ports system. We do not use the bundled apr/apr-util from apache, there we use apr / apr-util as own port. (Perhaps with apr-1.4.6 and apr-util-1.5 in a view weeks). This separation allows us to use an

[VOTE] Release apr-util 1.5.1

2012-09-07 Thread Stefan Fritsch
Hi, here comes the next try. Tarballs/zipfiles are at http://apr.apache.org/dev/dist/ Full CHANGES are here: http://apr.apache.org/dev/dist/CHANGES-APR-UTIL-1.5 http://apr.apache.org/dev/dist/CHANGES-APR-UTIL-1.5.1 +/-1 [ ] Release apr-util 1.5.1 as GA

Re: [VOTE] Release apr-util 1.5.0

2012-09-04 Thread Stefan Fritsch
On Wednesday 08 August 2012, Gregg Smith wrote: 1 warning crypt_blowfish.c .\crypto\crypt_blowfish.c(894) : warning C4244: '=' : conversion from 'unsigned long' to 'char', possible loss of data That's a false positive. count can only be between 4 and 31 at this point. IMHO the compiler

releasing 1.5.1 (was: [VOTE] Release apr-util 1.5.0)

2012-09-04 Thread Stefan Fritsch
On Wednesday 22 August 2012, William A. Rowe Jr. wrote: The code exists already in a licensable form as part of the spec, I believe. http://tools.ietf.org/html/rfc3492#appendix-C This can be made more usable with pools, etc with a pretty trivial effort. Before I start, though, From my

Re: [VOTE] Release apr-util 1.5.0

2012-08-10 Thread Stefan Fritsch
Thanks for the detailed tests. On Friday 10 August 2012, Rainer Jung wrote: If you don't need to release before, I would like to fix the LDADD use over the weekend, but it is not a show stopper. It seems I will be busy in the next few days. It is unlikely that I TR 1.5.1 before next

Re: [VOTE] Release apr-util 1.5.0

2012-08-07 Thread Stefan Fritsch
On Tuesday 07 August 2012, Eric Covener wrote: On Mon, Aug 6, 2012 at 4:24 PM, Stefan Fritsch s...@sfritsch.de wrote: Hi, Tarballs/zipfiles are at http://apr.apache.org/dev/dist/ It includes many bug fixes and new built-in bcrypt support. Full CHANGES are here: http

Re: [VOTE] Release apr-util 1.5.0

2012-08-07 Thread Stefan Fritsch
On Tuesday 07 August 2012, Jeff Trawick wrote: But if somebody else with a platform that is not Linux, AIX, Netware, or Windows wants to do some testing first, that would be appreciated. Maybe Solaris or FreeBSD, anyone? BTW, did anyone test on Windows yet? Gregg and Steffen have

[VOTE] Release apr-util 1.5.0

2012-08-06 Thread Stefan Fritsch
Hi, Tarballs/zipfiles are at http://apr.apache.org/dev/dist/ It includes many bug fixes and new built-in bcrypt support. Full CHANGES are here: http://apr.apache.org/dev/dist/CHANGES-APR-UTIL-1.5 +/-1 [ ] Release apr-util 1.5.0 as GA

apr-util 1.5 on Windows and Netware?

2012-08-05 Thread Stefan Fritsch
Hi, has anyone tried to compile apr-util 1.5 on Windows or Netware in the last two weeks? I intend to TR as soon as I get positive feed-back, or in a few days if there is no response. Cheers, Stefan

apr-util 1.5 ?

2012-07-18 Thread Stefan Fritsch
Hi, I would like to get apr-util 1.5 out soonish. It adds bcrypt support for password hashes. If anyone wants to add something else, go ahead and commit. Cheers, Stefan

Re: Choosing a stronger password hash algorithm

2012-07-02 Thread Stefan Fritsch
On Sunday 01 July 2012, William A. Rowe Jr. wrote: On 6/29/2012 4:23 AM, Stefan Fritsch wrote: Therefore I will go ahead and add bcrypt support to apr-util which will be a big improvement for the 95% of users who don't need FIPS. It sounds to me that after we spent a great deal of time

Re: Choosing a stronger password hash algorithm

2012-07-02 Thread Stefan Fritsch
On Monday 02 July 2012, Ben Laurie wrote: FWIW, I am not super-keen on this particular move. Whilst bcrypt is certainly an improvement, I am wary of relying on Blowfish - it is not a mainstream cipher and is not subject to the kind of scrutiny that, say, AES or SHA-2/3 are. If we are going

Re: Choosing a stronger password hash algorithm

2012-06-29 Thread Stefan Fritsch
On Tuesday 26 June 2012, William A. Rowe Jr. wrote: On 6/24/2012 3:34 AM, Stefan Fritsch wrote: On Sunday 24 June 2012, Graham Leggett wrote: Ideally, like we have a generic synchronous encryption API, we should have a generic hash API too, so that the user can use whatever hash

Re: Choosing a stronger password hash algorithm

2012-06-24 Thread Stefan Fritsch
On Sunday 24 June 2012, Graham Leggett wrote: On 24 Jun 2012, at 12:01 AM, Stefan Fritsch wrote: Openssl is not required, neither for apr nor for httpd. I propose to import either crypt_blowfish or scrypt into apr, just like apr contains some foreign sha1 and md5 code. This way we would

Choosing a stronger password hash algorithm

2012-06-23 Thread Stefan Fritsch
On Thursday 21 June 2012, Ben Laurie wrote: Then the question is: what scheme? Here are some design criteria I think would be useful. 1. Use something from the SHA-2 family - SHA-512 would seem fine to me. The sha message digests are designed to be fast and to be easily implemented in

Re: Choosing a stronger password hash algorithm

2012-06-23 Thread Stefan Fritsch
On Saturday 23 June 2012, William A. Rowe Jr. wrote: On 6/23/2012 3:42 PM, Stefan Fritsch wrote: bcrypt [1] and scrypt [2] seem to be much more difficult to port to hardware or GPUs than sha256/512_crypt [3-5]. We can't make the operation too expensive on normal CPUs or we create a DoS

Re: svn commit: r1308135 - in /apr/apr-util/branches/1.4.x: ./ CHANGES crypto/apr_crypto.c

2012-04-09 Thread Stefan Fritsch
On Sunday 08 April 2012, William A. Rowe Jr. wrote: On 4/4/2012 5:09 PM, Graham Leggett wrote: This type of comment embarrasses both the project and the ASF. If you want to discuss an issue, please discuss the issue. As soon as emails start getting abusive, EOT. Graham Leggett, The

Re: backports/merges

2012-04-09 Thread Stefan Fritsch
On Monday 09 April 2012, Rainer Jung wrote: Do you disagree with the procedure and/or my attempt to describe the normal way this is handled? No, I agree and I think it is more useful to include the CHANGES entry in the backport commit than to split it in a second commit. At least that's

Re: modes of discussion

2012-04-09 Thread Stefan Fritsch
On Sunday 08 April 2012, Jeff Trawick wrote: Some of the behavior here is embarrassing. Yelling about not following procedures that nobody else even follows as stated, threatening, whining, crudity or at least making fun of objections to crudity, extreme defensiveness, etc. do not reflect

Re: [VOTE] Release apr-util 1.4.2

2012-04-09 Thread Stefan Fritsch
On Monday 02 April 2012, Graham Leggett wrote: On 01 Apr 2012, at 11:06 PM, Stefan Fritsch wrote: Sorry for being late, but -1 Works fine if linked dynamically with DSOs. But for the static build, httpd segfaults in mod_ssl (backtrace at the bottom of the mail). Since 1.4.1

Re: [VOTE] Release apr-util 1.4.2

2012-04-01 Thread Stefan Fritsch
On Sunday 25 March 2012, Graham Leggett wrote: Fixed in apr-util is the static build of the apr_crypto interface. Full CHANGES are here: https://svn.apache.org/repos/asf/apr/apr-util/tags/1.4.2/CHANGES +/-1 [ ] Release apr-util 1.4.2 as GA Sorry for being late, but -1 Works fine if

Re: Using autoconf/automake/libtool

2012-03-16 Thread Stefan Fritsch
On Friday 16 March 2012, Graham Leggett wrote: Automake may not have done the trick in 2002, but it's now 2012, and I think it's fair that we looked at this again. FWIW, my last experiences with automake were about 2 years ago and I agree with Greg that it's extremely painful as soon as you

Re: svn commit: r1240475 - in /apr/apr/branches/1.4.x: ./ include/apr_errno.h

2012-02-04 Thread Stefan Fritsch
On Saturday 04 February 2012, Graham Leggett wrote: On 04 Feb 2012, at 11:47 AM, s...@apache.org wrote: URL: http://svn.apache.org/viewvc?rev=1240475view=rev Log: Reserve a range of USERERR values for HTTPD --- apr/apr/branches/1.4.x/include/apr_errno.h (original) +++

Re: svn commit: r1240475 - in /apr/apr/branches/1.4.x: ./ include/apr_errno.h

2012-02-04 Thread Stefan Fritsch
On Saturday 04 February 2012, William A. Rowe Jr. wrote: Read the full comment in the file (the diff context is too small). There is a huge range of error codes reserved for the application. Out of this range, subversion already had some ranges reserved. Now HTTPD has some other range

Re: Win32 apr-util's crypto, cprypto_nss and crypto_openssl now works

2011-12-07 Thread Stefan Fritsch
On Wed, 7 Dec 2011, Graham Leggett wrote: On 7 Dec 2011, at 08:58, Mladen Turk mt...@apache.org wrote: Fixed the 1.4.x branch win32 crypto API and modules (Mostly by adding missing build files and one API bug) They can now compile using Mozilla's xulrunner SDK and any OpenSSSL SDK. We could

Re: Win32 apr-util's crypto, cprypto_nss and crypto_openssl now works

2011-12-07 Thread Stefan Fritsch
On Wednesday 07 December 2011, Graham Leggett wrote: On 7 Dec 2011, at 13:54, Stefan Fritsch s...@sfritsch.de wrote: I've got a report that apr-util/ldap 1.3.12 does not build on Debian unstable currently, presumably due to toolchain changes. If you wait another 6 hours or so, I could check

Re: svn commit: r1207680 - in /apr/apr/trunk: crypto/apr_crypto_nss.c dbd/apr_dbd_sqlite3.c dbm/apr_dbm_sdbm.c test/testreslist.c util-misc/apr_thread_pool.c

2011-12-01 Thread Stefan Fritsch
On Tuesday 29 November 2011, William A. Rowe Jr. wrote: On 11/28/2011 5:32 PM, William A. Rowe Jr. wrote: On 11/28/2011 5:29 PM, Graham Leggett wrote: On 29 Nov 2011, at 01:21, William A. Rowe Jr. wrote: - rv = apr_sdbm_nextkey(dbm-file,rd); + apr_sdbm_nextkey(dbm-file,rd); pkey-dptr

Re: svn commit: r1204998 - /httpd/httpd/trunk/server/util_expr_eval.c

2011-11-22 Thread Stefan Fritsch
On Tuesday 22 November 2011, j...@apache.org wrote: Author: jim Date: Tue Nov 22 14:02:25 2011 New Revision: 1204998 URL: http://svn.apache.org/viewvc?rev=1204998view=rev Log: Hello. Let's compile again. Modified: httpd/httpd/trunk/server/util_expr_eval.c Modified:

Re: buildbot failure in ASF Buildbot on apr-util-branch-1.4-fbsd

2011-10-16 Thread Stefan Fritsch
On Saturday 15 October 2011, build...@apache.org wrote: The Buildbot has detected a new failure on builder apr-util-branch-1.4-fbsd while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/apr-util-branch-1.4-fbsd/builds/3 Buildbot URL:

Re: Has been APR initialized?

2011-09-20 Thread Stefan Fritsch
On Tuesday 20 September 2011, Antonio Vieiro wrote: Is there any way to know if APR has already been initialized? I'm working on two modules that use APR, and I'd like any of this to initialize/terminate APR in case of need. Just call apr_initialize/apr_terminate in each modules. Only the

Re: APR threadpool and memory pool weirdness

2011-07-27 Thread Stefan Fritsch
On Wednesday 27 July 2011, Cosmin Luță wrote: I have a rather strange use case for APR which leads to quick memory increase on Linux (at least): a program creates (in a loop) memory pools which are passed to tasks in a threadpool. Each task will call apr_pool_destroy on its pool (received as

Re: testreslist failures / thread-safety issues

2011-05-24 Thread Stefan Fritsch
On Sunday 22 May 2011, Jeff Trawick wrote: Can those people who frequently hit the testreslist failures please check if this commit helps? From a powerpc Debian build host, it looks promising, but I don't have direct access to that machine and can't do repeated tests there. no luck on

Re: testreslist failures / thread-safety issues

2011-05-23 Thread Stefan Fritsch
On Sunday 22 May 2011, Jeff Trawick wrote: Can those people who frequently hit the testreslist failures please check if this commit helps? From a powerpc Debian build host, it looks promising, but I don't have direct access to that machine and can't do repeated tests there. no luck on

testreslist failures / thread-safety issues

2011-05-22 Thread Stefan Fritsch
On Sunday 22 May 2011, s...@apache.org wrote: Author: sf Date: Sun May 22 20:10:42 2011 New Revision: 1126207 URL: http://svn.apache.org/viewvc?rev=1126207view=rev Log: Fix thread unsafe pool usage. This is a potential culprit for the occasional testreslist failures. Can those people who

Adding gcc attributes to function declarations

2011-05-15 Thread Stefan Fritsch
Hi, I think it would be a good idea to add some more gcc attribute annotations to our header to mark parameters that must not be NULL, etc. We already have some of these for format string. In order to not break other compilers, I thought to just include #if !defined(__GNUC__) #define

Re: Adding gcc attributes to function declarations

2011-05-15 Thread Stefan Fritsch
On Sun, 15 May 2011, Stefan Fritsch wrote: I think it would be a good idea to add some more gcc attribute annotations to our header to mark parameters that must not be NULL, etc. We already have some of these for format string. In order to not break other compilers, I thought to just include

Re: [Vote] Release apr-util 1.3.11

2011-04-27 Thread Stefan Fritsch
On Tuesday 26 April 2011, Rainer Jung wrote: +1 although there are still two problems on Solaris 10 for test_reslist, but not a regression. I built and made check on the following platforms: - Solaris 8 + 10, Sparc - SuSE Linux Enterprise 10 32 and 64 Bit - RedHat Enterprise Linux 5, 64

Re: Discuss; reset to apr-util 1.5.0-dev?

2011-04-19 Thread Stefan Fritsch
On Friday 15 April 2011, William A. Rowe Jr. wrote: On 4/15/2011 6:36 AM, Jeff Trawick wrote: On Thu, Apr 14, 2011 at 9:51 PM, William A. Rowe Jr. wr...@rowe-clan.net wrote: In order to disambiguate what was released by external entities from what the ASF APR Project has voted upon and

Re: [Vote] Release apr-util 1.3.11

2011-04-19 Thread Stefan Fritsch
[ +1 ] Release apr-util 1.3.11 as GA Compiles and tests ok on Debian Linux unstable/x86

Re: svn commit: r1083599 - in /apr/apr/branches/1.4.x: ./ CHANGES configure.in memory/unix/apr_pools.c

2011-03-21 Thread Stefan Fritsch
On Monday 21 March 2011, Jeff Trawick wrote: This last ,\n[] causes a shell script error for me on MinGW using autoconf 2.67 and bash 3.1. Perhaps it is a system problem (no issues for me in my normal env), but the argument is not in apr trunk and I can't fathom why an empty

APR_RING aliasing problem / segfaults with gcc 4.5

2011-02-22 Thread Stefan Fritsch
Hi, there is still the strict aliasing problem with the APR_RING macros which causes httpd to segfault with gcc 4.5 [1,2]. Has anyone found a better solution to that than marking the ring head elements volatile? A similar change has already been made for the ring entry elements in r566349.

Re: svn commit: r1072937 - /apr/apr/trunk/include/apr_hooks.h

2011-02-21 Thread Stefan Fritsch
On Monday 21 February 2011, traw...@apache.org wrote: Author: trawick Date: Mon Feb 21 12:07:33 2011 New Revision: 1072937 URL: http://svn.apache.org/viewvc?rev=1072937view=rev Log: add hook function args to the hook probe invocations Modified: apr/apr/trunk/include/apr_hooks.h

Re: [PATCH] apr_file_flush_locked and short writes

2011-02-21 Thread Stefan Fritsch
On Monday 21 February 2011, Bert Huijben wrote: Beyond this, there's no a mechanism to report that all the buffered data didn't get into the file. Perhaps apr_file_flush() should loop until the entire buffer is written or it gets a non-EINTR error? Commited the looping solution as

Re: reducing memory fragmentation

2011-02-20 Thread Stefan Fritsch
On Sunday 20 February 2011, Jim Jagielski wrote: On Feb 19, 2011, at 2:57 PM, Stefan Fritsch wrote: I am sure that apr_allocator with mmap is not an advantage on all platforms. Actually, apr allocating only multiples of 4k should make it easier for malloc to avoid fragmentation. But glibc's

Re: reducing memory fragmentation

2011-02-19 Thread Stefan Fritsch
On Saturday 19 February 2011, Greg Stein wrote: On Fri, Feb 18, 2011 at 16:55, Stefan Fritsch s...@sfritsch.de wrote: On Thursday 17 February 2011, Jim Jagielski wrote: Please also look at Greg's pocore memory allocation stuff... his hash stuff is also quite nice. Would be useful

Re: reducing memory fragmentation

2011-02-18 Thread Stefan Fritsch
On Thursday 17 February 2011, Jim Jagielski wrote: Please also look at Greg's pocore memory allocation stuff... his hash stuff is also quite nice. Would be useful to be able to use that as well That looks like a much bigger change than what I have just commited. But I agree that before

reducing memory fragmentation

2011-02-06 Thread Stefan Fritsch
On Friday 04 February 2011, William A. Rowe Jr. wrote: My thought is that this might not be the only thing to 'refresh' when you have an app which needs current state. It would be a chance to flush out all caches and set the state basically to apr_initialize(), modulo any open resources

Re: [VOTE] Release apr-util-0.9.19 as GA

2010-10-16 Thread Stefan Fritsch
On Tuesday 12 October 2010, Jeff Trawick wrote: [+1] Release apr-util 0.9.19 as GA Tested on Debian unstable/x86 with builtin expat

Re: [vote] Release apr-util 1.3.10

2010-10-02 Thread Stefan Fritsch
On Fri, 1 Oct 2010, Jeff Trawick wrote: Tarballs are at http://apr.apache.org/dev/dist/. Windows packages are not yet available. Due to the inclusion of a fix for a potential DOS that could affect some library consumers, I hope to get enough feedback within 24 hours to release. +/-1 [+1]

Re: scan-build on apr/trunk

2010-07-31 Thread Stefan Fritsch
On Saturday 31 July 2010, Philip M. Gollucci wrote: http://p6m7g8.net/~pgollucci/sb/ I might take a stab at some of these next week. $ ./buildconf $ scan-build ./configure $ scan-build make -j12 One more issue found by gcc: Error handling in apr_memcache.c is broken:

Re: svn commit: r979891 - in /apr/apr/trunk: build/ dbd/ dbm/ file_io/netware/ file_io/os2/ file_io/unix/ file_io/win32/ memory/unix/ threadproc/beos/ threadproc/unix/

2010-07-28 Thread Stefan Fritsch
On Wed, 28 Jul 2010, Ruediger Pluem wrote: On 07/28/2010 12:09 AM, s...@apache.org wrote: Author: sf Date: Tue Jul 27 22:09:45 2010 New Revision: 979891 Modified: apr/apr/trunk/dbm/apr_dbm_sdbm.c URL:

Re: Change FILE/... buckets to close file descriptor on destruction?

2010-06-19 Thread Stefan Fritsch
On Monday 14 June 2010, Stefan Fritsch wrote: [ ] change FILE/PIPE/SOCKET bucket in APR to close file descriptor when the last referencing bucket is destroyed [ ] same as above, but only if a new flag is set (like flag for mmap) [ ] don't change APR, work around problem in httpd

Re: Change FILE/... buckets to close file descriptor on destruction?

2010-06-14 Thread Stefan Fritsch
On Tuesday 18 May 2010, Stefan Fritsch wrote: On Tuesday 18 May 2010, Joe Orton wrote: On Tue, May 18, 2010 at 09:18:23AM +0200, Stefan Fritsch wrote: On Tue, 18 May 2010, Ruediger Pluem wrote: So if you want to close this fd you IMHO would need to do some refcounting and only close

Re: File descriptor leak with mpm-event / apr file bucket cleanup

2010-05-18 Thread Stefan Fritsch
On Tue, 18 May 2010, Ruediger Pluem wrote: --- buckets/apr_buckets_file.c.dist +0200 +++ buckets/apr_buckets_file.c @@ -34,8 +34,7 @@ apr_bucket_file *f = data; if (apr_bucket_shared_destroy(f)) { -/* no need to close the file here; it will get - * done automatically

Re: File descriptor leak with mpm-event / apr file bucket cleanup

2010-05-18 Thread Stefan Fritsch
On Tuesday 18 May 2010, Joe Orton wrote: On Tue, May 18, 2010 at 09:18:23AM +0200, Stefan Fritsch wrote: On Tue, 18 May 2010, Ruediger Pluem wrote: So if you want to close this fd you IMHO would need to do some refcounting and only close it if no other filebucket still references

Re: File descriptor leak with mpm-event / apr file bucket cleanup

2010-05-18 Thread Stefan Fritsch
On Tuesday 18 May 2010, Stefan Fritsch wrote: It does not cause any breakage in the perl-framework. As you suspected, it does break apr-util's testbuckets test. I will look if I can run the subversion test suite, too. I found no breakage in subversion 1.6.11's test suite. Cheers, Stefan

cppcheck fixes

2010-04-05 Thread Stefan Fritsch
Hi, I have tried the cppcheck static code analyzer on apr trunk and it found some errors that may be worth fixing. For some, I have attached a patch. These two I think are false positives/intentional: [./dso/win32/dso.c:133]: (error) Uninitialized variable: rv [./misc/unix/otherchild.c:85]:

Re: Finding memory leaks in httpd and httpd modules

2010-02-17 Thread Stefan Fritsch
On Wednesday 17 February 2010, Joe Orton wrote: On Wed, Feb 17, 2010 at 09:12:03AM -0500, Jeff Trawick wrote: a. get the server to steady state ... b. see what causes the heap to expand (brk/sbrk) This is what I do too, FWIW. It's primitive but usually effective. What about adding

Finding memory leaks in brigade usage

2010-02-17 Thread Stefan Fritsch
On Wednesday 17 February 2010, Jeff Trawick wrote: What about adding some code to apr-util's bucket debugging that logs when destroyed brigades (i.e. where the pool cleanup has been removed) are reused? I think this may be a common cause for memory leaks. as in something like this?

Re: [VOTE] release apr-1.4.2?

2010-02-04 Thread Stefan Fritsch
On Tuesday 26 January 2010, William A. Rowe Jr. wrote: Pushing to the mirrors now. It seems to be on the mirrors by now. Time to update the website?

Re: Quick things, apr/apr-util releases

2009-12-15 Thread Stefan Fritsch
On Tuesday 15 December 2009, William A. Rowe Jr. wrote: Not quite; the scenario that follows is; - user builds/installs apr-util-1.4.1 w/ crypto - user builds/installs crypto-using application The probability that this happens before the user installs httpd-2.3.x-alpha with x 4 and an

Re: DBD mysql driver segfault on cleanup when used together with legacy modules in apache using mysql

2009-10-28 Thread Stefan Fritsch
On Wednesday 28 October 2009, Viktor Griph wrote: There is a possiblility that the mysql library has been unloaded by the DSO loader before the cleanup function that tries to call mysql_thread_end() is called, casusing a segmentation fault. In my particular usecase I've been trying to use a

Re: DBD mysql driver segfault on cleanup when used together with legacy modules in apache using mysql

2009-10-28 Thread Stefan Fritsch
On Wednesday 28 October 2009, Viktor Griph wrote: Not very likely in this case, but it may make sense to check it: You do use libmysqlclient_r.so for both mod_dbd_mysql and mod_auth_mysql? If you use libmysqlclient_r.so for one and libmysqlclient.so for the other, you will get strange

Re: [vote] release apr 1.3.9?

2009-09-22 Thread Stefan Fritsch
Votes open for 48 hours or until we register sufficient +1's for release. Compiles ok with SunCC on Solaris9/Sparc and Solaris10/X86. I get one IPv6 related test failure in testsockets, but that is not a regression (happens with 1.3.8, too) and could be due to the way my test machines are set

Workaround for linux/hppa bug

2009-06-23 Thread Stefan Fritsch
Hi, there is a long standing bug in the Linux/hppa kernel that flock() returns EAGAIN and not EWOULDBLOCK. On all other architectures, these two are defined to be the same. This causes testprocmutex to fail. Cheers, Stefan --- apr-1.3.3~/locks/unix/proc_mutex.c +++

apr_file_dup and FD_CLOEXEC revisited

2009-06-11 Thread Stefan Fritsch
Hi, I finally got around to test the stderr reopening behaviour with the various FD_CLOEXEC bits in trunk. I noticed that this still does not work, i.e. when mod_php exec()s another program, stderr gets closed. The problem is in apr_file_dup2(). It should retain the INHERIT/NOCLEANUP flags of

  1   2   >