Re: [PATCH] a somewhat different approach to the iconv() issue

2001-02-09 Thread Roy T. Fielding
1) The #ifdef APR_ in xlate.c must be a #if Why is that? We generally use #ifdef FOO if FOO is sometimes defined and sometimes not (e.g., APR_ICONV_INBUF_CONST). We generally use #if FOO if FOO is always defined but sometimes to 1 and sometimes to 0 (e.g., APR_HAS_XLATE). Sorry, I

Re: [PATCH] a somewhat different approach to the iconv() issue

2001-02-08 Thread Greg Stein
Awesome. +1 On Wed, Feb 07, 2001 at 07:35:23PM -0500, Jeff Trawick wrote: There are some ideas here previously described by Mo DeJong. Additionally: . there is a way to avoid a warning for a certain platform: set apr_iconv_inbuf_const to 1 in hints.m4 for platforms where the parm is

Re: [PATCH] a somewhat different approach to the iconv() issue

2001-02-08 Thread Roy T. Fielding
. we *know* that versions of glibc 2.2 have const char ** instead of char ** so make that work without any hints.m4 stuff (which would have to look at the glibc version) Why not check for GCC and simply add -Werror to the compile? This should get RedHat 7.0 compiling cleanly, but I

Re: [PATCH] a somewhat different approach to the iconv() issue

2001-02-08 Thread Jeff Trawick
Roy T. Fielding [EMAIL PROTECTED] writes: . we *know* that versions of glibc 2.2 have const char ** instead of char ** so make that work without any hints.m4 stuff (which would have to look at the glibc version) Why not check for GCC and simply add -Werror to the compile?

Re: [PATCH] a somewhat different approach to the iconv() issue

2001-02-08 Thread Sascha Schumann
On 7 Feb 2001, Jeff Trawick wrote: Jeff Trawick [EMAIL PROTECTED] writes: Roy T. Fielding [EMAIL PROTECTED] writes: . we *know* that versions of glibc 2.2 have const char ** instead of char ** so make that work without any hints.m4 stuff (which would have to look at the

Re: [PATCH] a somewhat different approach to the iconv() issue

2001-02-08 Thread Jeff Trawick
Sascha Schumann [EMAIL PROTECTED] writes: On 7 Feb 2001, Jeff Trawick wrote: Jeff Trawick [EMAIL PROTECTED] writes: Roy T. Fielding [EMAIL PROTECTED] writes: . we *know* that versions of glibc 2.2 have const char ** instead of char ** so make that work without any

Re: [PATCH] a somewhat different approach to the iconv() issue

2001-02-08 Thread Roy T. Fielding
well, in practice it isn't so excellent :( the template for AC_TRY_COMPILE() doesn't even compile without warnings int main() { configure:4111: warning: function declaration isn't a prototype So we write our own macro that does compile without warnings. What was checked in doesn't work

Re: [PATCH] a somewhat different approach to the iconv() issue

2001-02-08 Thread Jeff Trawick
Roy T. Fielding [EMAIL PROTECTED] writes: What was checked in doesn't work -- I now get warnings again on my platform, and mine is the one with the correct prototypes. Hmmm... I get no warnings on a system of each flavor (Tru64 and RedHat 6) and got no warnings. What warnings do