On Mon, Mar 29, 2010 at 5:53 PM, Neil Conway n...@cs.berkeley.edu wrote:
On Mon, Mar 29, 2010 at 2:14 PM, Nick Kew n...@apache.org wrote:
I don't see the patch in this post. Is it small/simple/clear enough to
review in a brief-ish session?
Yep, should be very straightforward. Attached are
Ping? This patch addresses a crash that exists in both 1.4.x and
trunk, and is quite straightforward.
Neil
On Thu, Feb 4, 2010 at 8:14 PM, Neil Conway n...@cs.berkeley.edu wrote:
Any feedback on this patch? The bug it addresses exists in both 1.4.x and
trunk.
Neil
On Sat, Jan 16, 2010 at
On 29 Mar 2010, at 18:19, Neil Conway wrote:
Ping? This patch addresses a crash that exists in both 1.4.x and
trunk, and is quite straightforward.
I don't see the patch in this post. Is it small/simple/clear enough to
review in a brief-ish session? A bugzilla entry for it would be something
On Mon, Mar 29, 2010 at 2:14 PM, Nick Kew n...@apache.org wrote:
I don't see the patch in this post. Is it small/simple/clear enough to
review in a brief-ish session?
Yep, should be very straightforward. Attached are two versions of the
patch (one for the 1.4.x branch, one for trunk). The
Any feedback on this patch? The bug it addresses exists in both 1.4.x and trunk.
Neil
On Sat, Jan 16, 2010 at 5:30 PM, Neil Conway n...@cs.berkeley.edu wrote:
Attached is a refreshed version of this patch that applies against
current APR trunk (after the recent pollcb_wakeup() changes). The
Attached is a refreshed version of this patch that applies against
current APR trunk (after the recent pollcb_wakeup() changes). The
patch is now pretty trivial.
Note that if you want to backport this bug fix to the 1.4 branch, the
previous version of the patch should be used. But perhaps the
apr_pollset_wakeup() is buggy when used with APR_POLLSET_NOCOPY,
because create_wakeup_pipe() passes a stack-allocated apr_pollfd_t to
apr_pollset_add(). This is unsafe if the user specified
APR_POLLSET_NOCOPY when creating the pollset.
The attached patch fixes this by adding an apr_pollfd_t for
Attached is a slightly revised version of this patch. Changes:
* Initialize the apr_pool_t field of the apr_pollfd_t we use for the
wakeup pipe. Not clear what this field is actually used for (candidate
for removal in APR2?), but we may as well be tidy.
* Fix a minor bug in one of the versions
