Re: [VOTE] Release Apache Aries Remote Service Admin 1.12.0 (OSGi R7)

2018-05-01 Thread Jean-Baptiste Onofré
Hi Tom, sorry, I'm dealing for a huge e-mail stack just back from my vacation. I mixed some threads ;) Thanks ! Regards JB On 05/01/2018 08:51 AM, Timothy Ward wrote: > JB you are correct that this attempt was failing a lot of rat checks. > Christian fixed and re-staged the release vote in a

Re: [VOTE] Release Apache Aries Remote Service Admin 1.12.0 (OSGi R7)

2018-05-01 Thread Christian Schneider
Canceling this release. See take 2 for the fixed version. Christian 2018-04-27 10:31 GMT+02:00 Christian Schneider : > This release of Aries RSA is the reference implementation of Remote > Services and Remote Service Admin from the OSGi R7 spec. It was tested > against

Re: [VOTE] Release Apache Aries Remote Service Admin 1.12.0 (OSGi R7)

2018-05-01 Thread Timothy Ward
JB you are correct that this attempt was failing a lot of rat checks. Christian fixed and re-staged the release vote in a second thread. I see that you’ve voted on that one already. Tim Sent from my iPhone > On 1 May 2018, at 06:30, Jean-Baptiste Onofré wrote: > > -1

Re: [VOTE] Release Apache Aries Remote Service Admin 1.12.0 (OSGi R7)

2018-04-30 Thread Jean-Baptiste Onofré
-1 (binding) It seems a lot of files doesn't have ASF header. Can you please take a look ? Regards JB On 04/27/2018 10:31 AM, Christian Schneider wrote: > This release of Aries RSA is the reference implementation of Remote > Services and Remote Service Admin from the OSGi R7 spec. It was tested

Re: [VOTE] Release Apache Aries Remote Service Admin 1.12.0 (OSGi R7) take 2

2018-04-30 Thread Jean-Baptiste Onofré
+1 (binding) Regards JB On 04/30/2018 02:46 PM, Christian Schneider wrote: > I added the missing license headers and made sure rat runs on all builds. > --- > > This release of Aries RSA is the reference implementation of Remote > Services and Remote Service Admin from the OSGi R7 spec. It was

Re: [VOTE] Release Apache Aries Remote Service Admin 1.12.0 (OSGi R7) take 2

2018-04-30 Thread David Bosschaert
+1 David On 30 April 2018 at 13:46, Christian Schneider wrote: > I added the missing license headers and made sure rat runs on all builds. > --- > > This release of Aries RSA is the reference implementation of Remote > Services and Remote Service Admin from the OSGi R7

Re: [VOTE] Release Apache Aries Remote Service Admin 1.12.0 (OSGi R7) take 2

2018-04-30 Thread Raymond Auge
+1 (non-binding) - Ray On Mon, Apr 30, 2018 at 10:56 AM, Timothy Ward wrote: > +1 > > > On 30 Apr 2018, at 13:46, Christian Schneider > wrote: > > > > I added the missing license headers and made sure rat runs on all builds. > > --- > > > >

Re: [VOTE] Release Apache Aries Remote Service Admin 1.12.0 (OSGi R7) take 2

2018-04-30 Thread Timothy Ward
+1 > On 30 Apr 2018, at 13:46, Christian Schneider wrote: > > I added the missing license headers and made sure rat runs on all builds. > --- > > This release of Aries RSA is the reference implementation of Remote > Services and Remote Service Admin from the OSGi R7

Re: [VOTE] Release Apache Aries Remote Service Admin 1.12.0 (OSGi R7)

2018-04-30 Thread Timothy Ward
I think that the bnd files need headers too. They include non-trivial information describing how the bundles should be packaged. The files are just properties files so they support comments. For example https://github.com/apache/aries-jpa/blob/master/jpa-container/osgi.bnd#L1-L16 Tim On 29

Re: [VOTE] Release Apache Aries Remote Service Admin 1.12.0 (OSGi R7)

2018-04-29 Thread Christian Schneider
I did not specifically run rat tests. To be honest I thought they were part of the apache parent so I did not check. I added rat checks to the build on master now and fixed the reported files. Can you review this? Christian 2018-04-29 11:56 GMT+02:00 Timothy Ward : >

Re: [VOTE] Release Apache Aries Remote Service Admin 1.12.0 (OSGi R7)

2018-04-29 Thread Timothy Ward
Hi Christian, Did you run RAT checks on this before you staged it? I am seeing the following, which includes a lot of source files with no license headers. All the pom files, bnd files, xsd files, and definitely the .java files should have ASL v2 headers. Some of these are long-standing files,

Re: [VOTE] Release Apache Aries Remote Service Admin 1.12.0 (OSGi R7)

2018-04-27 Thread David Bosschaert
+1 David On 27 April 2018 at 09:31, Christian Schneider wrote: > This release of Aries RSA is the reference implementation of Remote > Services and Remote Service Admin from the OSGi R7 spec. It was tested > against the TCK and passes all tests. > > See here for the

Re: [VOTE] Release Apache Aries Remote Service Admin 1.12.0 (OSGi R7)

2018-04-27 Thread Raymond Auge
+1 (non binding) - Ray On Fri, Apr 27, 2018, 04:31 Christian Schneider, wrote: > This release of Aries RSA is the reference implementation of Remote > Services and Remote Service Admin from the OSGi R7 spec. It was tested > against the TCK and passes all tests. > > See