I also have a small preference for underscores but would also be fine with
dashes.
It seems to be more common (therefore blends better with vendored code) and
agrees with the styleguide and is closest to the exiting code. Also as an
aside, having file_names names like variable_names is nice.
I also have a preference for underscore but can get used to anything.
I agree with the points François made above about the recommendation of the
style guide and the smaller change to the existing code base.
On Tue, Aug 6, 2019 at 6:52 PM Francois Saint-Jacques <
fsaintjacq...@gmail.com> wrote:
Liya Fan created ARROW-6155:
---
Summary: [Java] Extract a super interface for vectors whose
elements reside in continuous memory segments
Key: ARROW-6155
URL: https://issues.apache.org/jira/browse/ARROW-6155
My vote would go with underscore to minimize changes and minimize
exceptions to the google style guide reference. I also suggests that
we add this to the linters somehow, if it's not too much trouble.
François
On Tue, Aug 6, 2019 at 9:35 PM Sutou Kouhei wrote:
>
> Hi,
>
> I like hyphens.
>
>
Hi,
I like hyphens.
Because many Linux commands use hyphens than
underscores. Here are counts on my Debian GNU/Linux machine:
% ls /usr/bin/ | grep -- - | wc -l
956
% ls /usr/bin/ | grep _ | wc -l
343
Thanks,
--
kou
In <20190806140340.2a7ffab2@fsol>
"[Discuss] C++ filenames: hyphens or
Yesh created ARROW-6154:
---
Summary: Too many open files (os error 24)
Key: ARROW-6154
URL: https://issues.apache.org/jira/browse/ARROW-6154
Project: Apache Arrow
Issue Type: Bug
Components:
Neal Richardson created ARROW-6153:
--
Summary: [R] Address parquet deprecation warning
Key: ARROW-6153
URL: https://issues.apache.org/jira/browse/ARROW-6153
Project: Apache Arrow
Issue Type:
I note that a change from underscores to hyphens would significantly
affect the Parquet, Plasma, and Gandiva libraries so I think we need
to hear from other developers of those subprojects. Underscores are
definitely less disruptive to the status quo
On Tue, Aug 6, 2019 at 4:18 PM Wes McKinney
Wes McKinney created ARROW-6152:
---
Summary: [C++][Parquet] Write arrow::Array directly into
parquet::TypedColumnWriter
Key: ARROW-6152
URL: https://issues.apache.org/jira/browse/ARROW-6152
Project:
I have a slight gut preference for underscores but I am OK with
changing everything to hyphens. The hyphens will probably grow on me
as it means pressing the "shift" key less frequently. Is there any
technical argument for using one over the other? My understanding is
that `git blame` is pretty
Wes McKinney created ARROW-6151:
---
Summary: [R] See if possible to generate r/inst/NOTICE.txt rather
than duplicate information
Key: ARROW-6151
URL: https://issues.apache.org/jira/browse/ARROW-6151
hi all,
As we've been discussing for the last 5 weeks or so [1], there is a
need to introduce 4 bytes of padding into the preamble of the
"encapsulated IPC message" format to ensure that the Flatbuffers
metadata payload begins on an 8-byte aligned memory offset. The
alternative to this would be
Saurabh Bajaj created ARROW-6150:
Summary: Intermittent Pyarrow HDFS IO error
Key: ARROW-6150
URL: https://issues.apache.org/jira/browse/ARROW-6150
Project: Apache Arrow
Issue Type: Bug
Hi all,
Reminder that the biweekly Arrow call is tomorrow at
https://meet.google.com/vtm-teks-phx. All are welcome to join. Notes
will be sent out to the mailing list afterwards.
Neal
Philip Felton created ARROW-6149:
Summary: [Parquet] Decimal comparisons used for min/max statistics
are not correct
Key: ARROW-6149
URL: https://issues.apache.org/jira/browse/ARROW-6149
Project:
Francois Saint-Jacques created ARROW-6148:
-
Summary: Missing debian build dependencies
Key: ARROW-6148
URL: https://issues.apache.org/jira/browse/ARROW-6148
Project: Apache Arrow
Sebastien Binet created ARROW-6147:
--
Summary: [Go] implement a Flight client
Key: ARROW-6147
URL: https://issues.apache.org/jira/browse/ARROW-6147
Project: Apache Arrow
Issue Type: New
Sebastien Binet created ARROW-6146:
--
Summary: [Go] implement a Plasma client
Key: ARROW-6146
URL: https://issues.apache.org/jira/browse/ARROW-6146
Project: Apache Arrow
Issue Type: New
Hello,
The filenames in the C++ source tree are a bit ad hoc and inconsistent.
Sometimes they use hyphens for word separation, sometimes underscores.
In ARROW-4648 it was proposed that we unify C++ file naming, therefore
there are two possible options: only hyphens, or only underscores.
What
Ji Liu created ARROW-6145:
-
Summary: [Java] UnionVector created by MinorType#getNewVector
could not keep field type info properly
Key: ARROW-6145
URL: https://issues.apache.org/jira/browse/ARROW-6145
Prudhvi Porandla created ARROW-6144:
---
Summary: Implement random function in Gandiva
Key: ARROW-6144
URL: https://issues.apache.org/jira/browse/ARROW-6144
Project: Apache Arrow
Issue Type:
Hi Micah,
Thanks a lot for doing this.
I am a little concerned about if there is any negative performance impact
on the current 32-bit-length based applications.
Can we do some performance comparison on our existing benchmarks?
Best,
Liya Fan
On Tue, Aug 6, 2019 at 3:35 PM Micah Kornfield
There have been some previous discussions on the mailing about supporting
64-bit lengths for Java ValueVectors (this is what the IPC specification
and C++ support). I created a PR [1] that changes all APIs that I could
find that take an index to take an "long" instead of an "int" (and
similarly
23 matches
Mail list logo
