Re: [VOTE] Release Apache Arrow 12.0.0 - RC0

2023-04-26 Thread Jacob Wujciak
I was able to build with USE_CONDA=1 but that produced a long list of test failures, which seems concerning? 17 - arrow-compute-internals-test (Failed) 18 - arrow-compute-expression-test (Failed) 19 - arrow-compute-scalar-cast-test (Failed) 20 -

Re: [VOTE] Formalize how to change format

2023-04-26 Thread Will Jones
+1. Thanks Kou. On Wed, Apr 26, 2023 at 10:27 AM Matt Topol wrote: > +1 (Non-binding) > > On Wed, Apr 26, 2023 at 5:16 AM Joris Van den Bossche < > jorisvandenboss...@gmail.com> wrote: > > > +1 > > > > On Wed, 26 Apr 2023 at 04:18, Sutou Kouhei wrote: > > > > > > Hi, > > > > > > I've added one

Re: [VOTE] Formalize how to change format

2023-04-26 Thread Matt Topol
+1 (Non-binding) On Wed, Apr 26, 2023 at 5:16 AM Joris Van den Bossche < jorisvandenboss...@gmail.com> wrote: > +1 > > On Wed, 26 Apr 2023 at 04:18, Sutou Kouhei wrote: > > > > Hi, > > > > I've added one more note about documentation: > > > > We must update the corresponding documentation

Re: [DISCUSS][Format] Starting the draft implementation of the ArrayView array format

2023-04-26 Thread Micah Kornfield
Small bikeshed: But to keep naming consistent "ViewList"? On Wed, Apr 26, 2023 at 8:02 AM Weston Pace wrote: > > My understanding is that the primary benefit of this ListView layout > > over Arrow's existing List layouts [1] is that ListView allows for > > buffer alignment [2] without padding,

Re: [DISCUSS][Format] Starting the draft implementation of the ArrayView array format

2023-04-26 Thread Weston Pace
> My understanding is that the primary benefit of this ListView layout > over Arrow's existing List layouts [1] is that ListView allows for > buffer alignment [2] without padding, which makes vectorized > processing much more efficient. Is this understanding correct? Yes. Though proponents of

Re: [DISCUSS][Format] Starting the draft implementation of the ArrayView array format

2023-04-26 Thread Felipe Oliveira Carvalho
After Weston's suggestion above, I've renamed files and classes in my WIP implementation: ArrayView -> ListView On Wed, Apr 26, 2023 at 11:08 AM Ian Cook wrote: > +1 to what Weston and Joris suggested regarding the name. "ListView" > seems like the best name to use for this layout in Arrow. >

Re: [DISCUSS][Format] Starting the draft implementation of the ArrayView array format

2023-04-26 Thread Ian Cook
+1 to what Weston and Joris suggested regarding the name. "ListView" seems like the best name to use for this layout in Arrow. My understanding is that the primary benefit of this ListView layout over Arrow's existing List layouts [1] is that ListView allows for buffer alignment [2] without

Re: [DISCUSS][Format] Starting the draft implementation of the ArrayView array format

2023-04-26 Thread Joris Van den Bossche
On Wed, 26 Apr 2023 at 02:37, Weston Pace wrote: > > For context, there was some discussion on this back in [1]. At that time > this was called "sequence view" but I do not like that name. However, > array-view array is a little confusing. Given this is similar to list can > we go with

Re: [VOTE] Formalize how to change format

2023-04-26 Thread Joris Van den Bossche
+1 On Wed, 26 Apr 2023 at 04:18, Sutou Kouhei wrote: > > Hi, > > I've added one more note about documentation: > > We must update the corresponding documentation (files in > ``_) > too. > >