Re: [RESULT] [VOTE] Alter Arrow binary protocol to address 8-byte Flatbuffer alignment requirements (2nd vote)

2019-09-13 Thread Neal Richardson
Nice work! On Fri, Sep 13, 2019 at 10:43 AM Wes McKinney wrote: > > Integration tests are passing: > > https://travis-ci.org/apache/arrow/jobs/584361357 > > I'm merging the feature branch into master. Thanks all > > On Thu, Sep 12, 2019 at 6:15 PM Wes McKinney wrote: > > > > Thanks all! > > > >

Re: [RESULT] [VOTE] Alter Arrow binary protocol to address 8-byte Flatbuffer alignment requirements (2nd vote)

2019-09-13 Thread Wes McKinney
Integration tests are passing: https://travis-ci.org/apache/arrow/jobs/584361357 I'm merging the feature branch into master. Thanks all On Thu, Sep 12, 2019 at 6:15 PM Wes McKinney wrote: > > Thanks all! > > It looks like all the changes are in, so we need to see if the > integration tests

Re: [RESULT] [VOTE] Alter Arrow binary protocol to address 8-byte Flatbuffer alignment requirements (2nd vote)

2019-09-12 Thread Sebastien Binet
hi there, On Thu, Sep 12, 2019 at 12:45 AM Wes McKinney wrote: > Thanks Bryan. > > I merged the Java patch with the EOS change and submitted a C++ patch > which also updates the specification > > https://github.com/apache/arrow/pull/5361 > > Let me know when the JS or C# patches are ready to go

Re: [RESULT] [VOTE] Alter Arrow binary protocol to address 8-byte Flatbuffer alignment requirements (2nd vote)

2019-09-11 Thread Wes McKinney
t; > the state, so if it reads the continuation token from the beginning, > >> then > >> > read all 8 bytes at the end. > >> > > > >> > > Thanks, > >> > > Ji Liu > >> > > > >> > > [1] h

Re: [RESULT] [VOTE] Alter Arrow binary protocol to address 8-byte Flatbuffer alignment requirements (2nd vote)

2019-09-10 Thread Bryan Cutler
;> > > To:dev@arrow.apache.org ; Ji Liu < >> > niki...@aliyun.com> >> > > Cc:emkornfield ; Paul Taylor < >> ptay...@apache.org> >> > > Subject:RE: [RESULT] [VOTE] Alter Arrow binary protocol to address >> > 8-byte Flatbuffer alignmen

Re: [RESULT] [VOTE] Alter Arrow binary protocol to address 8-byte Flatbuffer alignment requirements (2nd vote)

2019-09-09 Thread Bryan Cutler
> > read all 8 bytes at the end. > > > > > > Thanks, > > > Ji Liu > > > > > > [1] https://github.com/apache/arrow/pull/5229 > > > [2] https://github.com/apache/arrow/pull/5229#discussion_r321715682 > > > > > > > > > > > > > > > ------------------ > >

Re: [RESULT] [VOTE] Alter Arrow binary protocol to address 8-byte Flatbuffer alignment requirements (2nd vote)

2019-09-07 Thread Micah Kornfield
. > > > > https://github.com/apache/arrow/pull/5280 > > > > Eric > > > > -----Original Message----- > > From: Eric Erhardt > > Sent: Wednesday, September 4, 2019 10:12 AM > > To: dev@arrow.apache.org; Ji Liu > > Cc: emkornfield ; Paul Taylor

Re: [RESULT] [VOTE] Alter Arrow binary protocol to address 8-byte Flatbuffer alignment requirements (2nd vote)

2019-09-07 Thread Wes McKinney
d Time:2019年9月5日(星期四) 07:16 > To:dev@arrow.apache.org ; Ji Liu > Cc:emkornfield ; Paul Taylor > Subject:RE: [RESULT] [VOTE] Alter Arrow binary protocol to address 8-byte > Flatbuffer alignment requirements (2nd vote) > > The C# PR is up. > > https://github.com/apache/arrow/pul

Re: [RESULT] [VOTE] Alter Arrow binary protocol to address 8-byte Flatbuffer alignment requirements (2nd vote)

2019-09-06 Thread Ji Liu
Message- From: Wes McKinney Sent: Tuesday, September 3, 2019 10:17 PM To: Ji Liu Cc: emkornfield ; dev ; Paul Taylor Subject: Re: [RESULT] [VOTE] Alter Arrow binary protocol to address 8-byte Flatbuffer alignment requirements (2nd vote) hi folks, We now have patches up for Java, JS, and Go

RE: [RESULT] [VOTE] Alter Arrow binary protocol to address 8-byte Flatbuffer alignment requirements (2nd vote)

2019-09-04 Thread Eric Erhardt
: Wes McKinney Sent: Tuesday, September 3, 2019 10:17 PM To: Ji Liu Cc: emkornfield ; dev ; Paul Taylor Subject: Re: [RESULT] [VOTE] Alter Arrow binary protocol to address 8-byte Flatbuffer alignment requirements (2nd vote) hi folks, We now have patches up for Java, JS, and Go. How are we

RE: [RESULT] [VOTE] Alter Arrow binary protocol to address 8-byte Flatbuffer alignment requirements (2nd vote)

2019-09-04 Thread Eric Erhardt
, 2019 10:17 PM To: Ji Liu Cc: emkornfield ; dev ; Paul Taylor Subject: Re: [RESULT] [VOTE] Alter Arrow binary protocol to address 8-byte Flatbuffer alignment requirements (2nd vote) hi folks, We now have patches up for Java, JS, and Go. How are we doing on the code reviews for getting

Re: [RESULT] [VOTE] Alter Arrow binary protocol to address 8-byte Flatbuffer alignment requirements (2nd vote)

2019-09-03 Thread Wes McKinney
--- > From:Ji Liu > Send Time:2019年8月28日(星期三) 17:34 > To:emkornfield ; dev > Cc:Paul Taylor > Subject:Re: [RESULT] [VOTE] Alter Arrow binary protocol to address 8-byte > Flatbuffer alignment requirements (2nd vote) > > I could take the Java implementation and will ta

Re: [RESULT] [VOTE] Alter Arrow binary protocol to address 8-byte Flatbuffer alignment requirements (2nd vote)

2019-08-29 Thread Ji Liu
Kornfield Send Time:2019年8月28日(星期三) 17:14 To:dev Cc:Paul Taylor Subject:Re: [RESULT] [VOTE] Alter Arrow binary protocol to address 8-byte Flatbuffer alignment requirements (2nd vote) I should have integration tests with 0.14.1 generated binaries in the next few days. I think the one remaining

Re: [RESULT] [VOTE] Alter Arrow binary protocol to address 8-byte Flatbuffer alignment requirements (2nd vote)

2019-08-28 Thread Ji Liu
Arrow binary protocol to address 8-byte Flatbuffer alignment requirements (2nd vote) I should have integration tests with 0.14.1 generated binaries in the next few days. I think the one remaining unassigned piece of work in the Java implementation, i can take that up next if no one else gets

Re: [RESULT] [VOTE] Alter Arrow binary protocol to address 8-byte Flatbuffer alignment requirements (2nd vote)

2019-08-28 Thread Micah Kornfield
I should have integration tests with 0.14.1 generated binaries in the next few days. I think the one remaining unassigned piece of work in the Java implementation, i can take that up next if no one else gets to it. On Tue, Aug 27, 2019 at 7:19 PM Wes McKinney wrote: > Here's the C++ changes >

Re: [RESULT] [VOTE] Alter Arrow binary protocol to address 8-byte Flatbuffer alignment requirements (2nd vote)

2019-08-27 Thread Wes McKinney
Here's the C++ changes https://github.com/apache/arrow/pull/5211 I'm going to create a integration branch where we can merge each patch before merging to master On Fri, Aug 23, 2019 at 9:03 AM Wes McKinney wrote: > > It isn't implemented in C++ yet but I will try to get a patch up for > that

Re: [RESULT] [VOTE] Alter Arrow binary protocol to address 8-byte Flatbuffer alignment requirements (2nd vote)

2019-08-23 Thread Wes McKinney
It isn't implemented in C++ yet but I will try to get a patch up for that soon (today maybe). I think we should create a branch where we can stack the patches that implement this for each language. On Fri, Aug 23, 2019 at 4:04 AM Paul Taylor wrote: > > I'll do the JS updates. Is it safe to

Re: [RESULT] [VOTE] Alter Arrow binary protocol to address 8-byte Flatbuffer alignment requirements (2nd vote)

2019-08-23 Thread Paul Taylor
I'll do the JS updates. Is it safe to validate against the Arrow C++ integration tests? On 8/22/19 7:28 PM, Micah Kornfield wrote: I created https://issues.apache.org/jira/browse/ARROW-6313 as a tracking issue with sub-issues on the development work. So far no-one has claimed Java and

Re: [RESULT] [VOTE] Alter Arrow binary protocol to address 8-byte Flatbuffer alignment requirements (2nd vote)

2019-08-22 Thread Micah Kornfield
I created https://issues.apache.org/jira/browse/ARROW-6313 as a tracking issue with sub-issues on the development work. So far no-one has claimed Java and Javascript tasks. Would it make sense to have a separate dev branch for this work? Thanks, Micah On Thu, Aug 22, 2019 at 3:24 PM Wes

[RESULT] [VOTE] Alter Arrow binary protocol to address 8-byte Flatbuffer alignment requirements (2nd vote)

2019-08-22 Thread Wes McKinney
The vote carries with 4 binding +1 votes and 1 non-binding +1 I'll merge the specification patch later today and we can begin working on implementations so we can get this done for 0.15.0 On Tue, Aug 20, 2019 at 12:30 PM Bryan Cutler wrote: > > +1 (non-binding) > > On Tue, Aug 20, 2019, 7:43 AM