Re: [VOTE] Release Apache Arrow 0.12.0 (RC2) ARROW

2019-01-15 Thread Andrew Palumbo
SGTM. Happy to.

Re: [VOTE] Release Apache Arrow 0.12.0 (RC2) ARROW

2019-01-15 Thread Andrew Palumbo
From: Andrew Palumbo Sent: Tuesday, January 15, 2019 12:42 PM To: dev@arrow.apache.org Subject: Re: [VOTE] Release Apache Arrow 0.12.0 (RC2) ARROW Wes, /tmp doesnt seem to be the issue. it seems this machine has ~295 G. (I'll try to eye-verify that there is not some massive memory leak a bit later

Re: [VOTE] Release Apache Arrow 0.12.0 (RC2) ARROW

2019-01-15 Thread Andrew Palumbo
verify script for 0.12.0 Thanks Very Much, Andy From: Wes McKinney Sent: Tuesday, January 15, 2019 12:47 AM To: dev@arrow.apache.org Subject: Re: [VOTE] Release Apache Arrow 0.12.0 (RC2) ARROW I'm working on getting ARROW-4258 merged right now. ARROW-4260 also

Re: [VOTE] Release Apache Arrow 0.12.0 (RC2) ARROW

2019-01-14 Thread Wes McKinney
ps://github.com/apache/arrow/commit/be663c14637b2bdfef935946b6e91b6317219332 > ? > > arrow-json-integration-test needs -DARROW_BUILD_TESTS=ON. > > > Thanks, > -- > kou > > In > > "Re: [VOTE] Release Apache Arrow 0.12.0 (RC2) ARROW" on Tue, 15 Jan 2

Re: [VOTE] Release Apache Arrow 0.12.0 (RC2) ARROW

2019-01-14 Thread Kouhei Sutou
Hi, Does your verify-release-candidate.sh include https://github.com/apache/arrow/commit/be663c14637b2bdfef935946b6e91b6317219332 ? arrow-json-integration-test needs -DARROW_BUILD_TESTS=ON. Thanks, -- kou In "Re: [VOTE] Release Apache Arrow 0.12.0 (RC2) ARROW" on Tue, 15 Jan 2

Re: [VOTE] Release Apache Arrow 0.12.0 (RC2) ARROW

2019-01-14 Thread Wes McKinney
ectory: > '/tmp/arrow-0.12.0.5xTVS/apache-arrow-0.12.0/cpp/build/release/arrow-json- > integration-test': > '/tmp/arrow-0.12.0.5xTVS/apache-arrow-0.12.0/cpp/build/release/arrow-json-integration-test' > + cleanup > + rm -fr /tmp/arrow-0.12.0.5xTVS > > > > > Jira or is

Re: [VOTE] Release Apache Arrow 0.12.0 (RC2) ARROW

2019-01-14 Thread Andrew Palumbo
-0.12.0.5xTVS/apache-arrow-0.12.0/cpp/build/release/arrow-json-integration-test' + cleanup + rm -fr /tmp/arrow-0.12.0.5xTVS Jira or is this something obvious that i missed? Thank you. --Andy ________ From: Andrew Palumbo Sent: Monday, January 14, 2019 9:23 PM To: dev@arrow

Re: [VOTE] Release Apache Arrow 0.12.0 (RC2) ARROW

2019-01-14 Thread Andrew Palumbo
Hello, I've just run the verify scipt on the 0.12.0 tag after configuring an Ubuntu machine per the instructions. I'm crashing at "c++ producing, c++ consuming". With a no such file or directory... Arrow-json-integration-test. When I was trying to build straight from that submodule there was

Re: [VOTE] Release Apache Arrow 0.12.0 (RC2) ARROW

2019-01-14 Thread Kouhei Sutou
.apache.org/jira/browse/ARROW-4246 > > I don't think that this is a blocker. > > Other modules work well with ARROW_HAVE_GPU=yes. > > > There is a problem with GCC 8: > > https://issues.apache.org/jira/browse/ARROW-4242 > > I don't think that this is a blocker

Re: [VOTE] Release Apache Arrow 0.12.0 (RC2) ARROW

2019-01-14 Thread Kouhei Sutou
Hi, I've created a pull request for verifying binaries on Bintray: https://github.com/apache/arrow/pull/3397 Thanks, -- kou In <0a69afdb-2c15-2d7d-1d56-5333bf12b...@python.org> "Re: [VOTE] Release Apache Arrow 0.12.0 (RC2) ARROW" on Mon, 14 Jan 2019 09:34:06 +0100,

Re: [VOTE] Release Apache Arrow 0.12.0 (RC2) ARROW

2019-01-14 Thread Wes McKinney
Does anything need to change in the verification scripts to run the JavaScript parts of the integration tests? The build was passing when I merged the refactor. We aren't pushing any npm artifacts from this release so as long as the tests run it is OK I would be OK with merging the patch for

Re: [VOTE] Release Apache Arrow 0.12.0 (RC2) ARROW

2019-01-14 Thread Krisztián Szűcs
I'm fine with cutting an RC3. ARROW-4258 seems pretty bad. If We decide to create a new RC how should We deal with the recent JS refactoring [1]? On OSX the verification worked well though, except a plasma issue. Uwe, if You have time please verify it on OSX too. [1]

Re: [VOTE] Release Apache Arrow 0.12.0 (RC2) ARROW

2019-01-14 Thread Antoine Pitrou
Ok, it worked, except that I got the classical test_plasma_list() failure. Regards Antoine. Le 14/01/2019 à 17:50, Wes McKinney a écrit : > How about using the conda-forge package? > > conda create -y -p $HOME/release-0.12-toolchain brotli -c conda-forge > export

Re: [VOTE] Release Apache Arrow 0.12.0 (RC2) ARROW

2019-01-14 Thread Wes McKinney
In light of the severity of ARROW-4258 (https://github.com/apache/arrow/pull/3395) and some of the other rough edges in this RC, I would suggest making some fixes today and cutting an RC3. I'm revising my vote to -0 @Krisztian -- you are the RM, so it is up to you whether you want to cancel the

Re: [VOTE] Release Apache Arrow 0.12.0 (RC2) ARROW

2019-01-14 Thread Wes McKinney
How about using the conda-forge package? conda create -y -p $HOME/release-0.12-toolchain brotli -c conda-forge export BROTLI_HOME=$HOME/release-0.12-toolchain On Mon, Jan 14, 2019 at 10:46 AM Antoine Pitrou wrote: > > > Unfortunately, Ubuntu only provides shared library versions of > Brotli

Re: [VOTE] Release Apache Arrow 0.12.0 (RC2) ARROW

2019-01-14 Thread Antoine Pitrou
Unfortunately, Ubuntu only provides shared library versions of Brotli but we're looking for a statically-linked brotli: make[2]: *** No rule to make target '/usr/lib/x86_64-linux-gnu/libbrotlidec.a', needed by 'release/libarrow.so.12.0.0'. Stop. CMakeFiles/Makefile2:2013: recipe for target

Re: [VOTE] Release Apache Arrow 0.12.0 (RC2) ARROW

2019-01-14 Thread Wes McKinney
I forgot to add that I also hit known issue https://issues.apache.org/jira/browse/ARROW-3344 on Ubuntu 14.04 On Mon, Jan 14, 2019 at 9:46 AM Wes McKinney wrote: > > Can you set $BROTLI_HOME to unblock yourself? Since we have .deb > packages for Ubuntu Bionic it's an annoyance for source-builders

Re: [VOTE] Release Apache Arrow 0.12.0 (RC2) ARROW

2019-01-14 Thread Wes McKinney
Can you set $BROTLI_HOME to unblock yourself? Since we have .deb packages for Ubuntu Bionic it's an annoyance for source-builders but not a deal breaker (IMHO) for the RC On Mon, Jan 14, 2019 at 3:24 AM Antoine Pitrou wrote: > > > Unfortunately I cannot validate the source release on Ubuntu

Re: [VOTE] Release Apache Arrow 0.12.0 (RC2) ARROW

2019-01-14 Thread Antoine Pitrou
Unfortunately I cannot validate the source release on Ubuntu 18.04, as brotli fails compiling with a internal compiler error (this is gcc 7.3.0): /tmp/arrow-0.12.0.BZuZO/apache-arrow-0.12.0/cpp/build/brotli_ep-prefix/src/brotli_ep/enc/compress_fragment.c: In function

Re: [VOTE] Release Apache Arrow 0.12.0 (RC2) ARROW

2019-01-14 Thread Antoine Pitrou
Apparently the binaries verification script attempts to download from dist.apache.org? $ dev/release/verify-release-candidate.sh binaries 0.12.0 rc2 [...] + wget -P apache-arrow-0.12.0-rcrc2 --quiet --no-host-directories --cut-dirs=5 --no-parent --reject 'index.html*' --recursive

Re: [VOTE] Release Apache Arrow 0.12.0 (RC2) ARROW

2019-01-13 Thread Philipp Moritz
+1 (non-binding) I didn't do very exhaustive tests, but the full Ray test suite passes based on that commit. On Sun, Jan 13, 2019 at 8:59 PM Wes McKinney wrote: > +1 (binding) > > Ran release verification scripts (for source release) on Ubuntu 14.04 > (with ARROW_HAVE_CUDA=yes) and Windows /

Re: [VOTE] Release Apache Arrow 0.12.0 (RC2) ARROW

2019-01-13 Thread Wes McKinney
+1 (binding) Ran release verification scripts (for source release) on Ubuntu 14.04 (with ARROW_HAVE_CUDA=yes) and Windows / Visual Studio 2015 with some caveats * ARROW-4250: Gandiva test failing due to exact floating point comparison on Ubuntu 14.04 * ARROW-4253: GLib cannot use a non-system

Re: [VOTE] Release Apache Arrow 0.12.0 (RC2) ARROW

2019-01-13 Thread Andy Grove
Speaking for the Rust implementation only ... - The code compiles and tests pass - The version number of both crates (arrow and parquet) is correctly set to 0.12.0 - The parquet crate still depends on the arrow crate using a local path (../arrow) rather than depending on the published 0.12.0

Re: [VOTE] Release Apache Arrow 0.12.0 (RC2) ARROW

2019-01-13 Thread Krisztián Szűcs
is a blocker. > > Other modules work well with ARROW_HAVE_GPU=yes. > > > There is a problem with GCC 8: > > https://issues.apache.org/jira/browse/ARROW-4242 > > I don't think that this is a blocker. > > > Thanks, > -- > kou > > In > "[VOTE]

[VOTE] Release Apache Arrow 0.12.0 (RC2) ARROW

2019-01-12 Thread Krisztián Szűcs
Hi, I'd like to propose the 1st release candidate (RC2) of Apache Arrow version 0.12.0. This is a major release consisting of 600 resolved JIRAs [1]. The previous RCs were not voted, because: - RC0: the source archive didn't include required files to build gandiva-glib documents, also causing