Re: Review Request 73292: ATLAS-4254 : Basic Search : Optimize pagination

2021-05-09 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73292/#review222954 ---

Re: Review Request 73329: Correlating Deleted Entities with Lineage

2021-05-04 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73329/ --- (Updated May 5, 2021, 12:39 a.m.) Review request for atlas, Radhika Kundam and

Re: Review Request 73330: ATLAS-4272: Re-importing after deleting a glossary fails

2021-05-03 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73330/#review222935 --- Ship it! Ship It! - Ashutosh Mestry On May 3, 2021, 10:06

Re: Review Request 73329: Correlating Deleted Entities with Lineage

2021-05-03 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73329/ --- (Updated May 3, 2021, 8:59 p.m.) Review request for atlas, Radhika Kundam and

Review Request 73329: Correlating Deleted Entities with Lineage

2021-05-03 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73329/ --- Review request for atlas, Radhika Kundam and Sarath Subramanian. Bugs:

Re: Review Request 73316: ATLAS-4269: Deferred Actions : When a tag is propagated from an entity via 2 processes , blocking 1 process removes tag propagated from another process

2021-04-29 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73316/#review222919 --- Ship it! Ship It! - Ashutosh Mestry On April 30, 2021, 4:01

Re: Review Request 73316: ATLAS-4269: Deferred Actions : When a tag is propagated from an entity via 2 processes , blocking 1 process removes tag propagated from another process

2021-04-29 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73316/#review222917 ---

Re: Review Request 73314: ATLAS-4268: Deferred Actions : When a tag is already associated to a term and when the term is assigned to the entity , tag propagation doesn't happen

2021-04-29 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73314/#review222915 --- Ship it! Ship It! - Ashutosh Mestry On April 29, 2021, 7:39

Re: Review Request 73296: AtlasTasks: Elegant handling of Failover Scenarios

2021-04-26 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73296/ --- (Updated April 26, 2021, 11:40 p.m.) Review request for atlas, Jayendra Parab

Re: Review Request 73296: AtlasTasks: Elegant handling of Failover Scenarios

2021-04-26 Thread Ashutosh Mestry via Review Board
> On April 26, 2021, 5:32 a.m., Sarath Subramanian wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasGraphUtilsV2.java > > Lines 865 (patched) > > > > > > line 853 saves to edge as

Re: Review Request 73296: AtlasTasks: Elegant handling of Failover Scenarios

2021-04-25 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73296/ --- (Updated April 26, 2021, 5:56 a.m.) Review request for atlas, Jayendra Parab

Re: Review Request 73296: AtlasTasks: Elegant handling of Failover Scenarios

2021-04-25 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73296/ --- (Updated April 26, 2021, 3:29 a.m.) Review request for atlas, Jayendra Parab

Re: Review Request 73296: AtlasTasks: Elegant handling of Failover Scenarios

2021-04-24 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73296/ --- (Updated April 24, 2021, 6:43 a.m.) Review request for atlas, Jayendra Parab

Review Request 73296: AtlasTasks: Elegant handling of Failover Scenarios

2021-04-23 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73296/ --- Review request for atlas, Jayendra Parab and Sarath Subramanian. Bugs:

Re: Review Request 73271: ATLAS-4238 : Quick Search: handle special characters to get correct results

2021-04-13 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73271/#review222819 ---

Re: Review Request 73076: Deferred Actions Implementation

2021-04-13 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/ --- (Updated April 13, 2021, 4:28 p.m.) Review request for atlas, Jayendra Parab,

Re: Review Request 73239: HiveHook: HiveServer2 Messages Improvement

2021-04-12 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73239/ --- (Updated April 12, 2021, 4:31 p.m.) Review request for atlas, Madhan Neethiraj

Re: Review Request 73239: HiveHook: HiveServer2 Messages Improvement

2021-04-12 Thread Ashutosh Mestry via Review Board
> On April 12, 2021, 1:43 p.m., Nikhil Bonte wrote: > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/utils/HiveDDLEntityFilter.java > > Lines 246 (patched) > > > > > > remove extra blank line Done.

Re: Review Request 73239: HiveHook: HiveServer2 Messages Improvement

2021-04-09 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73239/ --- (Updated April 9, 2021, 11:41 p.m.) Review request for atlas, Madhan Neethiraj

Re: Review Request 73239: HiveHook: HiveServer2 Messages Improvement

2021-04-09 Thread Ashutosh Mestry via Review Board
> On April 9, 2021, 10:18 p.m., Sarath Subramanian wrote: > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/utils/ActiveEntityFilter.java > > Lines 40 (patched) > > > > > > consider moving line 35 here,

Re: Review Request 73239: HiveHook: HiveServer2 Messages Improvement

2021-04-09 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73239/ --- (Updated April 9, 2021, 9:14 p.m.) Review request for atlas, Madhan Neethiraj

Re: Review Request 73239: HiveHook: HiveServer2 Messages Improvement

2021-04-08 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73239/ --- (Updated April 9, 2021, 5:04 a.m.) Review request for atlas, Madhan Neethiraj

Re: Review Request 73239: HiveHook: HiveServer2 Messages Improvement

2021-04-08 Thread Ashutosh Mestry via Review Board
> On April 8, 2021, 11:26 p.m., Sarath Subramanian wrote: > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateDatabase.java > > Line 49 (original), 50 (patched) > > > > > > can we call

Re: Review Request 73076: Deferred Actions Implementation

2021-04-08 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/ --- (Updated April 8, 2021, 11:26 p.m.) Review request for atlas, Jayendra Parab,

Re: Review Request 73239: HiveHook: HiveServer2 Messages Improvement

2021-04-02 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73239/ --- (Updated April 2, 2021, 4:18 p.m.) Review request for atlas, Madhan Neethiraj

Re: Review Request 73239: HiveHook: HiveServer2 Messages Improvement

2021-03-24 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73239/ --- (Updated March 25, 2021, midnight) Review request for atlas, Madhan Neethiraj

Re: Review Request 73239: HiveHook: HiveServer2 Messages Improvement

2021-03-24 Thread Ashutosh Mestry via Review Board
> On March 22, 2021, 6:08 p.m., Madhan Neethiraj wrote: > > addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateTable.java > > Line 173 (original), 175 (patched) > > > > > > if hive_process and

Re: Review Request 73239: HiveHook: HiveServer2 Messages Improvement

2021-03-22 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73239/ --- (Updated March 22, 2021, 5:23 p.m.) Review request for atlas, Madhan Neethiraj

Review Request 73239: HiveHook: HiveServer2 Messages Improvement

2021-03-17 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73239/ --- Review request for atlas, Madhan Neethiraj and Sarath Subramanian. Bugs:

Re: Review Request 73233: ATLAS-4211 : DSL Search : Regression: When fetching string attribute with null value returns null , earlier versions returned empty

2021-03-17 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73233/#review222698 --- Fix it, then Ship it!

Re: Review Request 73076: Deferred Actions Implementation

2021-03-12 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/ --- (Updated March 13, 2021, 1 a.m.) Review request for atlas, Jayendra Parab,

Re: Review Request 73076: Deferred Actions Implementation

2021-03-12 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/ --- (Updated March 12, 2021, 8:29 p.m.) Review request for atlas, Jayendra Parab,

Re: Review Request 73076: Deferred Actions Implementation

2021-03-11 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/ --- (Updated March 12, 2021, 6:41 a.m.) Review request for atlas, Jayendra Parab,

Re: Review Request 73076: Deferred Actions Implementation

2021-03-11 Thread Ashutosh Mestry via Review Board
> On March 11, 2021, 8:52 p.m., Sarath Subramanian wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java > > Lines 2817 (patched) > > > > > > this will end up

Re: Review Request 73076: Deferred Actions Implementation

2021-03-10 Thread Ashutosh Mestry via Review Board
> On March 9, 2021, 6:27 a.m., Madhan Neethiraj wrote: > > intg/src/main/java/org/apache/atlas/model/tasks/AtlasTask.java > > Lines 184 (patched) > > > > > > - getTaskVertex() => getAdditionalInfo()? > > -

Re: Review Request 73076: Deferred Actions Implementation

2021-03-10 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/ --- (Updated March 11, 2021, 6:49 a.m.) Review request for atlas, Jayendra Parab,

Re: Review Request 73076: Deferred Actions Implementation

2021-03-08 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/ --- (Updated March 8, 2021, 6:19 p.m.) Review request for atlas, Jayendra Parab,

Re: Review Request 73076: Deferred Actions Implementation

2021-02-25 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/ --- (Updated Feb. 26, 2021, 6:08 a.m.) Review request for atlas, Jayendra Parab,

Re: Review Request 73076: Deferred Actions Implementation

2021-02-24 Thread Ashutosh Mestry via Review Board
> On Feb. 19, 2021, 8:58 p.m., Madhan Neethiraj wrote: > > common/src/main/java/org/apache/atlas/repository/Constants.java > > Lines 212 (patched) > > > > > > - TASK_TYPE_PROPERTY_KEY and TASK_TYPE are duplicates >

Re: Review Request 73076: Deferred Actions Implementation

2021-02-24 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/ --- (Updated Feb. 25, 2021, 5:27 a.m.) Review request for atlas, Jayendra Parab,

Re: Review Request 73076: Deferred Actions Implementation

2021-02-18 Thread Ashutosh Mestry via Review Board
> On Feb. 18, 2021, 7:14 a.m., Sarath Subramanian wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java > > Lines 2780 (patched) > > > > > > the taskDef guid should

Re: Review Request 73076: Deferred Actions Implementation

2021-02-18 Thread Ashutosh Mestry via Review Board
> On Feb. 18, 2021, 7:52 a.m., Sarath Subramanian wrote: > > one improvement to add (can be taken up in a follow-up patch) - add the > > task id to the entity vertex as well, so from entity details page we will > > know how many pending tasks are in process. I will address this in this patch.

Re: Review Request 73076: Deferred Actions Implementation

2021-02-18 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/ --- (Updated Feb. 19, 2021, 3:49 a.m.) Review request for atlas, Jayendra Parab,

Re: Review Request 73193: ATLAS-4170: v2/entity/bulk Entity GET API is able to read unauthorised entities too when skipFailedEntities is passed as True

2021-02-18 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73193/#review222614 --- Ship it! Ship It! - Ashutosh Mestry On Feb. 19, 2021, 2:17

Re: Review Request 73185: NotificationHookConsumer: Large Compressed Message Processing Problem

2021-02-17 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73185/ --- (Updated Feb. 18, 2021, 5:19 a.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 73185: NotificationHookConsumer: Large Compressed Message Processing Problem

2021-02-17 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73185/ --- (Updated Feb. 17, 2021, 7:12 p.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 73185: NotificationHookConsumer: Large Compressed Message Processing Problem

2021-02-17 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73185/ --- (Updated Feb. 17, 2021, 6:19 p.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 73185: NotificationHookConsumer: Large Compressed Message Processing Problem

2021-02-16 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73185/ --- (Updated Feb. 17, 2021, 7:03 a.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 73076: Deferred Actions Implementation

2021-02-16 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/ --- (Updated Feb. 17, 2021, 5:55 a.m.) Review request for atlas, Jayendra Parab,

Review Request 73185: NotificationHookConsumer: Large Compressed Message Processing Problem

2021-02-14 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73185/ --- Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath

Re: Review Request 73076: Deferred Actions Implementation

2021-02-11 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/ --- (Updated Feb. 11, 2021, 7:12 p.m.) Review request for atlas, Jayendra Parab,

Re: Review Request 73076: Deferred Actions Implementation

2021-02-10 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/ --- (Updated Feb. 11, 2021, 6:37 a.m.) Review request for atlas, Jayendra Parab,

Re: Review Request 73076: Deferred Actions Implementation

2021-02-10 Thread Ashutosh Mestry via Review Board
> On Feb. 5, 2021, 7:16 a.m., Madhan Neethiraj wrote: > > intg/src/main/java/org/apache/atlas/model/tasks/TaskDef.java > > Lines 65 (patched) > > > > > > Since TaskDef will be serialized/deserialized, consider using

Re: Review Request 73182: ATLAS-4139 [Atlas: Glossary Term Bulk Import] When AdditionalAttributes is not provided in key:value format, the error message does not convey that

2021-02-10 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73182/#review222582 --- Can you please combine this with your other review. This change

Re: Review Request 73076: Deferred Actions Implementation

2021-02-09 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/ --- (Updated Feb. 10, 2021, 6:40 a.m.) Review request for atlas, Jayendra Parab,

Re: Review Request 73076: Deferred Actions Implementation

2021-02-09 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/ --- (Updated Feb. 10, 2021, 6:25 a.m.) Review request for atlas, Jayendra Parab,

Re: Review Request 73173: ATLAS-4137 Entity Audit V1 api broken

2021-02-04 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73173/#review222557 --- Ship it! Ship It! - Ashutosh Mestry On Feb. 4, 2021, 6:19

Re: Review Request 73166: Clause Change for Glossary

2021-02-03 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73166/ --- (Updated Feb. 3, 2021, 9:46 p.m.) Review request for atlas, Nikhil Bonte,

Review Request 73166: Clause Change for Glossary

2021-02-01 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73166/ --- Review request for atlas, Nikhil Bonte, Pinal Shah, and Sarath Subramanian.

Re: Review Request 73151: ATLAS-4107 :- Atlas not picking the ldap bind password from the correct jceks file.

2021-01-27 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73151/#review222532 --- intg/src/main/java/org/apache/atlas/ApplicationProperties.java

Re: Review Request 73076: Deferred Actions Implementation

2021-01-25 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/ --- (Updated Jan. 25, 2021, 11:08 p.m.) Review request for atlas, Jayendra Parab,

Re: Review Request 73157: ATLAS-4110 Inconsistency in the result of DSL query and basic query.

2021-01-25 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73157/#review222529 --- Ship it! Ship It! - Ashutosh Mestry On Jan. 25, 2021, 9:52

Re: Review Request 73157: ATLAS-4110 Inconsistency in the result of DSL query and basic query.

2021-01-25 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73157/#review222528 ---

Re: Review Request 73157: ATLAS-4110 Inconsistency in the result of DSL query and basic query.

2021-01-25 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73157/#review222526 ---

Re: Review Request 73157: ATLAS-4110 Inconsistency in the result of DSL query and basic query.

2021-01-25 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73157/#review222525 --- In _RegistryBasedLookup_ please add Byte in the

Re: Review Request 73076: Deferred Actions Implementation

2021-01-20 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/ --- (Updated Jan. 20, 2021, 11:14 p.m.) Review request for atlas, Jayendra Parab,

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

2021-01-20 Thread Ashutosh Mestry via Review Board
> On Jan. 20, 2021, 12:54 a.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/query/DSLVisitor.java > > Line 232 (original), 247 (patched) > > > > > > Shouldn't a new GremlinQueryComposer be

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

2021-01-20 Thread Ashutosh Mestry via Review Board
> On Jan. 16, 2021, 7:54 a.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/query/executors/GremlinClauseToTraversalTranslator.java > > Lines 108 (patched) > > > > > > Can you review how

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

2021-01-20 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73128/ --- (Updated Jan. 20, 2021, 6:49 p.m.) Review request for atlas, Apoorv Naik,

Re: Review Request 73076: Deferred Actions Implementation

2021-01-19 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/ --- (Updated Jan. 19, 2021, 6:31 p.m.) Review request for atlas, Jayendra Parab,

Re: Review Request 73076: Deferred Actions Implementation

2021-01-19 Thread Ashutosh Mestry via Review Board
> On Jan. 10, 2021, 9:43 a.m., Sarath Subramanian wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java > > Lines 2037 (patched) > > > > > > consider adding tags to

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

2021-01-18 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73128/ --- (Updated Jan. 19, 2021, 4:52 a.m.) Review request for atlas, Apoorv Naik,

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

2021-01-18 Thread Ashutosh Mestry via Review Board
> On Jan. 15, 2021, 9:59 p.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/query/executors/GremlinClauseToTraversalTranslator.java > > Lines 65 (patched) > > > > > > trLists and collected

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

2021-01-15 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73128/ --- (Updated Jan. 16, 2021, 7:06 a.m.) Review request for atlas, Apoorv Naik,

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

2021-01-15 Thread Ashutosh Mestry via Review Board
> On Jan. 14, 2021, 3:58 p.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/query/executors/GremlinClauseToTraversalTranslator.java > > Lines 88 (patched) > > > > > > subTraversals could be

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

2021-01-15 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73128/ --- (Updated Jan. 15, 2021, 9:22 p.m.) Review request for atlas, Apoorv Naik,

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

2021-01-13 Thread Ashutosh Mestry via Review Board
> On Jan. 14, 2021, 5:12 a.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/query/executors/SelectClauseProjections.java > > Lines 145 (patched) > > > > > > if vertex doesn't have the

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

2021-01-13 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73128/ --- (Updated Jan. 14, 2021, 6:46 a.m.) Review request for atlas, Apoorv Naik,

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

2021-01-13 Thread Ashutosh Mestry via Review Board
> On Jan. 13, 2021, 8:46 p.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java > > Line 120 (original), 142 (patched) > > > > > > - for readability, and to

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

2021-01-13 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73128/ --- (Updated Jan. 14, 2021, 1:04 a.m.) Review request for atlas, Apoorv Naik,

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

2021-01-13 Thread Ashutosh Mestry via Review Board
- Ashutosh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73128/#review222455 --- On Jan. 13, 2021, 8:26 p.m., Ashutosh Mestry wrote:

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

2021-01-13 Thread Ashutosh Mestry via Review Board
> On Jan. 13, 2021, 5:12 p.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/query/executors/GremlinClauseToTraversalTranslator.java > > Lines 51 (patched) > > > > > > subTraversals is used

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

2021-01-13 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73128/ --- (Updated Jan. 13, 2021, 8:26 p.m.) Review request for atlas, Apoorv Naik,

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

2021-01-13 Thread Ashutosh Mestry via Review Board
> On Jan. 13, 2021, 6:15 a.m., Sarath Subramanian wrote: > > repository/src/main/java/org/apache/atlas/query/executors/TraversalBasedExecutor.java > > Lines 103 (patched) > > > > > > can there be a case where query

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

2021-01-12 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73128/ --- (Updated Jan. 12, 2021, 11:49 p.m.) Review request for atlas, Apoorv Naik,

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

2021-01-12 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73128/ --- (Updated Jan. 12, 2021, 10:41 p.m.) Review request for atlas, Apoorv Naik,

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

2021-01-12 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73128/ --- (Updated Jan. 12, 2021, 9:01 p.m.) Review request for atlas, Apoorv Naik,

Re: Review Request 73058: ATLAS-4057 : DSL Search : Support glossary terms and relationship

2021-01-12 Thread Ashutosh Mestry via Review Board
> On Jan. 12, 2021, 5:44 p.m., Ashutosh Mestry wrote: > > Can you please update documentation with these new keywords? Nevermind, i see it. Thanks! - Ashutosh --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 73058: ATLAS-4057 : DSL Search : Support glossary terms and relationship

2021-01-12 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73058/#review222443 --- Can you please update documentation with these new keywords? -

Re: Review Request 73076: Deferred Actions Implementation

2021-01-11 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/ --- (Updated Jan. 12, 2021, 6:34 a.m.) Review request for atlas, Jayendra Parab,

Re: Review Request 73126: ATLAS-4091: Upgrade janusgraph version to 0.5.3

2021-01-08 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73126/#review222423 --- Ship it! Ship It! - Ashutosh Mestry On Jan. 8, 2021, 11:47

Re: Review Request 73076: Deferred Actions Implementation

2020-12-16 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/ --- (Updated Dec. 16, 2020, 11:42 p.m.) Review request for atlas, Jayendra Parab,

Re: Review Request 73084: ATLAS-4067 In Entity Audits tab, show action as "user-defined properties added/updated/deleted" instead of plain 'Entity Updated'

2020-12-16 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73084/#review222358 --- Ship it! Ship It! - Ashutosh Mestry On Dec. 16, 2020, 5:35

Re: Review Request 73076: Deferred Actions Implementation: Work In Progress

2020-12-15 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73076/ --- (Updated Dec. 16, 2020, 5:18 a.m.) Review request for atlas, Jayendra Parab,

Re: Review Request 73081: ATLAS-4076: Creating an asset from existing asset adds duplicate Atlas audit entries

2020-12-15 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73081/#review222341 --- Ship it! Ship It! - Ashutosh Mestry On Dec. 11, 2020, 9:47

Re: Review Request 73081: ATLAS-4076: Creating an asset from existing asset adds duplicate Atlas audit entries

2020-12-15 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73081/#review222342 ---

Re: Review Request 73058: ATLAS-4057 : DSL Search : Support glossary terms and relationship

2020-12-14 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73058/#review222334 --- Can you please add a small section on docs? - Ashutosh Mestry

Re: Review Request 73058: ATLAS-4057 : DSL Search : Support glossary terms

2020-12-10 Thread Ashutosh Mestry via Review Board
> On Dec. 3, 2020, 5:58 p.m., Ashutosh Mestry wrote: > > repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java > > Lines 208 (patched) > > > > > > This doesn't make senese. > > Pinal Shah wrote:

Re: Review Request 73064: ATLAS-4059 - Rename Configuration flag for importing internal Kafka topics

2020-12-08 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73064/#review222312 --- Ship it! Ship It! - Ashutosh Mestry On Dec. 7, 2020, 3:44

Re: Review Request 73062: ATLAS-4049: Issue with few /admin APIs when hit on PASSIVE Atlas instance in HA mode

2020-12-03 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73062/#review83 --- Ship it! Ship It! - Ashutosh Mestry On Dec. 3, 2020, 6:05

<    1   2   3   4   >