Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2020-03-02 Thread Sidharth Mishra
://reviews.apache.org/r/71791/diff/17/ Changes: https://reviews.apache.org/r/71791/diff/16-17/ Testing --- Two UT and one IT has been added to test functionality like: 1. Atlas Audit entry save and retrive 2. Atlas Purge Audit store, retrive and search (UT and IT) Thanks, Sidharth Mishra

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2020-02-26 Thread Sidharth Mishra
://reviews.apache.org/r/71791/diff/16/ Changes: https://reviews.apache.org/r/71791/diff/15-16/ Testing --- Two UT and one IT has been added to test functionality like: 1. Atlas Audit entry save and retrive 2. Atlas Purge Audit store, retrive and search (UT and IT) Thanks, Sidharth Mishra

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2020-02-25 Thread Sidharth Mishra
://reviews.apache.org/r/71791/diff/15/ Changes: https://reviews.apache.org/r/71791/diff/14-15/ Testing --- Two UT and one IT has been added to test functionality like: 1. Atlas Audit entry save and retrive 2. Atlas Purge Audit store, retrive and search (UT and IT) Thanks, Sidharth Mishra

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2020-01-27 Thread Sidharth Mishra
://reviews.apache.org/r/71791/diff/14/ Changes: https://reviews.apache.org/r/71791/diff/13-14/ Testing --- Two UT and one IT has been added to test functionality like: 1. Atlas Audit entry save and retrive 2. Atlas Purge Audit store, retrive and search (UT and IT) Thanks, Sidharth Mishra

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2020-01-27 Thread Sidharth Mishra
ps://reviews.apache.org/r/71791/#review219365 --- On Dec. 11, 2019, 1:17 a.m., Sidharth Mishra wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2020-01-27 Thread Sidharth Mishra
ImportAuditEntry is part of this which I might have moved to another inherited class. But we have plan to unify the imp/exp audit soon, will take care later - Sidharth --- This is an automatically generated e-mail. To repl

Re: Review Request 71922: ATLAS-3564: New version of AWS S3 model addition

2020-01-13 Thread Sidharth Mishra
) - addons/models/3000-Cloud/3030-aws_s3_v2_typedefs.json PRE-CREATION Diff: https://reviews.apache.org/r/71922/diff/7/ Changes: https://reviews.apache.org/r/71922/diff/6-7/ Testing --- Thanks, Sidharth Mishra

Re: Review Request 71922: ATLAS-3564: New version of AWS S3 model addition

2020-01-12 Thread Sidharth Mishra
) - addons/models/3000-Cloud/3030-aws_s3_v2_typedefs.json PRE-CREATION Diff: https://reviews.apache.org/r/71922/diff/6/ Changes: https://reviews.apache.org/r/71922/diff/5-6/ Testing --- Thanks, Sidharth Mishra

Re: Review Request 71922: ATLAS-3564: New version of AWS S3 model addition

2020-01-10 Thread Sidharth Mishra
) - addons/models/3000-Cloud/3030-aws_s3_v2_typedefs.json PRE-CREATION Diff: https://reviews.apache.org/r/71922/diff/5/ Changes: https://reviews.apache.org/r/71922/diff/4-5/ Testing --- Thanks, Sidharth Mishra

Re: Review Request 71922: ATLAS-3564: New version of AWS S3 model addition

2020-01-10 Thread Sidharth Mishra
) - addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json PRE-CREATION Diff: https://reviews.apache.org/r/71922/diff/4/ Changes: https://reviews.apache.org/r/71922/diff/3-4/ Testing --- Thanks, Sidharth Mishra

Re: Review Request 71922: ATLAS-3564: New version of AWS S3 model addition

2020-01-10 Thread Sidharth Mishra
the reason we have this at both the places. Only this and tag is common property among object and bucket. Do you think extracting these two to another basetype will make sense? > On Jan. 10, 2020, 6:26 p.m., Ashutosh Mestry wrote: > > addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json > > Lines 238 (patched) > > <https://reviews.apache.org/r/7

Re: Review Request 71922: ATLAS-3564: New version of AWS S3 model addition

2020-01-08 Thread Sidharth Mishra
) - addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json PRE-CREATION Diff: https://reviews.apache.org/r/71922/diff/3/ Changes: https://reviews.apache.org/r/71922/diff/2-3/ Testing --- Thanks, Sidharth Mishra

Re: Review Request 71922: ATLAS-3564: New version of AWS S3 model addition

2020-01-08 Thread Sidharth Mishra
- addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json PRE-CREATION Diff: https://reviews.apache.org/r/71922/diff/1/ Testing --- Thanks, Sidharth Mishra

Re: Review Request 71922: ATLAS-3564: New version of AWS S3 model addition

2020-01-08 Thread Sidharth Mishra
) - addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json PRE-CREATION Diff: https://reviews.apache.org/r/71922/diff/2/ Changes: https://reviews.apache.org/r/71922/diff/1-2/ Testing --- Thanks, Sidharth Mishra

Review Request 71922: ATLAS-3564: New version of AWS S3 model addition

2019-12-17 Thread Sidharth Mishra
://reviews.apache.org/r/71922/diff/1/ Testing --- Thanks, Sidharth Mishra

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2019-12-10 Thread Sidharth Mishra
IT has been added to test functionality like: 1. Atlas Audit entry save and retrive 2. Atlas Purge Audit store, retrive and search (UT and IT) Thanks, Sidharth Mishra

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2019-12-10 Thread Sidharth Mishra
IT has been added to test functionality like: 1. Atlas Audit entry save and retrive 2. Atlas Purge Audit store, retrive and search (UT and IT) Thanks, Sidharth Mishra

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2019-12-10 Thread Sidharth Mishra
IT has been added to test functionality like: 1. Atlas Audit entry save and retrive 2. Atlas Purge Audit store, retrive and search (UT and IT) Thanks, Sidharth Mishra

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2019-12-09 Thread Sidharth Mishra
IT has been added to test functionality like: 1. Atlas Audit entry save and retrive 2. Atlas Purge Audit store, retrive and search (UT and IT) Thanks, Sidharth Mishra

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2019-12-04 Thread Sidharth Mishra
store, retrive and search (UT and IT) Thanks, Sidharth Mishra

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2019-12-04 Thread Sidharth Mishra
> > then audit them. I think its better to audit admin action purge even if we don't purge any entities. Please let me know if you still think we should not audit the unsuccessful purge action by admin. - Sidharth ------

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2019-12-04 Thread Sidharth Mishra
AtlasEntityStore. So AtlasEntityStore can't depends on AtlasAuditService again. KIndly suggest is there any other option to avoid this circular injection issue. - Sidharth --- This is an automatically generated e-mail. To

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2019-12-04 Thread Sidharth Mishra
to test functionality like: 1. Atlas Audit entry save and retrive 2. Atlas Purge Audit store, retrive and search (UT and IT) Thanks, Sidharth Mishra

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2019-12-04 Thread Sidharth Mishra
on DataAccess and DataAccess depends on AtlasEntityStore. So AtlasEntityStore can't depends on AtlasAuditService again. - Sidharth --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.or

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2019-12-04 Thread Sidharth Mishra
to test functionality like: 1. Atlas Audit entry save and retrive 2. Atlas Purge Audit store, retrive and search (UT and IT) Thanks, Sidharth Mishra

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2019-12-03 Thread Sidharth Mishra
n automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71791/#review218865 --- On Nov. 30, 2019, 7:44 p.m., Sidharth Mishra wrote: > > --- > This is

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2019-12-03 Thread Sidharth Mishra
9/. I am having separate patch for the lib version change and reverted the changes - Sidharth --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71791/#review218808 --------

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2019-12-03 Thread Sidharth Mishra
- Sidharth --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71791/#review218808 --- On Nov. 30, 2019, 7:44 p.m., Sidharth Mishra wrote

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2019-11-30 Thread Sidharth Mishra
store, retrive and search (UT and IT) Thanks, Sidharth Mishra

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2019-11-30 Thread Sidharth Mishra
, visit: https://reviews.apache.org/r/71791/#review218785 ------- On Nov. 26, 2019, 9:11 a.m., Sidharth Mishra wrote: > > --- > This is an automatically gener

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2019-11-26 Thread Sidharth Mishra
: https://reviews.apache.org/r/71791/diff/4/ Changes: https://reviews.apache.org/r/71791/diff/3-4/ Testing --- Two UT and one IT has been added to test functionality like: 1. Atlas Audit entry save and retrive 2. Atlas Purge Audit store, retrive and search (UT and IT) Thanks, Sidharth Mishra

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2019-11-21 Thread Sidharth Mishra
://reviews.apache.org/r/71791/diff/3/ Changes: https://reviews.apache.org/r/71791/diff/2-3/ Testing --- Two UT and one IT has been added to test functionality like: 1. Atlas Audit entry save and retrive 2. Atlas Purge Audit store, retrive and search (UT and IT) Thanks, Sidharth Mishra

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2019-11-19 Thread Sidharth Mishra
://reviews.apache.org/r/71791/diff/2/ Changes: https://reviews.apache.org/r/71791/diff/1-2/ Testing --- Two UT and one IT has been added to test functionality like: 1. Atlas Audit entry save and retrive 2. Atlas Purge Audit store, retrive and search (UT and IT) Thanks, Sidharth Mishra

Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2019-11-19 Thread Sidharth Mishra
and one IT has been added to test functionality like: 1. Atlas Audit entry save and retrive 2. Atlas Purge Audit store, retrive and search (UT and IT) Thanks, Sidharth Mishra

Re: Review Request 71737: ATLAS-3477: Introduce purging of entity in Atlas

2019-11-14 Thread Sidharth Mishra
e485> > > > > should this be AtlasPrivilege.ADMIN_PURGE ? > > Sidharth Mishra wrote: > As we don't have the Ranger changes for time being its ADMIN_IMPORT. > Later ll change it to ADMIN_PURGE To track

Re: Review Request 71737: ATLAS-3477: Introduce purging of entity in Atlas

2019-11-14 Thread Sidharth Mishra
1573161727305:0", "entity": null, "type": null }, { "entityId": "7b6806c1-8daf-4e0f-8d10-672a192968f1", "timestamp": 1573161723180, "user": "impala", "action": &qu

Re: Review Request 71737: ATLAS-3477: Introduce purging of entity in Atlas

2019-11-14 Thread Sidharth Mishra
s is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71737/#review218627 --- On Nov. 13, 2019, 9:04 p.m., Sidharth Mishra wrote: > > --- >

Re: Review Request 71737: ATLAS-3477: Introduce purging of entity in Atlas

2019-11-14 Thread Sidharth Mishra
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71737/#review218626 --- On Nov. 13, 2019, 9:04 p.m., Sidharth Mishra wrote: > >

Re: Review Request 71737: ATLAS-3477: Introduce purging of entity in Atlas

2019-11-13 Thread Sidharth Mishra
sit: https://reviews.apache.org/r/71737/#review218622 --- On Nov. 13, 2019, 6:04 a.m., Sidharth Mishra wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 71737: ATLAS-3477: Introduce purging of entity in Atlas

2019-11-12 Thread Sidharth Mishra
1573161727305:0", "entity": null, "type": null }, { "entityId": "7b6806c1-8daf-4e0f-8d10-672a192968f1", "timestamp": 1573161723180, "user": "impala", "action": &qu

Re: Review Request 71737: ATLAS-3477: Introduce purging of entity in Atlas

2019-11-12 Thread Sidharth Mishra
": "ENTITY_CREATE", "details": "Created: {\"typeName\":\"hive_column\",\"attributes\":{\"owner\":\"admin\",\"qualifiedName\":\"default.thursday_07_11_5.id@cm\",\"name\":\"id\",\"comment\":null,\"position\":0,\"type\":\"int\"},\"guid\":\"7b6806c1-8daf-4e0f-8d10-672a192968f1\",\"isIncomplete\":false,\"provenanceType\":0,\"version\":0,\"relationshipAttributes\":{\"table\":{\"guid\":\"c5ae4503-b498-493c-86b5-d8d909c6b16a\",\"typeName\":\"hive_table\",\"uniqueAttributes\":{\"qualifiedName\":\"default.thursday_07_11_5@cm\"},\"relationshipType\":\"hive_table_columns\"}},\"proxy\":false}", "eventKey": "7b6806c1-8daf-4e0f-8d10-672a192968f1:1573161723180:2", "entity": null, "type": null } ] Thanks, Sidharth Mishra

Re: Review Request 71737: ATLAS-3477: Introduce purging of entity in Atlas

2019-11-12 Thread Sidharth Mishra
quot;impala", "action": "ENTITY_CREATE", "details": "Created: {\"typeName\":\"hive_column\",\"attributes\":{\"owner\":\"admin\",\"qualifiedName\":\"default.thursday_07_11_5.id@cm\",\"name\":\"id\",\"comment\":null,\"position\":0,\"type\":\"int\"},\"guid\":\"7b6806c1-8daf-4e0f-8d10-672a192968f1\",\"isIncomplete\":false,\"provenanceType\":0,\"version\":0,\"relationshipAttributes\":{\"table\":{\"guid\":\"c5ae4503-b498-493c-86b5-d8d909c6b16a\",\"typeName\":\"hive_table\",\"uniqueAttributes\":{\"qualifiedName\":\"default.thursday_07_11_5@cm\"},\"relationshipType\":\"hive_table_columns\"}},\"proxy\":false}", "eventKey": "7b6806c1-8daf-4e0f-8d10-672a192968f1:1573161723180:2", "entity": null, "type": null } ] Thanks, Sidharth Mishra

Re: Review Request 71737: ATLAS-3477: Introduce purging of entity in Atlas

2019-11-12 Thread Sidharth Mishra
omatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71737/#review218585 --- On Nov. 7, 2019, 11:54 p.m., Sidharth Mishra wrote: > > --- > This is

Review Request 71737: ATLAS-3477: Introduce purging of entity in Atlas

2019-11-07 Thread Sidharth Mishra
": "ENTITY_CREATE", "details": "Created: {\"typeName\":\"hive_column\",\"attributes\":{\"owner\":\"admin\",\"qualifiedName\":\"default.thursday_07_11_5.id@cm\",\"name\":\"id\",\"comment\":null,\"position\":0,\"type\":\"int\"},\"guid\":\"7b6806c1-8daf-4e0f-8d10-672a192968f1\",\"isIncomplete\":false,\"provenanceType\":0,\"version\":0,\"relationshipAttributes\":{\"table\":{\"guid\":\"c5ae4503-b498-493c-86b5-d8d909c6b16a\",\"typeName\":\"hive_table\",\"uniqueAttributes\":{\"qualifiedName\":\"default.thursday_07_11_5@cm\"},\"relationshipType\":\"hive_table_columns\"}},\"proxy\":false}", "eventKey": "7b6806c1-8daf-4e0f-8d10-672a192968f1:1573161723180:2", "entity": null, "type": null } ] Thanks, Sidharth Mishra

Re: Review Request 71620: ATLAS-3461: Impala process and lineage is not getting created appropriately if query contains variation like comment or extra spaces

2019-10-21 Thread Sidharth Mishra
STORED AS TEXTFILE LOCATION '/warehouse/tablespace/external/hive/db1.db/thusday_ext1'; Thanks, Sidharth Mishra

Re: Review Request 71620: ATLAS-3461: Impala process and lineage is not getting created appropriately if query contains variation like comment or extra spaces

2019-10-21 Thread Sidharth Mishra
d match and even if it has multiple spaces it ll be taken care by [ ]* at beginning. Thanks, Sid - Sidharth --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71620/#review218312 -

Re: Review Request 71620: ATLAS-3461: Impala process and lineage is not getting created appropriately if query contains variation like comment or extra spaces

2019-10-21 Thread Sidharth Mishra
STORED AS TEXTFILE LOCATION '/warehouse/tablespace/external/hive/db1.db/thusday_ext1'; Thanks, Sidharth Mishra

Re: Review Request 71620: ATLAS-3461: Impala process and lineage is not getting created appropriately if query contains variation like comment or extra spaces

2019-10-21 Thread Sidharth Mishra
AME string ) ROW FORMAT DELIMITED FIELDS TERMINATED BY ',' STORED AS TEXTFILE LOCATION '/warehouse/tablespace/external/hive/db1.db/thusday_ext1'; Thanks, Sidharth Mishra

Re: Review Request 71620: ATLAS-3461: Impala process and lineage is not getting created appropriately if query contains variation like comment or extra spaces

2019-10-21 Thread Sidharth Mishra
TERMINATED BY ',' STORED AS TEXTFILE LOCATION '/warehouse/tablespace/external/hive/db1.db/thusday_ext1'; Thanks, Sidharth Mishra

Review Request 71620: ATLAS-3461: Impala process and lineage is not getting created appropriately if query contains variation like comment or extra spaces

2019-10-15 Thread Sidharth Mishra
daysecond1'; Thanks, Sidharth Mishra

Re: Request for adding me to contributor list

2019-09-27 Thread sidharth mishra
> > > On 9/24/19, 8:52 PM, "sidharth mishra" wrote: > > Hi All, > > I would like to contribute to Apache Atlas. Kindly add me to the > contributor list. > My git id is: sidharthkmishra > Email ID: sidharthkmis...@gmail.com > >

Request for adding me to contributor list

2019-09-24 Thread sidharth mishra
Hi All, I would like to contribute to Apache Atlas. Kindly add me to the contributor list. My git id is: sidharthkmishra Email ID: sidharthkmis...@gmail.com Kindly let me know if you have any questions or concerns. Regards, Sid

<    1   2   3