Re: Review Request 72902: ATLAS-3875: Introduce python client for Atlas (updated patch from https://reviews.apache.org/r/72730/)

2020-10-13 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72902/#review222041 --- Ship it! Ship It! - Madhan Neethiraj On Oct. 13, 2020,

Re: Review Request 72902: ATLAS-3875: Introduce python client for Atlas (updated patch from https://reviews.apache.org/r/72730/)

2020-10-13 Thread Sarath Subramanian
> On Oct. 12, 2020, 1:01 a.m., Madhan Neethiraj wrote: > > intg/src/main/python/apache_atlas/base_client.py > > Lines 46 (patched) > > > > > > If kerberos is not handled currently, consider adding in a subsequent >

Re: Review Request 72902: ATLAS-3875: Introduce python client for Atlas (updated patch from https://reviews.apache.org/r/72730/)

2020-10-13 Thread Sarath Subramanian
> On Oct. 12, 2020, 1:01 a.m., Madhan Neethiraj wrote: > > intg/src/main/python/apache_atlas/model/typedef.py > > Lines 58 (patched) > > > > > > Should category be constructor parameter in AtlasEnumDef, given the >

Re: Review Request 72902: ATLAS-3875: Introduce python client for Atlas (updated patch from https://reviews.apache.org/r/72730/)

2020-10-13 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72902/ --- (Updated Oct. 13, 2020, 3:05 p.m.) Review request for atlas, Ashutosh Mestry

Re: Review Request 72902: ATLAS-3875: Introduce python client for Atlas (updated patch from https://reviews.apache.org/r/72730/)

2020-10-12 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72902/#review222014 --- intg/src/main/python/apache_atlas/base_client.py Lines 46

Re: Review Request 72902: ATLAS-3875: Introduce python client for Atlas (updated patch from https://reviews.apache.org/r/72730/)

2020-10-12 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72902/ --- (Updated Oct. 12, 2020, 12:12 a.m.) Review request for atlas, Ashutosh Mestry

Re: Review Request 72902: ATLAS-3875: Introduce python client for Atlas (updated patch from https://reviews.apache.org/r/72730/)

2020-10-07 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72902/#review221999 --- Fix it, then Ship it! Looks good Sarath!