Re: Review Request 73029: ATLAS-4036, ATLAS-4037, Fix for empty Users and Client Id field in Admin Audit

2020-11-23 Thread Deep Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73029/ --- (Updated Nov. 23, 2020, 10:15 p.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 73029: ATLAS-4036, ATLAS-4037, Fix for empty Users and Client Id field in Admin Audit

2020-11-23 Thread Madhan Neethiraj
> On Nov. 20, 2020, 8:04 p.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java > > Lines 77 (patched) > > > > > > clientId => clientIp > > Deep Singh

Re: Review Request 73029: ATLAS-4036, ATLAS-4037, Fix for empty Users and Client Id field in Admin Audit

2020-11-23 Thread Deep Singh
> On Nov. 20, 2020, 8:04 p.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java > > Lines 77 (patched) > > > > > > clientId => clientIp Madhan, Variable

Re: Review Request 73029: ATLAS-4036, ATLAS-4037, Fix for empty Users and Client Id field in Admin Audit

2020-11-22 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73029/#review25 --- Ship it! Ship It! - Sarath Subramanian On Nov. 20, 2020,

Re: Review Request 73029: ATLAS-4036, ATLAS-4037, Fix for empty Users and Client Id field in Admin Audit

2020-11-20 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73029/#review20 --- Fix it, then Ship it!

Re: Review Request 73029: ATLAS-4036, ATLAS-4037, Fix for empty Users and Client Id field in Admin Audit

2020-11-20 Thread Mandar Ambawane
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73029/#review19 --- Ship it! Ship It! - Mandar Ambawane On Nov. 20, 2020, 4:05

Re: Review Request 73029: ATLAS-4036, ATLAS-4037, Fix for empty Users and Client Id field in Admin Audit

2020-11-20 Thread Deep Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73029/ --- (Updated Nov. 20, 2020, 4:05 p.m.) Review request for atlas, Ashutosh Mestry,

Re: Review Request 73029: ATLAS-4036, ATLAS-4037, Fix for empty Users and Client Id field in Admin Audit

2020-11-20 Thread Mandar Ambawane
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73029/#review17 ---

Review Request 73029: ATLAS-4036, ATLAS-4037, Fix for empty Users and Client Id field in Admin Audit

2020-11-19 Thread Deep Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73029/ --- Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Mandar Ambawane,