date:20170630

Re: Review Request 60528: UI : Search using entity and trait attributes

2017-06-30 Thread keval bhatt


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60528/
---

(Updated June 30, 2017, 8:22 a.m.)


Review request for atlas, Apoorv Naik, Madhan Neethiraj, Nixon Rodrigues, and 
Sarath Subramanian.


Changes
---

Missing licenses added


Bugs: ATLAS-1894
https://issues.apache.org/jira/browse/ATLAS-1894


Repository: atlas


Description
---

In basic search user can search based on attribute condition.


Diffs (updated)
-

  3party-licenses/bootstrap-datepicker-LICENSE 3fd94fa 
  3party-licenses/bootstrap-daterangepicker-LICENSE PRE-CREATION 
  3party-licenses/jQuery-QueryBuilder-LICENSE PRE-CREATION 
  LICENSE 9722907 
  dashboardv2/gruntfile.js cf076b6 
  dashboardv2/package.json 8924f71 
  dashboardv2/public/css/scss/form.scss 3ee94f5 
  dashboardv2/public/css/scss/override.scss 2852f80 
  dashboardv2/public/css/scss/search.scss 8c3dbec 
  dashboardv2/public/index.html 5fff304 
  dashboardv2/public/js/collection/VSearchList.js 6a84943 
  dashboardv2/public/js/collection/VTagList.js 9304858 
  dashboardv2/public/js/external_lib/datetimepicker/bootstrap-datetimepicker.js 
bb930fb 
  
dashboardv2/public/js/external_lib/datetimepicker/bootstrap-datetimepicker.min.css
 e9ec816 
  dashboardv2/public/js/main.js 3b40451 
  dashboardv2/public/js/models/VSearch.js 5c3df97 
  dashboardv2/public/js/models/VTag.js c875d5a 
  dashboardv2/public/js/router/Router.js f1250e7 
  dashboardv2/public/js/templates/search/QueryBuilder_tmpl.html PRE-CREATION 
  dashboardv2/public/js/templates/search/SearchLayoutView_tmpl.html a766cdf 
  dashboardv2/public/js/templates/search/SearchQuery_tmpl.html PRE-CREATION 
  dashboardv2/public/js/templates/search/SearchResultLayoutView_tmpl.html 
91f1a67 
  dashboardv2/public/js/templates/tag/AddTagAttributeView_tmpl.html a7f9146 
  dashboardv2/public/js/templates/tag/createTagLayoutView_tmpl.html 0491c78 
  dashboardv2/public/js/utils/Overrides.js b6fc17c 
  dashboardv2/public/js/utils/UrlLinks.js c692d8d 
  dashboardv2/public/js/utils/Utils.js 1d614a8 
  dashboardv2/public/js/views/business_catalog/SideNavLayoutView.js af18540 
  dashboardv2/public/js/views/entity/CreateEntityLayoutView.js 704062f 
  dashboardv2/public/js/views/search/QueryBuilderView.js PRE-CREATION 
  dashboardv2/public/js/views/search/SearchDetailLayoutView.js b22fae8 
  dashboardv2/public/js/views/search/SearchLayoutView.js 32b82d7 
  dashboardv2/public/js/views/search/SearchQueryView.js PRE-CREATION 
  dashboardv2/public/js/views/search/SearchResultLayoutView.js 1198809 
  dashboardv2/public/js/views/tag/TagDetailLayoutView.js 3bb27c3 
  dashboardv2/public/js/views/tag/TagLayoutView.js a5b5665 


Diff: https://reviews.apache.org/r/60528/diff/2/

Changes: https://reviews.apache.org/r/60528/diff/1-2/


Testing
---

Performed one round of sanity testing and UI is working fine


Thanks,

keval bhatt

[jira] [Updated] (ATLAS-1894) UI : Search using entity and trait attributes

2017-06-30 Thread Keval Bhatt (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-1894:
---
Attachment: ATLAS-1894.3.patch

> UI : Search using entity and trait attributes
> -
>
> Key: ATLAS-1894
> URL: https://issues.apache.org/jira/browse/ATLAS-1894
> Project: Atlas
>  Issue Type: Bug
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
> Attachments: ATLAS-1894.1.patch, ATLAS-1894.2.patch, 
> ATLAS-1894.3.patch, ATLAS-1894.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Review Request 60159: ATLAS-1880: Search using entity/trait attributes

2017-06-30 Thread Madhan Neethiraj


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60159/#review179336
---


Ship it!




Ship It!

- Madhan Neethiraj


On June 30, 2017, 6:27 a.m., Apoorv Naik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60159/
> ---
> 
> (Updated June 30, 2017, 6:27 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath 
> Subramanian, and Suma Shivaprasad.
> 
> 
> Bugs: ATLAS-1880
> https://issues.apache.org/jira/browse/ATLAS-1880
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> See JIRA
> 
> 
> Sample Request structure
> 
> ```json
> {
>   "typeName": "hive_table",
>   "excludeDeletedEntities": false,
>   "limit": 25,
>   "offset": 0,
>   "entityFilters": {
>   "condition": "AND",
>   "criterion": [{
>   "attributeName": "retention",
>   "operator": "=",
>   "attributeValue": "10"
>   }, {
>   "condition": "OR",
>   "criterion": [{
>   "attributeName": "createTime",
>   "operator": ">",
>   "attributeValue": "11"
>   }, {
>   "attributeName": "lastAccessTime",
>   "operator": "<=",
>   "attributeValue": "22"
>   }]
>   }]
>   }
> }
> ```
> 
> 
> Diffs
> -
> 
>   client/src/main/java/org/apache/atlas/AtlasClientV2.java 61413428 
>   common/src/main/java/org/apache/atlas/repository/Constants.java ac022528 
>   distro/src/conf/atlas-log4j.xml e6c0d9f6 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphQuery.java
>  841edf71 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasIndexQuery.java
>  1ff9d5ed 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasVertexQuery.java
>  53f490f5 
>   
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/NativeTitanGraphQuery.java
>  0211ff05 
>   
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/TitanGraphQuery.java
>  0077a21f 
>   
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/expr/AndCondition.java
>  68f0eb28 
>   
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/expr/HasPredicate.java
>  24e4f5bc 
>   
> graphdb/titan0/src/main/java/com/thinkaurelius/titan/graphdb/query/graph/GraphCentricQueryBuilder.java
>  54ff7cb7 
>   
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0IndexQuery.java
>  1ed1734f 
>   
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/Titan0VertexQuery.java
>  bd8b897f 
>   
> graphdb/titan0/src/main/java/org/apache/atlas/repository/graphdb/titan0/query/NativeTitan0GraphQuery.java
>  7ec6ffeb 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1IndexQuery.java
>  4073dd2a 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/Titan1VertexQuery.java
>  4452bcdd 
>   
> graphdb/titan1/src/main/java/org/apache/atlas/repository/graphdb/titan1/query/NativeTitan1GraphQuery.java
>  1ca900d8 
>   intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java 
> a402c628 
>   intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java 
> PRE-CREATION 
>   intg/src/main/java/org/apache/atlas/model/impexp/AtlasImportRequest.java 
> 21b64273 
>   
> repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java
>  923a198b 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  128cdbf9 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityLineageService.java 
> b07091a0 
>   repository/src/main/java/org/apache/atlas/discovery/GremlinStep.java 
> PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/discovery/SearchPipeline.java 
> PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/discovery/SolrStep.java 
> PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
>  35dbf6c4 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ImportService.java
>  3411f8de 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java
>  42bd58fb 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphRetriever.java
>  9a8695af 
>   repository/src/main/java/org/apache/atlas/util/SearchTracker

Re: Review Request 60528: UI : Search using entity and trait attributes

2017-06-30 Thread Madhan Neethiraj


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60528/#review179338
---


Ship it!




Ship It!

- Madhan Neethiraj


On June 30, 2017, 8:22 a.m., keval bhatt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60528/
> ---
> 
> (Updated June 30, 2017, 8:22 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, Nixon Rodrigues, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-1894
> https://issues.apache.org/jira/browse/ATLAS-1894
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> In basic search user can search based on attribute condition.
> 
> 
> Diffs
> -
> 
>   3party-licenses/bootstrap-datepicker-LICENSE 3fd94fa 
>   3party-licenses/bootstrap-daterangepicker-LICENSE PRE-CREATION 
>   3party-licenses/jQuery-QueryBuilder-LICENSE PRE-CREATION 
>   LICENSE 9722907 
>   dashboardv2/gruntfile.js cf076b6 
>   dashboardv2/package.json 8924f71 
>   dashboardv2/public/css/scss/form.scss 3ee94f5 
>   dashboardv2/public/css/scss/override.scss 2852f80 
>   dashboardv2/public/css/scss/search.scss 8c3dbec 
>   dashboardv2/public/index.html 5fff304 
>   dashboardv2/public/js/collection/VSearchList.js 6a84943 
>   dashboardv2/public/js/collection/VTagList.js 9304858 
>   
> dashboardv2/public/js/external_lib/datetimepicker/bootstrap-datetimepicker.js 
> bb930fb 
>   
> dashboardv2/public/js/external_lib/datetimepicker/bootstrap-datetimepicker.min.css
>  e9ec816 
>   dashboardv2/public/js/main.js 3b40451 
>   dashboardv2/public/js/models/VSearch.js 5c3df97 
>   dashboardv2/public/js/models/VTag.js c875d5a 
>   dashboardv2/public/js/router/Router.js f1250e7 
>   dashboardv2/public/js/templates/search/QueryBuilder_tmpl.html PRE-CREATION 
>   dashboardv2/public/js/templates/search/SearchLayoutView_tmpl.html a766cdf 
>   dashboardv2/public/js/templates/search/SearchQuery_tmpl.html PRE-CREATION 
>   dashboardv2/public/js/templates/search/SearchResultLayoutView_tmpl.html 
> 91f1a67 
>   dashboardv2/public/js/templates/tag/AddTagAttributeView_tmpl.html a7f9146 
>   dashboardv2/public/js/templates/tag/createTagLayoutView_tmpl.html 0491c78 
>   dashboardv2/public/js/utils/Overrides.js b6fc17c 
>   dashboardv2/public/js/utils/UrlLinks.js c692d8d 
>   dashboardv2/public/js/utils/Utils.js 1d614a8 
>   dashboardv2/public/js/views/business_catalog/SideNavLayoutView.js af18540 
>   dashboardv2/public/js/views/entity/CreateEntityLayoutView.js 704062f 
>   dashboardv2/public/js/views/search/QueryBuilderView.js PRE-CREATION 
>   dashboardv2/public/js/views/search/SearchDetailLayoutView.js b22fae8 
>   dashboardv2/public/js/views/search/SearchLayoutView.js 32b82d7 
>   dashboardv2/public/js/views/search/SearchQueryView.js PRE-CREATION 
>   dashboardv2/public/js/views/search/SearchResultLayoutView.js 1198809 
>   dashboardv2/public/js/views/tag/TagDetailLayoutView.js 3bb27c3 
>   dashboardv2/public/js/views/tag/TagLayoutView.js a5b5665 
> 
> 
> Diff: https://reviews.apache.org/r/60528/diff/2/
> 
> 
> Testing
> ---
> 
> Performed one round of sanity testing and UI is working fine
> 
> 
> Thanks,
> 
> keval bhatt
> 
>

[jira] [Updated] (ATLAS-1896) Add Cross Origin [CORS] headers for Atlas

2017-06-30 Thread Ruchi Solani (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ruchi Solani updated ATLAS-1896:

Attachment: ATLAS-1896.patch

Here is a fix for these issue

> Add Cross Origin [CORS] headers for Atlas 
> --
>
> Key: ATLAS-1896
> URL: https://issues.apache.org/jira/browse/ATLAS-1896
> Project: Atlas
>  Issue Type: Bug
>Reporter: Nixon Rodrigues
>Assignee: Ruchi Solani
> Attachments: ATLAS-1896.patch
>
>
> Add Cross Origin [CORS] headers for Atlas, make it configurable from 
> atlas-application properties   



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Build failed in Jenkins: apache-atlas-nightly #788

2017-06-30 Thread Apache Jenkins Server

See 


Changes:

[madhan] ATLAS-1880: search API with support for entity/tag attribute filters

[madhan] ATLAS-1894: Search using entity/tag attribute filters

--
[...truncated 542.63 KB...]
127.0.0.1 - - [30/Jun/2017:10:22:21 +] "POST /api/atlas/types HTTP/1.1" 201 
- "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:21 +] "POST 
/api/atlas/entities/ca0199ba-f6a4-46fe-aa77-9564ec611fa2/traits HTTP/1.1" 201 - 
"-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:21 +] "GET 
/api/atlas/entities/ca0199ba-f6a4-46fe-aa77-9564ec611fa2/traitDefinitions/PII_Traitsh3nc2oMid
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:21 +] "GET 
/api/atlas/entities/ca0199ba-f6a4-46fe-aa77-9564ec611fa2/traitDefinitions 
HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:21 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:21 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:21 +] "GET 
/api/atlas/entities/5304959d-91ca-4b85-bc5f-60a5d22ad7e4/traits HTTP/1.1" 200 - 
"-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:21 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:21 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:21 +] "POST 
/api/atlas/entities/731194bb-1cbf-44e9-945f-273da162b97f HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:21 +] "GET 
/api/atlas/entities/731194bb-1cbf-44e9-945f-273da162b97f HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:21 +] "POST 
/api/atlas/entities/qualifiedName?type=hive_table&property=qualifiedName&value=tableqLy64iRvrt
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:22 +] "GET 
/api/atlas/entities/731194bb-1cbf-44e9-945f-273da162b97f HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:22 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:22 +] "GET 
/api/atlas/entities/aa389e50-ff98-485c-89f0-6edb6dce5a04/audit?count=10 
HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:22 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:22 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:22 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:22 +] "POST /api/atlas/entities HTTP/1.1" 
400 - "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:22 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:22 +] "GET 
/api/atlas/v2/types/typedef/name/qtBaZsODA1 HTTP/1.1" 404 - "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:22 +] "POST /api/atlas/types HTTP/1.1" 201 
- "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:22 +] "POST /api/atlas/entities HTTP/1.1" 
201 - "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:22 +] "GET 
/api/atlas/entities/3fdf7beb-85b6-4b02-a4e6-b27f8954795b HTTP/1.1" 200 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:22 +] "GET 
/api/atlas/v2/entity/guid/d3b752ef-2923-4315-a86b-2e154ee4c7dc HTTP/1.1" 200 - 
"-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:22 +] "POST /api/atlas/v2/entity/ 
HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:23 +] "POST 
/api/atlas/v2/entity/guid/random/classifications HTTP/1.1" 404 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:23 +] "POST /api/atlas/v2/entity/bulk/ 
HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:23 +] "POST /api/atlas/v2/entity/ 
HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:23 +] "POST /api/atlas/v2/entity/ 
HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:23 +] "DELETE 
/api/atlas/v2/entity/bulk/?guid=41e51fdd-065e-43cf-853b-aefc818f7b65&guid=43157ad5-ccfe-4116-8070-3e88debaf971
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:23 +] "POST /api/atlas/v2/entity/ 
HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:23 +] "DELETE 
/api/atlas/v2/entity/uniqueAttribute/type/hive_db_v2?attr:name=dbcClyg9eFJG%EF%A0%AE%E6%82%BD%E4%8D%A5%E6%AF%9A%E1%BC%A1%EB%91%B8%E6%84%AA%E6%B2%B8%E5%A2%A8%E5%BE%81
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:23 +] "DELETE 
/api/atlas/v2/entity/guid/random/classification/blah_trait HTTP/1.1" 400 - "-" 
"Java/1.7.0_80"
127.0.0.1 - - [30/Jun/2017:10:22:23 +] "GET 
/api/atlas/discovery/search/dsl?query=hive_db_v2+where+name%3D'dbcClyg9eFJG'&limit=10&offset=0
 HTTP/1.1" 200 - "-" "Java/1.7.0_80"
127.0.0.1 - -

[GitHub] incubator-atlas pull request #36: [ATLAS-1875] Adding the gremlin id for a v...

2017-06-30 Thread cmar81

Github user cmar81 closed the pull request at:

https://github.com/apache/incubator-atlas/pull/36


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (ATLAS-1875) Gremlin id is no longer returned for vertices in gremlin query

2017-06-30 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/ATLAS-1875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16069921#comment-16069921
 ] 

ASF GitHub Bot commented on ATLAS-1875:
---

Github user cmar81 closed the pull request at:

https://github.com/apache/incubator-atlas/pull/36


> Gremlin id is no longer returned for vertices in gremlin query
> --
>
> Key: ATLAS-1875
> URL: https://issues.apache.org/jira/browse/ATLAS-1875
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: trunk, 0.8-incubating
>Reporter: Christian R
>  Labels: dsl, gremlin
> Fix For: 0.9-incubating, 0.8.1-incubating
>
>
> Hi, 
> while investigating a move from atlas 0.7 to 0.8 (HDP 2.5 to HDP2.6) our 
> tests fail on gremlin queries. It turns out that the returned entities in a 
> gremlin search in 0.8 does not include the 'id' attribute. 
> I've built commit a0bd93945cd45457bbf34a8cb819d4fa4ba72964 (0.8-rc1) on linux 
> using berkely and elasticearch to test with. 
> The query 
> :21000/api/atlas/discovery/search/gremlin?g.V.has('__type.name', 
> 'Infrastructure').collect()
> on our 0.7 cluster gives
> {code:json}
> {
> __type.name: "Infrastructure",
> __type.category: "CLASS",
> __type: "typeSystem",
> id: "16640"
> }{code}
> while the same query on my 0.8-rc1 installation gives 
> {code:javascript}
> {
> __type.name: "Infrastructure",
> __version: "1",
> __type.category: "CLASS",
> __type.version: "1.0",
> __modificationTimestamp: "1497448424134",
> __type: "typeSystem",
> __type.options: "null",
> __type.description: "Infrastructure",
> __guid: "77d07283-7622-4305-9c0c-09ac5aee86c8",
> __timestamp: "1497448424134"
> }
> {code}
> Certainly more information, but id is missing. 
> The very poor DSL performance (see  ATLAS-1868) and a need for advanced 
> queries led us to base our queries on gremlin. This has worked very well so 
> far. We include both edges and nodes in the result set and use the inVertex, 
> outVertex and label info on the edges to rebuild our tree on the client side.
> I also see that gremlin has disappeared from version two of the API. Since 
> addE and addV lets you insert into the graph I can see how exposing a full 
> gremlin endpoint might not be wanted. 
> As an example of the queries we run that I haven't been able to express in 
> the DSL is 
> {noformat}
> query = g.V.has('__guid','').copySplit(
>   _().out('track'), 
>   _().as('x')
>   .out('functions', 'component')
>   .loop('x'){true}{true}
>   .copySplit(
>   _(),
>   _().in('part_of'),
>   _().outE('functions', 
> 'component'),
>   _().inE('part_of')
>   )
>   .exhaustMerge.dedup
>   )
>   .exhaustMerge
> .collect()
> {noformat}
> this might not be a normal usecase. 
> edit to add: 
> I looked at GraphBackedDiscoveryService.java and notice that:
> 0.7:
> {code:java}
> else if (r instanceof TitanVertex) {
> Iterable ps = ((TitanVertex) 
> r).getProperties();
> for (TitanProperty tP : ps) {
> String pName = tP.getPropertyKey().getName();
> Object pValue = ((TitanVertex) r).getProperty(pName);
> if (pValue != null) {
> oRow.put(pName, pValue.toString());
> }
> }
> {code}
> Vs 0.8 code: 
> {code:java}
> else if (value instanceof AtlasVertex) {
> AtlasVertex vertex = (AtlasVertex)value;
> for (String key : vertex.getPropertyKeys()) {
> Object propertyValue = 
> GraphHelper.getProperty(vertex,  key);
> if (propertyValue != null) {
> oRow.put(key, propertyValue.toString());
> }
> }
> {code}
> look very similar. 
> However, 0.8 handles id in edges explicitly while the 0.7 doesn’t treat edges 
> explicitly at all.
> {code:java}
> else if(value instanceof AtlasEdge) {
> AtlasEdge edge = (AtlasEdge) value;
> oRow.put("id", edge.getId().toString());
> oRow.put("label", edge.getLabel());
> oRow.put("inVertex", 
> edge.getInVertex().getId().toString());
> oRow.put("outVertex", 
> edge.getOutVertex().getId().toString());
> for (String propertyK

[jira] [Resolved] (ATLAS-1888) UI - While Update Entity the data of type Long is not updating in entity from UI.

2017-06-30 Thread Keval Bhatt (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt resolved ATLAS-1888.

Resolution: Fixed

Committed to master 
(http://git-wip-us.apache.org/repos/asf/incubator-atlas/commit/9a4ed469)

> UI - While Update Entity the data of type Long is not updating in entity from 
> UI.
> -
>
> Key: ATLAS-1888
> URL: https://issues.apache.org/jira/browse/ATLAS-1888
> Project: Atlas
>  Issue Type: Bug
>Reporter: Kalyani Kashikar
>Assignee: Kalyani Kashikar
> Attachments: ATLAS-1888.patch
>
>
> Step to reproduce :-
> * Search for the Table.
> * Go to sales_fact_monthly_mv, and update CreateTime, LastAccessTime
> * Click on update button
> * CreateTime and LastAccessTime are not updating properly.
>  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (ATLAS-1896) Add Cross Origin [CORS] headers for Atlas

2017-06-30 Thread Ruchi Solani (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ruchi Solani updated ATLAS-1896:

Attachment: (was: ATLAS-1896.patch)

> Add Cross Origin [CORS] headers for Atlas 
> --
>
> Key: ATLAS-1896
> URL: https://issues.apache.org/jira/browse/ATLAS-1896
> Project: Atlas
>  Issue Type: Bug
>Reporter: Nixon Rodrigues
>Assignee: Ruchi Solani
>
> Add Cross Origin [CORS] headers for Atlas, make it configurable from 
> atlas-application properties   



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (ATLAS-1896) Add Cross Origin [CORS] headers for Atlas

2017-06-30 Thread Ruchi Solani (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ruchi Solani updated ATLAS-1896:

Attachment: ATLAS-1896.patch

> Add Cross Origin [CORS] headers for Atlas 
> --
>
> Key: ATLAS-1896
> URL: https://issues.apache.org/jira/browse/ATLAS-1896
> Project: Atlas
>  Issue Type: Bug
>Reporter: Nixon Rodrigues
>Assignee: Ruchi Solani
> Attachments: ATLAS-1896.patch
>
>
> Add Cross Origin [CORS] headers for Atlas, make it configurable from 
> atlas-application properties   



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (ATLAS-1896) Add Cross Origin [CORS] headers for Atlas

2017-06-30 Thread Ruchi Solani (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ruchi Solani updated ATLAS-1896:

Attachment: (was: ATLAS-1896.patch)

> Add Cross Origin [CORS] headers for Atlas 
> --
>
> Key: ATLAS-1896
> URL: https://issues.apache.org/jira/browse/ATLAS-1896
> Project: Atlas
>  Issue Type: Bug
>Reporter: Nixon Rodrigues
>Assignee: Ruchi Solani
>
> Add Cross Origin [CORS] headers for Atlas, make it configurable from 
> atlas-application properties   



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (ATLAS-1896) Add Cross Origin [CORS] headers for Atlas

2017-06-30 Thread Ruchi Solani (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ruchi Solani updated ATLAS-1896:

Attachment: ATLAS-1896.patch

> Add Cross Origin [CORS] headers for Atlas 
> --
>
> Key: ATLAS-1896
> URL: https://issues.apache.org/jira/browse/ATLAS-1896
> Project: Atlas
>  Issue Type: Bug
>Reporter: Nixon Rodrigues
>Assignee: Ruchi Solani
> Attachments: ATLAS-1896.patch
>
>
> Add Cross Origin [CORS] headers for Atlas, make it configurable from 
> atlas-application properties   



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ATLAS-1863) Set default value for primitive types attributes in entity based on attributeDef in Typedef

2017-06-30 Thread David Radley (JIRA)


[ 
https://issues.apache.org/jira/browse/ATLAS-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16070121#comment-16070121
 ] 

David Radley commented on ATLAS-1863:
-

I am not sure about this approach. 
- in principle I would have thought an optional attribute that is not specified 
means that it is not present and should not appear in a get. If we have a 
default value for an optional attribute - this is modelling in the style of an 
RDB schema, where all a tables columns are specified in the schema and need to 
exist in columns in the table, I would think we want to be looser than this. 
Json is flexible enough not to insist on attribute values being specified in 
the instances.
- if we add defaultvalue to attributeDef it should have a meaning for all 
attributeDefs, including those of type struc or enum. I think it would be 
unintuitive to have a default structure when it was optional. 

Can you share the use cases you are thinking of that drive the need for this 
change please?
 

> Set default value for primitive types attributes in entity based on 
> attributeDef in Typedef
> ---
>
> Key: ATLAS-1863
> URL: https://issues.apache.org/jira/browse/ATLAS-1863
> Project: Atlas
>  Issue Type: Improvement
>  Components: atlas-intg
>Reporter: Nixon Rodrigues
>Assignee: Ruchi Solani
>Priority: Critical
> Fix For: 0.9-incubating
>
> Attachments: ATLAS-1863.2.patch, ATLAS-1863.3.patch, ATLAS-1863.patch
>
>
> While creating entity if attribute value are not set explicitly for primitive 
> type which are optional, then default value should be set from attributedef.
> eg of typedef attributeDef
> {code}
> "attributeDefs": [{
>   "name": "sourceCode",
>   "typeName": "string",
>   "isOptional": true,
>   "cardinality": "SINGLE",
>   "valuesMinCount": 0,
>   "valuesMaxCount": 1,
>   "isUnique": false,
>   "isIndexable": true,
>   "defaultValue": "xyz"
>   }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (ATLAS-1906) Atlas client should support setting hadoop-jwt token in header

2017-06-30 Thread Hemanth Yamijala (JIRA)

Hemanth Yamijala created ATLAS-1906:
---

 Summary: Atlas client should support setting hadoop-jwt token in 
header
 Key: ATLAS-1906
 URL: https://issues.apache.org/jira/browse/ATLAS-1906
 Project: Atlas
  Issue Type: Bug
  Components:  atlas-core
Reporter: Hemanth Yamijala


In ATLAS-1767, support was added to make the Atlas REST API calls take a 
hadoop-jwt token coming from Knox SSO and authenticate the user.

This works perfectly when using a vanilla HTTP client. We have found it 
convenient to use the Atlas client Java binding for our work. However, it does 
not seem to support setting the hadoop-jwt token. Hence, we don't seem to be 
able to use it with a Knox SSO enabled Atlas server for API calls.

Could this support be added please?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (ATLAS-1907) Create RelationshipDefs for all base models and use the definitions in graph edges when creating entities

2017-06-30 Thread Sarath Subramanian (JIRA)

Sarath Subramanian created ATLAS-1907:
-

 Summary: Create RelationshipDefs for all base models and use the 
definitions in graph edges when creating entities
 Key: ATLAS-1907
 URL: https://issues.apache.org/jira/browse/ATLAS-1907
 Project: Atlas
  Issue Type: New Feature
  Components:  atlas-core
Affects Versions: trunk, 0.9-incubating, 0.8.1-incubating
Reporter: Sarath Subramanian
Assignee: Sarath Subramanian


Create relationshipDefs for all out of the box models. Use relationshipDef 
information when creating edges for composite attributes in entities.




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Updated] (ATLAS-1907) Create RelationshipDefs for all base models and use this definitions when creating edges for entities

2017-06-30 Thread Sarath Subramanian (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian updated ATLAS-1907:
--
Summary: Create RelationshipDefs for all base models and use this 
definitions when creating edges for entities  (was: Create RelationshipDefs for 
all base models and use the definitions in graph edges when creating entities)

> Create RelationshipDefs for all base models and use this definitions when 
> creating edges for entities
> -
>
> Key: ATLAS-1907
> URL: https://issues.apache.org/jira/browse/ATLAS-1907
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: trunk, 0.9-incubating, 0.8.1-incubating
>Reporter: Sarath Subramanian
>Assignee: Sarath Subramanian
>
> Create relationshipDefs for all out of the box models. Use relationshipDef 
> information when creating edges for composite attributes in entities.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Review Request 60578: [ATLA-1907]: Create RelationshipDefs for all base models and use this definitions when creating edges for entities

2017-06-30 Thread Sarath Subramanian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60578/
---

Review request for atlas, David Radley and Madhan Neethiraj.


Bugs: ATLAS-1907
https://issues.apache.org/jira/browse/ATLAS-1907


Repository: atlas


Description
---

Create relationshipDefs for all out of the box models. Use relationshipDef 
information when creating edges for composite attributes in entities.


Diffs
-

  addons/models/0010-base_model.json 7f64d85e 
  addons/models/0030-hive_model.json b359ea82 
  addons/models/0050-falcon_model.json b7398ef4 
  addons/models/0060-hbase_model.json 42fe00c4 
  addons/models/0080-storm_model.json 095936e0 
  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 49ead6e3 
  intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java 
8d2e7ec5 
  intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 70e3067a 
  intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java f85cf35c 
  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java c2e0be50 
  intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 29fae1c8 
  
repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java
 4530f51b 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java
 5ea4ff20 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java
 7b3f1e6e 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java
 86212338 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
 ebf6a201 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1Test.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/60578/diff/1/


Testing
---

Tested using Postman REST client.
Validated all hive_table creation works fine and lineage is rendered right.

UTs/ITs in progress.


Thanks,

Sarath Subramanian

[jira] [Updated] (ATLAS-1907) Create RelationshipDefs for all base models and use this definitions when creating edges for entities

2017-06-30 Thread Sarath Subramanian (JIRA)


 [ 
https://issues.apache.org/jira/browse/ATLAS-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian updated ATLAS-1907:
--
Attachment: ATLAS-1907.1.patch

> Create RelationshipDefs for all base models and use this definitions when 
> creating edges for entities
> -
>
> Key: ATLAS-1907
> URL: https://issues.apache.org/jira/browse/ATLAS-1907
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: trunk, 0.9-incubating, 0.8.1-incubating
>Reporter: Sarath Subramanian
>Assignee: Sarath Subramanian
> Attachments: ATLAS-1907.1.patch
>
>
> Create relationshipDefs for all out of the box models. Use relationshipDef 
> information when creating edges for composite attributes in entities.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (ATLAS-1879) Updating classification removes some properties

2017-06-30 Thread Madhan Neethiraj (JIRA)


[ 
https://issues.apache.org/jira/browse/ATLAS-1879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16070664#comment-16070664
 ] 

Madhan Neethiraj commented on ATLAS-1879:
-

bq. I understand the problem is the updateTypesDef method updates the 
TypeRegistry first, then the GraphStorage
[~bpgergo] - you are right. This is the source of the problem. However, 
updating TypeRegistry before GraphStorage is by design, as validations (like 
existence of referenced types, etc) are performed in this stage. If there are 
any failures in the validation, the call bails out without making any changes 
to the graph.

I think the simple fix you suggested (shown below) is good. This does have an 
overhead of resolving references the second time; but alternate solution could 
be more involved. I would suggest to go with this fix.

{code}
AtlasTypesDef ret = updateGraphStore(typesDef, ttr);

// add the following block to fix the issue
try {
ttr.updateTypes(ret);
} catch (AtlasBaseException e) { // this shouldn't happen, as the types were 
already validated
  LOG.error("failed to update the registry after updating the store", e);
}
{code}


> Updating classification removes some properties
> ---
>
> Key: ATLAS-1879
> URL: https://issues.apache.org/jira/browse/ATLAS-1879
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 0.8-incubating
>Reporter: Laura Ngo
> Attachments: Atlas-1789.postman_collection.json
>
>
> * Created classification via POST. 
> * Updated via PUT
> * Lost properties
> POST http://127.0.0.1:21000/api/atlas/v2/types/typedefs
> {code}
> {
>  "classificationDefs": [{
>   "name": "test_classification_11",
>   "description": "",
>   "createdBy" : "admin",
>   "superTypes": [],
>   "attributeDefs": [{
> "name" : "test_class_11",
> "typeName" : "string",
> "isOptional" : true,
> "isUnique" : true,
> "isIndexable" : true,
> "cardinality": "SINGLE",
> "valuesMinCount": 0,
> "valuesMaxCount": 1
> }]
>  }],
>  "entityDefs": [],
>  "enumDefs": [],
>  "structDefs": []
> }
> {code}
> GET 
> http://127.0.0.1:21000/api/atlas/v2/types/classification/name/test_classification_11
> {code}
> {
> "category": "CLASSIFICATION",
> "guid": "83162fe1-4bb4-4a87-b2b8-364e751a1265",
> "createdBy": "admin",
> "createTime": 1497485890857,
> "updateTime": 1497485890857,
> "version": 1,
> "name": "test_classification_11",
> "description": "",
> "typeVersion": "1.0",
> "attributeDefs": [
>   {
> "name": "test_class_11",
> "typeName": "string",
> "isOptional": true,
> "cardinality": "SINGLE",
> "valuesMinCount": 0,
> "valuesMaxCount": 1,
> "isUnique": true,
> "isIndexable": true
> }
> ],
> "superTypes": [],
> }
> {code}
> PUT http://127.0.0.1:21000/api/atlas/v2/types/typedefs
> Update attribute.
> GET 
> http://127.0.0.1:21000/api/atlas/v2/types/classification/name/test_classification_11
> {code}
> {
> "category": "CLASSIFICATION",
> "createdBy": "admin",
> "name": "test_classification_11",
> "description": "",
> "attributeDefs": [
>   {
> "name": "test_class_11",
> "typeName": "string",
> "isOptional": true,
> "cardinality": "SINGLE",
> "valuesMinCount": 0,
> "valuesMaxCount": 1,
> "isUnique": true,
> "isIndexable": false
> }
> ],
> "superTypes": [],
> }
> {code}
> Some properties are missing after PUT update of attribute "isIndexable"



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (ATLAS-1879) Updating classification removes some properties

2017-06-30 Thread Madhan Neethiraj (JIRA)


[ 
https://issues.apache.org/jira/browse/ATLAS-1879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16070664#comment-16070664
 ] 

Madhan Neethiraj edited comment on ATLAS-1879 at 6/30/17 8:31 PM:
--

bq. I understand the problem is the updateTypesDef method updates the 
TypeRegistry first, then the GraphStorage
[~bpgergo] - you are right. This is the source of the problem. However, 
updating TypeRegistry before GraphStorage is by design, as validations (like 
existence of referenced types, etc) are performed in this stage. If there are 
any failures in the validation, the call bails out without making any changes 
to the graph.

I think the simple fix you suggested (shown below) is good. This does have an 
overhead of resolving references the second time; but alternate solution could 
be more involved. I would suggest to go with this fix.

Also, this fix will address another issue reported by [~LauraNgo] - ATLAS-1895.

{code}
AtlasTypesDef ret = updateGraphStore(typesDef, ttr);

// add the following block to fix the issue
try {
ttr.updateTypes(ret);
} catch (AtlasBaseException e) { // this shouldn't happen, as the types were 
already validated
  LOG.error("failed to update the registry after updating the store", e);
}
{code}



was (Author: madhan.neethiraj):
bq. I understand the problem is the updateTypesDef method updates the 
TypeRegistry first, then the GraphStorage
[~bpgergo] - you are right. This is the source of the problem. However, 
updating TypeRegistry before GraphStorage is by design, as validations (like 
existence of referenced types, etc) are performed in this stage. If there are 
any failures in the validation, the call bails out without making any changes 
to the graph.

I think the simple fix you suggested (shown below) is good. This does have an 
overhead of resolving references the second time; but alternate solution could 
be more involved. I would suggest to go with this fix.

{code}
AtlasTypesDef ret = updateGraphStore(typesDef, ttr);

// add the following block to fix the issue
try {
ttr.updateTypes(ret);
} catch (AtlasBaseException e) { // this shouldn't happen, as the types were 
already validated
  LOG.error("failed to update the registry after updating the store", e);
}
{code}


> Updating classification removes some properties
> ---
>
> Key: ATLAS-1879
> URL: https://issues.apache.org/jira/browse/ATLAS-1879
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 0.8-incubating
>Reporter: Laura Ngo
> Attachments: Atlas-1789.postman_collection.json
>
>
> * Created classification via POST. 
> * Updated via PUT
> * Lost properties
> POST http://127.0.0.1:21000/api/atlas/v2/types/typedefs
> {code}
> {
>  "classificationDefs": [{
>   "name": "test_classification_11",
>   "description": "",
>   "createdBy" : "admin",
>   "superTypes": [],
>   "attributeDefs": [{
> "name" : "test_class_11",
> "typeName" : "string",
> "isOptional" : true,
> "isUnique" : true,
> "isIndexable" : true,
> "cardinality": "SINGLE",
> "valuesMinCount": 0,
> "valuesMaxCount": 1
> }]
>  }],
>  "entityDefs": [],
>  "enumDefs": [],
>  "structDefs": []
> }
> {code}
> GET 
> http://127.0.0.1:21000/api/atlas/v2/types/classification/name/test_classification_11
> {code}
> {
> "category": "CLASSIFICATION",
> "guid": "83162fe1-4bb4-4a87-b2b8-364e751a1265",
> "createdBy": "admin",
> "createTime": 1497485890857,
> "updateTime": 1497485890857,
> "version": 1,
> "name": "test_classification_11",
> "description": "",
> "typeVersion": "1.0",
> "attributeDefs": [
>   {
> "name": "test_class_11",
> "typeName": "string",
> "isOptional": true,
> "cardinality": "SINGLE",
> "valuesMinCount": 0,
> "valuesMaxCount": 1,
> "isUnique": true,
> "isIndexable": true
> }
> ],
> "superTypes": [],
> }
> {code}
> PUT http://127.0.0.1:21000/api/atlas/v2/types/typedefs
> Update attribute.
> GET 
> http://127.0.0.1:21000/api/atlas/v2/types/classification/name/test_classification_11
> {code}
> {
> "category": "CLASSIFICATION",
> "createdBy": "admin",
> "name": "test_classification_11",
> "description": "",
> "attributeDefs": [
>   {
> "name": "test_class_11",
> "typeName": "string",
> "isOptional": true,
> "cardinality": "SINGLE",
> "valuesMinCount": 0,
> "valuesMaxCount": 1,
> "isUnique": true,
> "isIndexable": false
> }
> ],
> "superTypes": [],
> }
> {code}
> Some properties are missing after PUT update of attribute "isIndexable"



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Re: Review Request 60578: [ATLA-1907]: Create RelationshipDefs for all base models and use this definitions when creating edges for entities

2017-06-30 Thread Madhan Neethiraj


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60578/#review179407
---




addons/models/0010-base_model.json
Lines 99 (patched)


Consider naming this as: dataset_process_inputs
Also, swap the endDefs: endDef1 -> dataset; endDef2 -> process. I think 
this would be intutive to read.



addons/models/0030-hive_model.json
Lines 527 (patched)


Consider the following:
- rename as 'hive_db_table' - from container to contained
- swap the endDefs: endDef1=hive_db; endDef2=hive_table
- propagateTags: TWO_TO_ONE ==> ONE_TO_TWO



addons/models/0030-hive_model.json
Lines 619 (patched)


I would suggest to keep the container end as endDef1.



addons/models/0050-falcon_model.json
Lines 162 (patched)


I would suggest to keep the container end as endDef1. Also, rename the 
relationship as "falcon_cluster_feed"



addons/models/0050-falcon_model.json
Lines 181 (patched)


I would suggest to keep the container end as endDef1. Also, rename the 
relationship as "falcon_cluster_process"



addons/models/0050-falcon_model.json
Lines 200 (patched)


I would suggest to keep the container end as endDef1. Also, rename the 
relationship as "falcon_cluster_feed_creation"



intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java
Lines 118 (patched)


add "@Override"



intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java
Lines 147 (patched)


Consider making the following as unmodifiable:
 - allSubTypes= Collections.unmodifiableSet(allSubTypes);
 - typeAndAllSubTypes = 
Collections.unmodifiableSet(typeAndAllSubTypes);
 - relationshipAttributes = 
Collections.unmodifiableMap(relationshipAttributes);
 - relationshipAttributesType = 
Collections.unmodifiableMap(relationshipAttributesType);

Also, update accessors of these fields to simply return the member, instead 
of wrapping it with Collections.unmodifiable..()



intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java
Lines 368 (patched)


Please move these comments from here to appropriate file.


- Madhan Neethiraj


On June 30, 2017, 8:25 p.m., Sarath Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60578/
> ---
> 
> (Updated June 30, 2017, 8:25 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-1907
> https://issues.apache.org/jira/browse/ATLAS-1907
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Create relationshipDefs for all out of the box models. Use relationshipDef 
> information when creating edges for composite attributes in entities.
> 
> 
> Diffs
> -
> 
>   addons/models/0010-base_model.json 7f64d85e 
>   addons/models/0030-hive_model.json b359ea82 
>   addons/models/0050-falcon_model.json b7398ef4 
>   addons/models/0060-hbase_model.json 42fe00c4 
>   addons/models/0080-storm_model.json 095936e0 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 49ead6e3 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java 
> 8d2e7ec5 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 70e3067a 
>   intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 
> f85cf35c 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java c2e0be50 
>   intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 29fae1c8 
>   
> repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java
>  4530f51b 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java
>  5ea4ff20 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java
>  7b3f1e6e 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java
>  86212338 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
>  ebf6a201 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1Test.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60578/diff/1/
> 
> 
> Testing
> ---
> 
> Tested using Postman REST client.
> Validated all hiv

Re: Review Request 60578: [ATLA-1907]: Create RelationshipDefs for all base models and use this definitions when creating edges for entities

2017-06-30 Thread Madhan Neethiraj


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60578/#review179423
---




repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java
Lines 353 (patched)


"if" ==> "else if"



repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java
Lines 377 (patched)


for types that don't have superTypes, this method would return null - and 
cause NPE in #347/#348/#353/#354 Instead of computing this List (why not Set?) 
every time, consider adding a method to appropriate AtlasEntityType.


- Madhan Neethiraj


On June 30, 2017, 8:25 p.m., Sarath Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60578/
> ---
> 
> (Updated June 30, 2017, 8:25 p.m.)
> 
> 
> Review request for atlas, David Radley and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-1907
> https://issues.apache.org/jira/browse/ATLAS-1907
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Create relationshipDefs for all out of the box models. Use relationshipDef 
> information when creating edges for composite attributes in entities.
> 
> 
> Diffs
> -
> 
>   addons/models/0010-base_model.json 7f64d85e 
>   addons/models/0030-hive_model.json b359ea82 
>   addons/models/0050-falcon_model.json b7398ef4 
>   addons/models/0060-hbase_model.json 42fe00c4 
>   addons/models/0080-storm_model.json 095936e0 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 49ead6e3 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasRelationship.java 
> 8d2e7ec5 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 70e3067a 
>   intg/src/main/java/org/apache/atlas/type/AtlasRelationshipType.java 
> f85cf35c 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java c2e0be50 
>   intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 29fae1c8 
>   
> repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java
>  4530f51b 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityStoreV1.java
>  5ea4ff20 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasGraphUtilsV1.java
>  7b3f1e6e 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1.java
>  86212338 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/EntityGraphMapper.java
>  ebf6a201 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipStoreV1Test.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/60578/diff/1/
> 
> 
> Testing
> ---
> 
> Tested using Postman REST client.
> Validated all hive_table creation works fine and lineage is rendered right.
> 
> UTs/ITs in progress.
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>

Re: Review Request 60528: UI : Search using entity and trait attributes

[jira] [Updated] (ATLAS-1894) UI : Search using entity and trait attributes

Re: Review Request 60159: ATLAS-1880: Search using entity/trait attributes

Re: Review Request 60528: UI : Search using entity and trait attributes

[jira] [Updated] (ATLAS-1896) Add Cross Origin [CORS] headers for Atlas

Build failed in Jenkins: apache-atlas-nightly #788

[GitHub] incubator-atlas pull request #36: [ATLAS-1875] Adding the gremlin id for a v...

[jira] [Commented] (ATLAS-1875) Gremlin id is no longer returned for vertices in gremlin query

[jira] [Resolved] (ATLAS-1888) UI - While Update Entity the data of type Long is not updating in entity from UI.

[jira] [Updated] (ATLAS-1896) Add Cross Origin [CORS] headers for Atlas

[jira] [Updated] (ATLAS-1896) Add Cross Origin [CORS] headers for Atlas

[jira] [Updated] (ATLAS-1896) Add Cross Origin [CORS] headers for Atlas

[jira] [Updated] (ATLAS-1896) Add Cross Origin [CORS] headers for Atlas

[jira] [Commented] (ATLAS-1863) Set default value for primitive types attributes in entity based on attributeDef in Typedef

[jira] [Created] (ATLAS-1906) Atlas client should support setting hadoop-jwt token in header

[jira] [Created] (ATLAS-1907) Create RelationshipDefs for all base models and use the definitions in graph edges when creating entities

[jira] [Updated] (ATLAS-1907) Create RelationshipDefs for all base models and use this definitions when creating edges for entities

Review Request 60578: [ATLA-1907]: Create RelationshipDefs for all base models and use this definitions when creating edges for entities

[jira] [Updated] (ATLAS-1907) Create RelationshipDefs for all base models and use this definitions when creating edges for entities

[jira] [Commented] (ATLAS-1879) Updating classification removes some properties

[jira] [Comment Edited] (ATLAS-1879) Updating classification removes some properties

Re: Review Request 60578: [ATLA-1907]: Create RelationshipDefs for all base models and use this definitions when creating edges for entities

Re: Review Request 60578: [ATLA-1907]: Create RelationshipDefs for all base models and use this definitions when creating edges for entities

23 matches

Site Navigation

Mail list logo

Footer information