Re: Review Request 64800: ATLAS-2229: Implementation fixes and grammar simplification

[Apoorv Naik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64800/
---

(Updated Dec. 23, 2017, 1:11 a.m.)


Review request for atlas and Madhan Neethiraj.


Changes
---

Explicit handling of limit/offset sent via REST params


Bugs: ATLAS-2229
https://issues.apache.org/jira/browse/ATLAS-2229


Repository: atlas


Description
---

Gremlin related changes

Global aggregator instead of local, no implicit limits on aggregator
Error handling for malformed queries
Simplified outgoing traversal
Fix for groupBy followed by orderBy
Handled quoted string labels when using aggregator functions


Removed space/comma separated query from DSL grammar


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java fb741f8f6 
  
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 
ece1516a7 
  repository/src/main/java/org/apache/atlas/query/AtlasDSL.java PRE-CREATION 
  repository/src/main/java/org/apache/atlas/query/DSLVisitor.java b597a0daa 
  repository/src/main/java/org/apache/atlas/query/Expressions.java 77350f09b 
  repository/src/main/java/org/apache/atlas/query/GremlinTranslator.java 
6ce90e620 
  repository/src/main/java/org/apache/atlas/query/IdentifierHelper.java 
0c7e2ed83 
  repository/src/main/java/org/apache/atlas/query/Lookup.java a64b68876 
  repository/src/main/java/org/apache/atlas/query/QueryParser.java 6e378a1f6 
  repository/src/main/java/org/apache/atlas/query/QueryProcessor.java 5e07a9228 
  repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.java 
576e1298e 
  repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.tokens 
8c147b4fc 
  repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.g4 
058a5c80f 
  repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.tokens 
8c147b4fc 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasAbstractDefStoreV1.java
 02dad4684 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipDefStoreV1.java
 d3253000e 
  repository/src/test/java/org/apache/atlas/query/QueryProcessorTest.java 
b87314199 


Diff: https://reviews.apache.org/r/64800/diff/4/

Changes: https://reviews.apache.org/r/64800/diff/3-4/


Testing
---

Testing done via UI

UTs and ITs have not been tackled yet, once all the existing cases are 
implemented that's the next big thing.


Thanks,

Apoorv Naik

Re: Review Request 64800: ATLAS-2229: Implementation fixes and grammar simplification

[Apoorv Naik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64800/
---

(Updated Dec. 23, 2017, 12:57 a.m.)


Review request for atlas and Madhan Neethiraj.


Changes
---

Resolved compilation errors due to previous bad rebase


Bugs: ATLAS-2229
https://issues.apache.org/jira/browse/ATLAS-2229


Repository: atlas


Description
---

Gremlin related changes

Global aggregator instead of local, no implicit limits on aggregator
Error handling for malformed queries
Simplified outgoing traversal
Fix for groupBy followed by orderBy
Handled quoted string labels when using aggregator functions


Removed space/comma separated query from DSL grammar


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java fb741f8f 
  
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 
ece1516a 
  repository/src/main/java/org/apache/atlas/query/AtlasDSL.java PRE-CREATION 
  repository/src/main/java/org/apache/atlas/query/DSLVisitor.java b597a0da 
  repository/src/main/java/org/apache/atlas/query/Expressions.java 77350f09 
  repository/src/main/java/org/apache/atlas/query/GremlinTranslator.java 
6ce90e62 
  repository/src/main/java/org/apache/atlas/query/IdentifierHelper.java 
0c7e2ed8 
  repository/src/main/java/org/apache/atlas/query/Lookup.java a64b6887 
  repository/src/main/java/org/apache/atlas/query/QueryParser.java 6e378a1f 
  repository/src/main/java/org/apache/atlas/query/QueryProcessor.java 5e07a922 
  repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.java 
576e1298 
  repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.tokens 
8c147b4f 
  repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.g4 
058a5c80 
  repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.tokens 
8c147b4f 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasAbstractDefStoreV1.java
 02dad468 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipDefStoreV1.java
 d3253000 
  repository/src/test/java/org/apache/atlas/query/QueryProcessorTest.java 
b8731419 


Diff: https://reviews.apache.org/r/64800/diff/3/

Changes: https://reviews.apache.org/r/64800/diff/2-3/


Testing
---

Testing done via UI

UTs and ITs have not been tackled yet, once all the existing cases are 
implemented that's the next big thing.


Thanks,

Apoorv Naik

Re: Review Request 64800: ATLAS-2229: Implementation fixes and grammar simplification

[Apoorv Naik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64800/
---

(Updated Dec. 23, 2017, 12:13 a.m.)


Review request for atlas and Madhan Neethiraj.


Changes
---

Rebased on latest master


Bugs: ATLAS-2229
https://issues.apache.org/jira/browse/ATLAS-2229


Repository: atlas


Description
---

Gremlin related changes

Global aggregator instead of local, no implicit limits on aggregator
Error handling for malformed queries
Simplified outgoing traversal
Fix for groupBy followed by orderBy
Handled quoted string labels when using aggregator functions


Removed space/comma separated query from DSL grammar


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java fb741f8f6 
  repository/src/main/java/org/apache/atlas/query/AtlasDSL.java PRE-CREATION 
  repository/src/main/java/org/apache/atlas/query/DSLVisitor.java b597a0daa 
  repository/src/main/java/org/apache/atlas/query/Expressions.java 77350f09b 
  repository/src/main/java/org/apache/atlas/query/GremlinTranslator.java 
6ce90e620 
  repository/src/main/java/org/apache/atlas/query/IdentifierHelper.java 
0c7e2ed83 
  repository/src/main/java/org/apache/atlas/query/Lookup.java a64b68876 
  repository/src/main/java/org/apache/atlas/query/QueryParser.java 6e378a1f6 
  repository/src/main/java/org/apache/atlas/query/QueryProcessor.java 5e07a9228 
  repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.java 
576e1298e 
  repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.tokens 
8c147b4fc 
  repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.g4 
058a5c80f 
  repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.java 
e557c4af2 
  repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.tokens 
8c147b4fc 
  
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserBaseVisitor.java
 4423c0e92 
  
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserVisitor.java
 8c59d7a6e 
  repository/src/test/java/org/apache/atlas/query/QueryProcessorTest.java 
b87314199 


Diff: https://reviews.apache.org/r/64800/diff/2/

Changes: https://reviews.apache.org/r/64800/diff/1-2/


Testing
---

Testing done via UI

UTs and ITs have not been tackled yet, once all the existing cases are 
implemented that's the next big thing.


Thanks,

Apoorv Naik

Build failed in Jenkins: Atlas-master-IntegrationTests #230

[Apache Jenkins Server]

See 


Changes:

[madhan] ATLAS-2229: fix for unit test failures in DSL tests; also fixed

--
[...truncated 363.70 KB...]
at org.springframework.web.context.ContextLoaderListener.contextInitialized 
(ContextLoaderListener.java:107)
at org.eclipse.jetty.server.handler.ContextHandler.callContextInitialized 
(ContextHandler.java:843)
at org.eclipse.jetty.servlet.ServletContextHandler.callContextInitialized 
(ServletContextHandler.java:533)
at org.eclipse.jetty.server.handler.ContextHandler.startContext 
(ContextHandler.java:816)
at org.eclipse.jetty.servlet.ServletContextHandler.startContext 
(ServletContextHandler.java:345)
at org.eclipse.jetty.webapp.WebAppContext.startWebapp 
(WebAppContext.java:1404)
at org.eclipse.jetty.maven.plugin.JettyWebAppContext.startWebapp 
(JettyWebAppContext.java:323)
at org.eclipse.jetty.webapp.WebAppContext.startContext 
(WebAppContext.java:1366)
at org.eclipse.jetty.server.handler.ContextHandler.doStart 
(ContextHandler.java:778)
at org.eclipse.jetty.servlet.ServletContextHandler.doStart 
(ServletContextHandler.java:262)
at org.eclipse.jetty.webapp.WebAppContext.doStart (WebAppContext.java:520)
at org.eclipse.jetty.maven.plugin.JettyWebAppContext.doStart 
(JettyWebAppContext.java:398)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start 
(AbstractLifeCycle.java:68)
at org.eclipse.jetty.util.component.ContainerLifeCycle.start 
(ContainerLifeCycle.java:131)
at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart 
(ContainerLifeCycle.java:113)
at org.eclipse.jetty.server.handler.AbstractHandler.doStart 
(AbstractHandler.java:61)
at org.eclipse.jetty.server.handler.ContextHandlerCollection.doStart 
(ContextHandlerCollection.java:161)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start 
(AbstractLifeCycle.java:68)
at org.eclipse.jetty.util.component.ContainerLifeCycle.start 
(ContainerLifeCycle.java:131)
at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart 
(ContainerLifeCycle.java:113)
at org.eclipse.jetty.server.handler.AbstractHandler.doStart 
(AbstractHandler.java:61)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start 
(AbstractLifeCycle.java:68)
at org.eclipse.jetty.util.component.ContainerLifeCycle.start 
(ContainerLifeCycle.java:131)
at org.eclipse.jetty.server.Server.start (Server.java:422)
at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart 
(ContainerLifeCycle.java:105)
at org.eclipse.jetty.server.handler.AbstractHandler.doStart 
(AbstractHandler.java:61)
at org.eclipse.jetty.server.Server.doStart (Server.java:389)
at org.eclipse.jetty.util.component.AbstractLifeCycle.start 
(AbstractLifeCycle.java:68)
at org.eclipse.jetty.maven.plugin.AbstractJettyMojo.startJetty 
(AbstractJettyMojo.java:460)
at org.eclipse.jetty.maven.plugin.AbstractJettyMojo.execute 
(AbstractJettyMojo.java:328)
at org.eclipse.jetty.maven.plugin.JettyRunWarMojo.execute 
(JettyRunWarMojo.java:64)
at org.eclipse.jetty.maven.plugin.JettyDeployWar.execute 
(JettyDeployWar.java:65)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
(DefaultBuildPluginManager.java:134)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:208)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:154)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
(MojoExecutor.java:146)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:117)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
(LifecycleModuleBuilder.java:81)
at 
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
 (SingleThreadedBuilder.java:51)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:309)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:194)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:107)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:955)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:290)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:194)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke 
(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke 
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:498)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
(Launcher.java:289)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
(Launcher.java:229)
at 

Review Request 64800: ATLAS-2229: Implementation fixes and grammar simplification

[Apoorv Naik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64800/
---

Review request for atlas and Madhan Neethiraj.


Bugs: ATLAS-2229
https://issues.apache.org/jira/browse/ATLAS-2229


Repository: atlas


Description
---

Gremlin related changes

Global aggregator instead of local, no implicit limits on aggregator
Error handling for malformed queries
Simplified outgoing traversal
Fix for groupBy followed by orderBy
Handled quoted string labels when using aggregator functions


Removed space/comma separated query from DSL grammar


Diffs
-

  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java fb741f8f6 
  repository/src/main/java/org/apache/atlas/query/AtlasDSL.java PRE-CREATION 
  repository/src/main/java/org/apache/atlas/query/DSLVisitor.java b597a0daa 
  repository/src/main/java/org/apache/atlas/query/Expressions.java 77350f09b 
  repository/src/main/java/org/apache/atlas/query/GremlinTranslator.java 
6ce90e620 
  repository/src/main/java/org/apache/atlas/query/IdentifierHelper.java 
0c7e2ed83 
  repository/src/main/java/org/apache/atlas/query/Lookup.java a64b68876 
  repository/src/main/java/org/apache/atlas/query/QueryParser.java 6e378a1f6 
  repository/src/main/java/org/apache/atlas/query/QueryProcessor.java 76a10e3d5 
  repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.java 
576e1298e 
  repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.tokens 
8c147b4fc 
  repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.g4 
058a5c80f 
  repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.java 
e557c4af2 
  repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.tokens 
8c147b4fc 
  
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserBaseVisitor.java
 4423c0e92 
  
repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParserVisitor.java
 8c59d7a6e 
  repository/src/test/java/org/apache/atlas/query/QueryProcessorTest.java 
b87314199 


Diff: https://reviews.apache.org/r/64800/diff/1/


Testing
---

Testing done via UI

UTs and ITs have not been tackled yet, once all the existing cases are 
implemented that's the next big thing.


Thanks,

Apoorv Naik

Jenkins build is still unstable: Atlas-master-UnitTests #214

[Apache Jenkins Server]

See 

Build failed in Jenkins: Atlas-master-IntegrationTests #229

[Apache Jenkins Server]

See 


Changes:

[madhan] ATLAS-2323: remove array form of attribute from term model

--
[...truncated 413.34 KB...]
Error 503 


HTTP ERROR: 503
Problem accessing /api/atlas/types. Reason:
Service Unavailable
http://eclipse.org/jetty;>Powered by Jetty:// 
9.3.14.v20161028


)
at 
org.apache.atlas.web.integration.TypesJerseyResourceIT.addTraits(TypesJerseyResourceIT.java:244)
at 
org.apache.atlas.web.integration.TypesJerseyResourceIT.testGetTraitNames(TypesJerseyResourceIT.java:196)

[ERROR] 
testListTypesByFilter(org.apache.atlas.web.integration.TypesJerseyResourceIT)  
Time elapsed: 40.058 s  <<< FAILURE!
org.apache.atlas.AtlasServiceException: 
Metadata service API org.apache.atlas.AtlasClient$API_V1@5936b6ee failed with 
status 503 (Service Unavailable) Response Body (


Error 503 


HTTP ERROR: 503
Problem accessing /api/atlas/types. Reason:
Service Unavailable
http://eclipse.org/jetty;>Powered by Jetty:// 
9.3.14.v20161028


)
at 
org.apache.atlas.web.integration.TypesJerseyResourceIT.testListTypesByFilter(TypesJerseyResourceIT.java:217)

[ERROR] testSubmit(org.apache.atlas.web.integration.TypesJerseyResourceIT)  
Time elapsed: 40.048 s  <<< FAILURE!
org.apache.atlas.AtlasServiceException: 
Metadata service API org.apache.atlas.AtlasClient$API_V1@5936b6ee failed with 
status 503 (Service Unavailable) Response Body (


Error 503 


HTTP ERROR: 503
Problem accessing /api/atlas/types. Reason:
Service Unavailable
http://eclipse.org/jetty;>Powered by Jetty:// 
9.3.14.v20161028


)
at 
org.apache.atlas.web.integration.TypesJerseyResourceIT.testSubmit(TypesJerseyResourceIT.java:84)

[ERROR] testUpdate(org.apache.atlas.web.integration.TypesJerseyResourceIT)  
Time elapsed: 20.022 s  <<< FAILURE!
org.apache.atlas.AtlasServiceException: 
Metadata service API org.apache.atlas.AtlasClient$API_V1@5936b6ee failed with 
status 503 (Service Unavailable) Response Body (


Error 503 


HTTP ERROR: 503
Problem accessing /api/atlas/types. Reason:
Service Unavailable
http://eclipse.org/jetty;>Powered by Jetty:// 
9.3.14.v20161028


)
at 
org.apache.atlas.web.integration.TypesJerseyResourceIT.testUpdate(TypesJerseyResourceIT.java:120)

[ERROR] 
setUp(org.apache.atlas.web.integration.MetadataDiscoveryJerseyResourceIT)  Time 
elapsed: 380.514 s  <<< FAILURE!
org.apache.atlas.AtlasServiceException: 
Metadata service API org.apache.atlas.AtlasClient$API_V1@5936b6ee failed with 
status 503 (Service Unavailable) Response Body (


Error 503 


HTTP ERROR: 503
Problem accessing /api/atlas/types. Reason:
Service Unavailable
http://eclipse.org/jetty;>Powered by Jetty:// 
9.3.14.v20161028


)
at 
org.apache.atlas.web.integration.MetadataDiscoveryJerseyResourceIT.createTypes(MetadataDiscoveryJerseyResourceIT.java:236)
at 
org.apache.atlas.web.integration.MetadataDiscoveryJerseyResourceIT.setUp(MetadataDiscoveryJerseyResourceIT.java:58)

[ERROR] setUp(org.apache.atlas.web.integration.BasicSearchIT)  Time elapsed: 
20.233 s  <<< FAILURE!
org.apache.atlas.AtlasServiceException: 
Metadata service API org.apache.atlas.AtlasBaseClient$API@2ff5f9d9 failed with 
status 503 (Service Unavailable) Response Body (


Error 503 


HTTP ERROR: 503
Problem accessing /api/atlas/admin/import. Reason:
Service Unavailable
http://eclipse.org/jetty;>Powered by Jetty:// 
9.3.14.v20161028


)
at 
org.apache.atlas.web.integration.BasicSearchIT.setUp(BasicSearchIT.java:61)

[INFO] 
[INFO] Results:
[INFO] 
[ERROR] Failures: 
[ERROR]   
AtlasAuthenticationSimpleFilterIT.testAccessforUnauthenticatedResource:57 
expected [200] but found [503]
[ERROR]   
AtlasAuthenticationSimpleFilterIT.testSimpleLoginAndAuthorizationWithValidCrendentialsAndInvalidAccessToResource:74
 expected [403] but found [503]
[ERROR]   AtlasAuthenticationSimpleFilterIT.testSimpleLoginForValidUser:46 
expected [200] but found [503]
[ERROR]   
AtlasAuthenticationSimpleFilterIT.testSimpleLoginWithInvalidCrendentials:93 
expected [401] but found [503]
[ERROR]   AdminJerseyResourceIT.testGetVersion:40 » AtlasService Metadata 
service API or...
[ERROR]   BasicSearchIT.setUp:61 » AtlasService Metadata service API 
org.apache.atlas.At...
[ERROR]   
EntityLineageJerseyResourceIT.setUp:56->DataSetLineageJerseyResourceIT.setUp:60->BaseResourceIT.createTypeDefinitionsV1:359->BaseResourceIT.createType:212
 » AtlasService
[ERROR]   
MetadataDiscoveryJerseyResourceIT.setUp:58->createTypes:236->BaseResourceIT.createTypeDefinitionsV1:359->BaseResourceIT.createType:212
 » AtlasService
[ERROR]   TypesJerseyResourceIT.testDuplicateSubmit:102 » AtlasService 
Metadata service ...
[ERROR]   
TypesJerseyResourceIT.testGetTraitNames:196->addTraits:244->BaseResourceIT.createType:216->BaseResourceIT.createType:212
 » AtlasService
[ERROR]   

Re: Review Request 64801: ATLAS2323 remove embedded media from term 0330 model

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64801/#review194449
---


Ship it!




Ship It!

- Madhan Neethiraj


On Dec. 22, 2017, 10:21 a.m., David Radley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64801/
> ---
> 
> (Updated Dec. 22, 2017, 10:21 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj and MandyDW MandyDW.
> 
> 
> Bugs: ATLAS2323
> https://issues.apache.org/jira/browse/ATLAS2323
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS2323 remove embedded media from term 0330 model
> 
> 
> Diffs
> -
> 
>   addons/models/0300-Area3-SubjectArea/0330-Terms.json 73315abb 
> 
> 
> Diff: https://reviews.apache.org/r/64801/diff/1/
> 
> 
> Testing
> ---
> 
> build atlas
> 
> 
> Thanks,
> 
> David Radley
> 
>

[jira] [Updated] (ATLAS-2323) remove embedded media from term 0330 model

[David Radley (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-2323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Radley updated ATLAS-2323:

Attachment: ATLAS2323.patch

> remove embedded media from term 0330 model
> --
>
> Key: ATLAS-2323
> URL: https://issues.apache.org/jira/browse/ATLAS-2323
> Project: Atlas
>  Issue Type: Bug
>Reporter: David Radley
>Assignee: David Radley
> Attachments: ATLAS2323.patch
>
>
> There is an old style attribute in term relating to media. Is has the array 
> form. This needs to be removed - media relationships are defined in Area 0. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Review Request 64801: ATLAS2323 remove embedded media from term 0330 model

[David Radley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64801/
---

Review request for atlas, Madhan Neethiraj and MandyDW MandyDW.


Bugs: ATLAS2323
https://issues.apache.org/jira/browse/ATLAS2323


Repository: atlas


Description
---

ATLAS2323 remove embedded media from term 0330 model


Diffs
-

  addons/models/0300-Area3-SubjectArea/0330-Terms.json 73315abb 


Diff: https://reviews.apache.org/r/64801/diff/1/


Testing
---

build atlas


Thanks,

David Radley

[jira] [Created] (ATLAS-2323) remove embedded media from term 0330 model

[David Radley (JIRA)]

David Radley created ATLAS-2323:
---

 Summary: remove embedded media from term 0330 model
 Key: ATLAS-2323
 URL: https://issues.apache.org/jira/browse/ATLAS-2323
 Project: Atlas
  Issue Type: Bug
Reporter: David Radley
Assignee: David Radley


There is an old style attribute in term relating to media. Is has the array 
form. This needs to be removed - media relationships are defined in Area 0. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)