[jira] [Updated] (ATLAS-3930) Atlas server distribution contains 180+ CVEs

2020-09-17 Thread Gaurav Saini (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-3930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gaurav Saini updated ATLAS-3930:

Description: 
we are working on apache atlas code and started deploying over 
*[https://github.com/apache/atlas/tree/release-2.1.0-rc3]*
 Upon scanning using twistlock, we found *180+* vulnerability.
  
 Out of these, Jackson-databind and netty_netty-all are the most occurring ones.
 So, we tried upgrading the versions, but integration tests in atlas-webapp 
started failing saying *"org.eclise.jetty, utils: Multi exception".*

The same thing is happening while upgrading versions of any other dependencies 
in the atlas module. The application breaks for any other dependency which we 
are trying to upgrade. for example, Hadoop_hdfs uses Jackson-databind as a 
transitive dependency, hence I am unable to update version.
 _PFA of dependency check for the project._

*I do not see any open issue on the Github channel too.*
 *Have you experienced any such scenario while upgrading earlier?*
 *Is there a way for me to move ahead to remove vulnerabilities in the current 
version?*

 

*The atlas server distribution should be using the latest version of the 
dependencies having no or fewer CVEs.*

  was:
we are working on apache atlas code and started deploying over 
*[https://github.com/apache/atlas/tree/release-2.1.0-rc3]*
 Upon scanning using twistlock, we found *180+* vulnerability.
  
 Out of these, Jackson-databind and netty_netty-all were the most occurring 
once.
 So, we tried upgrading the versions, but integration tests in atlas-webapp 
start failing saying *"org.eclise.jetty, utils: Multi exception".*

The same thing is happening while upgrading versions of any other dependencies 
in the atlas module. The application breaks for any other dependency which we 
are trying to upgrade. for example, Hadoop_hdfs uses Jackson-databind as a 
transitive dependency, hence I am unable to update version.
 _PFA of dependency check for the project._

*I do not see any open issue on the Github channel too.*
 *Have you experienced any such scenario while upgrading earlier?*
 *Is there a way for me to move ahead to remove vulnerabilities in the current 
version.*


> Atlas server distribution contains 180+ CVEs
> 
>
> Key: ATLAS-3930
> URL: https://issues.apache.org/jira/browse/ATLAS-3930
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core, atlas-intg, atlas-webui
>Affects Versions: 2.1.0
>Reporter: Gaurav Saini
>Priority: Blocker
> Attachments: dependency-check-report.csv, dependency-check-report.html
>
>
> we are working on apache atlas code and started deploying over 
> *[https://github.com/apache/atlas/tree/release-2.1.0-rc3]*
>  Upon scanning using twistlock, we found *180+* vulnerability.
>   
>  Out of these, Jackson-databind and netty_netty-all are the most occurring 
> ones.
>  So, we tried upgrading the versions, but integration tests in atlas-webapp 
> started failing saying *"org.eclise.jetty, utils: Multi exception".*
> The same thing is happening while upgrading versions of any other 
> dependencies in the atlas module. The application breaks for any other 
> dependency which we are trying to upgrade. for example, Hadoop_hdfs uses 
> Jackson-databind as a transitive dependency, hence I am unable to update 
> version.
>  _PFA of dependency check for the project._
> *I do not see any open issue on the Github channel too.*
>  *Have you experienced any such scenario while upgrading earlier?*
>  *Is there a way for me to move ahead to remove vulnerabilities in the 
> current version?*
>  
> *The atlas server distribution should be using the latest version of the 
> dependencies having no or fewer CVEs.*



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3930) Atlas server distribution contains 180+ CVEs

2020-09-17 Thread Gaurav Saini (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-3930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Gaurav Saini updated ATLAS-3930:

Summary: Atlas server distribution contains 180+ CVEs  (was: Getting Multi 
exception while updating the dependency version.)

> Atlas server distribution contains 180+ CVEs
> 
>
> Key: ATLAS-3930
> URL: https://issues.apache.org/jira/browse/ATLAS-3930
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core, atlas-intg, atlas-webui
>Affects Versions: 2.1.0
>Reporter: Gaurav Saini
>Priority: Blocker
> Attachments: dependency-check-report.csv, dependency-check-report.html
>
>
> we are working on apache atlas code and started deploying over 
> *[https://github.com/apache/atlas/tree/release-2.1.0-rc3]*
>  Upon scanning using twistlock, we found *180+* vulnerability.
>   
>  Out of these, Jackson-databind and netty_netty-all were the most occurring 
> once.
>  So, we tried upgrading the versions, but integration tests in atlas-webapp 
> start failing saying *"org.eclise.jetty, utils: Multi exception".*
> The same thing is happening while upgrading versions of any other 
> dependencies in the atlas module. The application breaks for any other 
> dependency which we are trying to upgrade. for example, Hadoop_hdfs uses 
> Jackson-databind as a transitive dependency, hence I am unable to update 
> version.
>  _PFA of dependency check for the project._
> *I do not see any open issue on the Github channel too.*
>  *Have you experienced any such scenario while upgrading earlier?*
>  *Is there a way for me to move ahead to remove vulnerabilities in the 
> current version.*



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [atlas] HeChuanXUPT opened a new pull request #112: update doc for janusgraph urls

2020-09-17 Thread GitBox 


HeChuanXUPT opened a new pull request #112:
URL: https://github.com/apache/atlas/pull/112


   update doc for janusgraph urls
   
   404 - Not found
   https://docs.janusgraph.org/latest/elasticsearch.html
   https://docs.janusgraph.org/latest/hbase.html#_remote_server_mode_2
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (ATLAS-3948) Entity Creation: Index Consistency: Java Patch Handler: Provide Option to Disable

2020-09-17 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-3948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17197940#comment-17197940
 ] 

ASF subversion and git services commented on ATLAS-3948:


Commit a2ea7d302e1ef8d6e9dd6f88e25749233a40e0f6 in atlas's branch 
refs/heads/branch-2.0 from Ashutosh Mestry
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=a2ea7d3 ]

ATLAS-3948: Entity Creation: Index Consistency: Java Patch Handler: Provide 
Option to Disable


> Entity Creation: Index Consistency: Java Patch Handler: Provide Option to 
> Disable
> -
>
> Key: ATLAS-3948
> URL: https://issues.apache.org/jira/browse/ATLAS-3948
> Project: Atlas
>  Issue Type: Bug
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Attachments: ATLAS-3948-index-consistency-conditional.patch
>
>
> *Background*
> The ATLAS-3907 provided ability to apply index consistency to existing 
> indexes via Java patch handler.
> However, when _atlas.graph.storage.consistency-lock.enabled=false_ this patch 
> still gets applied.
> *Solution*
> Check for the property in Java patch handler and avoid applying it if the 
> property is set to false.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3948) Entity Creation: Index Consistency: Java Patch Handler: Provide Option to Disable

2020-09-17 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-3948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17197939#comment-17197939
 ] 

ASF subversion and git services commented on ATLAS-3948:


Commit eccc37623e7c3d43e1aa494f88a5ad155fe9c123 in atlas's branch 
refs/heads/master from Ashutosh Mestry
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=eccc376 ]

ATLAS-3948: Entity Creation: Index Consistency: Java Patch Handler: Provide 
Option to Disable


> Entity Creation: Index Consistency: Java Patch Handler: Provide Option to 
> Disable
> -
>
> Key: ATLAS-3948
> URL: https://issues.apache.org/jira/browse/ATLAS-3948
> Project: Atlas
>  Issue Type: Bug
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Attachments: ATLAS-3948-index-consistency-conditional.patch
>
>
> *Background*
> The ATLAS-3907 provided ability to apply index consistency to existing 
> indexes via Java patch handler.
> However, when _atlas.graph.storage.consistency-lock.enabled=false_ this patch 
> still gets applied.
> *Solution*
> Check for the property in Java patch handler and avoid applying it if the 
> property is set to false.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3944) Logs of import scripts should go to Atlas default log directory

2020-09-17 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-3944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17197933#comment-17197933
 ] 

ASF subversion and git services commented on ATLAS-3944:


Commit 59a609a277971c246c7892a9e76d6a75e001d8a6 in atlas's branch 
refs/heads/branch-2.0 from Deep Singh
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=59a609a ]

ATLAS-3944: Logs of import scripts should go to Atlas default log directory

Signed-off-by: Ashutosh Mestry 


> Logs of import scripts should go to Atlas default log directory
> ---
>
> Key: ATLAS-3944
> URL: https://issues.apache.org/jira/browse/ATLAS-3944
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-intg
>Affects Versions: trunk, 2.1.0
>Reporter: Deep Singh
>Assignee: Deep Singh
>Priority: Major
> Fix For: trunk
>
> Attachments: 0001-Setting-default-log-directory-to-var-log-atlas.patch
>
>
> Import scripts like import-hbase.sh try to dump logs in a log directory 
> inside the base directory. Most of the users running import scripts have 
> read-only access to the base directory, this leads to the following error 
> exception.
> java.io.FileNotFoundException: 
> /opt/cloudera/parcels/CDH/lib/atlas/logs/import-hbase.log (No such file or 
> directory)
> Although there is a mechanism to set the log location to the desired 
> directory using env variable ATLAS_LOG_DIR, but by default, the script must 
> try to dump logs in Atlas default logs directory (/var/log/atlas)
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3944) Logs of import scripts should go to Atlas default log directory

2020-09-17 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-3944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17197886#comment-17197886
 ] 

ASF subversion and git services commented on ATLAS-3944:


Commit 62c682b344c245015bca4e3d6bf7f55b5394a5e2 in atlas's branch 
refs/heads/master from Deep Singh
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=62c682b ]

ATLAS-3944: Logs of import scripts should go to Atlas default log directory

Signed-off-by: Ashutosh Mestry 


> Logs of import scripts should go to Atlas default log directory
> ---
>
> Key: ATLAS-3944
> URL: https://issues.apache.org/jira/browse/ATLAS-3944
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-intg
>Affects Versions: trunk, 2.1.0
>Reporter: Deep Singh
>Assignee: Deep Singh
>Priority: Major
> Fix For: trunk
>
> Attachments: 0001-Setting-default-log-directory-to-var-log-atlas.patch
>
>
> Import scripts like import-hbase.sh try to dump logs in a log directory 
> inside the base directory. Most of the users running import scripts have 
> read-only access to the base directory, this leads to the following error 
> exception.
> java.io.FileNotFoundException: 
> /opt/cloudera/parcels/CDH/lib/atlas/logs/import-hbase.log (No such file or 
> directory)
> Although there is a mechanism to set the log location to the desired 
> directory using env variable ATLAS_LOG_DIR, but by default, the script must 
> try to dump logs in Atlas default logs directory (/var/log/atlas)
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3948) Entity Creation: Index Consistency: Java Patch Handler: Provide Option to Disable

2020-09-17 Thread Sarath Subramanian (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-3948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17197879#comment-17197879
 ] 

Sarath Subramanian commented on ATLAS-3948:
---

thanks for the patch [~amestry] +1

> Entity Creation: Index Consistency: Java Patch Handler: Provide Option to 
> Disable
> -
>
> Key: ATLAS-3948
> URL: https://issues.apache.org/jira/browse/ATLAS-3948
> Project: Atlas
>  Issue Type: Bug
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Attachments: ATLAS-3948-index-consistency-conditional.patch
>
>
> *Background*
> The ATLAS-3907 provided ability to apply index consistency to existing 
> indexes via Java patch handler.
> However, when _atlas.graph.storage.consistency-lock.enabled=false_ this patch 
> still gets applied.
> *Solution*
> Check for the property in Java patch handler and avoid applying it if the 
> property is set to false.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 72879: ATLAS-3946 : Filter TypeDefs in Metrics API and show data accordingly

2020-09-17 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72879/#review221888
---




repository/src/main/java/org/apache/atlas/services/MetricsService.java
Line 129 (original), 139 (patched)


Shouldn't entityDefs be used here, instead of 
typeRegistry.getAllEntityTypes()? Please review.


- Madhan Neethiraj


On Sept. 17, 2020, 5:24 p.m., Nixon Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72879/
> ---
> 
> (Updated Sept. 17, 2020, 5:24 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nikhil Bonte, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3946
> https://issues.apache.org/jira/browse/ATLAS-3946
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Filter TypeDefs in Metrics API and show data accordingly, currently data is 
> shown for all types even if user do not have access to those types.
> 
> This patch filterTypeDefs after authorization and updates the data for 
> required types.
> 
> 
> Diffs
> -
> 
>   repository/src/main/java/org/apache/atlas/services/MetricsService.java 
> 7917f32e5 
>   webapp/src/main/java/org/apache/atlas/web/security/AtlasSecurityConfig.java 
> e74a9e93a 
> 
> 
> Diff: https://reviews.apache.org/r/72879/diff/2/
> 
> 
> Testing
> ---
> 
> Tested Statistics UI from different users with different policies for 
> entityType and classfication.
> 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/25/console
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>

Re: Review Request 72879: ATLAS-3946 : Filter TypeDefs in Metrics API and show data accordingly

2020-09-17 Thread Nixon Rodrigues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72879/
---

(Updated Sept. 17, 2020, 5:24 p.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nikhil Bonte, and 
Sarath Subramanian.


Changes
---

Updated patch with review comment from Madhan.


Bugs: ATLAS-3946
https://issues.apache.org/jira/browse/ATLAS-3946


Repository: atlas


Description
---

Filter TypeDefs in Metrics API and show data accordingly, currently data is 
shown for all types even if user do not have access to those types.

This patch filterTypeDefs after authorization and updates the data for required 
types.


Diffs (updated)
-

  repository/src/main/java/org/apache/atlas/services/MetricsService.java 
7917f32e5 
  webapp/src/main/java/org/apache/atlas/web/security/AtlasSecurityConfig.java 
e74a9e93a 


Diff: https://reviews.apache.org/r/72879/diff/2/

Changes: https://reviews.apache.org/r/72879/diff/1-2/


Testing
---

Tested Statistics UI from different users with different policies for 
entityType and classfication.

https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/25/console


Thanks,

Nixon Rodrigues

Re: Review Request 72880: ATLAS-3947 : Skip authorization for read of _ALL_ENTITY_TYPES and _ALL_CLASSIFICATION_TYPES types

2020-09-17 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72880/#review221887
---


Ship it!




Ship It!

- Sarath Subramanian


On Sept. 17, 2020, 3:28 a.m., Nixon Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72880/
> ---
> 
> (Updated Sept. 17, 2020, 3:28 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nikhil Bonte, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3947
> https://issues.apache.org/jira/browse/ATLAS-3947
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Skip authorization for read of _ALL_ENTITY_TYPES type of entity type and 
> _ALL_CLASSIFICATION_TYPES type of classification type.
> This are internally required by for system attributes search.
> 
> This patch Skip authorization for read of _ALL_ENTITY_TYPES entityType and 
> and _ALL_CLASSIFICATION_TYPES classificationType.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java
>  458ec49ea 
> 
> 
> Diff: https://reviews.apache.org/r/72880/diff/1/
> 
> 
> Testing
> ---
> 
> Tested API's with no policies on types for a user. _ALL_ENTITY_TYPES and 
> _ALL_CLASSIFICATION_TYPES are loaded correctly after it.
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>

Re: Review Request 72879: ATLAS-3946 : Filter TypeDefs in Metrics API and show data accordingly

2020-09-17 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72879/#review221886
---


Ship it!




Ship It!

- Sarath Subramanian


On Sept. 17, 2020, 2:26 a.m., Nixon Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72879/
> ---
> 
> (Updated Sept. 17, 2020, 2:26 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nikhil Bonte, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3946
> https://issues.apache.org/jira/browse/ATLAS-3946
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Filter TypeDefs in Metrics API and show data accordingly, currently data is 
> shown for all types even if user do not have access to those types.
> 
> This patch filterTypeDefs after authorization and updates the data for 
> required types.
> 
> 
> Diffs
> -
> 
>   repository/src/main/java/org/apache/atlas/services/MetricsService.java 
> 7917f32e5 
>   webapp/src/main/java/org/apache/atlas/web/security/AtlasSecurityConfig.java 
> e74a9e93a 
> 
> 
> Diff: https://reviews.apache.org/r/72879/diff/1/
> 
> 
> Testing
> ---
> 
> Tested Statistics UI from different users with different policies for 
> entityType and classfication.
> 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/25/console
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>

[jira] [Updated] (ATLAS-3948) Entity Creation: Index Consistency: Java Patch Handler: Provide Option to Disable

2020-09-17 Thread Ashutosh Mestry (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-3948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashutosh Mestry updated ATLAS-3948:
---
Attachment: ATLAS-3948-index-consistency-conditional.patch

> Entity Creation: Index Consistency: Java Patch Handler: Provide Option to 
> Disable
> -
>
> Key: ATLAS-3948
> URL: https://issues.apache.org/jira/browse/ATLAS-3948
> Project: Atlas
>  Issue Type: Bug
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Attachments: ATLAS-3948-index-consistency-conditional.patch
>
>
> *Background*
> The ATLAS-3907 provided ability to apply index consistency to existing 
> indexes via Java patch handler.
> However, when _atlas.graph.storage.consistency-lock.enabled=false_ this patch 
> still gets applied.
> *Solution*
> Check for the property in Java patch handler and avoid applying it if the 
> property is set to false.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (ATLAS-3948) Entity Creation: Index Consistency: Java Patch Handler: Provide Option to Disable

2020-09-17 Thread Ashutosh Mestry (Jira) 
Ashutosh Mestry created ATLAS-3948:
--

 Summary: Entity Creation: Index Consistency: Java Patch Handler: 
Provide Option to Disable
 Key: ATLAS-3948
 URL: https://issues.apache.org/jira/browse/ATLAS-3948
 Project: Atlas
  Issue Type: Bug
Reporter: Ashutosh Mestry
Assignee: Ashutosh Mestry


*Background*

The ATLAS-3907 provided ability to apply index consistency to existing indexes 
via Java patch handler.

However, when _atlas.graph.storage.consistency-lock.enabled=false_ this patch 
still gets applied.

*Solution*

Check for the property in Java patch handler and avoid applying it if the 
property is set to false.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 72879: ATLAS-3946 : Filter TypeDefs in Metrics API and show data accordingly

2020-09-17 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72879/#review221885
---


Fix it, then Ship it!





repository/src/main/java/org/apache/atlas/services/MetricsService.java
Lines 241 (patched)


Instead of parameter 'typesDef', consider returning from this method:
  AtlasTypesDef getTypesDef() {
AtlasTypesDef ret = new AtlasTypesDef();

...

return ret;
  }


- Madhan Neethiraj


On Sept. 17, 2020, 9:26 a.m., Nixon Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72879/
> ---
> 
> (Updated Sept. 17, 2020, 9:26 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nikhil Bonte, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3946
> https://issues.apache.org/jira/browse/ATLAS-3946
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Filter TypeDefs in Metrics API and show data accordingly, currently data is 
> shown for all types even if user do not have access to those types.
> 
> This patch filterTypeDefs after authorization and updates the data for 
> required types.
> 
> 
> Diffs
> -
> 
>   repository/src/main/java/org/apache/atlas/services/MetricsService.java 
> 7917f32e5 
>   webapp/src/main/java/org/apache/atlas/web/security/AtlasSecurityConfig.java 
> e74a9e93a 
> 
> 
> Diff: https://reviews.apache.org/r/72879/diff/1/
> 
> 
> Testing
> ---
> 
> Tested Statistics UI from different users with different policies for 
> entityType and classfication.
> 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/25/console
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>

Re: Review Request 72880: ATLAS-3947 : Skip authorization for read of _ALL_ENTITY_TYPES and _ALL_CLASSIFICATION_TYPES types

2020-09-17 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72880/#review221884
---


Ship it!




Ship It!

- Madhan Neethiraj


On Sept. 17, 2020, 10:28 a.m., Nixon Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72880/
> ---
> 
> (Updated Sept. 17, 2020, 10:28 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nikhil Bonte, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3947
> https://issues.apache.org/jira/browse/ATLAS-3947
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Skip authorization for read of _ALL_ENTITY_TYPES type of entity type and 
> _ALL_CLASSIFICATION_TYPES type of classification type.
> This are internally required by for system attributes search.
> 
> This patch Skip authorization for read of _ALL_ENTITY_TYPES entityType and 
> and _ALL_CLASSIFICATION_TYPES classificationType.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java
>  458ec49ea 
> 
> 
> Diff: https://reviews.apache.org/r/72880/diff/1/
> 
> 
> Testing
> ---
> 
> Tested API's with no policies on types for a user. _ALL_ENTITY_TYPES and 
> _ALL_CLASSIFICATION_TYPES are loaded correctly after it.
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>

[jira] [Updated] (ATLAS-3947) Skip authorization for read _ALL_ENTITY_TYPES and _ALL_CLASSIFICATION_TYPES types

2020-09-17 Thread Nixon Rodrigues (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-3947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-3947:
---
Attachment: ATLAS-3947.patch

> Skip authorization for read _ALL_ENTITY_TYPES and _ALL_CLASSIFICATION_TYPES 
> types
> -
>
> Key: ATLAS-3947
> URL: https://issues.apache.org/jira/browse/ATLAS-3947
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
> Attachments: ATLAS-3947.patch
>
>
> Skip authorization for read of _ALL_ENTITY_TYPES type of entity type  and 
> _ALL_CLASSIFICATION_TYPES type of classification type.
>  This are internally required by for system attributes search. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Review Request 72880: ATLAS-3947 : Skip authorization for read of _ALL_ENTITY_TYPES and _ALL_CLASSIFICATION_TYPES types

2020-09-17 Thread Nixon Rodrigues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72880/
---

Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nikhil Bonte, and 
Sarath Subramanian.


Bugs: ATLAS-3947
https://issues.apache.org/jira/browse/ATLAS-3947


Repository: atlas


Description
---

Skip authorization for read of _ALL_ENTITY_TYPES type of entity type and 
_ALL_CLASSIFICATION_TYPES type of classification type.
This are internally required by for system attributes search.

This patch Skip authorization for read of _ALL_ENTITY_TYPES entityType and and 
_ALL_CLASSIFICATION_TYPES classificationType.


Diffs
-

  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java
 458ec49ea 


Diff: https://reviews.apache.org/r/72880/diff/1/


Testing
---

Tested API's with no policies on types for a user. _ALL_ENTITY_TYPES and 
_ALL_CLASSIFICATION_TYPES are loaded correctly after it.


Thanks,

Nixon Rodrigues

[jira] [Created] (ATLAS-3947) Skip authorization for read _ALL_ENTITY_TYPES and _ALL_CLASSIFICATION_TYPES types

2020-09-17 Thread Nixon Rodrigues (Jira) 
Nixon Rodrigues created ATLAS-3947:
--

 Summary: Skip authorization for read _ALL_ENTITY_TYPES and 
_ALL_CLASSIFICATION_TYPES types
 Key: ATLAS-3947
 URL: https://issues.apache.org/jira/browse/ATLAS-3947
 Project: Atlas
  Issue Type: Improvement
Reporter: Nixon Rodrigues
Assignee: Nixon Rodrigues


Skip authorization for read of _ALL_ENTITY_TYPES type of entity type  and 
_ALL_CLASSIFICATION_TYPES type of classification type.
 This are internally required by for system attributes search. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Review Request 72879: ATLAS-3946 : Filter TypeDefs in Metrics API and show data accordingly

2020-09-17 Thread Nixon Rodrigues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72879/
---

Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nikhil Bonte, and 
Sarath Subramanian.


Bugs: ATLAS-3946
https://issues.apache.org/jira/browse/ATLAS-3946


Repository: atlas


Description
---

Filter TypeDefs in Metrics API and show data accordingly, currently data is 
shown for all types even if user do not have access to those types.

This patch filterTypeDefs after authorization and updates the data for required 
types.


Diffs
-

  repository/src/main/java/org/apache/atlas/services/MetricsService.java 
7917f32e5 
  webapp/src/main/java/org/apache/atlas/web/security/AtlasSecurityConfig.java 
e74a9e93a 


Diff: https://reviews.apache.org/r/72879/diff/1/


Testing
---

Tested Statistics UI from different users with different policies for 
entityType and classfication.

https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/25/console


Thanks,

Nixon Rodrigues

[jira] [Created] (ATLAS-3946) Filter TypeDefs in Metrics API and show data accordingly

2020-09-17 Thread Nixon Rodrigues (Jira) 
Nixon Rodrigues created ATLAS-3946:
--

 Summary: Filter TypeDefs in Metrics API and show data accordingly
 Key: ATLAS-3946
 URL: https://issues.apache.org/jira/browse/ATLAS-3946
 Project: Atlas
  Issue Type: Improvement
Reporter: Nixon Rodrigues
Assignee: Nixon Rodrigues


Filter TypeDefs in Metrics API and show data accordingly, currently data is 
shown for all types even if user do not have access to those types.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3827) UI: Use moment date format instead of default date format.

2020-09-17 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-3827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17197450#comment-17197450
 ] 

ASF subversion and git services commented on ATLAS-3827:


Commit d6d590a14d9005a52e01ad923e2c07dacab28f49 in atlas's branch 
refs/heads/branch-2.0 from Keval Bhatt
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=d6d590a ]

ATLAS-3827: UI: Use moment date format instead of default date format.

Signed-off-by: Nikhil Bonte 
(cherry picked from commit ee80e6a675317f15a99429d509ffd49670d5df0d)


> UI: Use moment date format instead of default date format.
> --
>
> Key: ATLAS-3827
> URL: https://issues.apache.org/jira/browse/ATLAS-3827
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-3827-1.patch, ATLAS-3827.patch, 
> image-2020-09-16-17-11-33-386.png, image-2020-09-16-17-12-04-512.png, 
> new_date_format.png
>
>
>  
> UI configured to use the following date formats:
> {code:java}
>  /MM/DD
>  /MM/DD HH:mm:ss
>  MM/DD/ h:mm A z
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3945) UI: Entity details page, Show N/A for date if date value is 0 or null

2020-09-17 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-3945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17197449#comment-17197449
 ] 

ASF subversion and git services commented on ATLAS-3945:


Commit cab21a8cd821e02d352cb091405e0906af6312b2 in atlas's branch 
refs/heads/branch-2.0 from Keval Bhatt
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=cab21a8 ]

ATLAS-3945: UI: Entity details page, Show N/A for date if date value is 0 or 
null

Signed-off-by: Nikhil Bonte 
(cherry picked from commit e6c382680d1a3fa3284b5c9a9026264fc5bd3957)


> UI: Entity details page,  Show N/A for date if date value is 0 or null
> --
>
> Key: ATLAS-3945
> URL: https://issues.apache.org/jira/browse/ATLAS-3945
> Project: Atlas
>  Issue Type: Bug
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-3945.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3945) UI: Entity details page, Show N/A for date if date value is 0 or null

2020-09-17 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-3945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17197444#comment-17197444
 ] 

ASF subversion and git services commented on ATLAS-3945:


Commit e6c382680d1a3fa3284b5c9a9026264fc5bd3957 in atlas's branch 
refs/heads/master from Keval Bhatt
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=e6c3826 ]

ATLAS-3945: UI: Entity details page, Show N/A for date if date value is 0 or 
null

Signed-off-by: Nikhil Bonte 


> UI: Entity details page,  Show N/A for date if date value is 0 or null
> --
>
> Key: ATLAS-3945
> URL: https://issues.apache.org/jira/browse/ATLAS-3945
> Project: Atlas
>  Issue Type: Bug
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-3945.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3827) UI: Use moment date format instead of default date format.

2020-09-17 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-3827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17197445#comment-17197445
 ] 

ASF subversion and git services commented on ATLAS-3827:


Commit ee80e6a675317f15a99429d509ffd49670d5df0d in atlas's branch 
refs/heads/master from Keval Bhatt
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=ee80e6a ]

ATLAS-3827: UI: Use moment date format instead of default date format.

Signed-off-by: Nikhil Bonte 


> UI: Use moment date format instead of default date format.
> --
>
> Key: ATLAS-3827
> URL: https://issues.apache.org/jira/browse/ATLAS-3827
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-3827-1.patch, ATLAS-3827.patch, 
> image-2020-09-16-17-11-33-386.png, image-2020-09-16-17-12-04-512.png, 
> new_date_format.png
>
>
>  
> UI configured to use the following date formats:
> {code:java}
>  /MM/DD
>  /MM/DD HH:mm:ss
>  MM/DD/ h:mm A z
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3827) UI: Use moment date format instead of default date format.

2020-09-17 Thread Nikhil Bonte (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-3827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17197438#comment-17197438
 ] 

Nikhil Bonte commented on ATLAS-3827:
-

+1 for the patch, thanks [~kevalbhatt].

> UI: Use moment date format instead of default date format.
> --
>
> Key: ATLAS-3827
> URL: https://issues.apache.org/jira/browse/ATLAS-3827
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-3827-1.patch, ATLAS-3827.patch, 
> image-2020-09-16-17-11-33-386.png, image-2020-09-16-17-12-04-512.png, 
> new_date_format.png
>
>
>  
> UI configured to use the following date formats:
> {code:java}
>  /MM/DD
>  /MM/DD HH:mm:ss
>  MM/DD/ h:mm A z
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3827) UI: Use moment date format instead of default date format.

2020-09-17 Thread Keval Bhatt (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-3827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-3827:
---
Attachment: ATLAS-3827-1.patch

> UI: Use moment date format instead of default date format.
> --
>
> Key: ATLAS-3827
> URL: https://issues.apache.org/jira/browse/ATLAS-3827
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-3827-1.patch, ATLAS-3827.patch, 
> image-2020-09-16-17-11-33-386.png, image-2020-09-16-17-12-04-512.png, 
> new_date_format.png
>
>
>  
> UI configured to use the following date formats:
> {code:java}
>  /MM/DD
>  /MM/DD HH:mm:ss
>  MM/DD/ h:mm A z
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3945) UI: Entity details page, Show N/A for date if date value is 0 or null

2020-09-17 Thread Nikhil Bonte (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-3945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17197436#comment-17197436
 ] 

Nikhil Bonte commented on ATLAS-3945:
-

+1 for the patch, thanks [~kevalbhatt].

> UI: Entity details page,  Show N/A for date if date value is 0 or null
> --
>
> Key: ATLAS-3945
> URL: https://issues.apache.org/jira/browse/ATLAS-3945
> Project: Atlas
>  Issue Type: Bug
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-3945.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)