Build failed in Jenkins: Atlas-master-IntegrationTests #813

2018-03-19 Thread Apache Jenkins Server 
See 


--
[...truncated 609.66 KB...]
127.0.0.1 - - [20/Mar/2018:04:20:08 +] "GET 
//localhost:31000/api/atlas/v2/entity/uniqueAttribute/type/hive_process?attr:qualifiedName=LOAD-%3E:default.tableuopdxzez3c@primary:1521519603000
 HTTP/1.1" 200 1564 "-" "Java/1.8.0_152"
127.0.0.1 - - [20/Mar/2018:04:20:08 +] "GET 
//localhost:31000/api/atlas/v2/entity/uniqueAttribute/type/hive_process?attr:qualifiedName=LOAD-%3E:default.tableuopdxzez3c@primary:1521519603000
 HTTP/1.1" 200 1564 "-" "Java/1.8.0_152"
127.0.0.1 - - [20/Mar/2018:04:20:09 +] "GET 
//localhost:31000/api/atlas/v2/entity/uniqueAttribute/type/hive_process?attr:qualifiedName=LOAD-%3E:default.table4vzdpkt5gg@primary:1521519608000
 HTTP/1.1" 404 177 "-" "Java/1.8.0_152"
127.0.0.1 - - [20/Mar/2018:04:20:14 +] "GET 
//localhost:31000/api/atlas/v2/entity/uniqueAttribute/type/hive_process?attr:qualifiedName=LOAD-%3E:default.table4vzdpkt5gg@primary:1521519608000
 HTTP/1.1" 200 1651 "-" "Java/1.8.0_152"
127.0.0.1 - - [20/Mar/2018:04:20:14 +] "GET 
//localhost:31000/api/atlas/v2/entity/uniqueAttribute/type/hive_process?attr:qualifiedName=LOAD-%3E:default.table4vzdpkt5gg@primary:1521519608000
 HTTP/1.1" 200 1651 "-" "Java/1.8.0_152"
127.0.0.1 - - [20/Mar/2018:04:20:18 +] "GET 
//localhost:31000/api/atlas/v2/entity/uniqueAttribute/type/hive_column?attr:qualifiedName=dbkjagoaqdz1.tablev8a65s68bo.id@primary
 HTTP/1.1" 404 163 "-" "Java/1.8.0_152"
127.0.0.1 - - [20/Mar/2018:04:20:23 +] "GET 
//localhost:31000/api/atlas/v2/entity/uniqueAttribute/type/hive_column?attr:qualifiedName=dbkjagoaqdz1.tablev8a65s68bo.id@primary
 HTTP/1.1" 200 799 "-" "Java/1.8.0_152"
127.0.0.1 - - [20/Mar/2018:04:20:23 +] "GET 
//localhost:31000/api/atlas/v2/entity/uniqueAttribute/type/hive_column?attr:qualifiedName=dbkjagoaqdz1.tablev8a65s68bo.id@primary
 HTTP/1.1" 200 799 "-" "Java/1.8.0_152"
127.0.0.1 - - [20/Mar/2018:04:20:23 +] "POST 
//localhost:31000/api/atlas/v2/types/typedefs/ HTTP/1.1" 200 425 "-" 
"Java/1.8.0_152"
127.0.0.1 - - [20/Mar/2018:04:20:23 +] "POST 
//localhost:31000/api/atlas/v2/entity/guid/d5e35161-6ccb-4d13-b1dd-1be1e08e8e49/classifications
 HTTP/1.1" 204 0 "-" "Java/1.8.0_152"
127.0.0.1 - - [20/Mar/2018:04:20:24 +] "GET 
//localhost:31000/api/atlas/v2/entity/uniqueAttribute/type/hive_column?attr:qualifiedName=dbkjagoaqdz1.tablev8a65s68bo.id_new@primary
 HTTP/1.1" 200 910 "-" "Java/1.8.0_152"
127.0.0.1 - - [20/Mar/2018:04:20:24 +] "GET 
//localhost:31000/api/atlas/v2/entity/uniqueAttribute/type/hive_column?attr:qualifiedName=dbkjagoaqdz1.tablev8a65s68bo.id_new@primary
 HTTP/1.1" 200 910 "-" "Java/1.8.0_152"
127.0.0.1 - - [20/Mar/2018:04:20:24 +] "GET 
//localhost:31000/api/atlas/entities/d5e35161-6ccb-4d13-b1dd-1be1e08e8e49 
HTTP/1.1" 200 1061 "-" "Java/1.8.0_152"
127.0.0.1 - - [20/Mar/2018:04:20:26 +] "GET 
//localhost:31000/api/atlas/v2/entity/uniqueAttribute/type/hive_table?attr:qualifiedName=default.tablezds5awhzem@primary
 HTTP/1.1" 200 4851 "-" "Java/1.8.0_152"
127.0.0.1 - - [20/Mar/2018:04:20:26 +] "GET 
//localhost:31000/api/atlas/v2/entity/uniqueAttribute/type/hive_table?attr:qualifiedName=default.tablezds5awhzem@primary
 HTTP/1.1" 200 4851 "-" "Java/1.8.0_152"
127.0.0.1 - - [20/Mar/2018:04:20:26 +] "GET 
//localhost:31000/api/atlas/v2/entity/uniqueAttribute/type/hive_process?attr:qualifiedName=TRUNCATETABLE-%3E:default.tablezds5awhzem@primary:1521519625000
 HTTP/1.1" 404 186 "-" "Java/1.8.0_152"
127.0.0.1 - - [20/Mar/2018:04:20:31 +] "GET 
//localhost:31000/api/atlas/v2/entity/uniqueAttribute/type/hive_process?attr:qualifiedName=TRUNCATETABLE-%3E:default.tablezds5awhzem@primary:1521519625000
 HTTP/1.1" 200 1153 "-" "Java/1.8.0_152"
127.0.0.1 - - [20/Mar/2018:04:20:31 +] "GET 
//localhost:31000/api/atlas/v2/entity/uniqueAttribute/type/hive_process?attr:qualifiedName=TRUNCATETABLE-%3E:default.tablezds5awhzem@primary:1521519625000
 HTTP/1.1" 200 1153 "-" "Java/1.8.0_152"
127.0.0.1 - - [20/Mar/2018:04:20:31 +] "GET 
//localhost:31000/api/atlas/v2/entity/guid/40961560-f38a-418c-b770-9b1157fe440f 
HTTP/1.1" 200 1153 "-" "Java/1.8.0_152"
127.0.0.1 - - [20/Mar/2018:04:20:31 +] "GET 
//localhost:31000/api/atlas/v2/entity/guid/a1cc42d5-7a86-43a7-a6c6-61e247c09c4a 
HTTP/1.1" 200 5093 "-" "Java/1.8.0_152"
127.0.0.1 - - [20/Mar/2018:04:20:31 +] "GET 
//localhost:31000/api/atlas/v2/lineage/a1cc42d5-7a86-43a7-a6c6-61e247c09c4a?depth=0&direction=INPUT
 HTTP/1.1" 200 135 "-" "Java/1.8.0_152"
127.0.0.1 - - [20/Mar/2018:04:20:34 +] "GET 
//localhost:31000/api/atlas/v2/entity/uniqueAttribute/type/hive_process?attr:qualifiedName=QUERY:default.tablexjutmnfjip@primary:1521519631000-%3E
 HTTP/1.1" 404 178 "-" "Java/1.8.0_152"
127.0.0.1 - - [20/Mar/2018:04:20:39 +] "GET 
//localhost:31000/api/atlas/v2/entity/uniqueAttribute/type/hive_process?attr:qualifiedName=QUERY:defau

Re: Review Request 66151: ATLAS-2507 : HBase hook for Atlas should have QualifiedName with ":" as suffix for Namespace instead of "."

2018-03-19 Thread Ramesh Mani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66151/
---

(Updated March 20, 2018, 1:22 a.m.)


Review request for atlas, Abhay Kulkarni and Madhan Neethiraj.


Changes
---

Fixed review comments


Bugs: ATLAS-2507
https://issues.apache.org/jira/browse/ATLAS-2507


Repository: atlas


Description
---

ATLAS-2507 : HBase hook for Atlas should have QualifiedName with ":" as suffix 
for Namespace instead of "."


Diffs (updated)
-

  
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java
 f165e98 
  
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/util/ImportHBaseEntitiesBase.java
 d11a1a0 


Diff: https://reviews.apache.org/r/66151/diff/2/

Changes: https://reviews.apache.org/r/66151/diff/1-2/


Testing
---

Verified in Local VM


Thanks,

Ramesh Mani

Re: Review Request 65885: ATLAS-2470 - Add JanusGraph Cassandra support to Atlas

2018-03-19 Thread Pierre Padovani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65885/
---

(Updated March 20, 2018, 12:04 a.m.)


Review request for atlas and David Radley.


Changes
---

Fixed the injection of the logback jars in the distribution, they no longer are 
being pulled in, and logging has returned to normal.

I attempted to do a full build with tests, but the tests in repository failed. 
I do not believe the failure is due to this patch, as the same exact failure 
happens in master. The cassandra based audit tests do pass even if the 
subsequent tests are failing.

As an additional test on this patch, I applied the patch to a clean master with:

git am < ATLAS=2470-4.patch

It did give some warnings on whitespace, but properly applied the patch. I then 
built and ran Atlas with embedded-cassandra-solr and it started up with no 
errors.


Bugs: ATLAS-2470
https://issues.apache.org/jira/browse/ATLAS-2470


Repository: atlas


Description
---

This updates pom's to add the needed cassandra jars, and adds a dist profile 
embedded-cassandra-solr.


Diffs (updated)
-

  distro/pom.xml 0103bef6 
  distro/src/bin/atlas_config.py e6415cf4 
  distro/src/bin/atlas_start.py 39be6b7c 
  distro/src/bin/atlas_stop.py 66edd904 
  distro/src/conf/atlas-application.properties 10fb7b86 
  distro/src/conf/atlas-env.sh 68b24e93 
  distro/src/conf/cassandra.yml.template PRE-CREATION 
  distro/src/conf/zookeeper/log4j.properties PRE-CREATION 
  distro/src/conf/zookeeper/zoo.cfg.template PRE-CREATION 
  distro/src/main/assemblies/standalone-package.xml 1881082e 
  docs/src/site/twiki/InstallationSteps.twiki 6b9f0313 
  graphdb/janus/pom.xml 143b775f 
  pom.xml 9ddc8e18 
  repository/pom.xml b1d6b1f9 
  
repository/src/main/java/org/apache/atlas/repository/audit/AbstractStorageBasedAuditRepository.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/audit/CassandraBasedAuditRepository.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java
 cee7374e 
  
repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java
 4d70b7f7 
  
repository/src/test/java/org/apache/atlas/repository/audit/CassandraAuditRepositoryTest.java
 PRE-CREATION 
  repository/src/test/resources/cassandra_test.yml PRE-CREATION 
  
server-api/src/main/java/org/apache/atlas/listener/ActiveStateChangeHandler.java
 7d282b30 


Diff: https://reviews.apache.org/r/65885/diff/4/

Changes: https://reviews.apache.org/r/65885/diff/3-4/


Testing
---

Full build with the new embedded-cassandra-solr, and testing to make sure Atlas 
comes up and is functional.

Be aware that we have been running Cassandra backed JanusGraph for months with 
no issues.

This patch now includes support for Cassandra as an audit store. I've also 
refactored the audit unit tests, and added cassandra specific tests.


Thanks,

Pierre Padovani

Re: Review Request 66151: ATLAS-2507 : HBase hook for Atlas should have QualifiedName with ":" as suffix for Namespace instead of "."

2018-03-19 Thread Abhay Kulkarni 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66151/#review199482
---


Fix it, then Ship it!





addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java
Line 380 (original), 380 (patched)


The format specifications are used in several places. Please consider 
replacing them with
public static final String HBASE_TABLE_QUALIFIED_NAME_FORMAT = "%s:%s@%s";
public static final String HBASE_COLUMN_FAMILY_QUALIFIED_NAME_FORMAT = 
"%s:%s.%s@%s";
in HBaseAtlasHook class.


- Abhay Kulkarni


On March 19, 2018, 9:44 p.m., Ramesh Mani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66151/
> ---
> 
> (Updated March 19, 2018, 9:44 p.m.)
> 
> 
> Review request for atlas, Abhay Kulkarni and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2507
> https://issues.apache.org/jira/browse/ATLAS-2507
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-2507 : HBase hook for Atlas should have QualifiedName with ":" as 
> suffix for Namespace instead of "."
> 
> 
> Diffs
> -
> 
>   
> addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java
>  f165e98 
>   
> addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/util/ImportHBaseEntitiesBase.java
>  d11a1a0 
> 
> 
> Diff: https://reviews.apache.org/r/66151/diff/1/
> 
> 
> Testing
> ---
> 
> Verified in Local VM
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>

Review Request 66151: ATLAS-2507 : HBase hook for Atlas should have QualifiedName with ":" as suffix for Namespace instead of "."

2018-03-19 Thread Ramesh Mani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66151/
---

Review request for atlas, Abhay Kulkarni and Madhan Neethiraj.


Bugs: ATLAS-2507
https://issues.apache.org/jira/browse/ATLAS-2507


Repository: atlas


Description
---

ATLAS-2507 : HBase hook for Atlas should have QualifiedName with ":" as suffix 
for Namespace instead of "."


Diffs
-

  
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java
 f165e98 
  
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/util/ImportHBaseEntitiesBase.java
 d11a1a0 


Diff: https://reviews.apache.org/r/66151/diff/1/


Testing
---

Verified in Local VM


Thanks,

Ramesh Mani

Re: Review Request 66027: ATLAS-2491:Atlas Hive hook should use atlas v2 api for Entity propagation

2018-03-19 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66027/#review199470
---


Ship it!




Ship It!

- Madhan Neethiraj


On March 19, 2018, 5:57 p.m., Ramesh Mani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66027/
> ---
> 
> (Updated March 19, 2018, 5:57 p.m.)
> 
> 
> Review request for atlas and Madhan Neethiraj.
> 
> 
> Bugs: ATLAS-2491
> https://issues.apache.org/jira/browse/ATLAS-2491
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-2491:Atlas Hive hook should use atlas v2 api for Entity propagation
> 
> 
> Diffs
> -
> 
>   
> addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/bridge/FalconBridge.java
>  11d13b38 
>   addons/hive-bridge/pom.xml 14e42959 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/ColumnLineageUtils.java
>  ba100085 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
>  4047c164 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/AtlasHiveHookContext.java
>  PRE-CREATION 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 
> 69d294cc 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterDatabase.java
>  PRE-CREATION 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterTable.java
>  PRE-CREATION 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterTableRename.java
>  PRE-CREATION 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterTableRenameCol.java
>  PRE-CREATION 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AtlasEvent.java
>  PRE-CREATION 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateDatabase.java
>  PRE-CREATION 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateHiveProcess.java
>  PRE-CREATION 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateTable.java
>  PRE-CREATION 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/DropDatabase.java
>  PRE-CREATION 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/DropTable.java
>  PRE-CREATION 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/rewrite/ASTRewriter.java
>  3a2506bd 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/rewrite/HiveASTRewriter.java
>  4cd219f3 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/rewrite/LiteralRewriter.java
>  789b9812 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/rewrite/RewriteContext.java
>  505616e9 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/rewrite/RewriteException.java
>  c87bf6ba 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/HiveITBase.java 
> 217c6aac 
>   
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/HiveLiteralRewriterTest.java
>  f4abfb6a 
>   
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridgeTest.java
>  ea669f34 
>   
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/HiveMetastoreBridgeIT.java
>  22d3c599 
>   addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
> f96d47d4 
>   
> addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/hook/SqoopHook.java 
> 06a0e9c4 
>   
> addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java
>  b0a4dab8 
> 
> 
> Diff: https://reviews.apache.org/r/66027/diff/3/
> 
> 
> Testing
> ---
> 
> Tested in local vm
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>

Re: Review Request 65885: ATLAS-2470 - Add JanusGraph Cassandra support to Atlas

2018-03-19 Thread Pierre Padovani 


> On March 19, 2018, 7:28 p.m., David Radley wrote:
> > docs/src/site/twiki/InstallationSteps.twiki
> > Lines 45 (patched)
> > 
> >
> > I built Atlas as per these instructions. I then started atlas. Atlas 
> > started and worked - but when I looked at the application.log there was 
> > only 3 log entries.  
> > 
> > 2018-03-19 12:22:22,447 WARN  - [main:] ~ No meta.properties file under 
> > dir 
> > /Users/david/atlasreview2/distro/target/apache-atlas-1.0.0-SNAPSHOT-bin/apache-atlas-1.0.0-SNAPSHOT/data/kafka/kafka/meta.properties
> >  (Logging$class:87)
> > 2018-03-19 12:22:22,922 WARN  - [main:] ~ No meta.properties file under 
> > dir 
> > /Users/david/atlasreview2/distro/target/apache-atlas-1.0.0-SNAPSHOT-bin/apache-atlas-1.0.0-SNAPSHOT/data/kafka/kafka/meta.properties
> >  (Logging$class:87)
> > 2018-03-19 12:22:22,986 INFO  - [NotificationHookConsumer thread-0:] ~ 
> > [atlas-hook-consumer-thread]: Starting (Logging$class:72)
> > 
> > 
> > I would have expected much more logging.
> 
> Pierre Padovani wrote:
> This confused me as well. All of the logging is in the the newest 
> atlas..out file. Which makes sense when log4j is configured to 
> log to a rolling date/time stamped file. In previous builds of Atlas the 
> logging all showed up in the application.log file. This change in behavior 
> happened to me within the last few weeks. Do we know if a change was made to 
> induce this? or Was this induced by my changes?
> 
> I'll do some testing on my side.
> 
> Pierre Padovani wrote:
> Just retested off of master... something in the cassandra jars for Janus 
> must be overriding the Atlas logging configuration. I'll investigate.

Ok... the logback jars are being pulled into the distro... If you remove them 
from server/webapp/atlas/WEB-INF/lib you should have the expected behavior. 
I'll work on updating the patch to exclude those jars.


- Pierre


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65885/#review199456
---


On March 19, 2018, 11:51 a.m., Pierre Padovani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65885/
> ---
> 
> (Updated March 19, 2018, 11:51 a.m.)
> 
> 
> Review request for atlas and David Radley.
> 
> 
> Bugs: ATLAS-2470
> https://issues.apache.org/jira/browse/ATLAS-2470
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This updates pom's to add the needed cassandra jars, and adds a dist profile 
> embedded-cassandra-solr.
> 
> 
> Diffs
> -
> 
>   distro/pom.xml 0103bef6 
>   distro/src/bin/atlas_config.py e6415cf4 
>   distro/src/bin/atlas_start.py 39be6b7c 
>   distro/src/bin/atlas_stop.py 66edd904 
>   distro/src/conf/atlas-application.properties 10fb7b86 
>   distro/src/conf/atlas-env.sh 68b24e93 
>   distro/src/conf/cassandra.yml.template PRE-CREATION 
>   distro/src/conf/zookeeper/log4j.properties PRE-CREATION 
>   distro/src/conf/zookeeper/zoo.cfg.template PRE-CREATION 
>   distro/src/main/assemblies/standalone-package.xml 1881082e 
>   docs/src/site/twiki/InstallationSteps.twiki 6b9f0313 
>   graphdb/janus/pom.xml 143b775f 
>   repository/pom.xml b1d6b1f9 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/AbstractStorageBasedAuditRepository.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/CassandraBasedAuditRepository.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java
>  cee7374e 
>   
> repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java
>  4d70b7f7 
>   
> repository/src/test/java/org/apache/atlas/repository/audit/CassandraAuditRepositoryTest.java
>  PRE-CREATION 
>   repository/src/test/resources/cassandra_test.yml PRE-CREATION 
>   
> server-api/src/main/java/org/apache/atlas/listener/ActiveStateChangeHandler.java
>  7d282b30 
> 
> 
> Diff: https://reviews.apache.org/r/65885/diff/3/
> 
> 
> Testing
> ---
> 
> Full build with the new embedded-cassandra-solr, and testing to make sure 
> Atlas comes up and is functional.
> 
> Be aware that we have been running Cassandra backed JanusGraph for months 
> with no issues.
> 
> This patch now includes support for Cassandra as an audit store. I've also 
> refactored the audit unit tests, and added cassandra specific tests.
> 
> 
> Thanks,
> 
> Pierre Padovani
> 
>

Re: Review Request 65885: ATLAS-2470 - Add JanusGraph Cassandra support to Atlas

2018-03-19 Thread Pierre Padovani 


> On March 19, 2018, 7:28 p.m., David Radley wrote:
> > docs/src/site/twiki/InstallationSteps.twiki
> > Lines 45 (patched)
> > 
> >
> > I built Atlas as per these instructions. I then started atlas. Atlas 
> > started and worked - but when I looked at the application.log there was 
> > only 3 log entries.  
> > 
> > 2018-03-19 12:22:22,447 WARN  - [main:] ~ No meta.properties file under 
> > dir 
> > /Users/david/atlasreview2/distro/target/apache-atlas-1.0.0-SNAPSHOT-bin/apache-atlas-1.0.0-SNAPSHOT/data/kafka/kafka/meta.properties
> >  (Logging$class:87)
> > 2018-03-19 12:22:22,922 WARN  - [main:] ~ No meta.properties file under 
> > dir 
> > /Users/david/atlasreview2/distro/target/apache-atlas-1.0.0-SNAPSHOT-bin/apache-atlas-1.0.0-SNAPSHOT/data/kafka/kafka/meta.properties
> >  (Logging$class:87)
> > 2018-03-19 12:22:22,986 INFO  - [NotificationHookConsumer thread-0:] ~ 
> > [atlas-hook-consumer-thread]: Starting (Logging$class:72)
> > 
> > 
> > I would have expected much more logging.
> 
> Pierre Padovani wrote:
> This confused me as well. All of the logging is in the the newest 
> atlas..out file. Which makes sense when log4j is configured to 
> log to a rolling date/time stamped file. In previous builds of Atlas the 
> logging all showed up in the application.log file. This change in behavior 
> happened to me within the last few weeks. Do we know if a change was made to 
> induce this? or Was this induced by my changes?
> 
> I'll do some testing on my side.

Just retested off of master... something in the cassandra jars for Janus must 
be overriding the Atlas logging configuration. I'll investigate.


- Pierre


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65885/#review199456
---


On March 19, 2018, 11:51 a.m., Pierre Padovani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65885/
> ---
> 
> (Updated March 19, 2018, 11:51 a.m.)
> 
> 
> Review request for atlas and David Radley.
> 
> 
> Bugs: ATLAS-2470
> https://issues.apache.org/jira/browse/ATLAS-2470
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This updates pom's to add the needed cassandra jars, and adds a dist profile 
> embedded-cassandra-solr.
> 
> 
> Diffs
> -
> 
>   distro/pom.xml 0103bef6 
>   distro/src/bin/atlas_config.py e6415cf4 
>   distro/src/bin/atlas_start.py 39be6b7c 
>   distro/src/bin/atlas_stop.py 66edd904 
>   distro/src/conf/atlas-application.properties 10fb7b86 
>   distro/src/conf/atlas-env.sh 68b24e93 
>   distro/src/conf/cassandra.yml.template PRE-CREATION 
>   distro/src/conf/zookeeper/log4j.properties PRE-CREATION 
>   distro/src/conf/zookeeper/zoo.cfg.template PRE-CREATION 
>   distro/src/main/assemblies/standalone-package.xml 1881082e 
>   docs/src/site/twiki/InstallationSteps.twiki 6b9f0313 
>   graphdb/janus/pom.xml 143b775f 
>   repository/pom.xml b1d6b1f9 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/AbstractStorageBasedAuditRepository.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/CassandraBasedAuditRepository.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java
>  cee7374e 
>   
> repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java
>  4d70b7f7 
>   
> repository/src/test/java/org/apache/atlas/repository/audit/CassandraAuditRepositoryTest.java
>  PRE-CREATION 
>   repository/src/test/resources/cassandra_test.yml PRE-CREATION 
>   
> server-api/src/main/java/org/apache/atlas/listener/ActiveStateChangeHandler.java
>  7d282b30 
> 
> 
> Diff: https://reviews.apache.org/r/65885/diff/3/
> 
> 
> Testing
> ---
> 
> Full build with the new embedded-cassandra-solr, and testing to make sure 
> Atlas comes up and is functional.
> 
> Be aware that we have been running Cassandra backed JanusGraph for months 
> with no issues.
> 
> This patch now includes support for Cassandra as an audit store. I've also 
> refactored the audit unit tests, and added cassandra specific tests.
> 
> 
> Thanks,
> 
> Pierre Padovani
> 
>

Re: Review Request 65885: ATLAS-2470 - Add JanusGraph Cassandra support to Atlas

2018-03-19 Thread Pierre Padovani 


> On March 19, 2018, 7:28 p.m., David Radley wrote:
> > docs/src/site/twiki/InstallationSteps.twiki
> > Lines 45 (patched)
> > 
> >
> > I built Atlas as per these instructions. I then started atlas. Atlas 
> > started and worked - but when I looked at the application.log there was 
> > only 3 log entries.  
> > 
> > 2018-03-19 12:22:22,447 WARN  - [main:] ~ No meta.properties file under 
> > dir 
> > /Users/david/atlasreview2/distro/target/apache-atlas-1.0.0-SNAPSHOT-bin/apache-atlas-1.0.0-SNAPSHOT/data/kafka/kafka/meta.properties
> >  (Logging$class:87)
> > 2018-03-19 12:22:22,922 WARN  - [main:] ~ No meta.properties file under 
> > dir 
> > /Users/david/atlasreview2/distro/target/apache-atlas-1.0.0-SNAPSHOT-bin/apache-atlas-1.0.0-SNAPSHOT/data/kafka/kafka/meta.properties
> >  (Logging$class:87)
> > 2018-03-19 12:22:22,986 INFO  - [NotificationHookConsumer thread-0:] ~ 
> > [atlas-hook-consumer-thread]: Starting (Logging$class:72)
> > 
> > 
> > I would have expected much more logging.

This confused me as well. All of the logging is in the the newest atlas..out file. Which makes sense when log4j is configured to log to a rolling 
date/time stamped file. In previous builds of Atlas the logging all showed up 
in the application.log file. This change in behavior happened to me within the 
last few weeks. Do we know if a change was made to induce this? or Was this 
induced by my changes?

I'll do some testing on my side.


- Pierre


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65885/#review199456
---


On March 19, 2018, 11:51 a.m., Pierre Padovani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65885/
> ---
> 
> (Updated March 19, 2018, 11:51 a.m.)
> 
> 
> Review request for atlas and David Radley.
> 
> 
> Bugs: ATLAS-2470
> https://issues.apache.org/jira/browse/ATLAS-2470
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This updates pom's to add the needed cassandra jars, and adds a dist profile 
> embedded-cassandra-solr.
> 
> 
> Diffs
> -
> 
>   distro/pom.xml 0103bef6 
>   distro/src/bin/atlas_config.py e6415cf4 
>   distro/src/bin/atlas_start.py 39be6b7c 
>   distro/src/bin/atlas_stop.py 66edd904 
>   distro/src/conf/atlas-application.properties 10fb7b86 
>   distro/src/conf/atlas-env.sh 68b24e93 
>   distro/src/conf/cassandra.yml.template PRE-CREATION 
>   distro/src/conf/zookeeper/log4j.properties PRE-CREATION 
>   distro/src/conf/zookeeper/zoo.cfg.template PRE-CREATION 
>   distro/src/main/assemblies/standalone-package.xml 1881082e 
>   docs/src/site/twiki/InstallationSteps.twiki 6b9f0313 
>   graphdb/janus/pom.xml 143b775f 
>   repository/pom.xml b1d6b1f9 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/AbstractStorageBasedAuditRepository.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/CassandraBasedAuditRepository.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java
>  cee7374e 
>   
> repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java
>  4d70b7f7 
>   
> repository/src/test/java/org/apache/atlas/repository/audit/CassandraAuditRepositoryTest.java
>  PRE-CREATION 
>   repository/src/test/resources/cassandra_test.yml PRE-CREATION 
>   
> server-api/src/main/java/org/apache/atlas/listener/ActiveStateChangeHandler.java
>  7d282b30 
> 
> 
> Diff: https://reviews.apache.org/r/65885/diff/3/
> 
> 
> Testing
> ---
> 
> Full build with the new embedded-cassandra-solr, and testing to make sure 
> Atlas comes up and is functional.
> 
> Be aware that we have been running Cassandra backed JanusGraph for months 
> with no issues.
> 
> This patch now includes support for Cassandra as an audit store. I've also 
> refactored the audit unit tests, and added cassandra specific tests.
> 
> 
> Thanks,
> 
> Pierre Padovani
> 
>

Re: Review Request 65885: ATLAS-2470 - Add JanusGraph Cassandra support to Atlas

2018-03-19 Thread David Radley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65885/#review199456
---




docs/src/site/twiki/InstallationSteps.twiki
Lines 45 (patched)


I built Atlas as per these instructions. I then started atlas. Atlas 
started and worked - but when I looked at the application.log there was only 3 
log entries.  

2018-03-19 12:22:22,447 WARN  - [main:] ~ No meta.properties file under dir 
/Users/david/atlasreview2/distro/target/apache-atlas-1.0.0-SNAPSHOT-bin/apache-atlas-1.0.0-SNAPSHOT/data/kafka/kafka/meta.properties
 (Logging$class:87)
2018-03-19 12:22:22,922 WARN  - [main:] ~ No meta.properties file under dir 
/Users/david/atlasreview2/distro/target/apache-atlas-1.0.0-SNAPSHOT-bin/apache-atlas-1.0.0-SNAPSHOT/data/kafka/kafka/meta.properties
 (Logging$class:87)
2018-03-19 12:22:22,986 INFO  - [NotificationHookConsumer thread-0:] ~ 
[atlas-hook-consumer-thread]: Starting (Logging$class:72)

I would have expected much more logging.


- David Radley


On March 19, 2018, 11:51 a.m., Pierre Padovani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65885/
> ---
> 
> (Updated March 19, 2018, 11:51 a.m.)
> 
> 
> Review request for atlas and David Radley.
> 
> 
> Bugs: ATLAS-2470
> https://issues.apache.org/jira/browse/ATLAS-2470
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This updates pom's to add the needed cassandra jars, and adds a dist profile 
> embedded-cassandra-solr.
> 
> 
> Diffs
> -
> 
>   distro/pom.xml 0103bef6 
>   distro/src/bin/atlas_config.py e6415cf4 
>   distro/src/bin/atlas_start.py 39be6b7c 
>   distro/src/bin/atlas_stop.py 66edd904 
>   distro/src/conf/atlas-application.properties 10fb7b86 
>   distro/src/conf/atlas-env.sh 68b24e93 
>   distro/src/conf/cassandra.yml.template PRE-CREATION 
>   distro/src/conf/zookeeper/log4j.properties PRE-CREATION 
>   distro/src/conf/zookeeper/zoo.cfg.template PRE-CREATION 
>   distro/src/main/assemblies/standalone-package.xml 1881082e 
>   docs/src/site/twiki/InstallationSteps.twiki 6b9f0313 
>   graphdb/janus/pom.xml 143b775f 
>   repository/pom.xml b1d6b1f9 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/AbstractStorageBasedAuditRepository.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/CassandraBasedAuditRepository.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java
>  cee7374e 
>   
> repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java
>  4d70b7f7 
>   
> repository/src/test/java/org/apache/atlas/repository/audit/CassandraAuditRepositoryTest.java
>  PRE-CREATION 
>   repository/src/test/resources/cassandra_test.yml PRE-CREATION 
>   
> server-api/src/main/java/org/apache/atlas/listener/ActiveStateChangeHandler.java
>  7d282b30 
> 
> 
> Diff: https://reviews.apache.org/r/65885/diff/3/
> 
> 
> Testing
> ---
> 
> Full build with the new embedded-cassandra-solr, and testing to make sure 
> Atlas comes up and is functional.
> 
> Be aware that we have been running Cassandra backed JanusGraph for months 
> with no issues.
> 
> This patch now includes support for Cassandra as an audit store. I've also 
> refactored the audit unit tests, and added cassandra specific tests.
> 
> 
> Thanks,
> 
> Pierre Padovani
> 
>

[jira] [Created] (ATLAS-2507) HBase hook for Atlas should have QualifiedName with ":" as suffix for Namespace instead of "."

2018-03-19 Thread Ramesh Mani (JIRA) 
Ramesh Mani created ATLAS-2507:
--

 Summary: HBase hook for Atlas should have QualifiedName with ":" 
as suffix for Namespace instead of "."
 Key: ATLAS-2507
 URL: https://issues.apache.org/jira/browse/ATLAS-2507
 Project: Atlas
  Issue Type: Bug
  Components: atlas-intg
Reporter: Ramesh Mani
Assignee: Ramesh Mani


HBase hook for Atlas should have QualifiedName with ":" as suffix for Namespace 
instead of "."
This is need as in HBase Namespace association with Table is marked with ":" 
with HBase and when Tag associated to Namespace / Table is propagated to 
Ranger, then Qualified name for Table / Column family should have 
"NAMESPACE:TABLE". 
Currently it is in format "NAMESPACE.TABLE" in Atlas and this is send to 
Ranger.Policy is created for this 
resource name. When HBase send Table with Namespace in the Ranger Authorization 
request, the format is "NAMESPACE:TABLE" and policy created with TAG is not 
effective because of this mismatch.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 66027: ATLAS-2491:Atlas Hive hook should use atlas v2 api for Entity propagation

2018-03-19 Thread Ramesh Mani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66027/
---

(Updated March 19, 2018, 5:57 p.m.)


Review request for atlas and Madhan Neethiraj.


Changes
---

IT and Unit test fixes


Bugs: ATLAS-2491
https://issues.apache.org/jira/browse/ATLAS-2491


Repository: atlas


Description
---

ATLAS-2491:Atlas Hive hook should use atlas v2 api for Entity propagation


Diffs (updated)
-

  
addons/falcon-bridge/src/main/java/org/apache/atlas/falcon/bridge/FalconBridge.java
 11d13b38 
  addons/hive-bridge/pom.xml 14e42959 
  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/ColumnLineageUtils.java
 ba100085 
  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
 4047c164 
  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/AtlasHiveHookContext.java
 PRE-CREATION 
  addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 
69d294cc 
  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterDatabase.java
 PRE-CREATION 
  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterTable.java
 PRE-CREATION 
  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterTableRename.java
 PRE-CREATION 
  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AlterTableRenameCol.java
 PRE-CREATION 
  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/AtlasEvent.java
 PRE-CREATION 
  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateDatabase.java
 PRE-CREATION 
  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateHiveProcess.java
 PRE-CREATION 
  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/CreateTable.java
 PRE-CREATION 
  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/DropDatabase.java
 PRE-CREATION 
  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/DropTable.java
 PRE-CREATION 
  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/rewrite/ASTRewriter.java 
3a2506bd 
  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/rewrite/HiveASTRewriter.java
 4cd219f3 
  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/rewrite/LiteralRewriter.java
 789b9812 
  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/rewrite/RewriteContext.java
 505616e9 
  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/rewrite/RewriteException.java
 c87bf6ba 
  addons/hive-bridge/src/test/java/org/apache/atlas/hive/HiveITBase.java 
217c6aac 
  
addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/HiveLiteralRewriterTest.java
 f4abfb6a 
  
addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridgeTest.java
 ea669f34 
  
addons/hive-bridge/src/test/java/org/apache/atlas/hive/bridge/HiveMetastoreBridgeIT.java
 22d3c599 
  addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/HiveHookIT.java 
f96d47d4 
  addons/sqoop-bridge/src/main/java/org/apache/atlas/sqoop/hook/SqoopHook.java 
06a0e9c4 
  
addons/storm-bridge/src/main/java/org/apache/atlas/storm/hook/StormAtlasHook.java
 b0a4dab8 


Diff: https://reviews.apache.org/r/66027/diff/3/

Changes: https://reviews.apache.org/r/66027/diff/2-3/


Testing
---

Tested in local vm


Thanks,

Ramesh Mani

Review Request 66134: ATLAS-2506 : Attributes of filters in the inner filter group are not added to "attributes" JSON array of the Basic POST request body

2018-03-19 Thread pratik pandey 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66134/
---

Review request for atlas, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and 
Sharmadha Sainath.


Bugs: ATLAS-2506
https://issues.apache.org/jira/browse/ATLAS-2506


Repository: atlas


Description
---

Attributes of the filters added in the inner filter group are not added in the 
"attributes" parameter of the POST body.

Hence "attributes" in the POST body has only createTime , retention and not 
temporary.


Diffs
-

  dashboardv2/public/js/views/search/SearchLayoutView.js a0cd41e 


Diff: https://reviews.apache.org/r/66134/diff/1/


Testing
---

Done one round of sanity testing.


Thanks,

pratik pandey

[jira] [Updated] (ATLAS-2506) Attributes of filters in the inner filter group are not added to "attributes" JSON array of the Basic POST request body

2018-03-19 Thread pratik pandey (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ATLAS-2506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey updated ATLAS-2506:
-
Attachment: ATLAS-2506.patch

> Attributes of filters in the inner filter group are not added to "attributes" 
> JSON array of the Basic POST request body
> ---
>
> Key: ATLAS-2506
> URL: https://issues.apache.org/jira/browse/ATLAS-2506
> Project: Atlas
>  Issue Type: Bug
>Reporter: pratik pandey
>Assignee: pratik pandey
>Priority: Major
> Attachments: ATLAS-2506.patch, Faceted_search.png
>
>
> Attributes of the filters added in the inner filter group are not added in 
> the "attributes" parameter of the POST body.
> Hence "attributes" in the POST body has only createTime , retention and not 
> temporary.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Jenkins build is back to normal : Atlas-master-IntegrationTests #808

2018-03-19 Thread Apache Jenkins Server 
See

[jira] [Updated] (ATLAS-2504) UI , Tag propagation : When an entity has the same tag propagated and directly associated , update window shows the values of propagated tags.

2018-03-19 Thread pratik pandey (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ATLAS-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey updated ATLAS-2504:
-
Attachment: ATLAS-2504.patch

> UI , Tag propagation : When an entity has the same tag propagated and 
> directly associated , update window shows the values of propagated tags.
> --
>
> Key: ATLAS-2504
> URL: https://issues.apache.org/jira/browse/ATLAS-2504
> Project: Atlas
>  Issue Type: Bug
>Reporter: pratik pandey
>Assignee: pratik pandey
>Priority: Major
> Attachments: ATLAS-2504.patch, tag_propagation_UI.mov
>
>
> 1. Created 2 tables employee and employee_ctas as CTAS of employee.
> 2. Created tag PII with attributes(a - float)
> 3. Associated PII to employee with attribute values (a =0.5). Now tag is 
> propagated to employee_ctas also.
> 4. Associated PII to employee_ctas with attribute values (a = 0.7).
> 5. On clicking the Edit classification of employee_ctas , values of PII 
> associated to employee table was shown instead of employee_ctas table. 
> Attached the video clip . [^tag_propagation_UI.mov] 
> 6.But on updating the values , correctly updated the employee_ctas table 
> only. (For example , in the video clip , updated a to 0.8 and it updated PII 
> of employee_ctas)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Review Request 66133: ATLAS-2504 : UI , Tag propagation : When an entity has the same tag propagated and directly associated , update window shows the values of propagated tags.

2018-03-19 Thread pratik pandey 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66133/
---

Review request for atlas, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and 
Sharmadha Sainath.


Bugs: ATLAS-2504
https://issues.apache.org/jira/browse/ATLAS-2504


Repository: atlas


Description
---

1. Created 2 tables employee and employee_ctas as CTAS of employee.
2. Created tag PII with attributes(a - float)
3. Associated PII to employee with attribute values (a =0.5). Now tag is 
propagated to employee_ctas also.
4. Associated PII to employee_ctas with attribute values (a = 0.7).
5. On clicking the Edit classification of employee_ctas , values of PII 
associated to employee table was shown instead of  employee_ctas 
table.
6.But on updating the values , correctly updated the employee_ctas table only. 
(For example , in the video clip , updated a to 0.8 and it updated PII of 
employee_ctas)


Diffs
-

  dashboardv2/public/js/views/tag/TagDetailTableLayoutView.js 2296dad 


Diff: https://reviews.apache.org/r/66133/diff/1/


Testing
---

Done one round of sanity testing.


Thanks,

pratik pandey

Re: Review Request 65885: ATLAS-2470 - Add JanusGraph Cassandra support to Atlas

2018-03-19 Thread Pierre Padovani 


> On March 19, 2018, 12:31 a.m., David Radley wrote:
> > distro/src/conf/atlas-application.properties
> > Line 23 (original), 23 (patched)
> > 
> >
> > Sorry for the delay in reviewing. Unfortunatley the patch now does not 
> > apply to master I get: 
> > git am < ../ATLAS-2470-2.patch 
> > Applying: ATLAS-2470 - JanusGraph Cassandra support
> > .git/rebase-apply/patch:1146: trailing whitespace.
> > # The number of ticks that the initial 
> > error: patch failed: distro/src/conf/atlas-application.properties:24
> > error: distro/src/conf/atlas-application.properties: patch does not 
> > apply
> > .git/rebase-apply/patch:1039: new blank line at EOF.
> > +
> > .git/rebase-apply/patch:2761: new blank line at EOF.
> > +
> > Patch failed at 0001 ATLAS-2470 - JanusGraph Cassandra support

Ok.. I uploaded a new diff after rebasing off of master. However it still 
cannot be applied for similar reasons. A quick google soved my issues...

git am --3way < ATLAS-2470-3.patch

properly applies the patch.

https://www.lullabot.com/articles/git-best-practices-upgrading-the-patch-process


- Pierre


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65885/#review199398
---


On March 19, 2018, 11:51 a.m., Pierre Padovani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65885/
> ---
> 
> (Updated March 19, 2018, 11:51 a.m.)
> 
> 
> Review request for atlas and David Radley.
> 
> 
> Bugs: ATLAS-2470
> https://issues.apache.org/jira/browse/ATLAS-2470
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This updates pom's to add the needed cassandra jars, and adds a dist profile 
> embedded-cassandra-solr.
> 
> 
> Diffs
> -
> 
>   distro/pom.xml 0103bef6 
>   distro/src/bin/atlas_config.py e6415cf4 
>   distro/src/bin/atlas_start.py 39be6b7c 
>   distro/src/bin/atlas_stop.py 66edd904 
>   distro/src/conf/atlas-application.properties 10fb7b86 
>   distro/src/conf/atlas-env.sh 68b24e93 
>   distro/src/conf/cassandra.yml.template PRE-CREATION 
>   distro/src/conf/zookeeper/log4j.properties PRE-CREATION 
>   distro/src/conf/zookeeper/zoo.cfg.template PRE-CREATION 
>   distro/src/main/assemblies/standalone-package.xml 1881082e 
>   docs/src/site/twiki/InstallationSteps.twiki 6b9f0313 
>   graphdb/janus/pom.xml 143b775f 
>   repository/pom.xml b1d6b1f9 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/AbstractStorageBasedAuditRepository.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/CassandraBasedAuditRepository.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java
>  cee7374e 
>   
> repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java
>  4d70b7f7 
>   
> repository/src/test/java/org/apache/atlas/repository/audit/CassandraAuditRepositoryTest.java
>  PRE-CREATION 
>   repository/src/test/resources/cassandra_test.yml PRE-CREATION 
>   
> server-api/src/main/java/org/apache/atlas/listener/ActiveStateChangeHandler.java
>  7d282b30 
> 
> 
> Diff: https://reviews.apache.org/r/65885/diff/3/
> 
> 
> Testing
> ---
> 
> Full build with the new embedded-cassandra-solr, and testing to make sure 
> Atlas comes up and is functional.
> 
> Be aware that we have been running Cassandra backed JanusGraph for months 
> with no issues.
> 
> This patch now includes support for Cassandra as an audit store. I've also 
> refactored the audit unit tests, and added cassandra specific tests.
> 
> 
> Thanks,
> 
> Pierre Padovani
> 
>

[jira] [Updated] (ATLAS-2470) Basic support for Cassandra

2018-03-19 Thread Pierre Padovani (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ATLAS-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Padovani updated ATLAS-2470:
---
Attachment: ATLAS-2470-3.patch

> Basic support for Cassandra 
> 
>
> Key: ATLAS-2470
> URL: https://issues.apache.org/jira/browse/ATLAS-2470
> Project: Atlas
>  Issue Type: Sub-task
>Affects Versions: 1.0.0
>Reporter: Pierre Padovani
>Assignee: Pierre Padovani
>Priority: Major
> Fix For: 1.0.0
>
> Attachments: ATLAS-2470-1.patch, ATLAS-2470-2.patch, 
> ATLAS-2470-3.patch, ATLAS-2470.patch
>
>
> Add the basic build support, and ability to run embedded Cassandra and solr 
> using a profile build:
> -Pdist,embedded-cassandra-solr



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Re: Review Request 65885: ATLAS-2470 - Add JanusGraph Cassandra support to Atlas

2018-03-19 Thread Pierre Padovani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65885/
---

(Updated March 19, 2018, 11:51 a.m.)


Review request for atlas and David Radley.


Changes
---

Rebased off of master and regenerated the patch. Git is weird... a rebase 
showed no conflicts, but attempting to apply the previous version of the patch 
did.


Bugs: ATLAS-2470
https://issues.apache.org/jira/browse/ATLAS-2470


Repository: atlas


Description
---

This updates pom's to add the needed cassandra jars, and adds a dist profile 
embedded-cassandra-solr.


Diffs (updated)
-

  distro/pom.xml 0103bef6 
  distro/src/bin/atlas_config.py e6415cf4 
  distro/src/bin/atlas_start.py 39be6b7c 
  distro/src/bin/atlas_stop.py 66edd904 
  distro/src/conf/atlas-application.properties 10fb7b86 
  distro/src/conf/atlas-env.sh 68b24e93 
  distro/src/conf/cassandra.yml.template PRE-CREATION 
  distro/src/conf/zookeeper/log4j.properties PRE-CREATION 
  distro/src/conf/zookeeper/zoo.cfg.template PRE-CREATION 
  distro/src/main/assemblies/standalone-package.xml 1881082e 
  docs/src/site/twiki/InstallationSteps.twiki 6b9f0313 
  graphdb/janus/pom.xml 143b775f 
  repository/pom.xml b1d6b1f9 
  
repository/src/main/java/org/apache/atlas/repository/audit/AbstractStorageBasedAuditRepository.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/audit/CassandraBasedAuditRepository.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java
 cee7374e 
  
repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java
 4d70b7f7 
  
repository/src/test/java/org/apache/atlas/repository/audit/CassandraAuditRepositoryTest.java
 PRE-CREATION 
  repository/src/test/resources/cassandra_test.yml PRE-CREATION 
  
server-api/src/main/java/org/apache/atlas/listener/ActiveStateChangeHandler.java
 7d282b30 


Diff: https://reviews.apache.org/r/65885/diff/3/

Changes: https://reviews.apache.org/r/65885/diff/2-3/


Testing
---

Full build with the new embedded-cassandra-solr, and testing to make sure Atlas 
comes up and is functional.

Be aware that we have been running Cassandra backed JanusGraph for months with 
no issues.

This patch now includes support for Cassandra as an audit store. I've also 
refactored the audit unit tests, and added cassandra specific tests.


Thanks,

Pierre Padovani

[jira] [Updated] (ATLAS-2505) Set client IP to authorization request call for audit logging.

2018-03-19 Thread Nixon Rodrigues (JIRA) 

 [ 
https://issues.apache.org/jira/browse/ATLAS-2505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-2505:
---
Attachment: ATLAS-2505.1.patch

> Set client IP to authorization request call for audit logging.
> --
>
> Key: ATLAS-2505
> URL: https://issues.apache.org/jira/browse/ATLAS-2505
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: trunk
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
> Fix For: 1.0.0
>
> Attachments: ATLAS-2505.1.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Review Request 66132: ATLAS-2505 :- Set client IP to authorization request call for audit logging.

2018-03-19 Thread Nixon Rodrigues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66132/
---

Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.


Bugs: ATLAS-2505
https://issues.apache.org/jira/browse/ATLAS-2505


Repository: atlas


Description
---

This patch inclues changes to set client IP to authorization request ie 
AtlasAdminRequest, AtlasEntityRequest, AtlasTypeRequest object for audit 
logging.


Diffs
-

  authorization/pom.xml 92be82ef 
  
authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizationUtils.java
 8c57946b 
  server-api/src/main/java/org/apache/atlas/RequestContextV1.java 4f962877 
  webapp/src/main/java/org/apache/atlas/web/filters/AuditFilter.java 073d7ee8 


Diff: https://reviews.apache.org/r/66132/diff/1/


Testing
---

Tested the clientIp property in AtlasRequest object set correctly with client's 
remote ip during authz calls.


Thanks,

Nixon Rodrigues

[jira] [Created] (ATLAS-2506) Attributes of filters in the inner filter group are not added to "attributes" JSON array of the Basic POST request body

2018-03-19 Thread pratik pandey (JIRA) 
pratik pandey created ATLAS-2506:


 Summary: Attributes of filters in the inner filter group are not 
added to "attributes" JSON array of the Basic POST request body
 Key: ATLAS-2506
 URL: https://issues.apache.org/jira/browse/ATLAS-2506
 Project: Atlas
  Issue Type: Bug
Reporter: pratik pandey
Assignee: pratik pandey
 Attachments: Faceted_search.png

Attributes of the filters added in the inner filter group are not added in the 
"attributes" parameter of the POST body.

Hence "attributes" in the POST body has only createTime , retention and not 
temporary.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (ATLAS-2505) Set client IP to authorization request call for audit logging.

2018-03-19 Thread Nixon Rodrigues (JIRA) 
Nixon Rodrigues created ATLAS-2505:
--

 Summary: Set client IP to authorization request call for audit 
logging.
 Key: ATLAS-2505
 URL: https://issues.apache.org/jira/browse/ATLAS-2505
 Project: Atlas
  Issue Type: Bug
Reporter: Nixon Rodrigues
Assignee: Nixon Rodrigues






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Build failed in Jenkins: Atlas-master-IntegrationTests #807

2018-03-19 Thread Apache Jenkins Server 
See 


--
[...truncated 653.77 KB...]
[INFO] Started Jetty Server
[INFO] 
[INFO] --- maven-failsafe-plugin:2.18.1:integration-test (integration-test) @ 
falcon-bridge ---
[WARNING] useSystemClassloader setting has no effect when not forking
[INFO] Failsafe report directory: 

Running org.apache.atlas.falcon.hook.FalconHookIT
127.0.0.1 - - [19/Mar/2018:10:36:02 +] "GET 
//localhost:31000/api/atlas/entities?type=falcon_cluster&property=qualifiedName&value=cluster1coL62QAEY
 HTTP/1.1" 404 106 "-" "Java/1.8.0_152"
127.0.0.1 - - [19/Mar/2018:10:36:03 +] "GET 
//localhost:31000/api/atlas/entities?type=falcon_cluster&property=qualifiedName&value=cluster1coL62QAEY
 HTTP/1.1" 404 106 "-" "Java/1.8.0_152"
127.0.0.1 - - [19/Mar/2018:10:36:03 +] "GET 
//localhost:31000/api/atlas/entities?type=falcon_cluster&property=qualifiedName&value=cluster1coL62QAEY
 HTTP/1.1" 404 106 "-" "Java/1.8.0_152"
127.0.0.1 - - [19/Mar/2018:10:36:04 +] "GET 
//localhost:31000/api/atlas/entities?type=falcon_cluster&property=qualifiedName&value=cluster1coL62QAEY
 HTTP/1.1" 404 106 "-" "Java/1.8.0_152"
127.0.0.1 - - [19/Mar/2018:10:36:04 +] "GET 
//localhost:31000/api/atlas/entities?type=falcon_cluster&property=qualifiedName&value=cluster1coL62QAEY
 HTTP/1.1" 404 106 "-" "Java/1.8.0_152"
127.0.0.1 - - [19/Mar/2018:10:36:05 +] "GET 
//localhost:31000/api/atlas/entities?type=falcon_cluster&property=qualifiedName&value=cluster1coL62QAEY
 HTTP/1.1" 404 106 "-" "Java/1.8.0_152"
127.0.0.1 - - [19/Mar/2018:10:36:05 +] "GET 
//localhost:31000/api/atlas/entities?type=falcon_feed&property=qualifiedName&value=feedA42Jo7gtPY@clusternISpeeMySx
 HTTP/1.1" 404 118 "-" "Java/1.8.0_152"
127.0.0.1 - - [19/Mar/2018:10:36:05 +] "GET 
//localhost:31000/api/atlas/entities?type=falcon_feed&property=qualifiedName&value=feedA42Jo7gtPY@clusternISpeeMySx
 HTTP/1.1" 404 118 "-" "Java/1.8.0_152"
127.0.0.1 - - [19/Mar/2018:10:36:06 +] "GET 
//localhost:31000/api/atlas/entities?type=falcon_feed&property=qualifiedName&value=feedA42Jo7gtPY@clusternISpeeMySx
 HTTP/1.1" 404 118 "-" "Java/1.8.0_152"
127.0.0.1 - - [19/Mar/2018:10:36:06 +] "GET 
//localhost:31000/api/atlas/entities?type=falcon_feed&property=qualifiedName&value=feedA42Jo7gtPY@clusternISpeeMySx
 HTTP/1.1" 404 118 "-" "Java/1.8.0_152"
127.0.0.1 - - [19/Mar/2018:10:36:06 +] "GET 
//localhost:31000/api/atlas/entities?type=falcon_feed&property=qualifiedName&value=feedA42Jo7gtPY@clusternISpeeMySx
 HTTP/1.1" 404 118 "-" "Java/1.8.0_152"
127.0.0.1 - - [19/Mar/2018:10:36:07 +] "GET 
//localhost:31000/api/atlas/entities?type=falcon_feed&property=qualifiedName&value=feedA42Jo7gtPY@clusternISpeeMySx
 HTTP/1.1" 200 924 "-" "Java/1.8.0_152"
127.0.0.1 - - [19/Mar/2018:10:36:07 +] "GET 
//localhost:31000/api/atlas/entities?type=falcon_feed&property=qualifiedName&value=feedA42Jo7gtPY@clusternISpeeMySx
 HTTP/1.1" 200 924 "-" "Java/1.8.0_152"
127.0.0.1 - - [19/Mar/2018:10:36:07 +] "GET 
//localhost:31000/api/atlas/entities/ee83a34b-2697-4eeb-b739-cbb8687900fa 
HTTP/1.1" 200 924 "-" "Java/1.8.0_152"
127.0.0.1 - - [19/Mar/2018:10:36:07 +] "GET 
//localhost:31000/api/atlas/entities?type=falcon_feed_creation&property=qualifiedName&value=feedA42Jo7gtPY@clusternISpeeMySx
 HTTP/1.1" 200 1267 "-" "Java/1.8.0_152"
127.0.0.1 - - [19/Mar/2018:10:36:07 +] "GET 
//localhost:31000/api/atlas/entities?type=falcon_feed_creation&property=qualifiedName&value=feedA42Jo7gtPY@clusternISpeeMySx
 HTTP/1.1" 200 1267 "-" "Java/1.8.0_152"
127.0.0.1 - - [19/Mar/2018:10:36:07 +] "GET 
//localhost:31000/api/atlas/entities/b8df368b-3465-4410-be29-f5661a7025e4 
HTTP/1.1" 200 1267 "-" "Java/1.8.0_152"
127.0.0.1 - - [19/Mar/2018:10:36:07 +] "GET 
//localhost:31000/api/atlas/entities/4d64dfdb-5063-4c30-a0c7-30caf4224752 
HTTP/1.1" 200 1019 "-" "Java/1.8.0_152"
127.0.0.1 - - [19/Mar/2018:10:36:07 +] "GET 
//localhost:31000/api/atlas/entities?type=falcon_feed&property=qualifiedName&value=feedmR9ytCVXoJ@clusternISpeeMySx
 HTTP/1.1" 404 118 "-" "Java/1.8.0_152"
127.0.0.1 - - [19/Mar/2018:10:36:08 +] "GET 
//localhost:31000/api/atlas/entities?type=falcon_feed&property=qualifiedName&value=feedmR9ytCVXoJ@clusternISpeeMySx
 HTTP/1.1" 200 924 "-" "Java/1.8.0_152"
127.0.0.1 - - [19/Mar/2018:10:36:08 +] "GET 
//localhost:31000/api/atlas/entities?type=falcon_feed&property=qualifiedName&value=feedmR9ytCVXoJ@clusternISpeeMySx
 HTTP/1.1" 200 924 "-" "Java/1.8.0_152"
127.0.0.1 - - [19/Mar/2018:10:36:08 +] "GET 
//localhost:31000/api/atlas/entities/a4c4e9b8-d7b5-4008-a1f8-c008aa31ce15 
HTTP/1.1" 200 924 "-" "Java/1.8.0_152"
127.0.0.1 - - [19/Mar/2018:10:36:08 +] "GET 
//localhost:31000/api/atlas/entities?type=falcon_feed_creation&property=qualifiedName&value=feedmR9y