[jira] [Commented] (ATLAS-4077) update Python client to work with Kerberos and 2.7

2020-12-11 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-4077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248266#comment-17248266
 ] 

ASF subversion and git services commented on ATLAS-4077:


Commit 38755da907814e5a06cf09fb79518cc14ada7337 in atlas's branch 
refs/heads/branch-2.0 from Madhan Neethiraj
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=38755da ]

ATLAS-4077: updated Python client to support Python 2.7

(cherry picked from commit 77943a9489bd49e53b1e8572fa9ea32ae02e5b04)


> update Python client to work with Kerberos and 2.7
> --
>
> Key: ATLAS-4077
> URL: https://issues.apache.org/jira/browse/ATLAS-4077
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 2.1.0
>Reporter: Madhan Neethiraj
>Assignee: Madhan Neethiraj
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-4077.patch
>
>
> Python client for Atlas introduced in ATLAS-3875 requires Python 3.6 or 
> above. It will help make the client available for Python 2.7 as well. Also, 
> the client should support Kerberos authentication.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4077) update Python client to work with Kerberos and 2.7

2020-12-11 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-4077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248264#comment-17248264
 ] 

ASF subversion and git services commented on ATLAS-4077:


Commit 77943a9489bd49e53b1e8572fa9ea32ae02e5b04 in atlas's branch 
refs/heads/master from Madhan Neethiraj
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=77943a9 ]

ATLAS-4077: updated Python client to support Python 2.7


> update Python client to work with Kerberos and 2.7
> --
>
> Key: ATLAS-4077
> URL: https://issues.apache.org/jira/browse/ATLAS-4077
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 2.1.0
>Reporter: Madhan Neethiraj
>Assignee: Madhan Neethiraj
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-4077.patch
>
>
> Python client for Atlas introduced in ATLAS-3875 requires Python 3.6 or 
> above. It will help make the client available for Python 2.7 as well. Also, 
> the client should support Kerberos authentication.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 73078: ATLAS-4077: updated Atlas Python client to work with Python 2.7

2020-12-11 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73078/#review222326
---


Fix it, then Ship it!





intg/src/main/python/README.md
Line 22 (original), 19 (patched)


next python client version to be updated is '0.0.2'


- Sarath Subramanian


On Dec. 11, 2020, 1:03 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73078/
> ---
> 
> (Updated Dec. 11, 2020, 1:03 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Nikhil Bonte, Nixon Rodrigues, 
> Pinal Shah, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-4077
> https://issues.apache.org/jira/browse/ATLAS-4077
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> updated Atlas Python client to work with Python 2.7
> 
> 
> Diffs
> -
> 
>   atlas-examples/sample-app/src/main/python/discovery_example.py 93aae1d88 
>   atlas-examples/sample-app/src/main/python/entity_example.py 2cd5da122 
>   atlas-examples/sample-app/src/main/python/glossary_example.py ab5e20170 
>   atlas-examples/sample-app/src/main/python/lineage_example.py 42e2398d3 
>   
> atlas-examples/sample-app/src/main/python/request_json/entity_create_db.json 
> c6f8a87db 
>   
> atlas-examples/sample-app/src/main/python/request_json/entity_create_process.json
>  f59ec48da 
>   
> atlas-examples/sample-app/src/main/python/request_json/entity_create_table_canada.json
>  8838841a1 
>   
> atlas-examples/sample-app/src/main/python/request_json/entity_create_table_us.json
>  9685e8d54 
>   atlas-examples/sample-app/src/main/python/request_json/typedef_create.json 
> b42781ad9 
>   atlas-examples/sample-app/src/main/python/sample_client.py 54720d9ab 
>   atlas-examples/sample-app/src/main/python/typedef_example.py 8431d70dd 
>   atlas-examples/sample-app/src/main/python/utils.py c19382f29 
>   intg/src/main/python/README.md 086d7775f 
>   intg/src/main/python/apache_atlas/base_client.py ba85018e8 
>   intg/src/main/python/apache_atlas/client/discovery.py b1cdcc62e 
>   intg/src/main/python/apache_atlas/client/entity.py d43408e5d 
>   intg/src/main/python/apache_atlas/client/glossary.py 41b977e1f 
>   intg/src/main/python/apache_atlas/client/lineage.py e8966c2f3 
>   intg/src/main/python/apache_atlas/client/relationship.py 9ccf6444d 
>   intg/src/main/python/apache_atlas/client/typedef.py 70f795f5d 
>   intg/src/main/python/apache_atlas/exceptions.py d306568a5 
>   intg/src/main/python/apache_atlas/model/discovery.py 18eca380f 
>   intg/src/main/python/apache_atlas/model/entity.py ea66e717c 
>   intg/src/main/python/apache_atlas/model/enums.py PRE-CREATION 
>   intg/src/main/python/apache_atlas/model/glossary.py a9958d57e 
>   intg/src/main/python/apache_atlas/model/instance.py PRE-CREATION 
>   intg/src/main/python/apache_atlas/model/lineage.py 9e9c6e139 
>   intg/src/main/python/apache_atlas/model/metrics.py PRE-CREATION 
>   intg/src/main/python/apache_atlas/model/misc.py PRE-CREATION 
>   intg/src/main/python/apache_atlas/model/profile.py PRE-CREATION 
>   intg/src/main/python/apache_atlas/model/relationship.py 64a59eda8 
>   intg/src/main/python/apache_atlas/model/typedef.py 480d9fe32 
>   intg/src/main/python/apache_atlas/utils.py a59f29f1e 
>   intg/src/main/python/setup.py 60f49d2de 
> 
> 
> Diff: https://reviews.apache.org/r/73078/diff/2/
> 
> 
> Testing
> ---
> 
> - verified that the sample client works with Python 2.7 and Python 3.7
> - updated APIs to return Atlas class objects, instead of a dict object, to 
> enable consistent access to members
> - verified with HTTPS and Kerberos authentication
> - reorg classes to be in sync with Java client
> - simplified json files used by sample for easier reading
> - Test version of the updated library is available at 
> https://test.pypi.org/project/apache-atlas/
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: Review Request 73079: ATLAS-4031 : Upgrade gremlin to 3.4.8+

2020-12-11 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73079/#review222325
---


Ship it!




Ship It!

- Sarath Subramanian


On Dec. 10, 2020, 11:08 p.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73079/
> ---
> 
> (Updated Dec. 10, 2020, 11:08 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4031
> https://issues.apache.org/jira/browse/ATLAS-4031
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Upgrade tinkerpop dependency to upgrade gremlin-shaded.
> 
> 
> Diffs
> -
> 
>   graphdb/janus-hbase2/pom.xml d14d150ee 
>   graphdb/janus/pom.xml 9a4619f95 
>   pom.xml 2bf5631cc 
> 
> 
> Diff: https://reviews.apache.org/r/73079/diff/2/
> 
> 
> Testing
> ---
> 
> Atlas server up and running
> mvn clean install
> mvn clean package -Pdist,embedded-hbase-solr
> Fired entity create/delete
> quickstart.py working
> 
> 
> Thanks,
> 
> chaitali
> 
>

Re: Review Request 73081: ATLAS-4076: Creating an asset from existing asset adds duplicate Atlas audit entries

2020-12-11 Thread Deep Singh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73081/
---

(Updated Dec. 11, 2020, 9:47 p.m.)


Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nikhil Bonte, and 
Sarath Subramanian.


Bugs: ATLAS-4076
https://issues.apache.org/jira/browse/ATLAS-4076


Repository: atlas


Description (updated)
---

Observations:
=
Have a hive table and attach classification to it on Atlas. Enable propagation 
on the attached classification.
When you drive a new table from this hive table, the new table will have the 
propagated classification, as expected.
However, the entity audits of the newly derived table has multiple "Propagated 
Classification Added" enteries. 

If table derivation is done using Hive Beeline, there are 5 such entries per 
propagated classification.
Using Spark-shell, 3 such entries were observed per propagated classification.

Expected behaviour is to have just 1 entry per propagated classification.

Analysis:
=
After detecting relationship and creating relationship edge, the propagated 
enteties(classifications) are notified to entityChangeListner through 
entityChangeNotifier. However details of the propagated enteties are not passed 
directly to notifier, but through request context (buffered into 
addedPropagation list). 

After processing every edge, AtlasRelationshipStore manager sends notification 
to entityChangeListner, which simply gets all the items in request context 
buffer list. 

In this issue, Hive sends event which has multiple relationships, and only one 
relationship has propagated entities, but due to multiple notifications(which 
is correct) same buffer list is processed multipletimes (which is wrong).

Following are the list of created relationships 
Created relationship edge from [hive_table] --> [hive_storagedesc] using edge 
label: [__hive_table.sd] 
Created relationship edge from [hive_table] --> [hive_column] using edge label: 
[__hive_table.columns] 
Created relationship edge from [hive_table] --> [hive_table_ddl] using edge 
label: [r:hive_table_ddl_queries] 
Created relationship edge from [hive_table] --> [hive_db] using edge label: 
[__hive_table.db] 
Created relationship edge from [hive_process] --> [hive_process_execution] 
using edge label: [r:hive_process_process_executions] 
Created relationship edge from [hive_process] --> [hive_table] using edge 
label: [__Process.outputs]
Created relationship edge from [hive_process] --> [hive_table] using edge 
label: [__Process.inputs]
===
Created relationship edge from [hive_column_lineage] --> [hive_column] using 
edge label: [__Process.outputs] 
Created relationship edge from [hive_column_lineage] --> [hive_column] using 
edge label: [__Process.inputs] 
Created relationship edge from [hive_column_lineage] --> [hive_process] using 
edge label: [__hive_column_lineage.query] 

In the above list the highlited one has propagated classificatin, but 
subscequent 3 relationships sends 3 more notifications, resulting 3 extra 
entries for same classification in entity audits.

At the end entityChangeNotifier, while processing mutated entities, explicetly 
notify for any pending propagated entities and once again buffer list in 
request context is processed. Resulting in 4th extra entry in audits.

Fix:


One option was to send the details of propagated entities directly to notifier 
and not rely on the request context. It required lot of code change.
Other option was to clear the buffer in the request context after processing it 
in entityChangeNotifier.

This review request is with the second aproach.


Diffs
-

  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java
 32ad65e7a 
  server-api/src/main/java/org/apache/atlas/RequestContext.java 32ffddde1 


Diff: https://reviews.apache.org/r/73081/diff/1/


Testing
---

Manual testing was done using both hive and spark.
precommit test were success
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/263/console


Thanks,

Deep Singh

Re: Review Request 73078: ATLAS-4077: updated Atlas Python client to work with Python 2.7

2020-12-11 Thread Madhan Neethiraj 
Verdan,

This one started as an update to support Kerberos authentication. Given the 
library uses requests package, for Kerberos support I tried requests_kerberos 
package. However, installing this package for python3 failed in some of my 
Linux environments. Hence looked into enabling Python 2.7 for Atlas library, 
which by itself wasn't much change.

Most of the updates in this patch are about using instances of Atlas classes 
(like AtlasEntity) for both API arguments and return values. In earlier 
version, API arguments were Atlas class instances, but the return value was an 
dict - which would make it confusing to deal with.

Thanks,
Madhan

On 12/11/20, 1:07 PM, "Verdan Mahmood"  wrote:

A quick question Madhan, any specific requirements to support Python 2.7,
as it’s EOL is end of this year?

On Fri, 11 Dec 2020 at 22:04, Madhan Neethiraj  wrote:

>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73078/
> ---
>
> (Updated Dec. 11, 2020, 9:03 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Nikhil Bonte, Nixon Rodrigues,
> Pinal Shah, Sarath Subramanian, and Sidharth Mishra.
>
>
> Changes
> ---
>
> updated README.txt
>
>
> Summary (updated)
> -
>
> ATLAS-4077: updated Atlas Python client to work with Python 2.7
>
>
> Bugs: ATLAS-4077
> https://issues.apache.org/jira/browse/ATLAS-4077
>
>
> Repository: atlas
>
>
> Description
> ---
>
> updated Atlas Python client to work with Python 2.7
>
>
> Diffs (updated)
> -
>
>   atlas-examples/sample-app/src/main/python/discovery_example.py 93aae1d88
>   atlas-examples/sample-app/src/main/python/entity_example.py 2cd5da122
>   atlas-examples/sample-app/src/main/python/glossary_example.py ab5e20170
>   atlas-examples/sample-app/src/main/python/lineage_example.py 42e2398d3
>
> 
atlas-examples/sample-app/src/main/python/request_json/entity_create_db.json
> c6f8a87db
>
> 
atlas-examples/sample-app/src/main/python/request_json/entity_create_process.json
> f59ec48da
>
> 
atlas-examples/sample-app/src/main/python/request_json/entity_create_table_canada.json
> 8838841a1
>
> 
atlas-examples/sample-app/src/main/python/request_json/entity_create_table_us.json
> 9685e8d54
>
> atlas-examples/sample-app/src/main/python/request_json/typedef_create.json
> b42781ad9
>   atlas-examples/sample-app/src/main/python/sample_client.py 54720d9ab
>   atlas-examples/sample-app/src/main/python/typedef_example.py 8431d70dd
>   atlas-examples/sample-app/src/main/python/utils.py c19382f29
>   intg/src/main/python/README.md 086d7775f
>   intg/src/main/python/apache_atlas/base_client.py ba85018e8
>   intg/src/main/python/apache_atlas/client/discovery.py b1cdcc62e
>   intg/src/main/python/apache_atlas/client/entity.py d43408e5d
>   intg/src/main/python/apache_atlas/client/glossary.py 41b977e1f
>   intg/src/main/python/apache_atlas/client/lineage.py e8966c2f3
>   intg/src/main/python/apache_atlas/client/relationship.py 9ccf6444d
>   intg/src/main/python/apache_atlas/client/typedef.py 70f795f5d
>   intg/src/main/python/apache_atlas/exceptions.py d306568a5
>   intg/src/main/python/apache_atlas/model/discovery.py 18eca380f
>   intg/src/main/python/apache_atlas/model/entity.py ea66e717c
>   intg/src/main/python/apache_atlas/model/enums.py PRE-CREATION
>   intg/src/main/python/apache_atlas/model/glossary.py a9958d57e
>   intg/src/main/python/apache_atlas/model/instance.py PRE-CREATION
>   intg/src/main/python/apache_atlas/model/lineage.py 9e9c6e139
>   intg/src/main/python/apache_atlas/model/metrics.py PRE-CREATION
>   intg/src/main/python/apache_atlas/model/misc.py PRE-CREATION
>   intg/src/main/python/apache_atlas/model/profile.py PRE-CREATION
>   intg/src/main/python/apache_atlas/model/relationship.py 64a59eda8
>   intg/src/main/python/apache_atlas/model/typedef.py 480d9fe32
>   intg/src/main/python/apache_atlas/utils.py a59f29f1e
>   intg/src/main/python/setup.py 60f49d2de
>
>
> Diff: https://reviews.apache.org/r/73078/diff/2/
>
> Changes: https://reviews.apache.org/r/73078/diff/1-2/
>
>
> Testing (updated)
> ---
>
> - verified that the sample client works with Python 2.7 and Python 3.7
> - updated APIs to return Atlas class objects, instead of a dict object, to
> enable consistent access to members
> - verified with HTTPS and Kerberos authentication
> - reorg classes to be in sync with Java client
> - simplified json files used by sample for easier reading
>
>
> Thanks,

Re: Review Request 73078: ATLAS-4077: updated Atlas Python client to work with Python 2.7

2020-12-11 Thread Verdan Mahmood 
A quick question Madhan, any specific requirements to support Python 2.7,
as it’s EOL is end of this year?

On Fri, 11 Dec 2020 at 22:04, Madhan Neethiraj  wrote:

>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73078/
> ---
>
> (Updated Dec. 11, 2020, 9:03 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Nikhil Bonte, Nixon Rodrigues,
> Pinal Shah, Sarath Subramanian, and Sidharth Mishra.
>
>
> Changes
> ---
>
> updated README.txt
>
>
> Summary (updated)
> -
>
> ATLAS-4077: updated Atlas Python client to work with Python 2.7
>
>
> Bugs: ATLAS-4077
> https://issues.apache.org/jira/browse/ATLAS-4077
>
>
> Repository: atlas
>
>
> Description
> ---
>
> updated Atlas Python client to work with Python 2.7
>
>
> Diffs (updated)
> -
>
>   atlas-examples/sample-app/src/main/python/discovery_example.py 93aae1d88
>   atlas-examples/sample-app/src/main/python/entity_example.py 2cd5da122
>   atlas-examples/sample-app/src/main/python/glossary_example.py ab5e20170
>   atlas-examples/sample-app/src/main/python/lineage_example.py 42e2398d3
>
> atlas-examples/sample-app/src/main/python/request_json/entity_create_db.json
> c6f8a87db
>
> atlas-examples/sample-app/src/main/python/request_json/entity_create_process.json
> f59ec48da
>
> atlas-examples/sample-app/src/main/python/request_json/entity_create_table_canada.json
> 8838841a1
>
> atlas-examples/sample-app/src/main/python/request_json/entity_create_table_us.json
> 9685e8d54
>
> atlas-examples/sample-app/src/main/python/request_json/typedef_create.json
> b42781ad9
>   atlas-examples/sample-app/src/main/python/sample_client.py 54720d9ab
>   atlas-examples/sample-app/src/main/python/typedef_example.py 8431d70dd
>   atlas-examples/sample-app/src/main/python/utils.py c19382f29
>   intg/src/main/python/README.md 086d7775f
>   intg/src/main/python/apache_atlas/base_client.py ba85018e8
>   intg/src/main/python/apache_atlas/client/discovery.py b1cdcc62e
>   intg/src/main/python/apache_atlas/client/entity.py d43408e5d
>   intg/src/main/python/apache_atlas/client/glossary.py 41b977e1f
>   intg/src/main/python/apache_atlas/client/lineage.py e8966c2f3
>   intg/src/main/python/apache_atlas/client/relationship.py 9ccf6444d
>   intg/src/main/python/apache_atlas/client/typedef.py 70f795f5d
>   intg/src/main/python/apache_atlas/exceptions.py d306568a5
>   intg/src/main/python/apache_atlas/model/discovery.py 18eca380f
>   intg/src/main/python/apache_atlas/model/entity.py ea66e717c
>   intg/src/main/python/apache_atlas/model/enums.py PRE-CREATION
>   intg/src/main/python/apache_atlas/model/glossary.py a9958d57e
>   intg/src/main/python/apache_atlas/model/instance.py PRE-CREATION
>   intg/src/main/python/apache_atlas/model/lineage.py 9e9c6e139
>   intg/src/main/python/apache_atlas/model/metrics.py PRE-CREATION
>   intg/src/main/python/apache_atlas/model/misc.py PRE-CREATION
>   intg/src/main/python/apache_atlas/model/profile.py PRE-CREATION
>   intg/src/main/python/apache_atlas/model/relationship.py 64a59eda8
>   intg/src/main/python/apache_atlas/model/typedef.py 480d9fe32
>   intg/src/main/python/apache_atlas/utils.py a59f29f1e
>   intg/src/main/python/setup.py 60f49d2de
>
>
> Diff: https://reviews.apache.org/r/73078/diff/2/
>
> Changes: https://reviews.apache.org/r/73078/diff/1-2/
>
>
> Testing (updated)
> ---
>
> - verified that the sample client works with Python 2.7 and Python 3.7
> - updated APIs to return Atlas class objects, instead of a dict object, to
> enable consistent access to members
> - verified with HTTPS and Kerberos authentication
> - reorg classes to be in sync with Java client
> - simplified json files used by sample for easier reading
>
>
> Thanks,
>
> Madhan Neethiraj
>
> --
Sent from my iPhone

Re: Review Request 73078: ATLAS-4077: updated Atlas Python client to work with Python 2.7

2020-12-11 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73078/
---

(Updated Dec. 11, 2020, 9:03 p.m.)


Review request for atlas, Ashutosh Mestry, Nikhil Bonte, Nixon Rodrigues, Pinal 
Shah, Sarath Subramanian, and Sidharth Mishra.


Changes
---

updated README.txt


Summary (updated)
-

ATLAS-4077: updated Atlas Python client to work with Python 2.7


Bugs: ATLAS-4077
https://issues.apache.org/jira/browse/ATLAS-4077


Repository: atlas


Description
---

updated Atlas Python client to work with Python 2.7


Diffs (updated)
-

  atlas-examples/sample-app/src/main/python/discovery_example.py 93aae1d88 
  atlas-examples/sample-app/src/main/python/entity_example.py 2cd5da122 
  atlas-examples/sample-app/src/main/python/glossary_example.py ab5e20170 
  atlas-examples/sample-app/src/main/python/lineage_example.py 42e2398d3 
  atlas-examples/sample-app/src/main/python/request_json/entity_create_db.json 
c6f8a87db 
  
atlas-examples/sample-app/src/main/python/request_json/entity_create_process.json
 f59ec48da 
  
atlas-examples/sample-app/src/main/python/request_json/entity_create_table_canada.json
 8838841a1 
  
atlas-examples/sample-app/src/main/python/request_json/entity_create_table_us.json
 9685e8d54 
  atlas-examples/sample-app/src/main/python/request_json/typedef_create.json 
b42781ad9 
  atlas-examples/sample-app/src/main/python/sample_client.py 54720d9ab 
  atlas-examples/sample-app/src/main/python/typedef_example.py 8431d70dd 
  atlas-examples/sample-app/src/main/python/utils.py c19382f29 
  intg/src/main/python/README.md 086d7775f 
  intg/src/main/python/apache_atlas/base_client.py ba85018e8 
  intg/src/main/python/apache_atlas/client/discovery.py b1cdcc62e 
  intg/src/main/python/apache_atlas/client/entity.py d43408e5d 
  intg/src/main/python/apache_atlas/client/glossary.py 41b977e1f 
  intg/src/main/python/apache_atlas/client/lineage.py e8966c2f3 
  intg/src/main/python/apache_atlas/client/relationship.py 9ccf6444d 
  intg/src/main/python/apache_atlas/client/typedef.py 70f795f5d 
  intg/src/main/python/apache_atlas/exceptions.py d306568a5 
  intg/src/main/python/apache_atlas/model/discovery.py 18eca380f 
  intg/src/main/python/apache_atlas/model/entity.py ea66e717c 
  intg/src/main/python/apache_atlas/model/enums.py PRE-CREATION 
  intg/src/main/python/apache_atlas/model/glossary.py a9958d57e 
  intg/src/main/python/apache_atlas/model/instance.py PRE-CREATION 
  intg/src/main/python/apache_atlas/model/lineage.py 9e9c6e139 
  intg/src/main/python/apache_atlas/model/metrics.py PRE-CREATION 
  intg/src/main/python/apache_atlas/model/misc.py PRE-CREATION 
  intg/src/main/python/apache_atlas/model/profile.py PRE-CREATION 
  intg/src/main/python/apache_atlas/model/relationship.py 64a59eda8 
  intg/src/main/python/apache_atlas/model/typedef.py 480d9fe32 
  intg/src/main/python/apache_atlas/utils.py a59f29f1e 
  intg/src/main/python/setup.py 60f49d2de 


Diff: https://reviews.apache.org/r/73078/diff/2/

Changes: https://reviews.apache.org/r/73078/diff/1-2/


Testing (updated)
---

- verified that the sample client works with Python 2.7 and Python 3.7
- updated APIs to return Atlas class objects, instead of a dict object, to 
enable consistent access to members
- verified with HTTPS and Kerberos authentication
- reorg classes to be in sync with Java client
- simplified json files used by sample for easier reading


Thanks,

Madhan Neethiraj

[jira] [Created] (ATLAS-4077) update Python client to work with Kerberos and 2.7

2020-12-11 Thread Madhan Neethiraj (Jira) 
Madhan Neethiraj created ATLAS-4077:
---

 Summary: update Python client to work with Kerberos and 2.7
 Key: ATLAS-4077
 URL: https://issues.apache.org/jira/browse/ATLAS-4077
 Project: Atlas
  Issue Type: Improvement
Affects Versions: 2.1.0
Reporter: Madhan Neethiraj
Assignee: Madhan Neethiraj


Python client for Atlas introduced in ATLAS-3875 requires Python 3.6 or above. 
It will help make the client available for Python 2.7 as well. Also, the client 
should support Kerberos authentication.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4076) Creating an asset from existing asset adds duplicate Atlas audit entries

2020-12-11 Thread Deep Singh (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-4076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248148#comment-17248148
 ] 

Deep Singh commented on ATLAS-4076:
---

Analysis:
=
After detecting relationship and creating relationship edge, the propagated 
enteties(classifications) are notified to entityChangeListner through 
entityChangeNotifier. However details of the propagated enteties are not passed 
directly to notifier, but through request context (buffered into 
addedPropagation list). 

After processing every edge, AtlasRelationshipStore manager sends notification 
to entityChangeListner, which simply gets all the items in request context 
buffer list. 

In this issue, Hive sends and event which has multiple relationships, and only 
one relationship has propagated entities, but due to multiple 
notifications(which is correct) same buffer list is processed multipletimes 
(which is wrong).




> Creating an asset from existing asset adds duplicate Atlas audit entries 
> -
>
> Key: ATLAS-4076
> URL: https://issues.apache.org/jira/browse/ATLAS-4076
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 2.1.0
>Reporter: Deep Singh
>Assignee: Deep Singh
>Priority: Critical
>
> Steps :
> Go to beeline in hive.
> Create a new asset which is created from an existing asset, using the query : 
> create table test_web_site as select * from web_site_five;
> Observe that web_site_five contains two managed tags which should be 
> propagated to the newly created table , i.e : test_web_site
> Observe the audit tab for 'test_web_site' table in atlas contains multiple 
> entries 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4076) Creating an asset from existing asset adds duplicate Atlas audit entries

2020-12-11 Thread Deep Singh (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deep Singh updated ATLAS-4076:
--
External issue URL: 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/263/console

> Creating an asset from existing asset adds duplicate Atlas audit entries 
> -
>
> Key: ATLAS-4076
> URL: https://issues.apache.org/jira/browse/ATLAS-4076
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 2.1.0
>Reporter: Deep Singh
>Assignee: Deep Singh
>Priority: Critical
>
> Steps :
> Go to beeline in hive.
> Create a new asset which is created from an existing asset, using the query : 
> create table test_web_site as select * from web_site_five;
> Observe that web_site_five contains two managed tags which should be 
> propagated to the newly created table , i.e : test_web_site
> Observe the audit tab for 'test_web_site' table in atlas contains multiple 
> entries 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4076) Creating an asset from existing asset adds duplicate Atlas audit entries

2020-12-11 Thread Deep Singh (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deep Singh updated ATLAS-4076:
--
External issue URL:   (was: 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/263/console)

> Creating an asset from existing asset adds duplicate Atlas audit entries 
> -
>
> Key: ATLAS-4076
> URL: https://issues.apache.org/jira/browse/ATLAS-4076
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 2.1.0
>Reporter: Deep Singh
>Assignee: Deep Singh
>Priority: Critical
>
> Steps :
> Go to beeline in hive.
> Create a new asset which is created from an existing asset, using the query : 
> create table test_web_site as select * from web_site_five;
> Observe that web_site_five contains two managed tags which should be 
> propagated to the newly created table , i.e : test_web_site
> Observe the audit tab for 'test_web_site' table in atlas contains multiple 
> entries 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Review Request 73081: ATLAS-4076: Creating an asset from existing asset adds duplicate Atlas audit entries

2020-12-11 Thread Deep Singh 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73081/
---

Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nikhil Bonte, and 
Sarath Subramanian.


Bugs: ATLAS-4076
https://issues.apache.org/jira/browse/ATLAS-4076


Repository: atlas


Description
---

Observations:
=
Have a hive table and attach classification to it on Atlas. Enable propagation 
on the attached classification.
When you drive a new table from this hive table, the new table will have the 
propagated classification, as expected.
However, the entity audits of the newly derived table has multiple "Propagated 
Classification Added" enteries. 

If table derivation is done using Hive Beeline, there are 5 such entries per 
propagated classification.
Using Spark-shell, 3 such entries were observed per propagated classification.

Expected behaviour is to have just 1 entry per propagated classification.

Analysis:
=
After detecting relationship and creating relationship edge, the propagated 
enteties(classifications) are notified to entityChangeListner through 
entityChangeNotifier. However details of the propagated enteties are not passed 
directly to notifier, but through request context (buffered into 
addedPropagation list). 

After processing every edge, AtlasRelationshipStore manager sends notification 
to entityChangeListner, which simply gets all the items in request context 
buffer list. 

In this issue, Hive sends and event which has multiple relationships, and only 
one relationship has propagated entities, but due to multiple 
notifications(which is correct) same buffer list is processed multipletimes 
(which is wrong).

Following are the list of created relationships 
Created relationship edge from [hive_table] --> [hive_storagedesc] using edge 
label: [__hive_table.sd] 
Created relationship edge from [hive_table] --> [hive_column] using edge label: 
[__hive_table.columns] 
Created relationship edge from [hive_table] --> [hive_table_ddl] using edge 
label: [r:hive_table_ddl_queries] 
Created relationship edge from [hive_table] --> [hive_db] using edge label: 
[__hive_table.db] 
Created relationship edge from [hive_process] --> [hive_process_execution] 
using edge label: [r:hive_process_process_executions] 
Created relationship edge from [hive_process] --> [hive_table] using edge 
label: [__Process.outputs]
Created relationship edge from [hive_process] --> [hive_table] using edge 
label: [__Process.inputs]
===
Created relationship edge from [hive_column_lineage] --> [hive_column] using 
edge label: [__Process.outputs] 
Created relationship edge from [hive_column_lineage] --> [hive_column] using 
edge label: [__Process.inputs] 
Created relationship edge from [hive_column_lineage] --> [hive_process] using 
edge label: [__hive_column_lineage.query] 

In the above list the highlited one has propagated classificatin, but 
subscequent 3 relationships sends 3 more notifications, resulting 3 extra 
entries for same classification in entity audits.

At the end entityChangeNotifier, while processing mutated entities, explicetly 
notify for any pending propagated entities and once again buffer list in 
request context is processed. Resulting in 4th extra entry in audits.

Fix:


One option was to send the details of propagated entities directly to notifier 
and not rely on the request context. It required lot of code change.
Other option was to clear the buffer in the request context after processing it 
in entityChangeNotifier.

This review request is with the second aproach.


Diffs
-

  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java
 32ad65e7a 
  server-api/src/main/java/org/apache/atlas/RequestContext.java 32ffddde1 


Diff: https://reviews.apache.org/r/73081/diff/1/


Testing
---

Manual testing was done using both hive and spark.
precommit test were success
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/263/console


Thanks,

Deep Singh

[jira] [Created] (ATLAS-4076) Creating an asset from existing asset adds duplicate Atlas audit entries

2020-12-11 Thread Deep Singh (Jira) 
Deep Singh created ATLAS-4076:
-

 Summary: Creating an asset from existing asset adds duplicate 
Atlas audit entries 
 Key: ATLAS-4076
 URL: https://issues.apache.org/jira/browse/ATLAS-4076
 Project: Atlas
  Issue Type: Bug
  Components:  atlas-core
Affects Versions: 2.1.0
Reporter: Deep Singh
Assignee: Deep Singh


Steps :

Go to beeline in hive.
Create a new asset which is created from an existing asset, using the query : 
create table test_web_site as select * from web_site_five;
Observe that web_site_five contains two managed tags which should be propagated 
to the newly created table , i.e : test_web_site
Observe the audit tab for 'test_web_site' table in atlas contains multiple 
entries 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Assigned] (ATLAS-4067) In Entity Audits tab, show action as "user-defined properties added/updated/deleted" instead of plain 'Entity Updated'

2020-12-11 Thread Deep Singh (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deep Singh reassigned ATLAS-4067:
-

Assignee: Deep Singh

> In Entity Audits tab, show action as "user-defined properties 
> added/updated/deleted" instead of plain 'Entity Updated'
> --
>
> Key: ATLAS-4067
> URL: https://issues.apache.org/jira/browse/ATLAS-4067
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Affects Versions: 2.1.0
>Reporter: Umesh Padashetty
>Assignee: Deep Singh
>Priority: Major
> Attachments: Screenshot 2020-12-09 at 1.03.44 AM.png, Screenshot 
> 2020-12-09 at 12.57.59 AM.png
>
>
> Currently in the entity audits tab, we show actions as below:
>  * Business Attribute(s) Updated
>  * Classification Added
>  * Label(s) Added
> !Screenshot 2020-12-09 at 1.03.44 AM.png|width=1017,height=440!
> But for user-defined properties alone, we show "Entity Updated" for all the 
> udp actions. 
> !Screenshot 2020-12-09 at 12.57.59 AM.png|width=1028,height=292!
> This makes it very difficult to find out from the audits tab in which "Entity 
> Update" action the udp was updated for an entity.
> Though the user can expand the operation and find out what happened with udp, 
> this is not very intuitive



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4057) DSL Search : Support glossary terms and relationships

2020-12-11 Thread Pinal (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pinal updated ATLAS-4057:
-
Description: 
Supporting glossary term in advanced search, will allow user to search the 
entities which are assigned to particular term.

 

'hasTerm' keyword is added to support glossary term.

User needs to add fully qualifiedName of glossary term.

 

Example queries to search with glossary terms:

hive_table hasTerm "modernTrade@salesGlossary",

hive_table hasTerm "modernTrade@salesGlossary" and hive_table isA Dimension

 

Example queries to search with relationship:
hive_table where db.name = "sales"

  was:
Supporting glossary term in advanced search, will allow user to search the 
entities which are assigned to particular term.

 

'with' keyword is added to support glossary term.

User needs to add fully qualifiedName of glossary term.

 

Example queries to search:

hive_table with "modernTrade@salesGlossary",

hive_table with "modernTrade@salesGlossary" and hive_table isA Dimension

 


> DSL Search : Support glossary terms and relationships
> -
>
> Key: ATLAS-4057
> URL: https://issues.apache.org/jira/browse/ATLAS-4057
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Reporter: Pinal
>Assignee: Pinal
>Priority: Major
>  Labels: DSL
>
> Supporting glossary term in advanced search, will allow user to search the 
> entities which are assigned to particular term.
>  
> 'hasTerm' keyword is added to support glossary term.
> User needs to add fully qualifiedName of glossary term.
>  
> Example queries to search with glossary terms:
> hive_table hasTerm "modernTrade@salesGlossary",
> hive_table hasTerm "modernTrade@salesGlossary" and hive_table isA Dimension
>  
> Example queries to search with relationship:
> hive_table where db.name = "sales"



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4057) DSL Search : Support glossary terms and relationships

2020-12-11 Thread Pinal (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pinal updated ATLAS-4057:
-
Summary: DSL Search : Support glossary terms and relationships  (was: DSL 
Search : Support glossary terms)

> DSL Search : Support glossary terms and relationships
> -
>
> Key: ATLAS-4057
> URL: https://issues.apache.org/jira/browse/ATLAS-4057
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Reporter: Pinal
>Assignee: Pinal
>Priority: Major
>  Labels: DSL
>
> Supporting glossary term in advanced search, will allow user to search the 
> entities which are assigned to particular term.
>  
> 'with' keyword is added to support glossary term.
> User needs to add fully qualifiedName of glossary term.
>  
> Example queries to search:
> hive_table with "modernTrade@salesGlossary",
> hive_table with "modernTrade@salesGlossary" and hive_table isA Dimension
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4073) [UI] Column sorting not working in BusinessMetadata details page

2020-12-11 Thread Durga Kadam (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Durga Kadam updated ATLAS-4073:
---
Description: In Business Metadata, column sorting for 'Enable Multivalue' 
and 'Max Length' sorting does not work. PFA  (was: In Business Metadata, column 
sorting for 'Enable Multivalue' and 'Max Length' sorting works only once, if 
user tries to sort the column more than once sorting does not work, values 
remains as per first sorting applied.)

> [UI] Column sorting not working in BusinessMetadata details page
> 
>
> Key: ATLAS-4073
> URL: https://issues.apache.org/jira/browse/ATLAS-4073
> Project: Atlas
>  Issue Type: Bug
>Reporter: Durga Kadam
>Priority: Minor
> Attachments: sorting works only once for column maxlength and Enable 
> Multivalues.mkv
>
>
> In Business Metadata, column sorting for 'Enable Multivalue' and 'Max Length' 
> sorting does not work. PFA



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4075) Client side error is thrown as server error when a mal-formed payload is used

2020-12-11 Thread Dharshana M Krishnamoorthy (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dharshana M Krishnamoorthy updated ATLAS-4075:
--
Description: 
{code:java|title=Malformed payload for creating a classification}
{
"classificationDefs": [
{
"name": "tag_1",
}
]
}
{code}
{code:java|title=Malformed payload for creating a classification}
{
"classificationDefs": [
{
"name": "tag_1"
},
]
}
{code}
There is an additional "," in the above 2 payloads, which make it a client side 
payload error. But when firing such a request 500 internal server error is 
thrown
{code}

2020-12-11 07:47:28,482 ERROR - [etp402695541-552 - 
6420db24-b42f-45eb-a6bb-25ffb3c8ce0e:] ~ Error handling a request: 
31167d3d0dc60f70 (ExceptionMapperUtil:32)2020-12-11 07:47:28,482 ERROR - 
[etp402695541-552 - 6420db24-b42f-45eb-a6bb-25ffb3c8ce0e:] ~ Error handling a 
request: 31167d3d0dc60f70 
(ExceptionMapperUtil:32)com.fasterxml.jackson.databind.JsonMappingException: 
Unexpected character (']' (code 93)): expected a value at [Source: 
(org.eclipse.jetty.server.HttpInputOverHTTP); line: 6, column: 6] (through 
reference chain: 
org.apache.atlas.model.typedef.AtlasTypesDef["classificationDefs"]) at 
com.fasterxml.jackson.databind.JsonMappingException.wrapWithPath(JsonMappingException.java:397)
 at 
com.fasterxml.jackson.databind.JsonMappingException.wrapWithPath(JsonMappingException.java:356)
 at 
com.fasterxml.jackson.databind.deser.BeanDeserializerBase.wrapAndThrow(BeanDeserializerBase.java:1719)
 at 
com.fasterxml.jackson.databind.deser.BeanDeserializer.vanillaDeserialize(BeanDeserializer.java:290)
 at 
com.fasterxml.jackson.databind.deser.BeanDeserializer.deserialize(BeanDeserializer.java:151)
 at com.fasterxml.jackson.databind.ObjectReader._bind(ObjectReader.java:1682) 
at com.fasterxml.jackson.databind.ObjectReader.readValue(ObjectReader.java:977) 
at 
com.fasterxml.jackson.jaxrs.base.ProviderBase.readFrom(ProviderBase.java:814) 
at 
com.sun.jersey.spi.container.ContainerRequest.getEntity(ContainerRequest.java:490)
 at 
com.sun.jersey.server.impl.model.method.dispatch.EntityParamDispatchProvider$EntityInjectable.getValue(EntityParamDispatchProvider.java:123)
 at 
com.sun.jersey.server.impl.inject.InjectableValuesProvider.getInjectableValues(InjectableValuesProvider.java:86)
 at 
com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$EntityParamInInvoker.getParams(AbstractResourceMethodDispatchProvider.java:153)
 at 
com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$VoidOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:166)
 at 
com.sun.jersey.server.impl.model.method.dispatch.ResourceJavaMethodDispatcher.dispatch(ResourceJavaMethodDispatcher.java:75)
 at 
com.sun.jersey.server.impl.uri.rules.HttpMethodRule.accept(HttpMethodRule.java:302)
 at 
com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)
 at 
com.sun.jersey.server.impl.uri.rules.ResourceClassRule.accept(ResourceClassRule.java:108)
 at 
com.sun.jersey.server.impl.uri.rules.RightHandPathRule.accept(RightHandPathRule.java:147)
 at 
com.sun.jersey.server.impl.uri.rules.RootResourceClassesRule.accept(RootResourceClassesRule.java:84)
 at 
com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1542)
 at 
com.sun.jersey.server.impl.application.WebApplicationImpl._handleRequest(WebApplicationImpl.java:1473)
 at 
com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1419)
 at 
com.sun.jersey.server.impl.application.WebApplicationImpl.handleRequest(WebApplicationImpl.java:1409)
 at 
com.sun.jersey.spi.container.servlet.WebComponent.service(WebComponent.java:409)
 at 
com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:558)
 at 
com.sun.jersey.spi.container.servlet.ServletContainer.service(ServletContainer.java:733)
 at javax.servlet.http.HttpServlet.service(HttpServlet.java:790) at 
org.eclipse.jetty.servlet.ServletHolder$NotAsyncServlet.service(ServletHolder.java:1411)
 at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:763) at 
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1651)
 at org.apache.atlas.web.filters.AuditFilter.doFilter(AuditFilter.java:106) at 
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1638)
 at 
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:317)
 at 
org.springframework.security.web.access.intercept.FilterSecurityInterceptor.invoke(FilterSecurityInterceptor.java:127)
 at 
org.springframework.security.web.access.intercept.FilterSecurityInterceptor.doFilter(FilterSecurityInterceptor.java:91)
 at 
org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:331)
 at 
or

[jira] [Updated] (ATLAS-4075) Client side error is thrown as server error when a mal-formed payload is used

2020-12-11 Thread Dharshana M Krishnamoorthy (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dharshana M Krishnamoorthy updated ATLAS-4075:
--
Summary: Client side error is thrown as server error when a mal-formed 
payload is used  (was: 500 internal server error is thrown instead of 400 
malformed request from atlas when the payload is mal formed)

> Client side error is thrown as server error when a mal-formed payload is used
> -
>
> Key: ATLAS-4075
> URL: https://issues.apache.org/jira/browse/ATLAS-4075
> Project: Atlas
>  Issue Type: Bug
>Reporter: Dharshana M Krishnamoorthy
>Priority: Major
> Attachments: Screenshot 2020-12-11 at 1.29.32 PM.png, Screenshot 
> 2020-12-11 at 1.31.22 PM.png
>
>
> {code:java|title=Malformed payload for creating a classification}
> {
> "classificationDefs": [
> {
> "name": "tag_1",
> }
> ]
> }
> {code}
> {code:java|title=Malformed payload for creating a classification}
> {
> "classificationDefs": [
> {
> "name": "tag_1"
> },
> ]
> }
> {code}
> There is an additional "," in the above 2 payloads, which make it a client 
> side payload error. But when firing such a request 500 internal server error 
> is thrown
>   



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4075) 500 internal server error is thrown instead of 400 malformed request from atlas when the payload is mal formed

2020-12-11 Thread Dharshana M Krishnamoorthy (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4075?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dharshana M Krishnamoorthy updated ATLAS-4075:
--
Attachment: Screenshot 2020-12-11 at 1.31.22 PM.png
Screenshot 2020-12-11 at 1.29.32 PM.png

> 500 internal server error is thrown instead of 400 malformed request from 
> atlas when the payload is mal formed
> --
>
> Key: ATLAS-4075
> URL: https://issues.apache.org/jira/browse/ATLAS-4075
> Project: Atlas
>  Issue Type: Bug
>Reporter: Dharshana M Krishnamoorthy
>Priority: Major
> Attachments: Screenshot 2020-12-11 at 1.29.32 PM.png, Screenshot 
> 2020-12-11 at 1.31.22 PM.png
>
>
> {code:java|title=Malformed payload for creating a classification}
> {
> "classificationDefs": [
> {
> "name": "tag_1",
> }
> ]
> }
> {code}
> {code:java|title=Malformed payload for creating a classification}
> {
> "classificationDefs": [
> {
> "name": "tag_1"
> },
> ]
> }
> {code}
> There is an additional "," in the above 2 payloads, which make it a client 
> side payload error. But when firing such a request 500 internal server error 
> is thrown
>   



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (ATLAS-4075) 500 internal server error is thrown instead of 400 malformed request from atlas when the payload is mal formed

2020-12-11 Thread Dharshana M Krishnamoorthy (Jira) 
Dharshana M Krishnamoorthy created ATLAS-4075:
-

 Summary: 500 internal server error is thrown instead of 400 
malformed request from atlas when the payload is mal formed
 Key: ATLAS-4075
 URL: https://issues.apache.org/jira/browse/ATLAS-4075
 Project: Atlas
  Issue Type: Bug
Reporter: Dharshana M Krishnamoorthy
 Attachments: Screenshot 2020-12-11 at 1.29.32 PM.png, Screenshot 
2020-12-11 at 1.31.22 PM.png

{code:java|title=Malformed payload for creating a classification}
{
"classificationDefs": [
{
"name": "tag_1",
}
]
}
{code}
{code:java|title=Malformed payload for creating a classification}
{
"classificationDefs": [
{
"name": "tag_1"
},
]
}
{code}
There is an additional "," in the above 2 payloads, which make it a client side 
payload error. But when firing such a request 500 internal server error is 
thrown
  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)