[jira] [Created] (ATLAS-4128) Bulk import glossary terms should not allow creation of blank/empty glossaries

2021-02-03 Thread Dharshana M Krishnamoorthy (Jira)
Dharshana M Krishnamoorthy created ATLAS-4128:
-

 Summary: Bulk import glossary terms should not allow creation of 
blank/empty glossaries
 Key: ATLAS-4128
 URL: https://issues.apache.org/jira/browse/ATLAS-4128
 Project: Atlas
  Issue Type: Bug
  Components:  atlas-core
Reporter: Dharshana M Krishnamoorthy
 Attachments: Screenshot 2021-01-25 at 6.13.59 PM.png, Screenshot 
2021-01-28 at 11.25.14 AM.png

Currently via bulk import glossary term, we allow creation of blank/empty 
glossaries. 
We should not allow these

Response of : "api/atlas/v2/glossary" api
{code:java}
[
 {
 "guid": "34bf4540-5909-4a8e-84f0-1ff310870730",
 "qualifiedName": "glossary_1",
 "name": "glossary_1",
 "terms": [
 {
 "termGuid": "1ccaa2a2-f663-43ee-8cbc-f20c0ac95af0",
 "relationGuid": "b255b30e-be93-44e4-93bf-3d2d11a512d4",
 "displayText": "term_1"
 }
 ]
 },
 {
 "guid": "8834a901-0fde-4123-8d82-06e655ccf231",
 "qualifiedName": " ",
 "name": " ",
 "terms": [
 {
 "termGuid": "ac3f05d9-16d4-4ac5-be9c-bc5034af02d8",
 "relationGuid": "9c2ef8dd-522c-4d07-a338-093f39bceb93",
 "displayText": "no name term"
 }
 ]
 },
 {
 "guid": "29950f59-e863-42e2-a3f8-a070e706a934",
 "terms": [
 {
 "termGuid": "9e504d8d-8be2-4518-821a-cad3d86dfa6d",
 "relationGuid": "75f8f3d0-258a-4428-bb6c-08e59da90ee3",
 "displayText": "empty_term"
 }
 ]
 }
]

{code}
As seen above there exists a glossary with name " " and with no name.
Not sure of the implication of such a glossary
Though the request fails with right exception it ends up creating blank glossary

Payload used:
{code:java}
GlossaryName, TermName, ShortDescription, LongDescription, Examples, 
Abbreviation, Usage, AdditionalAttributes, TranslationTerms, ValidValuesFor, 
Synonyms, ReplacedBy, ValidValues, ReplacementTerms, SeeAlso, TranslatedTerms, 
IsA, Antonyms, Classifies, PreferredToTerms, PreferredTerms
" ", " ",{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-4116) UI should not allow the user to create a glossary with blank(" ") name

2021-02-03 Thread Keval Bhatt (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-4116:
---
Fix Version/s: 2.2.0

> UI should not allow the user to create a glossary with blank(" ") name
> --
>
> Key: ATLAS-4116
> URL: https://issues.apache.org/jira/browse/ATLAS-4116
> Project: Atlas
>  Issue Type: Bug
>Reporter: Nixon Rodrigues
>Assignee: Prasad P. Pawar
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: 
> 0001-ATLAS-4116-UI-UI-should-not-allow-the-user-to-create.patch, 
> 0001-ATLAS-4116-UI-V1-UI-should-not-allow-the-user-to-cre.patch, 
> 0001-Atlas-4166-UI-V2-UI-should-not-allow-the-user-to-cre.patch, 
> Atlas-4116Fix.png
>
>
> When just space is input the "Create" button is not enabled, but when the 
> space is selected, then the "Create" button is enabled and User is allowed to 
> click on "*Create*".
> This results in un-necessary failures
> *
> {"errorCode":"ATLAS-400-00-079","errorMessage":"Attributes qualifiedName and 
> name are missing. Failed to derive a unique name for Glossary"}
> *
> It is better to not allow clicking on "Create" for such an input via UI



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-4116) UI should not allow the user to create a glossary with blank(" ") name

2021-02-03 Thread Keval Bhatt (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-4116:
---
Fix Version/s: 3.0.0

> UI should not allow the user to create a glossary with blank(" ") name
> --
>
> Key: ATLAS-4116
> URL: https://issues.apache.org/jira/browse/ATLAS-4116
> Project: Atlas
>  Issue Type: Bug
>Reporter: Nixon Rodrigues
>Assignee: Prasad P. Pawar
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: 
> 0001-ATLAS-4116-UI-UI-should-not-allow-the-user-to-create.patch, 
> 0001-ATLAS-4116-UI-V1-UI-should-not-allow-the-user-to-cre.patch, 
> 0001-Atlas-4166-UI-V2-UI-should-not-allow-the-user-to-cre.patch, 
> Atlas-4116Fix.png
>
>
> When just space is input the "Create" button is not enabled, but when the 
> space is selected, then the "Create" button is enabled and User is allowed to 
> click on "*Create*".
> This results in un-necessary failures
> *
> {"errorCode":"ATLAS-400-00-079","errorMessage":"Attributes qualifiedName and 
> name are missing. Failed to derive a unique name for Glossary"}
> *
> It is better to not allow clicking on "Create" for such an input via UI



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-4127) Reduce number of Hive table calls in Atlas Hook

2021-02-03 Thread Sarath Subramanian (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian updated ATLAS-4127:
--
Component/s:  atlas-core

> Reduce number of Hive table calls in Atlas Hook
> ---
>
> Key: ATLAS-4127
> URL: https://issues.apache.org/jira/browse/ATLAS-4127
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 2.1.0
>Reporter: Deep Singh
>Priority: Major
>
> In Atlas Hive bridge, while calculating processQualifiedName, all partitions 
> are processed. 
> For each partition, a hive call is made to get table details. Since multiple 
> partitions can belong to the same table, there is a scope for improvement by 
> avoiding repeated hive calls for the same table information. 
> This improvement becomes crucial particularly in the case where there are 
> several partitions for a single table.  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (ATLAS-4127) Reduce number of Hive table calls in Atlas Hook

2021-02-03 Thread Sarath Subramanian (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian reassigned ATLAS-4127:
-

Assignee: Deep Singh

> Reduce number of Hive table calls in Atlas Hook
> ---
>
> Key: ATLAS-4127
> URL: https://issues.apache.org/jira/browse/ATLAS-4127
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 2.1.0
>Reporter: Deep Singh
>Assignee: Deep Singh
>Priority: Major
>  Labels: hive-hooks
>
> In Atlas Hive bridge, while calculating processQualifiedName, all partitions 
> are processed. 
> For each partition, a hive call is made to get table details. Since multiple 
> partitions can belong to the same table, there is a scope for improvement by 
> avoiding repeated hive calls for the same table information. 
> This improvement becomes crucial particularly in the case where there are 
> several partitions for a single table.  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-4127) Reduce number of Hive table calls in Atlas Hook

2021-02-03 Thread Sarath Subramanian (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian updated ATLAS-4127:
--
Labels: hive-hooks  (was: )

> Reduce number of Hive table calls in Atlas Hook
> ---
>
> Key: ATLAS-4127
> URL: https://issues.apache.org/jira/browse/ATLAS-4127
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 2.1.0
>Reporter: Deep Singh
>Priority: Major
>  Labels: hive-hooks
>
> In Atlas Hive bridge, while calculating processQualifiedName, all partitions 
> are processed. 
> For each partition, a hive call is made to get table details. Since multiple 
> partitions can belong to the same table, there is a scope for improvement by 
> avoiding repeated hive calls for the same table information. 
> This improvement becomes crucial particularly in the case where there are 
> several partitions for a single table.  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-4127) Reduce number of Hive table calls in Atlas Hook

2021-02-03 Thread Sarath Subramanian (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian updated ATLAS-4127:
--
Affects Version/s: 2.1.0

> Reduce number of Hive table calls in Atlas Hook
> ---
>
> Key: ATLAS-4127
> URL: https://issues.apache.org/jira/browse/ATLAS-4127
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 2.1.0
>Reporter: Deep Singh
>Priority: Major
>
> In Atlas Hive bridge, while calculating processQualifiedName, all partitions 
> are processed. 
> For each partition, a hive call is made to get table details. Since multiple 
> partitions can belong to the same table, there is a scope for improvement by 
> avoiding repeated hive calls for the same table information. 
> This improvement becomes crucial particularly in the case where there are 
> several partitions for a single table.  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 73170: ATLAS-4127 Reduce number of Hive table calls in Atlas Hook

2021-02-03 Thread Sarath Subramanian

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73170/#review222555
---


Ship it!




Ship It!

- Sarath Subramanian


On Feb. 3, 2021, 6:10 p.m., Deep Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73170/
> ---
> 
> (Updated Feb. 3, 2021, 6:10 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Rajesh 
> Balamohan, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4127
> https://issues.apache.org/jira/browse/ATLAS-4127
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> In Atlas Hive bridge, while calculating processQualifiedName, all partitions 
> are processed.
> For each partition, a hive call is made to get table details. Since multiple 
> partitions can belong to the same table, there is a scope for improvement by 
> avoiding repeated hive calls for the same table information.
> This improvement becomes crucial particularly in the case where there are 
> several partitions for a single table.
> 
> In DWX, query to populate store_sales takes 15 seconds to compile. 10+ 
> seconds in just Atlas hook for getting table details.
> 
> 
> Diffs
> -
> 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java
>  2b809a637 
> 
> 
> Diff: https://reviews.apache.org/r/73170/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Deep Singh
> 
>



[jira] [Commented] (ATLAS-4116) UI should not allow the user to create a glossary with blank(" ") name

2021-02-03 Thread Nixon Rodrigues (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-4116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17278531#comment-17278531
 ] 

Nixon Rodrigues commented on ATLAS-4116:


+1 for the patch , thanks [~prasadpp13] for the patch and [~kevalbhatt] for the 
code review

> UI should not allow the user to create a glossary with blank(" ") name
> --
>
> Key: ATLAS-4116
> URL: https://issues.apache.org/jira/browse/ATLAS-4116
> Project: Atlas
>  Issue Type: Bug
>Reporter: Nixon Rodrigues
>Assignee: Prasad P. Pawar
>Priority: Major
> Attachments: 
> 0001-ATLAS-4116-UI-UI-should-not-allow-the-user-to-create.patch, 
> 0001-ATLAS-4116-UI-V1-UI-should-not-allow-the-user-to-cre.patch, 
> 0001-Atlas-4166-UI-V2-UI-should-not-allow-the-user-to-cre.patch, 
> Atlas-4116Fix.png
>
>
> When just space is input the "Create" button is not enabled, but when the 
> space is selected, then the "Create" button is enabled and User is allowed to 
> click on "*Create*".
> This results in un-necessary failures
> *
> {"errorCode":"ATLAS-400-00-079","errorMessage":"Attributes qualifiedName and 
> name are missing. Failed to derive a unique name for Glossary"}
> *
> It is better to not allow clicking on "Create" for such an input via UI



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 73170: ATLAS-4127 Reduce number of Hive table calls in Atlas Hook

2021-02-03 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73170/#review222554
---


Ship it!




Ship It!

- Madhan Neethiraj


On Feb. 4, 2021, 2:10 a.m., Deep Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73170/
> ---
> 
> (Updated Feb. 4, 2021, 2:10 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Rajesh 
> Balamohan, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4127
> https://issues.apache.org/jira/browse/ATLAS-4127
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> In Atlas Hive bridge, while calculating processQualifiedName, all partitions 
> are processed.
> For each partition, a hive call is made to get table details. Since multiple 
> partitions can belong to the same table, there is a scope for improvement by 
> avoiding repeated hive calls for the same table information.
> This improvement becomes crucial particularly in the case where there are 
> several partitions for a single table.
> 
> In DWX, query to populate store_sales takes 15 seconds to compile. 10+ 
> seconds in just Atlas hook for getting table details.
> 
> 
> Diffs
> -
> 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java
>  2b809a637 
> 
> 
> Diff: https://reviews.apache.org/r/73170/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Deep Singh
> 
>



Review Request 73170: ATLAS-4127 Reduce number of Hive table calls in Atlas Hook

2021-02-03 Thread Deep Singh

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73170/
---

Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Rajesh Balamohan, 
and Sarath Subramanian.


Bugs: ATLAS-4127
https://issues.apache.org/jira/browse/ATLAS-4127


Repository: atlas


Description
---

In Atlas Hive bridge, while calculating processQualifiedName, all partitions 
are processed.
For each partition, a hive call is made to get table details. Since multiple 
partitions can belong to the same table, there is a scope for improvement by 
avoiding repeated hive calls for the same table information.
This improvement becomes crucial particularly in the case where there are 
several partitions for a single table.

In DWX, query to populate store_sales takes 15 seconds to compile. 10+ seconds 
in just Atlas hook for getting table details.


Diffs
-

  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java
 2b809a637 


Diff: https://reviews.apache.org/r/73170/diff/1/


Testing
---


Thanks,

Deep Singh



[jira] [Created] (ATLAS-4127) Reduce number of Hive table calls in Atlas Hook

2021-02-03 Thread Deep Singh (Jira)
Deep Singh created ATLAS-4127:
-

 Summary: Reduce number of Hive table calls in Atlas Hook
 Key: ATLAS-4127
 URL: https://issues.apache.org/jira/browse/ATLAS-4127
 Project: Atlas
  Issue Type: Bug
Reporter: Deep Singh


In Atlas Hive bridge, while calculating processQualifiedName, all partitions 
are processed. 
For each partition, a hive call is made to get table details. Since multiple 
partitions can belong to the same table, there is a scope for improvement by 
avoiding repeated hive calls for the same table information. 
This improvement becomes crucial particularly in the case where there are 
several partitions for a single table.  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (ATLAS-4126) Rewrite enable value is not present at Atlas for Materialized View metadata

2021-02-03 Thread Sidharth Kumar Mishra (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sidharth Kumar Mishra reassigned ATLAS-4126:


Assignee: Sidharth Kumar Mishra

> Rewrite enable value is not present at Atlas for Materialized View metadata
> ---
>
> Key: ATLAS-4126
> URL: https://issues.apache.org/jira/browse/ATLAS-4126
> Project: Atlas
>  Issue Type: Bug
>Reporter: Sidharth Kumar Mishra
>Assignee: Sidharth Kumar Mishra
>Priority: Major
>
> Repro steps:
> create table test_1 (id integer);
> CREATE MATERIALIZED VIEW test_mv_ctas_1 as select * from test_1;
> ALTER MATERIALIZED VIEW test_mv_ctas_1 enable rewrite;
> After this go to Atlas and see the Rewrite enable value is not present at 
> Atlas for the Materialized View entity test_mv_ctas_1
> [https://docs.cloudera.com/HDPDocuments/HDP3/HDP-3.1.5/materialized-view/content/hive_alter_materialized_view_rewrite.html]
> Even checked  parameters like transient_lastDdlTime is not getting populated 
> at hive_table of type MATERIALIZED_VIEW



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ATLAS-4126) Rewrite enable value is not present at Atlas for Materialized View metadata

2021-02-03 Thread Sidharth Kumar Mishra (Jira)
Sidharth Kumar Mishra created ATLAS-4126:


 Summary: Rewrite enable value is not present at Atlas for 
Materialized View metadata
 Key: ATLAS-4126
 URL: https://issues.apache.org/jira/browse/ATLAS-4126
 Project: Atlas
  Issue Type: Bug
Reporter: Sidharth Kumar Mishra


Repro steps:

create table test_1 (id integer);

CREATE MATERIALIZED VIEW test_mv_ctas_1 as select * from test_1;
ALTER MATERIALIZED VIEW test_mv_ctas_1 enable rewrite;

After this go to Atlas and see the Rewrite enable value is not present at Atlas 
for the Materialized View entity test_mv_ctas_1

[https://docs.cloudera.com/HDPDocuments/HDP3/HDP-3.1.5/materialized-view/content/hive_alter_materialized_view_rewrite.html]

Even checked  parameters like transient_lastDdlTime is not getting populated at 
hive_table of type MATERIALIZED_VIEW



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-4125) Create JavaPatch to add new supertypes to existing entities

2021-02-03 Thread Sarath Subramanian (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian updated ATLAS-4125:
--
Component/s:  atlas-core

> Create JavaPatch to add new supertypes to existing entities
> ---
>
> Key: ATLAS-4125
> URL: https://issues.apache.org/jira/browse/ATLAS-4125
> Project: Atlas
>  Issue Type: Task
>  Components:  atlas-core
>Affects Versions: 2.1.0
>Reporter: Radhika Kundam
>Assignee: Radhika Kundam
>Priority: Major
>
> As part of ATLAS-4098 introduced adding new super type for existing entity 
> type which is done by new action type "ADD_SUPER_TYPES" for Typedef patches. 
> With this patch, it will update entityType's definition with new superTypes.
> To provide backward compatibility for the above feature, we need to update 
> __superTypes for below.
> 1. All vertices with type of updated entityDef
> 2. All vertices of all sub-types of updated entityDef 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-4125) Create JavaPatch to add new supertypes to existing entities

2021-02-03 Thread Sarath Subramanian (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian updated ATLAS-4125:
--
Affects Version/s: 2.1.0

> Create JavaPatch to add new supertypes to existing entities
> ---
>
> Key: ATLAS-4125
> URL: https://issues.apache.org/jira/browse/ATLAS-4125
> Project: Atlas
>  Issue Type: Task
>Affects Versions: 2.1.0
>Reporter: Radhika Kundam
>Assignee: Radhika Kundam
>Priority: Major
>
> As part of ATLAS-4098 introduced adding new super type for existing entity 
> type which is done by new action type "ADD_SUPER_TYPES" for Typedef patches. 
> With this patch, it will update entityType's definition with new superTypes.
> To provide backward compatibility for the above feature, we need to update 
> __superTypes for below.
> 1. All vertices with type of updated entityDef
> 2. All vertices of all sub-types of updated entityDef 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ATLAS-4125) Create JavaPatch to add new supertypes to existing entities

2021-02-03 Thread Radhika Kundam (Jira)
Radhika Kundam created ATLAS-4125:
-

 Summary: Create JavaPatch to add new supertypes to existing 
entities
 Key: ATLAS-4125
 URL: https://issues.apache.org/jira/browse/ATLAS-4125
 Project: Atlas
  Issue Type: Task
Reporter: Radhika Kundam
Assignee: Radhika Kundam


As part of ATLAS-4098 introduced adding new super type for existing entity type 
which is done by new action type "ADD_SUPER_TYPES" for Typedef patches. With 
this patch, it will update entityType's definition with new superTypes.

To provide backward compatibility for the above feature, we need to update 
__superTypes for below.

1. All vertices with type of updated entityDef

2. All vertices of all sub-types of updated entityDef 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-4112) Basic Search : Incorrect results when searching with value having special char and contains/beginsWith/endsWith operator

2021-02-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-4112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17278395#comment-17278395
 ] 

ASF subversion and git services commented on ATLAS-4112:


Commit 0296ad6f4acbc00b66811655aa5729cff00769d0 in atlas's branch 
refs/heads/branch-2.0 from Pinal
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=0296ad6 ]

ATLAS-4112 : Basic Search : Attribute search of QualifiedName beginswith 
operator not returning results when the value ends with a digit+dot

Signed-off-by: Sarath Subramanian 
(cherry picked from commit e873515f5c9bd4cbc6eda9609034779bcddaf3a4)


> Basic Search : Incorrect results when searching with value having special 
> char and contains/beginsWith/endsWith operator
> 
>
> Key: ATLAS-4112
> URL: https://issues.apache.org/jira/browse/ATLAS-4112
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 2.1.0
>Reporter: Pinal
>Assignee: Pinal
>Priority: Major
>  Labels: BasicSearch
> Fix For: 3.0.0, 2.2.0
>
>
> *Problem:* While searching with wildcard search i.e contains, beginsWith, 
> endsWith operator, which has special characters in search attribute value 
> gives incorrect results
> *Example:* While searching qualifiedName beginsWith 
> "default.datagen_table_sensitive_725_1."
> *Solution:* Remove quotes and wildcard '*' from query
> *Steps to reproduce:*
> 1. Create a hive_table with name ends with a digit: 
> datagen_table_sensitive_725_1
> 2. Search By Type: hive_columns and select attribute filter: qualifiedName as 
> "default.datagen_table_sensitive_725__1." shows no Records found_ but if 
> qualifiedName is changed to "default.datagen_table_sensitive_725_1" _it shows 
> results with qualifiedName of column 
> "default.datagen_table_sensitive_725___1.col1@cm"_



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-4112) Basic Search : Incorrect results when searching with value having special char and contains/beginsWith/endsWith operator

2021-02-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-4112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17278394#comment-17278394
 ] 

ASF subversion and git services commented on ATLAS-4112:


Commit e873515f5c9bd4cbc6eda9609034779bcddaf3a4 in atlas's branch 
refs/heads/master from Pinal
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=e873515 ]

ATLAS-4112 : Basic Search : Attribute search of QualifiedName beginswith 
operator not returning results when the value ends with a digit+dot

Signed-off-by: Sarath Subramanian 


> Basic Search : Incorrect results when searching with value having special 
> char and contains/beginsWith/endsWith operator
> 
>
> Key: ATLAS-4112
> URL: https://issues.apache.org/jira/browse/ATLAS-4112
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 2.1.0
>Reporter: Pinal
>Assignee: Pinal
>Priority: Major
>  Labels: BasicSearch
> Fix For: 3.0.0, 2.2.0
>
>
> *Problem:* While searching with wildcard search i.e contains, beginsWith, 
> endsWith operator, which has special characters in search attribute value 
> gives incorrect results
> *Example:* While searching qualifiedName beginsWith 
> "default.datagen_table_sensitive_725_1."
> *Solution:* Remove quotes and wildcard '*' from query
> *Steps to reproduce:*
> 1. Create a hive_table with name ends with a digit: 
> datagen_table_sensitive_725_1
> 2. Search By Type: hive_columns and select attribute filter: qualifiedName as 
> "default.datagen_table_sensitive_725__1." shows no Records found_ but if 
> qualifiedName is changed to "default.datagen_table_sensitive_725_1" _it shows 
> results with qualifiedName of column 
> "default.datagen_table_sensitive_725___1.col1@cm"_



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-4112) Basic Search : Incorrect results when searching with value having special char and contains/beginsWith/endsWith operator

2021-02-03 Thread Sarath Subramanian (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian updated ATLAS-4112:
--
Fix Version/s: 2.2.0
   3.0.0

> Basic Search : Incorrect results when searching with value having special 
> char and contains/beginsWith/endsWith operator
> 
>
> Key: ATLAS-4112
> URL: https://issues.apache.org/jira/browse/ATLAS-4112
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 2.1.0
>Reporter: Pinal
>Assignee: Pinal
>Priority: Major
>  Labels: BasicSearch
> Fix For: 3.0.0, 2.2.0
>
>
> *Problem:* While searching with wildcard search i.e contains, beginsWith, 
> endsWith operator, which has special characters in search attribute value 
> gives incorrect results
> *Example:* While searching qualifiedName beginsWith 
> "default.datagen_table_sensitive_725_1."
> *Solution:* Remove quotes and wildcard '*' from query
> *Steps to reproduce:*
> 1. Create a hive_table with name ends with a digit: 
> datagen_table_sensitive_725_1
> 2. Search By Type: hive_columns and select attribute filter: qualifiedName as 
> "default.datagen_table_sensitive_725__1." shows no Records found_ but if 
> qualifiedName is changed to "default.datagen_table_sensitive_725_1" _it shows 
> results with qualifiedName of column 
> "default.datagen_table_sensitive_725___1.col1@cm"_



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-4112) Basic Search : Incorrect results when searching with value having special char and contains/beginsWith/endsWith operator

2021-02-03 Thread Sarath Subramanian (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian updated ATLAS-4112:
--
Affects Version/s: 2.1.0

> Basic Search : Incorrect results when searching with value having special 
> char and contains/beginsWith/endsWith operator
> 
>
> Key: ATLAS-4112
> URL: https://issues.apache.org/jira/browse/ATLAS-4112
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 2.1.0
>Reporter: Pinal
>Assignee: Pinal
>Priority: Major
>  Labels: BasicSearch
>
> *Problem:* While searching with wildcard search i.e contains, beginsWith, 
> endsWith operator, which has special characters in search attribute value 
> gives incorrect results
> *Example:* While searching qualifiedName beginsWith 
> "default.datagen_table_sensitive_725_1."
> *Solution:* Remove quotes and wildcard '*' from query
> *Steps to reproduce:*
> 1. Create a hive_table with name ends with a digit: 
> datagen_table_sensitive_725_1
> 2. Search By Type: hive_columns and select attribute filter: qualifiedName as 
> "default.datagen_table_sensitive_725__1." shows no Records found_ but if 
> qualifiedName is changed to "default.datagen_table_sensitive_725_1" _it shows 
> results with qualifiedName of column 
> "default.datagen_table_sensitive_725___1.col1@cm"_



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 73160: ATLAS-4112 : Basic Search : Incorrect results when searching with value having special char and contains/beginsWith/endsWith operator

2021-02-03 Thread Sarath Subramanian

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73160/#review222551
---


Ship it!




Ship It!

- Sarath Subramanian


On Feb. 3, 2021, 8:16 a.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73160/
> ---
> 
> (Updated Feb. 3, 2021, 8:16 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4112
> https://issues.apache.org/jira/browse/ATLAS-4112
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Problem:** While searching with wildcard search i.e contains, beginsWith, 
> endsWith operator, which has escape characters in search attribute value 
> gives incorrect results
> 
> **Example:** While searching qualifiedName beginsWith 
> "default.datagen_table_sensitive_725_1."
> 
> **Solution:** Remove quotes and wildcard '*' from query
> 
> **Steps to reproduce:**
> 1. Create a hive_table with name ends with a digit: 
> datagen_table_sensitive_725_1
> 2. Search By Type: hive_columns and select attribute filter: qualifiedName as 
> "default.datagen_table_sensitive_725_1." shows no Records found but if 
> qualifiedName is changed to "default.datagen_table_sensitive_725_1" it shows 
> results with qualifiedName of column 
> "default.datagen_table_sensitive_725_1.col1@cm"
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 050980994 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
> 01daf53d2 
>   
> repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
>  0da60d37f 
> 
> 
> Diff: https://reviews.apache.org/r/73160/diff/3/
> 
> 
> Testing
> ---
> 
> Added unit test cases
> Precommit: 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/353/console
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>



Re: Review Request 73166: Clause Change for Glossary

2021-02-03 Thread Ashutosh Mestry via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73166/
---

(Updated Feb. 3, 2021, 9:46 p.m.)


Review request for atlas, Nikhil Bonte, Pinal Shah, and Sarath Subramanian.


Changes
---

Updates include: 
- Addressed review comments.
- Rebased.


Bugs: ATLAS-4109
https://issues.apache.org/jira/browse/ATLAS-4109


Repository: atlas


Description
---

Replaced _or_ with _where_ for simplicity.


Diffs (updated)
-

  repository/src/main/java/org/apache/atlas/query/GremlinClause.java b7e5330ce 
  
repository/src/main/java/org/apache/atlas/query/executors/GremlinClauseToTraversalTranslator.java
 156a65ccb 
  repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java 
3594e2f34 


Diff: https://reviews.apache.org/r/73166/diff/2/

Changes: https://reviews.apache.org/r/73166/diff/1-2/


Testing
---

**Unit tests**
- Existing tests run.
- Updated _GremlinQueryComposer_ to include the new clause.

**PC-build**
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/363/


Thanks,

Ashutosh Mestry



Re: Review Request 73169: ATLAS-4123: Lineage missing in case of CREATE MATERIALIZED VIEW query at Hive

2021-02-03 Thread Sidharth Mishra

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73169/
---

(Updated Feb. 3, 2021, 6:04 p.m.)


Review request for atlas, Ashutosh Mestry, Deep Singh, Madhan Neethiraj, 
Radhika Kundam, and Sarath Subramanian.


Bugs: ATLAS-4123
https://issues.apache.org/jira/browse/ATLAS-4123


Repository: atlas


Description
---

ATLAS-4123: Lineage missing in case of CREATE MATERIALIZED VIEW query at Hive


Diffs
-

  addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 
e48967d63 


Diff: https://reviews.apache.org/r/73169/diff/1/


Testing (updated)
---

Atlas hook topic message from the hive hook before fix:
===

{
"version": {
"version": "1.0.0",
"versionParts": [
1
]
},
"msgCompressionKind": "NONE",
"msgSplitIdx": 1,
"msgSplitCount": 1,
"msgSourceIP": "172.27.10.2",
"msgCreatedBy": "hive",
"msgCreationTime": 1612311707304,
"message": {
"type": "ENTITY_CREATE_V2",
"user": "hive",
"entities": {
"referredEntities": {
"-73285185733726514": {
"typeName": "hive_storagedesc",
"attributes": {
"qualifiedName": "default.test_mv_ctas_2@cm_storage",
"storedAsSubDirectories": false,
"location": 
"hdfs://secure-2.secure.root.hwx.site:8020/warehouse/tablespace/managed/hive/test_mv_ctas_2",
"compressed": false,
"inputFormat": 
"org.apache.hadoop.hive.ql.io.orc.OrcInputFormat",
"parameters": {},
"outputFormat": 
"org.apache.hadoop.hive.ql.io.orc.OrcOutputFormat",
"serdeInfo": {
"typeName": "hive_serde",
"attributes": {
"serializationLib": 
"org.apache.hadoop.hive.ql.io.orc.OrcSerde",
"name": null,
"parameters": {}
}
},
"numBuckets": -1
},
"guid": "-73285185733726514",
"isIncomplete": false,
"provenanceType": 0,
"version": 0,
"relationshipAttributes": {
"table": {
"guid": "-73285185733726513",
"typeName": "hive_table",
"uniqueAttributes": {
"qualifiedName": "default.test_mv_ctas_2@cm"
},
"relationshipType": "hive_table_storagedesc"
}
},
"proxy": false
},
"-73285185733726515": {
"typeName": "hive_column",
"attributes": {
"owner": "admin",
"qualifiedName": "default.test_mv_ctas_2.id@cm",
"name": "id",
"comment": null,
"position": 0,
"type": "int"
},
"guid": "-73285185733726515",
"isIncomplete": false,
"provenanceType": 0,
"version": 0,
"relationshipAttributes": {
"table": {
"guid": "-73285185733726513",
"typeName": "hive_table",
"uniqueAttributes": {
"qualifiedName": "default.test_mv_ctas_2@cm"
},
"relationshipType": "hive_table_columns"
}
},
"proxy": false
}
},
"entities": [
{
"typeName": "hive_table",
"attributes": {
"owner": "admin",
"viewExpandedText": "select `test_1`.`id` from 
`default`.`test_1`",
"tableType": "MATERIALIZED_VIEW",
"temporary": false,
"lastAccessTime": 1612311707000,
"createTime": 1612311707000,
"qualifiedName": "default.test_mv_ctas_2@cm",
"name": "test_mv_ctas_2",
"comment": null,
"parameters": {
"transient_lastDdlTime": "1612311707",
"bucketing_version"

[jira] [Commented] (ATLAS-4123) Lineage missing in case of CREATE MATERIALIZED VIEW query at Hive

2021-02-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17278237#comment-17278237
 ] 

ASF subversion and git services commented on ATLAS-4123:


Commit d3e36976a3d24d0ffe8f3f2ed4198423c2c3cfac in atlas's branch 
refs/heads/branch-2.0 from sidmishra
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=d3e3697 ]

ATLAS-4123: Handle create/drop materialized view queries in hive hook

Signed-off-by: Sarath Subramanian 
(cherry picked from commit 0b02bd9f21eab4354b7d8479e05a38db75e5e1a0)


> Lineage missing in case of CREATE MATERIALIZED VIEW query at Hive
> -
>
> Key: ATLAS-4123
> URL: https://issues.apache.org/jira/browse/ATLAS-4123
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 2.1.0
>Reporter: Sidharth Kumar Mishra
>Assignee: Sidharth Kumar Mishra
>Priority: Major
>  Labels: hivehook
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-4123.patch
>
>
> Issue:
> At hive run the below queries:
> create table test_1 (id integer);
> CREATE MATERIALIZED VIEW test_mv_ctas_1 as select * from test_1;
> Expected behaviour:
> At Atlas we should have the lineage created between hive_table entity test_1 
> and test_mv_ctas_1
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-4123) Lineage missing in case of CREATE MATERIALIZED VIEW query at Hive

2021-02-03 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17278234#comment-17278234
 ] 

ASF subversion and git services commented on ATLAS-4123:


Commit 0b02bd9f21eab4354b7d8479e05a38db75e5e1a0 in atlas's branch 
refs/heads/master from sidmishra
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=0b02bd9 ]

ATLAS-4123: Handle create/drop materialized view queries in hive hook

Signed-off-by: Sarath Subramanian 


> Lineage missing in case of CREATE MATERIALIZED VIEW query at Hive
> -
>
> Key: ATLAS-4123
> URL: https://issues.apache.org/jira/browse/ATLAS-4123
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 2.1.0
>Reporter: Sidharth Kumar Mishra
>Assignee: Sidharth Kumar Mishra
>Priority: Major
>  Labels: hivehook
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-4123.patch
>
>
> Issue:
> At hive run the below queries:
> create table test_1 (id integer);
> CREATE MATERIALIZED VIEW test_mv_ctas_1 as select * from test_1;
> Expected behaviour:
> At Atlas we should have the lineage created between hive_table entity test_1 
> and test_mv_ctas_1
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-4123) Lineage missing in case of CREATE MATERIALIZED VIEW query at Hive

2021-02-03 Thread Sarath Subramanian (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian updated ATLAS-4123:
--
Component/s:  atlas-core

> Lineage missing in case of CREATE MATERIALIZED VIEW query at Hive
> -
>
> Key: ATLAS-4123
> URL: https://issues.apache.org/jira/browse/ATLAS-4123
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 2.1.0
>Reporter: Sidharth Kumar Mishra
>Assignee: Sidharth Kumar Mishra
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-4123.patch
>
>
> Issue:
> At hive run the below queries:
> create table test_1 (id integer);
> CREATE MATERIALIZED VIEW test_mv_ctas_1 as select * from test_1;
> Expected behaviour:
> At Atlas we should have the lineage created between hive_table entity test_1 
> and test_mv_ctas_1
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-4123) Lineage missing in case of CREATE MATERIALIZED VIEW query at Hive

2021-02-03 Thread Sarath Subramanian (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian updated ATLAS-4123:
--
Fix Version/s: 2.2.0
   3.0.0

> Lineage missing in case of CREATE MATERIALIZED VIEW query at Hive
> -
>
> Key: ATLAS-4123
> URL: https://issues.apache.org/jira/browse/ATLAS-4123
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 2.1.0
>Reporter: Sidharth Kumar Mishra
>Assignee: Sidharth Kumar Mishra
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-4123.patch
>
>
> Issue:
> At hive run the below queries:
> create table test_1 (id integer);
> CREATE MATERIALIZED VIEW test_mv_ctas_1 as select * from test_1;
> Expected behaviour:
> At Atlas we should have the lineage created between hive_table entity test_1 
> and test_mv_ctas_1
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-4123) Lineage missing in case of CREATE MATERIALIZED VIEW query at Hive

2021-02-03 Thread Sarath Subramanian (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian updated ATLAS-4123:
--
Labels: hivehook  (was: )

> Lineage missing in case of CREATE MATERIALIZED VIEW query at Hive
> -
>
> Key: ATLAS-4123
> URL: https://issues.apache.org/jira/browse/ATLAS-4123
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 2.1.0
>Reporter: Sidharth Kumar Mishra
>Assignee: Sidharth Kumar Mishra
>Priority: Major
>  Labels: hivehook
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-4123.patch
>
>
> Issue:
> At hive run the below queries:
> create table test_1 (id integer);
> CREATE MATERIALIZED VIEW test_mv_ctas_1 as select * from test_1;
> Expected behaviour:
> At Atlas we should have the lineage created between hive_table entity test_1 
> and test_mv_ctas_1
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-4123) Lineage missing in case of CREATE MATERIALIZED VIEW query at Hive

2021-02-03 Thread Sarath Subramanian (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian updated ATLAS-4123:
--
Affects Version/s: 2.1.0

> Lineage missing in case of CREATE MATERIALIZED VIEW query at Hive
> -
>
> Key: ATLAS-4123
> URL: https://issues.apache.org/jira/browse/ATLAS-4123
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 2.1.0
>Reporter: Sidharth Kumar Mishra
>Assignee: Sidharth Kumar Mishra
>Priority: Major
> Attachments: ATLAS-4123.patch
>
>
> Issue:
> At hive run the below queries:
> create table test_1 (id integer);
> CREATE MATERIALIZED VIEW test_mv_ctas_1 as select * from test_1;
> Expected behaviour:
> At Atlas we should have the lineage created between hive_table entity test_1 
> and test_mv_ctas_1
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 73169: ATLAS-4123: Lineage missing in case of CREATE MATERIALIZED VIEW query at Hive

2021-02-03 Thread Sarath Subramanian

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73169/#review222548
---


Ship it!




Ship It!

- Sarath Subramanian


On Feb. 2, 2021, 5:52 p.m., Sidharth Mishra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73169/
> ---
> 
> (Updated Feb. 2, 2021, 5:52 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Deep Singh, Madhan Neethiraj, 
> Radhika Kundam, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4123
> https://issues.apache.org/jira/browse/ATLAS-4123
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-4123: Lineage missing in case of CREATE MATERIALIZED VIEW query at Hive
> 
> 
> Diffs
> -
> 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 
> e48967d63 
> 
> 
> Diff: https://reviews.apache.org/r/73169/diff/1/
> 
> 
> Testing
> ---
> 
> Atlas hook topic message from the hive hook before fix:
> ===
> 
> {
> "version": {
> "version": "1.0.0",
> "versionParts": [
> 1
> ]
> },
> "msgCompressionKind": "NONE",
> "msgSplitIdx": 1,
> "msgSplitCount": 1,
> "msgSourceIP": "172.27.10.2",
> "msgCreatedBy": "hive",
> "msgCreationTime": 1612311707304,
> "message": {
> "type": "ENTITY_CREATE_V2",
> "user": "hive",
> "entities": {
> "referredEntities": {
> "-73285185733726514": {
> "typeName": "hive_storagedesc",
> "attributes": {
> "qualifiedName": "default.test_mv_ctas_2@cm_storage",
> "storedAsSubDirectories": false,
> "location": 
> "hdfs://sarath-secure-2.sarath-secure.root.hwx.site:8020/warehouse/tablespace/managed/hive/test_mv_ctas_2",
> "compressed": false,
> "inputFormat": 
> "org.apache.hadoop.hive.ql.io.orc.OrcInputFormat",
> "parameters": {},
> "outputFormat": 
> "org.apache.hadoop.hive.ql.io.orc.OrcOutputFormat",
> "serdeInfo": {
> "typeName": "hive_serde",
> "attributes": {
> "serializationLib": 
> "org.apache.hadoop.hive.ql.io.orc.OrcSerde",
> "name": null,
> "parameters": {}
> }
> },
> "numBuckets": -1
> },
> "guid": "-73285185733726514",
> "isIncomplete": false,
> "provenanceType": 0,
> "version": 0,
> "relationshipAttributes": {
> "table": {
> "guid": "-73285185733726513",
> "typeName": "hive_table",
> "uniqueAttributes": {
> "qualifiedName": "default.test_mv_ctas_2@cm"
> },
> "relationshipType": "hive_table_storagedesc"
> }
> },
> "proxy": false
> },
> "-73285185733726515": {
> "typeName": "hive_column",
> "attributes": {
> "owner": "admin",
> "qualifiedName": "default.test_mv_ctas_2.id@cm",
> "name": "id",
> "comment": null,
> "position": 0,
> "type": "int"
> },
> "guid": "-73285185733726515",
> "isIncomplete": false,
> "provenanceType": 0,
> "version": 0,
> "relationshipAttributes": {
> "table": {
> "guid": "-73285185733726513",
> "typeName": "hive_table",
> "uniqueAttributes": {
> "qualifiedName": "default.test_mv_ctas_2@cm"
> },
> "relationshipType": "hive_table_columns"
> }
> },
> "proxy": false
> }
> },
> "entities": [
> {
> "typeName": "hive_table",
> "attributes": {
> "owner": "admin",
>  

Re: Review Request 73160: ATLAS-4112 : Basic Search : Incorrect results when searching with value having special char and contains/beginsWith/endsWith operator

2021-02-03 Thread Pinal Shah

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73160/
---

(Updated Feb. 3, 2021, 4:16 p.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Changes
---

refactored


Bugs: ATLAS-4112
https://issues.apache.org/jira/browse/ATLAS-4112


Repository: atlas


Description
---

**Problem:** While searching with wildcard search i.e contains, beginsWith, 
endsWith operator, which has escape characters in search attribute value gives 
incorrect results

**Example:** While searching qualifiedName beginsWith 
"default.datagen_table_sensitive_725_1."

**Solution:** Remove quotes and wildcard '*' from query

**Steps to reproduce:**
1. Create a hive_table with name ends with a digit: 
datagen_table_sensitive_725_1
2. Search By Type: hive_columns and select attribute filter: qualifiedName as 
"default.datagen_table_sensitive_725_1." shows no Records found but if 
qualifiedName is changed to "default.datagen_table_sensitive_725_1" it shows 
results with qualifiedName of column 
"default.datagen_table_sensitive_725_1.col1@cm"


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 050980994 
  repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
01daf53d2 
  
repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
 0da60d37f 


Diff: https://reviews.apache.org/r/73160/diff/3/

Changes: https://reviews.apache.org/r/73160/diff/2-3/


Testing
---

Added unit test cases
Precommit: 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/353/console


Thanks,

Pinal Shah



Re: Review Request 73166: Clause Change for Glossary

2021-02-03 Thread Pinal Shah

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73166/#review222545
---




repository/src/main/java/org/apache/atlas/query/GremlinClause.java
Line 72 (original), 72 (patched)


Purpose of adding 'and(.in)' was to avoid traversing to the edge and then 
end vertex


- Pinal Shah


On Feb. 1, 2021, 5:20 p.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73166/
> ---
> 
> (Updated Feb. 1, 2021, 5:20 p.m.)
> 
> 
> Review request for atlas, Nikhil Bonte, Pinal Shah, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4109
> https://issues.apache.org/jira/browse/ATLAS-4109
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Replaced _or_ with _where_ for simplicity.
> 
> 
> Diffs
> -
> 
>   repository/src/main/java/org/apache/atlas/query/GremlinClause.java 
> b7e5330ce 
>   
> repository/src/main/java/org/apache/atlas/query/executors/GremlinClauseToTraversalTranslator.java
>  a7b05fd88 
>   
> repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java 
> 0e8af186d 
> 
> 
> Diff: https://reviews.apache.org/r/73166/diff/1/
> 
> 
> Testing
> ---
> 
> **Unit tests**
> - Existing tests run.
> - Updated _GremlinQueryComposer_ to include the new clause.
> 
> **PC-build**
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/363/
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>



Re: Review Request 73166: Clause Change for Glossary

2021-02-03 Thread Nikhil Bonte

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73166/#review222543
---


Ship it!




Ship It!

- Nikhil Bonte


On Feb. 1, 2021, 10:50 p.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73166/
> ---
> 
> (Updated Feb. 1, 2021, 10:50 p.m.)
> 
> 
> Review request for atlas, Nikhil Bonte, Pinal Shah, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4109
> https://issues.apache.org/jira/browse/ATLAS-4109
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Replaced _or_ with _where_ for simplicity.
> 
> 
> Diffs
> -
> 
>   repository/src/main/java/org/apache/atlas/query/GremlinClause.java 
> b7e5330ce 
>   
> repository/src/main/java/org/apache/atlas/query/executors/GremlinClauseToTraversalTranslator.java
>  a7b05fd88 
>   
> repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java 
> 0e8af186d 
> 
> 
> Diff: https://reviews.apache.org/r/73166/diff/1/
> 
> 
> Testing
> ---
> 
> **Unit tests**
> - Existing tests run.
> - Updated _GremlinQueryComposer_ to include the new clause.
> 
> **PC-build**
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/363/
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>



[jira] [Comment Edited] (ATLAS-4115) Ranger Tag Sync via ATLAS

2021-02-03 Thread Tansheet Izhad (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-4115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17275659#comment-17275659
 ] 

Tansheet Izhad edited comment on ATLAS-4115 at 2/3/21, 10:27 AM:
-

[~sarath] This seems to be an issue with older version of Atlas, I installed 
Atlas 2.0.0 and the issue got resolved. Thank you.


was (Author: tansheet):
[~sarath] This seems to be an issue with older version of Atlas, I installed 
Atlas 2.0.0 and the issue got resolved. Thanks you.

> Ranger Tag Sync via ATLAS
> -
>
> Key: ATLAS-4115
> URL: https://issues.apache.org/jira/browse/ATLAS-4115
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Tansheet Izhad
>Priority: Major
>
> Currently trying to do ranger tag sync with a new in-build apache Atlas. 
> Using the ATLAS_REST_ENDPOINT for the tag sync.
> But getting the following error:
>  
> {code:java}
> 28 Jan 2021 17:17:57 ERROR AtlasRESTTagSource [Thread-7] - 287 failed to 
> download tags from Atlas
> org.apache.atlas.exception.AtlasBaseException: Given typename 
> AtlasGlossaryCategory was invalid
>  at 
> org.apache.atlas.type.AtlasTypeRegistry.getType(AtlasTypeRegistry.java:108)
>  at 
> org.apache.atlas.type.AtlasRelationshipType.resolveReferences(AtlasRelationshipType.java:94)
>  at 
> org.apache.atlas.type.AtlasTypeRegistry$AtlasTransientTypeRegistry.resolveReferences(AtlasTypeRegistry.java:373)
>  at 
> org.apache.atlas.type.AtlasTypeRegistry$AtlasTransientTypeRegistry.addTypes(AtlasTypeRegistry.java:445)
>  at 
> org.apache.ranger.tagsync.source.atlasrest.AtlasRESTTagSource.getAtlasActiveEntities(AtlasRESTTagSource.java:284)
>  at 
> org.apache.ranger.tagsync.source.atlasrest.AtlasRESTTagSource.synchUp(AtlasRESTTagSource.java:217)
>  at 
> org.apache.ranger.tagsync.source.atlasrest.AtlasRESTTagSource.run(AtlasRESTTagSource.java:200)
> {code}
> Looks like it's failing because of invalid Type. But not able to find 
> AtlasGlossaryCategory type on the atlas UI.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ATLAS-4124) Prevent user from deleting Business Metadata, if Business Metadata is already associated with an entity

2021-02-03 Thread Mandar Ambawane (Jira)
Mandar Ambawane created ATLAS-4124:
--

 Summary: Prevent user from deleting Business Metadata, if Business 
Metadata is already associated with an entity
 Key: ATLAS-4124
 URL: https://issues.apache.org/jira/browse/ATLAS-4124
 Project: Atlas
  Issue Type: Improvement
Reporter: Mandar Ambawane
Assignee: Mandar Ambawane






--
This message was sent by Atlassian Jira
(v8.3.4#803005)