Re: Review Request 73218: Creation of relations does not work for glossary import

[Sarath Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73218/#review222768
---


Ship it!




Ship It!

- Sarath Subramanian


On March 31, 2021, 3:44 p.m., Sidharth Mishra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73218/
> ---
> 
> (Updated March 31, 2021, 3:44 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Deep Singh, Madhan Neethiraj, 
> Radhika Kundam, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4191
> https://issues.apache.org/jira/browse/ATLAS-4191
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Creation of relations does not work for glossary import
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 884f81fd0 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 
> d1567009c 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java 
> 647dd3bef 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
>  9f143d494 
>   repository/src/main/java/org/apache/atlas/util/FileUtils.java 57df9abeb 
> 
> 
> Diff: https://reviews.apache.org/r/73218/diff/2/
> 
> 
> Testing
> ---
> 
> Manually tested importing the glossary with circular reference
> 
> 
> Thanks,
> 
> Sidharth Mishra
> 
>

Re: Review Request 73218: Creation of relations does not work for glossary import

[Sarath Subramanian]

> On April 1, 2021, 4:12 p.m., Sarath Subramanian wrote:
> >

Add Unit test coverage with example of circular relationship import.


- Sarath


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73218/#review222766
---


On March 31, 2021, 3:44 p.m., Sidharth Mishra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73218/
> ---
> 
> (Updated March 31, 2021, 3:44 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Deep Singh, Madhan Neethiraj, 
> Radhika Kundam, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4191
> https://issues.apache.org/jira/browse/ATLAS-4191
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Creation of relations does not work for glossary import
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 884f81fd0 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 
> d1567009c 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java 
> 647dd3bef 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
>  9f143d494 
>   repository/src/main/java/org/apache/atlas/util/FileUtils.java 57df9abeb 
> 
> 
> Diff: https://reviews.apache.org/r/73218/diff/2/
> 
> 
> Testing
> ---
> 
> Manually tested importing the glossary with circular reference
> 
> 
> Thanks,
> 
> Sidharth Mishra
> 
>

Re: Review Request 73218: Creation of relations does not work for glossary import

[Sarath Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73218/#review222766
---




repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
Lines 401 (patched)


dontUpdateIfAlreadyExists => ignoreUpdateIfTermExists



repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java
Lines 549 (patched)


Consider using a static constant for empty string:

String glossaryName = StringUtils.EMPTY



repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java
Line 693 (original), 700 (patched)


populateRelations => processRelations


- Sarath Subramanian


On March 31, 2021, 3:44 p.m., Sidharth Mishra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73218/
> ---
> 
> (Updated March 31, 2021, 3:44 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Deep Singh, Madhan Neethiraj, 
> Radhika Kundam, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4191
> https://issues.apache.org/jira/browse/ATLAS-4191
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Creation of relations does not work for glossary import
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 884f81fd0 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 
> d1567009c 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java 
> 647dd3bef 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
>  9f143d494 
>   repository/src/main/java/org/apache/atlas/util/FileUtils.java 57df9abeb 
> 
> 
> Diff: https://reviews.apache.org/r/73218/diff/2/
> 
> 
> Testing
> ---
> 
> Manually tested importing the glossary with circular reference
> 
> 
> Thanks,
> 
> Sidharth Mishra
> 
>

[jira] [Created] (ATLAS-4236) [Atlas: Audits][Intermittent] There were 2 audits for an entity update action one with differential enabled and one was without differential within a few milliseconds

[Dharshana M Krishnamoorthy (Jira)]

Dharshana M Krishnamoorthy created ATLAS-4236:
-

 Summary: [Atlas: Audits][Intermittent] There were 2 audits for an 
entity update action one with differential enabled and one was without 
differential within a few milliseconds
 Key: ATLAS-4236
 URL: https://issues.apache.org/jira/browse/ATLAS-4236
 Project: Atlas
  Issue Type: Bug
  Components:  atlas-core
Reporter: Dharshana M Krishnamoorthy


There was an entity update action and there were 2 audits created, for same 
action one with differential enabled and the other was without differential 
audit enabled within a few milli seconds

The cluster on which this occurred is still alive, but this was not 
reproduce-able later

Even if we suspect a config update in atlas and a restart, it would talk 
atleast a few minutes for the config to take effect and the next audit should 
be without differential audit enabled. But this was within a few milli seconds.

[https://quasar-nealzi-1.quasar-nealzi.root.hwx.site:31443/api/atlas/v2/entity/fa12e741-5e5f-45f8-bdd5-239b766e1d76/audit]
{code:java}
[
{
"entityId": "fa12e741-5e5f-45f8-bdd5-239b766e1d76",
"timestamp": 1617262937842,
"user": "hrt_qa",
"action": "CUSTOM_ATTRIBUTE_UPDATE",
"details": "Updated custom attribute: 
{\"typeName\":\"entity_type_ozsue\",\"attributes\":{\"type_short_min\":-32768,\"type_bigint_rand\":-5,\"type_bigdecimal_rand\":-5.0,\"type_byte_max\":127,\"type_set\":[\"1\",\"2\",\"3\",\"4\",\"5\"],\"type_short_max\":32767,\"type_bool_true\":true,\"type_str\":\"new_attrib_value\",\"type_double_rand\":-5.0,\"type_float_rand\":-5.0,\"type_date\":1494183548574,\"type_bool_false\":false,\"type_bigdecimal_max\":1.7976931348623157E+308,\"type_bigint_max\":9223372036854775807,\"type_short_rand\":5,\"type_double_max\":1.7976931348623157E308,\"type_bigdecimal_min\":5E-324,\"type_byte_rand\":5,\"type_double_min\":4.9E-324,\"type_int_max\":2147483647,\"type_long_max\":9223372036854775807,\"type_float_min\":300.003,\"type_int_rand\":-5,\"name\":\"audit_entity_rubmo\",\"type_arr_list\":[\"1\",\"2\",\"3\",\"4\",\"5\"],\"type_bigint_min\":-9223372036854775808,\"type_int_min\":9000,\"type_float_max\":3.4E38,\"type_long_min\":-9223372036854775808,\"type_byte_min\":-128,\"type_long_rand\":-5},\"guid\":\"fa12e741-5e5f-45f8-bdd5-239b766e1d76\",\"isIncomplete\":false,\"provenanceType\":0,\"status\":\"ACTIVE\",\"createdBy\":\"hrt_qa\",\"updatedBy\":\"hrt_qa\",\"createTime\":1617262927193,\"updateTime\":1617262933323,\"version\":0,\"classifications\":[],\"customAttributes\":{\"nseqt\":\"test
 value 3\",\"rojut\":\"test value 1\",\"deyhx\":\"test value 
2\"},\"labels\":[\"label_cc\",\"label_3\",\"label_01\",\"label_b\",\"label_2\",\"label_a\",\"label_1\"],\"proxy\":false}",
"eventKey": 
"fa12e741-5e5f-45f8-bdd5-239b766e1d76:1617262937842:0:1617262937851",
"entity": null,
"type": null
},
{
"entityId": "fa12e741-5e5f-45f8-bdd5-239b766e1d76",
"timestamp": 1617262933323,
"user": "hrt_qa",
"action": "CLASSIFICATION_DELETE",
"details": "Deleted classification: tag_type_gnpfh",
"eventKey": 
"fa12e741-5e5f-45f8-bdd5-239b766e1d76:1617262933323:0:1617262933349",
"entity": null,
"type": null
},
{
"entityId": "fa12e741-5e5f-45f8-bdd5-239b766e1d76",
"timestamp": 1617262933183,
"user": "hrt_qa",
"action": "CLASSIFICATION_UPDATE",
"details": "Updated classification: 
{\"typeName\":\"tag_type_gnpfh\",\"attributes\":{\"name\":\"val1\",\"id\":1},\"entityGuid\":\"fa12e741-5e5f-45f8-bdd5-239b766e1d76\",\"entityStatus\":\"ACTIVE\",\"propagate\":true,\"removePropagationsOnEntityDelete\":false}",
"eventKey": 
"fa12e741-5e5f-45f8-bdd5-239b766e1d76:1617262933183:0:1617262933197",
"entity": null,
"type": null
},
{
"entityId": "fa12e741-5e5f-45f8-bdd5-239b766e1d76",
"timestamp": 1617262932983,
"user": "hrt_qa",
"action": "CLASSIFICATION_ADD",
"details": "Added classification: 
{\"typeName\":\"tag_type_gnpfh\",\"attributes\":{},\"entityGuid\":\"fa12e741-5e5f-45f8-bdd5-239b766e1d76\",\"entityStatus\":\"ACTIVE\",\"propagate\":true,\"removePropagationsOnEntityDelete\":false}",
"eventKey": 
"fa12e741-5e5f-45f8-bdd5-239b766e1d76:1617262932983:0:1617262932994",
"entity": null,
"type": null
},
{
"entityId": "fa12e741-5e5f-45f8-bdd5-239b766e1d76",
"timestamp": 1617262932036,
"user": "hrt_qa",
"action": "LABEL_DELETE",
"details": "Deleted labels: label_aa label_bb",
"eventKey": 
"fa12e741-5e5f-45f8-bdd5-239b766e1d76:1617262932036:0:1617262932046",
"entity": null,
"type": null
},
{
"entityId": "fa12e741-5e5f-45f8-bdd5-239b766e1d76",
"timestamp": 

Re: Review Request 73249: ATLAS-4221 : Solr collection names should be configurable

[Sarath Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73249/#review222765
---




intg/src/main/java/org/apache/atlas/AtlasConfiguration.java
Lines 78 (patched)


consider renaming the configurations to:

atlas.solr.vertex.index.collection.name = vertex_index
atlas.solr.edge.index.collection.name = edge_index
atlas.solr.fulltext.index.collection.name = fulltext_index


- Sarath Subramanian


On April 1, 2021, 3:52 a.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73249/
> ---
> 
> (Updated April 1, 2021, 3:52 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab and Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-4221
> https://issues.apache.org/jira/browse/ATLAS-4221
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Currently in Atlas, the collection names are not configurable
> 
> We need to provide functionality where in names of the solr collections can 
> be customized using property configuration
> 
> 
> Diffs
> -
> 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 771287f75 
>   distro/src/bin/atlas_config.py 80b3bfb78 
>   distro/src/bin/atlas_start.py 7cf35a92a 
>   distro/src/conf/atlas-application.properties e06e74a26 
>   intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 08d6c9d4a 
> 
> 
> Diff: https://reviews.apache.org/r/73249/diff/3/
> 
> 
> Testing
> ---
> 
> mvn clean install
> mvn clean package -Pdist,embedded-hbase-solr
> atlas server up and running
> Collections created with entities linked
> 
> 
> Thanks,
> 
> chaitali
> 
>

Re: Review Request 73249: ATLAS-4221 : Solr collection names should be configurable

[Sarath Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73249/#review222764
---



Atlas Repair Index Tool also needs to updated to handle configurable collection 
names. Please review.

- Sarath Subramanian


On April 1, 2021, 3:52 a.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73249/
> ---
> 
> (Updated April 1, 2021, 3:52 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab and Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-4221
> https://issues.apache.org/jira/browse/ATLAS-4221
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Currently in Atlas, the collection names are not configurable
> 
> We need to provide functionality where in names of the solr collections can 
> be customized using property configuration
> 
> 
> Diffs
> -
> 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 771287f75 
>   distro/src/bin/atlas_config.py 80b3bfb78 
>   distro/src/bin/atlas_start.py 7cf35a92a 
>   distro/src/conf/atlas-application.properties e06e74a26 
>   intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 08d6c9d4a 
> 
> 
> Diff: https://reviews.apache.org/r/73249/diff/3/
> 
> 
> Testing
> ---
> 
> mvn clean install
> mvn clean package -Pdist,embedded-hbase-solr
> atlas server up and running
> Collections created with entities linked
> 
> 
> Thanks,
> 
> chaitali
> 
>

[jira] [Updated] (ATLAS-4235) [Atlas: Audits] When business metadata attribute or user defined attribute of an entity is updated, action is appearing as "Entity updated" in v1 api response

[Dharshana M Krishnamoorthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dharshana M Krishnamoorthy updated ATLAS-4235:
--
Description: 
Case 1:

When business metadata attribute of an entity is updated, action is appearing 
as "Entity updated" in v1 api response
{code:java}
{u'action': u'ENTITY_UPDATE',
 u'details': u'Updated business attributes: 
{"typeName":"eibqk_bm","attributes":{"attrib_1":"111kezor","attrib_2":"222kezor"}}',
 u'entityId': u'29068c0c-8573-4cf2-bddc-ddefd4d38281',
 u'eventKey': 
u'29068c0c-8573-4cf2-bddc-ddefd4d38281:1617296650400:0:1617296650414',
 u'timestamp': 1617296650400,
 u'user': u'hrt_qa'} {code}
As seen in the response, the *details* displays the right data "*Updated 
business attributes*" but *action* displays "*ENTITY_UPDATE*"

Case 2:

When user-defined attribute  of an entity is updated, action is appearing as 
"Entity updated" in v1 api response
{code:java}
{u'action': u'ENTITY_UPDATE',
 u'details': u'Updated custom attribute: 
{"typeName":"entity_type_jmgur","guid":"a5770082-21b5-48ad-9540-0b2b7073359d","isIncomplete":false,"provenanceType":0,"version":0,"customAttributes":{"obtsv":"test
 value 2","mjfid":"test value 3","qlomc":"test value 1"},"proxy":false}',
 u'entityId': u'a5770082-21b5-48ad-9540-0b2b7073359d',
 u'eventKey': 
u'a5770082-21b5-48ad-9540-0b2b7073359d:1617297493442:0:1617297493450',
 u'timestamp': 1617297493442,
 u'user': u'hrt_qa'} {code}
As seen in the response, the *details* displays the right data "*Updated custom 
attribute*" but *action* displays "*ENTITY_UPDATE*"

*Minor:*

Also it will be better if

*"Updated custom attribute"* is updated as ** 

*"**Updated custom attributes"* **

Please not the 's' at the end to keep it consistent 

  was:
When business metadata attribute of an entity is updated, action is appearing 
as "Entity updated" in v1 api response
{code:java}
{u'action': u'ENTITY_UPDATE',
 u'details': u'Updated business attributes: 
{"typeName":"eibqk_bm","attributes":{"attrib_1":"111kezor","attrib_2":"222kezor"}}',
 u'entityId': u'29068c0c-8573-4cf2-bddc-ddefd4d38281',
 u'eventKey': 
u'29068c0c-8573-4cf2-bddc-ddefd4d38281:1617296650400:0:1617296650414',
 u'timestamp': 1617296650400,
 u'user': u'hrt_qa'} {code}
As seen in the response, the *details* displays the right data "*Updated 
business attributes*" but *action* displays "*ENTITY_UPDATE*"


> [Atlas: Audits] When business metadata attribute or user defined attribute of 
> an entity is updated, action is appearing as "Entity updated" in v1 api 
> response
> --
>
> Key: ATLAS-4235
> URL: https://issues.apache.org/jira/browse/ATLAS-4235
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Dharshana M Krishnamoorthy
>Priority: Major
>
> Case 1:
> When business metadata attribute of an entity is updated, action is appearing 
> as "Entity updated" in v1 api response
> {code:java}
> {u'action': u'ENTITY_UPDATE',
>  u'details': u'Updated business attributes: 
> {"typeName":"eibqk_bm","attributes":{"attrib_1":"111kezor","attrib_2":"222kezor"}}',
>  u'entityId': u'29068c0c-8573-4cf2-bddc-ddefd4d38281',
>  u'eventKey': 
> u'29068c0c-8573-4cf2-bddc-ddefd4d38281:1617296650400:0:1617296650414',
>  u'timestamp': 1617296650400,
>  u'user': u'hrt_qa'} {code}
> As seen in the response, the *details* displays the right data "*Updated 
> business attributes*" but *action* displays "*ENTITY_UPDATE*"
> Case 2:
> When user-defined attribute  of an entity is updated, action is appearing as 
> "Entity updated" in v1 api response
> {code:java}
> {u'action': u'ENTITY_UPDATE',
>  u'details': u'Updated custom attribute: 
> {"typeName":"entity_type_jmgur","guid":"a5770082-21b5-48ad-9540-0b2b7073359d","isIncomplete":false,"provenanceType":0,"version":0,"customAttributes":{"obtsv":"test
>  value 2","mjfid":"test value 3","qlomc":"test value 1"},"proxy":false}',
>  u'entityId': u'a5770082-21b5-48ad-9540-0b2b7073359d',
>  u'eventKey': 
> u'a5770082-21b5-48ad-9540-0b2b7073359d:1617297493442:0:1617297493450',
>  u'timestamp': 1617297493442,
>  u'user': u'hrt_qa'} {code}
> As seen in the response, the *details* displays the right data "*Updated 
> custom attribute*" but *action* displays "*ENTITY_UPDATE*"
> *Minor:*
> Also it will be better if
> *"Updated custom attribute"* is updated as ** 
> *"**Updated custom attributes"* **
> Please not the 's' at the end to keep it consistent 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4235) [Atlas: Audits] When business metadata attribute or user defined attribute of an entity is updated, action is appearing as "Entity updated" in v1 api response

[Dharshana M Krishnamoorthy (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dharshana M Krishnamoorthy updated ATLAS-4235:
--
Summary: [Atlas: Audits] When business metadata attribute or user defined 
attribute of an entity is updated, action is appearing as "Entity updated" in 
v1 api response  (was: [Atlas: Audits] When business metadata attribute of an 
entity is updated, action is appearing as "Entity updated" in v1 api response)

> [Atlas: Audits] When business metadata attribute or user defined attribute of 
> an entity is updated, action is appearing as "Entity updated" in v1 api 
> response
> --
>
> Key: ATLAS-4235
> URL: https://issues.apache.org/jira/browse/ATLAS-4235
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Dharshana M Krishnamoorthy
>Priority: Major
>
> When business metadata attribute of an entity is updated, action is appearing 
> as "Entity updated" in v1 api response
> {code:java}
> {u'action': u'ENTITY_UPDATE',
>  u'details': u'Updated business attributes: 
> {"typeName":"eibqk_bm","attributes":{"attrib_1":"111kezor","attrib_2":"222kezor"}}',
>  u'entityId': u'29068c0c-8573-4cf2-bddc-ddefd4d38281',
>  u'eventKey': 
> u'29068c0c-8573-4cf2-bddc-ddefd4d38281:1617296650400:0:1617296650414',
>  u'timestamp': 1617296650400,
>  u'user': u'hrt_qa'} {code}
> As seen in the response, the *details* displays the right data "*Updated 
> business attributes*" but *action* displays "*ENTITY_UPDATE*"



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (ATLAS-4235) [Atlas: Audits] When business metadata attribute of an entity is updated, action is appearing as "Entity updated" in v1 api response

[Dharshana M Krishnamoorthy (Jira)]

Dharshana M Krishnamoorthy created ATLAS-4235:
-

 Summary: [Atlas: Audits] When business metadata attribute of an 
entity is updated, action is appearing as "Entity updated" in v1 api response
 Key: ATLAS-4235
 URL: https://issues.apache.org/jira/browse/ATLAS-4235
 Project: Atlas
  Issue Type: Bug
  Components:  atlas-core
Reporter: Dharshana M Krishnamoorthy


When business metadata attribute of an entity is updated, action is appearing 
as "Entity updated" in v1 api response
{code:java}
{u'action': u'ENTITY_UPDATE',
 u'details': u'Updated business attributes: 
{"typeName":"eibqk_bm","attributes":{"attrib_1":"111kezor","attrib_2":"222kezor"}}',
 u'entityId': u'29068c0c-8573-4cf2-bddc-ddefd4d38281',
 u'eventKey': 
u'29068c0c-8573-4cf2-bddc-ddefd4d38281:1617296650400:0:1617296650414',
 u'timestamp': 1617296650400,
 u'user': u'hrt_qa'} {code}
As seen in the response, the *details* displays the right data "*Updated 
business attributes*" but *action* displays "*ENTITY_UPDATE*"



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (ATLAS-4234) [Atlas: Audits] When one of the attributes of a classification is updated, all the attributes are getting displayed in the latest audit

[Dharshana M Krishnamoorthy (Jira)]

Dharshana M Krishnamoorthy created ATLAS-4234:
-

 Summary: [Atlas: Audits] When one of the attributes of a 
classification is updated, all the attributes are getting displayed in the 
latest audit
 Key: ATLAS-4234
 URL: https://issues.apache.org/jira/browse/ATLAS-4234
 Project: Atlas
  Issue Type: Bug
  Components:  atlas-core
Reporter: Dharshana M Krishnamoorthy


Classification has 2 attributes: *name* and *id*

*Scenario:*

Setting both the values initially creates a *classification update* audit

Eg:
{code:java}
{'name': 'val1', 'id': 1}  {code}
audit for the same:
{code:java}
u'details': u'Updated classification: 
{"typeName":"tag_type_kgmxl","attributes":{"name":"val1","id":1},"entityGuid":"93160c69-30f4-4fdf-a99b-8228a61d5130","entityStatus":"ACTIVE","propagate":true,"removePropagationsOnEntityDelete":false}',
 {code}
Now update only one of the attributes
{code:java}
{'name': 'new_val'} {code}
We expect the latest audit should contain only the details of the updated 
attribute , but it has both. Please refer below
{code:java}
u'details': u'Updated classification: 
{"typeName":"tag_type_kgmxl","attributes":{"name":"new_val","id":1},"entityGuid":"93160c69-30f4-4fdf-a99b-8228a61d5130","entityStatus":"ACTIVE","propagate":true,"removePropagationsOnEntityDelete":false}'
 {code}
*Expectation:*
{code:java}
u'details': u'Updated classification: 
{"typeName":"tag_type_kgmxl","attributes":{"name":"new_val"},"entityGuid":"93160c69-30f4-4fdf-a99b-8228a61d5130","entityStatus":"ACTIVE","propagate":true,"removePropagationsOnEntityDelete":false}',
 {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (ATLAS-4233) [Atlas: Audits] When a term is added or removed, v1 api displays action as null instead of TERM_ADD or TERM_DELETE

[Dharshana M Krishnamoorthy (Jira)]

Dharshana M Krishnamoorthy created ATLAS-4233:
-

 Summary: [Atlas: Audits] When a term is added or removed, v1 api 
displays action as null instead of TERM_ADD or TERM_DELETE
 Key: ATLAS-4233
 URL: https://issues.apache.org/jira/browse/ATLAS-4233
 Project: Atlas
  Issue Type: Bug
  Components:  atlas-core
Reporter: Dharshana M Krishnamoorthy
 Attachments: Screenshot 2021-04-01 at 7.58.12 PM.png, Screenshot 
2021-04-01 at 8.04.11 PM.png

*Scenario:*
 * Add a term to an entity.
 * Remove the term from the entity

Audits will be generated. Here the action should appear as *TERM_ADD or 
TERM_DELETE*

But the value is null instead. Please check the reference below
{code:java}
{
"entityId": "d83d7d10-c137-4a16-8018-70692cd555b2",
"timestamp": 1617286735612,
"user": "hrt_qa",
"action": null,
"details": "Added term: 
{\"guid\":\"700bafef-ac2b-489b-a54b-0dc5741e2a6f\",\"qualifiedName\":\"hdcpg_term@hdcpg_glossary\",\"name\":\"hdcpg_term\"}",
"eventKey": 
"d83d7d10-c137-4a16-8018-70692cd555b2:1617286735612:0:1617286735676"
} {code}
*v1: https://:31443/api/atlas/entities//audit*

*TERM_ADD*

!Screenshot 2021-04-01 at 7.58.12 PM.png|width=584,height=179!

*TERM_DELETE*

!Screenshot 2021-04-01 at 8.04.11 PM.png|width=581,height=174!

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4168) Overlapping "Switch to Beta UI" link on pagination

[Prasad P. Pawar (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prasad P. Pawar updated ATLAS-4168:
---
Attachment: 0001-ATLAS-4168-v1-Overlapping-Switch-to-Beta-UI-link-on-.patch

> Overlapping "Switch to Beta UI" link on pagination
> --
>
> Key: ATLAS-4168
> URL: https://issues.apache.org/jira/browse/ATLAS-4168
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Reporter: Durga Kadam
>Assignee: Prasad P. Pawar
>Priority: Minor
>  Labels: Atlas-UI
> Attachments: 
> 0001-ATLAS-4168-Overlapping-Switch-to-Beta-UI-link-on-pag.patch, 
> 0001-ATLAS-4168-v1-Overlapping-Switch-to-Beta-UI-link-on-.patch, 
> 4168_1fix.png, 4168_2Fixed.png, screenshot-newtab-2021.02.18-18_42_14.png
>
>
> “Switch to Beta UI” link at the bottom right of the page overlaps pagination 
> links in search results page .
> PFA



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [atlas] martin-g commented on pull request #128: ATLAS-4159 Update dependencies to fix the build on arm64

[GitBox]

martin-g commented on pull request #128:
URL: https://github.com/apache/atlas/pull/128#issuecomment-811836227


   Any feedback on the changes ?
   The failing test also fails on master branch - 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/479/console.
 Last success is 23 days ago.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: Review Request 73249: ATLAS-4221 : Solr collection names should be configurable

[chaitali]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73249/
---

(Updated April 1, 2021, 10:52 a.m.)


Review request for atlas, Jayendra Parab and Nixon Rodrigues.


Bugs: ATLAS-4221
https://issues.apache.org/jira/browse/ATLAS-4221


Repository: atlas


Description
---

Currently in Atlas, the collection names are not configurable

We need to provide functionality where in names of the solr collections can be 
customized using property configuration


Diffs
-

  common/src/main/java/org/apache/atlas/repository/Constants.java 771287f75 
  distro/src/bin/atlas_config.py 80b3bfb78 
  distro/src/bin/atlas_start.py 7cf35a92a 
  distro/src/conf/atlas-application.properties e06e74a26 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 08d6c9d4a 


Diff: https://reviews.apache.org/r/73249/diff/3/


Testing (updated)
---

mvn clean install
mvn clean package -Pdist,embedded-hbase-solr
atlas server up and running
Collections created with entities linked


Thanks,

chaitali

Re: Review Request 73249: ATLAS-4221 : Solr collection names should be configurable

[chaitali]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73249/
---

(Updated April 1, 2021, 10:51 a.m.)


Review request for atlas, Jayendra Parab and Nixon Rodrigues.


Bugs: ATLAS-4221
https://issues.apache.org/jira/browse/ATLAS-4221


Repository: atlas


Description
---

Currently in Atlas, the collection names are not configurable

We need to provide functionality where in names of the solr collections can be 
customized using property configuration


Diffs (updated)
-

  common/src/main/java/org/apache/atlas/repository/Constants.java 771287f75 
  distro/src/bin/atlas_config.py 80b3bfb78 
  distro/src/bin/atlas_start.py 7cf35a92a 
  distro/src/conf/atlas-application.properties e06e74a26 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 08d6c9d4a 


Diff: https://reviews.apache.org/r/73249/diff/3/

Changes: https://reviews.apache.org/r/73249/diff/2-3/


Testing
---

mvn clean install
atlas server up and running
Collections created with entities linked


Thanks,

chaitali

[jira] [Commented] (ATLAS-2734) Please delete old releases from mirroring system

[Sebb (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313066#comment-17313066
 ] 

Sebb commented on ATLAS-2734:
-

Please now delete
https://dist.apache.org/repos/dist/release/atlas/2.0.0/

The links on the download page already point to the archive server.

> Please delete old releases from mirroring system
> 
>
> Key: ATLAS-2734
> URL: https://issues.apache.org/jira/browse/ATLAS-2734
> Project: Atlas
>  Issue Type: Bug
> Environment: https://dist.apache.org/repos/dist/release/atlas/
>Reporter: Sebb
>Assignee: Madhan Neethiraj
>Priority: Major
> Fix For: 1.0.0
>
>
> To reduce the load on the ASF mirrors, projects are required to delete old 
> releases [1]
> Please can you remove all non-current releases from the mirrors?
> It looks like 0.8.2 and 0.8.1 are no longer current.
> It's unfair to expect the 3rd party mirrors to carry old releases.
> Thanks!
> [1] http://www.apache.org/dev/release.html#when-to-archive



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4201) UI: Add attributes modal api hits when no attributes are added on Classification detail page.

[Prasad P. Pawar (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prasad P. Pawar updated ATLAS-4201:
---
Affects Version/s: 2.1.0

> UI: Add attributes modal api hits when no attributes are added on 
> Classification detail page.
> -
>
> Key: ATLAS-4201
> URL: https://issues.apache.org/jira/browse/ATLAS-4201
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Affects Versions: 2.1.0
>Reporter: Prasad P. Pawar
>Assignee: Prasad P. Pawar
>Priority: Minor
>  Labels: attributes, classification
> Attachments: 
> 0001-ATLAS-4201-UI-Add-attributes-modal-api-hits-when-no-.patch, 
> AddAttributesField.png, AddButtonEnabled.png, Api_SuccessMessage.png
>
>
> Steps:
> 1) Add attributes by clicking on the attribute + button on the classification 
> detail page.
> Add Attribute modal opens with default 1 attribute field, "Add" button of the 
> modal is disabled.
> 2) Click on the "Add New Attributes" button.
>  Additional attribute field is added, with remove attribute field buttons.
> 3) Remove all the attributes fields by clicking on the remove buttons.
> 4) Add button gets enable (should be disabled), refer to the attached image.
> 5) Click on Add button, API is hit, an Attribute added success message is 
> shown, refer to the attached image.
> Expectation:
> Show Validation message on "Add" Button click of the modal: "No attribute is 
> added" or Disable the "Add" Button of modal or At least keep one Attribute 
> field in the modal.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4214) UI: expand/collapse Technical properies of entity audits' tab not working properly

[Prasad P. Pawar (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prasad P. Pawar updated ATLAS-4214:
---
Fix Version/s: (was: 2.0.0)
   2.2.0

> UI: expand/collapse Technical properies of entity audits' tab not working 
> properly
> --
>
> Key: ATLAS-4214
> URL: https://issues.apache.org/jira/browse/ATLAS-4214
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Affects Versions: 2.1.0
>Reporter: Nikhil Bonte
>Assignee: Prasad P. Pawar
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: 
> 0001-ATLAS-4214-UI-expand-collapse-Technical-properies-of.patch
>
>
> An entity that has at least 2 audit entries has the following issues with 
> expanding/collapsing Technical properties-
> Expand both audit entries, Technical properties are expanded by default,
>  # Clicking on 1st audit record's Technical properties will collapse 
> it(expected) along with changing the icon for 2nd audit record's Technical 
> properties (it will be still in an expanded state but icon gives feel that it 
> is collapsed) 
>  # Clicking on the 2nd audit record's Technical properties will 
> expand/collapse the 1st audit record's Technical properties while it itself 
> remains expanded.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4214) UI: expand/collapse Technical properies of entity audits' tab not working properly

[Prasad P. Pawar (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prasad P. Pawar updated ATLAS-4214:
---
Affects Version/s: 2.1.0

> UI: expand/collapse Technical properies of entity audits' tab not working 
> properly
> --
>
> Key: ATLAS-4214
> URL: https://issues.apache.org/jira/browse/ATLAS-4214
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Affects Versions: 2.1.0
>Reporter: Nikhil Bonte
>Assignee: Prasad P. Pawar
>Priority: Major
> Attachments: 
> 0001-ATLAS-4214-UI-expand-collapse-Technical-properies-of.patch
>
>
> An entity that has at least 2 audit entries has the following issues with 
> expanding/collapsing Technical properties-
> Expand both audit entries, Technical properties are expanded by default,
>  # Clicking on 1st audit record's Technical properties will collapse 
> it(expected) along with changing the icon for 2nd audit record's Technical 
> properties (it will be still in an expanded state but icon gives feel that it 
> is collapsed) 
>  # Clicking on the 2nd audit record's Technical properties will 
> expand/collapse the 1st audit record's Technical properties while it itself 
> remains expanded.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4214) UI: expand/collapse Technical properies of entity audits' tab not working properly

[Prasad P. Pawar (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prasad P. Pawar updated ATLAS-4214:
---
Fix Version/s: 2.0.0
   3.0.0

> UI: expand/collapse Technical properies of entity audits' tab not working 
> properly
> --
>
> Key: ATLAS-4214
> URL: https://issues.apache.org/jira/browse/ATLAS-4214
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Affects Versions: 2.1.0
>Reporter: Nikhil Bonte
>Assignee: Prasad P. Pawar
>Priority: Major
> Fix For: 2.0.0, 3.0.0
>
> Attachments: 
> 0001-ATLAS-4214-UI-expand-collapse-Technical-properies-of.patch
>
>
> An entity that has at least 2 audit entries has the following issues with 
> expanding/collapsing Technical properties-
> Expand both audit entries, Technical properties are expanded by default,
>  # Clicking on 1st audit record's Technical properties will collapse 
> it(expected) along with changing the icon for 2nd audit record's Technical 
> properties (it will be still in an expanded state but icon gives feel that it 
> is collapsed) 
>  # Clicking on the 2nd audit record's Technical properties will 
> expand/collapse the 1st audit record's Technical properties while it itself 
> remains expanded.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4224) UI : Redirect Atlas UI to login/index page when session is expired in backend.

[Prasad P. Pawar (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prasad P. Pawar updated ATLAS-4224:
---
Affects Version/s: 2.1.0

> UI : Redirect Atlas UI to login/index page when session is expired in backend.
> --
>
> Key: ATLAS-4224
> URL: https://issues.apache.org/jira/browse/ATLAS-4224
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 2.1.0
>Reporter: Nixon Rodrigues
>Assignee: Prasad P. Pawar
>Priority: Major
> Attachments: 
> 0001-ATLAS-4224-UI-Redirect-Atlas-UI-to-login-index-page-.patch
>
>
> Redirect Atlas UI to login/index page when session is expired in backend when 
> cookie is expired or deleted instead of showing notification in Atlas.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4224) UI : Redirect Atlas UI to login/index page when session is expired in backend.

[Prasad P. Pawar (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prasad P. Pawar updated ATLAS-4224:
---
Fix Version/s: 2.2.0

> UI : Redirect Atlas UI to login/index page when session is expired in backend.
> --
>
> Key: ATLAS-4224
> URL: https://issues.apache.org/jira/browse/ATLAS-4224
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 2.1.0
>Reporter: Nixon Rodrigues
>Assignee: Prasad P. Pawar
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: 
> 0001-ATLAS-4224-UI-Redirect-Atlas-UI-to-login-index-page-.patch
>
>
> Redirect Atlas UI to login/index page when session is expired in backend when 
> cookie is expired or deleted instead of showing notification in Atlas.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4224) UI : Redirect Atlas UI to login/index page when session is expired in backend.

[Prasad P. Pawar (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prasad P. Pawar updated ATLAS-4224:
---
Fix Version/s: 3.0.0

> UI : Redirect Atlas UI to login/index page when session is expired in backend.
> --
>
> Key: ATLAS-4224
> URL: https://issues.apache.org/jira/browse/ATLAS-4224
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 2.1.0
>Reporter: Nixon Rodrigues
>Assignee: Prasad P. Pawar
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: 
> 0001-ATLAS-4224-UI-Redirect-Atlas-UI-to-login-index-page-.patch
>
>
> Redirect Atlas UI to login/index page when session is expired in backend when 
> cookie is expired or deleted instead of showing notification in Atlas.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 73249: ATLAS-4221 : Solr collection names should be configurable

[Jayendra Parab]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73249/#review222759
---




distro/src/bin/atlas_config.py
Lines 741 (patched)


Remove this print msg...



distro/src/bin/atlas_start.py
Lines 29 (patched)


We should have these constants in atlas_config.py and should be names as 
VERTEX_INDEX_NAME_CONF
The method which gets the name, should make use of these constants from 
there



distro/src/conf/atlas-application.properties
Lines 83 (patched)


Kee the default index names as vertex_index, edge_index, fulltext_index


- Jayendra Parab


On March 30, 2021, 10:41 a.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73249/
> ---
> 
> (Updated March 30, 2021, 10:41 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab and Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-4221
> https://issues.apache.org/jira/browse/ATLAS-4221
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Currently in Atlas, the collection names are not configurable
> 
> We need to provide functionality where in names of the solr collections can 
> be customized using property configuration
> 
> 
> Diffs
> -
> 
>   common/src/main/java/org/apache/atlas/repository/Constants.java 771287f75 
>   distro/src/bin/atlas_config.py 80b3bfb78 
>   distro/src/bin/atlas_start.py 7cf35a92a 
>   distro/src/conf/atlas-application.properties e06e74a26 
>   intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 08d6c9d4a 
> 
> 
> Diff: https://reviews.apache.org/r/73249/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean install
> atlas server up and running
> Collections created with entities linked
> 
> 
> Thanks,
> 
> chaitali
> 
>