Re: Review Request 73376: ATLAS-4307: Atlas bulk clarification REST should be enhanced to associate classification to bulk entities with uniq attribute and type

2021-05-25 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73376/#review223047
---




intg/src/main/java/org/apache/atlas/model/instance/ClassificationAssociateRequest.java
Lines 47 (patched)


entitiesUniqAttributes => entitiesUniqueAttributes



webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java
Lines 813 (patched)


entitiesAttributes => entitiesUniqueAttributes



webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java
Line 814 (original), 828 (patched)


why need of linkedlist here and not array list?



webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java
Lines 856 (patched)


this empty/null check may not be needed, we check this in 
entitiesStore.addClassification() method. review and remove.


- Sarath Subramanian


On May 25, 2021, 5:19 p.m., Sidharth Mishra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73376/
> ---
> 
> (Updated May 25, 2021, 5:19 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4307
> https://issues.apache.org/jira/browse/ATLAS-4307
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-4307: Atlas bulk clarification REST should be enhanced to associate 
> classification to bulk entities with uniq attribute and type
> 
> 
> Diffs
> -
> 
>   
> intg/src/main/java/org/apache/atlas/model/instance/ClassificationAssociateRequest.java
>  3f946ef7a 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java ec893f25c 
> 
> 
> Diff: https://reviews.apache.org/r/73376/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested. With new changes the three options will be:
> 
> Option 1 (Only with type name and list of uniq attributes)
> 
> curl --location --request POST 
> 'http://atlas-host:31000/api/atlas/v2/entity/bulk/classification?skipFailedEntities=True'
>  \
> --header 'Authorization: Basic YWRtaW46YWRtaW4xMjM=' \
> --header 'Content-Type: application/json' \
> --data-raw '{
>   "classification" : {
> "propagate" : false,
> "attributes" : {
>   "type" : "false"
> },
> "typeName" : "TEST_TAG_TABLE"
>   },
>   "entitiesUniqAttributes" : [
>   {"qualifiedName": "db1.table43@cm"},
>   {"qualifiedName": "db1.table7@cm"},
>   {"qualifiedName": "db1.table55@cm"}],
>   "entityTypeName" : "hive_table"
> }'
> 
> Option 2 (Only with entity Guids)
> curl --location --request POST 
> 'http://atlas-host:31000/api/atlas/v2/entity/bulk/classification?skipFailedEntities=True'
>  \
> --header 'Authorization: Basic YWRtaW46YWRtaW4xMjM=' \
> --header 'Content-Type: application/json' \
> --data-raw '{
>   "classification" : {
> "propagate" : false,
> "attributes" : {
>   "type" : "false"
> },
> "typeName" : "TEST_TAG_TABLE"
>   },
>   "entityGuids" : ["f7288e81-46e4-4c88-b6c7-da092d6b6e35", 
> "1793c6df-53a6-481b-a75c-c705f98d6900"],
>   "entityTypeName" : "hive_table"
> }'
> 
> Option 3 (With both entity GUIDs and type Name with list of uniq attributes)
> curl --location --request POST 
> 'http://atlas-host:31000/api/atlas/v2/entity/bulk/classification?skipFailedEntities=True'
>  \
> --header 'Authorization: Basic YWRtaW46YWRtaW4xMjM=' \
> --header 'Content-Type: application/json' \
> --data-raw '{
>   "classification" : {
> "propagate" : false,
> "attributes" : {
>   "type" : "false"
> },
> "typeName" : "TEST_TAG_TABLE"
>   },
>   "entitiesUniqAttributes" : [
>   {"qualifiedName": "db1.table43@cm"},
>   {"qualifiedName": "db1.table8@cm"},
>   {"qualifiedName": "db1.table55@cm"}],
>   "entityGuids" : [
>   "6d6ab082-9a62-4aea-97b7-2b7337173631",
>   "9a0d3275-eb42-4229-ac51-6db1ddf3ccc6"],
>   "entityTypeName" : "hive_table"
> }'
> 
> 
> Thanks,
> 
> Sidharth Mishra
> 
>

[jira] [Updated] (ATLAS-4308) ATLAS UI Audit sorting : When consecutive Entity Audits are fired, sorting happens on the previous sorted results received from the server

2021-05-25 Thread Prasad P. Pawar (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prasad P. Pawar updated ATLAS-4308:
---
Component/s: atlas-webui

> ATLAS UI Audit sorting : When consecutive Entity Audits are fired, sorting 
> happens on the previous sorted results received from the server
> --
>
> Key: ATLAS-4308
> URL: https://issues.apache.org/jira/browse/ATLAS-4308
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Reporter: Prasad P. Pawar
>Assignee: Prasad P. Pawar
>Priority: Major
>  Labels: Atlas-UI, audits
>
> Attaching 2 screenshots where following was done
>  
> 1)sort by action + sort by user (sort by action is done and on top of that 
> result , sort by user is done)
> 2)sort by user (only sort by user is done)
>  
> The results are different on UI. 
>  
> The query for  :
> 1) is 
> a) 
> /api/atlas/v2/entity/0efb15b7-d4cc-4bcc-87d1-bee41d1baae5/audit?sortOrder=asc&offset=0&count=25&sortBy=action
>  
> b) 
> /api/atlas/v2/entity/0efb15b7-d4cc-4bcc-87d1-bee41d1baae5/audit?sortOrder=asc&offset=0&count=25&sortBy=user
>  
> 2) is 
> a) 
> /api/atlas/v2/entity/0efb15b7-d4cc-4bcc-87d1-bee41d1baae5/audit?sortOrder=asc&offset=0&count=25&sortBy=user
>  
> 1.b happens on the result of 1.a which is not expected.
>  
> 1.b should be equal to 2.a



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4308) ATLAS UI Audit sorting : When consecutive Entity Audits are fired, sorting happens on the previous sorted results received from the server

2021-05-25 Thread Prasad P. Pawar (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prasad P. Pawar updated ATLAS-4308:
---
Labels: Atlas-UI audits  (was: audits)

> ATLAS UI Audit sorting : When consecutive Entity Audits are fired, sorting 
> happens on the previous sorted results received from the server
> --
>
> Key: ATLAS-4308
> URL: https://issues.apache.org/jira/browse/ATLAS-4308
> Project: Atlas
>  Issue Type: Bug
>Reporter: Prasad P. Pawar
>Assignee: Prasad P. Pawar
>Priority: Major
>  Labels: Atlas-UI, audits
>
> Attaching 2 screenshots where following was done
>  
> 1)sort by action + sort by user (sort by action is done and on top of that 
> result , sort by user is done)
> 2)sort by user (only sort by user is done)
>  
> The results are different on UI. 
>  
> The query for  :
> 1) is 
> a) 
> /api/atlas/v2/entity/0efb15b7-d4cc-4bcc-87d1-bee41d1baae5/audit?sortOrder=asc&offset=0&count=25&sortBy=action
>  
> b) 
> /api/atlas/v2/entity/0efb15b7-d4cc-4bcc-87d1-bee41d1baae5/audit?sortOrder=asc&offset=0&count=25&sortBy=user
>  
> 2) is 
> a) 
> /api/atlas/v2/entity/0efb15b7-d4cc-4bcc-87d1-bee41d1baae5/audit?sortOrder=asc&offset=0&count=25&sortBy=user
>  
> 1.b happens on the result of 1.a which is not expected.
>  
> 1.b should be equal to 2.a



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (ATLAS-4308) ATLAS UI Audit sorting : When consecutive Entity Audits are fired, sorting happens on the previous sorted results received from the server

2021-05-25 Thread Prasad P. Pawar (Jira) 
Prasad P. Pawar created ATLAS-4308:
--

 Summary: ATLAS UI Audit sorting : When consecutive Entity Audits 
are fired, sorting happens on the previous sorted results received from the 
server
 Key: ATLAS-4308
 URL: https://issues.apache.org/jira/browse/ATLAS-4308
 Project: Atlas
  Issue Type: Bug
Reporter: Prasad P. Pawar
Assignee: Prasad P. Pawar


Attaching 2 screenshots where following was done
 
1)sort by action + sort by user (sort by action is done and on top of that 
result , sort by user is done)
2)sort by user (only sort by user is done)
 
The results are different on UI. 
 
The query for  :
1) is 
a) 
/api/atlas/v2/entity/0efb15b7-d4cc-4bcc-87d1-bee41d1baae5/audit?sortOrder=asc&offset=0&count=25&sortBy=action
 
b) 
/api/atlas/v2/entity/0efb15b7-d4cc-4bcc-87d1-bee41d1baae5/audit?sortOrder=asc&offset=0&count=25&sortBy=user
 
2) is 
a) 
/api/atlas/v2/entity/0efb15b7-d4cc-4bcc-87d1-bee41d1baae5/audit?sortOrder=asc&offset=0&count=25&sortBy=user
 
1.b happens on the result of 1.a which is not expected.
 
1.b should be equal to 2.a



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 73376: ATLAS-4307: Atlas bulk clarification REST should be enhanced to associate classification to bulk entities with uniq attribute and type

2021-05-25 Thread Ashutosh Mestry via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73376/#review223044
---




intg/src/main/java/org/apache/atlas/model/instance/ClassificationAssociateRequest.java
Lines 47 (patched)


Rename: entitiesUniqAttributes -> entityUniqAttributes


- Ashutosh Mestry


On May 26, 2021, 12:19 a.m., Sidharth Mishra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73376/
> ---
> 
> (Updated May 26, 2021, 12:19 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4307
> https://issues.apache.org/jira/browse/ATLAS-4307
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-4307: Atlas bulk clarification REST should be enhanced to associate 
> classification to bulk entities with uniq attribute and type
> 
> 
> Diffs
> -
> 
>   
> intg/src/main/java/org/apache/atlas/model/instance/ClassificationAssociateRequest.java
>  3f946ef7a 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java ec893f25c 
> 
> 
> Diff: https://reviews.apache.org/r/73376/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested. With new changes the three options will be:
> 
> Option 1 (Only with type name and list of uniq attributes)
> 
> curl --location --request POST 
> 'http://atlas-host:31000/api/atlas/v2/entity/bulk/classification?skipFailedEntities=True'
>  \
> --header 'Authorization: Basic YWRtaW46YWRtaW4xMjM=' \
> --header 'Content-Type: application/json' \
> --data-raw '{
>   "classification" : {
> "propagate" : false,
> "attributes" : {
>   "type" : "false"
> },
> "typeName" : "TEST_TAG_TABLE"
>   },
>   "entitiesUniqAttributes" : [
>   {"qualifiedName": "db1.table43@cm"},
>   {"qualifiedName": "db1.table7@cm"},
>   {"qualifiedName": "db1.table55@cm"}],
>   "entityTypeName" : "hive_table"
> }'
> 
> Option 2 (Only with entity Guids)
> curl --location --request POST 
> 'http://atlas-host:31000/api/atlas/v2/entity/bulk/classification?skipFailedEntities=True'
>  \
> --header 'Authorization: Basic YWRtaW46YWRtaW4xMjM=' \
> --header 'Content-Type: application/json' \
> --data-raw '{
>   "classification" : {
> "propagate" : false,
> "attributes" : {
>   "type" : "false"
> },
> "typeName" : "TEST_TAG_TABLE"
>   },
>   "entityGuids" : ["f7288e81-46e4-4c88-b6c7-da092d6b6e35", 
> "1793c6df-53a6-481b-a75c-c705f98d6900"],
>   "entityTypeName" : "hive_table"
> }'
> 
> Option 3 (With both entity GUIDs and type Name with list of uniq attributes)
> curl --location --request POST 
> 'http://atlas-host:31000/api/atlas/v2/entity/bulk/classification?skipFailedEntities=True'
>  \
> --header 'Authorization: Basic YWRtaW46YWRtaW4xMjM=' \
> --header 'Content-Type: application/json' \
> --data-raw '{
>   "classification" : {
> "propagate" : false,
> "attributes" : {
>   "type" : "false"
> },
> "typeName" : "TEST_TAG_TABLE"
>   },
>   "entitiesUniqAttributes" : [
>   {"qualifiedName": "db1.table43@cm"},
>   {"qualifiedName": "db1.table8@cm"},
>   {"qualifiedName": "db1.table55@cm"}],
>   "entityGuids" : [
>   "6d6ab082-9a62-4aea-97b7-2b7337173631",
>   "9a0d3275-eb42-4229-ac51-6db1ddf3ccc6"],
>   "entityTypeName" : "hive_table"
> }'
> 
> 
> Thanks,
> 
> Sidharth Mishra
> 
>

Re: Review Request 73376: ATLAS-4307: Atlas bulk clarification REST should be enhanced to associate classification to bulk entities with uniq attribute and type

2021-05-25 Thread Ashutosh Mestry via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73376/#review223043
---




webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java
Lines 820 (patched)


Refactor: Extract to method.


- Ashutosh Mestry


On May 26, 2021, 12:19 a.m., Sidharth Mishra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73376/
> ---
> 
> (Updated May 26, 2021, 12:19 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4307
> https://issues.apache.org/jira/browse/ATLAS-4307
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-4307: Atlas bulk clarification REST should be enhanced to associate 
> classification to bulk entities with uniq attribute and type
> 
> 
> Diffs
> -
> 
>   
> intg/src/main/java/org/apache/atlas/model/instance/ClassificationAssociateRequest.java
>  3f946ef7a 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java ec893f25c 
> 
> 
> Diff: https://reviews.apache.org/r/73376/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested. With new changes the three options will be:
> 
> Option 1 (Only with type name and list of uniq attributes)
> 
> curl --location --request POST 
> 'http://atlas-host:31000/api/atlas/v2/entity/bulk/classification?skipFailedEntities=True'
>  \
> --header 'Authorization: Basic YWRtaW46YWRtaW4xMjM=' \
> --header 'Content-Type: application/json' \
> --data-raw '{
>   "classification" : {
> "propagate" : false,
> "attributes" : {
>   "type" : "false"
> },
> "typeName" : "TEST_TAG_TABLE"
>   },
>   "entitiesUniqAttributes" : [
>   {"qualifiedName": "db1.table43@cm"},
>   {"qualifiedName": "db1.table7@cm"},
>   {"qualifiedName": "db1.table55@cm"}],
>   "entityTypeName" : "hive_table"
> }'
> 
> Option 2 (Only with entity Guids)
> curl --location --request POST 
> 'http://atlas-host:31000/api/atlas/v2/entity/bulk/classification?skipFailedEntities=True'
>  \
> --header 'Authorization: Basic YWRtaW46YWRtaW4xMjM=' \
> --header 'Content-Type: application/json' \
> --data-raw '{
>   "classification" : {
> "propagate" : false,
> "attributes" : {
>   "type" : "false"
> },
> "typeName" : "TEST_TAG_TABLE"
>   },
>   "entityGuids" : ["f7288e81-46e4-4c88-b6c7-da092d6b6e35", 
> "1793c6df-53a6-481b-a75c-c705f98d6900"],
>   "entityTypeName" : "hive_table"
> }'
> 
> Option 3 (With both entity GUIDs and type Name with list of uniq attributes)
> curl --location --request POST 
> 'http://atlas-host:31000/api/atlas/v2/entity/bulk/classification?skipFailedEntities=True'
>  \
> --header 'Authorization: Basic YWRtaW46YWRtaW4xMjM=' \
> --header 'Content-Type: application/json' \
> --data-raw '{
>   "classification" : {
> "propagate" : false,
> "attributes" : {
>   "type" : "false"
> },
> "typeName" : "TEST_TAG_TABLE"
>   },
>   "entitiesUniqAttributes" : [
>   {"qualifiedName": "db1.table43@cm"},
>   {"qualifiedName": "db1.table8@cm"},
>   {"qualifiedName": "db1.table55@cm"}],
>   "entityGuids" : [
>   "6d6ab082-9a62-4aea-97b7-2b7337173631",
>   "9a0d3275-eb42-4229-ac51-6db1ddf3ccc6"],
>   "entityTypeName" : "hive_table"
> }'
> 
> 
> Thanks,
> 
> Sidharth Mishra
> 
>

Review Request 73376: ATLAS-4307: Atlas bulk clarification REST should be enhanced to associate classification to bulk entities with uniq attribute and type

2021-05-25 Thread Sidharth Mishra 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73376/
---

Review request for atlas, Ashutosh Mestry, Deep Singh, Radhika Kundam, and 
Sarath Subramanian.


Bugs: ATLAS-4307
https://issues.apache.org/jira/browse/ATLAS-4307


Repository: atlas


Description
---

ATLAS-4307: Atlas bulk clarification REST should be enhanced to associate 
classification to bulk entities with uniq attribute and type


Diffs
-

  
intg/src/main/java/org/apache/atlas/model/instance/ClassificationAssociateRequest.java
 3f946ef7a 
  webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java ec893f25c 


Diff: https://reviews.apache.org/r/73376/diff/1/


Testing
---

Manually tested. With new changes the three options will be:

Option 1 (Only with type name and list of uniq attributes)

curl --location --request POST 
'http://atlas-host:31000/api/atlas/v2/entity/bulk/classification?skipFailedEntities=True'
 \
--header 'Authorization: Basic YWRtaW46YWRtaW4xMjM=' \
--header 'Content-Type: application/json' \
--data-raw '{
  "classification" : {
"propagate" : false,
"attributes" : {
  "type" : "false"
},
"typeName" : "TEST_TAG_TABLE"
  },
  "entitiesUniqAttributes" : [
  {"qualifiedName": "db1.table43@cm"},
  {"qualifiedName": "db1.table7@cm"},
  {"qualifiedName": "db1.table55@cm"}],
  "entityTypeName" : "hive_table"
}'

Option 2 (Only with entity Guids)
curl --location --request POST 
'http://atlas-host:31000/api/atlas/v2/entity/bulk/classification?skipFailedEntities=True'
 \
--header 'Authorization: Basic YWRtaW46YWRtaW4xMjM=' \
--header 'Content-Type: application/json' \
--data-raw '{
  "classification" : {
"propagate" : false,
"attributes" : {
  "type" : "false"
},
"typeName" : "TEST_TAG_TABLE"
  },
  "entityGuids" : ["f7288e81-46e4-4c88-b6c7-da092d6b6e35", 
"1793c6df-53a6-481b-a75c-c705f98d6900"],
  "entityTypeName" : "hive_table"
}'

Option 3 (With both entity GUIDs and type Name with list of uniq attributes)
curl --location --request POST 
'http://atlas-host:31000/api/atlas/v2/entity/bulk/classification?skipFailedEntities=True'
 \
--header 'Authorization: Basic YWRtaW46YWRtaW4xMjM=' \
--header 'Content-Type: application/json' \
--data-raw '{
  "classification" : {
"propagate" : false,
"attributes" : {
  "type" : "false"
},
"typeName" : "TEST_TAG_TABLE"
  },
  "entitiesUniqAttributes" : [
  {"qualifiedName": "db1.table43@cm"},
  {"qualifiedName": "db1.table8@cm"},
  {"qualifiedName": "db1.table55@cm"}],
  "entityGuids" : [
  "6d6ab082-9a62-4aea-97b7-2b7337173631",
  "9a0d3275-eb42-4229-ac51-6db1ddf3ccc6"],
  "entityTypeName" : "hive_table"
}'


Thanks,

Sidharth Mishra

[jira] [Commented] (ATLAS-4307) Atlas bulk clarification REST should be enhanced to associate classification to bulk entities with uniq attribute and type

2021-05-25 Thread Sidharth Kumar Mishra (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-4307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351410#comment-17351410
 ] 

Sidharth Kumar Mishra commented on ATLAS-4307:
--

With the change below three options will work -

Option 1 (Only with type name and list of uniq attributes)

curl --location --request POST 
'http://atlas-host:31000/api/atlas/v2/entity/bulk/classification?skipFailedEntities=True'
 \
--header 'Authorization: Basic YWRtaW46YWRtaW4xMjM=' \
--header 'Content-Type: application/json' \
--data-raw '{
 "classification" : {
 "propagate" : false,
 "attributes" : {
 "type" : "false"
 },
 "typeName" : "TEST_TAG_TABLE"
 },
 "entitiesUniqAttributes" : [
 \{"qualifiedName": "db1.table43@cm"},
 \{"qualifiedName": "db1.table7@cm"},
 \{"qualifiedName": "db1.table55@cm"}],
 "entityTypeName" : "hive_table"
}'

Option 2 (Only with entity Guids)
curl --location --request POST 
'http://atlas-host:31000/api/atlas/v2/entity/bulk/classification?skipFailedEntities=True'
 \
--header 'Authorization: Basic YWRtaW46YWRtaW4xMjM=' \
--header 'Content-Type: application/json' \
--data-raw '{
 "classification" : {
 "propagate" : false,
 "attributes" : {
 "type" : "false"
 },
 "typeName" : "TEST_TAG_TABLE"
 },
 "entityGuids" : ["f7288e81-46e4-4c88-b6c7-da092d6b6e35", 
"1793c6df-53a6-481b-a75c-c705f98d6900"],
 "entityTypeName" : "hive_table"
}'

Option 3 (With both entity GUIDs and type Name with list of uniq attributes)
curl --location --request POST 
'http://atlas-host:31000/api/atlas/v2/entity/bulk/classification?skipFailedEntities=True'
 \
--header 'Authorization: Basic YWRtaW46YWRtaW4xMjM=' \
--header 'Content-Type: application/json' \
--data-raw '{
 "classification" : {
 "propagate" : false,
 "attributes" : {
 "type" : "false"
 },
 "typeName" : "TEST_TAG_TABLE"
 },
 "entitiesUniqAttributes" : [
 \{"qualifiedName": "db1.table43@cm"},
 \{"qualifiedName": "db1.table8@cm"},
 \{"qualifiedName": "db1.table55@cm"}],
 "entityGuids" : [
 "6d6ab082-9a62-4aea-97b7-2b7337173631",
 "9a0d3275-eb42-4229-ac51-6db1ddf3ccc6"],
 "entityTypeName" : "hive_table"
}'

> Atlas bulk clarification REST should be enhanced to associate classification 
> to bulk entities with uniq attribute and type
> --
>
> Key: ATLAS-4307
> URL: https://issues.apache.org/jira/browse/ATLAS-4307
> Project: Atlas
>  Issue Type: Bug
>Reporter: Sidharth Kumar Mishra
>Assignee: Sidharth Kumar Mishra
>Priority: Major
> Attachments: ATLAS-4307..patch
>
>
> Right now there is no REST to support this. The existing bulk add 
> classification takes a list of GUIDs and associates the classification to 
> them. The existing one should also take type name and list of unique 
> attribute values for entities and tag the classification if it finds entries.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4307) Atlas bulk clarification REST should be enhanced to associate classification to bulk entities with uniq attribute and type

2021-05-25 Thread Sidharth Kumar Mishra (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sidharth Kumar Mishra updated ATLAS-4307:
-
Summary: Atlas bulk clarification REST should be enhanced to associate 
classification to bulk entities with uniq attribute and type  (was: Atlas 
should have REST to add a classification to bulk entities with uniq attribute 
and type)

> Atlas bulk clarification REST should be enhanced to associate classification 
> to bulk entities with uniq attribute and type
> --
>
> Key: ATLAS-4307
> URL: https://issues.apache.org/jira/browse/ATLAS-4307
> Project: Atlas
>  Issue Type: Bug
>Reporter: Sidharth Kumar Mishra
>Assignee: Sidharth Kumar Mishra
>Priority: Major
>
> Right now there is no REST to support this. The existing bulk add 
> classification takes a list of GUIDs and associates the classification to 
> them. The existing one should also take type name and list of unique 
> attribute values for entities and tag the classification if it finds entries.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4307) Atlas should have REST to add a classification to bulk entities with uniq attribute and type

2021-05-25 Thread Sidharth Kumar Mishra (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-4307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351395#comment-17351395
 ] 

Sidharth Kumar Mishra commented on ATLAS-4307:
--

In case there is no entity found for the specific unique attribute and type and 
skipFailedEntities flag is not set to True then it will fail even there will be 
more specified unique attributes for other enttities. If skipFailedEntities = 
True then it will continue even there are some error for some entity.

> Atlas should have REST to add a classification to bulk entities with uniq 
> attribute and type
> 
>
> Key: ATLAS-4307
> URL: https://issues.apache.org/jira/browse/ATLAS-4307
> Project: Atlas
>  Issue Type: Bug
>Reporter: Sidharth Kumar Mishra
>Assignee: Sidharth Kumar Mishra
>Priority: Major
>
> Right now there is no REST to support this. The existing bulk add 
> classification takes a list of GUIDs and associates the classification to 
> them. The existing one should also take type name and list of unique 
> attribute values for entities and tag the classification if it finds entries.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4307) Atlas should have REST to add a classification to bulk entities with uniq attribute and type

2021-05-25 Thread Sidharth Kumar Mishra (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sidharth Kumar Mishra updated ATLAS-4307:
-
Description: Right now there is no REST to support this. The existing bulk 
add classification takes a list of GUIDs and associates the classification to 
them. The existing one should also take type name and list of unique attribute 
values for entities and tag the classification if it finds entries.  (was: 
Right now there is no REST to support this. The existing bulk add 
classification takes list of GUIDs and associate the classification to them. 
The new one will take type name and list of uniq attribute values for each 
entity and tag the classification.)

> Atlas should have REST to add a classification to bulk entities with uniq 
> attribute and type
> 
>
> Key: ATLAS-4307
> URL: https://issues.apache.org/jira/browse/ATLAS-4307
> Project: Atlas
>  Issue Type: Bug
>Reporter: Sidharth Kumar Mishra
>Assignee: Sidharth Kumar Mishra
>Priority: Major
>
> Right now there is no REST to support this. The existing bulk add 
> classification takes a list of GUIDs and associates the classification to 
> them. The existing one should also take type name and list of unique 
> attribute values for entities and tag the classification if it finds entries.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4307) Atlas should have REST to add a classification to bulk entities with uniq attribute and type

2021-05-25 Thread Sidharth Kumar Mishra (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sidharth Kumar Mishra updated ATLAS-4307:
-
Description: Right now there is no REST to support this. The existing bulk 
add classification takes list of GUIDs and associate the classification to 
them. The new one will take type name and list of uniq attribute values for 
each entity and tag the classification.

> Atlas should have REST to add a classification to bulk entities with uniq 
> attribute and type
> 
>
> Key: ATLAS-4307
> URL: https://issues.apache.org/jira/browse/ATLAS-4307
> Project: Atlas
>  Issue Type: Bug
>Reporter: Sidharth Kumar Mishra
>Assignee: Sidharth Kumar Mishra
>Priority: Major
>
> Right now there is no REST to support this. The existing bulk add 
> classification takes list of GUIDs and associate the classification to them. 
> The new one will take type name and list of uniq attribute values for each 
> entity and tag the classification.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (ATLAS-4307) Atlas should have REST to add a classification to bulk entities with uniq attribute and type

2021-05-25 Thread Sidharth Kumar Mishra (Jira) 
Sidharth Kumar Mishra created ATLAS-4307:


 Summary: Atlas should have REST to add a classification to bulk 
entities with uniq attribute and type
 Key: ATLAS-4307
 URL: https://issues.apache.org/jira/browse/ATLAS-4307
 Project: Atlas
  Issue Type: Bug
Reporter: Sidharth Kumar Mishra
Assignee: Sidharth Kumar Mishra






--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Review Request 73375: Handle Spool Directory Creation by Different Users

2021-05-25 Thread Ashutosh Mestry via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73375/
---

Review request for atlas, Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian.


Bugs: ATLAS-4306
https://issues.apache.org/jira/browse/ATLAS-4306


Repository: atlas


Description
---

Please see bug description.


Diffs
-

  
notification/src/main/java/org/apache/atlas/notification/spool/AtlasFileSpool.java
 ea3128465 
  
notification/src/main/java/org/apache/atlas/notification/spool/IndexManagement.java
 f018983a4 
  
notification/src/main/java/org/apache/atlas/notification/spool/SpoolConfiguration.java
 76f05efea 
  
notification/src/main/java/org/apache/atlas/notification/spool/SpoolUtils.java 
abbe33d24 
  notification/src/test/java/org/apache/atlas/notification/spool/BaseTest.java 
304c82122 


Diff: https://reviews.apache.org/r/73375/diff/1/


Testing
---

**Functional tests**
Existing workflows.

**Unit tests**
None.


Thanks,

Ashutosh Mestry

[jira] [Assigned] (ATLAS-4304) [Business Metadata Bulk Import] [Beta UI] Bulk Import Business Metadata/Glossary options overlap

2021-05-25 Thread Prasad P. Pawar (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prasad P. Pawar reassigned ATLAS-4304:
--

Assignee: Prasad P. Pawar

> [Business Metadata Bulk Import] [Beta UI] Bulk Import Business 
> Metadata/Glossary options overlap
> 
>
> Key: ATLAS-4304
> URL: https://issues.apache.org/jira/browse/ATLAS-4304
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Reporter: Umesh Padashetty
>Assignee: Prasad P. Pawar
>Priority: Minor
> Attachments: Screenshot 2021-05-24 at 11.31.32 PM.png, Screenshot 
> 2021-05-24 at 11.31.48 PM.png
>
>
> As seen in the screenshot below, the sub drop downs overlap and the Business 
> Metadata/Glossary in almost 50% hidden
> !Screenshot 2021-05-24 at 11.31.32 PM.png!
> !Screenshot 2021-05-24 at 11.31.48 PM.png!
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4299) [Atlas: Debug Metrics] Several UI Issues are seen when the total count crossed 25

2021-05-25 Thread Prasad P. Pawar (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-4299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351291#comment-17351291
 ] 

Prasad P. Pawar commented on ATLAS-4299:


Hi,
the fix is provided on the uploaded patch.

> [Atlas: Debug Metrics] Several UI Issues are seen when the total count 
> crossed 25
> -
>
> Key: ATLAS-4299
> URL: https://issues.apache.org/jira/browse/ATLAS-4299
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Reporter: Dharshana M Krishnamoorthy
>Assignee: Prasad P. Pawar
>Priority: Major
> Attachments: 
> 0001-ATLAS-UI-ATLAS-4296-ATLAS-4298-ATLAS-4299-Debug-Metr.patch, Screenshot 
> 2021-05-24 at 4.13.08 PM.png, Screenshot 2021-05-24 at 4.40.15 PM.png
>
>
> A list of UI issues are seen when the total issues crosses 25
>  # The total number of data as per response is 29, but UI says 30
>  # The data displayed are only 29 but one of them is a blank entry 
> (Highlighted in screenshot)
>  # Among the 29 entries present in api response, one of them is missing in 
> the UI in this case [*TypesREST_getTypeDefHeaders*]
>  # When all the data are made to display in same page, the UI shows page 1 
> and 2
>  # When the selection is made to display only 25, it still displays all the 
> data [25+ entries are displayed]
>  # Sorting does not work without refresh
> Response Data:
> {code:java}
> {
>   "TypesREST_getTypeDefHeaders": {
> "name": "TypesREST_getTypeDefHeaders",
> "numops": 13,
> "minTime": 2,
> "maxTime": 37,
> "stdDevTime": 0,
> "avgTime": 2
>   },
>   "GlossaryREST_createGlossaryTerm": {
> "name": "GlossaryREST_createGlossaryTerm",
> "numops": 11,
> "minTime": 218,
> "maxTime": 308,
> "stdDevTime": 29.160475,
> "avgTime": 235.3
>   },
>   "GlossaryREST_deleteGlossaryCategory": {
> "name": "GlossaryREST_deleteGlossaryCategory",
> "numops": 2,
> "minTime": 197,
> "maxTime": 219,
> "stdDevTime": 0,
> "avgTime": 197
>   },
>   "GlossaryREST_deleteGlossary": {
> "name": "GlossaryREST_deleteGlossary",
> "numops": 3,
> "minTime": 165,
> "maxTime": 521,
> "stdDevTime": 251.73001,
> "avgTime": 343
>   },
>   "EntityREST_addClassifications": {
> "name": "EntityREST_addClassifications",
> "numops": 339,
> "minTime": 64,
> "maxTime": 430,
> "stdDevTime": 2.5495098,
> "avgTime": 101.5
>   },
>   "DiscoveryREST_getSavedSearches": {
> "name": "DiscoveryREST_getSavedSearches",
> "numops": 13,
> "minTime": 3,
> "maxTime": 38,
> "stdDevTime": 0,
> "avgTime": 3
>   },
>   "TypesREST_getClassificationDefByName": {
> "name": "TypesREST_getClassificationDefByName",
> "numops": 11,
> "minTime": 2,
> "maxTime": 2,
> "stdDevTime": 0,
> "avgTime": 1
>   },
>   "GlossaryREST_createGlossary": {
> "name": "GlossaryREST_createGlossary",
> "numops": 4,
> "minTime": 167,
> "maxTime": 197,
> "stdDevTime": 0,
> "avgTime": 179
>   },
>   "EntityREST_createOrUpdate": {
> "name": "EntityREST_createOrUpdate",
> "numops": 2,
> "minTime": 76,
> "maxTime": 133,
> "stdDevTime": 40.305088,
> "avgTime": 104.5
>   },
>   "GlossaryREST_getGlossaryCategory": {
> "name": "GlossaryREST_getGlossaryCategory",
> "numops": 14,
> "minTime": 5,
> "maxTime": 47,
> "stdDevTime": 18.384777,
> "avgTime": 25
>   },
>   "GlossaryREST_updateGlossaryTerm": {
> "name": "GlossaryREST_updateGlossaryTerm",
> "numops": 5,
> "minTime": 62,
> "maxTime": 559,
> "stdDevTime": 340.11835,
> "avgTime": 62
>   },
>   "DiscoveryREST_searchUsingBasic": {
> "name": "DiscoveryREST_searchUsingBasic",
> "numops": 2,
> "minTime": 25,
> "maxTime": 451,
> "stdDevTime": 0,
> "avgTime": 25
>   },
>   "EntityREST_getById": {
> "name": "EntityREST_getById",
> "numops": 5,
> "minTime": 37,
> "maxTime": 84,
> "stdDevTime": 20.067387,
> "avgTime": 52.8
>   },
>   "GlossaryREST_getGlossaries": {
> "name": "GlossaryREST_getGlossaries",
> "numops": 34,
> "minTime": 10,
> "maxTime": 291,
> "stdDevTime": 48.294235,
> "avgTime": 180
>   },
>   "TypesREST_getAllTypeDefs": {
> "name": "TypesREST_getAllTypeDefs",
> "numops": 44,
> "minTime": 0,
> "maxTime": 32,
> "stdDevTime": 0.5,
> "avgTime": 0.25
>   },
>   "DiscoveryREST_searchUsingDSL": {
> "name": "DiscoveryREST_searchUsingDSL",
> "numops": 4,
> "minTime": 13,
> "maxTime": 243,
> "stdDevTime": 155.56349,
> "avgTime": 16
>   },
>   "GlossaryREST_createGlossaryCategory": {
> "name": "GlossaryREST_createGlossaryCategory",
> "numops": 4,
> "minTime": 195,

[jira] [Updated] (ATLAS-4296) [Atlas: Debug Metrics] Min Time , Max Time and Average Time in UI are not matching the api response values

2021-05-25 Thread Prasad P. Pawar (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prasad P. Pawar updated ATLAS-4296:
---
Attachment: 0001-ATLAS-UI-ATLAS-4296-ATLAS-4298-ATLAS-4299-Debug-Metr.patch

> [Atlas: Debug Metrics] Min Time , Max Time and Average Time in UI are not 
> matching the api response values
> --
>
> Key: ATLAS-4296
> URL: https://issues.apache.org/jira/browse/ATLAS-4296
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Dharshana M Krishnamoorthy
>Assignee: Mayank Jain
>Priority: Major
> Attachments: 
> 0001-ATLAS-UI-ATLAS-4296-ATLAS-4298-ATLAS-4299-Debug-Metr.patch, 
> ATLAS-4296-1.patch, Screenshot 2021-05-21 at 4.18.34 PM.png, Screenshot 
> 2021-05-21 at 4.18.34 PM.png
>
>
> Scenario: Enable debug Metrics
> !Screenshot 2021-05-21 at 4.18.34 PM.png|width=646,height=322!
> Eg: Consider the above highlighted example. *GlossaryREST_deleteGlossary*
> Here
> Min Time : 1.920 (seconds)
> Max Time : 5.530 (seconds) and 
> Average Time : 5.530 (seconds)
> *Api response:*
> {code:java}
>   "GlossaryREST_deleteGlossary": {
> "name": "GlossaryREST_deleteGlossary",
> "numops": 6,
> "minTime": 192,
> "maxTime": 553,
> "stdDevTime": 21.556128,
> "avgTime": 532
>   } {code}
>  
> 1.92 (seconds) has to be 1920 if the value is response is stored in 
> milliseconds but it appears as 192



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4298) [Atlas: Debug Metrics][UI] When REST API Metric page has more than 25 entries, the page does not load unless manually refreshed

2021-05-25 Thread Prasad P. Pawar (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-4298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351290#comment-17351290
 ] 

Prasad P. Pawar commented on ATLAS-4298:


Hi,
the fix is provided on the uploaded patch.

> [Atlas: Debug Metrics][UI] When REST API Metric page has more than 25 
> entries, the page does not load unless manually refreshed
> ---
>
> Key: ATLAS-4298
> URL: https://issues.apache.org/jira/browse/ATLAS-4298
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Reporter: Dharshana M Krishnamoorthy
>Assignee: Prasad P. Pawar
>Priority: Major
> Attachments: 
> 0001-ATLAS-UI-ATLAS-4296-ATLAS-4298-ATLAS-4299-Debug-Metr.patch
>
>
> When debug metrics is enabled by setting *atlas.debug.metrics.enabled=true* 
> Debug metrics url page: :31443/index.html#!/debugMetrics displays the 
> REST API Metrics.
> When the result page entry count crosses 25, the page does not load, unless 
> refresh button is hit
> There are no error logs found in the cluster but console displays the 
> following
> {code:java}
> backbone.paginator.min.js?bust=1621440039818:1 
> Uncaught TypeError: Cannot read property 'add' of undefined
> at e (backbone.paginator.min.js?bust=1621440039818:1)
> at Object. (backbone.paginator.min.js?bust=1621440039818:1)
> at s (backbone-min.js?bust=1621440039818:1)
> at r (backbone-min.js?bust=1621440039818:1)
> at m (backbone-min.js?bust=1621440039818:1)
> at N.d.k.trigger (backbone-min.js?bust=1621440039818:1)
> at N.d._onModelEvent (backbone-min.js?bust=1621440039818:1)
> at s (backbone-min.js?bust=1621440039818:1)
> at r (backbone-min.js?bust=1621440039818:1)
> at m (backbone-min.js?bust=1621440039818:1){code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4296) [Atlas: Debug Metrics] Min Time , Max Time and Average Time in UI are not matching the api response values

2021-05-25 Thread Prasad P. Pawar (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-4296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351289#comment-17351289
 ] 

Prasad P. Pawar commented on ATLAS-4296:


Hi,
the fix is provided on the uploaded patch.

> [Atlas: Debug Metrics] Min Time , Max Time and Average Time in UI are not 
> matching the api response values
> --
>
> Key: ATLAS-4296
> URL: https://issues.apache.org/jira/browse/ATLAS-4296
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Dharshana M Krishnamoorthy
>Assignee: Mayank Jain
>Priority: Major
> Attachments: 
> 0001-ATLAS-UI-ATLAS-4296-ATLAS-4298-ATLAS-4299-Debug-Metr.patch, 
> ATLAS-4296-1.patch, Screenshot 2021-05-21 at 4.18.34 PM.png, Screenshot 
> 2021-05-21 at 4.18.34 PM.png
>
>
> Scenario: Enable debug Metrics
> !Screenshot 2021-05-21 at 4.18.34 PM.png|width=646,height=322!
> Eg: Consider the above highlighted example. *GlossaryREST_deleteGlossary*
> Here
> Min Time : 1.920 (seconds)
> Max Time : 5.530 (seconds) and 
> Average Time : 5.530 (seconds)
> *Api response:*
> {code:java}
>   "GlossaryREST_deleteGlossary": {
> "name": "GlossaryREST_deleteGlossary",
> "numops": 6,
> "minTime": 192,
> "maxTime": 553,
> "stdDevTime": 21.556128,
> "avgTime": 532
>   } {code}
>  
> 1.92 (seconds) has to be 1920 if the value is response is stored in 
> milliseconds but it appears as 192



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Assigned] (ATLAS-4299) [Atlas: Debug Metrics] Several UI Issues are seen when the total count crossed 25

2021-05-25 Thread Prasad P. Pawar (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prasad P. Pawar reassigned ATLAS-4299:
--

Assignee: Prasad P. Pawar

> [Atlas: Debug Metrics] Several UI Issues are seen when the total count 
> crossed 25
> -
>
> Key: ATLAS-4299
> URL: https://issues.apache.org/jira/browse/ATLAS-4299
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Reporter: Dharshana M Krishnamoorthy
>Assignee: Prasad P. Pawar
>Priority: Major
> Attachments: 
> 0001-ATLAS-UI-ATLAS-4296-ATLAS-4298-ATLAS-4299-Debug-Metr.patch, Screenshot 
> 2021-05-24 at 4.13.08 PM.png, Screenshot 2021-05-24 at 4.40.15 PM.png
>
>
> A list of UI issues are seen when the total issues crosses 25
>  # The total number of data as per response is 29, but UI says 30
>  # The data displayed are only 29 but one of them is a blank entry 
> (Highlighted in screenshot)
>  # Among the 29 entries present in api response, one of them is missing in 
> the UI in this case [*TypesREST_getTypeDefHeaders*]
>  # When all the data are made to display in same page, the UI shows page 1 
> and 2
>  # When the selection is made to display only 25, it still displays all the 
> data [25+ entries are displayed]
>  # Sorting does not work without refresh
> Response Data:
> {code:java}
> {
>   "TypesREST_getTypeDefHeaders": {
> "name": "TypesREST_getTypeDefHeaders",
> "numops": 13,
> "minTime": 2,
> "maxTime": 37,
> "stdDevTime": 0,
> "avgTime": 2
>   },
>   "GlossaryREST_createGlossaryTerm": {
> "name": "GlossaryREST_createGlossaryTerm",
> "numops": 11,
> "minTime": 218,
> "maxTime": 308,
> "stdDevTime": 29.160475,
> "avgTime": 235.3
>   },
>   "GlossaryREST_deleteGlossaryCategory": {
> "name": "GlossaryREST_deleteGlossaryCategory",
> "numops": 2,
> "minTime": 197,
> "maxTime": 219,
> "stdDevTime": 0,
> "avgTime": 197
>   },
>   "GlossaryREST_deleteGlossary": {
> "name": "GlossaryREST_deleteGlossary",
> "numops": 3,
> "minTime": 165,
> "maxTime": 521,
> "stdDevTime": 251.73001,
> "avgTime": 343
>   },
>   "EntityREST_addClassifications": {
> "name": "EntityREST_addClassifications",
> "numops": 339,
> "minTime": 64,
> "maxTime": 430,
> "stdDevTime": 2.5495098,
> "avgTime": 101.5
>   },
>   "DiscoveryREST_getSavedSearches": {
> "name": "DiscoveryREST_getSavedSearches",
> "numops": 13,
> "minTime": 3,
> "maxTime": 38,
> "stdDevTime": 0,
> "avgTime": 3
>   },
>   "TypesREST_getClassificationDefByName": {
> "name": "TypesREST_getClassificationDefByName",
> "numops": 11,
> "minTime": 2,
> "maxTime": 2,
> "stdDevTime": 0,
> "avgTime": 1
>   },
>   "GlossaryREST_createGlossary": {
> "name": "GlossaryREST_createGlossary",
> "numops": 4,
> "minTime": 167,
> "maxTime": 197,
> "stdDevTime": 0,
> "avgTime": 179
>   },
>   "EntityREST_createOrUpdate": {
> "name": "EntityREST_createOrUpdate",
> "numops": 2,
> "minTime": 76,
> "maxTime": 133,
> "stdDevTime": 40.305088,
> "avgTime": 104.5
>   },
>   "GlossaryREST_getGlossaryCategory": {
> "name": "GlossaryREST_getGlossaryCategory",
> "numops": 14,
> "minTime": 5,
> "maxTime": 47,
> "stdDevTime": 18.384777,
> "avgTime": 25
>   },
>   "GlossaryREST_updateGlossaryTerm": {
> "name": "GlossaryREST_updateGlossaryTerm",
> "numops": 5,
> "minTime": 62,
> "maxTime": 559,
> "stdDevTime": 340.11835,
> "avgTime": 62
>   },
>   "DiscoveryREST_searchUsingBasic": {
> "name": "DiscoveryREST_searchUsingBasic",
> "numops": 2,
> "minTime": 25,
> "maxTime": 451,
> "stdDevTime": 0,
> "avgTime": 25
>   },
>   "EntityREST_getById": {
> "name": "EntityREST_getById",
> "numops": 5,
> "minTime": 37,
> "maxTime": 84,
> "stdDevTime": 20.067387,
> "avgTime": 52.8
>   },
>   "GlossaryREST_getGlossaries": {
> "name": "GlossaryREST_getGlossaries",
> "numops": 34,
> "minTime": 10,
> "maxTime": 291,
> "stdDevTime": 48.294235,
> "avgTime": 180
>   },
>   "TypesREST_getAllTypeDefs": {
> "name": "TypesREST_getAllTypeDefs",
> "numops": 44,
> "minTime": 0,
> "maxTime": 32,
> "stdDevTime": 0.5,
> "avgTime": 0.25
>   },
>   "DiscoveryREST_searchUsingDSL": {
> "name": "DiscoveryREST_searchUsingDSL",
> "numops": 4,
> "minTime": 13,
> "maxTime": 243,
> "stdDevTime": 155.56349,
> "avgTime": 16
>   },
>   "GlossaryREST_createGlossaryCategory": {
> "name": "GlossaryREST_createGlossaryCategory",
> "numops": 4,
> "minTime": 195,
> "maxTime": 293,
> "stdDevTime": 0,
> "avgTime": 293
>

[jira] [Assigned] (ATLAS-4298) [Atlas: Debug Metrics][UI] When REST API Metric page has more than 25 entries, the page does not load unless manually refreshed

2021-05-25 Thread Prasad P. Pawar (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prasad P. Pawar reassigned ATLAS-4298:
--

Assignee: Prasad P. Pawar

> [Atlas: Debug Metrics][UI] When REST API Metric page has more than 25 
> entries, the page does not load unless manually refreshed
> ---
>
> Key: ATLAS-4298
> URL: https://issues.apache.org/jira/browse/ATLAS-4298
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Reporter: Dharshana M Krishnamoorthy
>Assignee: Prasad P. Pawar
>Priority: Major
> Attachments: 
> 0001-ATLAS-UI-ATLAS-4296-ATLAS-4298-ATLAS-4299-Debug-Metr.patch
>
>
> When debug metrics is enabled by setting *atlas.debug.metrics.enabled=true* 
> Debug metrics url page: :31443/index.html#!/debugMetrics displays the 
> REST API Metrics.
> When the result page entry count crosses 25, the page does not load, unless 
> refresh button is hit
> There are no error logs found in the cluster but console displays the 
> following
> {code:java}
> backbone.paginator.min.js?bust=1621440039818:1 
> Uncaught TypeError: Cannot read property 'add' of undefined
> at e (backbone.paginator.min.js?bust=1621440039818:1)
> at Object. (backbone.paginator.min.js?bust=1621440039818:1)
> at s (backbone-min.js?bust=1621440039818:1)
> at r (backbone-min.js?bust=1621440039818:1)
> at m (backbone-min.js?bust=1621440039818:1)
> at N.d.k.trigger (backbone-min.js?bust=1621440039818:1)
> at N.d._onModelEvent (backbone-min.js?bust=1621440039818:1)
> at s (backbone-min.js?bust=1621440039818:1)
> at r (backbone-min.js?bust=1621440039818:1)
> at m (backbone-min.js?bust=1621440039818:1){code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4254) Basic Search : Optimize pagination

2021-05-25 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-4254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351196#comment-17351196
 ] 

ASF subversion and git services commented on ATLAS-4254:


Commit 50869680e4cc5c27d80738101f2a122c52bf in atlas's branch 
refs/heads/branch-2.0 from Pinal
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=5086968 ]

ATLAS-4254 : Basic Search : Optimize pagination

Signed-off-by: Pinal 


> Basic Search : Optimize pagination
> --
>
> Key: ATLAS-4254
> URL: https://issues.apache.org/jira/browse/ATLAS-4254
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Reporter: Pinal
>Assignee: Pinal
>Priority: Major
>  Labels: BasicSearch
>
> *Current Working of Pagination*
>  * When user specifies page information i.e offset and limit in the request, 
> except some condition, offset is reset to 0
>  * Query is then executed from 0 offset and limit
>  * Filter out the results obtained from query
>  * Generate result set by skipping the results from 0 to the given offset
> *New Working Structure*
>  * New Parameter 'marker' (String) has been introduced in SearchParameters 
> which will have encrypted string as value.
>  * The marker should be  set as '*' for the start of the page
>  * The response of above request (AtlasSearchResult) will have 'nextMarker' 
> field which will have encrypted String which is to be passed as value of 
> 'marker' in the subsequent request
>  * if marker is set then offset should not be greater than 0
> *Improvement*
>  * It will increase performance of the basic search 
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4254) Basic Search : Optimize pagination

2021-05-25 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-4254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17351191#comment-17351191
 ] 

ASF subversion and git services commented on ATLAS-4254:


Commit 35419d6c5a8b1b2bbba60e2f6d6fdf19efd8949b in atlas's branch 
refs/heads/master from Pinal
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=35419d6 ]

ATLAS-4254 : Basic Search : Optimize pagination

Signed-off-by: Pinal 


> Basic Search : Optimize pagination
> --
>
> Key: ATLAS-4254
> URL: https://issues.apache.org/jira/browse/ATLAS-4254
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Reporter: Pinal
>Assignee: Pinal
>Priority: Major
>  Labels: BasicSearch
>
> *Current Working of Pagination*
>  * When user specifies page information i.e offset and limit in the request, 
> except some condition, offset is reset to 0
>  * Query is then executed from 0 offset and limit
>  * Filter out the results obtained from query
>  * Generate result set by skipping the results from 0 to the given offset
> *New Working Structure*
>  * New Parameter 'marker' (String) has been introduced in SearchParameters 
> which will have encrypted string as value.
>  * The marker should be  set as '*' for the start of the page
>  * The response of above request (AtlasSearchResult) will have 'nextMarker' 
> field which will have encrypted String which is to be passed as value of 
> 'marker' in the subsequent request
>  * if marker is set then offset should not be greater than 0
> *Improvement*
>  * It will increase performance of the basic search 
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 73292: ATLAS-4254 : Basic Search : Optimize pagination

2021-05-25 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73292/#review223040
---


Ship it!




Ship It!

- Sarath Subramanian


On May 13, 2021, 8:43 a.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73292/
> ---
> 
> (Updated May 13, 2021, 8:43 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4254
> https://issues.apache.org/jira/browse/ATLAS-4254
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Current Working of Pagination**
> 
> - When user specifies page information i.e offset and limit in the request, 
> except some condition, offset is reset to 0
> - Query is then executed from 0 offset and limit
> - Filter out the results obtained from query
> - Generate result set by skipping the results from 0 to the given offset
> 
> **New Working Structure**
> 
> - New Parameter 'marker' (String) has been introduced in SearchParameters 
> which will have encrypted string as value.
> - The marker should be  set as '*' for the start of the page
> - The response of above request (AtlasSearchResult) will have 'nextMarker' 
> field which will have encrypted String which is to be passed as value of 
> 'marker' in the subsequent request
> - if marker is set then offset should not be greater than 0
> 
> 
> **Perfomance details**
> 
> Took usecase of ranger tagsync:
> - On searching tagged entities starting with offset: 0 and limit: 1000 
> returned 1 entities in ~ 21s
> - On searching tagged entities starting with marker: * and limit: 1000 
> returned 1 entities in ~ 10s
> (both the number are taken on the fresh start of the server, so as to avoid 
> caching affecting the numbers)
> - Removed 'atlas.graph.index.search.max-result-set-size=150' property from 
> atlas-application.properties
> 
> - Around 25% improvement
> 
> - Improvement is seen as the page size increases.
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/model/discovery/AtlasSearchResult.java 
> e1c550ef7 
>   intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java 
> 9d2cd4ffc 
>   
> repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java
>  647ff9ca0 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  a3ab6e38c 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java
>  5dcff3b16 
>   
> repository/src/main/java/org/apache/atlas/discovery/FreeTextSearchProcessor.java
>  92152fff5 
>   
> repository/src/main/java/org/apache/atlas/discovery/FullTextSearchProcessor.java
>  b37d93a83 
>   repository/src/main/java/org/apache/atlas/discovery/SearchContext.java 
> aa49121f6 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
> f9832c3b2 
>   
> repository/src/main/java/org/apache/atlas/discovery/TermSearchProcessor.java 
> 45a815886 
>   
> repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
>  027827af2 
>   
> repository/src/test/java/org/apache/atlas/discovery/ClassificationSearchProcessorTest.java
>  e1ebbfc70 
>   webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java 4c7b6228d 
> 
> 
> Diff: https://reviews.apache.org/r/73292/diff/5/
> 
> 
> Testing
> ---
> 
> MAnual testing
> unit testcases
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>

[jira] [Resolved] (ATLAS-4064) Atlas HEADER validation

2021-05-25 Thread Nikhil P Bonte (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil P Bonte resolved ATLAS-4064.
---
Fix Version/s: 2.2.0
   3.0.0
   Resolution: Resolved

> Atlas HEADER validation
> ---
>
> Key: ATLAS-4064
> URL: https://issues.apache.org/jira/browse/ATLAS-4064
> Project: Atlas
>  Issue Type: Bug
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
>
> Validation of HEADERS in backend.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4254) Basic Search : Optimize pagination

2021-05-25 Thread Pinal (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pinal updated ATLAS-4254:
-
Issue Type: Improvement  (was: Bug)

> Basic Search : Optimize pagination
> --
>
> Key: ATLAS-4254
> URL: https://issues.apache.org/jira/browse/ATLAS-4254
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Reporter: Pinal
>Assignee: Pinal
>Priority: Major
>  Labels: BasicSearch
>
> *Current Working of Pagination*
>  * When user specifies page information i.e offset and limit in the request, 
> except some condition, offset is reset to 0
>  * Query is then executed from 0 offset and limit
>  * Filter out the results obtained from query
>  * Generate result set by skipping the results from 0 to the given offset
> *New Working Structure*
>  * New Parameter 'marker' (String) has been introduced in SearchParameters 
> which will have encrypted string as value.
>  * The marker should be  set as '*' for the start of the page
>  * The response of above request (AtlasSearchResult) will have 'nextMarker' 
> field which will have encrypted String which is to be passed as value of 
> 'marker' in the subsequent request
>  * if marker is set then offset should not be greater than 0
> *Improvement*
>  * It will increase performance of the basic search 
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [atlas] jiutianfeiwu closed pull request #138: Merge pull request #1 from apache/master

2021-05-25 Thread GitBox 


jiutianfeiwu closed pull request #138:
URL: https://github.com/apache/atlas/pull/138


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [atlas] jiutianfeiwu commented on pull request #138: Merge pull request #1 from apache/master

2021-05-25 Thread GitBox 


jiutianfeiwu commented on pull request #138:
URL: https://github.com/apache/atlas/pull/138#issuecomment-847702037


   syn


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [atlas] jiutianfeiwu opened a new pull request #138: Merge pull request #1 from apache/master

2021-05-25 Thread GitBox 


jiutianfeiwu opened a new pull request #138:
URL: https://github.com/apache/atlas/pull/138


   pull20210427


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org