Re: Review Request 74180: ATLAS-4691 - Discrepancy in the atlas debug metrics between the active and the not active servers

2022-10-24 Thread Pinal Shah

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74180/#review224826
---


Ship it!




Ship It!

- Pinal Shah


On Oct. 24, 2022, 8:05 a.m., Jayendra Parab wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74180/
> ---
> 
> (Updated Oct. 24, 2022, 8:05 a.m.)
> 
> 
> Review request for atlas, Mandar Ambawane, Pinal Shah, Radhika Kundam, and 
> Sidharth Mishra.
> 
> 
> Bugs: ATLAS-4691
> https://issues.apache.org/jira/browse/ATLAS-4691
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> In HA setup, there is difference in response when debug metrics API 
> ("admin/debug/metrics") is accessed on active server and passive server. 
> The reason for this is debug metrics are maintained in-memory in the active 
> server. When "admin/debug/metrics" API call is accessed on the passive 
> server, the request isn't redirected to the active server like it does for 
> the other APIs, hence the passive node returns empty metrics.
> Adding "admin/debug/metrics" to the list of adminUriNotFiltered, so that the 
> API call gets redirected to active server.
> 
> 
> Diffs
> -
> 
>   webapp/src/main/java/org/apache/atlas/web/filters/ActiveServerFilter.java 
> a1d30ba87 
> 
> 
> Diff: https://reviews.apache.org/r/74180/diff/1/
> 
> 
> Testing
> ---
> 
> Tested manually on a HA setup, with this change, when the 
> "admin/debug/metrics" is sent to passive server, the request is redirected to 
> active server and correct response is returned
> 
> 
> Thanks,
> 
> Jayendra Parab
> 
>



[jira] [Commented] (ATLAS-4691) Discrepancy in the atlas debug metrics between the active and the not active servers

2022-10-24 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17623277#comment-17623277
 ] 

ASF subversion and git services commented on ATLAS-4691:


Commit faf9da84bbf55cf46bce275ad1488333d71629cb in atlas's branch 
refs/heads/branch-2.0 from Jayendra Parab
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=faf9da84b ]

ATLAS-4691: Discrepancy in the atlas debug metrics between the active and the 
not active servers

Signed-off-by: Pinal Shah 
(cherry picked from commit 1c7e59478c8d2905f732c1d87da5e8fd940637b8)


> Discrepancy in the atlas debug metrics between the active and the not active 
> servers
> 
>
> Key: ATLAS-4691
> URL: https://issues.apache.org/jira/browse/ATLAS-4691
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 2.2.0
>Reporter: Jayendra Parab
>Assignee: Jayendra Parab
>Priority: Major
>
> There is a discrepancy in the atlas debug metrics between the active and the 
> not active servers.
> Steps to reproduce:
>  - Setup Atlas in HA mode with two instances of Atlas
>  - add "atlas.debug.metrics.enabled=true" to the Atlas configuration 
> (conf/atlas-application.properties)
>  - restart Atlas
>  - open Atlas and create a new entity (e.g. hdfs_path) 
>  - check the debug metrics on both atlas instances using API call: 
> https://:/api/atlas/admin/debug/metrics
>  - The active instance returns correct metrics, whereas passive instance 
> returns empty metrics
> The reason for this is that the debug metrics are maintained in-memory in the 
> active server. When "admin/debug/metrics" API call is accessed on the passive 
> server, the request isn't redirected to the active server like it does for 
> the other APIs, hence the passive node returns empty metrics.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (ATLAS-4691) Discrepancy in the atlas debug metrics between the active and the not active servers

2022-10-24 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17623276#comment-17623276
 ] 

ASF subversion and git services commented on ATLAS-4691:


Commit 1c7e59478c8d2905f732c1d87da5e8fd940637b8 in atlas's branch 
refs/heads/master from Jayendra Parab
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=1c7e59478 ]

ATLAS-4691: Discrepancy in the atlas debug metrics between the active and the 
not active servers

Signed-off-by: Pinal Shah 


> Discrepancy in the atlas debug metrics between the active and the not active 
> servers
> 
>
> Key: ATLAS-4691
> URL: https://issues.apache.org/jira/browse/ATLAS-4691
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 2.2.0
>Reporter: Jayendra Parab
>Assignee: Jayendra Parab
>Priority: Major
>
> There is a discrepancy in the atlas debug metrics between the active and the 
> not active servers.
> Steps to reproduce:
>  - Setup Atlas in HA mode with two instances of Atlas
>  - add "atlas.debug.metrics.enabled=true" to the Atlas configuration 
> (conf/atlas-application.properties)
>  - restart Atlas
>  - open Atlas and create a new entity (e.g. hdfs_path) 
>  - check the debug metrics on both atlas instances using API call: 
> https://:/api/atlas/admin/debug/metrics
>  - The active instance returns correct metrics, whereas passive instance 
> returns empty metrics
> The reason for this is that the debug metrics are maintained in-memory in the 
> active server. When "admin/debug/metrics" API call is accessed on the passive 
> server, the request isn't redirected to the active server like it does for 
> the other APIs, hence the passive node returns empty metrics.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [atlas] bdsoha commented on pull request #203: Remove os.path.join causing incorrect windows path

2022-10-24 Thread GitBox


bdsoha commented on PR #203:
URL: https://github.com/apache/atlas/pull/203#issuecomment-1288819928

   @pinal-shah @mandarambawane Any activity on the *Python Client*?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@atlas.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (ATLAS-4691) Discrepancy in the atlas debug metrics between the active and the not active servers

2022-10-24 Thread Jayendra Parab (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jayendra Parab updated ATLAS-4691:
--
Description: 
There is a discrepancy in the atlas debug metrics between the active and the 
not active servers.

Steps to reproduce:
 - Setup Atlas in HA mode with two instances of Atlas
 - add "atlas.debug.metrics.enabled=true" to the Atlas configuration 
(conf/atlas-application.properties)
 - restart Atlas
 - open Atlas and create a new entity (e.g. hdfs_path) 
 - check the debug metrics on both atlas instances using API call: 
https://:/api/atlas/admin/debug/metrics
 - The active instance returns correct metrics, whereas passive instance 
returns empty metrics

The reason for this is that the debug metrics are maintained in-memory in the 
active server. When "admin/debug/metrics" API call is accessed on the passive 
server, the request isn't redirected to the active server like it does for the 
other APIs, hence the passive node returns empty metrics.

  was:
There is a discrepancy in the atlas debug metrics between the active and the 
not active servers.

Steps to reproduce:
 - Setup Atlas in HA mode with two instances of Atlas
 - add "atlas.debug.metrics.enabled=true" to the Atlas configuration 
(conf/atlas-application.properties_role_safety_valve)
 - restart Atlas
 - open Atlas and create a new entity (e.g. hdfs_path) 
 - check the debug metrics on both atlas instances using API call: 
https://:/api/atlas/admin/debug/metrics
 - The active instance returns correct metrics, whereas passive instance 
returns empty metrics

The reason for this is that the debug metrics are maintained in-memory in the 
active server. When "admin/debug/metrics" API call is accessed on the passive 
server, the request isn't redirected to the active server like it does for the 
other APIs, hence the passive node returns empty metrics.


> Discrepancy in the atlas debug metrics between the active and the not active 
> servers
> 
>
> Key: ATLAS-4691
> URL: https://issues.apache.org/jira/browse/ATLAS-4691
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 2.2.0
>Reporter: Jayendra Parab
>Assignee: Jayendra Parab
>Priority: Major
>
> There is a discrepancy in the atlas debug metrics between the active and the 
> not active servers.
> Steps to reproduce:
>  - Setup Atlas in HA mode with two instances of Atlas
>  - add "atlas.debug.metrics.enabled=true" to the Atlas configuration 
> (conf/atlas-application.properties)
>  - restart Atlas
>  - open Atlas and create a new entity (e.g. hdfs_path) 
>  - check the debug metrics on both atlas instances using API call: 
> https://:/api/atlas/admin/debug/metrics
>  - The active instance returns correct metrics, whereas passive instance 
> returns empty metrics
> The reason for this is that the debug metrics are maintained in-memory in the 
> active server. When "admin/debug/metrics" API call is accessed on the passive 
> server, the request isn't redirected to the active server like it does for 
> the other APIs, hence the passive node returns empty metrics.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Review Request 74180: ATLAS-4691 - Discrepancy in the atlas debug metrics between the active and the not active servers

2022-10-24 Thread Jayendra Parab

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74180/
---

Review request for atlas, Mandar Ambawane, Pinal Shah, Radhika Kundam, and 
Sidharth Mishra.


Bugs: ATLAS-4691
https://issues.apache.org/jira/browse/ATLAS-4691


Repository: atlas


Description
---

In HA setup, there is difference in response when debug metrics API 
("admin/debug/metrics") is accessed on active server and passive server. 
The reason for this is debug metrics are maintained in-memory in the active 
server. When "admin/debug/metrics" API call is accessed on the passive server, 
the request isn't redirected to the active server like it does for the other 
APIs, hence the passive node returns empty metrics.
Adding "admin/debug/metrics" to the list of adminUriNotFiltered, so that the 
API call gets redirected to active server.


Diffs
-

  webapp/src/main/java/org/apache/atlas/web/filters/ActiveServerFilter.java 
a1d30ba87 


Diff: https://reviews.apache.org/r/74180/diff/1/


Testing
---

Tested manually on a HA setup, with this change, when the "admin/debug/metrics" 
is sent to passive server, the request is redirected to active server and 
correct response is returned


Thanks,

Jayendra Parab



[jira] [Assigned] (ATLAS-4691) Discrepancy in the atlas debug metrics between the active and the not active servers

2022-10-24 Thread Jayendra Parab (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jayendra Parab reassigned ATLAS-4691:
-

Assignee: Jayendra Parab

> Discrepancy in the atlas debug metrics between the active and the not active 
> servers
> 
>
> Key: ATLAS-4691
> URL: https://issues.apache.org/jira/browse/ATLAS-4691
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 2.2.0
>Reporter: Jayendra Parab
>Assignee: Jayendra Parab
>Priority: Major
>
> There is a discrepancy in the atlas debug metrics between the active and the 
> not active servers.
> Steps to reproduce:
>  - Setup Atlas in HA mode with two instances of Atlas
>  - add "atlas.debug.metrics.enabled=true" to the Atlas configuration 
> (conf/atlas-application.properties_role_safety_valve)
>  - restart Atlas
>  - open Atlas and create a new entity (e.g. hdfs_path) 
>  - check the debug metrics on both atlas instances using API call: 
> https://:/api/atlas/admin/debug/metrics
>  - The active instance returns correct metrics, whereas passive instance 
> returns empty metrics
> The reason for this is that the debug metrics are maintained in-memory in the 
> active server. When "admin/debug/metrics" API call is accessed on the passive 
> server, the request isn't redirected to the active server like it does for 
> the other APIs, hence the passive node returns empty metrics.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (ATLAS-4691) Discrepancy in the atlas debug metrics between the active and the not active servers

2022-10-24 Thread Jayendra Parab (Jira)
Jayendra Parab created ATLAS-4691:
-

 Summary: Discrepancy in the atlas debug metrics between the active 
and the not active servers
 Key: ATLAS-4691
 URL: https://issues.apache.org/jira/browse/ATLAS-4691
 Project: Atlas
  Issue Type: Bug
  Components:  atlas-core
Affects Versions: 2.2.0
Reporter: Jayendra Parab


There is a discrepancy in the atlas debug metrics between the active and the 
not active servers.

Steps to reproduce:
 - Setup Atlas in HA mode with two instances of Atlas
 - add "atlas.debug.metrics.enabled=true" to the Atlas configuration 
(conf/atlas-application.properties_role_safety_valve)
 - restart Atlas
 - open Atlas and create a new entity (e.g. hdfs_path) 
 - check the debug metrics on both atlas instances using API call: 
https://:/api/atlas/admin/debug/metrics
 - The active instance returns correct metrics, whereas passive instance 
returns empty metrics

The reason for this is that the debug metrics are maintained in-memory in the 
active server. When "admin/debug/metrics" API call is accessed on the passive 
server, the request isn't redirected to the active server like it does for the 
other APIs, hence the passive node returns empty metrics.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)