Re: [DRAFT] [REPORT] Apache Atlas - September 2024

[Nikhil Bonte]

+1

Thanks Madhan for putting this together

On Thu, 12 Sep 2024 at 3:21 AM, Madhan Neethiraj  wrote:

> Atlas community,
>
>
>
> Please review the following draft report for this quarter.
>
>
>
> Thanks,
>
> Madhan
>
>
>
>
>
>
>
>
>
> ## Description:
>
> The mission of Apache Atlas is the creation and maintenance of software
> related
>
> to a scalable and extensible set of core foundational governance services
> -
>
> enabling enterprises to effectively and efficiently meet their compliance
>
> requirements
>
>
>
> ## Project Status:
>
> Current project status: Ongoing, with low activity
>
> Issues for the board: none
>
>
>
> ## Membership Data:
>
> Apache Atlas was founded 2017-06-20 (7 years ago)
>
> There are currently 48 committers and 32 PMC members in this project.
>
> The Committer-to-PMC ratio is 3:2.
>
>
>
> Community changes, past quarter:
>
> - No new PMC members. Last addition was Ashutosh Mestry on 2019-04-16.
>
> - No new committers. Last addition was Umesh Padashetty on 2023-06-14.
>
>
>
> ## Project Activity:
>
> - fixes and improvements in import functionality
>
> - performance improvement - utility to analyze hook notifications
>
> - improvements in notification processing
>
> - UI fixes in handling of deferred tasks
>
> - updated versions of dependent libraries
>
>
>
> ## Community Health:
>
> - dev@atlas.apache.org had a 21% decrease in traffic in the past quarter
> (235 emails compared to 296):
>
> - 10 commits in the past quarter, a decrease from 23 commits the previous
> quarter
>
> - 4 code contributors in the past quarter, a decrease from 7 in the
> previous quarter
>
> - 2 new contributors were added in the past quarter - Prashant Satam and
> Chandra Kanth Peravelli
>
>
>
> ## Recent releases:
>
> - Apache Atlas 2.3.0 was released on 2022-12-06.
>
> - Apache Atlas 2.2.0 was released on 2021-08-17.
>
> - Apache Atlas 2.1.0 was released on 2020-07-15.
>
>
>
>
>
>

Re: [DRAFT] [REPORT] Apache Atlas - June 2024

[Nikhil Bonte]

+1, Looks good, Thanks Madhan for putting this together



On Fri, 14 Jun 2024 at 5:52 AM, Madhan Neethiraj  wrote:

> Atlas community,
>
> Please review the following draft report for this quarter.
>
> Thanks,
> Madhan
>
>
> ## Description:
> The mission of Apache Atlas is the creation and maintenance of software
> related
> to a scalable and extensible set of core foundational governance services -
> enabling enterprises to effectively and efficiently meet their compliance
> requirements
>
> ## Project Status:
> Current project status: Ongoing, with low activity
> Issues for the board: there are no issues requiring board attention
>
> ## Membership Data:
> Apache Atlas was founded 2017-06-20 (7 years ago)
> There are currently 48 committers and 32 PMC members in this project.
> The Committer-to-PMC ratio is 3:2.
>
> Community changes, past quarter:
> - No new PMC members. Last addition was Ashutosh Mestry on 2019-04-16.
> - No new committers. Last addition was Umesh Padashetty on 2023-06-14.
>
> ## Project Activity:
> - improvements in Export/Import functionality
> - updates to support ignore patterns in all Atlas hooks
> - added support for Chinese characters in Atlas entity attributes
> - Docker setup update to address HBase failures
> - updated versions of dependent libraries JanusGraph and Tinkerpop
>
> ## Community Health:
> - dev@atlas.apache.org had a 166% increase in traffic in the past quarter
> (312
>   emails compared to 117)
> - 23 commits in the past quarter (64% increase)
> - 7 code contributors in the past quarter (40% increase)
> - 4 PRs opened on GitHub, past quarter (100% increase)
> - 2 PRs closed on GitHub, past quarter (100% increase)
>
> ## Recent releases:
> - Apache Atlas 2.3.0 was released on 2022-12-06
> - Apache Atlas 2.2.0 was released on 2021-08-17
> - Apache Atlas 2.1.0 was released on 2020-07-15
>
>
>
>
>

Re: [DRAFT] [REPORT] Apache Atlas - March 2024

[Nikhil Bonte]

Looks Good to me
Thanks Madhan for putting this together


Regards
Nikhil P. Bonte

On Wed, 13 Mar 2024 at 1:17 PM, Madhan Neethiraj  wrote:

> Atlas community,
>
> Please review the following draft report for this quarter.
>
> Thanks,
> Madhan
>
>
> ## Description:
> The mission of Apache Atlas is the creation and maintenance of software
> related
> to a scalable and extensible set of core foundational governance services
> -
> enabling enterprises to effectively and efficiently meet their compliance
> requirements
>
> ## Project Status:
> Current project status: Ongoing, with low activity
> Issues for the board: here are no issues requiring board attention.
>
> ## Membership Data:
> Apache Atlas was founded 2017-06-20 (7 years ago)
> There are currently 48 committers and 32 PMC members in this project.
> The Committer-to-PMC ratio is 3:2.
>
> Community changes, past quarter:
> - No new PMC members. Last addition was Ashutosh Mestry on 2019-04-16.
> - No new committers. Last addition was Umesh Padashetty on 2023-06-14.
>
> ## Project Activity:
> - fixes in download search results functionality
> - UI updates to improve usability of tag-propagation enable/disable
> - fix in business metadata changes to update system attributes
> - updated versions of Spring Security, netty
>
> ## Community Health:
> - dev@atlas.apache.org had a 40% decrease in traffic in the past quarter
> (143
>   emails compared to 238)
> - u...@atlas.apache.org had a 100% increase in traffic in the past
> quarter (8
>   emails compared to 4)
> - 10 commits in the past quarter (-73% change)
> - 6 code contributors in the past quarter (-50% change)
>
> ## Recent releases:
> - Apache Atlas 2.3.0 was released on 2022-12-06
> - Apache Atlas 2.2.0 was released on 2021-08-17
> - Apache Atlas 2.1.0 was released on 2020-07-15
>
>
>
>
>

Re: [DRAFT] [REPORT] Apache Atlas - December 2023

[Nikhil Bonte]

+1. Thanks for the draft Madhan


On Wed, 13 Dec 2023 at 10:55 PM, Madhan Neethiraj  wrote:

> Atlas community,
>
>
>
> Please review the following draft report for this quarter.
>
>
>
> Thanks,
>
> Madhan
>
>
>
> ## Description:
>
> The mission of Apache Atlas is the creation and maintenance of software
> related
>
> to a scalable and extensible set of core foundational governance services
> -
>
> enabling enterprises to effectively and efficiently meet their compliance
>
> requirements
>
>
>
> ## Project Status:
>
> Current project status: Ongoing, with moderate activity
>
> Issues for the board: There are no issues requiring board attention.
>
>
>
> ## Membership Data:
>
> Apache Atlas was founded 2017-06-20 (6 years ago)
>
> There are currently 48 committers and 32 PMC members in this project.
>
> The Committer-to-PMC ratio is 3:2.
>
>
>
> Community changes, past quarter:
>
> - No new PMC members. Last addition was Ashutosh Mestry on 2019-04-16.
>
> - No new committers. Last addition was Umesh Padashetty on 2023-06-14.
>
>
>
> ## Project Activity:
>
> - enhancements to support aging of entity audits
>
> - added bridge for Couchbase
>
> - performance improvement in notification processing with optimization in
>
>   fetching relationships
>
> - removed references to Python2 with Python3
>
> - improvements in dynamic index recovery
>
> - fixes in Impala hook
>
> - published Atlas client Python library 0.0.15
>
> - updated versions of Okio, Apache Ivy
>
>
>
> ## Community Health:
>
> - dev@atlas.apache.org had a 41% increase in traffic in the past quarter
> (247
>
>   emails compared to 174)
>
> - 17 issues opened in JIRA, past quarter (-48% change)
>
> - 14 issues closed in JIRA, past quarter (-30% change)
>
> - 33 commits in the past quarter (3% increase)
>
> - 11 code contributors in the past quarter (22% increase)
>
> - 2 PRs opened on GitHub, past quarter (-71% change)
>
> - 4 PRs closed on GitHub, past quarter (no change)
>
>
>
> ## Recent releases:
>
> Apache Atlas 2.3.0 was released on 2022-12-06.
>
> Apache Atlas 2.2.0 was released on 2021-08-17.
>
> Apache Atlas 2.1.0 was released on 2020-07-15.
>
>
>
>
>
>

Re: [DRAFT] [REPORT] Apache Atlas - June 2023

[Nikhil Bonte]

+1 for the draft

Thanks, Madhan for the drafting

Regards
Nikhil P. Bonte

On Thu, Jun 15, 2023 at 11:45 AM Nixon Rodrigues  wrote:

> +1 for the draft report.
>
> Thanks Madhan for putting this together for review
>
> Thanks and Regards
> Nixon
>
> On Thu, 15 Jun 2023 at 04:06, Madhan Neethiraj  wrote:
>
> > Atlas community,
> >
> >
> >
> > Please review the following draft report for this quarter.
> >
> >
> >
> > Thanks,
> >
> > Madhan
> >
> >
> >
> >
> >
> > ## Description:
> >
> > The mission of Apache Atlas is the creation and maintenance of software
> > related
> >
> > to a scalable and extensible set of core foundational governance services
> > -
> >
> > enabling enterprises to effectively and efficiently meet their compliance
> >
> > requirements
> >
> >
> >
> > ## Project Status:
> >
> > Current project status: Ongoing, with moderate activity
> >
> > Issues for the board: There are no issues requiring board attention.
> >
> >
> >
> > ## Membership Data:
> >
> > Apache Atlas was founded 2017-06-20 (6 years ago)
> >
> > There are currently 48 committers and 32 PMC members in this project.
> >
> > The Committer-to-PMC ratio is roughly 3:2.
> >
> >
> >
> > Community changes, past quarter:
> >
> > - No new PMC members. Last addition was Ashutosh Mestry on 2019-04-16.
> >
> > - One new committers. Last addition was Umesh Padashetty on 2023-06-13.
> >
> >
> >
> > ## Project Activity:
> >
> > - released Python client 0.0.14
> >
> > - updated versions of Storm, JanusGraph, TinkerPop
> >
> > - added APIs to download search results to file; updated UI to download
> > results
> >
> > - Hive hook fix in handling of notifications having an entity in both
> > inputs
> >
> > - support building Atlas using JDK versions higher than 8
> >
> > - UI updates to remove unused libraries from build package
> >
> >
> >
> > ## Community Health:
> >
> > - dev@atlas.apache.org had a 46% increase in traffic in the past quarter
> > (226
> >
> >   emails compared to 154)
> >
> > - 29 issues opened in JIRA, past quarter (61% increase)
> >
> > - 11 issues closed in JIRA, past quarter (no change)
> >
> > - 33 commits in the past quarter (6% increase)
> >
> > - 11 code contributors in the past quarter (57% increase)
> >
> >
> >
> > ## Most Recent releases:
> >
> > 2.3.0 was released on 2022-12-06
> >
> > 2.2.0 was released on 2021-08-17
> >
> > 2.1.0 was released on 2020-07-15
> >
> > 0.8.4 was released on 2019-06-21
> >
> >
> >
> >
>

Re: [DRAFT] [REPORT] Apache Atlas - December 2022

[Nikhil Bonte]

+1, LGTM

Thanks, Madhan for putting this together

Regards
Nikhil P. Bonte

On Sat, Dec 10, 2022 at 2:28 PM Madhan Neethiraj  wrote:

> Atlas community,
>
> Please review the following draft report for this quarter.
>
> Thanks,
> Madhan
>
> ## Description:
> The mission of Apache Atlas is the creation and maintenance of software
> related
> to a scalable and extensible set of core foundational governance services
> -
> enabling enterprises to effectively and efficiently meet their compliance
> requirements
>
> ## Issues:
> There are no issues requiring board attention.
>
> ## Membership Data:
> Apache Atlas was founded 2017-06-20 (5 years ago)
> There are currently 47 committers and 32 PMC members in this project.
> The Committer-to-PMC ratio is roughly 3:2.
>
> Community changes, past quarter:
> - No new PMC members. Last addition was Ashutosh Mestry on 2019-04-16.
> - Mandar Ambawane was added as committer on 2022-09-12
> - Prasad Pawar was added as committer on 2022-09-12
> - 5 new Atlas contributors in last quarter:
>   - Sheetal Shah, zhuangchong, yanxu3, Maxim Martynov, Dov Benyomin
> Sohacheski
>
> ## Project Activity:
> - the community released Apache Atlas 2.3.0
> - released Python client 0.0.12
> - New feature: relationship search API and UI
> - docker setup fixes for Kafka bridge
> - fixes in import-hbase and import-kafka utilities
> - updated versions of commons-text and commons-configuration2 libraries
> - multiple UI component version updates: scss-tokenizer, node-sass,
>   loader-utils, Snake-yaml
> - updated Hive version from 3.1.0 to 3.1.2
> - multiple UI fixes
>
>
> ## Community Health:
> - dev@atlas.apache.org had a 22% decrease in traffic in the past quarter
> (680
>   emails compared to 868)
> - u...@atlas.apache.org had a 37% decrease in traffic in the past quarter
> (12
>   emails compared to 19)
> - 46 issues opened in JIRA, past quarter (-16% change)
> - 47 issues closed in JIRA, past quarter (30% increase)
> - 104 commits in the past quarter (70% increase)
> - 17 code contributors in the past quarter (30% increase)
> - 22 PRs opened on GitHub, past quarter (29% increase)
> - 41 PRs closed on GitHub, past quarter (485% increase)
>
> ## Most Recent releases:
> 2.3.0 was released on 2022-12-06
> 2.2.0 was released on 2021-08-17
> 2.1.0 was released on 2020-07-15
> 0.8.4 was released on 2019-06-21
>
>
>
>

Re: [VOTE] Release Apache Atlas 2.3.0 rc1

[Nikhil Bonte]

+1 for the Apache Atlas 2.3.0 release candidate #1.

Performed Following:
- Able to download source, signature, md5 and sha512 files and verify the
checksum hash

- Build the source successfully using embedded-hbase-solr profile


Thanks
Nikhil P. Bonte

On Sun, Dec 4, 2022 at 4:17 AM Ramesh Mani  wrote:

> +1 for the Apache Atlas 2.3.0 release candidate #1.
>
>   Verified Build in CentOS7
>  /apache-maven-3.8.6/bin/mvn clean -DskipTests
> -Dmaven.wagon.http.ssl.insecure=true -Dmaven.wagon.http.ssl.allowall=true
> -Dmaven.wagon.http.ssl.ignore.validity.dates=true install
>  Verified Signature
>  gpg --verify apache-atlas-2.3.0-sources.tar.gz.asc
> gpg: Signature made Mon 28 Nov 2022 09:14:22 PM UTC using RSA
> key ID B01179D4
> gpg: Good signature from "Madhan Neethiraj  >"
> gpg: WARNING: This key is not certified with a trusted
> signature!
>  gpg:  There is no indication that the signature
> belongs to the owner.
> Primary key fingerprint: 0524 DD1F 7940 6654 6D61  0744 FED4 67D3 B011 79D4
>
>  Verified  SHA256 and SHA512
>  openssl dgst -sha256 apache-atlas-2.3.0-sources.tar.gz
> SHA256(apache-atlas-2.3.0-sources.tar.gz)=
> d56b89edd0499f109488b1d8394ec3f4f23609b9ea29a5099c473e84ec7e91c0
>
> openssl dgst -sha512 apache-atlas-2.3.0-sources.tar.gz
>SHA512(apache-atlas-2.3.0-sources.tar.gz)=
>
>  
> b24c9785f601b4644090ef0b4c16974fc572100b61f04ef2d6c68fdaa45293e902483f3574342a0e70c54f757c509d3d7ec6a85e494599b1018c65d8126d3480
>
> Thanks,
> Ramesh
>
>
> [root@rmani-7216-1 tmp]# gpg --verify apache-atlas-2.3.0-sources.tar.gz.as
>
> On Mon, Nov 28, 2022 at 1:30 PM Madhan Neethiraj 
> wrote:
>
> > Atlas team,
> >
> >
> >
> > Apache Atlas 2.3.0 release candidate #1 is now available for a vote
> within
> > dev community. Links to the release artifacts are given below. Please
> > review and vote.
> >
> >
> >
> > The vote will be open for at least 72 hours or until necessary votes are
> > reached.
> >
> >   [ ] +1 approve
> >
> >   [ ] +0 no opinion
> >
> >   [ ] -1 disapprove (and reason why)
> >
> >
> >
> > Thanks,
> >
> > Madhan
> >
> >
> >
> >
> >
> > List of issues addressed in this release:
> >
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20Atlas%20AND%20fixVersion%20%3D%202.3.0%20ORDER%20BY%20key%20DESC
> >
> >
> >
> > Git tag for the release:
> > https://github.com/apache/atlas/tree/release-2.3.0-rc1
> >
> >
> >
> > Sources for the release:
> >
> https://dist.apache.org/repos/dist/dev/atlas/2.3.0-rc1/apache-atlas-2.3.0-sources.tar.gz
> >
> >
> >
> > Source release verification:
> >
> >   PGP Signature:
> >
> https://dist.apache.org/repos/dist/dev/atlas/2.3.0-rc1/apache-atlas-2.3.0-sources.tar.gz.asc
> >
> >   MD5 Hash:
> >
> https://dist.apache.org/repos/dist/dev/atlas/2.3.0-rc1/apache-atlas-2.3.0-sources.tar.gz.md5
> >
> >
> >
> > Keys to verify the signature of the release artifacts are available at:
> > https://dist.apache.org/repos/dist/dev/atlas/KEYS
> >
> >
>

Re: [DRAFT] [REPORT] Apache Atlas - September 2022

[Nikhil Bonte]

Thanks for putting this together Madhan.

+1

Regards
Nikhil P. Bonte

On Mon, Sep 19, 2022 at 11:45 AM Chaitali Borole <
chaitali.bor...@freestoneinfotech.com> wrote:

> Thanks Madhan, looks good to me.
> +1
>
> Thanks,
> Chaitali
>
> On Wed, Sep 14, 2022 at 8:45 AM Madhan Neethiraj 
> wrote:
>
> > Atlas community,
> >
> >
> >
> > Please review the following draft report for this quarter.
> >
> >
> >
> > Thanks,
> >
> > Madhan
> >
> >
> >
> > ## Description:
> >
> > The mission of Apache Atlas is the creation and maintenance of software
> > related
> >
> > to a scalable and extensible set of core foundational governance
> services -
> >
> > enabling enterprises to effectively and efficiently meet their compliance
> >
> > requirements
> >
> >
> >
> > ## Issues:
> >
> > There are no issues requiring board attention.
> >
> >
> >
> > ## Membership Data:
> >
> > Apache Atlas was founded 2017-06-20 (5 years ago) There are currently 47
> >
> > committers and 32 PMC members in this project. The Committer-to-PMC ratio
> > is
> >
> > roughly 3:2.
> >
> >
> >
> > Community changes, past quarter:
> >
> > - No new PMC members. Last addition was Ashutosh Mestry on 2019-04-16.
> >
> > - Mandar Ambawane was added as committer on 2022-09-12
> >
> > - Prasad Pawar was added as committer on 2022-09-12
> >
> > - 4 new Atlas contributors in last quarter:
> >
> >   - Abhishek Pal, Kundan Kumar Jha, Patrik Marton, Beakal Lemeneh
> >
> >
> >
> > ## Project Activity:
> >
> > - fixes in search API handling of pagination
> >
> > - updates to support authenticated Cassandra cluster as audit repository
> >
> > - performance improvements in Atlas lineage API and UI
> >
> > - removed Kafka core dependency in Atlas webapp
> >
> > - improvements in import-hive utility to delete entities for deleted
> > objects
> >
> >   in Hive
> >
> > - multiple UI fixes and improvements
> >
> > - dependent component version updates: Spring Framework 5.3.21, Spring
> >
> >   Security 5.7.2, Netty Project 4.1.78.Final, POI 5.2.2, JUnit 4.13.2
> >
> > - started a thread on Atlas 2.4.0 release. Looking to complete release by
> >
> >   October 2022
> >
> >
> >
> >
> >
> > ## Community Health:
> >
> > - dev@atlas.apache.org had a 22% decrease in traffic in the past quarter
> > (680
> >
> >   emails compared to 868)
> >
> > - u...@atlas.apache.org had a 37% decrease in traffic in the past
> quarter
> > (12
> >
> >   emails compared to 19)
> >
> > - 48 issues opened in JIRA, past quarter (-12% change)
> >
> > - 29 issues closed in JIRA, past quarter (38% increase)
> >
> > - 51 commits in the past quarter (-15% change)
> >
> > - 13 code contributors in the past quarter (8% increase)
> >
> > - 16 PRs opened on GitHub, past quarter (-40% change)
> >
> > - 7 PRs closed on GitHub, past quarter (no change)
> >
> >
> >
> > ## Most Recent releases:
> >
> > 2.2.0 was released on 2021-08-17
> >
> > 2.1.0 was released on 2020-07-15
> >
> > 0.8.4 was released on 2019-06-21
> >
> >
>

Re: Review Request 74101: ATLAS-4668 : When classification is created with multiple super types having same attributes , Atlas doesn't throw an exception

[Nikhil Bonte]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74101/#review224645
---




intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java
Lines 564 (patched)
<https://reviews.apache.org/r/74101/#comment313448>

attributeToClassificationNameMap.containsKey(attributeName)

I think having only this check is enough to identify duplicate attribute 
name from different parent defs

Also, if above statement is true, map allAttributes can be used instead 
defining another map called attributeToClassificationNameMap


- Nikhil Bonte


On Sept. 6, 2022, 11:06 a.m., Mandar Ambawane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74101/
> ---
> 
> (Updated Sept. 6, 2022, 11:06 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, madhan, Pinal Shah, Radhika Kundam, 
> Sheetal Shah, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-4668
> https://issues.apache.org/jira/browse/ATLAS-4668
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> When an entity type is created with multiple super types having same 
> attribute name, Atlas throws exception.
> 
> Ex:
> 
> if there are 2 types:
> 
> type1 - attr1, attr2
> 
> type2- attr1, attr2
> 
> Both types cant be added to super type to type3 since both type1 and type2 
> have same attribute - attr1
> 
> This patch will check for the exact scenario in case of Classification 
> Typedef as well.
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
> 5b86b808b 
> 
> 
> Diff: https://reviews.apache.org/r/74101/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>

Re: [DRAFT] [REPORT] Apache Atlas - July 2022

[Nikhil Bonte]

+1
Thanks Madhan for putting this together.

Regards
Nikhil P. Bonte

On Mon, Jul 11, 2022, 10:56 PM Ashutosh Mestry  wrote:

> +1
>
> Thanks for taking care of this!
>
> ~ ashutosh
>
> On 2022/07/11 05:45:50 Madhan Neethiraj wrote:
> > Atlas community,
> >
> > Please review the following draft report for this quarter.
> >
> > Thanks,
> > Madhan
> >
> > ## Description:
> > The mission of Apache Atlas is the creation and maintenance of software
> related
> > to a scalable and extensible set of core foundational governance
> services -
> > enabling enterprises to effectively and efficiently meet their
> compliance
> > requirements
> >
> > ## Issues:
> > There are not issues requiring board attention.
> >
> > ## Membership Data:
> > Apache Atlas was founded 2017-06-20 (5 years ago)
> > There are currently 45 committers and 32 PMC members in this project.
> > The Committer-to-PMC ratio is roughly 3:2.
> >
> > Community changes, past quarter:
> > - No new PMC members. Last addition was Ashutosh Mestry on 2019-04-16.
> > - No new committers. Last addition was Radhika Kundam on 2022-02-04.
> >
> > ## Project Activity:
> > - resolved failures with Atlas HA with index-recovery enabled
> > - notification message processing improvements to enable server and
> hooks to
> >   be of different versions
> > - Kafka importer utility improvements
> > - Impala hook fix to handle large query string
> > - Glossary module performance improvements to handle glossaries with
> large
> >   number of categories and terms
> > - import zip functionality improvements
> > - several UI enhancements/fixes
> > - dependent component version updates: Spring 5.3.20, jQuery-UI 1.13.0,
> netty
> >   4.1.77, Spring security 5.7.1, gson 2.9.0
> >
> > ## Community Health:
> > - dev@atlas.apache.org had a 22% decrease in traffic in the past
> quarter (680
> >   emails compared to 868)
> > - u...@atlas.apache.org had a 37% decrease in traffic in the past
> quarter (12
> >   emails compared to 19)
> > - 48 issues opened in JIRA, past quarter (-12% change)
> > - 24 issues closed in JIRA, past quarter (-20% change)
> > - 48 commits in the past quarter (-27% change)
> > - 11 code contributors in the past quarter (-15% change)
> > - 24 PRs opened on GitHub, past quarter (20% increase)
> > - 11 PRs closed on GitHub, past quarter (450% increase)
> >
> > ## Most Recent releases:
> > 2.2.0 was released on 2021-08-17
> > 2.1.0 was released on 2020-07-15
> > 0.8.4 was released on 2019-06-21
> >
> >
> >
> >
>

Re: Review Request 73974: ATLAS-4614 :- Atlas - Deferred Actions : Add classification name in response

[Nikhil Bonte]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73974/#review224514
---


Ship it!




Ship It!

- Nikhil Bonte


On June 16, 2022, 10:30 a.m., Paresh Devalia wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73974/
> ---
> 
> (Updated June 16, 2022, 10:30 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Mandar Ambawane, and Pinal Shah.
> 
> 
> Bugs: ATLAS-4614
> https://issues.apache.org/jira/browse/ATLAS-4614
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> In /api/atlas/admin/tasks call , when a tag is propagated , the 
> classificationVertexId is displayed. It becomes tough to debug when there are 
> many pending tasks . classification name can be added in the response in 
> addition to/instead of classificationVertexId.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
>  6964211e9 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  9a7f29017 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/tasks/ClassificationTask.java
>  0bad84e49 
> 
> 
> Diff: https://reviews.apache.org/r/73974/diff/4/
> 
> 
> Testing
> ---
> 
> Manual testing is done.
> 
> Pre-commit : 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1096/consoleFull
> 
> Created 1000  hive_tables dependant on parent table.
> Hive_tables name will be sequence_1 to sequence_999
> 
> Below step are tested for add, update and delete classification.
> 
> 1) Adding classification :- 
>   Create a classification with name test_1.
>   Added test_1 classification with checked on "propagate" of 
> sequence_1 hive_table, so this classification will be assign to all child 
> table.
>   So while background process is going on, will check the task 
> status API.
>   curl k -u :  -request GET 
> 'https://:/api/atlas/admin/tasks'
>   so in response will be
>   [
>   {
>   "type": 
> "CLASSIFICATION_PROPAGATION_ADD",
>   "guid": 
> "39f68061-2c5b-4e0c-9ba6-65b3d8117e99",
>   "createdBy": "admin",
>   "createdTime": 1651591949394,
>   "updatedTime": 1651591949394,
>   "parameters": {
>   "relationshipGuid": null,
>   "classificationName": "test_1",
>   "entityGuid": 
> "29a5ac89-a3fb-46ff-bbb1-646d3b0717dd",
>   "classificationVertexId": 
> "122896440"
>   },
>   "attemptCount": 0,
>   "status": "PENDING"
>   }
>   ]
>   
> 2)Updating classification attribute value:-
>   Creating attribute for test_1 classification.
>   Updating classification attribute value on sequence_1 
> hive_table, then in background process it will update all the child table 
> attribute value.
>   So while background process is going on, will check the task 
> status API.
>   curl k -u :  -request GET 
> 'https://:/api/atlas/admin/tasks' 
>   so in response will be
>   [
>   {
>   "type": 
> "CLASSIFICATION_PROPAGATION_ADD",
>   "guid": 
> "39f68061-2c5b-4e0c-9ba6-65b3d8117e99",
>   "createdBy": "admin",
>   "createdTime": 1651591949394,
>   "updatedTime": 1651591949394,
>  

Re: Review Request 74027: ATLAS-4622: import fix to handle invalid zip entry

[Nikhil Bonte]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74027/#review224512
---


Ship it!




Ship It!

- Nikhil Bonte


On June 16, 2022, 5:41 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74027/
> ---
> 
> (Updated June 16, 2022, 5:41 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nikhil Bonte, 
> Nixon Rodrigues, Pinal Shah, Radhika Kundam, Sarath Subramanian, Sharmadha 
> Sainath, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-4622
> https://issues.apache.org/jira/browse/ATLAS-4622
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> updated to fail import operation when invalid zip entries were found
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 6ca933ff9 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ZipSourceWithBackingDirectory.java
>  79638009d 
> 
> 
> Diff: https://reviews.apache.org/r/74027/diff/1/
> 
> 
> Testing
> ---
> 
> - verified that import fails on detecting entries with names having relative 
> path to parent directory
> - pre-commit tests run 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1122/
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Re: [DRAFT] [REPORT] Apache Atlas - March 2022

[Nikhil Bonte]

+1, Looks good.
Thanks Madhan for putting this together

Regards
Nikhil P Bonte

On Wed, Mar 9, 2022, 4:08 AM Madhan Neethiraj  wrote:

> Atlas community,
>
>
>
> Please review the following draft report for this quarter.
>
>
>
> Thanks,
>
> Madhan
>
>
>
>
>
>
>
> ## Description:
>
> The mission of Apache Atlas is the creation and maintenance of software
>
> related to a scalable and extensible set of core foundational governance
>
> services - enabling enterprises to effectively and efficiently meet their
>
> compliance requirements
>
>
>
> ## Issues:
>
> There are no issues requiring board attention.
>
>
>
> ## Membership Data:
>
> Apache Atlas was founded 2017-06-20 (5 years ago). There are currently 45
>
> committers and 32 PMC members in this project. The Committer-to-PMC ratio
> is
>
> roughly 3:2.
>
>
>
> Community changes, past quarter:
>
> - No new PMC members. Last addition was Ashutosh Mestry on 2019-04-16.
>
> - Radhika Kundam was added as committer on 2022-02-04
>
>
>
> ## Project Activity:
>
> - added build profile for Cassandra and Elastic Search stores
>
> - UI fixes to handle glossary with large number of terms
>
> - multiple fixes in search feature and UI
>
> - updated docker setup to use network name
>
> - updated monitoring to support Elastic Search index backend
>
> - updated Hive hook to support Ozone file scheme for external tables
>
> - fixed failure in Atlas startup in HA mode with index recovery enabled
>
> - dependent component version updates: JanusGraph 0.6.1, TinkerPop 3.5.2,
>
>   Spring framework 5.3.15, log4j 2.17.1, testng 7.0, underscore.js 1.12.1
>
>
>
> ## Community Health:
>
> - dev@atlas.apache.org had a 22% decrease in traffic in the past quarter
> (680
>
>   emails compared to 868)
>
> - u...@atlas.apache.org had a 37% decrease in traffic in the past quarter
> (12
>
>   emails compared to 19)
>
> - 61 issues opened in JIRA, past quarter (-27% change)
>
> - 29 issues closed in JIRA, past quarter (-51% change)
>
> - 56 commits in the past quarter (-53% change)
>
> - 13 code contributors in the past quarter (-27% change)
>
> - 9 PRs opened on GitHub, past quarter (12% increase)
>
> - 2 PRs closed on GitHub, past quarter (-50% change)
>
>
>
> ## Most Recent releases:
>
> 2.2.0 was released on 2021-08-17
>
> 2.1.0 was released on 2020-07-15
>
> 0.8.4 was released on 2019-06-21
>
>
>
>
>
>

Re: Alation Users/Accounts

[Nikhil Bonte]

Hi Anna,

I am not in any way related to Alation...
I work for a different organisation.


Thanks

On Mon, Feb 28, 2022 at 8:14 PM Anna Loran  wrote:

> Hello,
>
> Just Following up on the previous email which I sent regarding Alation
> customers information.
>
> Please let me know if you have any queries.
>
> Best regards,
> Anna
>
>
> On Thu, Feb 24, 2022 at 11:25 AM Anna Loran 
> wrote:
>
> > Hi,
> >
> >
> >
> > Your profile stood out to me as the person to speak with about the
> current
> > strategy. Do you have any interest in acquiring contact details of*
> > Alation AmoCRM*users/customers?
> >
> >
> >
> > We also have validated datasets of: Informatica, Alteryx, Collibra,
> > SolarWinds, Egnyte, Segment, Denodo, Dataedo and many more.
> >
> >
> >
> > I’m assuming you’re the best person for this – if not, who would you
> > recommend I speak with?
> >
> >
> >
> > Have a great day!
> >
> > Anna Loran
> > Demand Generation Specialist
> > If you do not wish to receive our email, please include the words DND or
> > Unsubscribe in the subject line or body of replying email.
> >
>

Re: [DRAFT] [REPORT] Apache Atlas - Dec-2021

[Nikhil Bonte]

Thanks Madhan for putting this together.

Report looks good to me.

Regards,
Nikhil P. Bonte

On Wed, Dec 8, 2021, 9:52 PM Sarath Subramanian  wrote:

> Thanks Madhan for the draft report.
>
> +1
>
>
> Thanks,
> Sarath
>
> On Wed, Dec 8, 2021 at 1:20 AM Madhan Neethiraj  wrote:
>
> > Atlas community,
> >
> > Please review the following draft report for this quarter.
> >
> > Thanks,
> > Madhan
> >
> > ## Description:
> > The mission of Apache Atlas is the creation and maintenance of software
> > related
> > to a scalable and extensible set of core foundational governance services
> > -
> > enabling enterprises to effectively and efficiently meet their compliance
> > requirements
> >
> > ## Issues:
> > There are no issues requiring board attention.
> >
> > ## Membership Data:
> > Apache Atlas was founded 2017-06-20 (4 years ago)
> > There are currently 44 committers and 32 PMC members in this project.
> > The Committer-to-PMC ratio is roughly 3:2.
> >
> > Community changes, past quarter:
> > - No new PMC members. Last addition was Ashutosh Mestry on 2019-04-16.
> > - No new committers. Last addition was Sidharth Mishra on 2021-04-19.
> >
> > ## Project Activity:
> > - enhanced hook messages to capture hook messages and message source
> > - updated quick search to support sorting
> > - added metrics persistence to retrieve historical data
> > - UI: updated term details page to add additional attributes
> > - UI: chart representation of metrics data
> > - UI: implemented session timeout
> > - performance improvement in glossary bulk import
> > - fixes in index health monitor
> > - Dependent component version updates: JanusGraph 0.6.0, Apache Strom
> > 2.3.0, Elastic search 6.8.17, Apache Kafka 2.8.1, netty 4.1.69, Junit
> > 4.13.1, jackson 2.11.0, commons-io 2.11.0, Spring Security 5.4.4
> >
> > ## Community Health:
> > - dev@atlas.apache.org had a 10% decrease in traffic in the past quarter
> > (798
> > emails compared to 881)
> > - u...@atlas.apache.org had a 45% decrease in traffic in the past
> quarter
> > (10
> > emails compared to 18)
> > - 87 issues opened in JIRA, past quarter (3% increase)
> > - 56 issues closed in JIRA, past quarter (-43% change)
> > - 111 commits in the past quarter (-5% change)
> > - 15 code contributors in the past quarter (-34% change)
> > - 7 PRs opened on GitHub, past quarter (no change)
> > - 3 PRs closed on GitHub, past quarter (-50% change)
> >
> > ## Most Recent releases:
> >  2.2.0 was released on 2021-08-17
> >  2.1.0 was released on 2020-07-15
> >  0.8.4 was released on 2019-06-21
> >
> >
> >
>

Re: Creating entity types

[Nikhil Bonte]

You need to set a property '*atlas.ui.editable.entity.types'* which accepts
comma separated typeNames or * to show all types in dropdown

On Fri, Oct 29, 2021 at 12:58 PM Pierre Smits 
wrote:

> Hi all,
>
> I am trying to create, via the UI (the web application/interface), new
> entity types. But the only thing I can select from the drop down is the
> 'hdfs_path'.
>
> Is that an bug? Or am I missing something in a configuration?
>
> Met vriendelijke groet,
>
> Pierre Smits
> *Proud* *contributor** of* Apache OFBiz  since
> 2008 (without privileges)
>
> *Apache Directory , PMC Member*
> Apache Incubator , committer
> Apache Steve , committer
>

Re: Review Request 73642: ATLAS-1558 Running Quickstart V2 multiple times throws an exception type already exists

[Nikhil Bonte]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73642/#review223693
---




webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java
Line 227 (original), 225 (patched)
<https://reviews.apache.org/r/73642/#comment312799>

Suggestion:
If this exception happens, can we run DSL search queries directly assuming 
that types & entities are already created
OR
We can accept a flag from script to allow just running DSL queries 
explicitly assuming that types & entities are already created


- Nikhil Bonte


On Oct. 29, 2021, 12:57 p.m., Shraddha Pardeshi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73642/
> ---
> 
> (Updated Oct. 29, 2021, 12:57 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Mandar Ambawane, and Pinal Shah.
> 
> 
> Bugs: ATLAS-1558
> https://issues.apache.org/jira/browse/ATLAS-1558
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> When you try to run QuickStart V2 multiple times, after the first succesfull 
> run, it throws exception that types already exists. QuickStart should exit 
> gracefully with types already exist message.
> 
> 
> Diffs
> -
> 
>   webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java 5309d1993 
> 
> 
> Diff: https://reviews.apache.org/r/73642/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Shraddha Pardeshi
> 
>

Re: Review Request 73599: Conditionally Disable 'Session Inactivity Timeout'

[Nikhil Bonte]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73599/#review223522
---


Ship it!




Ship It!

- Nikhil Bonte


On Sept. 23, 2021, 2:05 a.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73599/
> ---
> 
> (Updated Sept. 23, 2021, 2:05 a.m.)
> 
> 
> Review request for atlas, Nikhil Bonte, Nixon Rodrigues, Prasad Pawar, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4435
> https://issues.apache.org/jira/browse/ATLAS-4435
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Please see JIRA for details.
> 
> Additional info:
> * UI pop-up dialog looks at the value passed in the response of 
> 'admin/session' REST endpoint. Not passing the configuration value, disables 
> the feature from UI (Smart!).
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/AtlasConfiguration.java fa519ef5a 
>   
> webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java
>  b8d21b9bb 
>   webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
> baa040f4c 
>   
> webapp/src/main/java/org/apache/atlas/web/security/AtlasAuthenticationSuccessHandler.java
>  1b1a80826 
> 
> 
> Diff: https://reviews.apache.org/r/73599/diff/3/
> 
> 
> Testing
> ---
> 
> Manual testing:
> * Verified against Knox SSO enabled cluster.
> * User-name password enabled cluster.
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Re: [DRAFT] [REPORT] Apache Atlas - Sep-2021

[Nikhil Bonte]

Madhan

Thanks for the report, looks good to me.


Regards
Nikhil P Bonte

On Fri, 10 Sep, 2021, 9:30 am Nixon Rodrigues,  wrote:

> Madhan,
>
> Thanks for putting the draft for review.
>
> It Looks good to me.
>
> Regards,
> Nixon
>
> On Fri, 10 Sept 2021 at 06:51, Madhan Neethiraj  wrote:
>
> > Atlas community,
> >
> > Please review the following draft report for this quarter.
> >
> > Thanks,
> > Madhan
> >
> >
> > ## Description:
> > The mission of Apache Atlas is the creation and maintenance of software
> > related
> > to a scalable and extensible set of core foundational governance services
> > -
> > enabling enterprises to effectively and efficiently meet their compliance
> > requirements
> >
> > ## Issues:
> > There are no issues requiring board attention at this time.
> >
> > ## Membership Data:
> > Apache Atlas was founded 2017-06-20 (4 years ago)
> > There are currently 44 committers and 32 PMC members in this project.
> > The Committer-to-PMC ratio is roughly 3:2.
> >
> > Community changes, past quarter:
> > - No new PMC members. Last addition was Ashutosh Mestry on 2019-04-16.
> > - No new committers. Last addition was Sidharth Mishra on 2021-04-19.
> >
> > ## Project Activity:
> > - Apache Atlas 2.2.0 was released on 2021-08-17. This release includes
> >   significant improvements and fixes, more than 220 JIRAs
> > - DSL search enhancements to enable search using classification
> attributes
> > - Dependent component version updates: Kafka 2.5, curator 4.3.0,
> >   nimbus-jose-jwt 9.8.1, commons-io 2.8.0, JUnit 4.13.1
> > - Apache Kafka hook improvements
> > - Apache Hive hook fixes and improvements
> > - updates to support Apache Flink types
> > - Python client improvements
> > - UI improvements
> >
> >
> > ## Community Health:
> > - the community was focused on releasing Apache Atlas 2.2.0, after a year
> > in
> >   development
> > - dev@atlas.apache.org had a 27% decrease in traffic in the past quarter
> > (926
> >   emails compared to 1258)
> > - 85 issues opened in JIRA, past quarter (-36% change)
> > - 97 issues closed in JIRA, past quarter (-18% change)
> > - 102 commits in the past quarter (-52% change)
> > - 21 code contributors in the past quarter (-12% change)
> > - 6 PRs opened on GitHub, past quarter (-45% change)
> > - 6 PRs closed on GitHub, past quarter (-50% change)
> >
> > ## Most recent releases:
> >   2.2.0  was released on 08/17/2020
> >   2.1.0  was released on 07/16/2020
> >   0.8.4  was released on 06/21/2019
> >   1.2.0  was released on 06/12/2019
> >
> >
> >
> >
> >
> >
>

Re: Not able assign apache jira

[Nikhil Bonte]

Jira id - nbonte

Regards
Nikhil P. Bonte


On Wed, Aug 25, 2021 at 8:54 PM Nikhil Bonte <
nikhil.bo...@freestoneinfotech.com> wrote:

> Hi,
>
> I am not able to assign Jira to myself.
> Jira id - *nbonte**.*
>
> Regards
> Nikhil P. Bonte
>

Not able assign apache jira

[Nikhil Bonte]

Hi,

I am not able to assign Jira to myself.
Jira id - *nbonte**.*

Regards
Nikhil P. Bonte

Re: Review Request 73494: ATLAS-4376 : AtlasClientV2 getRelationshipDefByName does not work

[Nikhil Bonte]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73494/#review223388
---


Ship it!




Ship It!

- Nikhil Bonte


On Aug. 4, 2021, 5:08 p.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73494/
> ---
> 
> (Updated Aug. 4, 2021, 5:08 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Nikhil Bonte, Nixon Rodrigues, 
> Pinal Shah, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4376
> https://issues.apache.org/jira/browse/ATLAS-4376
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> When tried to get the typedef of a relationship by:
> 
> atlasClient.getRelationshipDefByName(name)
> This will get translated into the following REST request: 
> /api/atlas/v2/types/structdef/name/
> 
> {name}
> 
> The correct REST request should be: 
> /api/atlas/v2/types/relationshipdef/name/{name}
> The reason why it's querying a structdef and not a relationshipdef is due to 
> a bug in AtlasClientV2 line 1135:
> 
> } else if (AtlasStructDef.class.isAssignableFrom(typeDefClass))
> 
> { return "structdef"; }
> else if (AtlasRelationshipDef.class.isAssignableFrom(typeDefClass)) {
> return "relationshipdef";
> Since AtlasRelationshipDef extends AtlasStructDef, the first "if" branch will 
> always be true and the second "if" branch will never happen. The fix for this 
> issue is to reverse the two "if" branches.
> 
> provide test cases for all "if" branches to ensure the querying works 
> correctly
> 
> 
> Diffs
> -
> 
>   client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 
> eb0e630f9 
>   client/client-v2/src/test/java/org/apache/atlas/AtlasClientV2Test.java 
> 83a3391eb 
> 
> 
> Diff: https://reviews.apache.org/r/73494/diff/2/
> 
> 
> Testing
> ---
> 
> mvn clean install -Drat.skip
> mvn clean package -Pdist,embedded-hbase-solr -DskipTests -Drat.skip
> testcases added
> 
> 
> Thanks,
> 
> chaitali
> 
>

Re: Review Request 73508: ATLAS-4233 [Atlas: Audits] When a term is added or removed, v1 api displays action as null instead of TERM_ADD or TERM_DELETE

[Nikhil Bonte]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73508/#review223345
---


Ship it!




Ship It!

- Nikhil Bonte


On Aug. 10, 2021, 11:39 a.m., Shraddha Pardeshi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73508/
> ---
> 
> (Updated Aug. 10, 2021, 11:39 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Nikhil Bonte, Nixon Rodrigues, and 
> Pinal Shah.
> 
> 
> Bugs: ATLAS-4233
> https://issues.apache.org/jira/browse/ATLAS-4233
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> When we add or remove a term to an entity,in audits the action should appear 
> as TERM_ADD or TERM_DELETE
> But instead the value is giving null.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/converters/AtlasInstanceConverter.java
>  5c08874ff 
> 
> 
> Diff: https://reviews.apache.org/r/73508/diff/1/
> 
> 
> Testing
> ---
> 
> PC - 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/792/console
> 
> 
> Thanks,
> 
> Shraddha Pardeshi
> 
>

Re: Review Request 73502: ATLAS-3917 While deleting parent tag, shows incorrect message.

[Nikhil Bonte]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73502/#review223344
---


Fix it, then Ship it!




Fix it, then Ship it!


repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasTypeDefGraphStoreV2.java
Line 273 (original), 273 (patched)
<https://reviews.apache.org/r/73502/#comment312421>

move #273 inside if condition (#274), so that name will be fetched only 
when exception is to be thrown.


- Nikhil Bonte


On Aug. 5, 2021, 12:46 p.m., Shraddha Pardeshi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73502/
> ---
> 
> (Updated Aug. 5, 2021, 12:46 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Nikhil Bonte, Nixon Rodrigues, and 
> Pinal Shah.
> 
> 
> Bugs: ATLAS-3917
> https://issues.apache.org/jira/browse/ATLAS-3917
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> -Actual Behaviour : While deleting parent tag if the tag is not associated 
> with any entity shows this message- "Given type {0} has reference."
> -Expected Result: There should be tag name instead of {0}
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasTypeDefGraphStoreV2.java
>  b9d41bbba 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasClassificationDefStoreV2Test.java
>  3242a33ad 
> 
> 
> Diff: https://reviews.apache.org/r/73502/diff/2/
> 
> 
> Testing
> ---
> 
> -Manual testing done on local server
> 
> -Test case added.
> 
> PC - 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/779/console
> 
> 
> Thanks,
> 
> Shraddha Pardeshi
> 
>

Re: [VOTE] Release Apache Atlas version 2.2.0 - rc1

[Nikhil Bonte]

Hi Sidharth

+1 for Apache Atlas v2.2.0 rc1.

Verified following:
  *  Verified md5, sha512, Signature
  *  Clean build embedded-hbase-solr profile.
  *  Setup Atlas server in embedded HBase and Solr.
  *  Verified re-indexing with JAVA_PATCH
  *  Verified Import zip with REST API
  *  Ran quick start
  *  Created entities using Atlas UI
  *  Verified metric API, statistics modal.


Regards
Nikhil P. Bonte


On Tue, Aug 10, 2021 at 4:25 AM Sidharth Mishra 
wrote:

> Atlas team,
>
> Apache Atlas 2.2.0 rc1, with the following fixes since rc0, is now
> available for vote within the dev community.
>
> ATLAS-4390 - Changed Atlas branch to release-2.2.0-rc1
> ATLAS-4391 - NoSuchFileException for {atlas.log.dir}/atlas-metrics.out
> ATLAS-4343 - [Entity Audits] 'Propagated Classification Added'
> Timestamp is < 'Entity
> Created' Timestamp
> ATLAS-4387 - UI: Propagated Classifications shows wrong count for
> entity type on Entity   detail
> page
> ATLAS-4386 - Relationship search: Sorting does not work when
> relationship label is passed
>
> Links to the release artifacts are given below. Please review and vote.
>
> The vote will be open for at least 72 hours or until necessary votes
> are reached.
>
>   [ ] +1 Approve
>
>   [ ] +0 No opinion
>
>   [ ] -1 Disapprove (and reason why)
>
> Thanks,
> Sid
>
> List of all issues addressed in this release:
>
> https://issues.apache.org/jira/issues/?jql=project%3DATLAS%20AND%20status%3DResolved%20AND%20fixVersion%3D2.2.0%20ORDER%20BY%20key%20DESC
>
> Git tag for the release:
> https://github.com/apache/atlas/tree/release-2.2.0-rc1
>
> Sources for the release:
>
> https://dist.apache.org/repos/dist/dev/atlas/2.2.0-rc1/apache-atlas-2.2.0-sources.tar.gz
>
> Source release verification:
>
>   PGP Signature:
>
> https://dist.apache.org/repos/dist/dev/atlas/2.2.0-rc1/apache-atlas-2.2.0-sources.tar.gz.asc
>
>   SHA512 Hash:
>
> https://dist.apache.org/repos/dist/dev/atlas/2.2.0-rc1/apache-atlas-2.2.0-sources.tar.gz.sha512
>
>   MD5 Hash:
>
> https://dist.apache.org/repos/dist/dev/atlas/2.2.0-rc1/apache-atlas-2.2.0-sources.tar.gz.md5
>
>
> Keys to verify the signature of the release artifacts are available
> at: https://dist.apache.org/repos/dist/release/atlas/KEYS
>
>
> New features/enhancements:
>
>  - Introduced Deferred Action - Tag propagation will be handled as
> a background process (AtlasTask)
>
> - Added Re-indexing as JAVA_PATCH
>
> - Created JavaPatch to add new super types to existing entities
>
> - Supported for Business Metadata in Atlas Export API
>
> - Supported HA for admin/task API
>
> - Enhanced export service to export Terms
>
> - Added new models and addition attributes to Atlas for Apache
> Flink, GCP and ADLS Gen 2
>
> - Added support to Configure HiveServer2 Hook to send Lineage-only
> Messages
>
> - Improved and enhanced Bulk Glossary Import supporting import
> with relations
>
> - Dependency between Atlas and Kafka Zookeeper removed
>
> - Improved performance of GraphHelper's guid and status getter methods
>
> - Added new privilege - "admin-audits" for Atlas Admin Audits
> authorization
>
> - Basic search Improvements - search text with special characters,
> optimize pagination
>
> - Updated free-text search processor to support Elasticsearch
>
> - Refactored and enhanced Atlas Python Client supporting Python 2.7
>
> - DSL Search enhancements - Support glossary terms and
> relationship, can handle null attribute values, Java Tinkerpop
> Traversals instead of GremlinScriptEngine, support search by
> classification and its attribute, Caching mechanism for translated dsl
> queries
>
> - Enhanced Export/Import Service to conditionally Support
> Simultaneous Operations
>
> - Enhanced NotificationHookConsumer for Large Message Processing
>
> - Enhanced Atlas authorization for Add/Update/Remove
> classification on entities
>
> - Provided option to add mandatory attribute to existing entity
> definition
>
> - Fixed Atlas UI to load faster in case of large number of
> classifications & entities
>
> - Updated versions of dependent libraries/components: JanusGraph,
> elasticsearch, JQuery, Http core, Http Client, slf4j, log4j, ant,
> gremlin, Solr, groovy, netty, Kafka
>

Re: Review Request 73502: ATLAS-3917 While deleting parent tag, shows incorrect message.

[Nikhil Bonte]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73502/#review223311
---




repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasClassificationDefStoreV2Test.java
Lines 80 (patched)
<https://reviews.apache.org/r/73502/#comment312404>

Suggestion - Rename: 
testErrorMessage() -> testDeleteReferencedTraitFail()


- Nikhil Bonte


On Aug. 4, 2021, 7:41 p.m., Shraddha Pardeshi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73502/
> ---
> 
> (Updated Aug. 4, 2021, 7:41 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Nikhil Bonte, Nixon Rodrigues, and 
> Pinal Shah.
> 
> 
> Bugs: ATLAS-3917
> https://issues.apache.org/jira/browse/ATLAS-3917
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> -Actual Behaviour : While deleting parent tag if the tag is not associated 
> with any entity shows this message- "Given type {0} has reference."
> -Expected Result: There should be tag name instead of {0}
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasTypeDefGraphStoreV2.java
>  b9d41bbba 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasClassificationDefStoreV2Test.java
>  3242a33ad 
> 
> 
> Diff: https://reviews.apache.org/r/73502/diff/1/
> 
> 
> Testing
> ---
> 
> -Manual testing done on local server
> 
> -Test case added.
> 
> PC - 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/779/console
> 
> 
> Thanks,
> 
> Shraddha Pardeshi
> 
>

Re: Planning for Apache Atlas 2.2.0 release

[Nikhil Bonte]

Thanks for volunteering Sidharth!

+1 for the release Apache Atlas 2.2.


Regards
Nikhil P. Bonte


On Wed, Jul 28, 2021 at 10:46 AM Ashutosh Mestry 
wrote:

> Sidharth: Thanks for volunteering!
>
>
>
> +1 for the release.
>
>
>
> *~ ashutosh*
>
> *Ashutosh Mestry* * . Staff Software Engineer .
> Cloudera, Inc. . *
>
> ...
>
> *No hurry, no pause. – Tim Ferriss, Life Hacker, Author*
>
>
>
>
>
> *From: *Sarath Subramanian 
> *Date: *Tuesday, July 27, 2021 at 10:06 PM
> *To: *dev@atlas.apache.org 
> *Cc: *u...@atlas.apache.org 
> *Subject: *Re: Planning for Apache Atlas 2.2.0 release
>
> Thanks for volunteering to release Apache Atlas 2.2
>
> +1
>
>
> Thanks,
> Sarath
>
>
> On Tue, Jul 27, 2021 at 12:11 PM Sidharth Mishra 
> wrote:
>
> > Dear Atlas community,
> >
> > Since Apache Atlas 2.1 was released, there are many new features,
> > improvements and fixes. Here are few features/enhancements since last
> > release, Apache Atlas 2.1:
> >
> > - Introduced Deferred Action - Tag propagation will be handled as
> > a background process (AtlasTask)
> >
> > - Added Re-indexing as JAVA_PATCH
> >
> > - Created JavaPatch to add new super types to existing entities
> >
> > - Supported for Business Metadata in Atlas Export API
> >
> > - Supported HA for admin/task API
> >
> > - Enhanced export service to export Terms
> >
> > - Added new models and addition attributes to Atlas for Apache
> > Flink, GCP and ADLS Gen 2
> >
> > - Added support to Configure HiveServer2 Hook to send Lineage-only
> > Messages
> >
> > - Improved and enhanced Bulk Glossary Import supporting import
> > with relations
> >
> > - Dependency between Atlas and Kafka Zookeeper removed
> >
> > - Improved performance of GraphHelper's guid and status getter
> methods
> >
> > - Added new privilege - "admin-audits" for Atlas Admin Audits
> > authorization
> >
> > - Basic search Improvements - search text with special characters,
> > optimize pagination
> >
> > - Updated free-text search processor to support Elasticsearch
> >
> > - Refactored and enhanced Atlas Python Client supporting Python 2.7
> >
> > - DSL Search enhancements - Support glossary terms and
> > relationship, can handle null attribute values, Java Tinkerpop
> > Traversals instead of GremlinScriptEngine, support search by
> > classification and its attribute, Caching mechanism for translated dsl
> > queries
> >
> > - Enhanced Export/Import Service to conditionally Support
> > Simultaneous Operations
> >
> > - Enhanced NotificationHookConsumer for Large Message Processing
> >
> > - Enhanced Atlas authorization for Add/Update/Remove
> > classification on entities
> >
> > - Provided option to add mandatory attribute to existing entity
> > definition
> >
> > - Fixed Atlas UI to load faster in case of large number of
> > classifications & entities
> >
> > - Updated versions of dependent libraries/components: JanusGraph,
> > elasticsearch, JQuery, Http core, Http Client, slf4j, log4j, ant,
> > gremlin, Solr, groovy, netty, Kafka
> >
> > There are around 336 plus commits on branch 2.0 and 205 resolved
> > issues with fix version 2.2.0 after 2.1.0 release.
> > With these significant improvements in place, it is time for the next
> > release of Apache Atlas!
> >
> > I propose to release Apache Atlas 2.2 by early next month. Please
> > review and send your comments.
> >
> > Regards,
> > Sidharth
> >
>

Re: Review Request 73442: ATLAS-4150 Remove System Internal Entity Types from Metrics GET api

[Nikhil Bonte]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73442/#review223237
---


Ship it!




Ship It!

- Nikhil Bonte


On July 9, 2021, 1:11 p.m., Mandar Ambawane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73442/
> ---
> 
> (Updated July 9, 2021, 1:11 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4150
> https://issues.apache.org/jira/browse/ATLAS-4150
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch checks all the Super Types of an Entity Type. If any of the Super 
> Types is __internal
> 
> Then it will not allow that Entity Type in Metrics api response.
> 
> 
> Diffs
> -
> 
>   repository/src/main/java/org/apache/atlas/services/MetricsService.java 
> e721108d3 
>   repository/src/test/java/org/apache/atlas/services/MetricsServiceTest.java 
> bea8eb8b5 
> 
> 
> Diff: https://reviews.apache.org/r/73442/diff/1/
> 
> 
> Testing
> ---
> 
> PreCommit: 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/734/consoleFull
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>

Re: Review Request 73442: ATLAS-4150 Remove System Internal Entity Types from Metrics GET api

[Nikhil Bonte]

> On July 16, 2021, 6:44 p.m., Mandar Ambawane wrote:
> > repository/src/main/java/org/apache/atlas/services/MetricsService.java
> > Lines 248 (patched)
> > 
> >
> > I have put this check to make sure there will not be any NPE.
> > Suppose user creates one user-defined entity typedef without having any 
> > super type.
> > Then, there might be a chance of getting Null value for 
> > entityDef.getSuperTypes()

Refer 
https://github.com/apache/atlas/blob/c1dc84cdeeb1b5c3a53f2bec01ae138e5f578dd1/intg/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java#L152
This suggests that there is no possibility of NPE


- Nikhil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73442/#review223235
---


On July 9, 2021, 1:11 p.m., Mandar Ambawane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73442/
> ---
> 
> (Updated July 9, 2021, 1:11 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4150
> https://issues.apache.org/jira/browse/ATLAS-4150
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch checks all the Super Types of an Entity Type. If any of the Super 
> Types is __internal
> 
> Then it will not allow that Entity Type in Metrics api response.
> 
> 
> Diffs
> -
> 
>   repository/src/main/java/org/apache/atlas/services/MetricsService.java 
> e721108d3 
>   repository/src/test/java/org/apache/atlas/services/MetricsServiceTest.java 
> bea8eb8b5 
> 
> 
> Diff: https://reviews.apache.org/r/73442/diff/1/
> 
> 
> Testing
> ---
> 
> PreCommit: 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/734/consoleFull
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>

Re: Review Request 73442: ATLAS-4150 Remove System Internal Entity Types from Metrics GET api

[Nikhil Bonte]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73442/#review223234
---


Fix it, then Ship it!




Fix & Ship


repository/src/main/java/org/apache/atlas/services/MetricsService.java
Lines 248 (patched)
<https://reviews.apache.org/r/73442/#comment312326>

CollectionUtils.isNotEmpty(entityDef.getSuperTypes())

I think this check is not required, please review & remove.


- Nikhil Bonte


On July 9, 2021, 1:11 p.m., Mandar Ambawane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73442/
> ---
> 
> (Updated July 9, 2021, 1:11 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4150
> https://issues.apache.org/jira/browse/ATLAS-4150
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch checks all the Super Types of an Entity Type. If any of the Super 
> Types is __internal
> 
> Then it will not allow that Entity Type in Metrics api response.
> 
> 
> Diffs
> -
> 
>   repository/src/main/java/org/apache/atlas/services/MetricsService.java 
> e721108d3 
>   repository/src/test/java/org/apache/atlas/services/MetricsServiceTest.java 
> bea8eb8b5 
> 
> 
> Diff: https://reviews.apache.org/r/73442/diff/1/
> 
> 
> Testing
> ---
> 
> PreCommit: 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/734/consoleFull
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>

Re: Review Request 73423: ATLAS-4338: Import Service: Support change notifiers for migration import

[Nikhil Bonte]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73423/
---

(Updated June 30, 2021, 4:37 p.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, madhan, Nixon 
Rodrigues, Sarath Subramanian, and Sidharth Mishra.


Changes
---

Addressed review comments


Bugs: ATLAS-4338
https://issues.apache.org/jira/browse/ATLAS-4338


Repository: atlas


Description
---

Currently Migration import feature (MigrationImport.java) does not support 
enabling notifiers (audits writer, notification to Atlas entities topic).

With this improvement, Atlas now will enable notifiers for Migration import, 
based on a flag.

 

Approach:

* New option in AtlasImportRequest - sendNotifications (default : false)
* MigrationImport will use the flag to select appropriate implementation of 
IAtlasEntityChangeNotifier to create EntityCreationManager.
* EntityCreationManager will then notify listeners.


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/model/impexp/AtlasImportRequest.java 
2c1870444 
  
repository/src/main/java/org/apache/atlas/repository/impexp/ImportService.java 
1d29bf833 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java
 99be169f2 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/BulkImporterImpl.java
 8e17fd410 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/GuidMutationResponsePair.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/MigrationImport.java
 d6f23d6e2 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/pc/EntityConsumer.java
 b73988fd7 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/pc/EntityCreationManager.java
 734add6d7 


Diff: https://reviews.apache.org/r/73423/diff/3/

Changes: https://reviews.apache.org/r/73423/diff/2-3/


Testing
---

* Tested Manually
* Sample request
{
"options": {
"migration": "true",
"size": "100",
"sendNotifications": "true",
"batchSize": 500,
"numWorkers": 40
}
}
* took ~270 secs to import 12987 entities with notifiers enabled.
* PC build : 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/679/console


Thanks,

Nikhil Bonte

Re: Review Request 73423: ATLAS-4338: Import Service: Support change notifiers for migration import

[Nikhil Bonte]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73423/
---

(Updated June 23, 2021, 7:51 p.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, madhan, Nixon 
Rodrigues, Sarath Subramanian, and Sidharth Mishra.


Changes
---

Addressed review comment


Bugs: ATLAS-4338
https://issues.apache.org/jira/browse/ATLAS-4338


Repository: atlas


Description
---

Currently Migration import feature (MigrationImport.java) does not support 
enabling notifiers (audits writer, notification to Atlas entities topic).

With this improvement, Atlas now will enable notifiers for Migration import, 
based on a flag.

 

Approach:

* New option in AtlasImportRequest - sendNotifications (default : false)
* MigrationImport will use the flag to select appropriate implementation of 
IAtlasEntityChangeNotifier to create EntityCreationManager.
* EntityCreationManager will then notify listeners.


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/model/impexp/AtlasImportRequest.java 
2c1870444 
  
repository/src/main/java/org/apache/atlas/repository/impexp/ImportService.java 
1d29bf833 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java
 99be169f2 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/BulkImporterImpl.java
 8e17fd410 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/BulkImportResultItem.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/MigrationImport.java
 d6f23d6e2 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/pc/EntityConsumer.java
 b73988fd7 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/pc/EntityCreationManager.java
 734add6d7 


Diff: https://reviews.apache.org/r/73423/diff/2/

Changes: https://reviews.apache.org/r/73423/diff/1-2/


Testing
---

* Tested Manually
* Sample request
{
"options": {
"migration": "true",
"size": "100",
"sendNotifications": "true",
"batchSize": 500,
"numWorkers": 40
}
}
* took ~270 secs to import 12987 entities with notifiers enabled.
* PC build : 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/679/console


Thanks,

Nikhil Bonte

Re: Review Request 73423: ATLAS-4338: Import Service: Support change notifiers for migration import

[Nikhil Bonte]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73423/
---

(Updated June 21, 2021, 7:36 p.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, madhan, Nixon 
Rodrigues, Sarath Subramanian, and Sidharth Mishra.


Changes
---

Updated PC build link


Bugs: ATLAS-4338
https://issues.apache.org/jira/browse/ATLAS-4338


Repository: atlas


Description
---

Currently Migration import feature (MigrationImport.java) does not support 
enabling notifiers (audits writer, notification to Atlas entities topic).

With this improvement, Atlas now will enable notifiers for Migration import, 
based on a flag.

 

Approach:

* New option in AtlasImportRequest - sendNotifications (default : false)
* MigrationImport will use the flag to select appropriate implementation of 
IAtlasEntityChangeNotifier to create EntityCreationManager.
* EntityCreationManager will then notify listeners.


Diffs
-

  intg/src/main/java/org/apache/atlas/model/impexp/AtlasImportRequest.java 
2c1870444 
  
repository/src/main/java/org/apache/atlas/repository/impexp/ImportService.java 
1d29bf833 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java
 99be169f2 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/BulkImporterImpl.java
 8e17fd410 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/MigrationImport.java
 d6f23d6e2 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/pc/EntityConsumer.java
 b73988fd7 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/pc/EntityCreationManager.java
 734add6d7 


Diff: https://reviews.apache.org/r/73423/diff/1/


Testing (updated)
---

* Tested Manually
* Sample request
{
"options": {
"migration": "true",
"size": "100",
"sendNotifications": "true",
"batchSize": 500,
"numWorkers": 40
}
}
* took ~270 secs to import 12987 entities with notifiers enabled.
* PC build : 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/679/console


Thanks,

Nikhil Bonte

Review Request 73423: ATLAS-4338: Import Service: Support change notifiers for migration import

[Nikhil Bonte]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73423/
---

Review request for atlas, Ashutosh Mestry, Jayendra Parab, madhan, Nixon 
Rodrigues, Sarath Subramanian, and Sidharth Mishra.


Bugs: ATLAS-4338
https://issues.apache.org/jira/browse/ATLAS-4338


Repository: atlas


Description
---

Currently Migration import feature (MigrationImport.java) does not support 
enabling notifiers (audits writer, notification to Atlas entities topic).

With this improvement, Atlas now will enable notifiers for Migration import, 
based on a flag.

 

Approach:

* New option in AtlasImportRequest - sendNotifications (default : false)
* MigrationImport will use the flag to select appropriate implementation of 
IAtlasEntityChangeNotifier to create EntityCreationManager.
* EntityCreationManager will then notify listeners.


Diffs
-

  intg/src/main/java/org/apache/atlas/model/impexp/AtlasImportRequest.java 
2c1870444 
  
repository/src/main/java/org/apache/atlas/repository/impexp/ImportService.java 
1d29bf833 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java
 99be169f2 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/BulkImporterImpl.java
 8e17fd410 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/MigrationImport.java
 d6f23d6e2 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/pc/EntityConsumer.java
 b73988fd7 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/pc/EntityCreationManager.java
 734add6d7 


Diff: https://reviews.apache.org/r/73423/diff/1/


Testing
---

* Tested Manually
* Attached sample zip, sample request
{
"options": {
"migration": "true",
"size": "100",
"sendNotifications": "true",
"batchSize": 500,
"numWorkers": 40
}
}
* took ~270 secs to import 12987 entities with notifiers enabled.
* PC build :


File Attachments


largedb.zip
  
https://reviews.apache.org/media/uploaded/files/2021/06/15/c84f450b-c2b3-4cac-8b4a-76942a2c14e3__largedb.zip


Thanks,

Nikhil Bonte

Re: Review Request 73405: ATLAS-4302: Migrated Data: Process Entity Name not set to QualifiedName

[Nikhil Bonte]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73405/#review223104
---


Ship it!




Ship It!

- Nikhil Bonte


On June 4, 2021, 10:18 a.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73405/
> ---
> 
> (Updated June 4, 2021, 10:18 a.m.)
> 
> 
> Review request for atlas, Nikhil Bonte, Nixon Rodrigues, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-4302
> https://issues.apache.org/jira/browse/ATLAS-4302
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Approach**
> Java patch is optionally run when 
> ```atlas.process.name.update.patch
> 
> is set to true.
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/AtlasConfiguration.java e31afa89a 
>   
> repository/src/main/java/org/apache/atlas/repository/patches/AtlasPatchManager.java
>  fae28c440 
>   
> repository/src/main/java/org/apache/atlas/repository/patches/ProcessNamePatch.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/73405/diff/2/
> 
> 
> Testing
> ---
> 
> **Functional test**
> - Validated with medium data set (5M entities).
> 
> **Volume test**
> - Validated improvement for a lineage entity with 1200 inputs and 1700 
> outputs. With this change, the _AtlasEntityHeader_ payload size reduces by 
> 90%.
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Re: Review Request 73375: Handle Spool Directory Creation by Different Users

[Nikhil Bonte]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73375/#review223071
---


Ship it!




Ship It!

- Nikhil Bonte


On May 26, 2021, 3:12 a.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73375/
> ---
> 
> (Updated May 26, 2021, 3:12 a.m.)
> 
> 
> Review request for atlas, Nikhil Bonte, Nixon Rodrigues, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-4306
> https://issues.apache.org/jira/browse/ATLAS-4306
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Please see bug description.
> 
> 
> Diffs
> -
> 
>   
> notification/src/main/java/org/apache/atlas/notification/spool/AtlasFileSpool.java
>  ea3128465 
>   
> notification/src/main/java/org/apache/atlas/notification/spool/IndexManagement.java
>  f018983a4 
>   
> notification/src/main/java/org/apache/atlas/notification/spool/SpoolConfiguration.java
>  76f05efea 
>   
> notification/src/main/java/org/apache/atlas/notification/spool/SpoolUtils.java
>  abbe33d24 
>   
> notification/src/test/java/org/apache/atlas/notification/spool/BaseTest.java 
> 304c82122 
> 
> 
> Diff: https://reviews.apache.org/r/73375/diff/1/
> 
> 
> Testing
> ---
> 
> **Functional tests**
> Existing workflows.
> 
> **Unit tests**
> None.
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

[jira] [Updated] (ATLAS-4259) Swagger: Improve Header validation

[Nikhil Bonte (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Bonte updated ATLAS-4259:

Fix Version/s: 2.2.0
   3.0.0

> Swagger: Improve Header validation 
> ---
>
> Key: ATLAS-4259
> URL: https://issues.apache.org/jira/browse/ATLAS-4259
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Affects Versions: 2.1.0
>Reporter: Nikhil Bonte
>Assignee: Nikhil P Bonte
>Priority: Major
>  Labels: REST_API, swagger
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-4259-Swagger-Improve-Header-validation_v2.patch
>
>
> This will add support for ATLAS-4064 in swagger.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4259) Swagger: Improve Header validation

[Nikhil Bonte (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Bonte updated ATLAS-4259:

Affects Version/s: 2.1.0

> Swagger: Improve Header validation 
> ---
>
> Key: ATLAS-4259
> URL: https://issues.apache.org/jira/browse/ATLAS-4259
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Affects Versions: 2.1.0
>Reporter: Nikhil Bonte
>Assignee: Nikhil P Bonte
>Priority: Major
>  Labels: REST_API, swagger
> Attachments: ATLAS-4259-Swagger-Improve-Header-validation_v2.patch
>
>
> This will add support for ATLAS-4064 in swagger.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 73329: Correlating Deleted Entities with Lineage

[Nikhil Bonte]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73329/#review223027
---


Ship it!




Ship It!

- Nikhil Bonte


On May 21, 2021, 3:48 a.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73329/
> ---
> 
> (Updated May 21, 2021, 3:48 a.m.)
> 
> 
> Review request for atlas, Radhika Kundam and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4152
> https://issues.apache.org/jira/browse/ATLAS-4152
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Background**
> As part of ATLAS-4204, HS2 notifications send entity-lineage only (provided 
> the poperty is enabled).
> 
> When Spooling enabled the order of messages can potentially change. The 
> notification messages coming from HS2 and HMS may not be in the same order as 
> when they arrived with direct notification.
> 
> Problem: 
> Consider the sequence of arriving messages:
> 
> This is the sequence of messages for Entity 1 (C = create, U = update, D = 
> delete, L?x = Lineage of type 'x')
> No problem: C1, U1, L1x, L1y, D1
> Problem: C1, U1, D1, L1x, L1y
> 
> This implementation attempts to handle ths problem mentioned above. If the 
> above case is not handled, it will end up creating shell entities, since 
> deleted entities are not looked up as part of entity creation.
> 
> **Approach**
> Used bounded stream approach where an incoming stream of messages is bounded 
> with an indicator that it originates from spool. This helps makes localized 
> decisions on the incoming stream of messages.
> 
> High-level approach:
> - Messages when written to the spool are tagged with a timestamp.
> - Deleted entities are maintained in a cache.
> - Lineage-only message are checked if they refer to a deleted entity.
> - If they refer to deleted entity, they are stitched to the one present in 
> the cache only if it falls within the threshold.
> - Using step-climbing approach for locating right entity to stitch lineage to.
> 
> New: _EntityCorrelationsManager_: Uses message timestamp and cached entity 
> qualifiedName-GUID map.
> Modifed: _NotificationHookConsumer_ Uses the new class.
> New: _HiveDDLLineagePreprocess_ Uses entity-correlation to link to deleted 
> entities.
> Modified: _SpoolConfiguration_: Added new configuration to pause message 
> sending after destination is available: 
> _atlas.hook.spool.pause.before.send.sec_.
> In-memory lookup approach changed to persistent loookup.
> 
> 
> Diffs
> -
> 
>   common/src/main/java/org/apache/atlas/repository/Constants.java ffcec9743 
>   
> intg/src/main/java/org/apache/atlas/model/notification/AtlasNotificationMessage.java
>  810ba97c9 
>   notification/src/main/java/org/apache/atlas/kafka/AtlasKafkaConsumer.java 
> f7d9668ec 
>   notification/src/main/java/org/apache/atlas/kafka/AtlasKafkaMessage.java 
> 22bd79fdf 
>   notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java 
> 3d1b3ccf1 
>   
> notification/src/main/java/org/apache/atlas/notification/AtlasNotificationMessageDeserializer.java
>  3264e264c 
>   
> notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java
>  edd8ed931 
>   
> notification/src/main/java/org/apache/atlas/notification/spool/AtlasFileSpool.java
>  2d7d19595 
>   
> notification/src/main/java/org/apache/atlas/notification/spool/Publisher.java 
> 22242c933 
>   
> notification/src/main/java/org/apache/atlas/notification/spool/SpoolConfiguration.java
>  a9a3a78cc 
>   notification/src/main/java/org/apache/atlas/notification/spool/Spooler.java 
> 2cacaaadc 
>   
> notification/src/test/java/org/apache/atlas/notification/AbstractNotificationTest.java
>  d7e4959f7 
>   
> notification/src/test/java/org/apache/atlas/notification/spool/AtlasFileSpoolTest.java
>  167efbecc 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
>  cc727c6ba 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/EntityCorrelationStore.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasGraphUtilsV2.java
>  0a9470815 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/EntityCorrelationStoreTest.java
>  PRE-CREATION 
>   
> webapp/src/main/java/org/apache/atlas/notification/EntityCorrelationManager.java
>  PRE-CREATION 
>   
&

[jira] [Updated] (ATLAS-4259) Swagger: Improve Header validation

[Nikhil Bonte (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Bonte updated ATLAS-4259:

Attachment: (was: ATLAS-4259-Swagger-Improve-Header-validation-v1.patch)

> Swagger: Improve Header validation 
> ---
>
> Key: ATLAS-4259
> URL: https://issues.apache.org/jira/browse/ATLAS-4259
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>    Reporter: Nikhil Bonte
>Assignee: Nikhil P Bonte
>Priority: Major
>  Labels: REST_API, swagger
> Attachments: ATLAS-4259-Swagger-Improve-Header-validation_v2.patch
>
>
> This will add support for ATLAS-4064 in swagger.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4259) Swagger: Improve Header validation

[Nikhil Bonte (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Bonte updated ATLAS-4259:

Attachment: ATLAS-4259-Swagger-Improve-Header-validation_v2.patch

> Swagger: Improve Header validation 
> ---
>
> Key: ATLAS-4259
> URL: https://issues.apache.org/jira/browse/ATLAS-4259
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>    Reporter: Nikhil Bonte
>Assignee: Nikhil P Bonte
>Priority: Major
>  Labels: REST_API, swagger
> Attachments: ATLAS-4259-Swagger-Improve-Header-validation-v1.patch, 
> ATLAS-4259-Swagger-Improve-Header-validation_v2.patch
>
>
> This will add support for ATLAS-4064 in swagger.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 73302: ATLAS-4255 : Atlas - Upgrade netty to 4.1.61

[Nikhil Bonte]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73302/#review222875
---


Ship it!




Ship It!

- Nikhil Bonte


On April 26, 2021, 11:39 p.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73302/
> ---
> 
> (Updated April 26, 2021, 11:39 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
> Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4255
> https://issues.apache.org/jira/browse/ATLAS-4255
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Currently  Atlas is pulling netty jar versions 4.1.47,4.1.51,4.1.23,4.1.48 
> 
> Upgrade it to latest 4.1.61-final
> Introduced a dependency as netty-bom which can take care of all transitive 
> dependencies for io.netty atlas is pulling
> 
> 
> Diffs
> -
> 
>   pom.xml 092ba09ce 
> 
> 
> Diff: https://reviews.apache.org/r/73302/diff/1/
> 
> 
> Testing
> ---
> 
> Atlas server up and running
> Created entities,glossaries and tags
> quickstart.py successful
> PC : 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/522/console
> 
> 
> Thanks,
> 
> chaitali
> 
>

[jira] [Commented] (ATLAS-4260) Swagger: click to expand API does not work properly in some cases

[Nikhil Bonte (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17330480#comment-17330480
 ] 

Nikhil Bonte commented on ATLAS-4260:
-

Known issue from original library - 
https://github.com/stoicflame/enunciate/issues/1081

> Swagger: click to expand API does not work properly in some cases
> -
>
> Key: ATLAS-4260
> URL: https://issues.apache.org/jira/browse/ATLAS-4260
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>    Reporter: Nikhil Bonte
>Assignee: Nikhil P Bonte
>Priority: Major
>  Labels: rest_api, swagger
>
> Click on API POST /v2/entity also expands API POST /v2/entity/bulk & vice 
> versa
>  
> Root Cause:
> This is due to the same id of div element of both APIs.
> The swagger spec has "operationId" same for both API.
>  
> Need to check if any other API has the same issue.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4259) Swagger: Improve Header validation

[Nikhil Bonte (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Bonte updated ATLAS-4259:

Attachment: (was: ATLAS-4259-Swagger-Improve-Header-validation-v0.patch)

> Swagger: Improve Header validation 
> ---
>
> Key: ATLAS-4259
> URL: https://issues.apache.org/jira/browse/ATLAS-4259
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>    Reporter: Nikhil Bonte
>Assignee: Nikhil P Bonte
>Priority: Major
>  Labels: REST_API, swagger
> Attachments: ATLAS-4259-Swagger-Improve-Header-validation-v1.patch
>
>
> This will add support for ATLAS-4064 in swagger.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4260) Swagger: click to expand API does not work properly in some cases

[Nikhil Bonte (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Bonte updated ATLAS-4260:

Description: 
Click on API POST /v2/entity also expands API POST /v2/entity/bulk & vice versa

 

Root Cause:

This is due to the same id of div element of both APIs.

The swagger spec has "operationId" same for both API.

 

Need to check if any other API has the same issue.

 

> Swagger: click to expand API does not work properly in some cases
> -
>
> Key: ATLAS-4260
> URL: https://issues.apache.org/jira/browse/ATLAS-4260
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Nikhil Bonte
>Priority: Major
>  Labels: rest_api, swagger
>
> Click on API POST /v2/entity also expands API POST /v2/entity/bulk & vice 
> versa
>  
> Root Cause:
> This is due to the same id of div element of both APIs.
> The swagger spec has "operationId" same for both API.
>  
> Need to check if any other API has the same issue.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (ATLAS-4260) Swagger: click to expand API does not work properly in some cases

[Nikhil Bonte (Jira)]

Nikhil Bonte created ATLAS-4260:
---

 Summary: Swagger: click to expand API does not work properly in 
some cases
 Key: ATLAS-4260
 URL: https://issues.apache.org/jira/browse/ATLAS-4260
 Project: Atlas
  Issue Type: Bug
Reporter: Nikhil Bonte






--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4260) Swagger: click to expand API does not work properly in some cases

[Nikhil Bonte (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Bonte updated ATLAS-4260:

Labels: rest_api swagger  (was: )

> Swagger: click to expand API does not work properly in some cases
> -
>
> Key: ATLAS-4260
> URL: https://issues.apache.org/jira/browse/ATLAS-4260
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>    Reporter: Nikhil Bonte
>Priority: Major
>  Labels: rest_api, swagger
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4260) Swagger: click to expand API does not work properly in some cases

[Nikhil Bonte (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Bonte updated ATLAS-4260:

Component/s:  atlas-core

> Swagger: click to expand API does not work properly in some cases
> -
>
> Key: ATLAS-4260
> URL: https://issues.apache.org/jira/browse/ATLAS-4260
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>    Reporter: Nikhil Bonte
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4259) Swagger: Improve Header validation

[Nikhil Bonte (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17330428#comment-17330428
 ] 

Nikhil Bonte commented on ATLAS-4259:
-

Tested manually, working fine.

> Swagger: Improve Header validation 
> ---
>
> Key: ATLAS-4259
> URL: https://issues.apache.org/jira/browse/ATLAS-4259
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>    Reporter: Nikhil Bonte
>Priority: Major
>  Labels: REST_API, swagger
> Attachments: ATLAS-4259-Swagger-Improve-Header-validation-v0.patch
>
>
> This will add support for ATLAS-4064 in swagger.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4259) Swagger: Improve Header validation

[Nikhil Bonte (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Bonte updated ATLAS-4259:

Attachment: ATLAS-4259-Swagger-Improve-Header-validation-v0.patch

> Swagger: Improve Header validation 
> ---
>
> Key: ATLAS-4259
> URL: https://issues.apache.org/jira/browse/ATLAS-4259
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>    Reporter: Nikhil Bonte
>Priority: Major
>  Labels: REST_API, swagger
> Attachments: ATLAS-4259-Swagger-Improve-Header-validation-v0.patch
>
>
> This will add support for ATLAS-4064 in swagger.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4259) Swagger: Improve Header validation

[Nikhil Bonte (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Bonte updated ATLAS-4259:

Description: This will add support for ATLAS-4064 in swagger.

> Swagger: Improve Header validation 
> ---
>
> Key: ATLAS-4259
> URL: https://issues.apache.org/jira/browse/ATLAS-4259
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>    Reporter: Nikhil Bonte
>Priority: Major
>  Labels: REST_API, swagger
>
> This will add support for ATLAS-4064 in swagger.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4259) Swagger: Improve Header validation

[Nikhil Bonte (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Bonte updated ATLAS-4259:

Component/s:  atlas-core

> Swagger: Improve Header validation 
> ---
>
> Key: ATLAS-4259
> URL: https://issues.apache.org/jira/browse/ATLAS-4259
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>    Reporter: Nikhil Bonte
>Priority: Major
>  Labels: REST_API, swagger
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4259) Swagger: Improve Header validation

[Nikhil Bonte (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Bonte updated ATLAS-4259:

Labels: REST_API swagger  (was: )

> Swagger: Improve Header validation 
> ---
>
> Key: ATLAS-4259
> URL: https://issues.apache.org/jira/browse/ATLAS-4259
> Project: Atlas
>  Issue Type: Improvement
>    Reporter: Nikhil Bonte
>Priority: Major
>  Labels: REST_API, swagger
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (ATLAS-4259) Swagger: Improve Header validation

[Nikhil Bonte (Jira)]

Nikhil Bonte created ATLAS-4259:
---

 Summary: Swagger: Improve Header validation 
 Key: ATLAS-4259
 URL: https://issues.apache.org/jira/browse/ATLAS-4259
 Project: Atlas
  Issue Type: Improvement
Reporter: Nikhil Bonte






--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 73258: ATLAS-4195: [Atlas: Audits] 2 entries are created in audits when "replace columns" command is executed in hive

[Nikhil Bonte]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73258/#review222847
---


Fix it, then Ship it!





repository/src/test/java/org/apache/atlas/repository/store/graph/v2/DifferentialAuditsTest.java
Lines 47 (patched)
<https://reviews.apache.org/r/73258/#comment312009>

DSLQueriesTest.class -> DifferentialAuditsTest.class


- Nikhil Bonte


On April 22, 2021, 9:10 a.m., Deep Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73258/
> ---
> 
> (Updated April 22, 2021, 9:10 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nikhil Bonte, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4195
> https://issues.apache.org/jira/browse/ATLAS-4195
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> When columns for certain table are deleted or replaced, in graph we mark the 
> table relationship with columns(replaced or deleted) as inactive. When shuch 
> a table's definition is sent by Hivehook in some event(may be as refered 
> entity), an update audit is created for the table (irrespective of 
> differential audit feature being enableld or disabled). 
> 
> This is because in entity comparator, where we compare relationships of 
> stored entity with the relationships of incoming refered table entity, we do 
> not ignore the inactive relationships of stored entity. This was because 
> mapVertexToArray method of EntityGraphRetriever did not have the capability 
> to ignore AtlasEdges having inactive status.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
>  c13392000 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
>  b79002334 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/DifferentialAuditsTest.java
>  PRE-CREATION 
>   repository/src/test/resources/json/entities/db01.json PRE-CREATION 
>   repository/src/test/resources/json/entities/tbl01-2cols.json PRE-CREATION 
>   repository/src/test/resources/json/entities/tbl01.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/73258/diff/2/
> 
> 
> Testing
> ---
> 
> Manual testing was done.
> Unit test Added.
> 
> 
> Thanks,
> 
> Deep Singh
> 
>

Re: Review Request 73290: ATLAS-4251: Upgrade luceneMatchVersion in Solr configs

[Nikhil Bonte]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73290/
---

(Updated April 21, 2021, 8:35 p.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, madhan, Nixon 
Rodrigues, Pinal Shah, and Sarath Subramanian.


Bugs: ATLAS-4251
https://issues.apache.org/jira/browse/ATLAS-4251


Repository: atlas


Description
---

Altas' Solr config currently has luceneMatchVersion as 5.0.0

This improvement will upgrade it to 8.4.1


Diffs
-

  dev-support/atlas-docker/config/solr/solrconfig.xml 21d19ef19 
  distro/src/conf/solr/solrconfig.xml 21d19ef19 
  repository/src/test/resources/solr/core-template/solrconfig.xml 9264f99d4 
  test-tools/src/main/resources/solr/core-template/solrconfig.xml 977ebc49c 


Diff: https://reviews.apache.org/r/73290/diff/1/


Testing (updated)
---

Manually Tested

Pre-commit build - 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/511/consoleFull
 (IN PROGRESS)


Thanks,

Nikhil Bonte

[jira] [Created] (ATLAS-4251) Upgrade luceneMatchVersion in Solr configs

[Nikhil Bonte (Jira)]

Nikhil Bonte created ATLAS-4251:
---

 Summary: Upgrade luceneMatchVersion in Solr configs
 Key: ATLAS-4251
 URL: https://issues.apache.org/jira/browse/ATLAS-4251
 Project: Atlas
  Issue Type: Improvement
  Components:  atlas-core
Reporter: Nikhil Bonte


Altas' Solr config currently has luceneMatchVersion as 5.0.0

This improvement will upgrade it to 8.4.1



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 73258: ATLAS-4195: [Atlas: Audits] 2 entries are created in audits when "replace columns" command is executed in hive

[Nikhil Bonte]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73258/#review222842
---


Ship it!




Code looks good to me.
Going ahead, I think it will be good to have UTs around this scenario.

- Nikhil Bonte


On March 29, 2021, 11:29 p.m., Deep Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73258/
> ---
> 
> (Updated March 29, 2021, 11:29 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-4195
> https://issues.apache.org/jira/browse/ATLAS-4195
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> When columns for certain table are deleted or replaced, in graph we mark the 
> table relationship with columns(replaced or deleted) as inactive. When shuch 
> a table's definition is sent by Hivehook in some event(may be as refered 
> entity), an update audit is created for the table (irrespective of 
> differential audit feature being enableld or disabled). 
> 
> This is because in entity comparator, where we compare relationships of 
> stored entity with the relationships of incoming refered table entity, we do 
> not ignore the inactive relationships of stored entity. This was because 
> mapVertexToArray method of EntityGraphRetriever did not have the capability 
> to ignore AtlasEdges having inactive status.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityComparator.java
>  d962385c2 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
>  8208d11c2 
> 
> 
> Diff: https://reviews.apache.org/r/73258/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing was done.
> 
> 
> Thanks,
> 
> Deep Singh
> 
>

Re: Review Request 73258: ATLAS-4195: [Atlas: Audits] 2 entries are created in audits when "replace columns" command is executed in hive

[Nikhil Bonte]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73258/#review222825
---



Started a pre-commit - 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/497/

- Nikhil Bonte


On March 29, 2021, 11:29 p.m., Deep Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73258/
> ---
> 
> (Updated March 29, 2021, 11:29 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-4195
> https://issues.apache.org/jira/browse/ATLAS-4195
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> When columns for certain table are deleted or replaced, in graph we mark the 
> table relationship with columns(replaced or deleted) as inactive. When shuch 
> a table's definition is sent by Hivehook in some event(may be as refered 
> entity), an update audit is created for the table (irrespective of 
> differential audit feature being enableld or disabled). 
> 
> This is because in entity comparator, where we compare relationships of 
> stored entity with the relationships of incoming refered table entity, we do 
> not ignore the inactive relationships of stored entity. This was because 
> mapVertexToArray method of EntityGraphRetriever did not have the capability 
> to ignore AtlasEdges having inactive status.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityComparator.java
>  d962385c2 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
>  8208d11c2 
> 
> 
> Diff: https://reviews.apache.org/r/73258/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing was done.
> 
> 
> Thanks,
> 
> Deep Singh
> 
>

Re: Review Request 73239: HiveHook: HiveServer2 Messages Improvement

[Nikhil Bonte]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73239/#review222808
---




addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/utils/ActiveEntityFilter.java
Lines 38 (patched)
<https://reviews.apache.org/r/73239/#comment311990>

update info log
atlas.hook.hive.ignore.ddl.operations  ->  
atlas.hook.hive.hs2.ignore.ddl.operations



addons/hive-bridge/src/test/resources/atlas-application.properties
Lines 125 (patched)
<https://reviews.apache.org/r/73239/#comment311991>

change property key
atlas.hook.hive.ignore.ddl.operations  ->  
atlas.hook.hive.hs2.ignore.ddl.operations


- Nikhil Bonte


On April 12, 2021, 10:01 p.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73239/
> ---
> 
> (Updated April 12, 2021, 10:01 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4204
> https://issues.apache.org/jira/browse/ATLAS-4204
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Background**
> Please see JIRA.
> 
> Terms and abbreviations used:
> - Database objects: Database, table, views, etc.
> - DDL: Data Definition Langugage. Database parlance. Operations performed on 
> a database server that result in creation of objects that hold data.
> - DML: Data Manipulation Language. Database parlance. Operations performed on 
> a database server that result in manipulation (add, update, delete) of data. 
> These are performed using database objects that are already created.
> 
> Hive hook is implemented by:
> - _HiveHook_
> - _HiveMetastoreImpl_
> 
> - _BaseHiveEvent_ has 2 methods:
> - getHiveMetastoreEntities: Called by HMS events.
> - getHiveEntities: Called by HS2 events.
> 
> **Approach**
> - Introduce a flag _skipDDL_ indicating if entities generated as part of DDL 
> operation should be skipped by a hook. This flag is set as a configuration 
> parameters: atlas.hive.hook.ignore.ddl.operations
> - Continue using HMS event processing unchanged.
> - New: _ActiveEntityFilter_: Initializes entity filter based on the skipDDL 
> setting.
> - New: _LineageOnlyFilter_: Retains entities that participate in lineage.
> - New: _PassthroughFilter_: Does not do any filtering.
> 
> 
> Diffs
> -
> 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/AtlasHiveHookContext.java
>  128647147 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 
> 79e87c79d 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java
>  7c269ce53 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/utils/ActiveEntityFilter.java
>  PRE-CREATION 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/utils/EntityFilter.java
>  PRE-CREATION 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/utils/HiveDDLEntityFilter.java
>  PRE-CREATION 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/utils/PassthroughFilter.java
>  PRE-CREATION 
>   
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/utils/ActiveEntityFilterTest.java
>  PRE-CREATION 
>   addons/hive-bridge/src/test/resources/atlas-application.properties 
> 898b69c99 
>   addons/hive-bridge/src/test/resources/json/hs2-alter-view-v2.json 
> PRE-CREATION 
>   addons/hive-bridge/src/test/resources/json/hs2-alter-view.json PRE-CREATION 
>   addons/hive-bridge/src/test/resources/json/hs2-create-db-v2.json 
> PRE-CREATION 
>   addons/hive-bridge/src/test/resources/json/hs2-create-db.json PRE-CREATION 
>   addons/hive-bridge/src/test/resources/json/hs2-create-process-v2.json 
> PRE-CREATION 
>   addons/hive-bridge/src/test/resources/json/hs2-create-process.json 
> PRE-CREATION 
>   addons/hive-bridge/src/test/resources/json/hs2-create-table-v2.json 
> PRE-CREATION 
>   addons/hive-bridge/src/test/resources/json/hs2-create-table.json 
> PRE-CREATION 
>   addons/hive-bridge/src/test/resources/json/hs2-drop-db-v2.json PRE-CREATION 
>   addons/hive-bridge/src/test/resources/json/hs2-drop-db.json PRE-CREATION 
>   addons/hive-bridge/src/test/resources/json/hs2-drop-table-v2.json 
> PRE-CREATION 
>   addons/hive-bridge/src/test/resources/json/hs2-drop-table.json PRE-CREATION 
>   addons/hive-bridge/src/test/resources/json/hs2-table-rename-v2.json 
> PRE-CREATION 
>   addons/hive-bridge/src/test/resources/json/hs2-

Re: Review Request 73239: HiveHook: HiveServer2 Messages Improvement

[Nikhil Bonte]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73239/#review222803
---


Ship it!





addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/utils/HiveDDLEntityFilter.java
Lines 246 (patched)
<https://reviews.apache.org/r/73239/#comment311983>

remove extra blank line



addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/utils/ActiveEntityFilterTest.java
Lines 204 (patched)
<https://reviews.apache.org/r/73239/#comment311984>

remove extra blank line



addons/hive-bridge/src/test/resources/atlas-application.properties
Lines 125 (patched)
<https://reviews.apache.org/r/73239/#comment311982>

Suggesion: rename 
atlas.hook.hive.ignore.ddl.operations  ->  
atlas.hook.hive.hs2.ignore.ddl.operations


- Nikhil Bonte


On April 10, 2021, 5:11 a.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73239/
> ---
> 
> (Updated April 10, 2021, 5:11 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4204
> https://issues.apache.org/jira/browse/ATLAS-4204
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Background**
> Please see JIRA.
> 
> Terms and abbreviations used:
> - Database objects: Database, table, views, etc.
> - DDL: Data Definition Langugage. Database parlance. Operations performed on 
> a database server that result in creation of objects that hold data.
> - DML: Data Manipulation Language. Database parlance. Operations performed on 
> a database server that result in manipulation (add, update, delete) of data. 
> These are performed using database objects that are already created.
> 
> Hive hook is implemented by:
> - _HiveHook_
> - _HiveMetastoreImpl_
> 
> - _BaseHiveEvent_ has 2 methods:
> - getHiveMetastoreEntities: Called by HMS events.
> - getHiveEntities: Called by HS2 events.
> 
> **Approach**
> - Introduce a flag _skipDDL_ indicating if entities generated as part of DDL 
> operation should be skipped by a hook. This flag is set as a configuration 
> parameters: atlas.hive.hook.ignore.ddl.operations
> - Continue using HMS event processing unchanged.
> - New: _ActiveEntityFilter_: Initializes entity filter based on the skipDDL 
> setting.
> - New: _LineageOnlyFilter_: Retains entities that participate in lineage.
> - New: _PassthroughFilter_: Does not do any filtering.
> 
> 
> Diffs
> -
> 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/AtlasHiveHookContext.java
>  128647147 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 
> 79e87c79d 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/events/BaseHiveEvent.java
>  7c269ce53 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/utils/ActiveEntityFilter.java
>  PRE-CREATION 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/utils/EntityFilter.java
>  PRE-CREATION 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/utils/HiveDDLEntityFilter.java
>  PRE-CREATION 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/utils/PassthroughFilter.java
>  PRE-CREATION 
>   
> addons/hive-bridge/src/test/java/org/apache/atlas/hive/hook/utils/ActiveEntityFilterTest.java
>  PRE-CREATION 
>   addons/hive-bridge/src/test/resources/atlas-application.properties 
> 898b69c99 
>   addons/hive-bridge/src/test/resources/json/hs2-alter-view-v2.json 
> PRE-CREATION 
>   addons/hive-bridge/src/test/resources/json/hs2-alter-view.json PRE-CREATION 
>   addons/hive-bridge/src/test/resources/json/hs2-create-db-v2.json 
> PRE-CREATION 
>   addons/hive-bridge/src/test/resources/json/hs2-create-db.json PRE-CREATION 
>   addons/hive-bridge/src/test/resources/json/hs2-create-process-v2.json 
> PRE-CREATION 
>   addons/hive-bridge/src/test/resources/json/hs2-create-process.json 
> PRE-CREATION 
>   addons/hive-bridge/src/test/resources/json/hs2-create-table-v2.json 
> PRE-CREATION 
>   addons/hive-bridge/src/test/resources/json/hs2-create-table.json 
> PRE-CREATION 
>   addons/hive-bridge/src/test/resources/json/hs2-drop-db-v2.json PRE-CREATION 
>   addons/hive-bridge/src/test/resources/json/hs2-drop-db.json PRE-CREATION 
>   addons/hive-bridge/src/test/resources/json/hs2-drop-table-v2.json 
> PRE-CREATION 
>   addons/hive-bridge/src/test/resources/json/hs2-drop-table.json PRE-CREATION 
>   addons/hive-br

[jira] [Updated] (ATLAS-4214) UI: expand/collapse Technical properies of entity audits' tab not working properly

[Nikhil Bonte (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4214?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Bonte updated ATLAS-4214:

Description: 
An entity that has at least 2 audit entries has the following issues with 
expanding/collapsing Technical properties-

Expand both audit entries, Technical properties are expanded by default,
 # Clicking on 1st audit record's Technical properties will collapse 
it(expected) along with changing the icon for 2nd audit record's Technical 
properties (it will be still in an expanded state but icon gives feel that it 
is collapsed) 
 # Clicking on the 2nd audit record's Technical properties will expand/collapse 
the 1st audit record's Technical properties while it itself remains expanded.

> UI: expand/collapse Technical properies of entity audits' tab not working 
> properly
> --
>
> Key: ATLAS-4214
> URL: https://issues.apache.org/jira/browse/ATLAS-4214
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Reporter: Nikhil Bonte
>Priority: Major
>
> An entity that has at least 2 audit entries has the following issues with 
> expanding/collapsing Technical properties-
> Expand both audit entries, Technical properties are expanded by default,
>  # Clicking on 1st audit record's Technical properties will collapse 
> it(expected) along with changing the icon for 2nd audit record's Technical 
> properties (it will be still in an expanded state but icon gives feel that it 
> is collapsed) 
>  # Clicking on the 2nd audit record's Technical properties will 
> expand/collapse the 1st audit record's Technical properties while it itself 
> remains expanded.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (ATLAS-4214) UI: expand/collapse Technical properies of entity audits' tab not working properly

[Nikhil Bonte (Jira)]

Nikhil Bonte created ATLAS-4214:
---

 Summary: UI: expand/collapse Technical properies of entity audits' 
tab not working properly
 Key: ATLAS-4214
 URL: https://issues.apache.org/jira/browse/ATLAS-4214
 Project: Atlas
  Issue Type: Bug
  Components: atlas-webui
Reporter: Nikhil Bonte






--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (ATLAS-4206) Swagger: Upload APIs does not work

[Nikhil Bonte (Jira)]

Nikhil Bonte created ATLAS-4206:
---

 Summary: Swagger: Upload APIs does not work
 Key: ATLAS-4206
 URL: https://issues.apache.org/jira/browse/ATLAS-4206
 Project: Atlas
  Issue Type: Improvement
  Components:  atlas-core
Affects Versions: 2.1.0
Reporter: Nikhil Bonte


APIs affected:

POST /v2/glossary/import
POST /v2/entity/businessmetadata/import

 
 # Swagger UI for the above APIs shows two params _fileDetail_ & _inputStream_ 
both of type _file_, the expectation is to have the only _inputStream_ to 
upload a file.
 # Param _inputStream_ have name as "_inputStream_", expected name is "_file_".



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4206) Swagger: File upload APIs does not work

[Nikhil Bonte (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Bonte updated ATLAS-4206:

Summary: Swagger: File upload APIs does not work  (was: Swagger: Upload 
APIs does not work)

> Swagger: File upload APIs does not work
> ---
>
> Key: ATLAS-4206
> URL: https://issues.apache.org/jira/browse/ATLAS-4206
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Affects Versions: 2.1.0
>Reporter: Nikhil Bonte
>Priority: Major
>  Labels: REST_API, swagger
>
> APIs affected:
> POST /v2/glossary/import
> POST /v2/entity/businessmetadata/import
>  
>  # Swagger UI for the above APIs shows two params _fileDetail_ & 
> _inputStream_ both of type _file_, the expectation is to have the only 
> _inputStream_ to upload a file.
>  # Param _inputStream_ have name as "_inputStream_", expected name is 
> "_file_".



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 73205: ATLAS-4150 : __AtlasAuditEntry appearing in metrics window

[Nikhil Bonte]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73205/#review222640
---




0001-ATLAS-4150.patch
Lines 1 (patched)
<https://reviews.apache.org/r/73205/#comment311796>

This file should not be the part of patch.
0001-ATLAS-4150.patch


- Nikhil Bonte


On March 1, 2021, 9:58 a.m., Shraddha Pardeshi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73205/
> ---
> 
> (Updated March 1, 2021, 9:58 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab and Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-4150
> https://issues.apache.org/jira/browse/ATLAS-4150
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> __Approach__:
> - Entries for AtlasAuditEntry are visible on metrics UI. 
> - But it is an system internal entity and should ideally not be visible in 
> the metrics UI.
> - So here skipping internal type from UI.
> 
> 
> Diffs
> -
> 
>   0001-ATLAS-4150.patch PRE-CREATION 
>   repository/src/main/java/org/apache/atlas/services/MetricsService.java 
> e721108d3 
>   repository/src/test/java/org/apache/atlas/services/MetricsServiceTest.java 
> bea8eb8b5 
> 
> 
> Diff: https://reviews.apache.org/r/73205/diff/1/
> 
> 
> Testing
> ---
> 
> __Unit tests__
> - Changes made in existing test.
> 
> __Manual tests__
> - Via web UI.
> 
> 
> Thanks,
> 
> Shraddha Pardeshi
> 
>

Re: Review Request 73166: Clause Change for Glossary

[Nikhil Bonte]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73166/#review222543
---


Ship it!




Ship It!

- Nikhil Bonte


On Feb. 1, 2021, 10:50 p.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73166/
> ---
> 
> (Updated Feb. 1, 2021, 10:50 p.m.)
> 
> 
> Review request for atlas, Nikhil Bonte, Pinal Shah, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4109
> https://issues.apache.org/jira/browse/ATLAS-4109
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Replaced _or_ with _where_ for simplicity.
> 
> 
> Diffs
> -
> 
>   repository/src/main/java/org/apache/atlas/query/GremlinClause.java 
> b7e5330ce 
>   
> repository/src/main/java/org/apache/atlas/query/executors/GremlinClauseToTraversalTranslator.java
>  a7b05fd88 
>   
> repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java 
> 0e8af186d 
> 
> 
> Diff: https://reviews.apache.org/r/73166/diff/1/
> 
> 
> Testing
> ---
> 
> **Unit tests**
> - Existing tests run.
> - Updated _GremlinQueryComposer_ to include the new clause.
> 
> **PC-build**
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/363/
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

[jira] [Commented] (ATLAS-4100) Recent datamodel changes (Jan 2021) broke our installation

[Nikhil Bonte (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-4100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17264633#comment-17264633
 ] 

Nikhil Bonte commented on ATLAS-4100:
-

[~nevi_me]
{quote}I can see the entity count on the sidebar
{quote}
Based on this I assume that typeDefs API returns type definitions (GET 
/v2/types/typedefs)
{quote}and inspecting the API shows that it retrieves information, but that 
information can't be shown.
{quote}
Not clear which API, but I guess you are referring to search API & it returns 
search results but results are not being rendered on UI. 

If that is the case, there might some issue with UI, please check the console 
tab from the browser's developer tools if it has any clue.
{quote}The export API isn't working,...
{quote}
Could you please tell us more about what is the issue with export API?

 

> Recent datamodel changes (Jan 2021) broke our installation
> --
>
> Key: ATLAS-4100
> URL: https://issues.apache.org/jira/browse/ATLAS-4100
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Neville Dipale
>Priority: Critical
>
> Hi Atlas developers
> We run an Atlas installation (with external Cassandra & ElasticSearch) where 
> we build Atlas via a Docker script, pointing to specific git commits.
> The last update we have was from early December 2020. Yesterday I updated to 
> the latest git tree, but after the update, the Atlas UI doesn't show 
> entities. I can see the entity count on the sidebar, and inspecting the API 
> shows that it retrieves information, but that information can't be shown.
> I suspect that the changes to the cloud datamodel could be the cause (or at 
> least one of the causes). ATLAS-4082 created patches to the Azure entity 
> definitions, but ATLAS-4083 directly modified the entity definitions. I can't 
> definitively pinpoint the issue, but I noticed the issue with no longer being 
> able to view data, after trying to apply the changes to ATLAS-4083 to our 
> installation.
> The export API isn't working, so we have no viable alternative but to try 
> extract the data manually from Cassandra, or worse, to destroy our data & 
> start from scratch.
> Further, I unfortunately don't have any logs to attach, because in order for 
> us to run Atlas with LDAP integration + a keystore file, the way we run Atlas 
> (going in the container to manually start each time) doesn't output logs, 
> even though we have configured the log4j.xml file propertly.
> I suppose I'm opening this in case other people come across this issue.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

[Nikhil Bonte]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73128/#review222441
---




repository/src/main/java/org/apache/atlas/query/executors/TraversalBasedExecutor.java
Lines 83 (patched)
<https://reviews.apache.org/r/73128/#comment311498>

Need to handle limit & offset here.
Assume you have 30 columns
query: "Column groupby (name)" will return all the 30 columns
Same behaviour if limit is passed in query.


- Nikhil Bonte


On Jan. 11, 2021, 12:27 p.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73128/
> ---
> 
> (Updated Jan. 11, 2021, 12:27 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Nikhil Bonte, Nixon Rodrigues, Pinal 
> Shah, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2932
> https://issues.apache.org/jira/browse/ATLAS-2932
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Approach**
> General Approach:
> - Ensure that Gremlin-based implementation continues to function. This will 
> ensure backward compatibility and will guarad against regressions or behavior 
> deviations, if any, are introduced with the new implementation.
> - Continue using existing _GremlinQueryComposer_. 
> - Translate the clauses to _AtlasGraphTraversal_.
> - Projects that were earlier handled in Gremlin query are now handled in a 
> separate Java class.
> 
> Details:
> - Modified: _GremlinQueryComposer_: Continue composing queries using existing 
> claues. Additions alone.
> - New: _DSLQueryExecutor_ Instantiates old or new executor based on flag.
> - Modifed: _EntityDiscoveryService_ uses the new exectors.
> - New _GremlinToTraversalTranslator_: Converts Gremlin clauses to 
> _AtlasGraphTraversal_.
> - Modified: _AtlasGraphTraversal_: Additional methods.
> - New: _SelectClauseProjections_: All queries with select operations.
> 
> **Credits**
> - Apoorv Naik (apoorvnaik): Original implementation.
> - Nikhil Bonte (nbonte): Continued on Apoorv's implementation and addressed 
> short-comings.
> 
> 
> Diffs
> -
> 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraph.java 
> c016f6340 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphTraversal.java
>  881bb1e0f 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraph.java
>  0dd573b89 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphTraversal.java
>  c33c4f4d0 
>   intg/src/main/java/org/apache/atlas/AtlasConfiguration.java ea9f26d47 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  01a6c303a 
>   repository/src/main/java/org/apache/atlas/query/AtlasDSL.java b8a744b35 
>   repository/src/main/java/org/apache/atlas/query/GremlinClause.java 
> 9704b0f9e 
>   repository/src/main/java/org/apache/atlas/query/GremlinClauseList.java 
> 9f30e4dc0 
>   repository/src/main/java/org/apache/atlas/query/GremlinQuery.java 531f7ae86 
>   repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java 
> 249381059 
>   repository/src/main/java/org/apache/atlas/query/SelectClauseComposer.java 
> 969fcd2b1 
>   
> repository/src/main/java/org/apache/atlas/query/executors/DSLQueryExecutor.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/query/executors/GremlinClauseToTraversalTranslator.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/query/executors/ScriptEngineBasedExecutor.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/query/executors/SelectClauseProjections.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/query/executors/TraversalBasedExecutor.java
>  PRE-CREATION 
>   repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 
> 3bb3b07bf 
> 
> 
> Diff: https://reviews.apache.org/r/73128/diff/2/
> 
> 
> Testing
> ---
> 
> **Unit Tests**
> - Additional tests.
> - _GremlinCompoerTest_ continues to validate the clause creation.
> - Improved validation for _minMaxCount_ tests.
> - Refactored: _TableValidator_ Validates output from a query with select 
> claues.
> 
> **Volume Tests**
> - Old implementation: 528 queries take over 10 mins to execute.
> - New implemeentations: 528 queries execute in 7 secs.
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

[Nikhil Bonte]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73128/#review222442
---




repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java
Lines 589-598 (original), 613-622 (patched)
<https://reviews.apache.org/r/73128/#comment311499>

enable & validate these queries


- Nikhil Bonte


On Jan. 11, 2021, 12:27 p.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73128/
> ---
> 
> (Updated Jan. 11, 2021, 12:27 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Nikhil Bonte, Nixon Rodrigues, Pinal 
> Shah, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2932
> https://issues.apache.org/jira/browse/ATLAS-2932
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Approach**
> General Approach:
> - Ensure that Gremlin-based implementation continues to function. This will 
> ensure backward compatibility and will guarad against regressions or behavior 
> deviations, if any, are introduced with the new implementation.
> - Continue using existing _GremlinQueryComposer_. 
> - Translate the clauses to _AtlasGraphTraversal_.
> - Projects that were earlier handled in Gremlin query are now handled in a 
> separate Java class.
> 
> Details:
> - Modified: _GremlinQueryComposer_: Continue composing queries using existing 
> claues. Additions alone.
> - New: _DSLQueryExecutor_ Instantiates old or new executor based on flag.
> - Modifed: _EntityDiscoveryService_ uses the new exectors.
> - New _GremlinToTraversalTranslator_: Converts Gremlin clauses to 
> _AtlasGraphTraversal_.
> - Modified: _AtlasGraphTraversal_: Additional methods.
> - New: _SelectClauseProjections_: All queries with select operations.
> 
> **Credits**
> - Apoorv Naik (apoorvnaik): Original implementation.
> - Nikhil Bonte (nbonte): Continued on Apoorv's implementation and addressed 
> short-comings.
> 
> 
> Diffs
> -
> 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraph.java 
> c016f6340 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphTraversal.java
>  881bb1e0f 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraph.java
>  0dd573b89 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphTraversal.java
>  c33c4f4d0 
>   intg/src/main/java/org/apache/atlas/AtlasConfiguration.java ea9f26d47 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  01a6c303a 
>   repository/src/main/java/org/apache/atlas/query/AtlasDSL.java b8a744b35 
>   repository/src/main/java/org/apache/atlas/query/GremlinClause.java 
> 9704b0f9e 
>   repository/src/main/java/org/apache/atlas/query/GremlinClauseList.java 
> 9f30e4dc0 
>   repository/src/main/java/org/apache/atlas/query/GremlinQuery.java 531f7ae86 
>   repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java 
> 249381059 
>   repository/src/main/java/org/apache/atlas/query/SelectClauseComposer.java 
> 969fcd2b1 
>   
> repository/src/main/java/org/apache/atlas/query/executors/DSLQueryExecutor.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/query/executors/GremlinClauseToTraversalTranslator.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/query/executors/ScriptEngineBasedExecutor.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/query/executors/SelectClauseProjections.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/query/executors/TraversalBasedExecutor.java
>  PRE-CREATION 
>   repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 
> 3bb3b07bf 
> 
> 
> Diff: https://reviews.apache.org/r/73128/diff/2/
> 
> 
> Testing
> ---
> 
> **Unit Tests**
> - Additional tests.
> - _GremlinCompoerTest_ continues to validate the clause creation.
> - Improved validation for _minMaxCount_ tests.
> - Refactored: _TableValidator_ Validates output from a query with select 
> claues.
> 
> **Volume Tests**
> - Old implementation: 528 queries take over 10 mins to execute.
> - New implemeentations: 528 queries execute in 7 secs.
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Re: Review Request 73128: DSL: Using AtlasTraversal Instead of Gremlin

[Nikhil Bonte]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73128/#review222440
---




repository/src/main/java/org/apache/atlas/query/executors/TraversalBasedExecutor.java
Lines 80 (patched)
<https://reviews.apache.org/r/73128/#comment311497>

Remove TODO, this block gets executed. e.g. query :
hive_column groupby (name)


- Nikhil Bonte


On Jan. 11, 2021, 12:27 p.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73128/
> ---
> 
> (Updated Jan. 11, 2021, 12:27 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Nikhil Bonte, Nixon Rodrigues, Pinal 
> Shah, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2932
> https://issues.apache.org/jira/browse/ATLAS-2932
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Approach**
> General Approach:
> - Ensure that Gremlin-based implementation continues to function. This will 
> ensure backward compatibility and will guarad against regressions or behavior 
> deviations, if any, are introduced with the new implementation.
> - Continue using existing _GremlinQueryComposer_. 
> - Translate the clauses to _AtlasGraphTraversal_.
> - Projects that were earlier handled in Gremlin query are now handled in a 
> separate Java class.
> 
> Details:
> - Modified: _GremlinQueryComposer_: Continue composing queries using existing 
> claues. Additions alone.
> - New: _DSLQueryExecutor_ Instantiates old or new executor based on flag.
> - Modifed: _EntityDiscoveryService_ uses the new exectors.
> - New _GremlinToTraversalTranslator_: Converts Gremlin clauses to 
> _AtlasGraphTraversal_.
> - Modified: _AtlasGraphTraversal_: Additional methods.
> - New: _SelectClauseProjections_: All queries with select operations.
> 
> **Credits**
> - Apoorv Naik (apoorvnaik): Original implementation.
> - Nikhil Bonte (nbonte): Continued on Apoorv's implementation and addressed 
> short-comings.
> 
> 
> Diffs
> -
> 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraph.java 
> c016f6340 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphTraversal.java
>  881bb1e0f 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraph.java
>  0dd573b89 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphTraversal.java
>  c33c4f4d0 
>   intg/src/main/java/org/apache/atlas/AtlasConfiguration.java ea9f26d47 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  01a6c303a 
>   repository/src/main/java/org/apache/atlas/query/AtlasDSL.java b8a744b35 
>   repository/src/main/java/org/apache/atlas/query/GremlinClause.java 
> 9704b0f9e 
>   repository/src/main/java/org/apache/atlas/query/GremlinClauseList.java 
> 9f30e4dc0 
>   repository/src/main/java/org/apache/atlas/query/GremlinQuery.java 531f7ae86 
>   repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java 
> 249381059 
>   repository/src/main/java/org/apache/atlas/query/SelectClauseComposer.java 
> 969fcd2b1 
>   
> repository/src/main/java/org/apache/atlas/query/executors/DSLQueryExecutor.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/query/executors/GremlinClauseToTraversalTranslator.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/query/executors/ScriptEngineBasedExecutor.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/query/executors/SelectClauseProjections.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/query/executors/TraversalBasedExecutor.java
>  PRE-CREATION 
>   repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 
> 3bb3b07bf 
> 
> 
> Diff: https://reviews.apache.org/r/73128/diff/2/
> 
> 
> Testing
> ---
> 
> **Unit Tests**
> - Additional tests.
> - _GremlinCompoerTest_ continues to validate the clause creation.
> - Improved validation for _minMaxCount_ tests.
> - Refactored: _TableValidator_ Validates output from a query with select 
> claues.
> 
> **Volume Tests**
> - Old implementation: 528 queries take over 10 mins to execute.
> - New implemeentations: 528 queries execute in 7 secs.
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

[jira] [Updated] (ATLAS-3913) Swagger documentation for APIs

[Nikhil Bonte (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Bonte updated ATLAS-3913:

Attachment: how_to_navigate.png
swagger_rest_api_doc_page.png

> Swagger documentation for APIs
> --
>
> Key: ATLAS-3913
> URL: https://issues.apache.org/jira/browse/ATLAS-3913
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core, atlas-webui
>Affects Versions: 2.1.0
>Reporter: Nikhil Bonte
>    Assignee: Nikhil Bonte
>Priority: Major
>  Labels: REST_API, swagger
> Fix For: 3.0.0, 2.2.0
>
> Attachments: how_to_navigate.png, swagger_rest_api_doc_page.png
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Current packaging does not package swagger ui into Atlas war.
> This change will pack swagger ui into the war file.
> Also update enunciate version from 2.11.1 to 2.13.2 
> h3. Approach:
>  * Update enuntiate plugin version from 2.11.1 to 2.13.2
>  * Download latest swagger-ui from 
> [https://github.com/swagger-api/swagger-ui/archive/v3.36.2.zip] & extract.
>  * Move swagger-ui-3.36.2/dist/ to 
> build-tools/src/main/resources/ui-dist
>  * Update swagger tag in enuntiate.xml
>  * Inside build-tools/src/main/resources/ui-dist :
>  * Create index.js
>  * Modify SwaggerUIBundle object in ui-dist/index.html to load index.js along 
> with following:
>  1.  Modify url to load swagger.json
>  2.  Add requestInterceptor
>  * Updated Header.js, UrlLinks.js, Header.html to add API documentation menu.
>  
> h3. How to navigate to the documentation page?
> -> Once Atlas UI is loaded, goto Logged-in-User -> Help -> API Documentation 
> (see attached screenshot for reference)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3913) Swagger documentation for APIs

[Nikhil Bonte (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Bonte updated ATLAS-3913:

Description: 
Current packaging does not package swagger ui into Atlas war.

This change will pack swagger ui into the war file.

Also update enunciate version from 2.11.1 to 2.13.2 
h3. Approach:
 * Update enuntiate plugin version from 2.11.1 to 2.13.2
 * Download latest swagger-ui from 
[https://github.com/swagger-api/swagger-ui/archive/v3.36.2.zip] & extract.
 * Move swagger-ui-3.36.2/dist/ to 
build-tools/src/main/resources/ui-dist
 * Update swagger tag in enuntiate.xml
 * Inside build-tools/src/main/resources/ui-dist :
 * Create index.js
 * Modify SwaggerUIBundle object in ui-dist/index.html to load index.js along 
with following:
 1.  Modify url to load swagger.json
 2.  Add requestInterceptor
 * Updated Header.js, UrlLinks.js, Header.html to add API documentation menu.

 
h3. How to navigate to the documentation page?

-> Once Atlas UI is loaded, goto Logged-in-User -> Help -> API Documentation 
(see attached screenshot for reference)

  was:
Current packaging does not package swagger ui into Atlas war.

This change will pack swagger ui into the war file.

Also update enunciate version from 2.11.1 to 2.13.2
 
h2. Approach:
  * Update enuntiate plugin version from 2.11.1 to 2.13.2
 * Download latest swagger-ui from 
[https://github.com/swagger-api/swagger-ui/archive/v3.36.2.zip] & extract.
 * Move swagger-ui-3.36.2/dist/ to 
build-tools/src/main/resources/ui-dist
 * Update swagger tag in enuntiate.xml
 * Inside build-tools/src/main/resources/ui-dist :
 * Create index.js
 * Modify SwaggerUIBundle object in ui-dist/index.html to load index.js along 
with following:
 1 modify url to load swagger.json
 2 Add requestInterceptor
 * Updated Header.js, UrlLinks.js, Header.html to add API documentation menu.

 
h2. How to navigate to the documentation page?
-> Once Atlas UI is loaded, goto Logged-in-User -> Help -> API Documentation 
(see attached screenshot for reference)


> Swagger documentation for APIs
> --
>
> Key: ATLAS-3913
> URL: https://issues.apache.org/jira/browse/ATLAS-3913
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core, atlas-webui
>Affects Versions: 2.1.0
>        Reporter: Nikhil Bonte
>Assignee: Nikhil Bonte
>Priority: Major
>  Labels: REST_API, swagger
> Fix For: 3.0.0, 2.2.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Current packaging does not package swagger ui into Atlas war.
> This change will pack swagger ui into the war file.
> Also update enunciate version from 2.11.1 to 2.13.2 
> h3. Approach:
>  * Update enuntiate plugin version from 2.11.1 to 2.13.2
>  * Download latest swagger-ui from 
> [https://github.com/swagger-api/swagger-ui/archive/v3.36.2.zip] & extract.
>  * Move swagger-ui-3.36.2/dist/ to 
> build-tools/src/main/resources/ui-dist
>  * Update swagger tag in enuntiate.xml
>  * Inside build-tools/src/main/resources/ui-dist :
>  * Create index.js
>  * Modify SwaggerUIBundle object in ui-dist/index.html to load index.js along 
> with following:
>  1.  Modify url to load swagger.json
>  2.  Add requestInterceptor
>  * Updated Header.js, UrlLinks.js, Header.html to add API documentation menu.
>  
> h3. How to navigate to the documentation page?
> -> Once Atlas UI is loaded, goto Logged-in-User -> Help -> API Documentation 
> (see attached screenshot for reference)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3913) Swagger documentation for APIs

[Nikhil Bonte (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Bonte updated ATLAS-3913:

Description: 
Current packaging does not package swagger ui into Atlas war.

This change will pack swagger ui into the war file.

Also update enunciate version from 2.11.1 to 2.13.2
 
h2. Approach:
  * Update enuntiate plugin version from 2.11.1 to 2.13.2
 * Download latest swagger-ui from 
[https://github.com/swagger-api/swagger-ui/archive/v3.36.2.zip] & extract.
 * Move swagger-ui-3.36.2/dist/ to 
build-tools/src/main/resources/ui-dist
 * Update swagger tag in enuntiate.xml
 * Inside build-tools/src/main/resources/ui-dist :
 * Create index.js
 * Modify SwaggerUIBundle object in ui-dist/index.html to load index.js along 
with following:
 1 modify url to load swagger.json
 2 Add requestInterceptor
 * Updated Header.js, UrlLinks.js, Header.html to add API documentation menu.

 
h2. How to navigate to the documentation page?
-> Once Atlas UI is loaded, goto Logged-in-User -> Help -> API Documentation 
(see attached screenshot for reference)

  was:
Current packaging does not package swagger ui into Atlas war.

This change will pack swagger ui into the war file.

Also update enunciate version from 2.11.1 to 2.13.2


> Swagger documentation for APIs
> --
>
> Key: ATLAS-3913
> URL: https://issues.apache.org/jira/browse/ATLAS-3913
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core, atlas-webui
>Affects Versions: 2.1.0
>Reporter: Nikhil Bonte
>Assignee: Nikhil Bonte
>Priority: Major
>  Labels: REST_API, swagger
> Fix For: 3.0.0, 2.2.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Current packaging does not package swagger ui into Atlas war.
> This change will pack swagger ui into the war file.
> Also update enunciate version from 2.11.1 to 2.13.2
>  
> h2. Approach:
>   * Update enuntiate plugin version from 2.11.1 to 2.13.2
>  * Download latest swagger-ui from 
> [https://github.com/swagger-api/swagger-ui/archive/v3.36.2.zip] & extract.
>  * Move swagger-ui-3.36.2/dist/ to 
> build-tools/src/main/resources/ui-dist
>  * Update swagger tag in enuntiate.xml
>  * Inside build-tools/src/main/resources/ui-dist :
>  * Create index.js
>  * Modify SwaggerUIBundle object in ui-dist/index.html to load index.js along 
> with following:
>  1 modify url to load swagger.json
>  2 Add requestInterceptor
>  * Updated Header.js, UrlLinks.js, Header.html to add API documentation menu.
>  
> h2. How to navigate to the documentation page?
> -> Once Atlas UI is loaded, goto Logged-in-User -> Help -> API Documentation 
> (see attached screenshot for reference)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3913) Swagger documentation for APIs

[Nikhil Bonte (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Bonte updated ATLAS-3913:

Description: 
Current packaging does not package swagger ui into Atlas war.

This change will pack swagger ui into the war file.

Also update enunciate version from 2.11.1 to 2.13.2

  was:
Current packaging does not package swagger ui into Atlas war.

This change will pack swagger ui into the war file.

Also update enunciate version from 2.11.1 to 2.13.1


> Swagger documentation for APIs
> --
>
> Key: ATLAS-3913
> URL: https://issues.apache.org/jira/browse/ATLAS-3913
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core, atlas-webui
>Affects Versions: 2.1.0
>Reporter: Nikhil Bonte
>    Assignee: Nikhil Bonte
>Priority: Major
>  Labels: REST_API, swagger
> Fix For: 3.0.0, 2.2.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Current packaging does not package swagger ui into Atlas war.
> This change will pack swagger ui into the war file.
> Also update enunciate version from 2.11.1 to 2.13.2



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (ATLAS-3913) Swagger documentation for APIs

[Nikhil Bonte (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Bonte resolved ATLAS-3913.
-
Resolution: Fixed

> Swagger documentation for APIs
> --
>
> Key: ATLAS-3913
> URL: https://issues.apache.org/jira/browse/ATLAS-3913
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core, atlas-webui
>Affects Versions: 2.1.0
>Reporter: Nikhil Bonte
>    Assignee: Nikhil Bonte
>Priority: Major
>  Labels: REST_API, swagger
> Fix For: 3.0.0, 2.2.0
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Current packaging does not package swagger ui into Atlas war.
> This change will pack swagger ui into the war file.
> Also update enunciate version from 2.11.1 to 2.13.1



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: [ANNOUNCE] Apache Atlas - Swagger REST API documentation

[Nikhil Bonte]

Attaching screenshots...

On Mon, Dec 7, 2020 at 1:50 PM Nikhil Bonte  wrote:

> All,
>
> The Swagger REST API documentation for Apache Atlas is now available.
>
> It provides an interactive interface to try out all the REST APIs
> supported by Atlas (types, entities, glossaries, lineages, relationships
> and search).
>
> How to navigate to the API documentation page?
> -> Once Atlas UI is loaded, Navigate to Logged-in-User -> Help -> API
> Documentation (see attached screenshot for reference)
>
> Apache Atlas will be updating its website to include details about this
> REST API doc. Feedback and suggestions are welcome.
>
>
> Thanks,
> Nikhil P Bonte
>


-- 
Regards
Nikhil P. Bonte

[ANNOUNCE] Apache Atlas - Swagger REST API documentation

[Nikhil Bonte]

All,

The Swagger REST API documentation for Apache Atlas is now available.

It provides an interactive interface to try out all the REST APIs supported
by Atlas (types, entities, glossaries, lineages, relationships and search).

How to navigate to the API documentation page?
-> Once Atlas UI is loaded, Navigate to Logged-in-User -> Help -> API
Documentation (see attached screenshot for reference)

Apache Atlas will be updating its website to include details about this
REST API doc. Feedback and suggestions are welcome.


Thanks,
Nikhil P Bonte

Re: Review Request 73057: ATLAS-3913 Swagger documentation for APIs

[Nikhil Bonte]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73057/
---

(Updated Dec. 3, 2020, 12:29 p.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
Nixon Rodrigues, Sameer Shaikh, and Sarath Subramanian.


Changes
---

* Disabled validation of swagger specs
* Changed the tab icon


Bugs: ATLAS-3913
https://issues.apache.org/jira/browse/ATLAS-3913


Repository: atlas


Description
---

Currently, swagger documentation is not available with packaging.
This change will allow atlas server deployment to host its REST API doc using 
Swagger.

## Approach:

* Update enuntiate plugin version from 2.11.1 to 2.13.2
* Download latest swagger-ui from 
https://github.com/swagger-api/swagger-ui/archive/v3.36.2.zip & extract.
* Move swagger-ui-3.36.2/dist/ to 
build-tools/src/main/resources/ui-dist
* Update swagger tag in enuntiate.xml
* Inside build-tools/src/main/resources/ui-dist :
* Create index.js
* Modify SwaggerUIBundle object in ui-dist/index.html to load index.js 
along with following:
1 modify url to load swagger.json
2 Add requestInterceptor
* Updated Header.js, UrlLinks.js, Header.html to add API documentation menu.


## How to navigate to the documentation page?

-> Once Atlas UI is loaded, goto Logged-in-User -> Help -> API Documentation 
(see attached screenshot for reference)


Diffs (updated)
-

  3party-licenses/normalize.css-LICENSE PRE-CREATION 
  3party-licenses/swagger-ui-LECENSE PRE-CREATION 
  build-tools/src/main/resources/enunciate.xml 8a9383a01 
  build-tools/src/main/resources/ui-dist/index.html PRE-CREATION 
  build-tools/src/main/resources/ui-dist/index.js PRE-CREATION 
  build-tools/src/main/resources/ui-dist/swagger-ui-bundle.js PRE-CREATION 
  build-tools/src/main/resources/ui-dist/swagger-ui-standalone-preset.js 
PRE-CREATION 
  build-tools/src/main/resources/ui-dist/swagger-ui.css PRE-CREATION 
  dashboardv2/public/js/templates/site/Header.html 97e124aaa 
  dashboardv2/public/js/utils/UrlLinks.js 6d3c07952 
  dashboardv2/public/js/views/site/Header.js 2d6b55d47 
  dashboardv3/public/js/templates/site/Header.html 6d5e6efac 
  dashboardv3/public/js/utils/UrlLinks.js 69e527442 
  dashboardv3/public/js/views/site/Header.js cce00c730 
  pom.xml ba9450c16 
  webapp/pom.xml fe5dc0bdb 


Diff: https://reviews.apache.org/r/73057/diff/3/

Changes: https://reviews.apache.org/r/73057/diff/2-3/


Testing
---

Tested few APIs (POST | GET| DELETE) manually.


File Attachments


How-to-navigate-to-the-documentation-page
  
https://reviews.apache.org/media/uploaded/files/2020/12/02/8fe22101-fbf8-4ab2-87d9-6bfee0949845__99964008-a62afe80-2db8-11eb-8ecd-cea617fe7f4a.png


Thanks,

Nikhil Bonte

Re: Review Request 73057: ATLAS-3913 Swagger documentation for APIs

[Nikhil Bonte]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73057/
---

(Updated Dec. 2, 2020, 2:33 p.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
Nixon Rodrigues, Sameer Shaikh, and Sarath Subramanian.


Changes
---

Updated reviewers details


Bugs: ATLAS-3913
https://issues.apache.org/jira/browse/ATLAS-3913


Repository: atlas


Description (updated)
---

Currently, swagger documentation is not available with packaging.
This change will allow atlas server deployment to host its REST API doc using 
Swagger.

## Approach:

* Update enuntiate plugin version from 2.11.1 to 2.13.2
* Download latest swagger-ui from 
https://github.com/swagger-api/swagger-ui/archive/v3.36.2.zip & extract.
* Move swagger-ui-3.36.2/dist/ to 
build-tools/src/main/resources/ui-dist
* Update swagger tag in enuntiate.xml
* Inside build-tools/src/main/resources/ui-dist :
* Create index.js
* Modify SwaggerUIBundle object in ui-dist/index.html to load index.js 
along with following:
1 modify url to load swagger.json
2 Add requestInterceptor
* Updated Header.js, UrlLinks.js, Header.html to add API documentation menu.


## How to navigate to the documentation page?

-> Once Atlas UI is loaded, goto Logged-in-User -> Help -> API Documentation 
(see attached screenshot for reference)


Diffs
-

  3party-licenses/normalize.css-LICENSE PRE-CREATION 
  3party-licenses/swagger-ui-LECENSE PRE-CREATION 
  build-tools/src/main/resources/enunciate.xml 8a9383a01 
  build-tools/src/main/resources/ui-dist/favicon-16x16.png PRE-CREATION 
  build-tools/src/main/resources/ui-dist/favicon-32x32.png PRE-CREATION 
  build-tools/src/main/resources/ui-dist/index.html PRE-CREATION 
  build-tools/src/main/resources/ui-dist/index.js PRE-CREATION 
  build-tools/src/main/resources/ui-dist/swagger-ui-bundle.js PRE-CREATION 
  build-tools/src/main/resources/ui-dist/swagger-ui-standalone-preset.js 
PRE-CREATION 
  build-tools/src/main/resources/ui-dist/swagger-ui.css PRE-CREATION 
  dashboardv2/public/js/templates/site/Header.html 97e124aaa 
  dashboardv2/public/js/utils/UrlLinks.js 6d3c07952 
  dashboardv2/public/js/views/site/Header.js 2d6b55d47 
  dashboardv3/public/js/templates/site/Header.html 6d5e6efac 
  dashboardv3/public/js/utils/UrlLinks.js 69e527442 
  dashboardv3/public/js/views/site/Header.js cce00c730 
  pom.xml ba9450c16 
  webapp/pom.xml fe5dc0bdb 


Diff: https://reviews.apache.org/r/73057/diff/2/


Testing (updated)
---

Tested few APIs (POST | GET| DELETE) manually.


File Attachments


How-to-navigate-to-the-documentation-page
  
https://reviews.apache.org/media/uploaded/files/2020/12/02/8fe22101-fbf8-4ab2-87d9-6bfee0949845__99964008-a62afe80-2db8-11eb-8ecd-cea617fe7f4a.png


Thanks,

Nikhil Bonte

Re: Review Request 73046: ATLAS-4055 Basic search doesn't work if the search text has special characters

[Nikhil Bonte]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73046/#review43
---


Ship it!




Ship It!

- Nikhil Bonte


On Nov. 26, 2020, 9:46 a.m., Jayendra Parab wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73046/
> ---
> 
> (Updated Nov. 26, 2020, 9:46 a.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-4055
> https://issues.apache.org/jira/browse/ATLAS-4055
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> If the search text has a special character (i.e, one of + - & | ! ( ) { } [ ] 
> ^ " ~ * ? : \ /), then we need to enclose the search text in double quotes. 
> This change is required in addition to the changes provided in ATLAS-3983
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 28d2e23c4 
> 
> 
> Diff: https://reviews.apache.org/r/73046/diff/2/
> 
> 
> Testing
> ---
> 
> - Created entities with all the special characters in the name and qualified 
> name attribute
> - Tried basic search with attributes to search the name and qualified name
> - The search result included the appropriate entity that was matching the 
> search criteria
> 
> 
> Thanks,
> 
> Jayendra Parab
> 
>

Re: Review Request 72991: Export/Import: Add Support for BusinessMetadata Attributes

[Nikhil Bonte]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72991/#review222187
---


Ship it!




Ship It!

- Nikhil Bonte


On Nov. 10, 2020, 12:21 a.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72991/
> ---
> 
> (Updated Nov. 10, 2020, 12:21 a.m.)
> 
> 
> Review request for atlas, Nikhil Bonte and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4006 and ATLAS-4007
> https://issues.apache.org/jira/browse/ATLAS-4006
> https://issues.apache.org/jira/browse/ATLAS-4007
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Background**
> Existing implementation does not support export and import of _Business 
> Metadata_ (BM) attributes. 
> 
> **Implementation**
> - Export: Updated existing flow to include detecting BM attributes and adding 
> the types to the exported payload.
> - Import: Updated _TypeAttributeDifference_ to include BM attribute detection 
> and update.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/AtlasServerService.java
>  542106f36 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java
>  0491a853a 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportTypeProcessor.java
>  664af9166 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ImportTypeDefProcessor.java
>  b65807742 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/TypeAttributeDifference.java
>  0d78dbe57 
>   
> repository/src/test/java/org/apache/atlas/repository/impexp/TypeAttributeDifferenceTest.java
>  f9b7cd11f 
>   repository/src/test/resources/json/typesDef-bm.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72991/diff/3/
> 
> 
> Testing
> ---
> 
> **Unit tests**
> New tests added.
> 
> **Functional testing**
> End-to-end tests. (Export-import-export).
> 
> **Pre-commit Build**
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/154/
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/179/
> 
> 
> File Attachments
> 
> 
> Stocks with BM
>   
> https://reviews.apache.org/media/uploaded/files/2020/10/29/8ea9511f-3b0e-4b27-96cb-e5f2f50ba75d__stocks-bm.zip
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

[jira] [Commented] (ATLAS-3816) Backport: Basic search issue with IndexSerializer

[Nikhil Bonte (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17224521#comment-17224521
 ] 

Nikhil Bonte commented on ATLAS-3816:
-

committed to branch-0.8 - 63e3d5c9e5e74f1110d80c7bcfce970725504888

[https://github.com/apache/atlas/commit/63e3d5c9e5e74f1110d80c7bcfce970725504888]

 

> Backport: Basic search issue with IndexSerializer
> -
>
> Key: ATLAS-3816
> URL: https://issues.apache.org/jira/browse/ATLAS-3816
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.8.4
>    Reporter: Nikhil Bonte
>Assignee: Nikhil Bonte
>Priority: Major
> Fix For: 0.8.4
>
> Attachments: 
> ATLAS-3816-Backport-Basic-search-issue-with-IndexSer-v2.patch
>
>
> *Background:*
> Atlas instance with property 
> _"atlas.use.index.query.to.find.entity.by.unique.attributes=true"_
> Direct index query which has pattern *"v."* throws exception, e.g.
>  
> v."Referenceable.qualifiedName":"atscale_agg_in{color:#ff}v.{color}as_agg_2cfb287d_dal_fixed_inco@edldev"
>  
> This will throw 
> {code:java}
> java.lang.IllegalArgumentException: Found reference to non-existant property 
> key in query at position...{code}
>  
> *Solution:*
> Backporting  ATLAS-2371.
> It is resolved with janusgraph, for titan implementation backporting required.
> Query will be :  
> *$v$*"Referenceable.qualifiedName":"atscale_agg_in{color:#ff}v.{color}as_agg_2cfb287d_dal_fixed_inco@edldev"
>  
> Default value for index search prefix is _"$v$"_
> Can be changed using the property _"atlas.graph.index.search.vertex.prefix"_
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3816) Backport: Basic search issue with IndexSerializer

[Nikhil Bonte (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Bonte updated ATLAS-3816:

Fix Version/s: 0.8.4

> Backport: Basic search issue with IndexSerializer
> -
>
> Key: ATLAS-3816
> URL: https://issues.apache.org/jira/browse/ATLAS-3816
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.8.4
>    Reporter: Nikhil Bonte
>Assignee: Nikhil Bonte
>Priority: Major
> Fix For: 0.8.4
>
> Attachments: 
> ATLAS-3816-Backport-Basic-search-issue-with-IndexSer-v2.patch
>
>
> *Background:*
> Atlas instance with property 
> _"atlas.use.index.query.to.find.entity.by.unique.attributes=true"_
> Direct index query which has pattern *"v."* throws exception, e.g.
>  
> v."Referenceable.qualifiedName":"atscale_agg_in{color:#ff}v.{color}as_agg_2cfb287d_dal_fixed_inco@edldev"
>  
> This will throw 
> {code:java}
> java.lang.IllegalArgumentException: Found reference to non-existant property 
> key in query at position...{code}
>  
> *Solution:*
> Backporting  ATLAS-2371.
> It is resolved with janusgraph, for titan implementation backporting required.
> Query will be :  
> *$v$*"Referenceable.qualifiedName":"atscale_agg_in{color:#ff}v.{color}as_agg_2cfb287d_dal_fixed_inco@edldev"
>  
> Default value for index search prefix is _"$v$"_
> Can be changed using the property _"atlas.graph.index.search.vertex.prefix"_
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (ATLAS-4008) Cache getGuid and getStatus in GraphTransactionInterceptor

[Nikhil Bonte (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Bonte resolved ATLAS-4008.
-
Fix Version/s: 2.2.0
   3.0.0
   Resolution: Done

> Cache getGuid and getStatus in GraphTransactionInterceptor
> --
>
> Key: ATLAS-4008
> URL: https://issues.apache.org/jira/browse/ATLAS-4008
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>    Reporter: Nikhil Bonte
>Assignee: Nikhil Bonte
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: 
> ATLAS-4008-Cache-getGuid-and-getStatus-in-GraphTrans-v1.patch
>
>
> *Problem Statement:*
> GraphHelper.getGuid() & GraphHelper.getStatus() causes overhead when called 
> multiple times in a same request.
>  
> *Approach:*
> Implement a caching mechanism in GraphTransactionInterceptor to cache the 
> following mappings:
> *vertexID -> guid*
> *vertexID -> entityStatus*
> *edgeId -> status*



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4008) Cache getGuid and getStatus in GraphTransactionInterceptor

[Nikhil Bonte (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Bonte updated ATLAS-4008:

Attachment: ATLAS-4008-Cache-getGuid-and-getStatus-in-GraphTrans-v1.patch

> Cache getGuid and getStatus in GraphTransactionInterceptor
> --
>
> Key: ATLAS-4008
> URL: https://issues.apache.org/jira/browse/ATLAS-4008
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>    Reporter: Nikhil Bonte
>Assignee: Nikhil Bonte
>Priority: Major
> Attachments: 
> ATLAS-4008-Cache-getGuid-and-getStatus-in-GraphTrans-v1.patch
>
>
> *Problem Statement:*
> GraphHelper.getGuid() & GraphHelper.getStatus() causes overhead when called 
> multiple times in a same request.
>  
> *Approach:*
> Implement a caching mechanism in GraphTransactionInterceptor to cache the 
> following mappings:
> *vertexID -> guid*
> *vertexID -> entityStatus*
> *edgeId -> status*



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4008) Cache getGuid and getStatus in GraphTransactionInterceptor

[Nikhil Bonte (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Bonte updated ATLAS-4008:

Description: 
*Problem Statement:*

GraphHelper.getGuid() & GraphHelper.getStatus() causes overhead when called 
multiple times in a same request.

 

*Approach:*

Implement a caching mechanism in GraphTransactionInterceptor to cache the 
following mappings:

*vertexID -> guid*

*vertexID -> entityStatus*

*edgeId -> status*

  was:
*Problem Statement:*

GraphHelper.getGuid() & GraphHelper.getStatus() causes overhead when called 
multiple times in a same request.

 

*Approach:*

Implement a caching mechanism in GraphTransactionInterceptor to cache the 
following mappings:

*vertexID -> guid*

*vertexID -> entityStatus*


> Cache getGuid and getStatus in GraphTransactionInterceptor
> --
>
> Key: ATLAS-4008
> URL: https://issues.apache.org/jira/browse/ATLAS-4008
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Reporter: Nikhil Bonte
>Assignee: Nikhil Bonte
>Priority: Major
>
> *Problem Statement:*
> GraphHelper.getGuid() & GraphHelper.getStatus() causes overhead when called 
> multiple times in a same request.
>  
> *Approach:*
> Implement a caching mechanism in GraphTransactionInterceptor to cache the 
> following mappings:
> *vertexID -> guid*
> *vertexID -> entityStatus*
> *edgeId -> status*



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 72993: Cache getGuid and getStatus in GraphTransactionInterceptor

[Nikhil Bonte]

> On Oct. 28, 2020, 4:11 p.m., Ashutosh Mestry wrote:
> > repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java
> > Line 860 (original), 861 (patched)
> > <https://reviews.apache.org/r/72993/diff/1/?file=2241708#file2241708line861>
> >
> > fyi: Since we use different DI mechanisms in test and regular code, the 
> > annotation does not get applied, because of which the finally block within 
> > _GraphTransactionInterceptor_ does not get called, hence explict call.
> > 
> > The test executes fine since everything happens in same txn.

Thanks for the info & helping out to fix UTs.


- Nikhil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72993/#review222139
-------


On Oct. 29, 2020, 9:34 a.m., Nikhil Bonte wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72993/
> ---
> 
> (Updated Oct. 29, 2020, 9:34 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, madhan, Nixon 
> Rodrigues, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-4008
> https://issues.apache.org/jira/browse/ATLAS-4008
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Problem Statement:
> 
> GraphHelper.getGuid() & GraphHelper.getStatus() causes overhead when called 
> multiple times in a same request.
> 
>  
> 
> Approach:
> 
> Implement a caching mechanism in GraphTransactionInterceptor to cache the 
> following mappings:
> 
> vertexID -> guid
> 
> vertexID -> entityStatus
> 
> 
> Diffs
> -
> 
>   repository/src/main/java/org/apache/atlas/GraphTransactionInterceptor.java 
> 57e454a8e 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
> ca46d0fdb 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
>  9360dd3c9 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasComplexAttributesTest.java
>  ad5fa92bd 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java
>  b9cbef1b0 
> 
> 
> Diff: https://reviews.apache.org/r/72993/diff/2/
> 
> 
> Testing
> ---
> 
> PC build : 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/164/console
>  - In progress
> 
> 
> Thanks,
> 
> Nikhil Bonte
> 
>

Re: Review Request 72993: Cache getGuid and getStatus in GraphTransactionInterceptor

[Nikhil Bonte]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72993/
---

(Updated Oct. 29, 2020, 9:34 a.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, madhan, Nixon 
Rodrigues, Sarath Subramanian, and Sidharth Mishra.


Changes
---

Addressed review comments.


Bugs: ATLAS-4008
https://issues.apache.org/jira/browse/ATLAS-4008


Repository: atlas


Description
---

Problem Statement:

GraphHelper.getGuid() & GraphHelper.getStatus() causes overhead when called 
multiple times in a same request.

 

Approach:

Implement a caching mechanism in GraphTransactionInterceptor to cache the 
following mappings:

vertexID -> guid

vertexID -> entityStatus


Diffs (updated)
-

  repository/src/main/java/org/apache/atlas/GraphTransactionInterceptor.java 
57e454a8e 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
ca46d0fdb 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
 9360dd3c9 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasComplexAttributesTest.java
 ad5fa92bd 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java
 b9cbef1b0 


Diff: https://reviews.apache.org/r/72993/diff/2/

Changes: https://reviews.apache.org/r/72993/diff/1-2/


Testing
---

PC build : 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/164/console
 - In progress


Thanks,

Nikhil Bonte

Re: Review Request 72993: Cache getGuid and getStatus in GraphTransactionInterceptor

[Nikhil Bonte]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72993/
---

(Updated Oct. 28, 2020, 1:59 p.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, madhan, Nixon 
Rodrigues, Sarath Subramanian, and Sidharth Mishra.


Bugs: ATLAS-4008
https://issues.apache.org/jira/browse/ATLAS-4008


Repository: atlas


Description
---

Problem Statement:

GraphHelper.getGuid() & GraphHelper.getStatus() causes overhead when called 
multiple times in a same request.

 

Approach:

Implement a caching mechanism in GraphTransactionInterceptor to cache the 
following mappings:

vertexID -> guid

vertexID -> entityStatus


Diffs
-

  repository/src/main/java/org/apache/atlas/GraphTransactionInterceptor.java 
57e454a8e 
  repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
ca46d0fdb 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
 9360dd3c9 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasComplexAttributesTest.java
 ad5fa92bd 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java
 b9cbef1b0 


Diff: https://reviews.apache.org/r/72993/diff/1/


Testing (updated)
---

PC build : 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/164/console
 - In progress


Thanks,

Nikhil Bonte

Re: Review Request 72991: Export/Import: Add Support for BusinessMetadata Attributes

[Nikhil Bonte]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72991/#review222136
---


Ship it!




Ship It!

- Nikhil Bonte


On Oct. 27, 2020, 8:21 p.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72991/
> ---
> 
> (Updated Oct. 27, 2020, 8:21 p.m.)
> 
> 
> Review request for atlas, Nikhil Bonte and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4006 and ATLAS-4007
> https://issues.apache.org/jira/browse/ATLAS-4006
> https://issues.apache.org/jira/browse/ATLAS-4007
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Background**
> Existing implementation does not support export and import of _Business 
> Metadata_ (BM) attributes. 
> 
> **Implementation**
> - Export: Updated existing flow to include detecting BM attributes and adding 
> the types to the exported payload.
> - Import: Updated _TypeAttributeDifference_ to include BM attribute detection 
> and update.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java
>  0491a853a 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportTypeProcessor.java
>  664af9166 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ImportTypeDefProcessor.java
>  b65807742 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/TypeAttributeDifference.java
>  0d78dbe57 
>   
> repository/src/test/java/org/apache/atlas/repository/impexp/TypeAttributeDifferenceTest.java
>  f9b7cd11f 
> 
> 
> Diff: https://reviews.apache.org/r/72991/diff/1/
> 
> 
> Testing
> ---
> 
> **Unit tests**
> New tests added.
> 
> **Functional testing**
> End-to-end tests. (Export-import-export).
> 
> **Pre-commit Build**
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/154/
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Re: Review Request 72991: Export/Import: Add Support for BusinessMetadata Attributes

[Nikhil Bonte]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72991/#review222135
---




repository/src/main/java/org/apache/atlas/repository/impexp/ExportTypeProcessor.java
Lines 124 (patched)
<https://reviews.apache.org/r/72991/#comment311194>

suggestion: rename: 
addBusinessMetadataType -> addBusinessMetadataTypes


- Nikhil Bonte


On Oct. 27, 2020, 8:21 p.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72991/
> ---
> 
> (Updated Oct. 27, 2020, 8:21 p.m.)
> 
> 
> Review request for atlas, Nikhil Bonte and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4006 and ATLAS-4007
> https://issues.apache.org/jira/browse/ATLAS-4006
> https://issues.apache.org/jira/browse/ATLAS-4007
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Background**
> Existing implementation does not support export and import of _Business 
> Metadata_ (BM) attributes. 
> 
> **Implementation**
> - Export: Updated existing flow to include detecting BM attributes and adding 
> the types to the exported payload.
> - Import: Updated _TypeAttributeDifference_ to include BM attribute detection 
> and update.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java
>  0491a853a 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportTypeProcessor.java
>  664af9166 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ImportTypeDefProcessor.java
>  b65807742 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/TypeAttributeDifference.java
>  0d78dbe57 
>   
> repository/src/test/java/org/apache/atlas/repository/impexp/TypeAttributeDifferenceTest.java
>  f9b7cd11f 
> 
> 
> Diff: https://reviews.apache.org/r/72991/diff/1/
> 
> 
> Testing
> ---
> 
> **Unit tests**
> New tests added.
> 
> **Functional testing**
> End-to-end tests. (Export-import-export).
> 
> **Pre-commit Build**
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/154/
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

[jira] [Created] (ATLAS-4008) Cache getGuid and getStatus in GraphTransactionInterceptor

[Nikhil Bonte (Jira)]

Nikhil Bonte created ATLAS-4008:
---

 Summary: Cache getGuid and getStatus in GraphTransactionInterceptor
 Key: ATLAS-4008
 URL: https://issues.apache.org/jira/browse/ATLAS-4008
 Project: Atlas
  Issue Type: Improvement
  Components:  atlas-core
Reporter: Nikhil Bonte
Assignee: Nikhil Bonte


*Problem Statement:*

GraphHelper.getGuid() & GraphHelper.getStatus() causes overhead when called 
multiple times in a same request.

 

*Approach:*

Implement a caching mechanism in GraphTransactionInterceptor to cache the 
following mappings:

*vertexID -> guid*

*vertexID -> entityStatus*



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3953) JSON Files from Export API with "?" char for string with special chars

[Nikhil Bonte (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17205237#comment-17205237
 ] 

Nikhil Bonte commented on ATLAS-3953:
-

+1 for the patch. Thanks [~amestry].

> JSON Files from Export API with "?" char for string with special chars 
> ---
>
> Key: ATLAS-3953
> URL: https://issues.apache.org/jira/browse/ATLAS-3953
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 2.1.0
> Environment: Apache Atlas 2.1.0 embedded HBASE and SOLR
>Reporter: Carlos Alberto Rocha Cardoso
>Assignee: Ashutosh Mestry
>Priority: Major
> Attachments: 9fdc3ad0-46c2-430a-89c4-4a751d31c064.json, 
> ATLAS-3953-Export-ZipSink-Specify-character-endcodin.patch, 
> Asset_Imported.PNG, AtlasServer.PNG, 
> a5c148bf-5ab6-4c49-853e-855842102128.json, atlas_export.zip, path.zip
>
>
> The Export API returns a ZIP file with some JSON files describing Atlas 
> Entities and TypeDefs.
> I am having an issue where some special chars in JSON are being replaced by 
> "?" chars.
> An Entity name like "Distribuição" was exported in JSON file like 
> "Distribui??o". The special chars "çã" was replaced for the "??" chars.
> I tried to change the exported JSON file encoding and the request header for 
> Export API but without success.
> After analyzing the Atlas source code, especially the *splitAndWriteBytes* 
> method of the 
> *[ZipSink|https://github.com/apache/atlas/blob/cc601d7371fae1dbc16b55d1ca84f06b745700dc/repository/src/main/java/org/apache/atlas/repository/impexp/ZipSink.java]
>  class*, I thought if maybe the problem is because the *s.getBytes()* is 
> returning the JSON string to be written to ZIP with another encoding than 
> *UTF-8*, and maybe set the encode like *s.getBytes(StandardCharsets.UTF_8)* 
> could be a solution.
> It's my first contact with the Atlas source code, and I'm not a JAVA 
> programmer, so it's only a guess.
> I saw that it's possible to set the default to encode to the platform or JVM, 
> but how they said in this below discussion, perhaps this doesn't work 
> properly in all situations.
> [https://stackoverflow.com/questions/361975/setting-the-default-java-character-encoding]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3827) UI: Use moment date format instead of default date format.

[Nikhil Bonte (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17197438#comment-17197438
 ] 

Nikhil Bonte commented on ATLAS-3827:
-

+1 for the patch, thanks [~kevalbhatt].

> UI: Use moment date format instead of default date format.
> --
>
> Key: ATLAS-3827
> URL: https://issues.apache.org/jira/browse/ATLAS-3827
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-3827-1.patch, ATLAS-3827.patch, 
> image-2020-09-16-17-11-33-386.png, image-2020-09-16-17-12-04-512.png, 
> new_date_format.png
>
>
>  
> UI configured to use the following date formats:
> {code:java}
>  /MM/DD
>  /MM/DD HH:mm:ss
>  MM/DD/ h:mm A z
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3945) UI: Entity details page, Show N/A for date if date value is 0 or null

[Nikhil Bonte (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17197436#comment-17197436
 ] 

Nikhil Bonte commented on ATLAS-3945:
-

+1 for the patch, thanks [~kevalbhatt].

> UI: Entity details page,  Show N/A for date if date value is 0 or null
> --
>
> Key: ATLAS-3945
> URL: https://issues.apache.org/jira/browse/ATLAS-3945
> Project: Atlas
>  Issue Type: Bug
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-3945.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: [ANNOUNCE] New Committer: Nikhil Bonte

[Nikhil Bonte]

Thanks Madhan.

Thank you Apache Atlas PMC for allowing me to have committer privileges.
I will use them wisely.

Regards
Nikhil P Bonte

On Thu, Sep 17, 2020 at 6:19 AM Madhan Neethiraj  wrote:

> Atlas community,
>
>
>
> Apache Atlas PMC has asked Nikhil Bonte to become a committer and we are
> pleased to announce that he has accepted.
>
>
>
> Welcome Nikhil, great to have you on board.
>
>
>
> On behalf of Apache Atlas PMC,
>
>
>
> Madhan
>

[jira] [Commented] (ATLAS-3932) Upgrade Spring security , libpam4j and jna lib version

[Nikhil Bonte (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190094#comment-17190094
 ] 

Nikhil Bonte commented on ATLAS-3932:
-

+1 for the patch.

Thanks [~nixon].

> Upgrade Spring security , libpam4j and jna lib version
> --
>
> Key: ATLAS-3932
> URL: https://issues.apache.org/jira/browse/ATLAS-3932
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 2.1.0
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: 
> 0001-ATLAS-3932-Upgrade-jna-spring.security-and-libpam4j-.patch
>
>
> Upgrade jna lib version from 4.1.0 to 5.2.0
> Upgrade libpam4j lib version from 1.8 to 1.11
> and Upgrade Spring security  version from 4.2.16.RELEASE to  4.2.17.RELEASE



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3913) Swagger documentation for APIs

[Nikhil Bonte (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nikhil Bonte updated ATLAS-3913:

Description: 
Current packaging does not package swagger ui into Atlas war.

This change will pack swagger ui into the war file.

Also update enunciate version from 2.11.1 to 2.13.1

  was:
Current packaging does not package swagger ui into Atlas war.

This change will pack swagger ui into war.

Also update enunciate version from 2.11.1 to 2.13.1


> Swagger documentation for APIs
> --
>
> Key: ATLAS-3913
> URL: https://issues.apache.org/jira/browse/ATLAS-3913
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core, atlas-webui
>    Reporter: Nikhil Bonte
>Assignee: Nikhil Bonte
>Priority: Major
>
> Current packaging does not package swagger ui into Atlas war.
> This change will pack swagger ui into the war file.
> Also update enunciate version from 2.11.1 to 2.13.1



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (ATLAS-3913) Swagger documentation for APIs

[Nikhil Bonte (Jira)]

Nikhil Bonte created ATLAS-3913:
---

 Summary: Swagger documentation for APIs
 Key: ATLAS-3913
 URL: https://issues.apache.org/jira/browse/ATLAS-3913
 Project: Atlas
  Issue Type: Bug
  Components:  atlas-core, atlas-webui
Reporter: Nikhil Bonte
Assignee: Nikhil Bonte


Enunciate does not package swagger ui into Atlas war.

This change will pack swagger ui into war.

Also update enunciate version from 2.11.1 to 2.13.1



--
This message was sent by Atlassian Jira
(v8.3.4#803005)