----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73258/#review222825 -----------------------------------------------------------
Started a pre-commit - https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/497/ - Nikhil Bonte On March 29, 2021, 11:29 p.m., Deep Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73258/ > ----------------------------------------------------------- > > (Updated March 29, 2021, 11:29 p.m.) > > > Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath > Subramanian. > > > Bugs: ATLAS-4195 > https://issues.apache.org/jira/browse/ATLAS-4195 > > > Repository: atlas > > > Description > ------- > > When columns for certain table are deleted or replaced, in graph we mark the > table relationship with columns(replaced or deleted) as inactive. When shuch > a table's definition is sent by Hivehook in some event(may be as refered > entity), an update audit is created for the table (irrespective of > differential audit feature being enableld or disabled). > > This is because in entity comparator, where we compare relationships of > stored entity with the relationships of incoming refered table entity, we do > not ignore the inactive relationships of stored entity. This was because > mapVertexToArray method of EntityGraphRetriever did not have the capability > to ignore AtlasEdges having inactive status. > > > Diffs > ----- > > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityComparator.java > d962385c2 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java > 8208d11c2 > > > Diff: https://reviews.apache.org/r/73258/diff/1/ > > > Testing > ------- > > Manual testing was done. > > > Thanks, > > Deep Singh > >
