Review Request 61980: ATLAS-2087: Allow Atlas server to bind on a specific address

2017-08-29 Thread Richard Ding via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61980/ --- Review request for atlas, David Radley, Madhan Neethiraj, and Sarath

Re: Review Request 61561: ATLAS-1218: Atlas says it is started but does not accept REST requests

2017-08-25 Thread Richard Ding via Review Board
> On Aug. 25, 2017, 9:55 a.m., Nigel Jones wrote: > > distro/src/bin/atlas_start.py > > Lines 134 (patched) > > > > > > I notice we have a hardcoded max time of 5 minutes. I wonder if there's > > any scenarios

Re: Review Request 61871: ATLAS-2083: Refactor AtlasDefStore classes to reduce code duplication

2017-08-25 Thread Richard Ding via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61871/ --- (Updated Aug. 25, 2017, 6:44 p.m.) Review request for atlas, Apoorv Naik,

Review Request 61871: ATLAS-2083: Refactor AtlasDefStore classes to reduce code duplication

2017-08-23 Thread Richard Ding via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61871/ --- Review request for atlas, Apoorv Naik, David Radley, Madhan Neethiraj, and

Review Request 61795: ATLAS-2060: Fix logger class name typos

2017-08-21 Thread Richard Ding via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61795/ --- Review request for atlas, David Radley and Madhan Neethiraj. Bugs: ATLAS-2060

Review Request 61794: ATLAS-2076: Add RELATIONSHIP type to search filters

2017-08-21 Thread Richard Ding via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61794/ --- Review request for atlas, David Radley, Madhan Neethiraj, and Sarath

Re: Review Request 61561: ATLAS-1218: Atlas says it is started but does not accept REST requests

2017-08-16 Thread Richard Ding via Review Board
> On Aug. 16, 2017, 9:22 a.m., David Radley wrote: > > distro/src/bin/atlas_start.py > > Lines 134 (patched) > > > > > > You are passing an empty string as the message. I suggest removing this > > parameter and

Re: Review Request 61561: ATLAS-1218: Atlas says it is started but does not accept REST requests

2017-08-16 Thread Richard Ding via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61561/ --- (Updated Aug. 16, 2017, 11:15 p.m.) Review request for atlas, David Radley,

Re: Review Request 61561: ATLAS-1218: Atlas says it is started but does not accept REST requests

2017-08-16 Thread Richard Ding via Review Board
> On Aug. 11, 2017, 11:11 a.m., David Radley wrote: > > distro/src/bin/atlas_config.py > > Lines 71 (patched) > > > > > > I am uncomfortable duplicating the default port values here. I suggest > > moving this logic

Re: Review Request 61561: ATLAS-1218: Atlas says it is started but does not accept REST requests

2017-08-14 Thread Richard Ding via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61561/ --- (Updated Aug. 14, 2017, 11:19 p.m.) Review request for atlas, David Radley,

Re: Review Request 61561: ATLAS-1218: Atlas says it is started but does not accept REST requests

2017-08-14 Thread Richard Ding via Review Board
> On Aug. 11, 2017, 11:11 a.m., David Radley wrote: > > distro/src/bin/atlas_config.py > > Lines 71 (patched) > > > > > > I am uncomfortable duplicating the default port values here. I suggest > > moving this logic

Re: Review Request 61568: ATLAS-2003: Add Javadoc format to class summaries

2017-08-11 Thread Richard Ding via Review Board
> On Aug. 11, 2017, 9:22 a.m., David Radley wrote: > > common/src/main/java/org/apache/atlas/security/InMemoryJAASConfiguration.java > > Lines 54 (patched) > > > > > > Hi Richard, this looks good - please could you

Review Request 61568: ATLAS-2003: Add Javadoc format to class summaries

2017-08-10 Thread Richard Ding via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61568/ --- Review request for atlas, David Radley, Madhan Neethiraj, and Sarath

Review Request 61567: ATLAS-2004: Move Apache license header to the beginning of file

2017-08-10 Thread Richard Ding via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61567/ --- Review request for atlas and Nixon Rodrigues. Bugs: ATLAS-2004

Review Request 61566: ATLAS-1867: org.apache.atlas.AtlasClientV2.deleteAtlasTypeDefs gives an exception

2017-08-10 Thread Richard Ding via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61566/ --- Review request for atlas, David Radley, Madhan Neethiraj, and Sarath

Review Request 61561: ATLAS-1218: Atlas says it is started but does not accept REST requests

2017-08-10 Thread Richard Ding via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61561/ --- Review request for atlas, David Radley, Madhan Neethiraj, and Sarath