Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 23, 2018, 1:03 p.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSRepositoryConnector.java > > Lines 115 (patched) > > > > > > should here be > >

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 23, 2018, 1:21 p.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/AttributeDef.java > > Line 23 (original), 23 (patched) > > > > > > attribute can also

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 23, 2018, 1:39 p.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDefPatch.java > > Lines 49 (patched) > > > > > > if the user wants to user create a

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review195998 --- omrs/src/main/java/org/apache/atlas/omrs/localrepository/reposito

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review195997 --- omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/prope

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review195989 --- omrs/src/main/java/org/apache/atlas/omrs/localrepository/reposito

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 23, 2018, noon, Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/localrepository/repositoryconnector/LocalOMRSConnectorProvider.java > > Lines 192 (patched) > > > > > > this function already exist

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review195986 --- omrs/src/main/java/org/apache/atlas/omrs/enterprise/repositorycon

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review195903 --- omrs/src/main/java/org/apache/atlas/omrs/enterprise/connectormana

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review195896 --- omrs/src/main/java/org/apache/atlas/omrs/enterprise/connectormana

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 19, 2018, 3:28 p.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDef.java > > Line 91 (original), 86 (patched) > > > > > > based on the comments fo

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 19, 2018, 3:28 p.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDef.java > > Line 45 (original), 45 (patched) > > > > > > can you add java doc for

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 19, 2018, 3:28 p.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDef.java > > Line 91 (original), 86 (patched) > > > > > > based on the comments fo

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 19, 2018, 3:28 p.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDef.java > > Line 56 (original), 51 (patched) > > > > > > should change to "Typica

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 19, 2018, 3:28 p.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDef.java > > Line 40 (original), 40 (patched) > > > > > > can you add java doc for

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 19, 2018, 3:28 p.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDef.java > > Line 45 (original), 45 (patched) > > > > > > can you add java doc for

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 19, 2018, 3:28 p.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDef.java > > Line 91 (original), 86 (patched) > > > > > > based on the comments fo

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 19, 2018, 3:28 p.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/TypeDef.java > > Line 45 (original), 45 (patched) > > > > > > can you add java doc for

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review195822 --- omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/prope

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 17, 2018, 11:38 a.m., David Radley wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/PrimitiveDefCategory.java > > Lines 41 (patched) > > > > > > Do we need Character

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 18, 2018, 1:45 p.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/repositoryconnector/OMRSConnection.java > > Lines 33 (patched) > > > > > > why do we also need below > >

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 19, 2018, 9:27 a.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/repositoryconnector/OMRSRepositoryConnector.java > > Lines 66 (patched) > > > > > > is it possible to change

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 19, 2018, 2:54 p.m., David Radley wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/PrimitivePropertyValue.java > > Lines 102 (patched) > > > > > > I suggest we use

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 19, 2018, 9:27 a.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/repositoryconnector/OMRSRepositoryConnector.java > > Lines 66 (patched) > > > > > > is it possible to change

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 18, 2018, 1:45 p.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/repositoryconnector/OMRSConnection.java > > Lines 33 (patched) > > > > > > why do we also need below > >

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review195818 --- omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/prope

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 17, 2018, 11:38 a.m., David Radley wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/RelationshipCategory.java > > Lines 28 (patched) > > > > > > I suggest adding a c

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review195808 --- omrs/src/main/java/org/apache/atlas/omrs/enterprise/repositorycon

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 17, 2018, 11:38 a.m., David Radley wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/OMRSMetadataHighwayManager.java > > Lines 47 (patched) > > > > > > I am wondering whether the cohort man

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 17, 2018, 11:38 a.m., David Radley wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/OMRSCohortManager.java > > Lines 111 (patched) > > > > > > I wonder whether it would be better to set t

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 17, 2018, 11:38 a.m., David Radley wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatahighway/CohortConnectionStatus.java > > Lines 38 (patched) > > > > > > Presumably the cohort could just be disco

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 18, 2018, 1:45 p.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/repositoryconnector/OMRSConnection.java > > Lines 33 (patched) > > > > > > why do we also need below > >

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 19, 2018, 8:54 a.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/enterprise/repositoryconnector/EnterpriseOMRSConnectorProperties.java > > Lines 24 (patched) > > > > > > should you add java do

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 19, 2018, 8:54 a.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/enterprise/repositoryconnector/EnterpriseOMRSConnectorProperties.java > > Lines 30 (patched) > > > > > > do we have to call sup

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 19, 2018, 8:54 a.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/enterprise/repositoryconnector/EnterpriseOMRSRepositoryConnector.java > > Lines 43 (patched) > > > > > > not necessary to imple

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 19, 2018, 9:27 a.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/repositoryconnector/OMRSRepositoryConnector.java > > Lines 31 (patched) > > > > > > in ConnectorBase we alre

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 19, 2018, 9:27 a.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/repositoryconnector/OMRSRepositoryConnector.java > > Lines 66 (patched) > > > > > > is it possible to change

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review195794 --- omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/repos

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review195728 --- omrs/src/main/java/org/apache/atlas/omrs/enterprise/repositorycon

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review195709 --- omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/repos

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Jan. 17, 2018, 11:38 a.m., David Radley wrote: > > omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMetadataExchangeRule.java > > Lines 36 (patched) > > > > > > I am not sure what we mean here by loc

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review195417 --- omrs/src/main/java/org/apache/atlas/omrs/admin/properties/OpenMet

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review195326 --- omrs/pom.xml Lines 55 (patched)

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Nov. 20, 2017, 11:52 a.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/RelationshipCategory.java > > Lines 43 (patched) > > > > > > the javadoc in > > [https

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Nov. 16, 2017, 3:39 p.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/MatchCriteria.java > > Lines 32 (patched) > > > > > > in the javadoc in > > [https://issues.apac

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Nov. 17, 2017, 10:36 a.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/connectors/igc/IGCOMRSConnectorProvider.java > > Lines 24 (patched) > > > > > > the header should be the explanation of IGCOMR

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Nov. 16, 2017, 3:12 p.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/EntitySummaries.java > > Lines 45 (patched) > > > > > > is that also necessary to offer

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Nov. 16, 2017, 2:52 p.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceIterator.java > > Lines 67 (patched) > > > > > > is that necessary to set start

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/ --- (Updated Jan. 12, 2018, 1:35 p.m.) Review request for atlas, David Radley and M

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Nov. 20, 2017, 2:02 p.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/InstanceStatus.java > > Lines 24 (patched) > > > > > > I do not fully understand the me

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Nov. 29, 2017, 4:01 p.m., David Radley wrote: > > omrs/pom.xml > > Lines 42 (patched) > > > > > > This project does not resolve for me - where do I get hold of this > > dependant project? > > Mandy Chessell wro

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Nov. 15, 2017, 4:10 p.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/MetadataCollection.java > > Lines 107 (patched) > > > > > > in the wiki page [OMRS connector > > API](http

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Nov. 16, 2017, 3:06 p.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/Classifications.java > > Lines 46 (patched) > > > > > > in Relationships and EntityDeta

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review193898 --- omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/prope

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Nov. 29, 2017, 4:01 p.m., David Radley wrote: > > omrs/pom.xml > > Lines 42 (patched) > > > > > > This project does not resolve for me - where do I get hold of this > > dependant project? I assume you know this

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review192122 --- omrs/pom.xml Lines 42 (patched)

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Nov. 20, 2017, 11:43 a.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/typedefs/EnumDefs.java > > Lines 33 (patched) > > > > > > in the > > [https://issues.apache.org

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review191730 --- omrs/src/main/java/org/apache/atlas/omrs/connectors/OMRSConnectio

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review191508 --- omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/prope

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review191507 --- omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/Metad

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review191506 --- omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/prope

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review191504 --- omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/prope

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review191500 --- omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/prope

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review191499 --- omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/prope

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review191491 --- omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/prope

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review191329 --- omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/prope

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review191327 --- omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/prope

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review191313 --- omrs/src/main/java/org/apache/atlas/omrs/connectors/igc/IGCOMRSCo

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review191190 --- omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/prope

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review191188 --- omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/Metad

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review191186 --- omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/prope

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review191185 --- omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/prope

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review191184 --- omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/prope

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review191183 --- omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/prope

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review191182 --- omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/prope

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review191072 --- omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/Metad

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Nov. 15, 2017, 2:23 p.m., Yao Li wrote: > > omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/properties/instances/ArrayPropertyValue.java > > Lines 67 (patched) > > > > > > In MapProperyValue, you use

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review191062 --- omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/prope

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review191061 --- omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/prope

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review191058 --- omrs/src/main/java/org/apache/atlas/omrs/metadatacollection/prope

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review191054 --- omrs/src/main/java/org/apache/atlas/omrs/connectors/OMRSConnectio

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/ --- (Updated Nov. 10, 2017, 1:43 p.m.) Review request for atlas, David Radley and M

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/ --- (Updated Nov. 10, 2017, 1:39 p.m.) Review request for atlas, David Radley and M

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Nov. 3, 2017, 9:02 a.m., Nigel Jones wrote: > > omrs/src/main/java/org/apache/atlas/omrs/ffdc/RelationshipNotDeletedException.java > > Lines 25 (patched) > > > > > > Minor/naming -- We have an exception TypeDefIn

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Nov. 3, 2017, 9:02 a.m., Nigel Jones wrote: > > omrs/pom.xml > > Lines 26 (patched) > > > > > > The parent pom doesn't specify this module. I presume this is due to > > the omrs code not being ready yet ie inten

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

> On Nov. 3, 2017, 9:02 a.m., Nigel Jones wrote: > > om-fwk-gaf/src/main/java/org/apache/atlas/gaf/ffdc/README.md > > Lines 19 (patched) > > > > > > I presume this is part of the changes not ready for review? (given a

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/#review190017 --- om-fwk-gaf/src/main/java/org/apache/atlas/gaf/ffdc/README.md Line

Re: Review Request 63502: ATLAS-2246 - Review request for the OMRS Connector API.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63502/ --- (Updated Nov. 2, 2017, 12:03 p.m.) Review request for atlas, David Radley and M

<    1   2