Re: Review Request 73181: ATLAS-4146 [Atlas: Glossary] On updating the related terms, UI allows the user to add the already added term

2021-02-16 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73181/#review222599
---


Ship it!




Ship It!

- Sarath Subramanian


On Feb. 10, 2021, 5 a.m., Mandar Ambawane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73181/
> ---
> 
> (Updated Feb. 10, 2021, 5 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
> Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4146
> https://issues.apache.org/jira/browse/ATLAS-4146
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch checks whether any duplicate Related Glossary Terms present in the 
> payload sent by UI for Update operation.
> 
> This check is done for all the GlossaryTerm Relations.
> 
> If duplicate entry is found then Exception is thrown.
> 
> 
> Diffs
> -
> 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 
> 82243e2 
> 
> 
> Diff: https://reviews.apache.org/r/73181/diff/1/
> 
> 
> Testing
> ---
> 
> Manual Testing is done
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>

Re: Review Request 73181: ATLAS-4146 [Atlas: Glossary] On updating the related terms, UI allows the user to add the already added term

2021-02-12 Thread Mandar Ambawane 


> On Feb. 10, 2021, 7:44 p.m., Sarath Subramanian wrote:
> > repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
> > Lines 1055 (patched)
> > 
> >
> > why qualifiedName needs to be sent back? if 'duplicateTermHeaders' has 
> > any value then this confirms the terms are duplicated? Please review.

Yes Sarath, if 'duplicateTermHeaders' has any value then this confirms the 
terms are duplicated.

Here, I am sending back First-Found Duplicate Term's QualifiedName. And 
including this QualifiedName in the Error Response.

I am using this QualifiedName as a flag to throw an Exception.


- Mandar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73181/#review222584
---


On Feb. 10, 2021, 1 p.m., Mandar Ambawane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73181/
> ---
> 
> (Updated Feb. 10, 2021, 1 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
> Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4146
> https://issues.apache.org/jira/browse/ATLAS-4146
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch checks whether any duplicate Related Glossary Terms present in the 
> payload sent by UI for Update operation.
> 
> This check is done for all the GlossaryTerm Relations.
> 
> If duplicate entry is found then Exception is thrown.
> 
> 
> Diffs
> -
> 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 
> 82243e2 
> 
> 
> Diff: https://reviews.apache.org/r/73181/diff/1/
> 
> 
> Testing
> ---
> 
> Manual Testing is done
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>

Re: Review Request 73181: ATLAS-4146 [Atlas: Glossary] On updating the related terms, UI allows the user to add the already added term

2021-02-12 Thread Mandar Ambawane 


> On Feb. 10, 2021, 7:42 p.m., Sarath Subramanian wrote:
> > Mandar, this check should be handled from UI side - not to allow saving an 
> > already assigned 'Term'.

Yes Sarath, I have already asked UI team to handle this from UI end.

If user uses curl command to update Glossary Terms, Server side validation is 
added to handle such scenario.


- Mandar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73181/#review222583
---


On Feb. 10, 2021, 1 p.m., Mandar Ambawane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73181/
> ---
> 
> (Updated Feb. 10, 2021, 1 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
> Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4146
> https://issues.apache.org/jira/browse/ATLAS-4146
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch checks whether any duplicate Related Glossary Terms present in the 
> payload sent by UI for Update operation.
> 
> This check is done for all the GlossaryTerm Relations.
> 
> If duplicate entry is found then Exception is thrown.
> 
> 
> Diffs
> -
> 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 
> 82243e2 
> 
> 
> Diff: https://reviews.apache.org/r/73181/diff/1/
> 
> 
> Testing
> ---
> 
> Manual Testing is done
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>

Re: Review Request 73181: ATLAS-4146 [Atlas: Glossary] On updating the related terms, UI allows the user to add the already added term

2021-02-10 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73181/#review222584
---




repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
Lines 1055 (patched)


why qualifiedName needs to be sent back? if 'duplicateTermHeaders' has any 
value then this confirms the terms are duplicated? Please review.


- Sarath Subramanian


On Feb. 10, 2021, 5 a.m., Mandar Ambawane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73181/
> ---
> 
> (Updated Feb. 10, 2021, 5 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
> Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4146
> https://issues.apache.org/jira/browse/ATLAS-4146
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch checks whether any duplicate Related Glossary Terms present in the 
> payload sent by UI for Update operation.
> 
> This check is done for all the GlossaryTerm Relations.
> 
> If duplicate entry is found then Exception is thrown.
> 
> 
> Diffs
> -
> 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 
> 82243e2 
> 
> 
> Diff: https://reviews.apache.org/r/73181/diff/1/
> 
> 
> Testing
> ---
> 
> Manual Testing is done
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>

Re: Review Request 73181: ATLAS-4146 [Atlas: Glossary] On updating the related terms, UI allows the user to add the already added term

2021-02-10 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73181/#review222583
---



Mandar, this check should be handled from UI side - not to allow saving an 
already assigned 'Term'.

- Sarath Subramanian


On Feb. 10, 2021, 5 a.m., Mandar Ambawane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73181/
> ---
> 
> (Updated Feb. 10, 2021, 5 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
> Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4146
> https://issues.apache.org/jira/browse/ATLAS-4146
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch checks whether any duplicate Related Glossary Terms present in the 
> payload sent by UI for Update operation.
> 
> This check is done for all the GlossaryTerm Relations.
> 
> If duplicate entry is found then Exception is thrown.
> 
> 
> Diffs
> -
> 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 
> 82243e2 
> 
> 
> Diff: https://reviews.apache.org/r/73181/diff/1/
> 
> 
> Testing
> ---
> 
> Manual Testing is done
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>

Review Request 73181: ATLAS-4146 [Atlas: Glossary] On updating the related terms, UI allows the user to add the already added term

2021-02-10 Thread Mandar Ambawane 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73181/
---

Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
Nixon Rodrigues, and Sarath Subramanian.


Bugs: ATLAS-4146
https://issues.apache.org/jira/browse/ATLAS-4146


Repository: atlas


Description
---

This patch checks whether any duplicate Related Glossary Terms present in the 
payload sent by UI for Update operation.

This check is done for all the GlossaryTerm Relations.

If duplicate entry is found then Exception is thrown.


Diffs
-

  repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 
82243e2 


Diff: https://reviews.apache.org/r/73181/diff/1/


Testing
---

Manual Testing is done


Thanks,

Mandar Ambawane