Re: Review Request 65123: ATLAS-2298 - Review of OCF Database Connector

2018-03-22 Thread Yao Li
> On Jan. 18, 2018, 12:16 p.m., Graham Wallis wrote: > > jdbc/connectors/gaian/GaianJDBCConnector.java > > Lines 21 (patched) > > > > > > I would think that host, port, database name, user and password should > >

Re: Review Request 65123: ATLAS-2298 - Review of OCF Database Connector

2018-01-31 Thread Yao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65123/ --- (Updated Jan. 31, 2018, 12:08 p.m.) Review request for atlas and Mandy

Re: Review Request 65123: ATLAS-2298 - Review of OCF Database Connector

2018-01-30 Thread Yao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65123/ --- (Updated Jan. 30, 2018, 3:29 p.m.) Review request for atlas and Mandy

Re: Review Request 65123: ATLAS-2298 - Review of OCF Database Connector

2018-01-30 Thread Yao Li
> On Jan. 18, 2018, 12:16 p.m., Graham Wallis wrote: > > jdbc/connectors/gaian/GaianJDBCConnector.java > > Lines 186 (patched) > > > > > > There are ways to dynamically get the name of the enclosing method - > >

Re: Review Request 65123: ATLAS-2298 - Review of OCF Database Connector

2018-01-30 Thread Yao Li
> On Jan. 18, 2018, 12:16 p.m., Graham Wallis wrote: > > jdbc/connectors/JDBCConnection.java > > Lines 84 (patched) > > > > > > Is it deliberate that we are testing the super-class attribute? > > Yao Li wrote: >

Re: Review Request 65123: ATLAS-2298 - Review of OCF Database Connector

2018-01-29 Thread Yao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65123/ --- (Updated Jan. 29, 2018, 3:58 p.m.) Review request for atlas and Mandy

Re: Review Request 65123: ATLAS-2298 - Review of OCF Database Connector

2018-01-29 Thread Yao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65123/ --- (Updated Jan. 29, 2018, 3:53 p.m.) Review request for atlas and Mandy

Re: Review Request 65123: ATLAS-2298 - Review of OCF Database Connector

2018-01-29 Thread Yao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65123/ --- (Updated Jan. 29, 2018, 3:47 p.m.) Review request for atlas and Mandy

Re: Review Request 65123: ATLAS-2298 - Review of OCF Database Connector

2018-01-29 Thread Yao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65123/ --- (Updated Jan. 29, 2018, 3:45 p.m.) Review request for atlas and Mandy